Something similar to inotify in 2.4.

2007-11-29 Thread Vitaliy Ivanov
Hi all, Can anyone advice whether there is something similar to inotify in 2.4 kernel? Need efficient way to track file system changes. Maybe some other tools, approaches under 2.4? TIA, Vitaliy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message t

Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-11-05 Thread Vitaliy Ivanov
Willy, On 11/4/07, Willy Tarreau <[EMAIL PROTECTED]> wrote: > I'm planning on issuing a new 2.4.36 prerelease soon. Have you made any > progress on your code after Pete's recommendations ? Yep. We just finalized 2.6 changes and now I'm working on 2.4 version. Will get back to you all soon. When a

Re: fixing usb-midi device support

2007-11-01 Thread Vitaliy Ivanov
David, On 10/31/07, David Griffith <[EMAIL PROTECTED]> wrote: > > I have a MOTU Fastlane and an Emu Xmidi 2x2 USB midi interfaces. The Emu > unit works fine with current kernels. The MOTU unit won't work with > kernels newer than 2.6.17. I stumbled over a patch that had something to > do with a

Re: USB: FIx locks and urb->status in adutux

2007-11-01 Thread Vitaliy Ivanov
On Thu, 2007-11-01 at 00:01, Pete Zaitcev wrote: > Sorry about that. I'll try to be more explicit in the future. OK, got it. Thanks. > > I just tried the latest patch and all seems to be good. > > BTW, slab corruption issue that I saw on the original driver we started > > fixing on is not an is

Re: USB: FIx locks and urb->status in adutux

2007-10-31 Thread Vitaliy Ivanov
On Tue, 2007-10-30 at 23:54, Pete Zaitcev wrote: > One other small thing. I see you dropped the dev->mtx bracket that > I added around the initialization and submission. Notice that the > dev->udev is zeroed under dev->mtx, not the static lock. This is because > it has to be seen in read and write

Re: 2.6.24-rc1: usb problem?

2007-10-30 Thread Vitaliy Ivanov
On 10/30/07, Oliver Neukum <[EMAIL PROTECTED]> wrote: > Am Dienstag 30 Oktober 2007 schrieb Harald Dunkel: > > Is this anything to worry about? Please mail if I can help to track this > > down. > > This is a known problem. A fix is in the queue. Here is original thread: http://lkml.org/lkml/2007/1

Re: USB: FIx locks and urb->status in adutux

2007-10-30 Thread Vitaliy Ivanov
On Tue, 2007-10-30 at 06:24, Pete Zaitcev wrote: > However, this looks wrong: > > > +dev->interrupt_in_endpoint->bInterval); > > + dev->read_urb_finished = 0; > > + retval = usb_submit_urb(dev->interrupt_in_urb, GFP_KERNEL); > > + /* we ignore failure */ > > + /* end o

Re: USB: FIx locks and urb->status in adutux

2007-10-29 Thread Vitaliy Ivanov
freed). - Fix indentation in adu_write. Looks like it was damaged by a script. - Remove sleep_on. Here is the final patch. Comments are welcomed. -- Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]> Signed-off-by: Vitaliy Ivanov <[EMAIL PROTECTED]> Tested-by: Vitaliy Ivanov &l

Re: USB: FIx locks and urb->status in adutux

2007-10-26 Thread Vitaliy Ivanov
Greg, On 10/25/07, Greg KH <[EMAIL PROTECTED]> wrote: > Hm, I think I'll wait for Pete and you to agree and send me a final > version before applying anything here :) I'm testing the final patch Pete created with all the notes. Will let you know if there are issues with it. If not it can be appli

Re: USB: FIx locks and urb->status in adutux

2007-10-24 Thread Vitaliy Ivanov
Pete, On Wed, 2007-10-24 at 04:53, Pete Zaitcev wrote: 1) > +/* > + * The locking scheme is a vanilla 3-lock: > + * adu_device.buflock: A spinlock, covers what IRQs touch. > + * adutux_mutex: A Static lock to cover open_count. It would also > cover > + * any globa

Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-10-19 Thread Vitaliy Ivanov
> > Didn't here anything on this? What is our final decision here? > > It's gotten worse, not better. Apparently, you aren't getting the > concept of protecting the open count with a static lock and my > explanations are just not vivid enough or something. So I decided > to fix it myself. Maybe t

Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-10-19 Thread Vitaliy Ivanov
On 10/17/07, Vitaliy Ivanov <[EMAIL PROTECTED]> wrote: > Willy & Pete, > > On Tue, 2007-10-16 at 21:24, Vitaliy Ivanov wrote: > > Following Pete notes I will rework code and give it for review once again. > > As I said it's usb-skeleton approach that I reused d

Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-10-17 Thread Vitaliy Ivanov
Willy & Pete, On Tue, 2007-10-16 at 21:24, Vitaliy Ivanov wrote: > Following Pete notes I will rework code and give it for review once again. > As I said it's usb-skeleton approach that I reused during the port. > > Anyway, will get back to this soon. Reworked code a litt

Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-10-16 Thread Vitaliy Ivanov
On Tue, 2007-10-16 at 18:41, Willy Tarreau wrote: > OK, I have no objection, but please apply the fixes the le16 problem as > suggested by Pete and Greg first. Also, you will probably receive more > comments, and/or criticisms from further reviews. This is normal and > expected. You just have to f

Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-10-16 Thread Vitaliy Ivanov
On Tue, 2007-10-16 at 20:56, Pete Zaitcev wrote: > On Tue, 16 Oct 2007 17:41:38 +0200, Willy Tarreau <[EMAIL PROTECTED]> wrote: > > > OK, I have no objection, but please apply the fixes the le16 problem as > > suggested by Pete and Greg first. Also, you will probably receive more > > comments, and

Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-10-16 Thread Vitaliy Ivanov
e adutux driver exposes standard open/close/read/write API's to the user application. Signed-off-by: Vitaliy Ivanov <[EMAIL PROTECTED]> Tested-by: Vitaliy Ivanov <[EMAIL PROTECTED]> -- diff -uprN -X dontdiff KERNELS/linux-2.4.35.3/Documentation/Configure.help linux-2.4.3

Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-10-16 Thread Vitaliy Ivanov
Pete, On Mon, 2007-10-15 at 20:30, Pete Zaitcev wrote: > > + in_end_size = le16_to_cpu(dev->interrupt_in_endpoint->wMaxPacketSize); > > + out_end_size = le16_to_cpu(dev->interrupt_out_endpoint->wMaxPacketSize); > > Did you verify if this works? We use pre-swapped descriptors in 2.4. > I susp

Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-10-15 Thread Vitaliy Ivanov
Pete, On 10/15/07, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > On Sun, 14 Oct 2007 23:45:36 +0300, "Vitaliy Ivanov" <[EMAIL PROTECTED]> > wrote: > > > Also IMHO the more drivers are in the tree the more users will use it. > > Once it will be merged in

Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-10-14 Thread Vitaliy Ivanov
Willy, On 10/14/07, Willy Tarreau <[EMAIL PROTECTED]> wrote: > Hello Vitaliy, > > On Sun, Oct 14, 2007 at 08:37:25PM +0300, Vitaliy Ivanov wrote: > > Hello Willy, Greg and list, > > > > I have ported adutux driver for ADU series device list from 2.6 to 2

[2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-10-14 Thread Vitaliy Ivanov
b-skeleton. Patch is based on the latest 2.4.35.3. Performed a lot of tests but only under UHCI controller and ADU200 and all seems to be OK. I would like someone to perform code review as it's my first attempt to the kernel programming. Any comments, propositions are welcome. Signed-off-b

Re: Driver question: multiple instances of same char device

2007-07-10 Thread Vitaliy Ivanov
On 7/10/07, Jon Dufresne <[EMAIL PROTECTED]> wrote: I am relatively new to linux device development. And want to understand Linux conventions. Suppose I have a PCI card that is represented in the system by a character device. If I have two of those PCI cards in the system when the driver module

Re: USB adutux device number

2007-05-15 Thread Vitaliy Ivanov
Did any of USB fellows has a chance to look at this issue? It can be critical to customers as this 67 minor number is listed in the driver code only and not all of them going through the code. -- Vitaliy On 5/14/07, Vitaliy Ivanov <[EMAIL PROTECTED]> wrote: Hello, I'm not s

USB adutux device number

2007-05-14 Thread Vitaliy Ivanov
Hello, I'm not sure if it's correct place to deal with the issue. In Documentation/devices.txt there is no info about adutux driver that is included in the kernel: ... 65 = /dev/usb/usblcd USBLCD Interface ([EMAIL PROTECTED]) 66 = /dev/usb/cpad0Synaptics c