Re: [PATCH stable] net: sch_generic: fix the missing new qdisc assignment bug

2020-11-03 Thread Vishwanath Pai
ILTIN)) >  set_bit(__QDISC_STATE_DEACTIVATED, &qdisc->state); > + > +    rcu_assign_pointer(dev_queue->qdisc, qdisc_default); >  } >  } > I have tested the patch on v5.4.71 and it fixes our issues. Tested-by: Vishwanath Pai

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-11-02 Thread Vishwanath Pai
On 11/2/20 4:08 AM, Yunsheng Lin wrote: > On 2020/10/30 1:20, Vishwanath Pai wrote: >> On 10/29/20 6:24 AM, Yunsheng Lin wrote: >>> On 2020/10/29 12:50, Vishwanath Pai wrote: >>>> On 10/28/20 10:37 PM, Yunsheng Lin wrote: >>>>> On 2020/10/29 4:04, Vis

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-10-29 Thread Vishwanath Pai
On 10/29/20 6:24 AM, Yunsheng Lin wrote: > On 2020/10/29 12:50, Vishwanath Pai wrote: >> On 10/28/20 10:37 PM, Yunsheng Lin wrote: >>> On 2020/10/29 4:04, Vishwanath Pai wrote: >>>> On 10/28/20 1:47 PM, Cong Wang wrote: >>>>> On Wed, Oct 28, 2020 a

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-10-29 Thread Vishwanath Pai
On 10/28/20 10:37 PM, Yunsheng Lin wrote: > On 2020/10/29 4:04, Vishwanath Pai wrote: >> On 10/28/20 1:47 PM, Cong Wang wrote: >>> On Wed, Oct 28, 2020 at 8:37 AM Pai, Vishwanath wrote: >>>> Hi, >>>> >>>> We noticed some problems when test

Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-10-28 Thread Vishwanath Pai
On 10/28/20 1:47 PM, Cong Wang wrote: > On Wed, Oct 28, 2020 at 8:37 AM Pai, Vishwanath wrote: >> Hi, >> >> We noticed some problems when testing the latest 5.4 LTS kernel and traced it >> back to this commit using git bisect. When running our tests the machine stops >> responding to all traffi

Re: Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-10-28 Thread Vishwanath Pai
On 9/17/20 3:26 PM, Cong Wang wrote: > On Fri, Sep 11, 2020 at 1:13 AM Yunsheng Lin wrote: >> >> On 2020/9/11 4:07, Cong Wang wrote: >>> On Tue, Sep 8, 2020 at 4:06 AM Yunsheng Lin wrote: Currently there is concurrent reset and enqueue operation for the same lockless qdisc whe

[PATCH v2] netfilter: xt_hashlimit: fix build error caused by 64bit division

2017-09-07 Thread Vishwanath Pai
: bea74641e378 ("netfilter: xt_hashlimit: add rate match mode") Signed-off-by: Vishwanath Pai --- net/netfilter/xt_hashlimit.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c index 10d4823.

[PATCH] netfilter: xt_hashlimit: fix build error caused by 64bit division

2017-09-07 Thread Vishwanath Pai
n cfg_copy(). Fixes: bea74641e378 ("netfilter: xt_hashlimit: add rate match mode") Signed-off-by: Vishwanath Pai --- net/netfilter/xt_hashlimit.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c in

Re: xt_hashlimig build error (was Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label)

2017-09-07 Thread Vishwanath Pai
On 09/07/2017 04:45 PM, Linus Torvalds wrote: > On Thu, Sep 7, 2017 at 1:16 PM, Vishwanath Pai wrote: >> >> Writing U32INT_MAX as 0xULL was a mistake on my part. I could >> have avoided all of this by using built-in constants instead of trying >> to define them

Re: xt_hashlimig build error (was Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label)

2017-09-07 Thread Vishwanath Pai
On 09/07/2017 02:43 PM, Linus Torvalds wrote: > Note: that patch has *exactly* the issue I was talking about above. > > Doing that > > if (user > 0xULL) > return 0; > > is different from the old code, which used to result in a zero in the > divide, and then > > r = (r -

Re: xt_hashlimig build error (was Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label)

2017-09-07 Thread Vishwanath Pai
On 09/07/2017 01:51 PM, Linus Torvalds wrote: > On Thu, Sep 7, 2017 at 3:29 AM, Ingo Molnar wrote: >> >> not the best of kernels, 32-bit allyesconfig doesn't even appear to build: >> >> net/netfilter/xt_hashlimit.o: In function `hashlimit_mt_common.isra.6': >> xt_hashlimit.c:(.text+0x1146): un

Re: [PATCH] netfilter: xt_hashlimit: avoid 64-bit division

2017-09-06 Thread Vishwanath Pai
On 09/06/2017 03:57 PM, Arnd Bergmann wrote: > 64-bit division is expensive on 32-bit architectures, and > requires a special function call to avoid a link error like: > > net/netfilter/xt_hashlimit.o: In function `hashlimit_mt_common': > xt_hashlimit.c:(.text+0x1328): undefined reference to `__ae

Re: [PATCH] netfilter: xt_hashlimit: Add missing ULL suffixes for 64-bit constants

2016-10-06 Thread Vishwanath Pai
; * HZ * CREDITS_PER_JIFFY; > > -- 1.9.1 Thanks for fixing this. Acked-by: Vishwanath Pai

Re: [PATCH 3/3] netfilter: xt_hashlimit: uses div_u64 for division

2016-09-30 Thread Vishwanath Pai
; for the version 1 data to restore the original faster 32-bit division. >> >> With both changes combined, we no longer get a link error. >> >> Fixes: 11d5f15723c9 ("netfilter: xt_hashlimit: Create revision 2 to support >> higher pps rates") >> Signed-

[PATCH v3] netfilter/nflog: nflog-range does not truncate packets (userspace)

2016-06-24 Thread Vishwanath Pai
flag XT_NFLOG_F_COPY_LEN. Also updated the man page to reflect the new option and added tests to extensions/libxt_NFLOG.t Reported-by: Joe Dollard Reviewed-by: Josh Hunt Signed-off-by: Vishwanath Pai diff --git a/extensions/libxt_NFLOG.c b/extensions/libxt_NFLOG.c index f611631..8c67066

[PATCH v2 2/2] netfilter/nflog: nflog-range does not truncate packets (userspace)

2016-06-21 Thread Vishwanath Pai
this. Reported-by: Joe Dollard Reviewed-by: Josh Hunt Signed-off-by: Vishwanath Pai diff --git a/extensions/libxt_NFLOG.c b/extensions/libxt_NFLOG.c index f611631..8c564a2 100644 --- a/extensions/libxt_NFLOG.c +++ b/extensions/libxt_NFLOG.c @@ -12,7 +12,10 @@ enum { O_GROUP = 0

[PATCH v2 1/2] netfilter/nflog: nflog-range does not truncate packets

2016-06-21 Thread Vishwanath Pai
placed by --nflog-size now. --nflog-range would still exist but does not do anything. Reported-by: Joe Dollard Reviewed-by: Josh Hunt Signed-off-by: Vishwanath Pai diff --git a/include/net/netfilter/nf_log.h b/include/net/netfilter/nf_log.h index 57639fc..83d855b 100644 --- a/include/net/net

Re: [PATCH] Fix Kernel Panic in bonding driver debugfs file: rlb_hash_table

2015-04-29 Thread Vishwanath Pai
a >> kernel panic. >> >> The patch applies against both net and net-next >> >> Signed-off-by: Vishwanath Pai >> > Good catch, a few cosmetic nits below. > >> diff --git a/drivers/net/bonding/bond_main.c >> b/drivers/net/bonding/bond_main.c >>