ments.
Signed-off-by: Vinicius Peixoto
Co-developed-by: Enzo Bertoloti
Signed-off-by: Enzo Bertoloti
Co-developed-by: Fabricio Gasperin
Signed-off-by: Fabricio Gasperin
Suggested-by: David Laight
---
This patch was developed during a hackathon organized by LKCAMP [1],
with the objective of wr
On 10/4/24 15:40, kernel test robot wrote:
Hi Vinicius,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 9852d85ec9d492ebef56dc5f229416c925758edc]
url:
https://github.com/intel-lab-lkp/linux/commits/Vinicius-Peixoto/lib-crc16_kunit-c-add-KUnit-tests-for
ments.
Signed-off-by: Vinicius Peixoto
Co-developed-by: Enzo Bertoloti
Signed-off-by: Enzo Bertoloti
Co-developed-by: Fabricio Gasperin
Signed-off-by: Fabricio Gasperin
Suggested-by: David Laight
---
Hi all,
This patch was developed during a hackathon organized by LKCAMP [1],
with the objecti
Hi David,
On 9/25/24 08:26, David Laight wrote:
From: Vinicius Peixoto
Sent: 23 September 2024 00:27
Hi all,
This patch was developed during a hackathon organized by LKCAMP [1],
with the objective of writing KUnit tests, both to introduce people to
the kernel development process and to learn
of crc16 similar to yours (using a loop
instead of a lookup table) to validate the results.
Thanks,
Vinicius
Slow is relative - this code only takes 35ms to crc-64 over 5MB of data.
{
volatile const uint32_t *r = (const void *)buf;
for (crc = 0; r < (const uint32_t *)buf_end; r++)
Hi André,
On 9/24/24 6:33 PM, André Almeida wrote:
Hey!
On 9/23/24 01:26, Vinicius Peixoto wrote:
Hi all,
This patch was developed during a hackathon organized by LKCAMP [1],
with the objective of writing KUnit tests, both to introduce people to
the kernel development process and to learn
mance measurements.
Signed-off-by: Vinicius Peixoto
Co-developed-by: Enzo Bertoloti
Signed-off-by: Enzo Bertoloti
Co-developed-by: Fabricio Gasperin
Signed-off-by: Fabricio Gasperin
---
lib/Kconfig.debug | 8 +
lib/Makefile | 1 +
lib/crc16_kunit.c
randomly-generated test data that we use to validate
the kernel's implementation of CRC-16.
We would really appreciate any feedback/suggestions on how to improve
this. Thanks! :-)
Vinicius Peixoto (1):
lib/crc16_kunit.c: add KUnit tests for crc16
lib/Kconfig.debug | 8 +
lib/Mak
. Thanks in advance!
Vinicius
20200507
>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14eeda2590
>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=161472f590
>>
>> The issue was bisected to:
>>
>> commit 5a781ccbd19e4664babcbe4b4ead7aa2b9283d22
>> Author: Vi
Hi,
All these functions in net/core/dev.c are very similar.
__netdev_walk_all_upper_dev
netdev_walk_all_upper_dev_rcu
netdev_walk_all_lower_dev
__netdev_walk_all_lower_dev
netdev_walk_all_lower_dev_rcu
Can they be merged in one function? Are they a hot path?
Regards,
Vinicius
ot;net: stmmac: Add support for CBS QDISC")
> Suggested-by: Gomes, Vinicius
Just a nitpick/formality, I would prefer if you used:
Suggested-by: Vinicius Costa Gomes
> Signed-off-by: Mohammad Athari Bin Ismail
> Signed-off-by: Song, Yoong Siang
Patch looks good.
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
On Wed, Feb 3, 2021 at 2:39 AM Theodore Ts'o wrote:
>
> On Tue, Feb 02, 2021 at 04:28:37PM +0000, Vinicius Tinti wrote:
> > Clang with -Wunreachable-code-aggressive is being used to try to find
> > unreachable code that could cause potential bugs. There is no plan to
&
check when DX_DEBUG is set. This allows the
function to be used in other parts of the code.
Suggestions from: Andreas, Christoph, Nathan, Nick and Ted.
Signed-off-by: Vinicius Tinti
---
fs/ext4/namei.c | 38 --
1 file changed, 24 insertions(+), 14 deletions(-)
di
On Mon, Feb 1, 2021 at 6:41 PM Nick Desaulniers wrote:
>
> On Mon, Feb 1, 2021 at 1:38 PM Theodore Ts'o wrote:
> >
> > On Mon, Feb 01, 2021 at 01:16:19PM -0800, Nick Desaulniers wrote:
> > > I agree; Vinicius, my recommendation for -Wunreachable-* with Clang
&g
On Mon, Feb 1, 2021 at 2:13 PM Theodore Ts'o wrote:
>
> On Mon, Feb 01, 2021 at 01:15:29PM -0300, Vinicius Tinti wrote:
> > On Mon, Feb 1, 2021 at 9:49 AM Christoph Hellwig wrote:
> > >
> > > DX_DEBUG is completely dead code, so either kill it off or make
On Mon, Feb 1, 2021 at 9:49 AM Christoph Hellwig wrote:
>
> DX_DEBUG is completely dead code, so either kill it off or make it an
> actual CONFIG_* symbol through Kconfig if it seems useful.
About the unreachable code in "if (0)" I think it could be removed.
It seems to be doing an extra check.
// linear search cross check
^
/* DISABLES CODE */ ( )
Signed-off-by: Vinicius Tinti
---
fs/ext4/namei.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index cf652ba3e74d..46
On Sat, Jan 30, 2021 at 9:45 AM Chris Wilson wrote:
>
> Quoting Vinicius Tinti (2021-01-30 12:34:11)
> > On Fri, Jan 29, 2021 at 08:55:54PM +, Chris Wilson wrote:
> > > Quoting Vinicius Tinti (2021-01-29 18:15:19)
> > > > By enabling -Wunreachable-code-aggre
On Fri, Jan 29, 2021 at 08:55:54PM +, Chris Wilson wrote:
> Quoting Vinicius Tinti (2021-01-29 18:15:19)
> > By enabling -Wunreachable-code-aggressive on Clang the following code
> > paths are unreachable.
>
> That code exists as commentary and, especially for sdvo, lib
r search cross check
^
/* DISABLES CODE */ ( )
Signed-off-by: Vinicius Tinti
---
fs/ext4/namei.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index cf652ba3e74d..1f64dbd7237b 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei
dvo.c:696:13: warning: unused function
'intel_sdvo_set_encoder_power_state' [-Wunused-function]
static bool intel_sdvo_set_encoder_power_state(struct intel_sdvo *intel_sdvo,
^
Signed-off-by: Vinicius Tinti
---
drivers/gpu/drm/i915/display/intel_sdvo.c | 30 --
rocess theoretically does not need ETF, just set the skb-> tstamp
>> and use a pass through queue.
>> However the only way now to set TC_SETUP_QDISC_ETF in the driver is using
>> ETF.
>
> Yes, and I'd like to eventually get rid of this constraint.
>
I'm interested in these kind of ideas :-)
What would be your end goal? Something like:
- Any application is able to set SO_TXTIME;
- We would have a best effort support for scheduling packets based on
their transmission time enabled by default;
- If the hardware supports, there would be a "offload" flag that could
be enabled;
More or less this?
Cheers.
--
Vinicius
and NIC power management settings also
effect latency on the order of 10-100s usecs when the system is allowed
to go idle, some things that have helped:
- setting CONFIG_PCIEASPM to performance;
- disabling EEE (energy efficient ethernet) in your NIC;
>
> Search for cpu C-states , and powertop program.
>
Cheers,
--
Vinicius
only
thing that comes to mind is having a timecounter, or similar, "software
view" over the PHC clock).
Anyway, my feeling is that until this is solved, we would only be
working around the problem, and creating even more hard to handle corner
cases.
Cheers,
--
Vinicius
z 20200507
>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=157c7aa590
>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13c92ef990
>>
>> The issue was bisected to:
>>
>> commit 5a781ccbd19e4664babcbe4b4ead7aa2b9283d22
>>
is is just any user.
Yeah, will fix this.
Thanks,
--
Vinicius
en" or "closed".
But again, if I calculate the 'skb->tstamp' of each packet during
enqueue, I don't need the hrtimer. What we have in the txtime-assisted
mode is half way there.
I think this is what you had in mind.
Cheers,
--
Vinicius
Hi,
Dmitry Vyukov writes:
> On Wed, Jul 29, 2020 at 9:13 PM Vinicius Costa Gomes
> wrote:
>>
>> Hi,
>>
>> "Zhang, Qiang" writes:
>>
>> >
>> > 发件人: linux-kernel-ow...@vger.kernel.org
starves other kernel threads.
We could put some limits on the interval when running in software mode,
but I don't like this too much, because we are talking about users with
CAP_NET_ADMIN and they have easier ways to do bad things to the system.
Cheers,
--
Vinicius
Murali Karicheri writes:
> Hi Vinicius,
>
> On 5/21/20 1:31 PM, Vinicius Costa Gomes wrote:
>> Murali Karicheri writes:
>>
> Snip-
>
>>>- prefix all common code with hsr_prp
>>>- net/hsr -> renamed to net/hsr
each stream has its
> own sequence number), and those rules can identify the source, the
> destination, or both the source and the destination.
Same understanding here.
Cheers,
--
Vinicius
100644 net/hsr-prp/hsr_prp_main.c
> create mode 100644 net/hsr-prp/hsr_prp_main.h
> create mode 100644 net/hsr-prp/hsr_prp_netlink.c
> create mode 100644 net/hsr-prp/hsr_prp_netlink.h
> create mode 100644 net/hsr-prp/hsr_prp_slave.c
> create mode 100644 net/hsr-prp/hsr_prp_slave.h
> create mode 100644 net/hsr-prp/prp_netlink.c
> create mode 100644 net/hsr-prp/prp_netlink.h
> delete mode 100644 net/hsr/Kconfig
> delete mode 100644 net/hsr/Makefile
> delete mode 100644 net/hsr/hsr_device.c
> delete mode 100644 net/hsr/hsr_device.h
> delete mode 100644 net/hsr/hsr_forward.c
> delete mode 100644 net/hsr/hsr_framereg.h
> delete mode 100644 net/hsr/hsr_main.c
> delete mode 100644 net/hsr/hsr_main.h
> delete mode 100644 net/hsr/hsr_netlink.c
> delete mode 100644 net/hsr/hsr_slave.c
> delete mode 100644 net/hsr/hsr_slave.h
>
> --
> 2.17.1
>
--
Vinicius
e
> to integrate and test it on AM65x CPSW driver and provide my comments/
> Tested-by:
Understood. Thanks.
--
Vinicius
void *type_data)
> @@ -1363,6 +1411,8 @@ static int vsc9959_port_setup_tc(struct dsa_switch *ds,
> int port,
> switch (type) {
> case TC_SETUP_QDISC_TAPRIO:
> return vsc9959_qos_port_tas_set(ocelot, port, type_data);
> + case TC_SETUP_QDISC_CBS:
> + return vsc9959_qos_port_cbs_set(ds, port, type_data);
> default:
> return -EOPNOTSUPP;
> }
> --
> 2.17.1
>
--
Vinicius
ould go via the net tree, as it is a warning fix.
Anyway...
Acked-by: Vinicius Costa Gomes
--
Vinicius
his looks like it should be directed to net-next.
When you re-send it for net-next, feel free to add my:
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
this next week.
>
> Thanks,
> -Vladimir
Thanks a lot,
--
Vinicius
Hi,
Vladimir Oltean writes:
> Right. And while we're at it, there's still the potential
> division-by-zero problem which I still don't know how to solve without
> implementing a full-blown __ethtool_get_link_ksettings parser that
> checks against all the possible outputs it can have under the "n
ttribute (which were never used),
the parsing of those types of schedules was the only user of this
policy.
>
> I'm not applying this without at least a better and clear commit
> message explaining why we shouldn't be using this policy any more.
YueHaibing may use the text above in the commit message of a new spin of
this patch if you think it's clear enough.
Cheers,
--
Vinicius
Ivan Khoronzhuk writes:
> In case off error, all entries should be freed from the sched list
> before deleting it. For simplicity use rcu way.
>
> Fixes: 5a781ccbd19e46 ("tc: Add support for configuring the taprio scheduler")
> Signed-off-by: Ivan Khoronzhuk
> -
Hi,
Voon Weifeng writes:
> From: Ong Boon Leong
>
> IEEE 802.1Qbv Enhancements for Scheduled Traffics (EST) is available in
> EQoS ver5.xx. The change adds basic EST functionalities:
>
> a) EST initialization with hardware capabilities detection.
> b) Setting Gate Control List (GCL), i.e. gate
Hi Po Liu,
PO LIU writes:
> Hi Vinicius,
>
> Thank you very much for your feedback.
>
> I know the CBS is used to be most important part of AVB. And qdiscs is good
> tool to configure qos.
>
> But as you know, the TSN family is a cluster of protocols and much e
TSN protocols(like Qcc)
>but hardware related configuration.
>
> TSN Protocols supports by this patch: Qbv/Qci/Qbu/Credit-base Shaper(Qav).
> This patch verified on NXP ls1028ardb board.
>
> Will add more protocols in the future.
>
> Signed-off-by: Po Liu
Cheers,
--
Vinicius
Joe Perches writes:
> The line continuation unintentionally adds whitespace so
> instead use a coalesced format to remove the whitespace.
>
> Miscellanea:
>
> o Use a more typical style for ternaries and arguments
> for this logging message
>
> Signed-off-by: Joe P
Hi Jirka,
Jiri Olsa writes:
> On Fri, Oct 26, 2018 at 04:19:52PM -0700, Vinicius Costa Gomes wrote:
>> Hi,
>>
>> Adrian Hunter writes:
>>
>> > On 18/10/18 1:55 AM, Arnaldo Carvalho de Melo wrote:
>> >> From: Arnaldo Carvalho de Melo
>>
amp;
>> - machine__kernel_ip(machine, al->addr)) {
>> -mg = &machine->kmaps;
>> -load_map = true;
>> -goto try_again;
>> -}
>> -} else {
>> +if (al->map != NULL) {
>> /*
>> * Kernel maps might be changed when loading symbols so loading
>> * must be done prior to using kernel maps.
>>
--
Vinicius
ueue. In the implementation we are working on, this is left for the
user to decide.
Or do you have a reason for not doing *any* kind of re-ordering?
>
> I'd say the same is true for requests to send packets timed
> in the past.
+1
Cheers,
--
Vinicius
> +
It's been some time that I looked at this code, so I could be missing
something, but I got the feeling that this part would make more sense if
it was at process_adv_report(), there's even the check for a pending
connection, so no need to redo that here.
Apart from this, the series looks good.
> mgmt_event(MGMT_EV_DEVICE_FOUND, hdev, ev, ev_size, NULL);
> }
>
> --
> 2.12.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers,
--
Vinicius
On Fri, Mar 18, 2016 at 11:15 PM, Al Viro wrote:
> On Wed, Mar 16, 2016 at 11:48:49PM -0300, Vinicius Tinti wrote:
>> C11 standard (at 6.10.3.3) says that ## operator (paste) has undefined
>> behavior when one of the result operands is not a valid preprocessing
>> token.
>
kernel use CONCAT(a,b) instead of CONCAT(a, b).
Changing favors concise usage.
Signed-off-by: Vinicius Tinti
Acked-by: Behan Webster
---
arch/x86/crypto/aes_ctrby8_avx-x86_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/crypto/aes_ctrby8_avx-x86_64.S
b/arch/x86
stem kernel tree a try:
https://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git
Cheers,
--
Vinicius
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tue, Feb 24, 2015 at 3:11 PM, Mark Rutland wrote:
> On Tue, Feb 24, 2015 at 05:59:50PM +, Richard W.M. Jones wrote:
>> On Wed, Feb 18, 2015 at 12:26:38PM -0500, Kyle McMartin wrote:
>> > Using GCC 5 to build the kernel with ftrace enabled, we encounter the
>> > following error as a result o
Remove extra semicolon in perf_event.c if statement.
Signed-off-by: Vinicius Tinti
---
arch/arm/kernel/perf_event.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
index 31e0eb3..a892067 100644
--- a/arch/arm
Em (15:49:49), Alan Cox escreveu:
>On Gwe, 2005-07-22 at 08:27 -0300, Vinicius wrote:
>> Hi all!
>>
>> I have a server with 2 Pentium 4 HT processors and 32 GB of RAM, this
>> server runs lots of applications that consume lots of memory to. When I
>stop
&g
On Fri, 2005-07-22 at 08:27 -0300, Vinicius wrote:
[...]
>>I have a server with 2 Pentium 4 HT processors and 32 GB of >>RAM,
this
>> server runs lots of applications that consume lots of memory to. >>When I
>>stop
>> this applications, the kernel does
anks in advance (sorry my bad english).
Vinicius.
Protolink Consultoria.
Não seja o último saber. Chegou o gravador de conversas telefônicas. Trata-se
de um mini gravador que pode ser instalado em qualquer ponto do fio da sua
linha telefônica (inclusive extenções), e basta o seu telefone sair do gancho,
seja para receber ou efetuar uma chamada, que a gravação é acio
58 matches
Mail list logo
