Re: [PATCH 1/1] s390/pci: expose a PCI device's UID as its index

2021-04-17 Thread Viktor Mihajlovski
On 4/16/21 7:58 PM, K, Narendra wrote: -Original Message- From: Niklas Schnelle Sent: Thursday, April 15, 2021 12:55 PM To: Bjorn Helgaas Cc: K, Narendra; Viktor Mihajlovski; Stefan Raspl; Peter Oberparleiter; linux- net...@vger.kernel.org; linux-...@vger.kernel.org; linux- ker

Re: [RFC 1/1] s390/pci: expose a PCI device's UID as its index

2021-03-08 Thread Viktor Mihajlovski
d use sprintf(). What do you think? See https://www.kernel.org/doc/html/latest/filesystems/sysfs.html for the changes in the internal API. Krzysztof Of course that makes sense and thanks for pointing me to this API! @Viktor, may I carry your R-b over? Sure, please go ahead. I'll als

[PATCH 1/1] tracing/tools: fix a couple of spelling mistakes

2021-02-25 Thread Viktor Rosendahl
From: Colin Ian King There is a spelling mistake in the -g help option, I believe it should be "graph". There is also a spelling mistake in a warning message. Fix both mistakes. Signed-off-by: Colin Ian King Signed-off-by: Viktor Rosendahl --- tools/tracing/latency/latency-colle

[PATCH 0/1] Fix for the latency-collector

2021-02-25 Thread Viktor Rosendahl
Hi Steve, I am not sure what is the correct approach to handle this latency-collector fix. Can you take it into your queue? best regards, Viktor Colin Ian King (1): tracing/tools: fix a couple of spelling mistakes tools/tracing/latency/latency-collector.c | 6 +++--- 1 file changed, 3

[PATCH v12 0/1] Add the latency-collector to tools

2021-02-12 Thread Viktor Rosendahl
ftrace state when the program terminates * Cleaned up the commit message a bit, removed example output etc. Viktor Rosendahl (1): Add the latency-collector to tools tools/Makefile| 14 +- tools/tracing/Makefile| 19 + tools/tracing/latency

[PATCH v12 1/1] Add the latency-collector to tools

2021-02-12 Thread Viktor Rosendahl
est_0, preemptirqtest_1, preemptirqtest_2 in the stack traces. Signed-off-by: Viktor Rosendahl --- tools/Makefile| 14 +- tools/tracing/Makefile| 19 + tools/tracing/latency/.gitignore |2 + tools/tracing/latency/Makefile

[PATCH v11] Add the latency-collector to tools

2021-02-12 Thread Viktor Rosendahl
est_0, preemptirqtest_1, preemptirqtest_2 in the stack traces. Signed-off-by: Viktor Rosendahl --- tools/Makefile| 14 +- tools/tracing/Makefile| 19 + tools/tracing/latency/Makefile| 24 + tools/tracing/latency/lat

[PATCH] Add the latency-collector to tools

2021-02-11 Thread Viktor Rosendahl
dding more APIs to libtracefs, and if there's something you find > useful, please send a feature request here: > I managed to do everything I wanted with the existing APIs. Perhaps some of the functionality would make sense in the library; I am not sure. best regards, Viktor > >

[RFC PATCH 1/2] Use pause-on-trace with the latency tracers

2021-01-19 Thread Viktor Rosendahl
at, or even how feasible it is without significant rework. Signed-off-by: Viktor Rosendahl --- kernel/trace/trace_irqsoff.c | 4 1 file changed, 4 insertions(+) diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c index d06aab4dcbb8..6756379b661f 100644 --- a/kernel/trace/trace_

[RFC PATCH 2/2] Add the latency-collector to tools

2021-01-19 Thread Viktor Rosendahl
<<<<<< In the example above, we randomly, happened to get the third latency in a burst of 10. If the experiment is repeated enough times, we will get all 10. Sometimes, there will be lost latencies, so that we get: 3054.078294 Latency 44 printout skipped due to inotify loop ..o

[RFC PATCH 0/2] Tracing bursts of latencies

2021-01-19 Thread Viktor Rosendahl
l the next but when one is doing validation with a fleet of devices being tested in a long and expensive test campaign, then it is quite desirable to not lose any latencies. best regards, Viktor Viktor Rosendahl (2): Use pause-on-trace with the latency tracers Add the latency-collector to

Re: ath9k broken [was: Linux 5.7.3]

2020-07-16 Thread Viktor Jägersküpper
[CC'ed Roman] Kalle Valo: > Viktor Jägersküpper writes: > >> Greg Kroah-Hartman wrote: >>> On Fri, Jun 26, 2020 at 04:40:18PM +0200, Gabriel C wrote: >>>> Am Fr., 26. Juni 2020 um 15:51 Uhr schrieb Gabriel C >>>> : >>>>> &g

Re: [PATCH] Revert "ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb"

2020-07-09 Thread Viktor Jägersküpper
Kalle Valo wrote: > Viktor Jägersküpper writes: > >> Kalle Valo writes: >>> Roman Mamedov writes: >>> >>>> On Sat, 4 Apr 2020 12:18:38 +0800 >>>> Qiujun Huang wrote: >>>> >>>>> In ath9k_hif_usb_rx_cb interface

Re: ath9k broken [was: Linux 5.7.3]

2020-07-07 Thread Viktor Jägersküpper
c{1,2} yet but we will today and let you know. >>>>>> >>>>> >>>>> We tested 5.8-rc2 and it is broken too. >>>>> >>>>> The exact HW name is: >>>>> >>>>> TP-link tl-wn722n (Atheros AR9271 chip) >>>> >>>> Great! >>>> >>>> Can you work with the developers to fix this in Linus's tree first? >>> >>> I'm the man in the middle, but sure we will try patches or any suggestions >>> from developers to identify and fix the problem. >>> >>>> >>>> I bet they want to see the output of 'lsusb -v' for this device to see >>>> if the endpoint calculations are correct... >>>> >>> >>> Working on it. As soon the reporter gives me the output, I will post it >>> here. >>> I've told him to run it on a broken and one working kernel. >> >> That is from a good kernel with reverted commit >> https://gist.github.com/AngryPenguinPL/07c8e2abd3b103eaf8978a39ad8577d1 >> >> That is from the broken kernel without the commit reverted >> https://gist.github.com/AngryPenguinPL/5cdc0dd16ce5e59ff3c32c048e2f5111 >> >> This is from 5.7.5 kernel, I don't have yet a 5.8-rc2 package with the >> reverted commit. > > Did this ever get resolved? > > thanks, > > greg k-h > This bug was also reported on the thread where it had been posted originally: https://lore.kernel.org/linux-wireless/20200621020428.6417d6fb@natsu/ I am waiting for Kalle Valo to accept my patch (v2) which reverts the above mentioned commit and which looks correct according to him. He wrote that he would take a closer look at this as soon as he could. I don't know how busy Kalle is, especially under the current circumstances. I will remind him on Thursday (one week after his last e-mail). At the latest I want this to be fixed with the 5.8 release. I think that the patch has to land in several networking trees before it reaches the mainline kernel, so if I can do anything to speed things up, just tell me. Thanks, Viktor

[PATCH v2] Revert "ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb"

2020-07-01 Thread Viktor Jägersküpper
3] usb 1-5: ath9k_htc: USB layer deinitialized Reported-by: Roman Mamedov Ref: https://bugzilla.kernel.org/show_bug.cgi?id=208251 Fixes: 2bbcaaee1fcb ("ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb") Tested-by: Viktor Jägersküpper Signed-off-by: Viktor Jägersküpper

[PATCH] Revert "ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb"

2020-07-01 Thread Viktor Jägersküpper
se the driver gets stuck like this: [5.778803] usb 1-5: Manufacturer: ATHEROS [ 21.697488] usb 1-5: ath9k_htc: Firmware ath9k_htc/htc_9271-1.4.0.fw requested [ 21.701377] usbcore: registered new interface driver ath9k_htc [ 22.053705] usb 1-5: ath9k_htc: Transferred FW:

[PATCH v10 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-18 Thread Viktor Rosendahl (BMW)
enough. queue_work_on() could be used to queue the work on another CPU but it seems difficult to select the right CPU. Signed-off-by: Viktor Rosendahl (BMW) --- kernel/trace/trace.c | 73 ++-- kernel/trace/trace.h | 7 + 2 files changed, 78 insertions(+), 2 de

[PATCH v10 4/4] ftrace: Add an option for tracing console latencies

2019-10-18 Thread Viktor Rosendahl (BMW)
vertheless be desirable to trace them. Basically, we want to be able to tell that there are latencies in the system under test because someone has incorrectly enabled the serial console. Signed-off-by: Viktor Rosendahl (BMW) --- .../admin-guide/kernel-parameters.txt | 4 +++ inc

[PATCH v10 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-10-18 Thread Viktor Rosendahl (BMW)
ssary to reload the module to repeat the test. The trigger will appear as /sys/kernel/preemptirq_delay_test/trigger in sysfs. Signed-off-by: Viktor Rosendahl (BMW) Reviewed-by: Joel Fernandes (Google) --- kernel/trace/Kconfig | 6 +- kernel/trace/preemptirq_delay_test.c

[PATCH v10 3/4] Add the latency-collector to tools

2019-10-18 Thread Viktor Rosendahl (BMW)
<<<<<< In the example above, we randomly, happened to get the third latency in a burst burst of 10. If the experiment is repeated enough times, we will get all 10. Sometimes, there will be lost latencies, so that we get: 3054.078294 Latency 44 printout skipped due to inotify loop

[PATCH v10 0/4] Some new features for the preempt/irqsoff tracers

2019-10-18 Thread Viktor Rosendahl (BMW)
ow it does, so in principle it could be applied separately from the others. [PATCH 4/4] This adds the option trace_console_latency=1 to the kernel parameters. This makes it possible to enable tracing of console latencies. best regards, Viktor Viktor Rosendahl (BMW) (4): ftrace: Impleme

Re: [PATCH v9 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-16 Thread Viktor Rosendahl (BMW)
om those #if statements. I made the latency_fsnotify() static and removed its declaration from kernel/trace/trace.h, since it's only used in kernel/trace/trace.c. best regards, Viktor This patch implements the feature that the tracing_max_latency file, e.g. /sys/kernel/debug/tracing/tracing_max_lat

[PATCH v9 3/4] Add the latency-collector to tools

2019-10-15 Thread Viktor Rosendahl (BMW)
<<<<<< In the example above, we randomly, happened to get the third latency in a burst burst of 10. If the experiment is repeated enough times, we will get all 10. Sometimes, there will be lost latencies, so that we get: 3054.078294 Latency 44 printout skipped due to inotify loop

[PATCH v9 0/4] Some new features for the preempt/irqsoff tracers

2019-10-15 Thread Viktor Rosendahl (BMW)
dn't apply cleanly on its own. However, now it does, so in principle it could be applied separately from the others. [PATCH 4/4] This adds the option console-latency to the trace options. This makes it possible to enable tracing of console latencies. best regards, Viktor Viktor Rosendahl (BMW

[PATCH v9 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-10-15 Thread Viktor Rosendahl (BMW)
ssary to reload the module to repeat the test. The trigger will appear as /sys/kernel/preemptirq_delay_test/trigger in sysfs. Signed-off-by: Viktor Rosendahl (BMW) Reviewed-by: Joel Fernandes (Google) --- kernel/trace/Kconfig | 6 +- kernel/trace/preemptirq_delay_test.c

[PATCH v9 4/4] ftrace: Add an option for tracing console latencies

2019-10-15 Thread Viktor Rosendahl (BMW)
vertheless be desirable to trace them. Basically, we want to be able to tell that there are latencies in the system under test because someone has incorrectly enabled the serial console. Signed-off-by: Viktor Rosendahl (BMW) --- .../admin-guide/kernel-parameters.txt | 4 +++ inc

[PATCH v9 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-15 Thread Viktor Rosendahl (BMW)
enough. queue_work_on() could be used to queue the work on another CPU but it seems difficult to select the right CPU. Signed-off-by: Viktor Rosendahl (BMW) --- kernel/trace/trace.c | 75 ++-- kernel/trace/trace.h | 18 +++ 2 files changed, 91 insertion

Re: [PATCH v8 4/4] ftrace: Add an option for tracing console latencies

2019-10-10 Thread Viktor Rosendahl
Den ons 9 okt. 2019 kl 20:08 skrev Steven Rostedt : > > On Wed, 9 Oct 2019 16:51:07 +0200 > Viktor Rosendahl wrote: > > > Apologies, I should have replied there but I have been a bit busy the > > last few days with other topics, and I felt a bit indecisive about > >

Re: [PATCH v8 4/4] ftrace: Add an option for tracing console latencies

2019-10-09 Thread Viktor Rosendahl
Den ons 9 okt. 2019 kl 16:11 skrev Joel Fernandes : > > On Wed, Oct 09, 2019 at 12:08:24AM +0200, Viktor Rosendahl (BMW) wrote: > > This new trace option "console-latency" will enable the latency > > tracers to trace the console latencies. Previously this has always b

[PATCH v8 4/4] ftrace: Add an option for tracing console latencies

2019-10-08 Thread Viktor Rosendahl (BMW)
theless be desirable to trace them. Basically, we want to be able to tell that there are latencies in the system under test because someone has incorrectly enabled the serial console. Signed-off-by: Viktor Rosendahl (BMW) --- include/linux/irqflags.h | 22 ++ kernel/print

[PATCH v8 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-10-08 Thread Viktor Rosendahl (BMW)
ssary to reload the module to repeat the test. The trigger will appear as /sys/kernel/preemptirq_delay_test/trigger in sysfs. Signed-off-by: Viktor Rosendahl (BMW) Reviewed-by: Joel Fernandes (Google) --- kernel/trace/Kconfig | 6 +- kernel/trace/preemptirq_delay_test.c

[PATCH v8 3/4] Add the latency-collector to tools

2019-10-08 Thread Viktor Rosendahl (BMW)
t;<<<<<<< In the example above, we randomly, happened to get the third latency in a burst burst of 10. If the experiment is repeated enough times, we will get all 10. Sometimes, there will be lost latencies, so that we get: 3054.078294 Latency 44 printout skipped due to inot

[PATCH v8 0/4] Some new features for the preempt/irqsoff tracers

2019-10-08 Thread Viktor Rosendahl (BMW)
s makes it possible to enable tracing of console latencies. best regards, Viktor Viktor Rosendahl (BMW) (4): ftrace: Implement fs notification for tracing_max_latency preemptirq_delay_test: Add the burst feature and a sysfs trigger Add the latency-collector to tools ftrace: Add an option f

[PATCH v8 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-08 Thread Viktor Rosendahl (BMW)
enough. queue_work_on() could be used to queue the work on another CPU but it seems difficult to select the right CPU. Signed-off-by: Viktor Rosendahl (BMW) Reviewed-by: Joel Fernandes (Google) --- kernel/trace/trace.c | 75 +- kernel/trace/trace.h

Re: [PATCH v7 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-03 Thread Viktor Rosendahl
On 10/2/19 2:32 AM, Joel Fernandes wrote: Some nits, but others looks good: On Fri, Sep 20, 2019 at 05:22:16PM +0200, Viktor Rosendahl (BMW) wrote: This patch implements the feature that the tracing_max_latency file, e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive notifications

Re: [PATCH v7 4/4] ftrace: Add an option for tracing console latencies

2019-10-02 Thread Viktor Rosendahl
On 10/2/19 2:52 AM, Joel Fernandes wrote: On Fri, Sep 20, 2019 at 05:22:19PM +0200, Viktor Rosendahl (BMW) wrote: This new trace option "console-latency" will enable the latency tracers to trace the console latencies. Previously this has always been implicitely disabled. I guess this

Re: [PATCH v7 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-02 Thread Viktor Rosendahl
On 10/2/19 5:13 PM, Steven Rostedt wrote: On Fri, 20 Sep 2019 17:22:16 +0200 "Viktor Rosendahl (BMW)" wrote: This patch implements the feature that the tracing_max_latency file, e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive notifications through the fsnotify framew

[PATCH v7 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-09-20 Thread Viktor Rosendahl (BMW)
enough. queue_work_on() could be used to queue the work on another CPU but it seems difficult to select the right CPU. Signed-off-by: Viktor Rosendahl (BMW) --- kernel/trace/trace.c | 75 +- kernel/trace/trace.h | 18 + kernel/trace/trace_hwlat

[PATCH v7 3/4] Add the latency-collector to tools

2019-09-20 Thread Viktor Rosendahl (BMW)
t;<<<<<<< In the example above, we randomly, happened to get the third latency in a burst burst of 10. If the experiment is repeated enough times, we will get all 10. Sometimes, there will be lost latencies, so that we get: 3054.078294 Latency 44 printout skipped due to inot

[PATCH v7 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-09-20 Thread Viktor Rosendahl (BMW)
ssary to reload the module to repeat the test. The trigger will appear as /sys/kernel/preemptirq_delay_test/trigger in sysfs. Signed-off-by: Viktor Rosendahl (BMW) --- kernel/trace/Kconfig | 6 +- kernel/trace/preemptirq_delay_test.c | 144 +++ 2 files ch

[PATCH v7 4/4] ftrace: Add an option for tracing console latencies

2019-09-20 Thread Viktor Rosendahl (BMW)
theless be desirable to trace them. Basically, we want to be able to tell that there are latencies in the system under test because someone has incorrectly enabled the serial console. Signed-off-by: Viktor Rosendahl (BMW) --- include/linux/irqflags.h | 22 ++ kernel/print

[PATCH v7 0/4] Some new features for the preempt/irqsoff tracers

2019-09-20 Thread Viktor Rosendahl (BMW)
es it possible to enable tracing of console latencies. best regards, Viktor Viktor Rosendahl (BMW) (4): ftrace: Implement fs notification for tracing_max_latency preemptirq_delay_test: Add the burst feature and a sysfs trigger Add the latency-collector to tools ftrace: Add an option for tr

Re: [PATCH v6 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-09-08 Thread Viktor Rosendahl
On 9/8/19 1:38 AM, Joel Fernandes wrote:> On Sat, Sep 07, 2019 at 11:12:59PM +0200, Viktor Rosendahl wrote: >> On 9/6/19 4:17 PM, Joel Fernandes wrote: >>> On Thu, Sep 05, 2019 at 03:25:45PM +0200, Viktor Rosendahl wrote: >> >>>> + >>>&g

Re: [PATCH v6 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-09-07 Thread Viktor Rosendahl
On 9/6/19 4:17 PM, Joel Fernandes wrote: On Thu, Sep 05, 2019 at 03:25:45PM +0200, Viktor Rosendahl wrote: + +__init static int latency_fsnotify_init(void) +{ + fsnotify_wq = alloc_workqueue("tr_max_lat_wq", + WQ_UNBOUND | WQ_HIGHPRI, 0);

Re: [PATCH v5 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-09-05 Thread Viktor Rosendahl
On 9/5/19 6:52 PM, Steven Rostedt wrote: On Wed, 4 Sep 2019 21:10:38 +0200 Viktor Rosendahl wrote: On 9/4/19 1:42 PM, Steven Rostedt wrote: I am not so keen to clutter source files with a new copyright message. My problem is that git-send-email doesn't work well with my work email ad

[PATCH v6 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-09-05 Thread Viktor Rosendahl
happen with a softirq, kernel thread or tasklet. For this reason we use the irq_work mechanism to call queue_work(). Signed-off-by: Viktor Rosendahl --- kernel/trace/trace.c | 75 +- kernel/trace/trace.h | 18 + kernel/trace/trace_hwlat.c | 4

[PATCH v6 4/4] ftrace: Add an option for tracing console latencies

2019-09-05 Thread Viktor Rosendahl
theless be desirable to trace them. Basically, we want to be able to tell that there are latencies in the system under test because someone has incorrectly enabled the serial console. Signed-off-by: Viktor Rosendahl --- include/linux/irqflags.h | 22 ++ kernel/printk/printk.c

[PATCH v6 3/4] Add the latency-collector to tools

2019-09-05 Thread Viktor Rosendahl
t;<<<<<<< In the example above, we randomly, happened to get the third latency in a burst burst of 10. If the experiment is repeated enough times, we will get all 10. Sometimes, there will be lost latencies, so that we get: 3054.078294 Latency 44 printout skipped due to inotif

[PATCH v6 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-09-05 Thread Viktor Rosendahl
ssary to reload the module to repeat the test. The trigger will appear as /sys/kernel/preemptirq_delay_test/trigger in sysfs. Signed-off-by: Viktor Rosendahl --- kernel/trace/Kconfig | 6 +- kernel/trace/preemptirq_delay_test.c | 147 +++ 2 files changed

[PATCH v6 0/4] Some new features for the preempt/irqsoff tracers

2019-09-05 Thread Viktor Rosendahl
ly on its own. However, now it does, so in principle it could be applied separately from the others. [PATCH 4/4] This adds the option console-latency to the trace options. This makes it possible to enable tracing of console latencies. best regards, Viktor Viktor Rosendahl (4): ftrace: Impleme

Re: [PATCH v5 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-09-04 Thread Viktor Rosendahl
On 9/4/19 1:42 PM, Steven Rostedt wrote: On Tue, 3 Sep 2019 15:26:00 +0200 Viktor Rosendahl wrote: diff --git a/kernel/trace/preemptirq_delay_test.c b/kernel/trace/preemptirq_delay_test.c index d8765c952fab..dc281fa75198 100644 --- a/kernel/trace/preemptirq_delay_test.c +++ b/kernel/trace

Re: [PATCH v5 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-09-04 Thread Viktor Rosendahl
On 9/4/19 1:39 PM, Steven Rostedt wrote: On Tue, 3 Sep 2019 15:25:59 +0200 Viktor Rosendahl wrote: +void latency_fsnotify_stop(void) +{ + /* Make sure all CPUs see caller's previous actions to stop tracer */ + smp_wmb(); These memory barriers just look wrong. What exactl

Re: [PATCH v5 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-09-04 Thread Viktor Rosendahl
code. In addition, the rest of the code will become a lot simpler. best regards, Viktor

[PATCH v5 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-09-03 Thread Viktor Rosendahl
__schedule(). On the other hand, in some places, like in idle and the console we need start stop functions that prevents the measurements from being make. Signed-off-by: Viktor Rosendahl --- include/linux/ftrace.h| 31 + kernel/sched/core.c | 3 + kernel/sched

[PATCH v5 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-09-03 Thread Viktor Rosendahl
ssary to reload the module to repeat the test. The trigger will appear as /sys/kernel/preemptirq_delay_test/trigger in sysfs. Signed-off-by: Viktor Rosendahl --- kernel/trace/Kconfig | 6 +- kernel/trace/preemptirq_delay_test.c | 145 +++ 2 files changed

[PATCH v5 4/4] ftrace: Add an option for tracing console latencies

2019-09-03 Thread Viktor Rosendahl
theless be desirable to trace them. Basically, we want to be able to tell that there are latencies in the system under test because someone has incorrectly enabled the serial console. Signed-off-by: Viktor Rosendahl --- include/linux/irqflags.h | 21 + kernel/printk/printk.c

[PATCH v5 0/4] Some new features for the preempt/irqsoff tracers

2019-09-03 Thread Viktor Rosendahl
s, so in principle it could be applied separately from the others. [PATCH 4/4] This adds the option console-latency to the trace options. This makes it possible to enable tracing of console latencies. best regards, Viktor Viktor Rosendahl (4): ftrace: Implement fs notification for tracing_max

[PATCH v5 3/4] Add the latency-collector to tools

2019-09-03 Thread Viktor Rosendahl
t;<<<<<<< In the example above, we randomly, happened to get the third latency in a burst burst of 10. If the experiment is repeated enough times, we will get all 10. Sometimes, there will be lost latencies, so that we get: 3054.078294 Latency 44 printout skipped due to inotif

Re: [PATCH v4 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-05-21 Thread Viktor Rosendahl
t's possible to slightly simplify the enable/disble functions, so I guess that this would not be necessary, especially since one would need to handle the case when some CPUs are in the forbidden sections when the tracers are enabled. I can try to add the static branch if you want it though.

[PATCH v4 4/4] ftrace: Add an option for tracing console latencies

2019-05-17 Thread Viktor Rosendahl
theless be desirable to trace them. Basically, we want to be able to tell that there are latencies in the system under test because someone has incorrectly enabled the serial console. Signed-off-by: Viktor Rosendahl --- include/linux/irqflags.h | 21 + kernel/printk/printk.c

[PATCH v4 3/4] Add the latency-collector to tools

2019-05-17 Thread Viktor Rosendahl
t;<<<<<<< In the example above, we randomly, happened to get the third latency in a burst burst of 10. If the experiment is repeated enough times, we will get all 10. Sometimes, there will be lost latencies, so that we get: 3054.078294 Latency 44 printout skipped due to inotif

[PATCH v4 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-05-17 Thread Viktor Rosendahl
ssary to reload the module to repeat the test. The trigger will appear as /sys/kernel/preemptirq_delay_test/trigger in sysfs. Signed-off-by: Viktor Rosendahl --- kernel/trace/Kconfig | 6 +- kernel/trace/preemptirq_delay_test.c | 145 +++ 2 files changed

[PATCH v4 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-05-17 Thread Viktor Rosendahl
exited do_idle()/__schedule(). Signed-off-by: Viktor Rosendahl --- include/trace/events/power.h | 40 + include/trace/events/sched.h | 40 + kernel/sched/core.c | 2 + kernel/sched/idle.c | 2 + kernel/trace/trace.c | 168

[PATCH v4 0/4] Some new features for the latency tracers

2019-05-17 Thread Viktor Rosendahl
n its own: [PATCH 4/4] This adds the option console-latency to the trace options. This makes it possible to enable tracing of console latencies. best regards, Viktor Viktor Rosendahl (4): ftrace: Implement fs notification for tracing_max_latency preemptirq_delay_test: Add the burst feature

Re: [PATCH v3 0/4] Some new features for the latency tracers

2019-05-14 Thread Viktor Rosendahl
On 5/14/19 6:51 PM, Steven Rostedt wrote: Hi Viktor, Note, as the merge window is open and I'm also currently at a conference, it may be a while before I can take a look at this. If you don't hear something from me in 10 days, feel free to send me a ping. -- Steve Hi Steve, O

[PATCH v3 3/4] Add the latency-collector to tools

2019-05-13 Thread Viktor Rosendahl
t;>>>>>>>> END <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< In the example above, we randomly, happened to get the third latency in a burst burst of 10. If the experiment

[PATCH v3 4/4] ftrace: Add an option for tracing console latencies

2019-05-13 Thread Viktor Rosendahl
theless be desirable to trace them. Basically, we want to be able to tell that there are latencies in the system under test because someone has incorrectly enabled the serial console. Signed-off-by: Viktor Rosendahl --- include/linux/irqflags.h| 21 + kernel/print

[PATCH v3 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-05-13 Thread Viktor Rosendahl
exited do_idle()/__schedule(). Signed-off-by: Viktor Rosendahl --- include/trace/events/power.h | 40 + include/trace/events/sched.h | 40 + kernel/sched/core.c | 2 + kernel/sched/idle.c | 2 + kernel/trace/trace.c | 160

[PATCH v3 0/4] Some new features for the latency tracers

2019-05-13 Thread Viktor Rosendahl
H 4/4] This adds the option console-latency to the trace options. best regards, Viktor Viktor Rosendahl (4): ftrace: Implement fs notification for tracing_max_latency preemptirq_delay_test: Add the burst feature and a sysfs trigger Add the latency-collector to tools ftrace: Add an optio

[PATCH v3 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-05-13 Thread Viktor Rosendahl
ssary to reload the module to repeat the test. The trigger will appear as /sys/kernel/preemptirq_delay_test/trigger in sysfs. Signed-off-by: Viktor Rosendahl --- kernel/trace/Kconfig | 6 +- kernel/trace/preemptirq_delay_test.c | 145 +++ 2 files changed

Re: [PATCH v2 1/4] ftrace: Implement fs notification for preempt/irqsoff tracers

2019-05-05 Thread Viktor Rosendahl
On 5/6/19 1:01 AM, Steven Rostedt wrote: > On Mon,  6 May 2019 00:39:15 +0200 > Viktor Rosendahl wrote: > >> Can you explain more precisely what you agree with? >> >> The general idea of being able to trace bursts of latencies? > > One thing I have an issue wit

Re: [PATCH v2 1/4] ftrace: Implement fs notification for preempt/irqsoff tracers

2019-05-05 Thread Viktor Rosendahl
On 5/4/19 6:47 PM, Joel Fernandes wrote: > On Wed, May 01, 2019 at 10:36:47PM +0200, Viktor Rosendahl wrote: >> immediately after each other in spite of the fact that the >> preempt/irqsoff tracers operate in overwrite mode. >> >> Signed-off-by: Viktor Rosendahl > &

Re: [PATCH v2 4/4] ftrace: Add an option for tracing console latencies

2019-05-02 Thread Viktor Rosendahl
urn the result of > console_stop_critical_timings() and have that passed to > console_start_critical_timings(), and only have start do something if > stop did something. This way the option only needs to disable the stop > part. Something like this? I have only compile tested it so far. best regard

[PATCH v2 4/4] ftrace: Add an option for tracing console latencies

2019-05-01 Thread Viktor Rosendahl
desirable to trace them. Basically, we want to be able to tell that there are latencies in the system under test because someone has incorrectly enabled the serial console. Signed-off-by: Viktor Rosendahl --- include/linux/irqflags.h | 13 + kernel/printk/printk.c | 5 +++-- kernel

[PATCH v2 3/4] Add the latency-collector to tools

2019-05-01 Thread Viktor Rosendahl
<<<<<< In the example above, we randomly, happened to get the third latency in a burst burst of 10. If the experiment is repeated enough times, we will get all 10. Sometimes, there will be lost latencies, so that we get: 3054.078294 Latency 44 printout skipped due to inotif

[PATCH v2 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-05-01 Thread Viktor Rosendahl
ssary to reload the module to repeat the test. The trigger will appear as /sys/kernel/preemptirq_delay_test/trigger in sysfs. Signed-off-by: Viktor Rosendahl --- kernel/trace/Kconfig | 6 +- kernel/trace/preemptirq_delay_test.c | 145 +++ 2 files changed

[PATCH v2 0/4] Some new features for the preempt/irqsoff tracers

2019-05-01 Thread Viktor Rosendahl
directly connected but doesn't apply cleanly on its own: [PATCH 4/4] This adds the option CONFIG_TRACE_CONSOLE_LATENCY to decide whether we want to trace prints to the console or not. best regards, Viktor Rosendahl Viktor Rosendahl (4): ftrace: Implement fs notification for preempt/ir

[PATCH v2 1/4] ftrace: Implement fs notification for preempt/irqsoff tracers

2019-05-01 Thread Viktor Rosendahl
latencies that occur immediately after each other in spite of the fact that the preempt/irqsoff tracers operate in overwrite mode. Signed-off-by: Viktor Rosendahl --- kernel/trace/Kconfig | 10 ++ kernel/trace/trace.c | 31 +-- kernel/trace/trace.h

[PATCH 3/4] Add the latency-collector to tools

2019-01-21 Thread Viktor Rosendahl
t;<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< In the example above, we randomly, happened to get the third latency in a burst burst of 10. If the experiment is repeated enough times, we will get a

[PATCH 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-01-21 Thread Viktor Rosendahl
odule to repeat the test. The trigger will appear as /sys/kernel/preemptirq_delay_test/trigger in sysfs. Signed-off-by: Viktor Rosendahl --- kernel/trace/preemptirq_delay_test.c | 139 +++ 1 file changed, 120 insertions(+), 19 deletions(-) diff --git a/kernel/

[PATCH 4/4] ftrace: Add an option for tracing console latencies

2019-01-21 Thread Viktor Rosendahl
desirable to trace them. Basically, we want to be able to tell that there are latencies in the system under test because someone has incorrectly enabled the serial console. Signed-off-by: Viktor Rosendahl --- include/linux/irqflags.h | 13 + kernel/printk/printk.c | 5 +++-- kernel

[PATCH 1/4] ftrace: Implement fs notification for preempt/irqsoff tracers

2019-01-21 Thread Viktor Rosendahl
latencies that occur immediately after each other in spite of the fact that the preempt/irqsoff tracers operate in overwrite mode. Signed-off-by: Viktor Rosendahl --- kernel/trace/Kconfig | 10 ++ kernel/trace/trace.c | 31 +-- kernel/trace/trace.h

[PATCH 0/4] Some new features for the preempt/irqsoff tracers

2019-01-21 Thread Viktor Rosendahl
This adds the option CONFIG_TRACE_CONSOLE_LATENCY to decide whether we want to trace prints to the console or not. best regards, Viktor Rosendahl Viktor Rosendahl (4): ftrace: Implement fs notification for preempt/irqsoff tracers preemptirq_delay_test: Add the burst feature and a sysfs tr

Re: REGRESSION: boot stalls on several old dual core Intel CPUs

2018-09-03 Thread Viktor Jägersküpper
Peter Zijlstra: > On Mon, Sep 03, 2018 at 10:54:23AM +0200, Peter Zijlstra wrote: >> On Mon, Sep 03, 2018 at 09:38:15AM +0200, Thomas Gleixner wrote: >>> On Mon, 3 Sep 2018, Peter Zijlstra wrote: On Sat, Sep 01, 2018 at 11:51:26AM +0930, Kevin Shanahan wrote: > commit 01548f4d3e8e94caf323a

Re: [PATCH v2] perf: add callgrind conversion tool

2013-03-27 Thread Viktor Ostashevskyi
Hi Roberto, Roberto Vitillo lbl.gov> writes: > The proposed patch adds the convert tool to perf which allows to convert a > perf.data file to a set of callgrind data files which can subsequently be > displayed with kcachegrind. Incredible job! Absence of this feature forced me to write my own

Re: Linux 3.0+ Disk performance problem - wrong pdflush behaviour

2012-10-11 Thread Viktor Nagy
Hi, On 2012.10.10. 22:27, Jan Kara wrote: On Wed 10-10-12 22:44:41, Viktor Nagy wrote: On 10/10/2012 06:57 PM, Jan Kara wrote: Hello, On Tue 09-10-12 11:41:16, Viktor Nagy wrote: Since Kernel version 3.0 pdflush blocks writes even the dirty bytes are well below /proc/sys/vm/dirty_bytes

Re: Linux 3.0+ Disk performance problem - wrong pdflush behaviour

2012-10-10 Thread Viktor Nagy
Hi, On 10/10/2012 06:57 PM, Jan Kara wrote: Hello, On Tue 09-10-12 11:41:16, Viktor Nagy wrote: Since Kernel version 3.0 pdflush blocks writes even the dirty bytes are well below /proc/sys/vm/dirty_bytes or /proc/sys/vm/dirty_ratio. The kernel 2.6.39 works nice. How this hurt us in the

Linux 3.0+ Disk performance problem - wrong pdflush behaviour

2012-10-09 Thread Viktor Nagy
for cache, and 5.1 GByte RAM free (totally unused). Sorry if I not found the right place to report this, please advise me were to send. Best regards Viktor Nagy #include #include #include #include #include #include #include #include #include #include // parameters char * filenam

Re: O_DIRECT question

2007-01-26 Thread Viktor
Mark Lord wrote: > You guys need to backup in this thread. > > Every example of O_DIRECT here could be replaced with > calls to mmap(), msync(), and madvise() (or posix_fadvise). No. How about handling IO errors? There is no practical way for it with mmap(). > In addition to being at least as fa

Re: O_DIRECT question

2007-01-12 Thread Viktor
Linus Torvalds wrote: O_DIRECT is still crazily racy versus pagecache operations. >>> >>>Yes. O_DIRECT is really fundamentally broken. There's just no way to fix >>>it sanely. >> >>How about aliasing O_DIRECT to POSIX_FADV_NOREUSE (sortof) ? > > > That is what I think some users could do. If

Re: O_DIRECT question

2007-01-12 Thread Viktor
Linus Torvalds wrote: >>OK, madvise() used with mmap'ed file allows to have reads from a file >>with zero-copy between kernel/user buffers and don't pollute cache >>memory unnecessarily. But how about writes? How is to do zero-copy >>writes to a file and don't pollute cache memory without using O_D

Re: O_DIRECT question

2007-01-11 Thread Viktor
Linus Torvalds wrote: > > On Thu, 11 Jan 2007, Aubrey wrote: > >>Now, my question is, is there a existing way to mount a filesystem >>with O_DIRECT flag? so that I don't need to change anything in my >>system. If there is no option so far, What is the right way to achieve >>my purpose? > > > Th

PROBLEM: AIPTEK input doesn`t register `device` & `driver` section in sysfs (/sys/class/input/event#)

2005-04-10 Thread Viktor A. Danilov
bdev = usbdev; aiptek->ifnum = intf->altsetting[0].desc.bInterfaceNumber; aiptek->inDelay = 0; LINUX_VERSION: [EMAIL PROTECTED]:/usr/src/linux/scripts$ ./ver_linux If some fields are empty or look unusual you may have an old version. Compare to the current minimal require

Re: patches to 2.6.9 and 2.6.10 - make menuconfig shows "v2.6.8.1"

2005-01-27 Thread Viktor Horvath
and not 2.6.8.1! You're perfectly right. I thought "patch" would stop and ask me something, but the error was silently buried under lots of "patching file" lines. > If you do the patching without the 2.6.8.1 patch everything should be fine. It is! Thanks a lot! Viktor.

patches to 2.6.9 and 2.6.10 - make menuconfig shows "v2.6.8.1"

2005-01-27 Thread Viktor Horvath
kernel package, this behaviour doesn't show up. Sorry if this is a dumb question, but I could not find an answer in the archives. Have a nice day, Viktor. Please Cc: me when answering. signature.asc Description: This is a digitally signed message part

Re: [BUG?] ISA-PnP and 3c509 NIC won't work together

2001-02-03 Thread Viktor Rosenfeld
-0-<1,0>: sync msgout: 1-3-1-c-10. sym53c875E-0-<1,0>: sync msg in: 1-3-1-c-f. sym53c875E-0-<1,0>: sync: per=12 scntl3=0x90 scntl4=0x0 ofs=15 fak=0 chg=0. sr0: scsi-1 drive Uniform CD-ROM driver Revision: 3.12 usb.c: registered new driver usbdevfs usb.c: registered new driver hub PCI: Fo

[BUG?] ISA-PnP and 3c509 NIC won't work together

2001-02-03 Thread Viktor Rosenfeld
#x27;t find info on re-enabling PNP on the card. Below, I have attached the content of /proc/isapnp. If I can do anything to provide more info, let me know. Thanks for a great kernel, Viktor -- Viktor Rosenfeld WWW: http://www.informatik.hu-berlin.de/~rosenfel/ Geek Code (3.1): GCS/SS d-@ s+: