Re: [PATCH] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry

2024-01-30 Thread Vikash Garodia
obvious answer, but is there a way of knowing >> without the crashes? > > +CC Vikash Garodia > > Unfortunately I don't really have much more information than this > message here: > https://lore.kernel.org/linux-arm-msm/ff021f49-f81b-0fd1-bd2c-895dbbb03...@quicinc.com

Re: [PATCH v3 2/3] arm64: dts: qcom: sc7280: Move video-firmware to chrome-common

2023-12-11 Thread Vikash Garodia
t; on a non-ChromeOS devices. We also need to move the secure SID 0x2184 > for iommu since (on some boards) we cannot touch that. > > At the same time also disable the venus node by default in the dtsi, > like it's done on other SoCs. > > Reviewed-by: Bryan O'Donoghue &

Re: [PATCH v2 2/3] arm64: dts: qcom: sc7280: Move video-firmware to chrome-common

2023-11-24 Thread Vikash Garodia
On 11/24/2023 6:23 PM, Dmitry Baryshkov wrote: > On Fri, 24 Nov 2023 at 14:30, Vikash Garodia > wrote: >> >> On 11/24/2023 5:05 PM, Luca Weiss wrote: >>> On Fri Nov 24, 2023 at 7:38 AM CET, Vikash Garodia wrote: >>>> >>>> On 11/22/2023 7:50 P

Re: [PATCH v2 2/3] arm64: dts: qcom: sc7280: Move video-firmware to chrome-common

2023-11-24 Thread Vikash Garodia
On 11/24/2023 5:05 PM, Luca Weiss wrote: > On Fri Nov 24, 2023 at 7:38 AM CET, Vikash Garodia wrote: >> >> On 11/22/2023 7:50 PM, Luca Weiss wrote: >>> On Wed Nov 22, 2023 at 2:17 PM CET, Vikash Garodia wrote: >>>> >>>> On 10/2/2023 7:50 PM, Luca

Re: [PATCH v2 2/3] arm64: dts: qcom: sc7280: Move video-firmware to chrome-common

2023-11-23 Thread Vikash Garodia
On 11/22/2023 7:50 PM, Luca Weiss wrote: > On Wed Nov 22, 2023 at 2:17 PM CET, Vikash Garodia wrote: >> >> On 10/2/2023 7:50 PM, Luca Weiss wrote: >>> If the video-firmware node is present, the venus driver assumes we're on >>> a system that doesn't

Re: [PATCH v2 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable venus node

2023-11-22 Thread Vikash Garodia
; +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > @@ -665,3 +665,8 @@ &usb_1_qmpphy { > > status = "okay"; > }; > + > +&venus { > + firmware-name = "qcom/qcm6490/fairphone5/venus.mbn"; > + status = "okay"; > +}; > Reviewed-by: Vikash Garodia Regards, Vikash

Re: [PATCH v2 2/3] arm64: dts: qcom: sc7280: Move video-firmware to chrome-common

2023-11-22 Thread Vikash Garodia
On 10/2/2023 7:50 PM, Luca Weiss wrote: > If the video-firmware node is present, the venus driver assumes we're on > a system that doesn't use TZ for starting venus, like on ChromeOS > devices. > > Move the video-firmware node to chrome-common.dtsi so we can use venus > on a non-ChromeOS devices

Re: [PATCH v2 1/3] media: venus: core: Set up secure memory ranges for SC7280

2023-11-22 Thread Vikash Garodia
dr = 0, > .dma_mask = 0xe000 - 1, > + .cp_start = 0, > + .cp_size = 0x2580, > + .cp_nonpixel_start = 0x100, > + .cp_nonpixel_size = 0x2480, > .fwname = "qcom/vpu-2.0/venus.mbn", > }; > Reviewed-by: Vikash Garodia

[PATCH] venus: helpers: keep max bandwidth when mbps exceeds the supported range

2021-03-31 Thread Vikash Garodia
When the video usecase have macro blocks per sec which is more than supported, keep the required bus bandwidth as the maximum supported. Signed-off-by: Vikash Garodia --- drivers/media/platform/qcom/venus/pm_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] venus: fixes for list corruption

2020-08-04 Thread Vikash Garodia
From: Vikash Garodia There are few list handling issues while adding and deleting node in the registered buf list in the driver. 1. list addition - buffer added into the list during buf_init while not deleted during cleanup. 2. list deletion - In capture streamoff, the list was reinitialized. As

Re: [PATCH] media: venus: dynamic handling of bitrate

2018-11-01 Thread Vikash Garodia
On 2018-11-01 19:23, Tomasz Figa wrote: On Thu, Nov 1, 2018 at 10:01 PM wrote: On 2018-11-01 17:48, Stanimir Varbanov wrote: > Hi Malathi, > > Thanks for the patch! > > On 10/31/18 9:42 AM, Malathi Gottam wrote: >> Any request for a change in bitrate after both planes >> are streamed on is han

[PATCH v10 0/5] Venus updates - PIL

2018-10-08 Thread Vikash Garodia
This version of the series * extends the description of firmware subnode in documentation. * renames the flag suggesting the presence of tz and update code accordingly. Stanimir Varbanov (1): venus: firmware: register separate platform_device for firmware loader Vikash Garodia (4): venus

Re: [PATCH v2 2/5] media: venus: add a routine to set venus state

2018-07-04 Thread Vikash Garodia
On 2018-07-04 14:30, Tomasz Figa wrote: On Wed, Jul 4, 2018 at 4:59 PM Vikash Garodia wrote: On 2018-06-04 18:24, Tomasz Figa wrote: > On Sat, Jun 2, 2018 at 6:21 AM Jordan Crouse > wrote: >> On Sat, Jun 02, 2018 at 01:56:05AM +0530, Vikash Garodia wrote: > Given that t

Re: [PATCH 3/4] venus: add check to make scm calls

2018-05-22 Thread Vikash Garodia
Hi Stan, On 2018-05-23 02:27, Stanimir Varbanov wrote: Hi Jordan, On 22.05.2018 22:50, Jordan Crouse wrote: On Tue, May 22, 2018 at 04:04:51PM +0300, Stanimir Varbanov wrote: Hi Vikash, On 05/17/2018 02:32 PM, Vikash Garodia wrote: In order to invoke scm calls, ensure that the platform has

Re: [PATCH 4/4] media: venus: add PIL support

2018-05-18 Thread Vikash Garodia
Hi Trilok, On 2018-05-18 06:10, Trilok Soni wrote: Hi Vikash, On 5/17/2018 4:32 AM, Vikash Garodia wrote: This adds support to load the video firmware and bring ARM9 out of reset. This is useful for platforms which does not have trustzone to reset the ARM9. ARM9 = video core here? May be

Re: [PATCH 1/4] soc: qcom: mdt_loader: Add check to make scm calls

2018-05-18 Thread Vikash Garodia
Hi Bjorn, On 2018-05-18 10:58, Bjorn Andersson wrote: On Thu 17 May 04:32 PDT 2018, Vikash Garodia wrote: In order to invoke scm calls, ensure that the platform has the required support to invoke the scm calls in secure world. Signed-off-by: Vikash Garodia --- drivers/soc/qcom/mdt_loader.c

[PATCH 4/4] media: venus: add PIL support

2018-05-17 Thread Vikash Garodia
This adds support to load the video firmware and bring ARM9 out of reset. This is useful for platforms which does not have trustzone to reset the ARM9. Signed-off-by: Vikash Garodia --- .../devicetree/bindings/media/qcom,venus.txt | 8 +- drivers/media/platform/qcom/venus/core.c

[PATCH 2/4] media: venus: add a routine to reset ARM9

2018-05-17 Thread Vikash Garodia
Add a new routine to reset the ARM9 and brings it out of reset. This is in preparation to add PIL functionality in venus driver. Signed-off-by: Vikash Garodia --- drivers/media/platform/qcom/venus/firmware.c | 26 drivers/media/platform/qcom/venus/firmware.h

[PATCH 3/4] venus: add check to make scm calls

2018-05-17 Thread Vikash Garodia
In order to invoke scm calls, ensure that the platform has the required support to invoke the scm calls in secure world. This code is in preparation to add PIL functionality in venus driver. Signed-off-by: Vikash Garodia --- drivers/media/platform/qcom/venus/hfi_venus.c | 26

[PATCH 1/4] soc: qcom: mdt_loader: Add check to make scm calls

2018-05-17 Thread Vikash Garodia
In order to invoke scm calls, ensure that the platform has the required support to invoke the scm calls in secure world. Signed-off-by: Vikash Garodia --- drivers/soc/qcom/mdt_loader.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/soc/qcom

[PATCH 0/4] Venus updates - PIL

2018-05-17 Thread Vikash Garodia
by Stanimir Varbanov. Comments are welcome! regards, Vikash Vikash Garodia (4): soc: qcom: mdt_loader: Add check to make scm calls media: venus: add a routine to reset ARM9 venus: add check to make scm calls media: venus: add PIL support .../devicetree/bindings/media/qcom,venus.txt

Re: [PATCH 08/28] venus: hfi_venus: add suspend function for 4xx version

2018-05-09 Thread Vikash Garodia
Hi Stanimir, On 2018-05-09 16:45, Stanimir Varbanov wrote: Hi Vikash, On 05/02/2018 09:07 AM, vgaro...@codeaurora.org wrote: Hello Stanimir, On 2018-04-24 18:14, Stanimir Varbanov wrote: This adds suspend (power collapse) function with slightly different order of calls comparing with Venus 3

Re: [PATCH 10/28] venus: vdec: call session_continue in insufficient event

2018-05-04 Thread Vikash Garodia
Hi Stanimir, On 2018-05-03 17:06, Stanimir Varbanov wrote: Hi Vikash, Thanks for the comments! On 2.05.2018 09:26, Vikash Garodia wrote: Hello Stanimir, On 2018-04-24 18:14, Stanimir Varbanov wrote: Call session_continue for Venus 4xx version even when the event says that the buffer

Re: [PATCH 26/28] venus: implementing multi-stream support

2018-05-03 Thread Vikash Garodia
add the required code. On 2.05.2018 10:40, Vikash Garodia wrote: Hello Stanimir, On 2018-04-24 18:14, Stanimir Varbanov wrote: This is implementing a multi-stream decoder support. The multi stream gives an option to use the secondary decoder output with different raw format (or the same in

Re: [PATCH 26/28] venus: implementing multi-stream support

2018-05-02 Thread Vikash Garodia
On 2018-05-02 18:58, Nicolas Dufresne wrote: Le mercredi 02 mai 2018 à 13:10 +0530, Vikash Garodia a écrit : Hello Stanimir, On 2018-04-24 18:14, Stanimir Varbanov wrote: > This is implementing a multi-stream decoder support. The multi > stream gives an option to use the secondary d

Re: [PATCH 26/28] venus: implementing multi-stream support

2018-05-02 Thread Vikash Garodia
Hello Stanimir, On 2018-04-24 18:14, Stanimir Varbanov wrote: This is implementing a multi-stream decoder support. The multi stream gives an option to use the secondary decoder output with different raw format (or the same in case of crop). Signed-off-by: Stanimir Varbanov --- drivers/media/p

Re: [PATCH 10/28] venus: vdec: call session_continue in insufficient event

2018-05-01 Thread Vikash Garodia
Hello Stanimir, On 2018-04-24 18:14, Stanimir Varbanov wrote: Call session_continue for Venus 4xx version even when the event says that the buffer resources are not sufficient. Leaving a comment with more information about the workaround. Signed-off-by: Stanimir Varbanov --- drivers/media/pla