Hi Yiwen, all,
On 2/9/2018 8:10 AM, jiangyiwen wrote:
> Hi Eric and Greg,
>
> I encountered the similar problem with create-unlink-getattr idiom.
> I use the testcase that create-unlink-setattr idiom, and I see the
> bug is reported at https://bugs.launchpad.net/qemu/+bug/1336794.
> Then I also s
logic for link state management in case of no
current active slave for 2*arp_interval.
Could you please elaborate what exactly is fixed here, and how it works? :)
p.s. num_grat_arp maybe could help?
[jarod: manufacturing of changelog]
CC: Jay Vosburgh
CC: Veaceslav Falico
CC: Andy
vices (including vlan and macvlan)
Signed-off-by: Michal Kubecek
Seems ok to me.
Acked-by: Veaceslav Falico
---
drivers/net/bonding/bond_main.c | 3 +++
drivers/net/team/team.c | 3 +++
net/core/dev.c | 15 +--
3 files changed, 11 insertions(+), 10 dele
On Tue, Nov 11, 2014 at 09:21:30AM +0100, Michal Kubecek wrote:
Large receive offloading is known to cause problems if received packets
are passed to other host. Therefore the kernel disables it by calling
dev_disable_lro() whenever a network device is enslaved in a bridge or
forwarding is enable
On Mon, Aug 04, 2014 at 11:15:13AM +0800, lichu...@huawei.com wrote:
From: Chunhe Li
If the bonding device is down, it should not receive packets
to network stack or other upper flow stack.
This breaks arp monitoring and 802.3ad modes, as they won't ever come up.
Also, please cc netdev next
On Thu, Jul 17, 2014 at 09:17:07AM +0200, Tom Gundersen wrote:
On Thu, Jul 17, 2014 at 8:56 AM, David Miller wrote:
Tom, even if the patches are sort of independent, they logically
belong together.
So please number them, and provide an appropriate "[PATCH 0/N] ..."
cover letter.
Please resubm
On Mon, Jun 02, 2014 at 04:35:57PM +0200, Jiri Pirko wrote:
Mon, Jun 02, 2014 at 04:25:15PM CEST, mpriv...@redhat.com wrote:
The link speed is available at /sys/class/net/$nic/speed.
However, the speed is printed in unsigned integer format. This
makes userspace applications read an incorrect val
On Wed, Apr 16, 2014 at 03:08:02PM +0800, Li, Zhen-Hua wrote:
From: "Li, Zhen-Hua"
As netif_running is called in netif_device_attach/detach. There should be
rtnl_lock/unlock called, to avoid dev stat change during netif_device_attach
and detach being called.
I checked NIC some drivers, some of
Gospodarek
CC: "David S. Miller"
CC: Stefan Richter
CC: Simon Wunderlich
CC: Neil Jerram
CC: Simon Horman
CC: Arvid Brodin
CC: net...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Veaceslav Falico
---
drivers/net/bonding/bond_alb.c | 2 +-
include/uapi/linux/if_ether.h
add the new option's documentation and update the arp_validate one
to be a bit more descriptive.
CC: Rob Landley
CC: Jay Vosburgh
CC: Andy Gospodarek
CC: "David S. Miller"
CC: dingtianhong
CC: Nikolay Aleksandrov
CC: Neil Horman
CC: Cong Wang
CC: linux-...@vger.kernel.org
CC:
-prototypes]
net/core/dev.c:4640:5: warning: no previous prototype for
‘netdev_adjacent_sysfs_add’ [-Wmissing-prototypes]
net/core/dev.c:4650:6: warning: no previous prototype for
‘netdev_adjacent_sysfs_del’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria
Reviewed-by: Veaceslav Falico
On Fri, Jan 31, 2014 at 01:54:03AM +0100, Tom Gundersen wrote:
Hi Veaceslav,
Thanks for your quick reply.
On Thu, Jan 30, 2014 at 4:05 PM, Veaceslav Falico wrote:
On Thu, Jan 30, 2014 at 02:20:02PM +0100, Tom Gundersen wrote:
In systemd's networkd and udevd, we would like to giv
On Thu, Jan 30, 2014 at 02:20:02PM +0100, Tom Gundersen wrote:
In systemd's networkd and udevd, we would like to give the administrator a
simple way to filter net devices by their DEVTYPE [0][1]. Other software
such as ConnMan and NetworkManager uses a similar filtering already.
Currently, plain
On Wed, Jan 15, 2014 at 03:25:16PM -0800, Eric W. Biederman wrote:
Tejun Heo writes:
Hey, Veaceslav, Eric.
Hi Tejun, Eric,
On Tue, Jan 14, 2014 at 05:35:23PM -0800, Eric W. Biederman wrote:
>>> >>This works like a charm. However, if I want to use (obviously, with the
>>> >>symlink presen
On Tue, Jan 14, 2014 at 11:31:39AM -0800, Greg KH wrote:
On Tue, Jan 14, 2014 at 08:12:08PM +0100, Veaceslav Falico wrote:
On Tue, Jan 14, 2014 at 10:21:35AM -0800, Greg KH wrote:
>On Tue, Jan 14, 2014 at 06:17:40PM +0100, Veaceslav Falico wrote:
>>Hi,
>>
>>I'm hitt
On Tue, Jan 14, 2014 at 10:21:35AM -0800, Greg KH wrote:
On Tue, Jan 14, 2014 at 06:17:40PM +0100, Veaceslav Falico wrote:
Hi,
I'm hitting a strange issue and/or I'm completely lost in sysfs internals.
Consider having two net_device *a, *b; which are registered normally.
Now, to cre
Hi,
I'm hitting a strange issue and/or I'm completely lost in sysfs internals.
Consider having two net_device *a, *b; which are registered normally.
Now, to create a link from /sys/class/net/a->name/linkname to b, one should
use:
sysfs_create_link(&(a->dev.kobj), &(b->dev.kobj), linkname);
To
interface once.
dev_ioctl()
rtnl_lock()
dev_ifsioc()
bond_do_ioctl()
rtnl_unlock()
Additionally we also change the coding style in bond_do_ioctl(),
letting it more readable for us.
Cc: Jay Vosburgh
Cc: Veaceslav Falico
Acked-by: Veaceslav Falico
Signed-off-by: Ying Xue
---
drivers/net
now a file that returns the "mode" of the interrupt (msi vs.
msix).
Signed-off-by: Greg Kroah-Hartman
Works like a charm for me.
FWIW,
Reviewed-by: Veaceslav Falico
---
Neil, can you test this patch to see if irqbalance works as-is or not?
thanks,
greg k-h
d
er.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Best regards,
Veaceslav Falico
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vg
_set_rx_mode()") in net-next.
>
> --
> Robin Hugh Johnson
> Gentoo Linux: Developer, Trustee & Infrastructure Lead
> E-Mail : robb...@gentoo.org
> GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
--
Best regards,
Veaceslav Falico
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tue, Oct 29, 2013 at 09:34:28AM -0700, Linus Torvalds wrote:
On Tue, Oct 29, 2013 at 3:30 AM, Veaceslav Falico wrote:
/*
* Its possible that we get into this path
* When populate_msi_sysfs fails, which means the entries
hich will take care of all the
kobjects properly.
And add the forgotten pci_dev_put(pdev) in case of failure to register the
kobject in populate_msi_sysfs().
CC: Bjorn Helgaas
CC: Neil Horman
CC: Greg Kroah-Hartman
CC: linux-...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-b
.org
Signed-off-by: Veaceslav Falico
---
drivers/pci/msi.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 0771508..dafda2b 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -391,6 +391,11 @@ static void free_msi_irqs(s
artman
CC: linux-...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Veaceslav Falico
---
drivers/pci/msi.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 5d70f49..0771508 100644
--- a/drivers/pci/msi.c
+++ b/d
On Mon, Oct 28, 2013 at 11:35:09AM -0600, Bjorn Helgaas wrote:
On Mon, Oct 28, 2013 at 11:30 AM, Veaceslav Falico wrote:
On Mon, Oct 28, 2013 at 11:23:41AM -0600, Bjorn Helgaas wrote:
[+cc Veaceslav]
On Sun, Oct 27, 2013 at 3:24 PM, Greg Kroah-Hartman
wrote:
On Sun, Oct 27, 2013 at 09:13
On Mon, Oct 28, 2013 at 11:23:41AM -0600, Bjorn Helgaas wrote:
[+cc Veaceslav]
On Sun, Oct 27, 2013 at 3:24 PM, Greg Kroah-Hartman
wrote:
On Sun, Oct 27, 2013 at 09:13:29PM +, Linus Torvalds wrote:
.. and one more case of freeing a delayed work object (likely a kobject again):
This time
On Fri, Oct 04, 2013 at 10:46:31AM -0600, Bjorn Helgaas wrote:
On Sat, Sep 28, 2013 at 3:37 PM, Veaceslav Falico wrote:
On Thu, Sep 26, 2013 at 11:59:51AM +0200, Veaceslav Falico wrote:
Currently, we first do kobject_put(&entry->kobj) and the kfree(entry),
however kobject_put()
On Fri, Sep 27, 2013 at 09:01:58PM +0200, Zdenek Kabelac wrote:
Dne 27.9.2013 18:01, Veaceslav Falico napsal(a):
On Fri, Sep 27, 2013 at 09:58:28AM -0600, Bjorn Helgaas wrote:
[+cc Veaceslav, linux-pci]
On Fri, Sep 27, 2013 at 7:34 AM, Zdenek Kabelac wrote:
Hi
With recent build of 3.12-rc2
On Thu, Sep 26, 2013 at 11:59:51AM +0200, Veaceslav Falico wrote:
Currently, we first do kobject_put(&entry->kobj) and the kfree(entry),
however kobject_put() doesn't guarantee us that it was the last reference
and that the kobj isn't used currently by someone else, so after we
On Fri, Sep 27, 2013 at 09:58:28AM -0600, Bjorn Helgaas wrote:
[+cc Veaceslav, linux-pci]
On Fri, Sep 27, 2013 at 7:34 AM, Zdenek Kabelac wrote:
Hi
With recent build of 3.12-rc2 I'm getting this warning report from kernel:
(hw Lenovo T61, C2D, 4GB Ram)
(repost since linux-kernel@ rejected my
On Thu, Sep 26, 2013 at 04:16:13PM -0600, Bjorn Helgaas wrote:
[+cc Russell]
On Thu, Sep 26, 2013 at 04:07:51PM +0200, Veaceslav Falico wrote:
On Thu, Sep 26, 2013 at 02:25:52PM +0200, Veaceslav Falico wrote:
>On Wed, Sep 25, 2013 at 05:35:54PM -0600, Bjorn Helgaas wrote:
>>On We
artman
CC: linux-...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Veaceslav Falico
---
drivers/pci/msi.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 5d70f49..0771508 100644
--- a/drivers/pci/msi.c
+++ b/d
l.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Veaceslav Falico
---
drivers/pci/msi.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index dafda2b..d62c468 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -384,12 +3
.org
Signed-off-by: Veaceslav Falico
---
Notes:
v1 -> v2:
Verify if the kset was actually register before unregistering.
drivers/pci/msi.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 0771508..dafda2b 100644
--- a/dr
On Thu, Sep 26, 2013 at 02:25:52PM +0200, Veaceslav Falico wrote:
On Wed, Sep 25, 2013 at 05:35:54PM -0600, Bjorn Helgaas wrote:
On Wed, Sep 25, 2013 at 5:23 PM, Neil Horman wrote:
On Wed, Sep 25, 2013 at 03:08:05PM -0600, Bjorn Helgaas wrote:
[+cc Neil (he added this code in da8d1c8ba4
On Wed, Sep 25, 2013 at 05:35:54PM -0600, Bjorn Helgaas wrote:
On Wed, Sep 25, 2013 at 5:23 PM, Neil Horman wrote:
On Wed, Sep 25, 2013 at 03:08:05PM -0600, Bjorn Helgaas wrote:
[+cc Neil (he added this code in da8d1c8ba4), Greg]
On Mon, Sep 16, 2013 at 7:47 PM, Veaceslav Falico wrote
hich will take care of all the
kobjects properly.
And add the forgotten pci_dev_put(pdev) in case of failure to register the
kobject in populate_msi_sysfs().
CC: Bjorn Helgaas
CC: Neil Horman
CC: Greg Kroah-Hartman
CC: linux-...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Veace
On Wed, Sep 25, 2013 at 05:35:54PM -0600, Bjorn Helgaas wrote:
On Wed, Sep 25, 2013 at 5:23 PM, Neil Horman wrote:
On Wed, Sep 25, 2013 at 03:08:05PM -0600, Bjorn Helgaas wrote:
[+cc Neil (he added this code in da8d1c8ba4), Greg]
On Mon, Sep 16, 2013 at 7:47 PM, Veaceslav Falico wrote
On Wed, Sep 25, 2013 at 03:34:58PM -0600, Bjorn Helgaas wrote:
On Mon, Sep 16, 2013 at 7:47 PM, Veaceslav Falico wrote:
Currently, we first do kobject_put(&entry->kobj) and the kfree(entry),
however kobject_put() doesn't guarantee us that it was the last reference
and that the kob
On Wed, Sep 25, 2013 at 03:30:14PM -0600, Bjorn Helgaas wrote:
On Wed, Sep 25, 2013 at 3:08 PM, Bjorn Helgaas wrote:
Also, I think it is incorrect that free_msi_irqs() does this:
if (entry->kobj.parent) {
kobject_del(&entry->kobj);
linux-...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Veaceslav Falico
---
drivers/pci/msi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index d5f90d6..14bf578 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -
will take care of all the
kobjects properly.
CC: Bjorn Helgaas
CC: linux-...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Veaceslav Falico
---
drivers/pci/msi.c | 27 +--
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/drivers/pci/msi.c b
ister part to free_msi_irqs() and remove already
existing ones.
CC: Bjorn Helgaas
CC: linux-...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Veaceslav Falico
---
drivers/pci/msi.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/msi.c b/driv
ry
containing kobject will only be delisted in free_msi_irqs(), and free only
when there are no other users of its kobject.
CC: Bjorn Helgaas
CC: linux-...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Veaceslav Falico
---
drivers/pci/msi.c | 38 +++
On Wed, Apr 17, 2013 at 01:25:13PM +0930, Rusty Russell wrote:
Veaceslav Falico writes:
Tested for a day on two reproducers on the latest upstream kernel, with the
recent kobject fix a49b7e82 ("kobject: fix kset_find_obj() race with
concurrent last kobject_put()") - it fixes the
On Mon, Apr 15, 2013 at 11:56:03AM +0930, Rusty Russell wrote:
Veaceslav Falico writes:
On Wed, Apr 10, 2013 at 04:47:34PM +0930, Rusty Russell wrote:
That's a bug. We should be cleaning up sysfs before we unlike the
removed module from the list.
Because the same thing applies to d
On Thu, Apr 11, 2013 at 08:20:03AM -0700, Greg KH wrote:
On Thu, Apr 11, 2013 at 03:53:40PM +0200, Veaceslav Falico wrote:
On Thu, Apr 11, 2013 at 06:28:31AM -0700, Greg KH wrote:
>On Thu, Apr 11, 2013 at 11:55:37AM +0200, Veaceslav Falico wrote:
...
In both examples we don't look
On Thu, Apr 11, 2013 at 06:28:31AM -0700, Greg KH wrote:
On Thu, Apr 11, 2013 at 11:55:37AM +0200, Veaceslav Falico wrote:
However, I think my patch still adds something good, cause now we have 2
cases where we basically do:
k = kset_find_obj();
if (!k)
return;
kobject_put(k);
which
On Wed, Apr 10, 2013 at 04:47:34PM +0930, Rusty Russell wrote:
Veaceslav Falico writes:
Add a new function, kset_obj_exists(), which is identical to
kset_find_obj() but doesn't take a reference to the kobject
found and only returns bool if found/not found.
The main purpose would be to
On Thu, Apr 11, 2013 at 11:28:06AM +0930, Rusty Russell wrote:
Greg KH writes:
On Tue, Apr 09, 2013 at 01:22:09PM +0200, Veaceslav Falico wrote:
Add a new function, kset_obj_exists(), which is identical to
kset_find_obj() but doesn't take a reference to the kobject
found and only re
x27;t need to
kobject_put() afterwards).
Signed-off-by: Veaceslav Falico
---
drivers/pci/slot.c |5 +
include/linux/kobject.h |1 +
kernel/module.c |5 +
lib/kobject.c | 28
4 files changed, 31 insertions(+), 8 deletions(-)
ate_speed_duplex(slave);
>>> + read_lock(&bond->lock);
>>>
>>> pr_info("%s: link status definitely up for
>>> interface %s, %u Mbps %s duplex.\n",
>>>
53 matches
Mail list logo
