Re: [PATCH][next] scsi: cxgb4i: fix dereference of pointer tdata before it is null checked

2020-07-13 Thread Varun Prakash
nfo = &tdata->ttinfo; > - struct sk_buff *skb = tdata->skb; > + struct sk_buff *skb; > struct cxgbi_sock *csk = NULL; > u32 pdulen = 0; > u32 datalen; > @@ -2378,6 +2379,7 @@ int cxgbi_conn_xmit_pdu(struct iscsi_task *task) > ret

Re: [PATCH -next] cxgbit: remove set but not used variable 'ppmax'

2019-06-14 Thread Varun Prakash
; > if (!lldi->vr->iscsi.size) { > @@ -308,8 +307,6 @@ int cxgbit_ddp_init(struct cxgbit_device *cdev) > return -EACCES; > } > > - ppmax = lldi->vr->iscsi.size >> PPOD_SIZE_SHIFT; > - > memset(&tformat, 0, sizeof(stru

Re: [PATCH] scsi: csiostor: remove redundant assignment to pointer 'ln'

2018-01-29 Thread Varun Prakash
vt[] = { > static struct csio_lnode * > csio_ln_lookup_by_portid(struct csio_hw *hw, uint8_t portid) > { > - struct csio_lnode *ln = hw->rln; > + struct csio_lnode *ln; > struct list_head *tmp; > > /* Match siblings lnode with portid */ Acked-by: Varun Prakash

Re: [PATCH] csi: libcxgbi: remove redundant check and close on csk

2017-09-11 Thread Varun Prakash
; --- a/drivers/scsi/cxgbi/libcxgbi.c > +++ b/drivers/scsi/cxgbi/libcxgbi.c > @@ -688,8 +688,6 @@ cxgbi_check_route(struct sockaddr *dst_addr, int ifindex) > > rel_rt: > ip_rt_put(rt); > - if (csk) > - cxgbi_sock_closed(csk); > err_out: > return ERR_PTR(err); > } Acked-by: Varun Prakash

Re: [PATCH] csiostor: Avoid content leaks and casts

2017-05-23 Thread Varun Prakash
On Mon, May 22, 2017 at 09:29:41AM -0700, Kees Cook wrote: > On Mon, May 22, 2017 at 8:05 AM, Varun Prakash wrote: > > On Tue, May 09, 2017 at 03:34:44PM -0700, Kees Cook wrote: > >> When copying attributes, the len argument was padded out and the resulting > >> memcpy(

Re: [PATCH] csiostor: Avoid content leaks and casts

2017-05-22 Thread Varun Prakash
On Tue, May 09, 2017 at 03:34:44PM -0700, Kees Cook wrote: > When copying attributes, the len argument was padded out and the resulting > memcpy() would copy beyond the end of the source buffer. Avoid this, > and use size_t for val_len to avoid all the casts. Similarly, avoid source > buffer casts

Re: [PATCH] cxgb4i: Add a missing call to neigh_release

2016-11-30 Thread Varun Prakash
ese calls > Quentin> where they are missing. > > Varun: Please review! > Looks good. Acked-by: Varun Prakash

Re: [PATCH] cxgbit: fix dma_addr_t printk format

2016-03-07 Thread Varun Prakash
On Sat, Mar 05, 2016 at 01:04:41AM +0100, Arnd Bergmann wrote: > The newly added driver prints a dma_addr_t using the %llx format string, > but that is wrong on most 32-bit architectures: > > drivers/target/iscsi/cxgbit/cxgbit_ddp.c: In function 'cxgbit_dump_sgl': > drivers/target/iscsi/cxgbit/cxg

Re: [PATCH] target/cxgbit: add INET dependency

2016-02-29 Thread Varun Prakash
On Tue, Mar 01, 2016 at 10:58:28AM +0530, Nicholas A. Bellinger wrote: > Hi Arnd, > > On Mon, 2016-02-29 at 12:14 +0100, Arnd Bergmann wrote: > > The newly added cxgbit driver directly calls functions of the > > IPv4 network stack, which fails if that is disabled: > > > > ERROR: "ip_route_output_