Re: [PATCH] pch_dma: Use GFP_ATOMIC because called from interrupt context

Hi Could you review this patch ? 8 days have passed... thanks, tomoya On Tue, Feb 12, 2013 at 11:25 AM, Tomoya MORINAGA wrote: > pdc_desc_get() is called from pd_prep_slave_sg, and the function is > called from interrupt context(e.g. Uart driver "pch_uart.c"). > In fact,

[PATCH] pch_dma: Use GFP_ATOMIC because called from interrupt context

pdc_desc_get() is called from pd_prep_slave_sg, and the function is called from interrupt context(e.g. Uart driver "pch_uart.c"). In fact, I saw kernel error message. So, GFP_ATOMIC must be used not GFP_NOIO. Signed-off-by: Tomoya MORINAGA --- drivers/dma/pch_dma.c |2 +- 1 files

Re: add Packet hub driver for Topcliff Platform controller hub

Hi Dan, On Mon, Jan 7, 2013 at 6:02 PM, Dan Carpenter wrote: > The patch cf4ece53460c: "add Packet hub driver for Topcliff Platform > controller hub" from Sep 1, 2010, leads to the following warning: > drivers/misc/pch_phub.c:596 pch_phub_bin_write() > error: buffer overflow 'buf' 4096 <

Re: [PATCH] misc/pch_phub: Enable UART clock setting by module parameter

On Wed, Jul 25, 2012 at 10:31 PM, Arnd Bergmann wrote: > What I think should work better here would be to use the clk API, > so that the phub driver registers a 'struct clk' using > (I assume) clk_register_divider_table(). > The UART driver would then call clk_get() to find that clk for > the uart

Re: [PATCH] misc/pch_phub: Enable UART clock setting by module parameter

., Ltd. tomoya On Thu, Jul 12, 2012 at 9:54 AM, Tomoya MORINAGA wrote: > On Wed, Jul 11, 2012 at 7:45 PM, Arnd Bergmann wrote: >> This looks like a rather nonscalable solution if you get to systems >> with lots of clocks. > > This "clock" is internal clock, not e

[PATCH v3] usb/host/ehci-hub: Fix the issue EG20T USB host controller has long resuming time, when pen drive is attached.

: Tomoya MORINAGA --- v3: Update comments from Alan Stern Add comment in the source code. v2: Update comments from Alan Stern Add patch description Always clear the STS_FLR flag. --- drivers/usb/host/ehci-hub.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions

[PATCH v2] usb/host/ehci-hub: Fix the issue EG20T USB host controller has long resuming time, when pen drive is attached.

: Tomoya MORINAGA --- v2: Update comments from Alan Stern Add patch description Always clear the STS_FLR flag. --- drivers/usb/host/ehci-hub.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c index

Re: [PATCH] misc/pch_phub: Enable UART clock setting by module parameter

On Wed, Jul 11, 2012 at 7:45 PM, Arnd Bergmann wrote: > This looks like a rather nonscalable solution if you get to systems > with lots of clocks. This "clock" is internal clock, not external clock. This PacketHub provides clock to the UART module Both the PacketHub and the UART is in 1 chip LSI

[PATCH] misc/pch_phub: Enable UART clock setting by module parameter

Currently, when a user wants to change UART clock, needs to modify this source code by hand. This patch enables changing UART clock by specifying UART clock as module parameter. Signed-off-by: Tomoya MORINAGA --- drivers/misc/pch_phub.c | 45 + 1

[PATCH] usb/host/ehci-hub: Fix the issue EG20T USB host controller has long resuming time, when pen drive is attached.

Signed-off-by: Tomoya MORINAGA --- drivers/usb/host/ehci-hub.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c index fc9e7cc..d596d0f 100644 --- a/drivers/usb/host/ehci-hub.c +++ b/drivers/usb/host/ehci-hub.c