[PATCH v2] selftests: intel_pstate: ftime() is deprecated

2020-11-01 Thread Tommi Rantala
39 | extern int ftime (struct timeb *__timebuf) |^ Signed-off-by: Tommi Rantala --- tools/testing/selftests/intel_pstate/aperf.c | 22 ++-- 1 file changed, 16 insertions(+), 6 deletions(-) v2: define and use NSEC_PER_MSEC and MSEC_PER_SEC diff --git a/t

[PATCH] selftests: intel_pstate: ftime() is deprecated

2020-10-16 Thread Tommi Rantala
39 | extern int ftime (struct timeb *__timebuf) |^ Signed-off-by: Tommi Rantala --- tools/testing/selftests/intel_pstate/aperf.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/intel_pstate/aperf.c b/t

[PATCH] perf test: Implement skip_reason callback for watchpoint tests

2020-10-16 Thread Tommi Rantala
point : Ok Signed-off-by: Tommi Rantala --- tools/perf/tests/builtin-test.c | 1 + tools/perf/tests/tests.h| 1 + tools/perf/tests/wp.c | 21 +++-- 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/tools/perf/tests/builtin-t

[PATCH] perf tools: Fix crash with non-jited bpf progs

2020-10-16 Thread Tommi Rantala
/proc/kallsyms a9b6b3b0 t __bpf_prog_run224 a9b6b3f0 t __bpf_prog_run192 a9b6b530 t __bpf_prog_run32 Fix by not allowing vmlinux_map to be removed by PERF_RECORD_KSYMBOL unregister event. Signed-off-by: Tommi Rantala --- tools/perf/util/machine.c | 11 ++-

[PATCH 12/13] selftests: clone3: use SKIP instead of XFAIL

2020-10-08 Thread Tommi Rantala
XFAIL is gone since 9847d24af95c ("selftests/harness: Refactor XFAIL into SKIP"), use SKIP instead. Fixes: 9847d24af95c ("selftests/harness: Refactor XFAIL into SKIP") Signed-off-by: Tommi Rantala --- tools/testing/selftests/clone3/clone3_cap_checkpoint_restore.c | 2 +

[PATCH 06/13] selftests: pidfd: skip test on kcmp() ENOSYS

2020-10-08 Thread Tommi Rantala
Skip test if kcmp() is not available, for example if kernel is compiled without CONFIG_CHECKPOINT_RESTORE=y. Signed-off-by: Tommi Rantala --- tools/testing/selftests/pidfd/pidfd_getfd_test.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/pidfd

[PATCH 10/13] selftests: proc: fix warning: _GNU_SOURCE redefined

2020-10-08 Thread Tommi Rantala
Makefile already contains -D_GNU_SOURCE, so we can remove it from the *.c files. Signed-off-by: Tommi Rantala --- tools/testing/selftests/proc/proc-loadavg-001.c | 1 - tools/testing/selftests/proc/proc-self-syscall.c | 1 - tools/testing/selftests/proc/proc-uptime-002.c | 1 - 3 files

[PATCH 08/13] selftests: pidfd: drop needless linux/kcmp.h inclusion in pidfd_setns_test.c

2020-10-08 Thread Tommi Rantala
kcmp is not used in pidfd_setns_test.c, so do not include Signed-off-by: Tommi Rantala --- tools/testing/selftests/pidfd/pidfd_setns_test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/pidfd/pidfd_setns_test.c b/tools/testing/selftests/pidfd/pidfd_setns_test.c

[PATCH 07/13] selftests: pidfd: add CONFIG_CHECKPOINT_RESTORE=y to config

2020-10-08 Thread Tommi Rantala
kcmp syscall is used in pidfd_getfd_test.c, so add CONFIG_CHECKPOINT_RESTORE=y to config to ensure kcmp is available. Signed-off-by: Tommi Rantala --- tools/testing/selftests/pidfd/config | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/pidfd/config b/tools/testing

[PATCH 11/13] selftests: core: use SKIP instead of XFAIL in close_range_test.c

2020-10-08 Thread Tommi Rantala
XFAIL is gone since 9847d24af95c ("selftests/harness: Refactor XFAIL into SKIP"), use SKIP instead. Fixes: 9847d24af95c ("selftests/harness: Refactor XFAIL into SKIP") Signed-off-by: Tommi Rantala --- tools/testing/selftests/core/close_range_test.c | 8 1 file c

[PATCH 09/13] selftests: android: fix multiple definition of sock_name

2020-10-08 Thread Tommi Rantala
Fix multiple definition of sock_name compilation error: tools/testing/selftests/android/ion/ipcsocket.h:8: multiple definition of `sock_name' Signed-off-by: Tommi Rantala --- tools/testing/selftests/android/ion/ipcsocket.c | 1 + tools/testing/selftests/android/ion/ipcsocket.h | 2

[PATCH 04/13] selftests/harness: prettify SKIP message whitespace again

2020-10-08 Thread Tommi Rantala
Commit 9847d24af95c ("selftests/harness: Refactor XFAIL into SKIP") replaced XFAIL with SKIP in the output. Add one more space to make the output aligned and pretty again. Fixes: 9847d24af95c ("selftests/harness: Refactor XFAIL into SKIP") Signed-off-by: Tommi Rantala

[PATCH 00/13] selftests fixes

2020-10-08 Thread Tommi Rantala
Hi, small fixes to issues I hit with selftests. Tommi Rantala (13): selftests: filter kselftest headers from command in lib.mk selftests: pidfd: fix compilation errors due to wait.h selftests: add vmaccess to .gitignore selftests/harness: prettify SKIP message whitespace again selftests

[PATCH 13/13] selftests: binderfs: use SKIP instead of XFAIL

2020-10-08 Thread Tommi Rantala
XFAIL is gone since 9847d24af95c ("selftests/harness: Refactor XFAIL into SKIP"), use SKIP instead. Fixes: 9847d24af95c ("selftests/harness: Refactor XFAIL into SKIP") Signed-off-by: Tommi Rantala --- .../selftests/filesystems/binderfs/binderfs_test.c| 8 ---

[PATCH 05/13] selftests: pidfd: use ksft_test_result_skip() when skipping test

2020-10-08 Thread Tommi Rantala
using ksft_test_result_skip(): $ ./pidfd_test TAP version 13 1..8 [...] ok 8 # SKIP pidfd_send_signal signal recycled pid test: Unsharing pid namespace not permitted # Totals: pass:7 fail:0 xfail:0 xpass:0 skip:1 error:0 Signed-off-by: Tommi Rantala --- tools/testing/selftests/

[PATCH 02/13] selftests: pidfd: fix compilation errors due to wait.h

2020-10-08 Thread Tommi Rantala
Drop unneeded header inclusion to fix pidfd compilation errors seen in Fedora 32: In file included from pidfd_open_test.c:9: ../../../../usr/include/linux/wait.h:17:16: error: expected identifier before numeric constant 17 | #define P_ALL 0 |^ Signed-off-by: Tommi

[PATCH 01/13] selftests: filter kselftest headers from command in lib.mk

2020-10-08 Thread Tommi Rantala
headers, so that we'll only pass the actual *.c files in the compiler command line. Fixes: 1056d3d2c97e ("selftests: enforce local header dependency in lib.mk") Signed-off-by: Tommi Rantala --- tools/testing/selftests/lib.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 03/13] selftests: add vmaccess to .gitignore

2020-10-08 Thread Tommi Rantala
Commit 2de4e82318c7 ("selftests/ptrace: add test cases for dead-locks") added vmaccess testcase, add the binary to .gitignore Fixes: 2de4e82318c7 ("selftests/ptrace: add test cases for dead-locks") Signed-off-by: Tommi Rantala --- tools/testing/selftests/ptrace/.gitignore |

[tip: perf/core] perf bench: Fix div-by-zero if runtime is zero

2020-05-08 Thread tip-bot2 for Tommi Rantala
The following commit has been merged into the perf/core branch of tip: Commit-ID: 41e7c32b978974adaadd4808ba42f9026634dca3 Gitweb: https://git.kernel.org/tip/41e7c32b978974adaadd4808ba42f9026634dca3 Author:Tommi Rantala AuthorDate:Fri, 17 Apr 2020 16:23:29 +03:00

[tip: perf/core] perf cgroup: Avoid needless closing of unopened fd

2020-05-08 Thread tip-bot2 for Tommi Rantala
The following commit has been merged into the perf/core branch of tip: Commit-ID: d2e7d8636fb7d3e30aa8f894003f9e293ea62eea Gitweb: https://git.kernel.org/tip/d2e7d8636fb7d3e30aa8f894003f9e293ea62eea Author:Tommi Rantala AuthorDate:Fri, 17 Apr 2020 16:23:26 +03:00

[tip: perf/core] perf test session topology: Fix data path

2020-05-08 Thread tip-bot2 for Tommi Rantala
The following commit has been merged into the perf/core branch of tip: Commit-ID: dbd660e6b2884b864d2642d930a163d3bcebe4be Gitweb: https://git.kernel.org/tip/dbd660e6b2884b864d2642d930a163d3bcebe4be Author:Tommi Rantala AuthorDate:Thu, 23 Apr 2020 14:53:40 +03:00

[tip:perf/core] perf tests shell: Skip trace+probe_vfs_getname.sh if built without trace support

2019-02-27 Thread tip-bot for Tommi Rantala
Commit-ID: 83244772a4cf9490a54182be2f65f45d6b1a1ee8 Gitweb: https://git.kernel.org/tip/83244772a4cf9490a54182be2f65f45d6b1a1ee8 Author: Tommi Rantala AuthorDate: Fri, 15 Feb 2019 15:42:46 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 15 Feb 2019 13:42:26 -0300 perf tests

[PATCH] perf tests shell: Skip trace+probe_vfs_getname.sh if built without trace support

2019-02-15 Thread Tommi Rantala
From: Tommi Rantala If perf was built without trace support, trace+probe_vfs_getname.sh fails: # perf trace -h perf: 'trace' is not a perf-command. See 'perf --help' # perf test 64 64: Check open filename arg using perf trace + vfs_getname: FAILED! Check trace su

perf trace --no-syscalls -e rcu:* -- garbage in output

2018-06-26 Thread Tommi Rantala
Hi, There some garbage in perf trace output, when tracing some rcu tracepoints (kernel is configured with CONFIG_RCU_TRACE=y). For example in rcu:rcu_callback, instead of getting proper rcuname in the first "%s" here, there's garbage: $ tail -1 /sys/kernel/debug/tracing/events/rcu/rcu_callb

Re: backporting "ext4: inplace xattr block update fails to deduplicate blocks" to LTS kernels?

2018-02-22 Thread Tommi Rantala
On 21.02.2018 17:56, Theodore Ts'o wrote: On Wed, Feb 21, 2018 at 12:40:00PM +0100, Greg Kroah-Hartman wrote: On Mon, Feb 19, 2018 at 03:26:37PM +0200, Tommi Rantala wrote: OK to backport it? I tested it briefly in 4.9, seems to work. It looks sane, but it would be nice if I can get p

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-02-21 Thread Tommi Rantala
On 20.02.2018 18:26, Neil Horman wrote: On Tue, Feb 20, 2018 at 09:14:41AM +0100, Dmitry Vyukov wrote: On Tue, Feb 20, 2018 at 8:56 AM, Tommi Rantala wrote: On 19.02.2018 20:59, Dmitry Vyukov wrote: Is this meant to be fixed already? I am still seeing this on the latest upstream tree

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-02-19 Thread Tommi Rantala
stream tree. These two commits are in v4.16-rc1: commit 4a31a6b19f9ddf498c81f5c9b089742b7472a6f8 Author: Tommi Rantala Date: Mon Feb 5 21:48:14 2018 +0200 sctp: fix dst refcnt leak in sctp_v4_get_dst ... Fixes: 410f03831 ("sctp: add routing output fallback") Fixes: 0ca50d12

backporting "ext4: inplace xattr block update fails to deduplicate blocks" to LTS kernels?

2018-02-19 Thread Tommi Rantala
Hi, 4.9 (and earlier) LTS kernels are missing this: commit ec00022030da5761518476096626338bd67df57a Author: Tahsin Erdogan Date: Sat Aug 5 22:41:42 2017 -0400 ext4: inplace xattr block update fails to deduplicate blocks OK to backport it? I tested it briefly in 4.9, seems to work. One

intel_pmu_init() extra_attr memory leak

2017-12-19 Thread Tommi Rantala
Hi, I'm seeing this kmemleak report in v4.15-rc4: # cat /sys/kernel/debug/kmemleak unreferenced object 0x8801f3d5d720 (size 64): comm "swapper/0", pid 1, jiffies 4294667312 (age 2687.423s) hex dump (first 32 bytes): 60 d1 41 ad ff ff ff ff 20 d1 41 ad ff ff ff ff `.A. .A.

Re: [PATCH net v2] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

2017-12-01 Thread Tommi Rantala
On 01.12.2017 15:18, Ying Xue wrote: On 11/30/2017 08:32 PM, Tommi Rantala wrote: In my opinion, the real root cause of the issue is because we too early set a not-yet-initialized bearer instance to ub->bearer through rcu_assign_pointer(ub->bearer, b) in tipc_udp_enable(). Instead if we

Re: [PATCH net v2] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

2017-11-30 Thread Tommi Rantala
On 30.11.2017 12:57, Ying Xue wrote: On 11/29/2017 06:48 PM, Tommi Rantala wrote: Remove the second tipc_rcv() call in tipc_udp_recv(). We have just checked that the bearer is not up, and calling tipc_rcv() with a bearer that is not up leads to a TIPC div-by-zero crash in

[PATCH net v2] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

2017-11-29 Thread Tommi Rantala
0 seconds.. Fixes: c9b64d492b1f ("tipc: add replicast peer discovery") Signed-off-by: Tommi Rantala Cc: Jon Maloy --- v2: Resorted to a minimal fix, as per feedback from David M. net/tipc/udp_media.c | 4 1 file changed, 4 deletions(-) diff --git a/net/tipc/udp_media.c

Re: [PATCH] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

2017-11-28 Thread Tommi Rantala
On 28.11.2017 16:58, David Miller wrote: From: Tommi Rantala Date: Tue, 28 Nov 2017 14:53:15 +0200 - - if (unlikely(msg_user(hdr) == LINK_CONFIG)) { - err = tipc_udp_rcast_disc(b, skb); - if (err) - goto rcu_out; + } else

[PATCH] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

2017-11-28 Thread Tommi Rantala
rom 0x8200 (relocation range: 0x8000-0xbfff) [ 12.751215] Rebooting in 60 seconds.. Fixes: c9b64d492b1f ("tipc: add replicast peer discovery") Signed-off-by: Tommi Rantala --- net/tipc/udp_media.c | 29 +++-- 1 file changed, 7 inse

tipc_node_calculate_timer div-by-zero

2017-11-27 Thread Tommi Rantala
Hi, I'm seeing a rare TIPC div-by-zero crash in tipc_node_calculate_timer(). If I get it right, we're receiving a discovery packet while enabling a bearer. The bearer is not yet fully initialized, causing the discovery packet processing to use zero tolerance value, which then causes the div-b

Re: tipc_udp_send_msg oops in 4.4 when setting link tolerance

2017-11-15 Thread Tommi Rantala
On 14.11.2017 13:35, Jon Maloy wrote: Found it, the missing patch is this one (9b3009604b8e does not help): commit d01332f1acacc0cb43a61f4244dd2b846d4cd585 Author: Richard Alpe Date: Mon Feb 1 08:19:56 2016 +0100 tipc: fix link attribute propagation bug It does not apply as-is to 4.4

Re: tipc_udp_send_msg oops in 4.4 when setting link tolerance

2017-11-14 Thread Tommi Rantala
if I can figure it out. -Tommi From e1857e6c60355296fd1cbe6e376d8a7265c2b289 Mon Sep 17 00:00:00 2001 From: Richard Alpe Date: Tue, 14 Nov 2017 11:09:50 +0200 Subject: [PATCH] tipc: fix link attribute propagation bug commit d01332f1acacc0cb43a61f4244dd2b846d4cd585 upstream. [backported to 4.4

tipc_udp_send_msg oops in 4.4 when setting link tolerance

2017-11-13 Thread Tommi Rantala
Hi, I always get an instant TIPC oops in 4.4, when I try to set the link tolerance (with LINKNAME != "broadcast-link"): $ tipc link set tolerance 1000 link $LINKNAME Any idea what's going on? Some tipc patch missing in 4.4? In 4.9 the "tipc" command executes just fine, but I've seen a few t

4.9.30 NULL pointer dereference in __remove_shared_vm_struct

2017-06-07 Thread Tommi Rantala
Hi, I have hit this kernel bug twice with 4.9.30 while running trinity, any ideas? It's not easily reproducible. Perhaps I should enable some more debug options to see if they reveal anything... (note that I had different kernel builds, so the IP addresses are different in the logs below)

Re: nouveau "eDP-1: EDID is invalid" regression after 4.11 with HP ZBook 15 G3

2017-06-03 Thread Tommi Rantala
2017-05-15 8:20 GMT+03:00 Tommi Rantala : > 2017-05-15 3:03 GMT+03:00 Ben Skeggs : >> On 05/15/2017 01:10 AM, Tommi Rantala wrote: >>> >>> Hi, >> >> Hey Tommi, >> >> Thanks for bisecting this. It's rather unexpected that you should be seeing

Re: (radeon?) WARNING: drivers/gpu/drm/drm_irq.c:1195 drm_vblank_put (v4.11-12441-g56868a4)

2017-05-22 Thread Tommi Rantala
2017-05-22 10:32 GMT+03:00 Daniel Vetter : > Yeah I think the locking stuff we've fixed, at least if you don't see it > in 4.12 it should be all good. And I think I spotted the bug you've > bisected to, patch is on dri-devel, pls test. Thanks! I'll test it later today. -Tommi

Re: (radeon?) WARNING: drivers/gpu/drm/drm_irq.c:1195 drm_vblank_put (v4.11-12441-g56868a4)

2017-05-18 Thread Tommi Rantala
2017-05-11 5:51 GMT+03:00 Michel Dänzer : > On 11/05/17 04:33 AM, Tommi Rantala wrote: >> Complete kernel log: >> http://termbin.com/dzy5 >> >> [ 249.952546] [ cut here ] >> [ 249.952593] WARNING: CPU: 5 PID: 0 at >> /home/ttrantal/g

Re: nouveau "eDP-1: EDID is invalid" regression after 4.11 with HP ZBook 15 G3

2017-05-14 Thread Tommi Rantala
2017-05-15 3:03 GMT+03:00 Ben Skeggs : > On 05/15/2017 01:10 AM, Tommi Rantala wrote: >> >> Hi, > > Hey Tommi, > > Thanks for bisecting this. It's rather unexpected that you should be seeing > problems here, but, the commit makes sense for it at least. > &g

Re: nouveau "eDP-1: EDID is invalid" regression after 4.11 with HP ZBook 15 G3

2017-05-14 Thread Tommi Rantala
et just in case it's needed from DEVINIT scripts where DRM isn't available. Signed-off-by: Ben Skeggs dmesg after boot with drm.debug enabled: v4.10-10409-g5c68d91 (still works): http://termbin.com/b0is v4.10-10410-gdf8dc97 (failure): http://termbin.com/j6lq Tommi 2017-05-10 1

Re: [PATCH] hwmon: (coretemp) Handle frozen hotplug state correctly

2017-05-10 Thread Tommi Rantala
2017-05-10 23:09 GMT+03:00 Guenter Roeck : > On Wed, May 10, 2017 at 10:16:33PM +0300, Tommi Rantala wrote: >> 2017-05-10 17:30 GMT+03:00 Thomas Gleixner : >> > The recent conversion to the hotplug state machine missed that the original >> > hotplug notifiers did not

(radeon?) WARNING: drivers/gpu/drm/drm_irq.c:1195 drm_vblank_put (v4.11-12441-g56868a4)

2017-05-10 Thread Tommi Rantala
Hi, I just tested v4.11-12441-g56868a4 on HP xw6600 with radeon graphics, and I'm seeing the following WARNING triggered constantly. I have not seen this earlier e.g. with the distro kernel 4.10.13-200.fc25.x86_64 $ lspci|grep -i amd 60:00.0 VGA compatible controller: Advanced Micro Devices, Inc

Re: [PATCH] hwmon: (coretemp) Handle frozen hotplug state correctly

2017-05-10 Thread Tommi Rantala
; > Thanks to Tommi for providing debug information patiently while I failed to > spot the obvious. > > Fixes: e00ca5df37ad ("hwmon: (coretemp) Convert to hotplug state machine") > Reported-by: Tommi Rantala > Signed-off-by: Thomas Gleixner Many thanks, I can confirm t

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-05-10 Thread Tommi Rantala
2017-05-10 17:01 GMT+03:00 Thomas Gleixner : > On Wed, 10 May 2017, Tommi Rantala wrote: >> 2017-05-09 10:16 GMT+03:00 Thomas Gleixner : >> > On Thu, 4 May 2017, Tommi Rantala wrote: >> >> Here's the trace output, does it help? >> > >> > No

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-05-10 Thread Tommi Rantala
2017-05-09 10:16 GMT+03:00 Thomas Gleixner : > On Thu, 4 May 2017, Tommi Rantala wrote: >> Here's the trace output, does it help? > > Not much. Can you please try the following: > > 1) Offline all CPUs except CPU0 before suspend/resume it works! > 2) Offline all CPU

nouveau "eDP-1: EDID is invalid" regression after 4.11 with HP ZBook 15 G3

2017-05-10 Thread Tommi Rantala
Hi, The HP ZBook 15 G3 laptop builtin display (eDP-1) does not work correctly with v4.11-11413-g2868b25. When booting the laptop, the resolution seems to be limited to 1024x768, and gnome-session segfaults. Up to 4.11 the display works just fine in 1920x1080 mode. I'm seeing this in the kernel

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-05-04 Thread Tommi Rantala
2017-04-23 18:01 GMT+03:00 Thomas Gleixner : > On Sat, 15 Apr 2017, Tommi Rantala wrote: > >> Testing with 4.10.8-200.fc25.x86_64: freezer, devices and platform are >> OK, it breaks at "processors". >> The screen stays off, and the machine no longer answers to pi

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-04-15 Thread Tommi Rantala
2017-04-14 20:35 GMT+03:00 Thomas Gleixner : > On Wed, 12 Apr 2017, Thomas Gleixner wrote: >> >> Can you please try the following: >> >> # for STATE in freezer devices platform processors core; do \ >> echo $STATE; \ >> echo $STATE >/sys/power/pm_test; \ >> echo mem >/sys/power/state >> >> Th

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-04-12 Thread Tommi Rantala
2017-04-12 13:52 GMT+03:00 Thomas Gleixner : > On Wed, 12 Apr 2017, Tommi Rantala wrote: >> 2017-04-12 12:28 GMT+03:00 Thomas Gleixner : >> > On Wed, 12 Apr 2017, Tommi Rantala wrote: >> >> Resume-from-suspend stopped working in HP xw6600 in fedora kernel >>

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-04-12 Thread Tommi Rantala
2017-04-12 12:28 GMT+03:00 Thomas Gleixner : > On Wed, 12 Apr 2017, Tommi Rantala wrote: >> Resume-from-suspend stopped working in HP xw6600 in fedora kernel >> 4.10.8-200.fc25.x86_64, while it worked just fine in >> 4.9.9-200.fc25.x86_64. >> >> When powering on th

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-04-12 Thread Tommi Rantala
2016-11-23 17:28 GMT+02:00 Guenter Roeck : > > On 11/22/2016 09:42 AM, Thomas Gleixner wrote: >> >> After the first attempt to convert the coretemp driver to the hotplug state >> machine failed, we had a deeper look and went a bit farther. >> >> The driver has quite some interesting concepts vs. th

Re: [RFC][PATCH] mm: Tighten x86 /dev/mem with zeroing

2017-04-06 Thread Tommi Rantala
: this still needs mmap support. Reported-by: Tommi Rantala Signed-off-by: Kees Cook --- Tommi, can you check and see if this fixes what you're seeing? I want to make sure this actually works first. (x86info uses seek/read not mmap.) Hi, I can confirm that it works (after a

Re: sudo x86info -a => kernel BUG at mm/usercopy.c:78!

2017-03-31 Thread Tommi Rantala
On 31.03.2017 21:26, Linus Torvalds wrote: Hmm. Thinking more about this, we do allow access to the first 1MB of physical memory unconditionally (see devmem_is_allowed() in arch/x86/mm/init.c). And I think we only _reserve_ the first 64kB or something. So I guess even STRICT_DEVMEM isn't actually

Re: sudo x86info -a => kernel BUG at mm/usercopy.c:78!

2017-03-31 Thread Tommi Rantala
On 31.03.2017 08:40, Tommi Rantala wrote: The only thing that I can think of would be a rogue ptr in the bios table, but that seems unlikely. Tommi, can you put strace of x86info -mp somewhere? That will confirm/deny whether we're at least asking the kernel to do sane things. Indeed th

Re: sudo x86info -a => kernel BUG at mm/usercopy.c:78!

2017-03-30 Thread Tommi Rantala
On 30.03.2017 20:44, Laura Abbott wrote: On 03/30/2017 10:37 AM, Kees Cook wrote: Reads out of /dev/mem should be restricted to non-RAM on Fedora, yes? Tommi, do your kernels have CONFIG_STRICT_DEVMEM=y ? -Kees CONFIG_STRICT_DEVMEM should be on in all Fedora kernels. Yes, the fedora kern

Re: sudo x86info -a => kernel BUG at mm/usercopy.c:78!

2017-03-30 Thread Tommi Rantala
On 30.03.2017 23:01, Dave Jones wrote: On Thu, Mar 30, 2017 at 12:52:31PM -0700, Kees Cook wrote: > On Thu, Mar 30, 2017 at 12:41 PM, Dave Jones wrote: > > On Thu, Mar 30, 2017 at 09:45:26AM -0700, Kees Cook wrote: > > > On Wed, Mar 29, 2017 at 11:44 PM, Tommi Rant

sudo x86info -a => kernel BUG at mm/usercopy.c:78!

2017-03-29 Thread Tommi Rantala
Hi, Running: $ sudo x86info -a On this HP ZBook 15 G3 laptop kills the x86info process with segfault and produces the following kernel BUG. $ git describe v4.11-rc4-40-gfe82203 It is also reproducible with the fedora kernel: 4.9.14-200.fc25.x86_64 Full dmesg output here: https://past

[tip:perf/core] perf utils: Readlink /proc/self/exe to find the perf binary

2017-03-27 Thread tip-bot for Tommi Rantala
Commit-ID: 55f77128e7652e537d6c226d5b56821cdb5c22de Gitweb: http://git.kernel.org/tip/55f77128e7652e537d6c226d5b56821cdb5c22de Author: Tommi Rantala AuthorDate: Wed, 22 Mar 2017 15:06:24 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 27 Mar 2017 15:37:54 -0300 perf utils

[tip:perf/core] perf buildid: Do not assume that readlink() returns a null terminated string

2017-03-27 Thread tip-bot for Tommi Rantala
Commit-ID: 5a2342111c68e623e27ee7ea3d0492d8dad6bda0 Gitweb: http://git.kernel.org/tip/5a2342111c68e623e27ee7ea3d0492d8dad6bda0 Author: Tommi Rantala AuthorDate: Wed, 22 Mar 2017 15:06:20 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 27 Mar 2017 15:35:06 -0300 perf buildid

[tip:perf/core] perf utils: Null terminate buf in read_ftrace_printk()

2017-03-27 Thread tip-bot for Tommi Rantala
Commit-ID: d4b364df5f6540e8d6a38008ce2693ba73a8508a Gitweb: http://git.kernel.org/tip/d4b364df5f6540e8d6a38008ce2693ba73a8508a Author: Tommi Rantala AuthorDate: Wed, 22 Mar 2017 15:06:23 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 27 Mar 2017 15:37:35 -0300 perf utils

[tip:perf/core] perf tests: Do not assume that readlink() returns a null terminated string

2017-03-27 Thread tip-bot for Tommi Rantala
Commit-ID: 0e6ba11511aef91ba8e2528ddc681d88922d7b0b Gitweb: http://git.kernel.org/tip/0e6ba11511aef91ba8e2528ddc681d88922d7b0b Author: Tommi Rantala AuthorDate: Wed, 22 Mar 2017 15:06:21 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 27 Mar 2017 15:35:56 -0300 perf tests

[tip:perf/core] perf utils: use sizeof(buf) - 1 in readlink() call

2017-03-27 Thread tip-bot for Tommi Rantala
Commit-ID: b7126ef78612a3d4a37aadf39125cff048cebb9b Gitweb: http://git.kernel.org/tip/b7126ef78612a3d4a37aadf39125cff048cebb9b Author: Tommi Rantala AuthorDate: Wed, 22 Mar 2017 15:06:22 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 27 Mar 2017 15:36:27 -0300 perf utils

[tip:perf/core] perf buildid: Do not update SDT cache with null filename

2017-03-27 Thread tip-bot for Tommi Rantala
Commit-ID: 2ccc220238680642be87a2d010ce07f1c40edafb Gitweb: http://git.kernel.org/tip/2ccc220238680642be87a2d010ce07f1c40edafb Author: Tommi Rantala AuthorDate: Wed, 22 Mar 2017 15:06:19 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 27 Mar 2017 15:33:36 -0300 perf buildid

[PATCH 1/6] perf buildid: do not update SDT cache with null filename

2017-03-22 Thread Tommi Rantala
==by 0x428CE0: main (perf.c:614) ==2633== Address 0x0 is not stack'd, malloc'd or (recently) free'd Signed-off-by: Tommi Rantala --- tools/perf/util/build-id.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/build-id.c b/tools/perf/util/b

[PATCH 2/6] perf buildid: do not assume that readlink() returns a null terminated string

2017-03-22 Thread Tommi Rantala
rf.c:359) ==11643==by 0x428CE0: handle_internal_command (perf.c:421) ==11643==by 0x428CE0: run_argv (perf.c:467) ==11643==by 0x428CE0: main (perf.c:614) [...] Additionally, a zero length result from readlink() is not very interesting. Signed-off-by: Tommi Rantala --- tools/perf/ut

[PATCH 6/6] perf utils: readlink /proc/self/exe to find the perf binary

2017-03-22 Thread Tommi Rantala
Signed-off-by: Tommi Rantala --- tools/perf/util/header.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index ab10e9d..c6243af 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -370,15 +370,11

[PATCH 4/6] perf utils: use sizeof(buf)-1 in readlink() call

2017-03-22 Thread Tommi Rantala
Ensure that we have space for the null byte in buf. Signed-off-by: Tommi Rantala --- tools/perf/util/header.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index 05714d5..ab10e9d 100644 --- a/tools/perf/util/header.c

[PATCH 5/6] perf utils: null terminate buf in read_ftrace_printk()

2017-03-22 Thread Tommi Rantala
by 0x429F5D: cmd_annotate (builtin-annotate.c:472) ==31357==by 0x497150: run_builtin (perf.c:359) ==31357==by 0x428CE0: handle_internal_command (perf.c:421) ==31357==by 0x428CE0: run_argv (perf.c:467) ==31357==by 0x428CE0: main (perf.c:614) Signed-off-by: Tommi Rantala ---

[PATCH 3/6] perf tests: do not assume that readlink() returns a null terminated string

2017-03-22 Thread Tommi Rantala
Ensure that the string in buf is null terminated. Signed-off-by: Tommi Rantala --- tools/perf/tests/sdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/sdt.c b/tools/perf/tests/sdt.c index f59d210..121949a 100644 --- a/tools/perf/tests/sdt.c +++ b/tools

[PATCH 0/6] perf string handling fixes

2017-03-22 Thread Tommi Rantala
Hi, Some small perf fixes, mostly caught with valgrind. The last patch is a simplification: it is easier to open /proc/self/exe than /proc/$pid/exe. Tommi Rantala (6): perf buildid: do not update SDT cache with null filename perf buildid: do not assume that readlink() returns a null

Re: nouveau: iowrite32 oops & warning at drivers/gpu/drm/nouveau/nouveau_fence.c:198

2015-11-23 Thread Tommi Rantala
2015-11-22 22:49 GMT+02:00 Ilia Mirkin : > Not sure if these apply here but there are a couple of outstanding > locking fixes available in > http://cgit.freedesktop.org/~darktama/nouveau/ -- specifically these > two: > > http://cgit.freedesktop.org/~darktama/nouveau/commit/?id=2f3a56ad019e378a352e9

nouveau: iowrite32 oops & warning at drivers/gpu/drm/nouveau/nouveau_fence.c:198

2015-11-22 Thread Tommi Rantala
Hello, I'm seeing this warning and oops when trying to fuzz linus v4.4-rc1-290-g3ad5d7e with trinity. [ cut here ] WARNING: CPU: 1 PID: 4308 at drivers/gpu/drm/nouveau/nouveau_fence.c:198 nouveau_fence_context_new+0x22e/0x270() CPU: 1 PID: 4308 Comm: trinity-c19 Tainted: G

nouveau: BUG: KASAN: slab-out-of-bounds in memcpy+0x1d/0x40

2015-11-22 Thread Tommi Rantala
Hello, I'm seeing this kasan report after booting with linus v4.4-rc1-290-g3ad5d7e. BUG: KASAN: slab-out-of-bounds in memcpy+0x1d/0x40 at addr 880169e21fd0 Read of size 64 by task kworker/1:0/14 = BUG kmalloc-8192 (No

[PATCH] [media] cx231xx: Add support for Terratec Grabby

2015-05-20 Thread Tommi Rantala
Add support for the Terratec Grabby with USB ID 0ccd:00a6. Signed-off-by: Tommi Rantala --- drivers/media/usb/cx231xx/cx231xx-cards.c | 28 drivers/media/usb/cx231xx/cx231xx.h | 1 + 2 files changed, 29 insertions(+) diff --git a/drivers/media/usb/cx231xx

[PATCH] drm/radeon: fix DRM_IOCTL_RADEON_CS oops

2015-03-02 Thread Tommi Rantala
00 [ 47.149253] ---[ end trace 09576b4e8b2c20b8 ]--- Signed-off-by: Tommi Rantala --- drivers/gpu/drm/radeon/radeon_cs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c index a579ed3..4d0f96c 10

[PATCH 2/2] Input: xpad - add Thrustmaster as Xbox 360 controller vendor

2014-10-15 Thread Tommi Rantala
Add Thrustmaster as Xbox 360 controller vendor. This is required for example to make the GP XID (044f:b326) gamepad work. Signed-off-by: Tommi Rantala --- drivers/input/joystick/xpad.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick

[PATCH 1/2] Input: xpad - add USB ID for Thrustmaster Ferrari 458 Racing Wheel

2014-10-15 Thread Tommi Rantala
Add the USB ID for the Xbox 360 Thrustmaster Ferrari 458 Racing Wheel. Signed-off-by: Tommi Rantala --- drivers/input/joystick/xpad.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index cd13c82..cee4fe3 100644 --- a/drivers

Re: f2fs get_dnode_of_data oops

2014-09-09 Thread Tommi Rantala
2014-09-09 7:41 GMT+03:00 Jaegeuk Kim : > Hi Tommi, > > This patch should resolve this bug. > Thanks a lot. :) > > From ee24677b9917583f50f16b6f59771439f91b890c Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim > Date: Mon, 8 Sep 2014 10:59:43 -0700 > Subject: [PATCH] f2fs: fix negative value for lseek

Re: f2fs get_dnode_of_data oops

2014-09-08 Thread Tommi Rantala
2014-09-08 7:20 GMT+03:00 Jaegeuk Kim : > Hi, > > Thank you for the report. > Could you share a little bit more information about the file accessing > f2fs_llseek? > E.g., file size, file offset, file allocation information, or dump of that > file. Hi, I can reproduce the bug with the following.

Re: f2fs get_dnode_of_data oops

2014-09-07 Thread Tommi Rantala
2014-09-07 22:14 GMT+03:00 Tommi Rantala : > Hello, > > Hit this oops while fuzzing v3.17-rc3-176-g2b12164 with Trinity. > > Tommi > > > BUG: unable to handle kernel paging request at 8804338717a8 > IP: [] get_dnode_of_data+0x3a9/0x440 > PGD 4594067 PUD 0 > Oo

f2fs get_dnode_of_data oops

2014-09-07 Thread Tommi Rantala
Hello, Hit this oops while fuzzing v3.17-rc3-176-g2b12164 with Trinity. Tommi BUG: unable to handle kernel paging request at 8804338717a8 IP: [] get_dnode_of_data+0x3a9/0x440 PGD 4594067 PUD 0 Oops: [#1] SMP DEBUG_PAGEALLOC CPU: 0 PID: 4719 Comm: trinity-c3 Not tainted 3.17.0-rc3+ #33

RTNL: assertion failed at net/ipv6/addrconf.c (1699)

2014-08-29 Thread Tommi Rantala
Hi, Was fuzzing Linus v3.17-rc2-89-g59753a8 with Trinity as the root user in qemu, when I hit the following assertion failures. Tommi [init] Started watchdog process, PID is 4841 [main] Main thread is alive. [ 77.229699] sctp: [Deprecated]: trinity-main (pid 4842) Use of int in max_burst sock

drm_ioctl & WARNING at arch/x86/mm/ioremap.c:98

2014-08-27 Thread Tommi Rantala
Hello, Got this warning while fuzzing v3.17-rc2-40-gff0c57a with Trinity. Was running as root in qemu. Tommi ioremap: invalid physical address 40004000 [ cut here ] WARNING: CPU: 0 PID: 2887 at arch/x86/mm/ioremap.c:98 __ioremap_caller+0x7a/0x2e0() CPU: 0 PID: 28

Re: drm_mode_create_dumb_ioctl: divide error

2014-08-24 Thread Tommi Rantala
22.8.2014 13.38 kirjoitti "David Herrmann" : > > Hi > > On Thu, Aug 21, 2014 at 8:18 PM, Tommi Rantala wrote: > > Hello, > > > > Triggered this while fuzzing v3.17-rc1-51-g372b1db with Trinity. > > > > Tommi > > > > > > [d

drm_mode_create_dumb_ioctl: divide error

2014-08-21 Thread Tommi Rantala
Hello, Triggered this while fuzzing v3.17-rc1-51-g372b1db with Trinity. Tommi [drm:drm_mode_legacy_fb_format] *ERROR* bad bpp, assuming x8r8g8b8 pixel format divide error: [#1] SMP DEBUG_PAGEALLOC CPU: 0 PID: 2854 Comm: trinity-c7 Not tainted 3.17.0-rc1+ #14 Hardware name: Bochs Bochs, BIO

/proc/asound/card0/oss_mixer stack corruption

2014-08-21 Thread Tommi Rantala
Hello, Trinity discovered that writing 128 bytes to /proc/asound/card0/oss_mixer triggers a stack corruption. Tommi # printf %128s > /proc/asound/card0/oss_mixer ALSA: mixer_oss: invalid OSS volume '' Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: 81e193ba

kernel BUG at security/keys/keyring.c:1003!

2014-02-27 Thread Tommi Rantala
Hello, Hit the following BUG while fuzzing 3.14.0-rc3 with trinity. Tommi [708836.755392] [ cut here ] [708836.756044] kernel BUG at /build/linux/security/keys/keyring.c:1003! [708836.756044] invalid opcode: [#1] SMP DEBUG_PAGEALLOC [708836.756044] CPU: 0 PID: 5594 C

btrfs "possible irq lock inversion dependency detected"

2014-02-17 Thread Tommi Rantala
Hello, Saw this while fuzzing the kernel with Trinity. Tommi [ 396.136048] = [ 396.136048] [ INFO: possible irq lock inversion dependency detected ] [ 396.136048] 3.14.0-rc3 #1 Not tainted [ 396.136048]

BUG: Bad rss-counter state mm:ffff88005f936c00 idx:0 val:1

2014-02-16 Thread Tommi Rantala
Hello, Noticed the following kernel message while fuzzing 3.14.0-rc2-00488-gca03339 with trinity. Should I be worried? [40879.796336] BUG: Bad rss-counter state mm:88005f936c00 idx:0 val:1 Tommi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

BUG: Bad page state in process trinity-c19

2014-02-15 Thread Tommi Rantala
Hello, Hit the following bug while fuzzing with trinity. I can see that Dave reported similar bad page state problems for 3.13-rc4, but this one does not seem to be AIO related. https://lkml.org/lkml/2013/12/18/932 Tommi BUG: Bad page state in process trinity-c19 pfn:2429e page:ea90a7

lockdep: strange %s#5 lock name

2014-02-10 Thread Tommi Rantala
Hello, Noticed a suspicious "%s#5" lock name in a lockdep splat while fuzzing with trinity. Tommi [249844.491141] INFO: task kworker/u2:2:32113 blocked for more than 120 seconds. [249844.493268] Not tainted v3.13-11268-g8a1f006 #3 [249844.494731] "echo 0 > /proc/sys/kernel/hung_task_timeou

Re: BUG ip_dst_cache (Not tainted): Poison overwritten

2014-02-03 Thread Tommi Rantala
2014-02-01 Tommi Rantala : > 2014-01-31 Eric Dumazet : >> On Fri, 2014-01-31 at 22:11 +0200, Tommi Rantala wrote: >>> Hello, >>> >>> Hit this while fuzzing v3.13-9218-g0e47c96 with trinity in a qemu >>> virtual machine. >>> >>> To

Re: BUG ip_dst_cache (Not tainted): Poison overwritten

2014-02-01 Thread Tommi Rantala
2014-01-31 Eric Dumazet : > On Fri, 2014-01-31 at 22:11 +0200, Tommi Rantala wrote: >> Hello, >> >> Hit this while fuzzing v3.13-9218-g0e47c96 with trinity in a qemu >> virtual machine. >> >> Tommi > > Hi Tommi > > Could you please try the followi

BUG ip_dst_cache (Not tainted): Poison overwritten

2014-01-31 Thread Tommi Rantala
Hello, Hit this while fuzzing v3.13-9218-g0e47c96 with trinity in a qemu virtual machine. Tommi [ 6329.061605] = [ 6329.062014] BUG ip_dst_cache (Not tainted): Poison overwritten [ 6329.062014]

sched_rr_get_interval NULL pointer OOPS

2014-01-24 Thread Tommi Rantala
Hello, Trinity triggered the following bug in two separate qemu virtual machines after fuzzing v3.13-3995-g0dc3fd0 for a day or two. I have not been running Trinity in a while, so no idea if this is a regression or not. If I'm reading this right, it's oopsing in kernel/sched/core.c: SYSCALL_DEFI

kernel BUG at net/core/skbuff.c:1065!

2013-06-16 Thread Tommi Rantala
Hello, Hit this bug while fuzzing in a qemu virtual machine as the root user. Kernel is v3.10-rc5-0-g317ddd2. Tommi [575180.874750] type=1401 audit(1371378748.322:7750): SELinux: unrecognized netlink message type=0 for sclass=36 [575180.874750] [575191.358143] [ cut here ]--

  1   2   >