[PATCH] netfilter: Initialize local variables to NULL, to prevent using them when uninitialized.

Signed-off-by: Tomer Barletz --- net/netfilter/nfnetlink_queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c index 7d81d28..e8be660 100644 --- a/net/netfilter/nfnetlink_queue.c +++ b/net/netfilter

Re: [PATCH] usb: Move xhci_pme_quirk() behind an #ifdef CONFIG_PM, as it is not used when it's not defined

Ping. On Tue, Aug 18, 2015 at 12:55 AM, Tomer Barletz wrote: > Signed-off-by: Tomer Barletz > --- > drivers/usb/host/xhci-pci.c | 90 > ++--- > 1 file changed, 45 insertions(+), 45 deletions(-) > > diff --git a/drivers/usb/host/xhc

[PATCH] usb: Move xhci_pme_quirk() behind an #ifdef CONFIG_PM, as it is not used when it's not defined

Signed-off-by: Tomer Barletz --- drivers/usb/host/xhci-pci.c | 90 ++--- 1 file changed, 45 insertions(+), 45 deletions(-) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index 5590eac..c79d336 100644 --- a/drivers/usb/host/xhci

Re: [PATCH] MAINTAINERS: Remove two MIA be2iscsi maintainers

Ping. On Mon, Aug 3, 2015 at 3:56 PM, Tomer Barletz wrote: > Email bounced when emailing minh.t...@avagotech.com and > sony.joh...@avagotech.com. > > Signed-off-by: Tomer Barletz > --- > MAINTAINERS | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/MAINTA

[PATCH] tty: Fix potentialy used uninitialized variable

Initialize size to 0, as it may be used uninitialized in case read_mem32() fails. Signed-off-by: Tomer Barletz --- drivers/tty/nozomi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index 80f9de9..d70e9e4 100644 --- a/drivers/tty

[PATCH] mtd: Fix switch-bool compilation warning

With gcc 5.1 I get: warning: switch condition has boolean value [-Wswitch-bool] Signed-off-by: Tomer Barletz --- drivers/mtd/mtd_blkdevs.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 41acc50..8830475

[PATCH] scsi/be2iscsi: Fix logical-not-parentheses compilation warning

This fixes the following warning seen with GCC v5.1: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]. Signed-off-by: Tomer Barletz --- drivers/scsi/be2iscsi/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] MAINTAINERS: Remove two MIA be2iscsi maintainers

Email bounced when emailing minh.t...@avagotech.com and sony.joh...@avagotech.com. Signed-off-by: Tomer Barletz --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a9ae6c1..7aa066b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9119,8 +9119,6

[PATCH] scsi/be2iscsi: Fix logical-not-parentheses compilation warning

This fixes the following warning seen with GCC v5.1: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]. Signed-off-by: Tomer Barletz --- drivers/scsi/be2iscsi/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] sata_sx4: Check return code from pdc20621_i2c_read()

The variable spd0 might be used uninitialized when pdc20621_i2c_read() fails. This also generates a compilation warning with gcc 5.1. Signed-off-by: Tomer Barletz --- drivers/ata/sata_sx4.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/ata

Re: [PATCH] sata_sx4: Check return code from pdc20621_i2c_read()

checkpatch.pl, or are we saying everyone should have their editor set to 8-spaces width tabs? --Tomer On Mon, Aug 3, 2015 at 11:52 AM, Sergei Shtylyov wrote: > On 08/03/2015 09:46 PM, Tomer Barletz wrote: > >> The variable spd0 might be used uninitialized when pdc20621_i2c_read() >&

[PATCH] sata_sx4: Check return code from pdc20621_i2c_read()

The variable spd0 might be used uninitialized when pdc20621_i2c_read() fails. This also generates a compilation warning with gcc 5.1. Signed-off-by: Tomer Barletz --- drivers/ata/sata_sx4.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/ata

[PATCH] Check return code from pdc20621_i2c_read()

The variable spd0 might be used uninitialized when pdc20621_i2c_read() fails. This also generates a compilation warning with gcc 5.1. Signed-off-by: Tomer Barletz --- drivers/ata/sata_sx4.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/ata/sata_sx4

[PATCH] Avoid compiler warning by storing the result of rq_data_dir() in an int variable

With gcc 5.1 I get: warning: switch condition has boolean value [-Wswitch-bool] Signed-off-by: Tomer Barletz --- drivers/mtd/mtd_blkdevs.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 41acc50..8830475

Re: [PATCH] Check return code from pdc20621_i2c_read()

pr_err() - it is not used at all in this file, and printk() is used instead. Wouldn't it be better to leave it with printk for this change, then have another change that replaces printk()s with pr_err()s? --Tomer On Sun, Aug 2, 2015 at 10:53 AM, Tomer Barletz wrote: > > On Sun,

[PATCH] Avoid compiler warning by storing the result of rq_data_dir() in an int variable

With gcc 5.1 I get: warning: switch condition has boolean value [-Wswitch-bool] Signed-off-by: Tomer Barletz --- drivers/mtd/mtd_blkdevs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 41acc50..8c3715c 100644

[PATCH] Check return code from pdc20621_i2c_read()

The variable spd0 might be used uninitialized when pdc20621_i2c_read() fails. This also generates a compilation warning with gcc 5.1. Signed-off-by: Tomer Barletz --- drivers/ata/sata_sx4.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/ata/sata_sx4

[PATCH] Fix logical-not-parentheses warning

This fixes the following warning, that is seen with gcc 5.1: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]. Signed-off-by: Tomer Barletz --- sound/pci/oxygen/oxygen_mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] Fix logical-not-parentheses warning

Signed-off-by: Tomer Barletz --- sound/pci/oxygen/oxygen_mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c index 6492bca..4ca1266 100644 --- a/sound/pci/oxygen/oxygen_mixer.c +++ b/sound/pci/oxygen