Re: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600

2021-03-05 Thread Tomas Henzl
On 3/4/21 6:00 PM, don.br...@microchip.com wrote: > -Original Message- > From: Sergei Trofimovich [mailto:sly...@gmail.com] > Sent: Wednesday, March 3, 2021 4:04 PM > To: Don Brace - C33706 > Cc: glaub...@physik.fu-berlin.de; storagedev ; > linux-s...@vger.kernel.org; linux-i...@vger.ker

Re: [PATCH 10/10] mpt3sas: Bump mpt3sas driver version to v16.100.00.00

2017-10-11 Thread Tomas Henzl
On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: > Bump mpt3sas driver version to v16.100.00.00 > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 09/10] mpt3sas: Adding support for SAS3616 HBA device

2017-10-11 Thread Tomas Henzl
On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: > Adding PNP ID of Mercator i.e. SAS3616 HBA device. > Its device ID is 0xD1 and vendor ID is 0x1000. > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset

2017-10-11 Thread Tomas Henzl
On 10/11/2017 05:56 PM, James Bottomley wrote: > On Wed, 2017-10-11 at 17:35 +0200, Tomas Henzl wrote: >> On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: >>> For Dev Handles who value is less than hba's phys count number >>>  driver will return HBA sas address va

Re: [PATCH 08/10] mpt3sas: Fix possibility of using invalid Enclosure Handles for SAS device after host reset

2017-10-11 Thread Tomas Henzl
> > Modified the driver to update devices enclosure handles after > host reset to current value, by referring the enclosure handles > from corresponding device pages > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl

Re: [PATCH 08/10] mpt3sas: Fix possibility of using invalid Enclosure Handles for SAS device after host reset

2017-10-11 Thread Tomas Henzl
ce_pg0, struct _sas_device *sas_device) > +{ > + Mpi2ConfigReply_t mpi_reply; > + Mpi2SasEnclosurePage0_t enclosure_pg0; > + > + if (!sas_device_pg0 || !sas_device) > + return; This test^ implies that sas_device_pg0 or sas_device can be null, is that true? Signed-off-by: Tomas Henzl

Re: [PATCH 07/10] mpt3sas: Display chassis slot information of the drive

2017-10-11 Thread Tomas Henzl
Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 06/10] mpt3sas: Updated MPI headers to v2.00.48

2017-10-11 Thread Tomas Henzl
On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: > Updated MPI headers to v2.00.48 > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 05/10] mpt3sas: Fix IO error occurs on pulling out a drive from RAID1 volume created on two SATA drive

2017-10-11 Thread Tomas Henzl
quot;DID_RESET" > (i.e. retry the IO infinite times) host bytes. > > Earlier driver is returning the IO with "DID_SOFT_ERROR" > that reties the IO quickly for five times but still > firmware needed some more time and hence IOs were failing. > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset

2017-10-11 Thread Tomas Henzl
s. So now updated the driver to return > Virtual SES's sas address for Virtual SES device instead of > HBA's sas address. > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl

Re: [PATCH 03/10] mpt3sas: Reduce memory footprints in kdump kernel

2017-10-11 Thread Tomas Henzl
ult. > 4) Set SCSI IO Queue depth to 200. > > Signed-off-by: Sreekanth Reddy I think that preferred is (though not much used yet) instead of 'reset_devices' to use a 'is_kdump_kernel()' function. Signed-off-by: Tomas Henzl

Re: [PATCH 02/10] mpt3sas: Fixed memory leaks in driver

2017-10-11 Thread Tomas Henzl
vice > node as NULL and so we are not freeing the child device's > allocated data structures. > Updated the driver to remove the expander device from the list > only after freeing all its child devices. > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 01/10] mpt3sas: Processing of Cable Exception events

2017-10-11 Thread Tomas Henzl
added Cable Exception Event even for SAS3008 & SAS3108 HBAs > (i.e. MPI 2.5 spec supporting HBAs) earlier this event was > enabled only for MPI 2.6 spec supporting HBA devices. > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH V6 00/11] megaraid_sas: Updates for scsi-next

2016-12-23 Thread Tomas Henzl
On 23.12.2016 16:24, Tomas Henzl wrote: > On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote: >> Sasikumar Chandrasekaran (11): >> megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid >> Controllers >> megaraid_sas: 128 MSIX Support >> megar

Re: [PATCH V6 00/11] megaraid_sas: Updates for scsi-next

2016-12-23 Thread Tomas Henzl
On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote: > Sasikumar Chandrasekaran (11): > megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid > Controllers > megaraid_sas: 128 MSIX Support > megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid > Controllers >

Re: [PATCH V6 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers

2016-12-23 Thread Tomas Henzl
On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote: > Update Linux driver to use new pdTargetId field for JBOD target ID > > This patch is depending on patch 9 and same as V5 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl

Re: [PATCH V6 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-23 Thread Tomas Henzl
On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote: > Large SEQ IO workload should sent as non fast path commands > > This patch is depending on patch 7 > > 80 chars per line limit is taken care around VD_EXT_DEBUG macro. > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl

Re: [PATCH V6 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-23 Thread Tomas Henzl
e around VD_EXT_DEBUG macro. > NULL pointer check for desc_table has been removed. > Few code indentation issues fixed. > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl

Re: [PATCH V6 02/11] megaraid_sas: 128 MSIX Support

2016-12-23 Thread Tomas Henzl
ikumar Chandrasekaran Reviewed-by: Tomas Henzl

Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:51, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Thursday, December 15, 2016 10:10 AM > To: Sasikumar PC; j...@kernel.org;

Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:51, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Sasikumar PC [mailto:sasikumar...@broadcom.com] > Sent: Wednesday, December 14, 2016 4:49 PM > To: 'Tomas Henzl&#x

Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:50, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Sasikumar PC [mailto:sasikumar...@broadcom.com] > Sent: Wednesday, December 14, 2016 4:43 PM > To: 'Tomas Henzl&#x

Re: [PATCH V5 00/11] megaraid_sas: Updates for scsi-next

2016-12-15 Thread Tomas Henzl
On 14.12.2016 23:12, Sasikumar Chandrasekaran wrote: > Sasikumar Chandrasekaran (11): > megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid > Controllers > megaraid_sas: 128 MSIX Support > megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid > Controllers >

Re: [PATCH V5 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-15 Thread Tomas Henzl
On 14.12.2016 23:13, Sasikumar Chandrasekaran wrote: > Large SEQ IO workload should sent as non fast path commands > > This patch is depending on patch 7 > This patch is same as V4 and there is no specific update for V5 That means, that you have ignored my question regarding 'bytes_wrote' I asked

Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-15 Thread Tomas Henzl
On 14.12.2016 22:54, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Friday, December 09, 2016 8:59 AM > To: Sasikumar Chandrasekaran; j...@ke

Re: [PATCH V5 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-15 Thread Tomas Henzl
On 14.12.2016 23:13, Sasikumar Chandrasekaran wrote: > SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap to > have different > sizes for different number of supported VDs. > > This patch is depending on patch 5 > Code indentation is fixed for VD_EXT_DEBUG macro > > Signed-off

Re: [PATCH V5 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

2016-12-15 Thread Tomas Henzl
pace changes (for example a non-ascii char has been removed). Other then the indentation is still not correct - see in text. I haven't found any other important issues so ok. > > Signed-off-by: Sasikumar Chandrasekaran > Reviewed-by: Tomas Henzl > --- > drivers/scsi/megaraid/meg

Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

2016-12-12 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > Detect sequential IO streams and pass those IOs directly to FW. > > This patch is depending on patch 3 > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas.h| 5 +- > drivers/scsi/megaraid/megaraid_s

Re: [PATCH V4 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > Update Linux driver to use new pdTargetId field for JBOD target ID > > This patch is depending on patch 9 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 11/11] megaraid_sas: driver version upgrade

2016-12-09 Thread Tomas Henzl
RELDATE "November 29, 2016" > > /* > * Device IDs Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > ldio outstanding variable needs to be decremented in io completion path for > iMR dual queue depth > > This patch is depending on patch 8 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > Large SEQ IO workload should sent as non fast path commands > > This patch is depending on patch 7 > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas.h| 8 + > drivers/scsi/megaraid/megaraid_sas

Re: [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers > Firmware functionality. > > This patch is depending on patch 6 > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 53

Re: [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers > Firmware functionality. > > This patch is depending on patch 6 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap to > have different > sizes for different number of supported VDs. > > This patch is depending on patch 5 > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi

Re: [PATCH V4 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes

2016-12-09 Thread Tomas Henzl
the OS logical IO) and > wait for > all Write IOs to complete. If any of the Write IOs fail or time out, the IO > will be > re issued to FW as an LD IO so FW can perform the error handling. > > This patch is depending on patch 4 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

2016-12-08 Thread Tomas Henzl
w. Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers

2016-12-08 Thread Tomas Henzl
or PI types 1 > and 2. > A value of 3 should be set to disable all PI checks if the Logical Block > Application > Tag is 0x and the Logical Block Reference Tag is 0x for PI type 3. > > This patch is depending on patch 2 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support

2016-12-08 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > SAS3.5 Generic Megaraid based Controllers will have the support for 128 MSI-X > vectors, > resulting in the need to support 128 reply queues > > This patch is depending on patch 1 > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/sc

Re: [PATCH V4 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

2016-12-08 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers > > V4: Removed the not supported PCI Device Ids > > Signed-off-by: Sasikumar Chandrasekaran The V4 does not panic my machine like the V3. Rev

Re: [PATCH V3 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

2016-12-06 Thread Tomas Henzl
On 5.12.2016 17:27, Sasikumar Chandrasekaran wrote: > This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas.h| 11 ++- > drivers/scsi/megaraid/megaraid_sas_base.c | 20

Re: [PATCH 00/11] Updates for scsi-next

2016-12-02 Thread Tomas Henzl
On 2.12.2016 15:07, Sasikumar Chandrasekaran wrote: > Sasikumar Chandrasekaran (11): > megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid > Controllers > megaraid_sas: 128 MSIX Support > megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid > Controllers >

Re: [PATCH v2] scsi: aic94xx: Add a missing call to kfree

2016-11-28 Thread Tomas Henzl
entin Lambert Looks good, Reviewed-by: Tomas Henzl Tomas

Re: [PATCH] scsi: pmcraid: Add missing resource releases

2016-11-22 Thread Tomas Henzl
ain > a call to class_destroy. This patch add these calls where they are > missing. > > This issue was found with Hector. > > Signed-off-by: Quentin Lambert Looks good, Reviewed-by: Tomas Henzl Tomas > > --- > drivers/scsi/pmcraid.c | 10 +++--- > 1 file chang

Re: [PATCH] scsi: aic94xx: Add a missing call to kfree

2016-11-22 Thread Tomas Henzl
On 19.11.2016 18:40, Quentin Lambert wrote: > Most error branches following the call to kzalloc contain > a call to kfree. This patch add these calls where they are > missing. > > This issue was found with Hector. Hi Quentin, most error branches also do set the freed pointer to NULL, please do the

Re: [PATCH 01/10] mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device.

2016-10-25 Thread Tomas Henzl
On 20.10.2016 14:20, Suganath Prabu S wrote: > Return value and Device_handle Arguments passed in correct order > to match with its format string. > > Signed-off-by: Chaitra P B > Signed-off-by: Sathya Prakash > Signed-off-by: Suganath Prabu S > --- Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 10/10] mpt3sas: Fix for Endianness issue.

2016-10-25 Thread Tomas Henzl
On 20.10.2016 14:20, Suganath Prabu S wrote: > Use le16_to_cpu only for accessing two byte data provided by controller. > > Signed-off-by: Chaitra P B > Signed-off-by: Sathya Prakash > Signed-off-by: Suganath Prabu S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 09/10] mpt3sas: Use the new MPI 2.6 32-bit Atomic Request Descriptors for SAS35 devices.

2016-10-25 Thread Tomas Henzl
On 20.10.2016 14:20, Suganath Prabu S wrote: > Support Atomic Request Descriptors for Ventura/SAS35 devices. > > Signed-off-by: Chaitra P B > Signed-off-by: Sathya Prakash > Signed-off-by: Suganath Prabu S > --- Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 04/10] mpt3sas: Removing unused macro "MPT_DEVICE_TLR_ON"

2016-10-25 Thread Tomas Henzl
@ struct MPT3SAS_TARGET { > * per device private data > */ > #define MPT_DEVICE_FLAGS_INIT0x01 > -#define MPT_DEVICE_TLR_ON0x02 > > #define MFG_PAGE10_HIDE_SSDS_MASK(0x00000003) > #define MFG_PAGE10_HIDE_ALL_DISKS(0x00) Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 02/10] mpt3sas: Fix for incorrect numbers for MSIX vectors enabled when non RDPQ card is enumerated first.

2016-10-25 Thread Tomas Henzl
DPQ enabled card is enumerated first , MSIX vectors enabled > depends on the cards capability. > > Signed-off-by: Chaitra P B > Signed-off-by: Sathya Prakash > Signed-off-by: Suganath Prabu S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 08/10] mpt3sas: set EEDP-escape-flags for SAS35 devices.

2016-10-25 Thread Tomas Henzl
of 3 should be set to disable all PI checks if the Logical Block > Application Tag is 0x and the Logical Block Reference Tag is > 0x for PI type 3. > > Signed-off-by: Chaitra P B > Signed-off-by: Sathya Prakash > Signed-off-by: Suganath Prabu S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 07/10] mpt3sas: Increased/Additional MSIX support for SAS35 devices.

2016-10-25 Thread Tomas Henzl
dex_count is added to set different values for SAS3 and > SAS35 devices. > > Signed-off-by: Chaitra P B > Signed-off-by: Sathya Prakash > Signed-off-by: Suganath Prabu S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 06/10] mpt3sas: Added Device ID's for SAS35 devices and updated MPI header.

2016-10-25 Thread Tomas Henzl
-off-by: Chaitra P B > Signed-off-by: Sathya Prakash > Signed-off-by: Suganath Prabu S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 6/6] mpt3sas: Used "synchronize_irq()"API to synchronize timed-out IO & TMs

2016-05-11 Thread Tomas Henzl
On 11.5.2016 05:53, Sreekanth Reddy wrote: > On Tue, May 10, 2016 at 6:41 PM, Tomas Henzl wrote: >> On 6.5.2016 10:59, Chaitra P B wrote: >>> Replaced mpt3sas_base_flush_reply_queues()with >>> mpt3sas_base_sync_reply_irqs(),as mpt3sas_base_flush_reply_queues() >>&

Re: [PATCH 5/6] mpt3sas: Set maximum transfer length per IO to 4MB for VDs

2016-05-11 Thread Tomas Henzl
On 6.5.2016 10:59, Chaitra P B wrote: > Set maximum transfer length per IO on RAID volumes > to 4MB by setting VD's queue's max_sector to 8192. > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 4/6] mpt3sas: Updating mpt3sas driver version to 13.100.00.00

2016-05-11 Thread Tomas Henzl
R_VERSION "13.100.00.00" > +#define MPT3SAS_MAJOR_VERSION13 > #define MPT3SAS_MINOR_VERSION 100 > #define MPT3SAS_BUILD_VERSION0 > #define MPT3SAS_RELEASE_VERSION 00 Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 3/6] mpt3sas: Fix initial Reference tag field for 4K PI drives.

2016-05-11 Thread Tomas Henzl
On 6.5.2016 10:59, Chaitra P B wrote: > Modified driver code to use scsi_prot_ref_tag() API instead of > scsi_get_lba(), while initializing reference tag field in the CDB. > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 2/6] mpt3sas: Handle active cable exception event

2016-05-11 Thread Tomas Henzl
connected to this active cable will not be seen. This active > cable requires of power" > > This event is only for Intruder/Cutlass HBAs. > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 1/6] mpt3sas: Update MPI header to 2.00.42

2016-05-11 Thread Tomas Henzl
A_ACTIVE_CABLE_EXCEPT > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 6/6] mpt3sas: Used "synchronize_irq()"API to synchronize timed-out IO & TMs

2016-05-10 Thread Tomas Henzl
On 6.5.2016 10:59, Chaitra P B wrote: > Replaced mpt3sas_base_flush_reply_queues()with > mpt3sas_base_sync_reply_irqs(),as mpt3sas_base_flush_reply_queues() > skips over reply queues that are currently busy (i.e. being handled > by interrupt processing in another core). If a reply queue is busy, >

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-19 Thread Tomas Henzl
On 15.3.2016 22:40, Arnd Bergmann wrote: > The qlt_check_reserve_free_req() function produces an incorrect warning > when CONFIG_PROFILE_ANNOTATED_BRANCHES is set: > > drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_check_reserve_free_req': > drivers/scsi/qla2xxx/qla_target.c:1887:3: error: 'cn

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-19 Thread Tomas Henzl
On 16.3.2016 16:03, Tomas Henzl wrote: > On 15.3.2016 22:40, Arnd Bergmann wrote: >> The qlt_check_reserve_free_req() function produces an incorrect warning >> when CONFIG_PROFILE_ANNOTATED_BRANCHES is set: >> >> drivers/scsi/qla2xxx/qla_target.c: In function

Re: [patch] tcm_loop: use after free on error

2016-03-03 Thread Tomas Henzl
On 2.3.2016 11:09, Dan Carpenter wrote: > We dereference "tl_nexus" to get the error code. > > Fixes: 1b418a8fcbc0 ('target: Convert demo-mode only drivers to > target_alloc_session') > Signed-off-by: Dan Carpenter Reviewed-by: Tomas Henzl

Re: [PATCH v2] fusion-mptbase: handle failed allocation for workqueue

2016-02-19 Thread Tomas Henzl
On 18.2.2016 17:55, Ewan Milne wrote: > On Thu, 2016-02-18 at 11:40 -0500, Ewan Milne wrote: >> It also appears to me upon further inspection that the existing code has >> other problems. In particular, once mpt_mapresources() has returned >> with a nonzero error code, it looks like iounmap() shou

Re: [PATCH v2 1/2] mpt3sas: Free memory pools before retrying to allocate with different value.

2016-02-18 Thread Tomas Henzl
_base_release_memory_pools(ioc); > goto retry_allocation; > } > Reviewed-by: Tomas Henzl

Re: [PATCH] fusion-mptbase: handle failed allocation for workqueue

2016-02-17 Thread Tomas Henzl
On 16.2.2016 21:52, Ewan Milne wrote: > On Tue, 2016-02-16 at 13:33 -0500, Insu Yun wrote: >> >> On Tue, Feb 16, 2016 at 1:18 PM, Ewan Milne wrote: >> On Mon, 2016-02-15 at 21:50 -0500, Insu Yun wrote: >> > the failure of ioc->reset_work_q is checked, >> > but not ioc->fw_e

Re: [PATCH 1/2] mpt3sas: Deallocate resources before trying reallocation of the same in _base_allocate_memory_pools()

2016-02-17 Thread Tomas Henzl
ools(struct MPT3SAS_ADAPTER >> *ioc, int sleep_flag) >> goto out; >> retry_sz += 64; >> ioc->hba_queue_depth = max_request_credit - retry_sz; >> +_base_release_memory_pools(ioc); >> goto retry_allocation; Thanks for posting Reviewed-by: Tomas Henzl

Re: [mpt3sas driver V1 6/10] mpt3sas: Added smp_affinity_enable module parameter.

2016-02-09 Thread Tomas Henzl
gt; - cpumask_clear(reply_q->affinity_hint); > + if (smp_affinity_enable) { > + if (!zalloc_cpumask_var(&reply_q->affinity_hint, GFP_KERNEL)) { > + kfree(reply_q); > + return -ENOMEM; > + } > + cpumask_clear(reply_q->affinity_hint); I think, that with zalloc_cpumask_var we no more need the cpumask_clear here Please remove it in next patchset. Reviewed-by: Tomas Henzl Tomas

Re: [mpt3sas driver 07/10] mpt3sas: Add support for configurable Chain Frame Size

2016-02-08 Thread Tomas Henzl
On 5.2.2016 08:56, Sreekanth Reddy wrote: > On Thu, Feb 4, 2016 at 8:35 PM, Tomas Henzl wrote: >> On 28.1.2016 07:37, Suganath prabu Subaramani wrote: >>> From: Suganath prabu Subramani >>> >>> Added support for configurable Chain Frame Size. Calculate the &

Re: [mpt3sas driver 06/10] mpt3sas: Added smp_affinity_enable module parameter.

2016-02-08 Thread Tomas Henzl
umask_var. --tm > > We incorporated other review comments for freeing reply_q and > cpumask_var in this patch and sending it soon. > > Thanks, > Suganath prabu S > > On Thu, Feb 4, 2016 at 8:31 PM, Tomas Henzl wrote: >> On 28.1.2016 07:37, Suganath prabu Subarama

Re: [mpt3sas driver 10/10] mpt3sas: Updating mpt3sas driver version to 12.100.00.00

2016-02-04 Thread Tomas Henzl
quot;09.102.00.00" > -#define MPT3SAS_MAJOR_VERSION9 > -#define MPT3SAS_MINOR_VERSION102 > +#define MPT3SAS_DRIVER_VERSION "12.100.00.00" > +#define MPT3SAS_MAJOR_VERSION12 > +#define MPT3SAS_MINOR_VERSION

Re: [mpt3sas driver 09/10] mpt3sas: Fix for Asynchronous completion of timedout IO and task abort of timedout IO.

2016-02-04 Thread Tomas Henzl
Subramani > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [mpt3sas driver 08/10] mpt3sas: Updated MPI Header to 2.00.42

2016-02-04 Thread Tomas Henzl
On 28.1.2016 07:37, Suganath prabu Subaramani wrote: > From: Suganath prabu Subramani > > Updated MPI version and MPI header files. > > Signed-off-by: Suganath prabu Subramani > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [mpt3sas driver 07/10] mpt3sas: Add support for configurable Chain Frame Size

2016-02-04 Thread Tomas Henzl
On 28.1.2016 07:37, Suganath prabu Subaramani wrote: > From: Suganath prabu Subramani > > Added support for configurable Chain Frame Size. Calculate the > Chain Message Frame size from the IOCMaxChainSegementSize (iocfacts). > Applicable only for mpt3sas/SAS3.0 HBA's. > > Signed-off-by: Suganath p

Re: [mpt3sas driver 06/10] mpt3sas: Added smp_affinity_enable module parameter.

2016-02-04 Thread Tomas Henzl
On 28.1.2016 07:37, Suganath prabu Subaramani wrote: > From: Suganath prabu Subramani > > Module parameter to enable/disable configuring > affinity hint for msix vector. > SMP affinity feature can be enabled/disabled by setting > module parameter "smp_affinity_enable" to 1/0. > By default this fea

Re: [mpt3sas driver 05/10] mpt3sas: Make use of additional HighPriority credit message frames for sending SCSI IO's

2016-02-04 Thread Tomas Henzl
global credits and > highPriority credits as two different values. > > Signed-off-by: Suganath prabu Subramani > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [mpt3sas driver 04/10] mpt3sas: Never block the Enclosure device

2016-02-04 Thread Tomas Henzl
while > adding any device to the OS. > > Signed-off-by: Suganath prabu Subramani > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [mpt3sas driver 03/10] mpt3sas: Fix static analyzer(coverity) tool identified defects

2016-02-04 Thread Tomas Henzl
d be of > same structure type. > 2.Dereference null return value > 3.Array compared against '0' > Check whether value pointed by particular index of an array is null or not > in "if" statement. > > Signed-off-by: Suganath prabu Subramani > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [mpt3sas driver 02/10] mpt3sas: Used IEEE SGL instead of MPI SGL while framing a SMP Passthrough request message.

2016-02-04 Thread Tomas Henzl
SMP Passthrough request message > and so unable to perform phy disable operation. > > Signed-off-by: Suganath prabu Subramani > > Signed-off-by: Chaitra P B (when Christopher's question is answered) Reviewed-by: Tomas Henzl Tomas

Re: [mpt3sas driver 01/10] mpt3sas: Added support for high port count HBA variants.

2016-02-04 Thread Tomas Henzl
anath prabu Subramani > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [PATCH v3] mptlan: add checks for dma mapping errors

2016-01-27 Thread Tomas Henzl
mainline. Thanks, Tomas > > Thanks > Sathya > > -Original Message- > From: mpt-fusionlinux@avagotech.com > [mailto:mpt-fusionlinux@avagotech.com] On Behalf Of Martin K. Petersen > Sent: Tuesday, January 26, 2016 7:23 PM > To: Tomas Henzl > Cc:

Re: [PATCH v3] mptlan: add checks for dma mapping errors

2016-01-26 Thread Tomas Henzl
On 25.1.2016 19:02, Alexey Khoroshilov wrote: > mpt_lan_sdu_send() and mpt_lan_post_receive_buckets() do not check > if mapping dma memory succeed. > The patch adds the checks and failure handling. > > v3: Fix resource deallocation (reported by Tomas Henzl). > > Found by Linu

Re: [PATCH v2] mptlan: add checks for dma mapping errors

2016-01-25 Thread Tomas Henzl
On 23.1.2016 01:41, Alexey Khoroshilov wrote: > mpt_lan_sdu_send() and mpt_lan_post_receive_buckets() do not check > if mapping dma memory succeed. > The patch adds the checks and failure handling. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshi

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-01-20 Thread Tomas Henzl
eft over from some sort of refactoring. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Tomas Henzl Tomas > --- > drivers/scsi/lpfc/lpfc_scsi.c | 17 - > 1 file changed, 17 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lp

Re: [PATCH] scsi: mvsas: fix indenting on return error code

2016-01-05 Thread Tomas Henzl
_IS_GONE() failure. > > The incorrect indenting was introduced by commit > 0b15fb1fdfd403726542cb6111bc916b7a9f7fad ("[SCSI] mvsas: add support > for Task collector mode and fixed relative bugs") > > No functional change, just a minor code reformatting clean up. > >

Re: [PATCH 3/3] arcmsr: change driver version to v1.30.00.22-20151126

2015-11-27 Thread Tomas Henzl
On 26.11.2015 12:44, Ching Huang wrote: > From: Ching Huang > > change driver version to v1.30.00.22-20151126 > > Signed-of-by: Ching Huang Reviewed-by: Tomas Henzl Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH 2/3] arcmsr: Split dma resource allocation to a new function

2015-11-27 Thread Tomas Henzl
gt;> acb->host->host_no); >>> + return false; >>> + } >>> + memset(dma_coherent, 0, acb->roundup_ccbsize); >>> >> There is a dma_zalloc_coherent >> >> (and even more trivially) >> >> Most all o

Re: [PATCH 1/3] arcmsr: modify codes for more readable

2015-11-27 Thread Tomas Henzl
On 26.11.2015 12:33, Ching Huang wrote: > From: Ching Huang > > modify codes for more readable > > Signed-of-by: Ching Huang Reviewed-by: Tomas Henzl Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

2015-11-26 Thread Tomas Henzl
On 26.11.2015 08:32, Ching Huang wrote: > On Wed, 2015-11-25 at 14:55 +0100, Tomas Henzl wrote: >> On 25.11.2015 12:41, Ching Huang wrote: >>> From: Ching Huang >>> >>> Releasing allocated resource if get configuration data failed. >>> >>> Sig

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

2015-11-25 Thread Tomas Henzl
On 25.11.2015 12:41, Ching Huang wrote: > From: Ching Huang > > Releasing allocated resource if get configuration data failed. > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c > b/drivers/scsi/arcmsr/arcmsr_hba.c > --- a/drivers/scsi/arcmsr/arcmsr_hba.c

Re: [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag

2015-11-13 Thread Tomas Henzl
driver's > 'struct MPT3SAS_DEVIC' structure. which is corrected with this patch. > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kern

Re: [PATCH v1 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-06-17 Thread Tomas Henzl
he driver. > > Changes in v1: >If PCI Recovery is on then return with -EFAULT in the function > _base_wait_for_iocstate(). > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-06-16 Thread Tomas Henzl
On 06/12/2015 11:42 AM, Sreekanth Reddy wrote: > Driver initialization fails if driver tries to send IOC facts request message > when the IOC is in reset or in a fault state. > > This patch will make sure that > 1.Driver to send IOC facts request message only if HBA is in operational or > ready

Re: [PATCH] mpt2sas: mpt3sas: Fix memory corruption during initialization

2015-05-05 Thread Tomas Henzl
On 05/04/2015 05:05 PM, Sreekanth Reddy wrote: > I have applied this patch on the latest upstream mpt3sas driver, then I have > compiled and loaded the driver. > In the driver logs I didn't see any attached drives are added to the OS, > 'fdisk -l' command also doesn't list > the drives which are

[PATCH 2/2] cciss: correct the non-resettable board list

2015-02-17 Thread Tomas Henzl
The hpsa driver carries a more recent version, copy the table from there. Signed-off-by: Tomas Henzl --- drivers/block/cciss.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 48498220cd..0ca65b25ef

[PATCH 1/2] cciss: remove duplicate entries from board_type struct

2015-02-17 Thread Tomas Henzl
and devices not supported by this driver from unresettable list Signed-off-by: Tomas Henzl --- drivers/block/cciss.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index ff20f192b0..48498220cd 100644 --- a/drivers/block/cciss.c +++ b/drivers

Re: [PATCH 2/2] Revert "[SCSI] mpt3sas: Remove phys on topology change"

2014-12-03 Thread Tomas Henzl
rives connected Enclosure/Expander will unregister with > SCSI Transport Layer, if any one remove and add expander > cable with in DMD (Device Missing Delay) time period or > even any one power-off and power-on the Enclosure with in > the DMD period. Reviewed-by: Tomas Henzl > >

Re: [PATCH 1/2] Revert "[SCSI] mpt2sas: Remove phys on topology change."

2014-12-03 Thread Tomas Henzl
sue which the original patch should have fixed, so it's fine to remove it. Reviewed-by: Tomas Henzl > Cc: > Cc: Tomas Henzl > Signed-off-by: Sreekanth Reddy > --- > drivers/scsi/mpt2sas/mpt2sas_transport.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) &

Re: [PATCH 0/2] mpt{2,3}sas remove disconnected phys on topology change

2014-12-02 Thread Tomas Henzl
revert back these > patch set changes. > > Regards, > Sreekanth > >> -Original Message- >> From: Jan Vesely [mailto:jves...@redhat.com] >> Sent: Thursday, August 01, 2013 3:31 PM >> To: linux-s...@vger.kernel.org; linux-kernel@vger.kernel.org >> Cc:

Re: [PATCH v5 1/2] arcmsr: simplify ioctl data read/write

2014-09-24 Thread Tomas Henzl
tindex; > + int32_t wqbuf_putIndex; > /* last of write buffer */ > uint8_t > devstate[ARCMSR_MAX_TARGETID][ARCMSR_MAX_TARGETLUN]; > /* id0 . id15, lun0...lun7 */ The comments I've added are not directly r

  1   2   >