Re: Re: [BUG] net/ppp: A use after free in ppp_unregister_channe

2021-03-15 Thread Tom Parkin
On Mon, Mar 15, 2021 at 13:18:24 +0100, Guillaume Nault wrote: > On Fri, Mar 12, 2021 at 10:47:53PM +0800, lyl2...@mail.ustc.edu.cn wrote: > > > > > > > > > -原始邮件- > > > 发件人: "Tom Parkin" > > > 发送时间: 2021-03-12 18:12:

Re: Re: [BUG] net/ppp: A use after free in ppp_unregister_channe

2021-03-15 Thread Tom Parkin
On Fri, Mar 12, 2021 at 22:47:53 +0800, lyl2...@mail.ustc.edu.cn wrote: > > > > > -原始邮件----- > > 发件人: "Tom Parkin" > > 发送时间: 2021-03-12 18:12:58 (星期五) > > 收件人: lyl2...@mail.ustc.edu.cn > > 抄送: pau...@samba.org, da...@davemloft.net, linux

Re: [BUG] net/ppp: A use after free in ppp_unregister_channe

2021-03-12 Thread Tom Parkin
Thanks for the report! On Thu, Mar 11, 2021 at 20:34:44 +0800, lyl2...@mail.ustc.edu.cn wrote: > File: drivers/net/ppp/ppp_generic.c > > In ppp_unregister_channel, pch could be freed in ppp_unbridge_channels() > but after that pch is still in use. Inside the function ppp_unbridge_channels, > if

Re: [PATCH net v2] net: l2tp: reduce log level of messages in receive path, add counter instead

2021-03-03 Thread Tom Parkin
On Wed, Mar 03, 2021 at 16:50:49 +0100, Matthias Schiffer wrote: > Commit 5ee759cda51b ("l2tp: use standard API for warning log messages") > changed a number of warnings about invalid packets in the receive path > so that they are always shown, instead of only when a special L2TP debug > flag is s

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-23 Thread Tom Parkin
On Mon, Feb 22, 2021 at 14:31:38 -0800, Jakub Kicinski wrote: > On Mon, 22 Feb 2021 17:40:16 +0100 Matthias Schiffer wrote: > > >> This will not be sufficient for my usecase: To stay compatible with older > > >> versions of fastd, I can't set the T flag in the first packet of the > > >> handshake,

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-23 Thread Tom Parkin
On Mon, Feb 22, 2021 at 17:40:16 +0100, Matthias Schiffer wrote: > On 2/22/21 12:49 PM, Tom Parkin wrote: > > On Sat, Feb 20, 2021 at 10:56:33 +0100, Matthias Schiffer wrote: > > > On 2/19/21 9:12 PM, Tom Parkin wrote: > > > > On Fri, Feb 19, 2021 at 20:06:15

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-22 Thread Tom Parkin
On Sat, Feb 20, 2021 at 10:56:33 +0100, Matthias Schiffer wrote: > On 2/19/21 9:12 PM, Tom Parkin wrote: > > On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote: > > > Before commit 5ee759cda51b ("l2tp: use standard API for warning log > > > messages&

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-19 Thread Tom Parkin
Hi Matthias, Thanks for your patch! On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote: > Before commit 5ee759cda51b ("l2tp: use standard API for warning log > messages"), it was possible for userspace applications to use their own > control protocols on the backing sockets of an L2

Re: [PATCH] Documentation: networking: Fix Column span alignment warnings in l2tp.rst

2020-11-19 Thread Tom Parkin
On Wed, Nov 18, 2020 at 16:44:11 +0530, siddhant gupta wrote: > On Wed, 18 Nov 2020 at 15:53, Tom Parkin wrote: > > > > On Tue, Nov 17, 2020 at 15:22:07 +0530, Siddhant Gupta wrote: > > > Fix Column span alignment problem warnings in the file > > > >

Re: [PATCH] Documentation: networking: Fix Column span alignment warnings in l2tp.rst

2020-11-18 Thread Tom Parkin
On Tue, Nov 17, 2020 at 15:22:07 +0530, Siddhant Gupta wrote: > Fix Column span alignment problem warnings in the file > Thanks for the patch, Siddhant. Could you provide some information on how these warnings were triggered? Using Sphinx 2.4.4 I can't reproduce any warnings for l2tp.rst using

Re: problems with L2TP

2015-07-03 Thread Tom Parkin
riable in create_socket() function). > > So my questions are: > 1. Am I doing something wrong in userspace part? Because my server > part is working fine with Android kernel implementation of LAC > (drivers/net/ppp/pppolac.c). When I'm trying to do the same with > mainline kernel implementation of LAC -- I'm having issues described > above. The second approach looks good to me. Note that the session only stays up as long as session_fd is open. How is the tunnel/session being created on the server side? How are you deriving the session and tunnel IDs? The fact that xl2tp is complaining about being unable to find tunnel IDs suggests that data is arriving there but that something isn't correctly configured at that end. > 2. Do we have some testing code for L2TP (particularly LAC)? Or maybe > just some working user-space code sample? > > Thanks! > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Tom Parkin Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development signature.asc Description: Digital signature

Re: [PATCH][RESEND] Fix checksum related BUG in l2tp_ppp receive path

2013-05-29 Thread Tom Parkin
her setting skb->ip_summed to CHECKSUM_NONE is the right thing to do. It seems like this would disable checksumming for the ICMP echo response. Although that may avoid the BUG, it may not be entirely ideal behaviour. I'll have a dig into the other tunnelling protocol implementation an