Re: [PATCH] ftrace: add simple oneshot function tracer

2019-07-09 Thread Thomas Preisner
On Wed, Jun 26, 2019 at 12:04:12PM -0400, Steven Rostedt wrote: > On Sun, 23 Jun 2019 14:05:55 +0200 > Thomas Preisner wrote: > > I've created this tracer with kernel tailoring in mind since the > > tailoring process of e.g. undertaker heavily benefits from a more > &

Re: [PATCH] ftrace: add simple oneshot function tracer

2019-06-23 Thread Thomas Preisner
On Mon, Jun 17, 2019 at 08:16:27PM -0400, Steven Rostedt wrote: > On Wed, 12 Jun 2019 23:29:35 +0200 > Thomas Preisner wrote: > > Hi Thomas, > > BTW, what email client do you use, because your replies seem to confuse > my email client (claws-mail) and it doesn't thre

Re: Re: [PATCH] ftrace: add simple oneshot function tracer

2019-06-13 Thread Thomas Preisner
I can add the file operation for enabling/disabling this new profiler together with a new kernel commandline argument for this profiler? Or what would be your prefered way? Greetings, Thomas Preisner

[PATCH v2] ftrace: add simple oneshot function profiler

2019-06-11 Thread Thomas Preisner
it can be passed directly to undertaker-tailor. Further information regarding this one oneshot function tracer can also be found at [1]. [0]: https://i4gerrit.informatik.uni-erlangen.de/undertaker.git [1]: https://tpreisner.de/pub/ba-thesis.pdf Signed-off-by: Thomas Preisner --- kernel/trace/Kcon

[no subject]

2019-06-11 Thread Thomas Preisner
On Wed, 29 May 2019 10:45:52 -0400 Steven Rostedt wrote: > On Wed, 29 May 2019 11:31:23 +0200 > Thomas Preisner wrote: > > > The "oneshot" tracer records every address (ip, parent_ip) exactly > > once. > > As a result, "oneshot" can be used to effi

[PATCH] ftrace: add simple oneshot function tracer

2019-05-29 Thread Thomas Preisner
be passed directly to undertaker-tailor. Further information regarding this oneshot function tracer can also be found at [1]. [0]: https://undertaker.cs.fau.de [1]: https://tpreisner.de/pub/ba-thesis.pdf Signed-off-by: Thomas Preisner --- Documentation/trace/ftrace.rst | 7 ++ kernel/trace/Kc

Re: Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

2016-12-29 Thread Thomas Preisner
On Tue, 2016-12-27 at 22:17:35 +0100, David Dillow wrote: >On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote: >> In some cases the return value of a failing function is not being used >> and the function typhoon_init_one() returns another negative error >> code ins

[PATCH v4 1/2] net: 3com: typhoon: typhoon_init_one: fix incorrect return values

2016-12-29 Thread Thomas Preisner
Reported-by: Pan Bian Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c index 9fe3990..25f2e92

[PATCH v4 2/2] net: 3com: typhoon: typhoon_init_one: make return values more specific

2016-12-29 Thread Thomas Preisner
In some cases the return value of a failing function is not being used and the function typhoon_init_one() returns another negative error code instead. Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 16 1 file changed, 8

Re: Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Thomas Preisner
Hello. On Sat, 2016-12-24 at 20:06 +0100, Sergei Shtylyov wrote: >Hello! > >On 12/24/2016 03:02 PM, Thomas Preisner wrote: > >> In a few cases the err-variable is not set to a negative error code if a >> function call fails and thus 0 is returned instead. >> It m

[PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Thomas Preisner
In some cases the return value of a failing function is not being used and the function typhoon_init_one() returns another negative error code instead. Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 16 1 file changed, 8

[PATCH v3 1/2] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Thomas Preisner
Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c index a0cacbe..c88b88a 100644 --- a/drivers/net

[PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Thomas Preisner
Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c index a0cacbe..c88b88a 100644 --- a/drivers/net

Re: [PATCH] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Thomas Preisner
On Sat, 2016-12-24 at 02:06 +0100, David Dillow wrote: >On Sat, 2016-12-24 at 00:00 +0100, Thomas Preisner wrote: >> diff --git a/drivers/net/ethernet/3com/typhoon.c >> b/drivers/net/ethernet/3com/typhoon.c >> index a0cacbe..9a3ab58 100644 >> --- a/drivers/net/ether

[PATCH v2 2/2] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Thomas Preisner
In some cases the return value of a failing function is not being used and the function typhoon_init_one() returns another negative error code instead. Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 16 1 file changed, 8

[PATCH] drivers: net: ethernet: 3com: fix return value

2016-12-23 Thread Thomas Preisner
-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c index a0cacbe..9a3ab58 100644 --- a/drivers/net/ethernet/3com/typhoon.c

[PATCH] drivers: staging: iio: cdc: fix return value

2016-12-23 Thread Thomas Preisner
At the end of function ad7150_write_event_config(), "return 0" seems improper. It may be better to return the value of ret. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188871 Reported-by: Pan Bian Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/s