Re: [PATCH AUTOSEL 4.19 04/42] netfilter: conntrack: always store window size un-scaled

("netfilter: conntrack: lower timeout to RETRANS > seconds if window is 0") > Reported-by: Jakub Jankowski > Tested-by: Jakub Jankowski > Signed-off-by: Florian Westphal > Acked-by: Jozsef Kadlecsik > Signed-off-by: Pablo Neira Ayuso > Signed-off-by: Sasha Levin

[RFC PATCH, untested] Fix off-by-one in tps_comparators[] access

ror) Array 'tps_comparators[2]' accessed at index 2, which is out of bounds. Signed-off-by: Thomas Jarosch --- drivers/mfd/tps65911-comparator.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/tps65911-comparator.c b/drivers/mfd/tps65911-comparator.c in

[staging PATCH] Add missing va_end() call

Reported by cppcheck Signed-off-by: Thomas Jarosch --- drivers/staging/unisys/uislib/uisutils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/unisys/uislib/uisutils.c b/drivers/staging/unisys/uislib/uisutils.c index 8ff6d26..d821c82 100644 --- a/drivers/staging/unisys

Re: 3.14.19: Oops on boot in rapl_cpu_prepare()

Hi again, On Wednesday, 24. September 2014 17:09:01 Thomas Jarosch wrote: > ... > general protection fault: [#1] SMP > Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.14.19-1.i2n.i686 #1 > Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 > task: f58

3.14.19: Oops on boot in rapl_cpu_prepare()

Hi Artem, I just upgraded from kernel 3.4.101 to 3.14.19. Now the system fails to boot using qemu (kernel Oops): -- ... UDP hash table entries: 512 (order: 2, 16384 bytes) UDP-Lite hash table entries: 512 (order: 2, 16384 bytes) NET: Registered

[tip:perf/core] perf header: Fix memory leak for the " Not caching a kptr_restrict'ed /proc/kallsyms" case

Commit-ID: fdae6373910c10e27b8ae07e11e821b183d0bba5 Gitweb: http://git.kernel.org/tip/fdae6373910c10e27b8ae07e11e821b183d0bba5 Author: Thomas Jarosch AuthorDate: Fri, 25 Jan 2013 11:21:39 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 30 Jan 2013 10:40:18 -0300 perf header

[tip:perf/core] perf tools: Fix memory leak on error

Commit-ID: 0b9e01a4f0d1c8277da6824fe060ccb0434d2fde Gitweb: http://git.kernel.org/tip/0b9e01a4f0d1c8277da6824fe060ccb0434d2fde Author: Thomas Jarosch AuthorDate: Fri, 25 Jan 2013 11:20:47 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 30 Jan 2013 10:40:05 -0300 perf tools

[tip:perf/core] perf sort: Use pclose() instead of fclose() on pipe stream

Commit-ID: 8eb44dd76ac994b020e5cfe72635c90d9e0ad995 Gitweb: http://git.kernel.org/tip/8eb44dd76ac994b020e5cfe72635c90d9e0ad995 Author: Thomas Jarosch AuthorDate: Fri, 25 Jan 2013 11:02:13 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 30 Jan 2013 10:38:48 -0300 perf sort

[tip:perf/core] perf tools: Fix possible double free on error

Commit-ID: 68c465ada54c730d653fc6fdc9dc0d5270b2de00 Gitweb: http://git.kernel.org/tip/68c465ada54c730d653fc6fdc9dc0d5270b2de00 Author: Thomas Jarosch AuthorDate: Fri, 25 Jan 2013 10:57:08 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 30 Jan 2013 10:37:41 -0300 perf tools

[perf PATCH v2] Fix double fclose() on do_write(fd, xxx) failure

cppcheck reported: [util/header.c:983]: (error) Used file that is not opened. Thanks to Arnaldo Carvalho de Melo for pointing out that fclose(NULL) is undefined behavior -> protect against it. Signed-off-by: Thomas Jarosch --- tools/perf/util/header.c | 4 +++- 1 file changed, 3 inserti

[perf PATCH] Fix NULL pointer dereference on error

pclose(NULL) is undefined behavior and crashes. Signed-off-by: Thomas Jarosch --- tools/perf/util/sort.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index a83ded2..8333661 100644 --- a/tools/perf/util/sort.c +++ b

Re: [perf PATCH 3/3] Fix double fclose() on do_write(fd, xxx) failure

On Friday, 25. January 2013 13:01:51 you wrote: > Em Fri, Jan 25, 2013 at 11:22:17AM +0100, Thomas Jarosch escreveu: > > cppcheck reported: > > [util/header.c:983]: (error) Used file that is not opened. > > > > Signed-off-by: Thomas Jarosch > > --- > > >

[tip:perf/core] perf tools: Fix possible (unlikely) buffer overflow

Commit-ID: a65c23420668f7112395abf9c6f22c6450567bf0 Gitweb: http://git.kernel.org/tip/a65c23420668f7112395abf9c6f22c6450567bf0 Author: Thomas Jarosch AuthorDate: Tue, 25 Dec 2012 17:23:39 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 24 Jan 2013 16:40:18 -0300 perf tools

[perf PATCH 3/3] Fix double fclose() on do_write(fd, xxx) failure

cppcheck reported: [util/header.c:983]: (error) Used file that is not opened. Signed-off-by: Thomas Jarosch --- tools/perf/util/header.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index 7b24cf3..30745c2 100644 --- a/tools/perf/util

[perf PATCH 2/3] Fix memory leak for the "Not caching a kptr_restrict'ed /proc/kallsyms\n" case

cppcheck reported: [util/header.c:316]: (error) Memory leak: filename [util/header.c:316]: (error) Memory leak: linkname Signed-off-by: Thomas Jarosch --- tools/perf/util/header.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/header.c b/tools/perf/util

[perf PATCH 1/3] Fix memory leak on error

cppcheck reported: [util/event.c:480]: (error) Memory leak: event Signed-off-by: Thomas Jarosch --- tools/perf/util/event.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c index 3cf2c3e..5cd13d7 100644 --- a/tools/perf

[perf PATCH v2] Use pclose() instead of fclose() on pipe stream

cppcheck message: [tools/perf/util/sort.c:277]: (error) Mismatching allocation and deallocation: fp Also fix descriptor leak on error and always initialize the "fp" variable. Signed-off-by: Thomas Jarosch --- tools/perf/util/sort.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[perf PATCH resend] Fix possible double free on error

Can only be triggered via CROSS_COMPILE env var. Detected by cppcheck. Signed-off-by: Thomas Jarosch --- tools/perf/arch/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c index 3e975cb..aacef07 100644 --- a/tools/perf/arch/common.c

Re: Re: [perf PATCH] Use pclose() instead of fclose() on pipe stream

Hi Arnaldo, On Friday, 11. January 2013 01:16:03 you wrote: > > Also fix descriptor leak on error > > > > Signed-off-by: Thomas Jarosch > > --- > > > > tools/perf/util/sort.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > After

[perf PATCH] Fix possible (unlikely) buffer overflow

AX+1. Signed-off-by: Thomas Jarosch --- tools/perf/util/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/sysfs.c b/tools/perf/util/sysfs.c index 48c6902..606f884 100644 --- a/tools/perf/util/sysfs.c +++ b/tools/perf/util/sysfs.c @@ -8,7 +8,7 @@ stat

[perf PATCH] Use pclose() instead of fclose() on pipe stream

cppcheck message: [tools/perf/util/sort.c:277]: (error) Mismatching allocation and deallocation: fp Also fix descriptor leak on error Signed-off-by: Thomas Jarosch --- tools/perf/util/sort.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/sort.c b/tools

[perf PATCH] Fix possible double free on error

Can only be triggered via CROSS_COMPILE env var. Detected by cppcheck. Signed-off-by: Thomas Jarosch --- tools/perf/arch/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c index 3e975cb..aacef07 100644 --- a/tools/perf/arch/common.c

Re: Kernel oops during netfilter memory allocation

Hello together, I've found an easier way to demonstrate the bug and filed a report at bugzilla.kernel.org: http://bugzilla.kernel.org/show_bug.cgi?id=8928 Hope there will be a quick resolution for this issue as the boxes crashing serve 800 users and more. Best regards, Thomas - To unsubscribe f

Re: Kernel oops during netfilter memory allocation

Hello, > > kernel BUG at arch/i386/mm/highmem.c:38 > > > > Try this. I just tried kernel 2.6.22.4 and 2.6.23-rc3. Using 2.6.23-rc3 vanilla, the box survives only 3 seconds with ipt_CRASH. Here's the backtrace, it's only slightly different: [ cut here ] kernel BUG at a

Re: Kernel oops during netfilter memory allocation

On Monday, 20. August 2007, Alexey Dobriyan wrote: > kernel BUG at arch/i386/mm/highmem.c:38 > > Try this. > > commit b8c1c5da1520977cb55a358f20fc09567d40cad9 > tree c762e6ad77297beed0978337ce2f5b0c50add739 > parent 01e457cfcd5b6b6f18d0bb8cec0c5d43df56557e > author Andrew Morton <[EMAIL PROTE

e100 patch for kernel 2.2.18

Hi, I've seen the e100 udelay/compile problem twice and now I think, I should release my patch. I've already send it to Intel but the are not responding. Please CC: any comments. cheers, Thomas. e100-type.patch e100-mdelay.patch

Oops: Unable to handle kernel paging request with kernel 2.2.12 and 2.2.16

Dear kernel development team, I experienced two kernel oops this month. Both of them happened while executing cron jobs at night. Upgrading from 2.2.12 to 2.2.16 didn't solve the problem. I'm no kernel hacker but if you look at the call trace, you can always see functions related to the file I/O