Re: [PATCH] jffs2: Don't add summary entry when MTD write fails

2016-02-25 Thread Thomas . Betker
Hello David: > > + int ret; > > + > > + ret = mtd_writev(c->mtd, vecs, count, to, retlen); > > + > > if (!jffs2_is_writebuffered(c)) { > > if (jffs2_sum_active()) { > > int res; > > + > > + if (ret || > > +

Re: JFFS2 deadlock

2016-02-25 Thread Thomas . Betker
Hello Joakim: > Can we get this upstream before next release? I don't think there > will much more > testing at this point. I would second this. Actually, I did some additional stress testing, but didn't see any problems. Best regards, Thomas

Re: JFFS2 deadlock

2016-02-18 Thread Thomas . Betker
o run some more stress tests here just to check that there weren't any unexpected side effects. (Don't get me wrong -- I am sure the patch is fine, but for me it's a case of "once bitten, twice shy" ...) Best regards, Thomas Betker

Re: JFFS2 deadlock

2016-02-01 Thread Thomas . Betker
tml. The problem with that patch was that it modified mm/filemap.c and include/linux/pagemap.h, which we were not too happy about. Your patch looks much simpler, and I will definitely test it. It may take a few days, though, as I have to unearth the test scripts, and find a time slot for testing. Best regards, Thomas Betker

Re: JFFS2 deadlock

2016-01-28 Thread Thomas . Betker
Hello Brian: > No, I'm pretty sure this is not the first report. I think there have > even been patches. The problem is that JFFS2 is effectively > unmaintained, despite what MAINTAINERS has to say about it. > > Previous reports: > > Subject: Another JFFS2 deadlock, kernel 3.4.11 > http://thread

[PATCH] jffs2: Don't add summary entry when MTD write fails

2015-11-11 Thread Thomas Betker
From: Thomas Betker jffs2_flash_direct_writev() always invokes jffs2_sum_add_kvec(), even if mtd_writev() fails. Usually, this results in an extra summary entry pointing to dirty node space, which should be ignored -- it is a bit of a waste, but harmless. When mtd_writev() returns *retlen == 0

[PATCH] iio: adc: xilinx: Fix VREFN scale

2015-11-11 Thread Thomas Betker
From: Thomas Betker The scaling factor for VREFN is 3.0/4096 (not 1.0/4096), just as for VREFP. This is not immediately obvious from the specification (Xilinx UG480), but has been confirmed by Xilinx support. Suggested-by: Hartmut Knaack Signed-off-by: Thomas Betker --- drivers/iio/adc

[PATCH] Revert "jffs2: Fix lock acquisition order bug in jffs2_write_begin"

2015-11-10 Thread Thomas Betker
From: Thomas Betker This reverts commit 5ffd3412ae55 ("jffs2: Fix lock acquisition order bug in jffs2_write_begin"). The commit modified jffs2_write_begin() to remove a deadlock with jffs2_garbage_collect_live(), but this introduced new deadlocks found by multiple users. page_lock(

Re: [RFC PATCH 0/2] spi: add dual parallel & stacked mode support in Zynq MPSoC GQSPI controller

2015-07-13 Thread Thomas . Betker
e, is there a MTD concatenation support? In addition to 5), the MTD driver using a dual-parallel QSPI flash has to 5a) add padding at the start of data for unaligned addresses, 5b) add padding at the end of data for unaligned lengths. Best regards, Thomas Betker -- To unsubscribe fro

Re: [PATCH] ARM: zynq: Set bit 22 in PL310 AuxCtrl register (6395/1)

2015-05-18 Thread Thomas . Betker
l > > If you can fix it in the boot loader or firmware even better. If it's > not doable, this patch will help (if Russell takes it): > > http://article.gmane.org/gmane.linux.ports.sh.devel/45685 Thanks for the info! Geert's patch looks good to me, and I sure hope it will be

Re: [PATCH] ARM: zynq: Set bit 22 in PL310 AuxCtrl register (6395/1)

2015-05-12 Thread Thomas . Betker
erwrite hardwired settings such as cache size, but shouldn't we at least allow to fix things that definitely need to be fixed? Best regards, Thomas Betker -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/3] Using SPI NOR flah on sunxi.

2015-04-30 Thread Thomas . Betker
Hello Michal: > I tried to connect a SPI NOR flash to my sunxi board and due to the current > sunxi SPI driver limitations it does not work. > > The SPI driver returns an error when more than 64 bytes are > transferred at once > due to lack of DMA support. Wouldn't it be easier to fix the SPI