RE: [PATCH v2] qed: Avoid implicit enum conversion in qed_ooo_submit_tx_buffers

2018-10-04 Thread Tayar, Tomer
From: Nathan Chancellor Sent: Thursday, October 04, 2018 7:39 PM > Clang warns when one enumerated type is implicitly converted to another. > > drivers/net/ethernet/qlogic/qed/qed_ll2.c:799:32: warning: implicit > conversion from enumeration type 'enum core_tx_dest' to different > enumeration ty

RE: [PATCH] qed: Use zeroing memory allocator than allocator/memset

2018-01-01 Thread Tayar, Tomer
From: Himanshu Jha [mailto:himanshujha199...@gmail.com] Sent: Saturday, December 30, 2017 5:37 PM > Use dma_zalloc_coherent and vzalloc for allocating zeroed > memory and remove unnecessary memset function. > > Done using Coccinelle. > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.coc

RE: [PATCH] qed: Delete redundant check on dcb_app priority

2017-10-08 Thread Tayar, Tomer
> dcb_app priority is unsigned thus checking whether it is less than zero > is redundant. > > Signed-off-by: Christos Gkekas Thanks Acked-By: Tomer Tayar

RE: [PATCH] qed: Fix a memory allocation failure test in 'qed_mcp_cmd_init()'

2017-08-07 Thread Tayar, Tomer
> We allocate 'p_info->mfw_mb_cur' and 'p_info->mfw_mb_shadow' but we > check > 'p_info->mfw_mb_addr' instead of 'p_info->mfw_mb_cur'. > > 'p_info->mfw_mb_addr' is never 0, because it is initiliazed a few lines > above in 'qed_load_mcp_offsets()'. > > Update the test and check the result of the 2