Re: [PATCH v2 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-18 Thread Tanmay Inamdar
config_read32 > > Signed-off-by: Duc Dang > Tested-by: Ian Campbell > Tested-by: Marcin Juszkiewicz Acked-by: Tanmay Inamdar --- > drivers/pci/host/pci-xgene.c | 43 ++- > 1 file changed, 42 insertions(+), 1 deletion(-) > > diff

Re: [PATCH] pci: host: xgene: fix incorrectly returned address by map_bus

2015-02-19 Thread Tanmay Inamdar
t_cfg_base(bus); > + return xgene_pcie_get_cfg_base(bus) + offset; > } > > static struct pci_ops xgene_pcie_ops = { Acked-by: Tanmay Inamdar > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

Re: [PATCH v10 0/4] APM X-Gene PCIe host controller

2014-10-02 Thread Tanmay Inamdar
On Thu, Oct 2, 2014 at 7:36 AM, Bjorn Helgaas wrote: > On Thu, Oct 2, 2014 at 6:20 AM, Arnd Bergmann wrote: >> On Wednesday 01 October 2014 13:14:03 Bjorn Helgaas wrote: >>> On Fri, Sep 26, 2014 at 02:08:23PM -0700, Tanmay Inamdar wrote: >>> > This patch adds suppor

[PATCH v10 4/4] MAINTAINERS: entry for APM X-Gene PCIe host driver

2014-09-26 Thread Tanmay Inamdar
Add entry for AppliedMicro X-Gene PCIe host driver. Signed-off-by: Tanmay Inamdar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 670b3dc..b18bc49 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6942,6 +6942,14 @@ L: linux

[PATCH v10 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-09-26 Thread Tanmay Inamdar
This patch adds the device tree nodes for APM X-Gene PCIe host controller and PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes are added. Signed-off-by: Tanmay Inamdar --- arch/arm64/boot/dts/apm-mustang.dts | 8 ++ arch/arm64/boot/dts/apm-storm.dtsi | 165

[PATCH v10 0/4] APM X-Gene PCIe host controller

2014-09-26 Thread Tanmay Inamdar
t to read inbound region configuration. 6. renamed host driver file to 'pci-xgene.c' from 'pcie-xgene.c' 7. dropped 'clock-names' property from bindings 8. added comments whereever requested. Tanmay Inamdar (4): pci:host: APM X-Gene PCIe host controller driver arm64: dt

[PATCH v10 1/4] pci:host: APM X-Gene PCIe host controller driver

2014-09-26 Thread Tanmay Inamdar
This patch adds the AppliedMicro X-Gene SOC PCIe host controller driver. X-Gene PCIe controller supports maximum up to 8 lanes and GEN3 speed. X-Gene SOC supports maximum 5 PCIe ports. Reviewed-by: Liviu Dudau Tested-by: Ming Lei Tested-by: Dann Frazier Signed-off-by: Tanmay Inamdar

[PATCH v10 3/4] dt-bindings: pci: xgene pcie device tree bindings

2014-09-26 Thread Tanmay Inamdar
This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pci-xgene.c' file. Signed-off-by: Tanmay Inamdar --- .../devicetree/bindings/pci/xgene-pci.txt | 57 ++ 1 file changed, 57 insertions(+) create mode 100644 Doc

Re: [PATCH v9 1/4] pci:host: APM X-Gene PCIe host controller driver

2014-09-22 Thread Tanmay Inamdar
On Mon, Sep 22, 2014 at 3:27 PM, Jason Gunthorpe wrote: > On Mon, Sep 22, 2014 at 04:09:03PM -0600, Bjorn Helgaas wrote: >> On Mon, Sep 22, 2014 at 3:33 PM, Tanmay Inamdar wrote: >> >> >>> +static void xgene_pcie_fixup_bridge(struct pci_dev *dev

Re: [PATCH v9 1/4] pci:host: APM X-Gene PCIe host controller driver

2014-09-22 Thread Tanmay Inamdar
On Mon, Sep 22, 2014 at 3:09 PM, Bjorn Helgaas wrote: > On Mon, Sep 22, 2014 at 3:33 PM, Tanmay Inamdar wrote: > >>>> +static void xgene_pcie_fixup_bridge(struct pci_dev *dev) >>>> +{ >>>> + int i; >>>> + >>>> +

Re: [PATCH v9 1/4] pci:host: APM X-Gene PCIe host controller driver

2014-09-22 Thread Tanmay Inamdar
Hello Bjorn, Thanks for the review and comments. Please see my inline replies. Thanks, Tanmay On Fri, Sep 19, 2014 at 3:32 PM, Bjorn Helgaas wrote: > On Tue, Sep 16, 2014 at 03:33:41PM -0700, Tanmay Inamdar wrote: >> This patch adds the AppliedMicro X-Gene SOC PCIe host controller dri

Re: [PATCH v9 0/4] APM X-Gene PCIe host controller

2014-09-19 Thread Tanmay Inamdar
Hi Ming Lei, On Thu, Sep 18, 2014 at 8:08 PM, Ming Lei wrote: > Hi Tanmay, > > On Wed, Sep 17, 2014 at 6:33 AM, Tanmay Inamdar wrote: >> This patch adds support for AppliedMicro X-Gene PCIe host controller. The >> driver is tested on X-Gene platform with different g

[PATCH v9 4/4] MAINTAINERS: entry for APM X-Gene PCIe host driver

2014-09-16 Thread Tanmay Inamdar
Add entry for AppliedMicro X-Gene PCIe host driver. Signed-off-by: Tanmay Inamdar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5e7866a..cd9bb3da 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6941,6 +6941,14 @@ L: linux

[PATCH v9 1/4] pci:host: APM X-Gene PCIe host controller driver

2014-09-16 Thread Tanmay Inamdar
This patch adds the AppliedMicro X-Gene SOC PCIe host controller driver. X-Gene PCIe controller supports maximum up to 8 lanes and GEN3 speed. X-Gene SOC supports maximum 5 PCIe ports. Reviewed-by: Liviu Dudau Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig | 10 + drivers/pci

[PATCH v9 0/4] APM X-Gene PCIe host controller

2014-09-16 Thread Tanmay Inamdar
d pci addresses from device tree to configure regions. 3. got rid of unnecessary wrappers for readl and writel. 4. got rid of endpoint configuration code. 5. added 'dma-ranges' property support to read inbound region configuration. 6. renamed host driver file to 'pci-xgene.c' fr

[PATCH v9 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-09-16 Thread Tanmay Inamdar
This patch adds the device tree nodes for APM X-Gene PCIe host controller and PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes are added. Signed-off-by: Tanmay Inamdar --- arch/arm64/boot/dts/apm-mustang.dts | 8 ++ arch/arm64/boot/dts/apm-storm.dtsi | 165

[PATCH v9 3/4] dt-bindings: pci: xgene pcie device tree bindings

2014-09-16 Thread Tanmay Inamdar
This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pci-xgene.c' file. Signed-off-by: Tanmay Inamdar --- .../devicetree/bindings/pci/xgene-pci.txt | 57 ++ 1 file changed, 57 insertions(+) create mode 100644 Doc

Re: [PATCH v8 1/4] pci:host: APM X-Gene PCIe host controller driver

2014-09-16 Thread Tanmay Inamdar
On Tue, Sep 16, 2014 at 2:17 PM, Liviu Dudau wrote: > On Tue, Sep 16, 2014 at 09:02:11PM +0100, Tanmay Inamdar wrote: >> On Fri, Sep 12, 2014 at 2:18 AM, Liviu Dudau wrote: >> > On Thu, Sep 11, 2014 at 11:57:43PM +0100, Tanmay Inamdar wrote: >> >> This patch adds th

Re: [PATCH v8 1/4] pci:host: APM X-Gene PCIe host controller driver

2014-09-16 Thread Tanmay Inamdar
On Fri, Sep 12, 2014 at 2:18 AM, Liviu Dudau wrote: > On Thu, Sep 11, 2014 at 11:57:43PM +0100, Tanmay Inamdar wrote: >> This patch adds the AppliedMicro X-Gene SOC PCIe host controller driver. >> X-Gene PCIe controller supports maximum up to 8 lanes and GEN3 speed. >> X-Gene

[PATCH v8 1/4] pci:host: APM X-Gene PCIe host controller driver

2014-09-11 Thread Tanmay Inamdar
This patch adds the AppliedMicro X-Gene SOC PCIe host controller driver. X-Gene PCIe controller supports maximum up to 8 lanes and GEN3 speed. X-Gene SOC supports maximum 5 PCIe ports. Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig | 10 + drivers/pci/host/Makefile| 1

[PATCH v8 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-09-11 Thread Tanmay Inamdar
This patch adds the device tree nodes for APM X-Gene PCIe host controller and PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes are added. Signed-off-by: Tanmay Inamdar --- arch/arm64/boot/dts/apm-mustang.dts | 8 ++ arch/arm64/boot/dts/apm-storm.dtsi | 160

[PATCH v8 0/4] APM X-Gene PCIe host controller

2014-09-11 Thread Tanmay Inamdar
cessary wrappers for readl and writel. 4. got rid of endpoint configuration code. 5. added 'dma-ranges' property support to read inbound region configuration. 6. renamed host driver file to 'pci-xgene.c' from 'pcie-xgene.c' 7. dropped 'clock-names' property f

[PATCH v8 4/4] MAINTAINERS: entry for APM X-Gene PCIe host driver

2014-09-11 Thread Tanmay Inamdar
Add entry for AppliedMicro X-Gene PCIe host driver. Signed-off-by: Tanmay Inamdar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5e7866a..cd9bb3da 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6941,6 +6941,14 @@ L: linux

[PATCH v8 3/4] dt-bindings: pci: xgene pcie device tree bindings

2014-09-11 Thread Tanmay Inamdar
This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pci-xgene.c' file. Signed-off-by: Tanmay Inamdar --- .../devicetree/bindings/pci/xgene-pci.txt | 55 ++ 1 file changed, 55 insertions(+) create mode 100644 Doc

Re: [PATCH v7 1/4] pci:host: APM X-Gene PCIe host controller driver

2014-09-11 Thread Tanmay Inamdar
On Thu, Sep 11, 2014 at 4:12 AM, Liviu Dudau wrote: > On Thu, Sep 11, 2014 at 12:20:17AM +0100, Tanmay Inamdar wrote: >> This patch adds the AppliedMicro X-Gene SOC PCIe host controller driver. >> X-Gene PCIe controller supports maximum up to 8 lanes and GEN3 speed. >> X-Gene

[PATCH v7 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-09-10 Thread Tanmay Inamdar
This patch adds the device tree nodes for APM X-Gene PCIe host controller and PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes are added. Signed-off-by: Tanmay Inamdar --- arch/arm64/boot/dts/apm-mustang.dts | 8 ++ arch/arm64/boot/dts/apm-storm.dtsi | 160

[PATCH v7 3/4] dt-bindings: pci: xgene pcie device tree bindings

2014-09-10 Thread Tanmay Inamdar
This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pci-xgene.c' file. Signed-off-by: Tanmay Inamdar --- .../devicetree/bindings/pci/xgene-pci.txt | 55 ++ 1 file changed, 55 insertions(+) create mode 100644 Doc

[PATCH v7 1/4] pci:host: APM X-Gene PCIe host controller driver

2014-09-10 Thread Tanmay Inamdar
This patch adds the AppliedMicro X-Gene SOC PCIe host controller driver. X-Gene PCIe controller supports maximum up to 8 lanes and GEN3 speed. X-Gene SOC supports maximum 5 PCIe ports. Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig | 10 + drivers/pci/host/Makefile| 1

[PATCH v7 4/4] MAINTAINERS: entry for APM X-Gene PCIe host driver

2014-09-10 Thread Tanmay Inamdar
Add entry for AppliedMicro X-Gene PCIe host driver. Signed-off-by: Tanmay Inamdar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5e7866a..cd9bb3da 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6941,6 +6941,14 @@ L: linux

[PATCH v7 0/4] APM X-Gene PCIe host controller

2014-09-10 Thread Tanmay Inamdar
'dma-ranges' property support to read inbound region configuration. 6. renamed host driver file to 'pci-xgene.c' from 'pcie-xgene.c' 7. dropped 'clock-names' property from bindings 8. added comments whereever requested. Tanmay Inamdar (4): pci:host: APM X-

Re: [PATCH v6 0/4] APM X-Gene PCIe host controller

2014-09-08 Thread Tanmay Inamdar
On Mon, Sep 8, 2014 at 6:59 AM, Liviu Dudau wrote: > On Sat, Sep 06, 2014 at 08:17:43AM -0600, Bjorn Helgaas wrote: >> On Fri, Sep 5, 2014 at 6:25 PM, Tanmay Inamdar wrote: >> > This patch adds support for AppliedMicro X-Gene PCIe host controller. The >> > driver i

[PATCH v6 4/4] MAINTAINERS: entry for APM X-Gene PCIe host driver

2014-09-05 Thread Tanmay Inamdar
Add entry for AppliedMicro X-Gene PCIe host driver. Signed-off-by: Tanmay Inamdar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5e7866a..cd9bb3da 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6941,6 +6941,14 @@ L: linux

[PATCH v6 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-09-05 Thread Tanmay Inamdar
This patch adds the device tree nodes for APM X-Gene PCIe controller and PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes are added. Signed-off-by: Tanmay Inamdar --- arch/arm64/boot/dts/apm-mustang.dts | 8 ++ arch/arm64/boot/dts/apm-storm.dtsi | 160

[PATCH v6 1/4] pci:host: APM X-Gene PCIe controller driver

2014-09-05 Thread Tanmay Inamdar
This patch adds the AppliedMicro X-Gene SOC PCIe controller driver. X-Gene PCIe controller supports maximum up to 8 lanes and GEN3 speed. X-Gene SOC supports maximum 5 PCIe ports. Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig | 10 + drivers/pci/host/Makefile| 1

[PATCH v6 0/4] APM X-Gene PCIe host controller

2014-09-05 Thread Tanmay Inamdar
host driver file to 'pci-xgene.c' from 'pcie-xgene.c' 7. dropped 'clock-names' property from bindings 8. added comments whereever requested. Tanmay Inamdar (4): pci:host: APM X-Gene PCIe controller driver arm64: dts: APM X-Gene PCIe device tree nodes dt-binding

[PATCH v6 3/4] dt-bindings: pci: xgene pcie device tree bindings

2014-09-05 Thread Tanmay Inamdar
This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pci-xgene.c' file. Signed-off-by: Tanmay Inamdar --- .../devicetree/bindings/pci/xgene-pci.txt | 55 ++ 1 file changed, 55 insertions(+) create mode 100644 Doc

Re: [PATCH v8 0/9] Support for creating generic PCI host bridges from DT

2014-07-10 Thread Tanmay Inamdar
Hi, On Tue, Jul 8, 2014 at 10:18 AM, Liviu Dudau wrote: > On Sun, Jul 06, 2014 at 04:23:43PM +0100, Rob Herring wrote: >> On Tue, Jul 1, 2014 at 1:43 PM, Liviu Dudau wrote: >> > This is my resurected attempt at adding support for generic PCI host >> > bridge controllers that make use of device t

Re: [PATCH] arm64: PCI(e) arch support

2014-07-07 Thread Tanmay Inamdar
On Thu, Jul 3, 2014 at 5:40 PM, Prabhakar Kushwaha wrote: > Hi Tanmay, Liviu, > > On 7/4/2014 2:57 AM, Tanmay Inamdar wrote: >> >> Reposting on request of several people since previously posted one was >> corrupted. >> >> This patch adds the arch support f

[PATCH] arm64: PCI(e) arch support

2014-07-03 Thread Tanmay Inamdar
has posted his v8 series of patch to support PCIe in arm64. The patch will apply against 3.13 Linux Kernel Signed-off-by: Tanmay Inamdar --- arch/arm64/Kconfig | 19 ++ arch/arm64/include/asm/dma.h | 18 + arch/arm64/include/asm/io.h | 19 +- arch/arm64/include/asm

Re: [PATCH v8 2/9] pci: Export find_pci_host_bridge() function.

2014-07-02 Thread Tanmay Inamdar
On Wed, Jul 2, 2014 at 12:12 PM, Arnd Bergmann wrote: > On Wednesday 02 July 2014 11:06:38 Tanmay Inamdar wrote: >> On Tue, Jul 1, 2014 at 11:43 AM, Liviu Dudau wrote: >> > This is a useful function and we should make it visible outside the >> > generic PCI code

Re: [PATCH v8 2/9] pci: Export find_pci_host_bridge() function.

2014-07-02 Thread Tanmay Inamdar
Hi, On Tue, Jul 1, 2014 at 11:43 AM, Liviu Dudau wrote: > This is a useful function and we should make it visible outside the > generic PCI code. Export it as a GPL symbol. > > Signed-off-by: Liviu Dudau > Tested-by: Tanmay Inamdar > --- > drivers/pci/host-bridge.c | 3

Re: [RFC PATCH] arm64: Add arch support for PCI

2014-07-02 Thread Tanmay Inamdar
On Wed, May 21, 2014 at 11:57 AM, Kumar Gala wrote: > > On Nov 21, 2013, at 7:38 AM, Tanmay Inamdar wrote: > >> This patch adds the PCI(e) arch support in arm64. The files are >> based on PCI(e) support in 32bit arm. >> >> >> Signed-off-by: Tanma

Re: [PATCH v7 0/3] Add support for PCI in AArch64

2014-04-23 Thread Tanmay Inamdar
Hello Sandeepa, On Tue, Apr 22, 2014 at 4:50 AM, Sandeepa Prabhu wrote: > On 22 April 2014 15:41, Liviu Dudau wrote: >> On Tue, Apr 22, 2014 at 09:58:28AM +0100, Sandeepa Prabhu wrote: >>> On 14 March 2014 21:04, Liviu Dudau wrote: >>> > Hi, >>> > >>> > This patch adds support for PCI to AArch6

Re: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-25 Thread Tanmay Inamdar
Hello Liviu, Thanks for taking a look. Please see inline. On Tue, Mar 25, 2014 at 7:02 AM, Liviu Dudau wrote: > On Wed, Mar 19, 2014 at 11:12:39PM +0000, Tanmay Inamdar wrote: >> This patch adds the AppliedMicro X-Gene SOC PCIe controller driver. >> X-Gene PCIe controller support

Re: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-25 Thread Tanmay Inamdar
Hello Phil, Thanks for reviewing. Please see inline. On Tue, Mar 25, 2014 at 1:52 AM, wrote: > Hi Tanmay, > > On: 19/03/2014 23:15, Tanmay wrote: >> Subject: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver >> Sent by: linux-pci-ow...@vger.kernel.org >> >> This patch adds the AppliedMicro

Re: [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-21 Thread Tanmay Inamdar
ch doesn't use pci_claim_resource. > > Please look into below patches from Bjorn. > https://lkml.org/lkml/2014/2/26/629 > > Thanks, > Sunil. > > On Thu, Mar 20, 2014 at 4:42 AM, Tanmay Inamdar wrote: >> This patch adds the AppliedMicro X-Gene SOC PCIe controlle

[PATCH v5 1/4] pci: APM X-Gene PCIe controller driver

2014-03-19 Thread Tanmay Inamdar
This patch adds the AppliedMicro X-Gene SOC PCIe controller driver. X-Gene PCIe controller supports maximum up to 8 lanes and GEN3 speed. X-Gene SOC supports maximum 5 PCIe ports. Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig | 10 + drivers/pci/host/Makefile|1

[PATCH v5 4/4] MAINTAINERS: entry for APM X-Gene PCIe host driver

2014-03-19 Thread Tanmay Inamdar
Add entry for AppliedMicro X-Gene PCIe host driver. Signed-off-by: Tanmay Inamdar --- MAINTAINERS |7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b3fdb0f..cc10644 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6638,6 +6638,13 @@ L: linux

[PATCH v5 0/4] APM X-Gene PCIe controller

2014-03-19 Thread Tanmay Inamdar
d 'dma-ranges' property support to read inbound region configuration. 6. renamed host driver file to 'pci-xgene.c' from 'pcie-xgene.c' 7. dropped 'clock-names' property from bindings 8. added comments whereever requested. Tanmay Inamdar (4): pci: APM

[PATCH v5 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-03-19 Thread Tanmay Inamdar
This patch adds the device tree nodes for APM X-Gene PCIe controller and PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes are added. Signed-off-by: Tanmay Inamdar --- arch/arm64/boot/dts/apm-mustang.dts |8 ++ arch/arm64/boot/dts/apm-storm.dtsi | 155

[PATCH v5 3/4] dt-bindings: pci: xgene pcie device tree bindings

2014-03-19 Thread Tanmay Inamdar
This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pci-xgene.c' file. Signed-off-by: Tanmay Inamdar --- .../devicetree/bindings/pci/xgene-pci.txt | 52 1 file changed, 52 insertions(+) create mode 100644 Doc

Re: [PATCH v4 1/4] pci: APM X-Gene PCIe controller driver

2014-03-14 Thread Tanmay Inamdar
Thanks for the review and comments. I will incorporate the comments from you and Jingoo Han in next version. -Tanmay On Fri, Mar 14, 2014 at 5:18 AM, Arnd Bergmann wrote: > On Thursday 06 March 2014, Tanmay Inamdar wrote: > >> +static inline void xgene_pcie_cfg_out16(void __iomem *a

Re: [PATCH v4 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-03-14 Thread Tanmay Inamdar
On Fri, Mar 14, 2014 at 5:07 AM, Arnd Bergmann wrote: > On Thursday 06 March 2014, Tanmay Inamdar wrote: >> + pcie0: pcie@1f2b { >> + status = "disabled"; >> + device_type = "pci"; >> +

Re: [PATCH v4 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-03-12 Thread Tanmay Inamdar
Hello Jingoo Han, On Wed, Mar 12, 2014 at 1:31 AM, Jingoo Han wrote: > On Thursday, March 06, 2014 3:06 PM, Tanmay Inamdar wrote: >> >> This patch adds the device tree nodes for APM X-Gene PCIe controller and >> PCIe clock interface. Since X-Gene SOC supports maximum 5 port

Re: [PATCH v4 1/4] pci: APM X-Gene PCIe controller driver

2014-03-07 Thread Tanmay Inamdar
Thanks for reviewing and the comments. I will surely include them in next version. -Tanmay On Fri, Mar 7, 2014 at 12:37 AM, Jingoo Han wrote: > On Thursday, March 06, 2014 3:06 PM, Tanmay Inamdar wrote: >> > > Hi Tanmay Inamdar, > > I added some minor comments. :-) >

[PATCH v4 4/4] MAINTAINERS: entry for APM X-Gene PCIe host driver

2014-03-05 Thread Tanmay Inamdar
Add entry for AppliedMicro X-Gene PCIe host driver. Signed-off-by: Tanmay Inamdar --- MAINTAINERS |7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e1297ff..80b7fe5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6629,6 +6629,13 @@ L: linux

[PATCH v4 3/4] dt-bindings: pci: xgene pcie device tree bindings

2014-03-05 Thread Tanmay Inamdar
This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pci-xgene.c' file. Signed-off-by: Tanmay Inamdar --- .../devicetree/bindings/pci/xgene-pci.txt | 52 1 file changed, 52 insertions(+) create mode 100644 Doc

[PATCH v4 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-03-05 Thread Tanmay Inamdar
This patch adds the device tree nodes for APM X-Gene PCIe controller and PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes are added. Signed-off-by: Tanmay Inamdar --- arch/arm64/boot/dts/apm-mustang.dts |8 ++ arch/arm64/boot/dts/apm-storm.dtsi | 155

[PATCH v4 0/4] APM X-Gene PCIe controller

2014-03-05 Thread Tanmay Inamdar
o read inbound region configuration. 6. renamed host driver file to 'pci-xgene.c' from 'pcie-xgene.c' 7. dropped 'clock-names' property from bindings 8. added comments whereever requested. Tanmay Inamdar (4): pci: APM X-Gene PCIe controller driver arm64: dts: APM X-Ge

[PATCH v4 1/4] pci: APM X-Gene PCIe controller driver

2014-03-05 Thread Tanmay Inamdar
This patch adds the AppliedMicro X-Gene SOC PCIe controller driver. X-Gene PCIe controller supports maxmum upto 8 lanes and GEN3 speed. X-Gene SOC supports maximum 5 PCIe ports. Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig | 10 + drivers/pci/host/Makefile|1

Re: [PATCH v5 0/7] [RFC] Support for creating generic host_bridge from device tree

2014-03-05 Thread Tanmay Inamdar
On Wed, Mar 5, 2014 at 12:18 AM, Liviu Dudau wrote: > On Wed, Mar 05, 2014 at 01:53:55AM +0000, Tanmay Inamdar wrote: >> Hello, >> >> Thanks for the patch set. >> >> On Tue, Mar 4, 2014 at 7:49 AM, Liviu Dudau wrote: >> > This is v5 of my attempt to

Re: [PATCH v5 0/7] [RFC] Support for creating generic host_bridge from device tree

2014-03-05 Thread Tanmay Inamdar
On Wed, Mar 5, 2014 at 3:40 AM, Liviu Dudau wrote: > On Wed, Mar 05, 2014 at 01:53:55AM +0000, Tanmay Inamdar wrote: >> Hello, >> >> Thanks for the patch set. >> >> On Tue, Mar 4, 2014 at 7:49 AM, Liviu Dudau wrote: >> > This is v5 of my attempt to

Re: [PATCH v5 0/7] [RFC] Support for creating generic host_bridge from device tree

2014-03-04 Thread Tanmay Inamdar
Hello, Thanks for the patch set. On Tue, Mar 4, 2014 at 7:49 AM, Liviu Dudau wrote: > This is v5 of my attempt to add support for a generic pci_host_bridge > controller created > from a description passed in the device tree. > > Changes from v4: > - Export pci_find_host_bridge() to be used by

Re: [PATCH v5 5/7] pci: Use parent domain number when allocating child busses.

2014-03-04 Thread Tanmay Inamdar
Hello, On Tue, Mar 4, 2014 at 7:50 AM, Liviu Dudau wrote: > pci_alloc_child_bus() uses the newly allocated child bus to figure > out the domain number that is going to use for setting the device > name. A better option is to use the parent bus domain number. > > Signed-off-by: Liviu Dudau > > di

Re: [PATCH v4 5/6] pci: Use parent domain number when allocating child busses.

2014-03-03 Thread Tanmay Inamdar
Hi Liviu, Actually your suggested implementation of pci_domain_nr is working perfectly. My bad for earlier email. I did not implement it correctly. Thanks, Tanmay On Mon, Mar 3, 2014 at 4:42 PM, Tanmay Inamdar wrote: > Hello, > > Please see inline. > > On Mon, Mar 3, 2014 at

Re: [PATCH v4 5/6] pci: Use parent domain number when allocating child busses.

2014-03-03 Thread Tanmay Inamdar
Hello, Please see inline. On Mon, Mar 3, 2014 at 3:51 PM, Liviu Dudau wrote: > On Mon, Mar 03, 2014 at 03:14:47PM -0800, Tanmay Inamdar wrote: >> Hello Liviu, >> >> Thanks for fixing up domain_nr. Now I have moved on further to a new >> dom

Re: [PATCH v4 5/6] pci: Use parent domain number when allocating child busses.

2014-03-03 Thread Tanmay Inamdar
Hello Liviu, Thanks for fixing up domain_nr. Now I have moved on further to a new domain_nr related warning dump :-)

Re: [PATCH v3 5/5] pci: Add support for creating a generic host_bridge from device tree

2014-03-01 Thread Tanmay Inamdar
Hello, On Fri, Feb 28, 2014 at 6:39 PM, Liviu Dudau wrote: > On Fri, Feb 28, 2014 at 06:07:05PM -0800, Tanmay Inamdar wrote: >> Earlier email did not deliver to mailing lists because of plain text >> setting problem on my side. Apologies for spamming. Sending it again. &g

Re: [PATCH v3 5/5] pci: Add support for creating a generic host_bridge from device tree

2014-02-28 Thread Tanmay Inamdar
t here ] WARNING: CPU: 0 PID: 1 at /home/tinamdar/work/open-source/linux/drivers/pci/probe.c:711 pci_add_new_bus+0x36c/0x380() Thanks, Tanmay On Fri, Feb 28, 2014 at 6:01 PM, Tanmay Inamdar wrote: > Hello Liviu, > > While porting X-Gene PCIe driver to v

Re: [PATCH] pci: Add support for creating a generic host_bridge from device tree

2014-02-13 Thread Tanmay Inamdar
On Thu, Feb 13, 2014 at 12:10 AM, Jingoo Han wrote: > On Thursday, February 06, 2014 7:18 PM, Liviu Dudau wrote: >> On Wed, Feb 05, 2014 at 10:26:27PM +0000, Tanmay Inamdar wrote: >> > Hello Liviu, >> > >> > I did not get the first email of this particular pat

Re: [PATCH] pci: Add support for creating a generic host_bridge from device tree

2014-02-10 Thread Tanmay Inamdar
On Sat, Feb 8, 2014 at 6:22 AM, Liviu Dudau wrote: > On Sat, Feb 08, 2014 at 12:21:56AM +0000, Tanmay Inamdar wrote: >> On Thu, Feb 6, 2014 at 2:18 AM, Liviu Dudau wrote: >> > On Wed, Feb 05, 2014 at 10:26:27PM +0000, Tanmay Inamdar wrote: >> >> Hello Liviu, >&

Re: [PATCH] pci: Add support for creating a generic host_bridge from device tree

2014-02-07 Thread Tanmay Inamdar
On Thu, Feb 6, 2014 at 2:18 AM, Liviu Dudau wrote: > On Wed, Feb 05, 2014 at 10:26:27PM +0000, Tanmay Inamdar wrote: >> Hello Liviu, >> >> I did not get the first email of this particular patch on any of >> subscribed mailing lists (don't know why), hence replyin

Re: [PATCH] pci: Add support for creating a generic host_bridge from device tree

2014-02-05 Thread Tanmay Inamdar
Hello Liviu, I did not get the first email of this particular patch on any of subscribed mailing lists (don't know why), hence replying here. +struct pci_host_bridge * +pci_host_bridge_of_init(struct device *parent, int busno, struct pci_ops *ops, + void *host_data, struct list_head *resources) +

Re: [RFC PATCH V3 1/4] pci: APM X-Gene PCIe controller driver

2014-02-03 Thread Tanmay Inamdar
On Mon, Feb 3, 2014 at 12:12 PM, Arnd Bergmann wrote: > On Monday 03 February 2014 11:42:22 Tanmay Inamdar wrote: >> On Thu, Jan 30, 2014 at 6:16 AM, Arnd Bergmann wrote: >> > On Friday 24 January 2014, Tanmay Inamdar wrote: >> > >> >> +static void xgen

Re: [RFC PATCH V3 1/4] pci: APM X-Gene PCIe controller driver

2014-02-03 Thread Tanmay Inamdar
On Thu, Jan 30, 2014 at 6:16 AM, Arnd Bergmann wrote: > On Friday 24 January 2014, Tanmay Inamdar wrote: > >> +static void xgene_pcie_fixup_bridge(struct pci_dev *dev) >> +{ >> + int i; >> + >> + /* Hide the PCI host BARs from the kernel as their con

Re: [RFC PATCH V3 0/4] APM X-Gene PCIe controller

2014-01-29 Thread Tanmay Inamdar
On Wed, Jan 29, 2014 at 4:18 PM, Bjorn Helgaas wrote: > On Sat, Jan 25, 2014 at 9:09 AM, Dann Frazier > wrote: >> On Fri, Jan 24, 2014 at 2:32 PM, Tanmay Inamdar wrote: >>> This patch adds support for AppliedMicro X-Gene PCIe host controller. The >>> driver is

Re: [RFC PATCH V2 1/4] pci: APM X-Gene PCIe controller driver

2014-01-27 Thread Tanmay Inamdar
if this fixes the problem. Again.. sorry for spamming. > On Sat, Jan 25, 2014 at 1:11 PM, Arnd Bergmann wrote: >> On Friday 24 January 2014 13:28:22 Tanmay Inamdar wrote: >>> On Thu, Jan 16, 2014 at 5:10 PM, Tanmay Inamdar wrote: >>> > On Wed, Jan 15, 2014 at 4:

Re: [RFC PATCH V3 0/4] APM X-Gene PCIe controller

2014-01-27 Thread Tanmay Inamdar
On Sat, Jan 25, 2014 at 8:09 AM, Dann Frazier wrote: > On Fri, Jan 24, 2014 at 2:32 PM, Tanmay Inamdar wrote: >> This patch adds support for AppliedMicro X-Gene PCIe host controller. The >> driver is tested on X-Gene platform with different gen1/2/3 PCIe endpoint >> car

Re: [RFC PATCH V2 1/4] pci: APM X-Gene PCIe controller driver

2014-01-27 Thread Tanmay Inamdar
On Sat, Jan 25, 2014 at 12:11 PM, Arnd Bergmann wrote: > On Friday 24 January 2014 13:28:22 Tanmay Inamdar wrote: >> On Thu, Jan 16, 2014 at 5:10 PM, Tanmay Inamdar wrote: >> > On Wed, Jan 15, 2014 at 4:39 AM, Arnd Bergmann wrote: >> >> On Wednesday 15 Janu

[RFC PATCH V3 4/4] MAINTAINERS: entry for APM X-Gene PCIe host driver

2014-01-24 Thread Tanmay Inamdar
Add entry for AppliedMicro X-Gene PCIe host driver. Signed-off-by: Tanmay Inamdar --- MAINTAINERS |7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5c21402..721fec7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6539,6 +6539,13 @@ L: linux

[RFC PATCH V3 3/4] dt-bindings: pci: xgene pcie device tree bindings

2014-01-24 Thread Tanmay Inamdar
This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pci-xgene.c' file. Signed-off-by: Tanmay Inamdar --- .../devicetree/bindings/pci/xgene-pci.txt | 52 1 file changed, 52 insertions(+) create mode 100644 Doc

[RFC PATCH V3 1/4] pci: APM X-Gene PCIe controller driver

2014-01-24 Thread Tanmay Inamdar
This patch adds the AppliedMicro X-Gene SOC PCIe controller driver. X-Gene PCIe controller supports maximum upto 8 lanes and GEN3 speed. X-Gene has maximum 5 PCIe ports supported. Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig | 10 + drivers/pci/host/Makefile|1

[RFC PATCH V3 2/4] arm64: dts: APM X-Gene PCIe device tree nodes

2014-01-24 Thread Tanmay Inamdar
This patch adds the device tree nodes for APM X-Gene PCIe controller and PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes are added. Signed-off-by: Tanmay Inamdar --- arch/arm64/boot/dts/apm-mustang.dts |8 ++ arch/arm64/boot/dts/apm-storm.dtsi | 155

[RFC PATCH V3 0/4] APM X-Gene PCIe controller

2014-01-24 Thread Tanmay Inamdar
e.c' 7. dropped 'clock-names' property from bindings 8. added comments whereever requested. Tanmay Inamdar (4): pci: APM X-Gene PCIe controller driver arm64: dts: APM X-Gene PCIe device tree nodes dt-bindings: pci: xgene pcie device tree bindings MAINTAINERS: entry for A

Re: [RFC PATCH V2 1/4] pci: APM X-Gene PCIe controller driver

2014-01-24 Thread Tanmay Inamdar
On Thu, Jan 16, 2014 at 5:10 PM, Tanmay Inamdar wrote: > On Wed, Jan 15, 2014 at 4:39 AM, Arnd Bergmann wrote: >> On Wednesday 15 January 2014, Tanmay Inamdar wrote: >>> This patch adds the AppliedMicro X-Gene SOC PCIe controller driver. >>> X-Gene PCIe controller s

Re: [RFC PATCH V2 3/4] dt-bindings: pci: xgene pcie device tree bindings

2014-01-16 Thread Tanmay Inamdar
On Wed, Jan 15, 2014 at 1:57 AM, Arnd Bergmann wrote: > On Wednesday 15 January 2014, Tanmay Inamdar wrote: >> This patch adds the bindings for X-Gene PCIe driver. The driver resides >> under 'drivers/pci/host/pci-xgene.c' file. >> >> Signed-off-by: Tanm

Re: [RFC PATCH V2 1/4] pci: APM X-Gene PCIe controller driver

2014-01-16 Thread Tanmay Inamdar
On Wed, Jan 15, 2014 at 4:39 AM, Arnd Bergmann wrote: > On Wednesday 15 January 2014, Tanmay Inamdar wrote: >> This patch adds the AppliedMicro X-Gene SOC PCIe controller driver. >> X-Gene PCIe controller supports maxmum upto 8 lanes and GEN3 speed. >> X-Gene has maximum 5

[RFC PATCH V2 4/4] MAINTAINERS: entry for APM X-Gene PCIe host driver

2014-01-14 Thread Tanmay Inamdar
Add entry for AppliedMicro X-Gene PCIe host driver. Signed-off-by: Tanmay Inamdar --- MAINTAINERS |7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6c20792..9e3ed53 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6531,6 +6531,13 @@ L: linux

[RFC PATCH V2 2/4] arm64:dts: APM X-Gene PCIe device tree nodes

2014-01-14 Thread Tanmay Inamdar
This patch adds the device tree nodes for APM X-Gene PCIe controller and PCIe clock interface. Since X-Gene SOC supports maximum 5 ports, 5 dts nodes are added. Signed-off-by: Tanmay Inamdar --- arch/arm64/boot/dts/apm-mustang.dts |4 + arch/arm64/boot/dts/apm-storm.dtsi | 144

[RFC PATCH V2 3/4] dt-bindings: pci: xgene pcie device tree bindings

2014-01-14 Thread Tanmay Inamdar
This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pci-xgene.c' file. Signed-off-by: Tanmay Inamdar --- .../devicetree/bindings/pci/xgene-pcie.txt | 45 1 file changed, 45 insertions(+) create mode 100644 Doc

[RFC PATCH V2 1/4] pci: APM X-Gene PCIe controller driver

2014-01-14 Thread Tanmay Inamdar
This patch adds the AppliedMicro X-Gene SOC PCIe controller driver. X-Gene PCIe controller supports maxmum upto 8 lanes and GEN3 speed. X-Gene has maximum 5 PCIe ports supported. Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig | 10 + drivers/pci/host/Makefile|1

[RFC PATCH V2 0/4] APM X-Gene PCIe controller

2014-01-14 Thread Tanmay Inamdar
t driver file to 'pci-xgene.c' from 'pcie-xgene.c' 7. dropped 'clock-names' property from bindings 8. added comments whereever requested. Tanmay Inamdar (4): pci: APM X-Gene PCIe controller driver arm64:dts: APM X-Gene PCIe device tree nodes dt-bindings: pci: xg

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-10 Thread Tanmay Inamdar
On Tue, Jan 7, 2014 at 7:35 AM, Arnd Bergmann wrote: > On Tuesday 07 January 2014, Tanmay Inamdar wrote: >> On Fri, Jan 3, 2014 at 1:49 AM, Arnd Bergmann wrote: >> >> +Required properties: >> >> +- status: Either "ok" or "disabled". >>

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-09 Thread Tanmay Inamdar
On Tue, Jan 7, 2014 at 10:31 AM, Jason Gunthorpe wrote: > On Tue, Jan 07, 2014 at 04:35:01PM +0100, Arnd Bergmann wrote: > >> > >> + 0x 0x0 0xd000 0xe0 0xd000 0x0 >> > >> 0x0020 /* cfg */ >> > > >> > > config space is not normally in the ranges property,

Re: [RFC PATCH 2/3] arm64: dts: APM X-Gene PCIe device tree nodes

2014-01-09 Thread Tanmay Inamdar
On Tue, Jan 7, 2014 at 9:27 AM, Jason Gunthorpe wrote: > On Mon, Jan 06, 2014 at 06:56:21PM -0800, Tanmay Inamdar wrote: > >> > There is some kind of an addressing problem because you've done this: >> > >> > +static void xgene_pcie_fixup_bridge(struct pc

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-09 Thread Tanmay Inamdar
On Tue, Jan 7, 2014 at 1:27 AM, Arnd Bergmann wrote: > On Tuesday 07 January 2014, Tanmay Inamdar wrote: >> > Also, the implementation is wrong since the I/O port range already needs >> > to be ioremapped in order for inb/outb to work. There is already a >> > gen

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-06 Thread Tanmay Inamdar
On Fri, Jan 3, 2014 at 1:49 AM, Arnd Bergmann wrote: > On Monday 23 December 2013, Tanmay Inamdar wrote: >> This patch adds the bindings for X-Gene PCIe driver. The driver resides >> under 'drivers/pci/host/pcie-xgene.c' file. >> >> Signed-off-by: Tanm

Re: [RFC PATCH 2/3] arm64: dts: APM X-Gene PCIe device tree nodes

2014-01-06 Thread Tanmay Inamdar
On Thu, Jan 2, 2014 at 4:52 PM, Jason Gunthorpe wrote: > On Thu, Jan 02, 2014 at 01:56:51PM -0800, Tanmay Inamdar wrote: >> On Mon, Dec 23, 2013 at 9:46 AM, Jason Gunthorpe >> wrote: >> > On Mon, Dec 23, 2013 at 01:32:03PM +0530, Tanmay Inamdar wrote: >> >> T

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-06 Thread Tanmay Inamdar
On Sun, Jan 5, 2014 at 5:47 PM, Jingoo Han wrote: > On Monday, December 23, 2013 5:02 PM, Tanmay Inamdar wrote: >> >> This patch adds the AppliedMicro X-gene SOC PCIe controller driver. >> APM X-Gene PCIe controller supports maximum upto 8 lanes and >> GEN3 speed. X-Ge

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-06 Thread Tanmay Inamdar
Thanks for your comments. Please see some inline replies. On Fri, Jan 3, 2014 at 4:07 AM, Arnd Bergmann wrote: > On Monday 23 December 2013, Tanmay Inamdar wrote: >> This patch adds the AppliedMicro X-gene SOC PCIe controller driver. >> APM X-Gene PCIe controller supports maxim

  1   2   >