he performance of boot up.
With the combination of these 3 new trace events and
mm_filemap_add_to_page_cache, we observed a reduction in the pack file
by 7.3% - 20% on ChromeOS varying by device.
Signed-off-by: Takaya Saeki
Reviewed-by: Masami Hiramatsu (Google)
Reviewed-by: Steven Rostedt (Google)
he performance of boot up.
With the combination of these 3 new trace events and
mm_filemap_add_to_page_cache, we observed a reduction in the pack file
by 7.3% - 20% on ChromeOS varying by device.
Signed-off-by: Takaya Saeki
Reviewed-by: Masami Hiramatsu (Google)
Reviewed-by: Steven Rostedt (Google)
Oh yes. That sounds like a good idea. Let me update the patch with it.
Thanks,
Takaya Saeki
Hello Matthew, I'd appreciate it if you could comment on this.
Thank you.
Hello all, and thank you so much for the review, Steven and Masami.
I'm currently considering replacing the `max_ofs` output with
`length`. Please let me know your thoughts.
With the current design, a memory range of an event is an inclusive
range of [ofs, max_ofs + 4096]. I found the `+4096` part
he performance of boot up.
With the combination of these 3 new trace events and
mm_filemap_add_to_page_cache, we observed a reduction in the pack file
by 7.3% - 20% on ChromeOS varying by device.
Signed-off-by: Takaya Saeki
---
Changelog between v2 and v1
- Fix a file offset type usage by casting
Thank you Matthew for taking a look at this!
I fix both points and send a V2 patch.
> This needs to be cast to an loff_t before shifting.
I found that this applies to add_to_page_cache and delete_from_page_cache, too.
I could fix them too, but I didn't since it will change the max value
of those
Thanks Steven for trying it out.
> I can see it bringing down the number of pages needed to be saved
> dramatically.
Yes, I agree.
However, note that wc does not count the size of the page caches
correctly since 'get_map_pages' gives you a range. In your example of
the less command, actually the
he performance of boot up.
With the combination of these 3 new trace events and
mm_filemap_add_to_page_cache, we observed a reduction in the pack file
by 7.3% - 20% on ChromeOS varying by device.
Signed-off-by: Takaya Saeki
---
include/trace/events/filemap.h | 84 +++
9 matches
Mail list logo
