Hello Andy,
> Von: Andy Shevchenko
> Gesendet: Freitag, 19. Februar 2021 14:56
> An: Sven Schuchmann
> Cc: Pavel Machek ; Dan Murphy ;
> linux-l...@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Betreff: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default
Hello Pavel, hello Andy,
> -Ursprüngliche Nachricht-
> Von: Pavel Machek
> Gesendet: Freitag, 19. Februar 2021 12:17
> An: Sven Schuchmann
> Cc: Dan Murphy ; linux-l...@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Betreff: Re: [PATCH v2 2/4] leds: lp50xx: a
Hello Dan,
> Von: Jacek Anaszewski
> Gesendet: Freitag, 5. Februar 2021 19:37
> Hi Pavel,
>
> On 2/5/21 11:23 AM, Pavel Machek wrote:
> > Hi!
> >
> patternProperties:
> "(^led-[0-9a-f]$|led)":
> @@ -99,6 +104,7 @@ examples:
> reg = <0x1>;
>
Hello Pavel, hello Dan,
> > diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> > b/Documentation/devicetree/bindings/leds/leds-
> lp50xx.yaml
> > index c192b5feadc7..2bc25b2fc94d 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> > +++ b/Documentation/d
Hello Pavel,
> > > > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
> > > > index f13117eed976..4b40bf66483c 100644
> > > > --- a/drivers/leds/leds-lp50xx.c
> > > > +++ b/drivers/leds/leds-lp50xx.c
> > > > @@ -267,7 +267,6 @@ struct lp50xx_led {
> > > > struct led_cl
Hello Pavel,
>
> > Signed-off-by: Sven Schuchmann
>
> Check your email headers, empty To: is strange.
>
> > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
> > index 79bc071c31fb..e8aa36c7e963 100644
> > --- a/drivers/leds/leds-lp50xx.c
Hello Pavel,
> > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
> > index f13117eed976..4b40bf66483c 100644
> > --- a/drivers/leds/leds-lp50xx.c
> > +++ b/drivers/leds/leds-lp50xx.c
> > @@ -267,7 +267,6 @@ struct lp50xx_led {
> > struct led_classdev_mc mc_cdev;
> > st
errors
changes in v2
- sets default intensity to full
- adds the property to the multi-led node
Signed-off-by: Sven Schuchmann
---
drivers/leds/leds-lp50xx.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
index
errors
changes in v2
- sets default intensity to full
- adds the property to the multi-led node
Signed-off-by: Sven Schuchmann
---
drivers/leds/leds-lp50xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
index 4b40bf66483c
errors
changes in v2
- sets default intensity to full
- adds the property to the multi-led node
Signed-off-by: Sven Schuchmann
---
Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/leds
errors
changes in v2
- sets default intensity to full
- adds the property to the multi-led node
Signed-off-by: Sven Schuchmann
---
drivers/leds/leds-lp50xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
index f13117eed976
Helo Pavel,
> > > Yes, sounds reasonable. Could we get default intensity of 100% on all
> > > channels if nothing else is specified?
> > >
> > > Or maybe simply "if intensity is not specified, start with 100%, and
> > > use explicit =0 if other color is expected".
> > >
> > Mh, if someone is alrea
Hello Pavel, hello Marek
> > Is the property default-intensity documented in DT bindings?
I updated the documentation in leds-lp50xx.yaml. Is it this what you mean?
> > Wouldn't it be better if the property was used in the multi-led node
> > instead of the channel node? I.e.
> > multi-led@3 {
Hello Pavel,
>
> Yes, sounds reasonable. Could we get default intensity of 100% on all
> channels if nothing else is specified?
>
> Or maybe simply "if intensity is not specified, start with 100%, and
> use explicit =0 if other color is expected".
>
Mh, if someone is already using the led drive
Hello Dan, hello Pavel,
> > Do you have set up where this is needed and you can test this? Will
> > you submit the fixes?
>
> No I use an always on regulator in my setup. I have no managed supplies
> exposed.
I am also sorry I do not have a setup ready for testing this.
I think we should ignore t
Hello Pavel,
> > In order to use a multicolor-led together with a trigger
> > from DT the led needs to have an intensity set to see something.
> > The trigger changes the brightness of the led but if there
> > is no intensity we actually see nothing.
> >
> > This patch adds the ability to set the
The regulator for vled-supply is unused in the driver.
It is just assigned from DT and disabled in lp50xx_remove.
So the code can be removed from the driver.
Part 1 updates the documentation
Part 2 removes the code
Signed-off-by: Sven Schuchmann
---
drivers/leds/leds-lp50xx.c | 14
The regulator for vled-supply is unused in the driver.
It is just assigned from DT and disabled in lp50xx_remove.
So the code can be removed from the driver.
Part 1 updates the documentation
Part 2 removes the code
Signed-off-by: Sven Schuchmann
---
Documentation/devicetree/bindings/leds/leds
Hi,
sorry to ask but was someone able to look at this? Any thoughts?
Best Regards,
Sven
> -Ursprüngliche Nachricht-
> Von: Sven Schuchmann
> Gesendet: Dienstag, 19. Januar 2021 11:53
> An: Sven Schuchmann
> Cc: Pavel Machek ; Dan Murphy ; Rob Herring
that it is turned on from DT.
Signed-off-by: Sven Schuchmann
---
Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++-
drivers/leds/leds-lp50xx.c | 4
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings
turned on from DT.
Signed-off-by: Sven Schuchmann
---
Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 6 +-
drivers/leds/leds-lp50xx.c | 4
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/leds/leds
21 matches
Mail list logo
