Hi,
On 12/08/2020 20:50, Linus Torvalds wrote:
On Wed, Aug 12, 2020 at 12:34 PM Steven Whitehouse wrote:
The point of this is to give us the ability to monitor mounts from
userspace.
We haven't had that before, I don't see why it's suddenly such a big deal.
The noti
Hi,
On 12/08/2020 19:18, Linus Torvalds wrote:
On Tue, Aug 11, 2020 at 5:05 PM David Howells wrote:
Well, the start of it was my proposal of an fsinfo() system call.
Ugh. Ok, it's that thing.
This all seems *WAY* over-designed - both your fsinfo and Miklos' version.
What's wrong with fstatf
Hi,
On 12/08/2020 09:37, Miklos Szeredi wrote:
[snip]
b) The awarded performance boost is not warranted for the use cases it
is designed for.
Thanks,
Miklos
This is a key point. One of the main drivers for this work is the
efficiency improvement for large numbers of mounts. Ian and Karel h
Hi,
On 05/09/2019 18:19, Linus Torvalds wrote:
On Thu, Sep 5, 2019 at 10:01 AM David Howells wrote:
I'm just going to be very blunt about this, and say that there is no
way I can merge any of this *ever*, unless other people stand up and
say that
(a) they'll use it
and
(b) they'll activ
Hi,
On 31/10/18 15:38, Eric W. Biederman wrote:
Al Viro writes:
mount API series from David Howells. Last cycle's objections
had been of the "I'd do it differently" variety and with no such
differently done variants having ever materialized over several
cycles...
Absolutely not.
M
Hi,
On 31/10/18 16:18, Linus Torvalds wrote:
On Tue, Oct 30, 2018 at 10:34 PM Al Viro wrote:
mount API series from David Howells. Last cycle's objections
had been of the "I'd do it differently" variety and with no such
differently done variants having ever materialized over several
Hi,
On 24/04/18 17:27, Michal Hocko wrote:
Hi,
it seems that we still have few vmalloc users who perform GFP_NOFS
allocation:
drivers/mtd/ubi/io.c
fs/ext4/xattr.c
fs/gfs2/dir.c
fs/gfs2/quota.c
fs/nfs/blocklayout/extent_tree.c
fs/ubifs/debug.c
fs/ubifs/lprops.c
fs/ubifs/lpt_commit.c
fs/ubifs/orp
Hi,
On 05/04/18 14:34, Greg KH wrote:
On Thu, Apr 05, 2018 at 10:00:04AM +0100, Steven Whitehouse wrote:
Hi,
On 05/04/18 09:52, Dmitry Vyukov wrote:
On Thu, Apr 5, 2018 at 10:36 AM, Steven Whitehouse wrote:
Hi,
On 05/04/18 09:19, Dmitry Vyukov wrote:
On Thu, Apr 5, 2018 at 8:34 AM
Hi,
On 05/04/18 09:52, Dmitry Vyukov wrote:
On Thu, Apr 5, 2018 at 10:36 AM, Steven Whitehouse wrote:
Hi,
On 05/04/18 09:19, Dmitry Vyukov wrote:
On Thu, Apr 5, 2018 at 8:34 AM, Greg KH
wrote:
On Wed, Apr 04, 2018 at 07:02:01PM -0700, syzbot wrote:
Hello,
syzbot hit the following
Hi,
On 05/04/18 09:19, Dmitry Vyukov wrote:
On Thu, Apr 5, 2018 at 8:34 AM, Greg KH wrote:
On Wed, Apr 04, 2018 at 07:02:01PM -0700, syzbot wrote:
Hello,
syzbot hit the following crash on upstream commit
3e968c9f1401088abc9a19ae6ff571644d37a355 (Wed Apr 4 21:19:24 2018 +)
Merge tag 'ext
Hi,
On 04/04/18 13:36, Jan Kara wrote:
Hi,
On Wed 04-04-18 10:24:48, Steven Whitehouse wrote:
On 03/04/18 13:05, Jan Kara wrote:
Hello,
On Sun 01-04-18 10:01:02, syzbot wrote:
syzbot hit the following crash on upstream commit
10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00
Hi,
On 03/04/18 13:05, Jan Kara wrote:
Hello,
On Sun 01-04-18 10:01:02, syzbot wrote:
syzbot hit the following crash on upstream commit
10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +)
Merge branch 'perf-urgent-for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/g
Hi,
Can we solve the problem another way, by not taking refs on the glocks
when we are iterating over them for the debugfs files? I assume that is
the main issue here.
We didn't used to take refs since the rcu locking was enough during the
walk itself. We used to only keep track of the hash
Hi,
On 02/02/18 04:18, Daniel Jordan wrote:
On 02/01/2018 10:54 AM, Steven Whitehouse wrote:
Hi,
On 31/01/18 23:04, daniel.m.jor...@oracle.com wrote:
lru_lock, a per-node* spinlock that protects an LRU list, is one of the
hottest locks in the kernel. On some workloads on large machines
Hi,
On 31/01/18 23:04, daniel.m.jor...@oracle.com wrote:
lru_lock, a per-node* spinlock that protects an LRU list, is one of the
hottest locks in the kernel. On some workloads on large machines, it
shows up at the top of lock_stat.
One way to improve lru_lock scalability is to introduce an ar
On 16/01/18 20:51, Stephen Rothwell wrote:
Hi all,
Commit
7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use")
is missing a Signed-off-by from its author.
Bob, can you add that?
Steve.
Hi,
On 17/09/17 17:38, Al Viro wrote:
On Sun, Sep 17, 2017 at 09:34:01AM -0700, Linus Torvalds wrote:
Now, I suspect most (all?) do, but that's a historical artifact rather
than "design". In particular, the VFS layer used to do the locking for
the filesystems, to guarantee the POSIX requiremen
Hi,
On 31/07/17 13:22, Jeff Layton wrote:
On Mon, 2017-07-31 at 13:05 +0100, Steven Whitehouse wrote:
Hi,
On 31/07/17 12:44, Jeff Layton wrote:
On Mon, 2017-07-31 at 12:32 +0100, Steven Whitehouse wrote:
Hi,
On 31/07/17 12:27, Jeff Layton wrote:
On Thu, 2017-07-27 at 08:48 -0400, Jeff
Hi,
On 31/07/17 12:44, Jeff Layton wrote:
On Mon, 2017-07-31 at 12:32 +0100, Steven Whitehouse wrote:
Hi,
On 31/07/17 12:27, Jeff Layton wrote:
On Thu, 2017-07-27 at 08:48 -0400, Jeff Layton wrote:
On Thu, 2017-07-27 at 10:49 +0200, Jan Kara wrote:
On Wed 26-07-17 13:55:36, Jeff Layton
Hi,
On 31/07/17 12:27, Jeff Layton wrote:
On Thu, 2017-07-27 at 08:48 -0400, Jeff Layton wrote:
On Thu, 2017-07-27 at 10:49 +0200, Jan Kara wrote:
On Wed 26-07-17 13:55:36, Jeff Layton wrote:
+int file_write_and_wait(struct file *file)
+{
+ int err = 0, err2;
+ struct address_spa
Hi,
On 28/07/17 13:47, Jeff Layton wrote:
On Fri, 2017-07-28 at 13:37 +0100, Steven Whitehouse wrote:
Hi,
On 27/07/17 13:47, Bob Peterson wrote:
- Original Message -
On Wed, 2017-07-26 at 12:21 -0700, Matthew Wilcox wrote:
On Wed, Jul 26, 2017 at 01:55:38PM -0400, Jeff Layton
Hi,
On 27/07/17 13:47, Bob Peterson wrote:
- Original Message -
| On Wed, 2017-07-26 at 12:21 -0700, Matthew Wilcox wrote:
| > On Wed, Jul 26, 2017 at 01:55:38PM -0400, Jeff Layton wrote:
| > > @@ -668,12 +668,14 @@ static int gfs2_fsync(struct file *file, loff_t
| > > start, loff_t end
Hi,
On 05/05/17 11:09, Sowmini Varadhan wrote:
On (05/05/17 10:45), Steven Whitehouse wrote:
I do wonder if the man page for recvmsg is wrong, or at least a bit
confusing. SOCK_SEQPACKET is stream based not message based - it just
happens to have EOR markers in the stream. There is no reason
Hi,
On 05/05/17 06:18, Sam Kumar wrote:
Hello,
I have recently had occasion to use SOCK_SEQPACKET sockets on Linux,
and noticed some odd behavior. When using sendmsg and recvmsg with
these sockets, it seems that the "end-of-record" flag (MSG_EOR) is not
being propagated correctly.
It depends wh
Hi,
On 28/06/16 03:08, Dave Chinner wrote:
On Fri, Jun 24, 2016 at 02:50:11PM -0500, Bob Peterson wrote:
This patch adds a new prune_icache_sb function for the VFS slab
shrinker to call. Trying to directly free the inodes from memory
might deadlock because it evicts inodes, which calls into DLM
Hi,
I think the idea looks good. A couple of comments below though...
On 24/06/16 20:50, Bob Peterson wrote:
This patch adds a new prune_icache_sb function for the VFS slab
shrinker to call. Trying to directly free the inodes from memory
might deadlock because it evicts inodes, which calls into
Hi,
On 29/04/16 06:35, NeilBrown wrote:
On Tue, Apr 26 2016, Michal Hocko wrote:
Hi,
we have discussed this topic at LSF/MM this year. There was a general
interest in the scope GFP_NOFS allocation context among some FS
developers. For those who are not aware of the discussion or the issue
I am
Hi,
On 06/07/15 18:21, Ming Lin wrote:
On Mon, Jul 6, 2015 at 3:58 AM, Steven Whitehouse wrote:
Hi,
On 06/07/15 08:44, Ming Lin wrote:
From: Kent Overstreet
We can always fill up the bio now, no need to estimate the possible
size based on queue parameters.
[snip]
diff --git a/fs/gfs2
Hi,
On 06/07/15 08:44, Ming Lin wrote:
From: Kent Overstreet
We can always fill up the bio now, no need to estimate the possible
size based on queue parameters.
[snip]
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index 2c1ae86..64d3116 100644
--- a/fs/gfs2/lops.c
+++ b/fs/gfs2/lops.c
@@ -26
way.
Acked-by: Steven Whitehouse
Steve.
---
fs/gfs2/sys.c | 56
1 file changed, 44 insertions(+), 12 deletions(-)
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c
index ae8e881..436bdeb 100644
--- a/fs/gfs2/sys.c
+++ b/fs/gfs2/sys.c
@@ -101
Hi,
On 20/04/15 16:40, Randy Dunlap wrote:
On 04/19/15 22:45, Stephen Rothwell wrote:
Hi all,
Please do not add any v4.2 material to your linux-next included trees
until after v4.1-rc1 is released.
Changes since 20150415:
on i386:
ERROR: "__divdi3" [fs/gfs2/gfs2.ko] undefined!
These n
Hi,
On 15/04/15 00:16, Linus Torvalds wrote:
On Tue, Apr 14, 2015 at 10:47 AM, Bob Peterson wrote:
There's another that adds me as a GFS2 co-maintainer [...]
So generally, when I start getting pull requests from different
people, I'd like to see a previous separate heads-up or confirmation
fr
Hi,
On 04/04/15 20:13, Dmitry Monakhov wrote:
Cc: cluster-de...@redhat.com
Signed-off-by: Dmitry Monakhov
Acked-by: Steven Whitehouse
Steve.
---
fs/gfs2/file.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index f6fc412
reasonable to me:
Acked-by: Steven Whitehouse
Steve.
Signed-off-by: Chengyu Song
---
fs/gfs2/glock.c | 47 ---
1 file changed, 28 insertions(+), 19 deletions(-)
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index f42dffb..0fa8062 100644
--- a/fs/gfs2
Hi,
On 18/02/15 09:13, Jan Kara wrote:
On Wed 18-02-15 10:34:55, Alexey Dobriyan wrote:
On Mon, Feb 16, 2015 at 10:38:52AM +0100, Jan Kara wrote:
On Sat 14-02-15 21:55:24, Alexey Dobriyan wrote:
Freezing and thawing are separate system calls, task which is supposed
to thaw filesystem/superblo
Hi,
Please consider pulling the following changes,
Steve.
--
This time we have mostly clean ups. There is a bug fix for a NULL dereference
relating to ACLs, and another which improves (but does not fix entirely) an
all
From: alex chen
Sprintf format specifier "%d" and "%u" are mixed up in
gfs2_recovery_done() and freeze_show(). So correct them.
Signed-off-by: Alex Chen
Reviewed-by: Joseph Qi
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
index 573
From: Oleg Drokin
leaf_dealloc uses vzalloc as a fallback to kzalloc(GFP_NOFS), so
it clearly does not want any shrinker activity within the fs itself.
convert vzalloc into __vmalloc(GFP_NOFS|__GFP_ZERO) to better achieve
this goal.
Signed-off-by: Oleg Drokin
Signed-off-by: Steven Whitehouse
From: Bob Peterson
Since the only caller of function __gfs2_glock_remove_from_lru locks the
same spin_lock as gfs2_glock_remove_from_lru, the functions can be combined.
Signed-off-by: Bob Peterson
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index a23524a
From: Bob Peterson
This patch just removes a goto that did nothing.
Signed-off-by: Bob Peterson
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 9054002..73c72253 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -543,10 +543,7 @@ static int
This time we have mostly clean ups. There is a bug fix for a NULL dereference
relating to ACLs, and another which improves (but does not fix entirely) an
allocation fall-back code path. The other three patches are small clean ups.
Steve.
--
To unsubscribe from this list: send the line "unsubscrib
From: Andrew Elble
Fixes: e01580bf9e ("gfs2: use generic posix ACL infrastructure")
Reported-by: Eric Meddaugh
Tested-by: Eric Meddaugh
Signed-off-by: Andrew Elble
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c
index 3088e2a..7b31430 100644
--- a/fs/
Hi,
On 04/02/15 07:13, Oleg Drokin wrote:
Hello!
On Feb 3, 2015, at 5:33 PM, Dave Chinner wrote:
I also wonder if vmalloc is still very slow? That was the case some
time ago when I noticed a problem in directory access times in gfs2,
which made us change to use kmalloc with a vmalloc fallback
Hi,
On 02/02/15 08:11, Dave Chinner wrote:
On Mon, Feb 02, 2015 at 01:57:23AM -0500, Oleg Drokin wrote:
Hello!
On Feb 2, 2015, at 12:37 AM, Dave Chinner wrote:
On Sun, Feb 01, 2015 at 10:59:54PM -0500, gr...@linuxhacker.ru wrote:
From: Oleg Drokin
leaf_dealloc uses vzalloc as a fallback t
Hi,
Please consider pulling the following changes,
Steve.
--
The following changes since commit 0df1f2487d2f0d04703f142813d53615d62a1da4:
Linux 3.18-rc3 (2014-11-02 15:01:51 -0800)
are available in the git repos
Hi,
All five patches now in the GFS2 -nmw tree. Thanks,
Steve.
On 20/11/14 05:19, Al Viro wrote:
vfree() is allowed under spinlock these days, but it's cheaper when
it doesn't step into deferred case and here it's very easy to avoid.
Signed-off-by: Al Viro
---
fs/gfs2/dir.c |7 ---
Hi,
Now in the GFS2 -nmw git tree. Thanks,
Steve.
On 18/11/14 10:35, SF Markus Elfring wrote:
From: Markus Elfring
Date: Tue, 18 Nov 2014 11:31:23 +0100
The functions iput() and put_pid() test whether their argument is NULL
and then return immediately. Thus the test around the call is not ne
gfs2 also used generic_write_sync to implement a crude version
of fallocate. It has been switched to use an open coded variant
instead.
Signed-off-by: Christoph Hellwig
GFS2 bits:
Acked-by: Steven Whitehouse
I know that Andy Price has some work in this area too, so in due course
w
Hi,
On 09/10/14 21:49, Fabian Frederick wrote:
No need to store gfs2_dir_check result and test it before returning.
Signed-off-by: Fabian Frederick
Since I've already sent a pull request for this merge window, and this
is not urgent, I'll keep this one and use it to start off the new tree
in
Hi,
Please consider pulling the following changes,
Steve.
-
The following changes since commit 37504a3be90b69438426d74ccf467a9fe192932b:
Merge tag 'gfs2-fixes' of
git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-
From: Fabian Frederick
use macro definition
Signed-off-by: Fabian Frederick
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 7f513b1..8f0c19d 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -811,7 +811,7 @@ void gfs2_holder_init(struct gfs2_glock
ion is not
saved and the buffer_head is released as per previous behavior.
Signed-off-by: Bob Peterson
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index 1a349f9..5d4261f 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -2100,8 +2100,13 @@ int gfs2_diradd_alloc_r
he ip->i_no_addr
field is invalid and so, the fix in gfs2_inplace_reserve() as per
1) won't work in this scenario. We need to catch and fix it sooner
in the parent dir itself (gfs2_create_inode()), before it is
copied to the new inode.
Signed-off-by: Abhi Das
Signed-off-by: Steven Whitehous
Hi,
Not a huge amount this time... just four patches. This time we have a couple
of bug fixes, one relating to bad i_goal values which are now ignored (i_goal
is basically a hint so it is safe to so this) and another relating to the
saving of the dirent location during rename. There is one perform
From: Bob Peterson
This patch speeds up GFS2 unlink operations by using function
gfs2_rbm_incr rather than continuously calculating the rbm.
Signed-off-by: Bob Peterson
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 55ef72d..7474c41 100644
--- a/fs/gfs2
Hi,
Apologies for taking so long - I've added this into the -nmw tree now.
Thanks,
Steve.
On 03/10/14 19:15, Fabian Frederick wrote:
use macro definition
Signed-off-by: Fabian Frederick
---
fs/gfs2/glock.c | 4 ++--
fs/gfs2/glops.c | 2 +-
fs/gfs2/trans.c | 2 +-
3 files changed, 4 in
Hi,
Please consider pulling the following fixes for GFS2,
Steve.
The following changes since commit 372b1dbdd1fb5697890b937228d93cfd9c734c90:
Merge branch 'for-linus' of git://git.samba.org/sfrench/cifs-2.6 (2014
ff-by: Jan Kara
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index 67d310c..39e7e99 100644
--- a/fs/gfs2/incore.h
+++ b/fs/gfs2/incore.h
@@ -262,6 +262,9 @@ struct gfs2_holder {
unsigned long gh_ip;
};
+/* Number of quota types we support */
+#d
ned-off-by: Steven Whitehouse
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 9317ddc..fc8ac2e 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -626,8 +626,10 @@ static int gfs2_create_inode(struct inode *dir, struct
dentry *dentry,
if (!IS_ERR(inode)) {
d = d_sp
From: Bob Peterson
This patch changes some variables (especially maxlen in function
gfs2_block_map) from unsigned int to size_t. We need 64-bit arithmetic
for very large files (e.g. 1PB) where the variables otherwise get
shifted to all 0's.
Signed-off-by: Bob Peterson
Signed-off-by: S
From: Benjamin Coddington
Fix a regression introduced by:
6d4ade986f9c8df31e68 GFS2: Add atomic_open support
where an early return misses d_splice_alias() which had been
adding the negative dentry.
Signed-off-by: Benjamin Coddington
Signed-off-by: Bob Peterson
Signed-off-by: Steven Whitehouse
me for the
demote to occur. Then it tries again, for an increasing amount of time.
Subsequent attempts to gain the "try" lock don't use "_1CB" so that
only one callback is issued.
Signed-off-by: Bob Peterson
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/file.c b/fs
From: Fabian Frederick
fix checkpatch warnings:
"WARNING: Prefer seq_puts to seq_printf"
Cc: cluster-de...@redhat.com
Signed-off-by: Fabian Frederick
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index 2607ff1..a346f56 100644
--- a/fs/gfs2/super.
Hi,
Here are a number of small fixes for GFS2. There is a fix for FIEMAP
on large sparse files, a negative dentry hashing fix, a fix for
flock, and a bug fix relating to d_splice_alias usage. There are
also (patches 1 and 5) a couple of updates which are less
critical, but small and low risk.
Ste
become more widely used.
Signed-off-by: Rob Jones
Acked-by: Steven Whitehouse
Steve.
---
Documentation/filesystems/seq_file.txt | 33
1 file changed, 33 insertions(+)
diff --git a/Documentation/filesystems/seq_file.txt
b/Documentation/filesystems
Hi,
On 07/08/14 15:16, Rob Jones wrote:
On 07/08/14 15:09, Rob Jones wrote:
Hi Steve,
On 07/08/14 14:32, Steven Whitehouse wrote:
Hi,
On 07/08/14 13:58, Rob Jones wrote:
[snip]
On a related subject, Having looked at a few uses of seq_file, I must
say that some users seem to make
Hi,
On 07/08/14 13:58, Rob Jones wrote:
[snip]
On a related subject, Having looked at a few uses of seq_file, I must
say that some users seem to make assumptions about the internal
workings of the module. Dangerous behaviour as only some behaviours are
documented.
e.g. The behaviour that "stru
Hi,
On 28/07/14 22:19, Andreas Dilger wrote:
On Jul 28, 2014, at 6:52 AM, Abhijith Das wrote:
OnJuly 26, 2014 12:27:19 AM "Andreas Dilger" wrote:
Is there a time when this doesn't get called to prefetch entries in
readdir() order? It isn't clear to me what benefit there is of returning
the
Hi,
On 25/07/14 19:28, Zach Brown wrote:
On Fri, Jul 25, 2014 at 07:08:12PM +0100, Steven Whitehouse wrote:
Hi,
On 25/07/14 18:52, Zach Brown wrote:
[snip]
Hmm. Have you tried plumbing these read-ahead calls in under the normal
getdents() syscalls?
We don't have a filereadahead() sy
Hi,
On 25/07/14 18:52, Zach Brown wrote:
On Fri, Jul 25, 2014 at 01:37:19PM -0400, Abhijith Das wrote:
Hi all,
The topic of a readdirplus-like syscall had come up for discussion at last
year's
LSF/MM collab summit. I wrote a couple of syscalls with their GFS2
implementations
to get at a dire
Spelling s/invlidate/invalidate/
Steven Whitehouse (2):
GFS2: Fix race in glock lru glock disposal
GFS2: Use GFP_NOFS when allocating glocks
fs/gfs2/file.c | 4 ++--
fs/gfs2/glock.c| 14 +-
fs/gfs2/glops.c| 4 ++--
fs/gfs2/lock_dlm.c | 4 ++--
fs/gfs2/rgrp.
Hi,
Here are the current set of small fixes relating to GFS2.
This patch set contains two minor docs/spelling fixes, some fixes for
flock, a change to use GFP_NOFS to avoid recursion on a rarely used code
path and a fix for a race relating to the glock lru,
Steve.
--
To unsubscribe from this li
problem is especially apparent when dealing with nested flocks.
Signed-off-by: Bob Peterson
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index c355f73..278fae5 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -1128,7 +1128,9 @@ void gfs2_glock_dq_wait
From: Fabian Frederick
kcalloc manages count*sizeof overflow.
Cc: cluster-de...@redhat.com
Signed-off-by: Fabian Frederick
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c
index 91f274d..4fafea1 100644
--- a/fs/gfs2/lock_dlm.c
+++ b/fs/gfs2/lock_dlm.c
so
that it is no longer called while another glock is held, but that
doesn't look at all easy, so GFP_NOFS is the best solution for the
time being.
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index c1e5b12..b703dcc 100644
--- a/fs/gfs2/glock.c
+++ b/fs
, especially
in cases where the flocks are held in Shared (SH) mode.
Signed-off-by: Bob Peterson
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 491e8e0..26b3f95 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -981,7 +981,7 @@ static int do_flock(struct file
safer.
Signed-off-by: Bob Peterson
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 4fc3a30..491e8e0 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -991,7 +991,7 @@ static int do_flock(struct file *file, int cmd, struct
file_loc
From: Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven
Cc: cluster-de...@redhat.com
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c
index fc11007..2ffc67d 100644
--- a/fs/gfs2/glops.c
+++ b/fs/gfs2/glops.c
@@ -234,8 +234,8 @@ static void inode_go_sync
From: Fabian Frederick
Cc: cluster-de...@redhat.com
Signed-off-by: Fabian Frederick
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index db629d1..f4cb9c0 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -337,7 +337,7 @@ static bool gfs2_unaligned_extlen
every
iteration.
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 278fae5..c1e5b12 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -1406,12 +1406,16 @@ __acquires(&lru_lock)
gl = list_entry(list->next, struct gfs2_g
Hi,
This and the seq_puts patch are now both in the -nmw tree. Thanks,
Steve.
On 02/07/14 21:05, Fabian Frederick wrote:
Cc: Steven Whitehouse
Cc: cluster-de...@redhat.com
Signed-off-by: Fabian Frederick
---
fs/gfs2/rgrp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Hi,
Now in the -nmw tree. Thanks,
Steve.
On 29/06/14 11:21, Geert Uytterhoeven wrote:
Signed-off-by: Geert Uytterhoeven
Cc: Steven Whitehouse
Cc: cluster-de...@redhat.com
---
fs/gfs2/glops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/glops.c b/fs/gfs2
Hi,
Now in the -nmw git tree. Thanks,
Steve.
On 25/06/14 19:40, Fabian Frederick wrote:
kcalloc manages count*sizeof overflow.
Cc: Steven Whitehouse
Cc: cluster-de...@redhat.com
Signed-off-by: Fabian Frederick
---
fs/gfs2/lock_dlm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
(I hoped to submit this in the rc1 -> rc2 window, but that happened
while I was on leave...)
Thanks,
NeilBrown
Acked-by: Steven Whitehouse
Steve.
---
NeilBrown (2):
SCHED: remove proliferation of wait_on_bit action functions.
SCHED: allow wait_on_bit_action functions to supp
Hi,
Please consider pulling the following changes,
Steve.
-
The following changes since commit 6ca2a88ad820af56535ed1e6936e0490cb6ec6dc:
Merge branch 'x86-urgent-for-linus' of
git://git.kernel.org/pub/scm/linux/kerne
Hi,
This must be about the smallest merge window patch set ever for GFS2.
It is probably also the first one without a single patch from me. That
is down to a combination of factors, and I have some things in the works
that are not quite ready yet, that I hope to put in next time around.
Returning
From: Fabian Frederick
Fix 2 typos and move one definition which was between function
comments and function definition (yet another kernel-doc warning)
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
index
From: Bob Peterson
This patch uses a completion to prevent dlm's recovery process from
referencing and trying to recover a journal before a journal has been
opened.
Signed-off-by: Bob Peterson
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index 24
ck in order to allow the unfreeze ioctl to be issued now use the lock
grabbed by the freeze code instead.
The freeze and unfreeze code take care to make sure that this shared
lock will not be dropped while another process is using it.
Signed-off-by: Benjamin Marzinski
Signed-off-by: Steven White
From: Fabian Frederick
Sparse warning: fs/gfs2/lops.c:78:29:
"warning: Using plain integer as NULL pointer"
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index a294d8d..2c1ae86 100644
--- a/fs/g
From: Abhi Das
Old values of user quota limits were being used and
could allow users to exceed their allotted quotas.
This patch refreshes the limits to the latest values
so that quotas are enforced correctly.
Resolves: rhbz#1077463
Signed-off-by: Abhi Das
Signed-off-by: Steven Whitehouse
From: Fabian Frederick
Related function is not gfs2_set_flags but do_gfs2_set_flags
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 6065252..6ab0cfb 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
struct inode_time in gfs2.
Signed-off-by: Arnd Bergmann
Cc: Steven Whitehouse
Cc: cluster-de...@redhat.com
---
fs/gfs2/dir.c | 6 +++---
fs/gfs2/glops.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
Subject to deciding the internal representation of struct inode_time,
this looks
Hi,
I've added this patch, plus the one you sent yesterday to the GFS2 -nmw
tree. Thanks,
Steve.
On 15/05/14 17:57, Fabian Frederick wrote:
Related function is not gfs2_set_flags but do_gfs2_set_flags
Cc: Steven Whitehouse
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
---
fs
Hi,
On 26/04/14 19:57, Fabian Frederick wrote:
Sparse warning: fs/gfs2/lops.c:78:29:
"warning: Using plain integer as NULL pointer"
Cc: Steven Whitehouse
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
---
fs/gfs2/lops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
Hi,
On Fri, 2014-04-04 at 14:52 -0700, Linus Torvalds wrote:
> On Tue, Apr 1, 2014 at 4:15 PM, Steven Whitehouse wrote:
> >
> > Please consider pulling the following changes
>
> This pull request is also missing shortlog and diffstat, like Jeff
> Layton's did. Did
Hi,
On Wed, 2014-04-02 at 04:10 -0700, Christoph Hellwig wrote:
> On Tue, Apr 01, 2014 at 02:25:45PM -0400, Richard Hansen wrote:
> > For the flags parameter, POSIX says "Either MS_ASYNC or MS_SYNC shall
> > be specified, but not both." [1] There was already a test for the
> > "both" condition.
Hi,
Please consider pulling the following changes,
Steve.
--
The following changes since commit 1b2ad41214c9bf6e8befa000f0522629194bf540:
GFS2: Fix address space from page function (2014-03-31 17:48:27 +0100)
are av
rable improvement.
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index 9dcb977..1e1bda0 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -18,6 +18,7 @@
#include
#include
#include
+#include
#include
#include
@@ -145,8 +146,10 @@ void gfs2_ail1_flush(struct gfs
he
most common cases.
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 5c52418..ec455b9 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -376,12 +376,11 @@ static void munge_mode_uid_gid(const struct gfs2_inode
*dip,
inode-&g
1 - 100 of 685 matches
Mail list logo
