Re: Is read barrier missed in kfifo?

2018-05-11 Thread Stefani Seibold
My guts thinks you are right. Feel free to send a patch... Am Freitag, den 11.05.2018, 15:25 +0800 schrieb Xiao Guangrong: > Hi, > > Currently, there is no read barrier between reading the index > (kfifo.in) and fetching the real data from the fifo. > > I am afraid that will cause the vfifo is o

Re: [PATCH v3 26/26] kfifo: DECLARE_KIFO_PTR(fifo, u64) does not work on arm 32 bit

2017-11-30 Thread Stefani Seibold
ght structure. > > > > Signed-off-by: Sean Young > > Acked-by: Stefani Seibold > > Hi Stefani/Andrew, > > As this patch is required for the LIRC rework, would be ok if I would > merge it via the media tree? > It is okay by me. But the question remains why this p

Re: [PATCH] external references for device tree overlays

2017-06-07 Thread Stefani Seibold
On Wed, 2017-06-07 at 17:19 -0500, Rob Herring wrote: > On Wed, Jun 7, 2017 at 3:11 AM, Pantelis Antoniou > wrote: > > Hi Stefani, > > > > On Tue, 2017-06-06 at 21:17 +0200, Stefani Seibold wrote: > > > Hi Pantelis, > > > > > > thank

Re: [PATCH] external references for device tree overlays

2017-06-07 Thread Stefani Seibold
Hi Pantelis, On Wed, 2017-06-07 at 11:11 +0300, Pantelis Antoniou wrote: > Hi Stefani, > > On Tue, 2017-06-06 at 21:17 +0200, Stefani Seibold wrote: > > Hi Pantelis, > > > > thanks for the suggestion. This feature is not very well > > documented. I > > tr

Re: [PATCH] external references for device tree overlays

2017-06-06 Thread Stefani Seibold
vices. Hope this helps to understand the reason for this patch. - Stefani Am Montag, den 05.06.2017, 21:43 +0300 schrieb Pantelis Antoniou: > Hi Stefani, > > On Mon, 2017-06-05 at 14:59 +0200, Stefani Seibold wrote: > > From: Stefani Seibold > > > > This p

Re: [PATCH] external references for device tree overlays

2017-06-06 Thread Stefani Seibold
Hi Frank, On 06.06.2017, 00:20 -0700 Frank Rowand wrote:: > On 06/05/17 05:59, Stefani Seibold wrote: > > From: Stefani Seibold > > > > This patch enables external references for symbols which are not > > exported by the current device tree. For example > >

[PATCH] external references for device tree overlays

2017-06-05 Thread Stefani Seibold
From: Stefani Seibold This patch enables external references for symbols which are not exported by the current device tree. For example // RASPI example (only for testing) /dts-v1/; /plugin/; / { compatible = "brcm,bcm2835", "brcm,bcm2708", "brcm,bcm2709";

OHCI unplug kernel crash in kernel 4.3, 4.4 and 4.5

2016-02-28 Thread Stefani Seibold
I still reported this bug 6 Weeks ago... and i checked it know with the current kernel 4.5.0-rc5. The bug is yet not fixed. A unplug of an USB 1.0 OHCI controller express card will result in a kernel crash. The express card is attached via thunderbolt and a sonnet express card to thunderbolt adapt

[PATCH] kfifo: fix sparse complains

2016-02-21 Thread Stefani Seibold
: Stefani Seibold --- include/linux/kfifo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h index 473b436..41eb6fd 100644 --- a/include/linux/kfifo.h +++ b/include/linux/kfifo.h @@ -401,7 +401,7 @@ __kfifo_int_must_check_helper

Re: [PATCH] samples: Fix `echo 1 > /proc/int-fifo` never return error

2015-02-04 Thread Stefani Seibold
The example is intended for int types, not for strings. So it is not a bug, it's a feature ;-) But anyway, if you prefer to handle with strings your are okay by me. Am Dienstag, den 03.02.2015, 11:51 + schrieb Wang Long: > echo 99 > /proc/int-fifo > Never return > echo 1000 >

Re: X86: Impossible select Enhanced Real Time Clock Support (legacy PC RTC driver)

2014-05-02 Thread Stefani Seibold
On Mon, 2014-04-28 at 20:20 +0200, Alessandro Zummo wrote: > On Mon, 28 Apr 2014 11:16:37 -0700 > John Stultz wrote: > > > >> This breaks the API since there is no more misc device /dev/rtc > > >> available without a udev rule or a link to /dev/rtc0. > > > > So yea.. I feel like that /dev/rtcN

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-15 Thread Stefani Seibold
Am Dienstag, den 15.04.2014, 15:14 -0400 schrieb Alan Stern: > On Tue, 15 Apr 2014, Stefani Seibold wrote: > > > > > usbcore: registered new interface driver USB-SATA-storage > > > > USB SATA Mass Storage support registered. > > > > usb 1-4: new hig

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-15 Thread Stefani Seibold
Am Dienstag, den 15.04.2014, 15:02 -0400 schrieb Alan Stern: > On Tue, 15 Apr 2014, Stefani Seibold wrote: > > > I did a unbind and bind of the ehci-pci and ohci-pci, after this i got > > the following dmesg log: > > > > ehci_hcd: USB 2.0 'Enhanced' Ho

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-15 Thread Stefani Seibold
Am Dienstag, den 15.04.2014, 15:05 -0400 schrieb Alan Stern: > On Tue, 15 Apr 2014, Stefani Seibold wrote: > > > > One other thing you can try is to increase the reset timeout in > > > drivers/usb/host/ehci-hub.c. This is under the USB_PORT_FEAT_RESET > > > c

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-15 Thread Stefani Seibold
Am Dienstag, den 15.04.2014, 15:02 -0400 schrieb Alan Stern: > On Tue, 15 Apr 2014, Stefani Seibold wrote: > > > I did a unbind and bind of the ehci-pci and ohci-pci, after this i got > > the following dmesg log: > > > > ehci_hcd: USB 2.0 'Enhanced' Ho

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-15 Thread Stefani Seibold
Am Dienstag, den 15.04.2014, 15:49 -0300 schrieb Thadeu Lima de Souza Cascardo: > On Tue, Apr 15, 2014 at 08:42:58PM +0200, Stefani Seibold wrote: > > Am Dienstag, den 15.04.2014, 15:33 -0300 schrieb Thadeu Lima de Souza > > Cascardo: > > > On Tue, Apr 15, 2014 a

Re: X86: kexec issues with i915 in 3.14

2014-04-15 Thread Stefani Seibold
On Tuesday, 15.04.2014, 16:54 +0800 wrote Jiang Liu: > Hi Stefanin, > As David has mentioned, the warning messages indicates the VGA > controller hasn't been shut down correctly during reboot and keeps doing > DMA write operations after loading the new kernel. Do you have found > any older ke

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-15 Thread Stefani Seibold
Am Dienstag, den 15.04.2014, 15:33 -0300 schrieb Thadeu Lima de Souza Cascardo: > On Tue, Apr 15, 2014 at 05:00:28PM +0200, stef...@seibold.net wrote: > > > > Zitat von Thadeu Lima de Souza Cascardo : > > > > >On Tue, Apr 15, 2014 at 12:04:17PM +0200, stef...@seibold.net wrote: > > >> > > >>Zitat

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-15 Thread Stefani Seibold
Am Montag, den 14.04.2014, 13:58 -0400 schrieb Alan Stern: > On Mon, 14 Apr 2014, Stefani Seibold wrote: > > > > > An other PowerPC device which is nearly eactly the same HW but without > > > > this USB HUB works perfectly. > > > > > > Maybe yo

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-15 Thread Stefani Seibold
Am Montag, den 14.04.2014, 12:27 -0400 schrieb Alan Stern: > On Mon, 14 Apr 2014 stef...@seibold.net wrote: > > > Zitat von Alan Stern : > > > > > > >> <6>[ 167.936921] usb 2-2.1: new full-speed USB device number 3 > > >> using ohci-pci > > >> <6>[ 168.067890] usb 2-2.1: New USB device foun

Re: X86: kexec issues with i915 in 3.14

2014-04-14 Thread Stefani Seibold
Am Montag, den 14.04.2014, 00:28 + schrieb Woodhouse, David: > On Sun, 2014-04-13 at 22:01 +0200, Stefani Seibold wrote: > > Rebooting my kernel vanilla kernel 3.14 will fail with tons of kernel > > log messages: > > > > [0.262754] IOMMU: Setting identity

Re: EHCI hotplug kernel crash in kernel 3.14 and 3.13

2014-04-14 Thread Stefani Seibold
me. Thanks, Greetings, Stefani Am Montag, den 14.04.2014, 11:11 -0400 schrieb Alan Stern: > On Sun, 13 Apr 2014, Stefani Seibold wrote: > > > A hot plug of an USB 2.0 EHCI controller cardbus card will result in a > > kernel crash. This is the kernel log of a vanilla 3.1

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-14 Thread Stefani Seibold
Am Montag, den 14.04.2014, 12:27 -0400 schrieb Alan Stern: > On Mon, 14 Apr 2014 stef...@seibold.net wrote: > > > Zitat von Alan Stern : > > > > > > >> <6>[ 167.936921] usb 2-2.1: new full-speed USB device number 3 > > >> using ohci-pci > > >> <6>[ 168.067890] usb 2-2.1: New USB device found

X86: kexec issues with i915 in 3.14

2014-04-13 Thread Stefani Seibold
Rebooting my kernel vanilla kernel 3.14 will fail with tons of kernel log messages: [0.262754] IOMMU: Setting identity map for device :00:1a.0 [0x7c45f000 - 0x7c46bfff] [0.262780] IOMMU: Setting identity map for device :00:14.0 [0x7c45f000 - 0x7c46bfff] [0.262798] IOMMU: Prep

Missing USB XHCI and EHCI reset for kexec

2014-04-13 Thread Stefani Seibold
When executing a kexec kernel on a PowerPC board the new started kernel will not find already enumerated USB devices due a missing reset on the USB bus. As a work around a echo 1 >/sys/bus/pci/drivers/[ex]hci-pci/BUS-ADDRESS-OF-THE-HCD/reset will solve this. But this is far from beauty. My late

X86: Impossible select Enhanced Real Time Clock Support (legacy PC RTC driver)

2014-04-13 Thread Stefani Seibold
Since some kernel version it is impossible to select the Enhanced Real Time Clock Support (legacy PC RTC driver) because RTC_LIB is set by default in arch/x86/Kconfig, but the rule for selecting CONFIG_RTC is RTC_LIB=n. So the code of driver/char/rtc is still useless. This breaks the API since the

EHCI hotplug kernel crash in kernel 3.14 and 3.13

2014-04-13 Thread Stefani Seibold
A hot plug of an USB 2.0 EHCI controller cardbus card will result in a kernel crash. This is the kernel log of a vanilla 3.14 x86_64 kernel. I will attach my kernel config. [ 70.418181] pcmcia_socket pcmcia_socket0: pccard: CardBus card inserted into slot 0 [ 70.418209] pci :04:00.0: [103

Re: [PATCH] x86: Fix the symbol versions on the 32-bit vDSO

2014-03-30 Thread Stefani Seibold
4 11:33:37 PM PDT, Stefani Seibold > wrote: > >Am Samstag, den 29.03.2014, 13:15 -0700 schrieb Andy Lutomirski: > >> The new symbols provide the same API as the 64-bit variants, so they > >> should have the same symbol version name. This can't break > >&g

Re: [PATCH] x86: Fix the symbol versions on the 32-bit vDSO

2014-03-29 Thread Stefani Seibold
Am Samstag, den 29.03.2014, 13:15 -0700 schrieb Andy Lutomirski: > The new symbols provide the same API as the 64-bit variants, so they > should have the same symbol version name. This can't break > userspace, since these symbols are new for 32-bit Linux. > This breaks my glibc patch... What is

[tip:x86/vdso] x86, vdso: Fix size of get_unmapped_area()

2014-03-24 Thread tip-bot for Stefani Seibold
Commit-ID: 645a387ecbdb4aa78c8451a66416340616134537 Gitweb: http://git.kernel.org/tip/645a387ecbdb4aa78c8451a66416340616134537 Author: Stefani Seibold AuthorDate: Sun, 23 Mar 2014 17:38:14 +0100 Committer: H. Peter Anvin CommitDate: Mon, 24 Mar 2014 09:31:23 -0700 x86, vdso: Fix size

[PATCH] x86, vdso: fix size of get_unmapped_area()

2014-03-23 Thread Stefani Seibold
: Stefani Seibold --- arch/x86/vdso/vdso32-setup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/vdso/vdso32-setup.c b/arch/x86/vdso/vdso32-setup.c index 791c1cb..0034898 100644 --- a/arch/x86/vdso/vdso32-setup.c +++ b/arch/x86/vdso/vdso32-setup.c @@ -165,12 +165,14

Re: [x86,vdso32] kernel BUG at mm/swap.c:134!

2014-03-23 Thread Stefani Seibold
g/pub/scm/linux/kernel/git/tip/tip.git x86/vdso > > commit 4e40112c4ff6a577dd06d92b2a54cdf06265bf74 > Author: Stefani Seibold > AuthorDate: Mon Mar 17 23:22:13 2014 +0100 > Commit: H. Peter Anvin > CommitDate: Tue Mar 18 12:52:54 2014 -0700 > > x86, vds

[PATCH v2] x86, vdso32: fix out of memory handling setup vDSO

2014-03-20 Thread Stefani Seibold
This patch add a correct out of memory handling for setup a 32 bit vDSO. The patch is against tip commit 4e40112c4ff6a577dd06d92b2a54cdf06265bf74 Signed-off-by: Stefani Seibold --- arch/x86/vdso/vdso32-setup.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff

Re: [PATCH] x86, vdso32: fix out of memory handling setup vDSO

2014-03-20 Thread Stefani Seibold
Am Donnerstag, den 20.03.2014, 10:53 +0100 schrieb Thomas Gleixner: > On Thu, 20 Mar 2014, Stefani Seibold wrote: > > > This patch add a correct out of memory handling for setup a 32 bit vDSO. > > > > The patch is against tip commit 4e40112c4ff6a577dd06d92b2a54cdf06265bf7

[PATCH] x86, vdso32: fix out of memory handling setup vDSO

2014-03-20 Thread Stefani Seibold
This patch add a correct out of memory handling for setup a 32 bit vDSO. The patch is against tip commit 4e40112c4ff6a577dd06d92b2a54cdf06265bf74 Signed-off-by: Stefani Seibold --- arch/x86/vdso/vdso32-setup.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git

[tip:x86/vdso] x86, vdso: __vdso_clock_gettime() cleanup

2014-03-18 Thread tip-bot for Stefani Seibold
Commit-ID: ce39c64028a075d14af32bfb8336bfe1370c0443 Gitweb: http://git.kernel.org/tip/ce39c64028a075d14af32bfb8336bfe1370c0443 Author: Stefani Seibold AuthorDate: Mon, 17 Mar 2014 23:22:04 +0100 Committer: H. Peter Anvin CommitDate: Tue, 18 Mar 2014 12:52:01 -0700 x86, vdso

[tip:x86/vdso] x86, vdso: Introduce VVAR marco for vdso32

2014-03-18 Thread tip-bot for Stefani Seibold
Commit-ID: ef721987aef0cc0abba08c88810f2155f76b0b1f Gitweb: http://git.kernel.org/tip/ef721987aef0cc0abba08c88810f2155f76b0b1f Author: Stefani Seibold AuthorDate: Mon, 17 Mar 2014 23:22:07 +0100 Committer: H. Peter Anvin CommitDate: Tue, 18 Mar 2014 12:52:29 -0700 x86, vdso: Introduce

[tip:x86/vdso] x86, vdso: Add 32 bit VDSO time support for 64 bit kernel

2014-03-18 Thread tip-bot for Stefani Seibold
Commit-ID: 7c03156f34d113f885f045d8fb8cc3efd9e64751 Gitweb: http://git.kernel.org/tip/7c03156f34d113f885f045d8fb8cc3efd9e64751 Author: Stefani Seibold AuthorDate: Mon, 17 Mar 2014 23:22:10 +0100 Committer: H. Peter Anvin CommitDate: Tue, 18 Mar 2014 12:52:41 -0700 x86, vdso: Add 32

[tip:x86/vdso] x86, vdso: Make vsyscall_gtod_data handling x86 generic

2014-03-18 Thread tip-bot for Stefani Seibold
Commit-ID: d2312e3379d581d2c3603357a0181046448e1de3 Gitweb: http://git.kernel.org/tip/d2312e3379d581d2c3603357a0181046448e1de3 Author: Stefani Seibold AuthorDate: Mon, 17 Mar 2014 23:22:01 +0100 Committer: H. Peter Anvin CommitDate: Tue, 18 Mar 2014 12:51:52 -0700 x86, vdso: Make

[tip:x86/vdso] x86, vdso: Cleanup __vdso_gettimeofday()

2014-03-18 Thread tip-bot for Stefani Seibold
Commit-ID: 0df1ea2b7955d3cb311a549c44ed482452b859ff Gitweb: http://git.kernel.org/tip/0df1ea2b7955d3cb311a549c44ed482452b859ff Author: Stefani Seibold AuthorDate: Mon, 17 Mar 2014 23:22:06 +0100 Committer: H. Peter Anvin CommitDate: Tue, 18 Mar 2014 12:52:26 -0700 x86, vdso: Cleanup

[tip:x86/vdso] x86, vdso: Revamp vclock_gettime.c

2014-03-18 Thread tip-bot for Stefani Seibold
Commit-ID: 411f790cd7e91fac0db80d3cf789cb6deeac298e Gitweb: http://git.kernel.org/tip/411f790cd7e91fac0db80d3cf789cb6deeac298e Author: Stefani Seibold AuthorDate: Mon, 17 Mar 2014 23:22:03 +0100 Committer: H. Peter Anvin CommitDate: Tue, 18 Mar 2014 12:51:59 -0700 x86, vdso: Revamp

[tip:x86/vdso] x86, vdso32: handle 32 bit vDSO larger one page

2014-03-18 Thread tip-bot for Stefani Seibold
Commit-ID: 4e40112c4ff6a577dd06d92b2a54cdf06265bf74 Gitweb: http://git.kernel.org/tip/4e40112c4ff6a577dd06d92b2a54cdf06265bf74 Author: Stefani Seibold AuthorDate: Mon, 17 Mar 2014 23:22:13 +0100 Committer: H. Peter Anvin CommitDate: Tue, 18 Mar 2014 12:52:54 -0700 x86, vdso32: handle

[tip:x86/vdso] x86, vdso: Add 32 bit VDSO time support for 32 bit kernel

2014-03-18 Thread tip-bot for Stefani Seibold
Commit-ID: 7a59ed415f5b57469e22e41fc4188d5399e0b194 Gitweb: http://git.kernel.org/tip/7a59ed415f5b57469e22e41fc4188d5399e0b194 Author: Stefani Seibold AuthorDate: Mon, 17 Mar 2014 23:22:09 +0100 Committer: H. Peter Anvin CommitDate: Tue, 18 Mar 2014 12:52:37 -0700 x86, vdso: Add 32

[tip:x86/vdso] mm: Add new func _install_special_mapping() to mmap.c

2014-03-18 Thread tip-bot for Stefani Seibold
Commit-ID: 3935ed6a3a533c1736e3ca65bff72afd1773be27 Gitweb: http://git.kernel.org/tip/3935ed6a3a533c1736e3ca65bff72afd1773be27 Author: Stefani Seibold AuthorDate: Mon, 17 Mar 2014 23:22:02 +0100 Committer: H. Peter Anvin CommitDate: Tue, 18 Mar 2014 12:51:56 -0700 mm: Add new func

[tip:x86/vdso] x86, vdso: Replace VVAR(vsyscall_gtod_data) by gtod macro

2014-03-18 Thread tip-bot for Stefani Seibold
Commit-ID: af8c93d8d9809c3cf71cae2c398069399e64efa3 Gitweb: http://git.kernel.org/tip/af8c93d8d9809c3cf71cae2c398069399e64efa3 Author: Stefani Seibold AuthorDate: Mon, 17 Mar 2014 23:22:05 +0100 Committer: H. Peter Anvin CommitDate: Tue, 18 Mar 2014 12:52:03 -0700 x86, vdso: Replace

[PATCH v23 10/13] x86, vdso: Add 32 bit VDSO time support for 64 bit kernel

2014-03-17 Thread Stefani Seibold
32- and 64-bit access - The inner struct clock was removed to pack the whole struct. The "unsigned seq" would be handled by functions derivated from seqcount_t. Signed-off-by: Stefani Seibold --- arch/x86/include/asm/vgtod.h | 71 +-- arch/x86/include/

[PATCH v23 12/13] x86, vdso32: Disable stack protector, adjust optimizations

2014-03-17 Thread Stefani Seibold
From: "H. Peter Anvin" For the 32-bit VDSO, match the 64-bit VDSO in: 1. Disable the stack protector. 2. Use -fno-omit-frame-pointer for user space debugging sanity. 3. Use -foptimize-sibling-calls like the 64-bit VDSO does. Reported-by: Ingo Molnar Signed-off-by: Stefani Seibold

[PATCH v23 11/13] x86, vdso: Zero-pad the VVAR page

2014-03-17 Thread Stefani Seibold
of memory that is exposed to userspace. Signed-off-by: Stefani Seibold --- arch/x86/kernel/vmlinux.lds.S | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S index 1d4897b..49edf2d 100644 --- a/arch/x86/kernel/vmlinux.lds.S +++

[PATCH v23 13/13] x86, vdso32: handle 32 bit vDSO larger one page

2014-03-17 Thread Stefani Seibold
This patch enables 32 bit vDSO which are larger than a page. Signed-off-by: Stefani Seibold --- arch/x86/vdso/vdso32-setup.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/arch/x86/vdso/vdso32-setup.c b/arch/x86/vdso/vdso32-setup.c index e10abdf

[PATCH v23 01/13] x86, vdso: Make vsyscall_gtod_data handling x86 generic

2014-03-17 Thread Stefani Seibold
This patch move the vsyscall_gtod_data handling out of vsyscall_64.c into an additonal file vsyscall_gtod.c to make the functionality available for x86 32 bit kernel. It also adds a new vsyscall_32.c which setup the VVAR page. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold

[PATCH v23 03/13] x86, vdso: Revamp vclock_gettime.c

2014-03-17 Thread Stefani Seibold
This intermediate patch revamps the vclock_gettime.c by moving some functions around. It is only for spliting purpose, to make whole the 32 bit vdso timer patch easier to review. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- arch/x86/vdso/vclock_gettime.c | 85

[PATCH v23 04/13] x86, vdso: __vdso_clock_gettime() cleanup

2014-03-17 Thread Stefani Seibold
This patch is a small code cleanup for the __vdso_clock_gettime() function. It removes the unneeded return values from do_monotonic_coarse() and do_realtime_coarse() and add a fallback label for doing the kernel gettimeofday() system call. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani

[PATCH v23 09/13] x86, vdso: Add 32 bit VDSO time support for 32 bit kernel

2014-03-17 Thread Stefani Seibold
This patch add the time support for 32 bit a VDSO to a 32 bit kernel. For 32 bit programs running on a 32 bit kernel, the same mechanism is used as for 64 bit programs running on a 64 bit kernel. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- arch/x86/include/asm/vdso.h

[PATCH v23 08/13] x86, vdso: Patch alternatives in the 32-bit VDSO

2014-03-17 Thread Stefani Seibold
From: Andy Lutomirski We need the alternatives mechanism for rdtsc_barrier() to work. Signed-off-by: Stefani Seibold --- arch/x86/include/asm/vdso.h | 2 ++ arch/x86/vdso/Makefile | 3 ++- arch/x86/vdso/vdso32-setup.c | 23 --- arch/x86/vdso/vma.c | 13

[PATCH v23 05/13] x86, vdso: Replace VVAR(vsyscall_gtod_data) by gtod macro

2014-03-17 Thread Stefani Seibold
There a currently more than 30 users of the gtod macro, so replace the last VVAR(vsyscall_gtod_data) by gtod macro. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- arch/x86/vdso/vclock_gettime.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86

[PATCH v23 07/13] x86, vdso: Introduce VVAR marco for vdso32

2014-03-17 Thread Stefani Seibold
This patch revamps the vvar.h for introduce the VVAR macro for vdso32. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- arch/x86/include/asm/vvar.h | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/vvar.h b/arch/x86/include

[PATCH v23 00/13] x86: Add x86 32 bit VDSO time function support

2014-03-17 Thread Stefani Seibold
This patch add the functions vdso_gettimeofday(), vdso_clock_gettime() and vdso_time() to the x86 32 bit VDSO. The reason to do this was to get a fast reliable time stamp. Many developers uses TSC to get a fast time stamp, without knowing the pitfalls. VDSO time functions a fast and a reliable way

[PATCH v23 06/13] x86, vdso: Cleanup __vdso_gettimeofday()

2014-03-17 Thread Stefani Seibold
This patch do a little cleanup for the __vdso_gettimeofday() function. It kicks out an unneeded ret local variable and makes the code faster if only the timezone is needed (an admittedly rare case.) Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- arch/x86/vdso/vclock_gettime.c

[PATCH v23 02/13] mm: Add new func _install_special_mapping() to mmap.c

2014-03-17 Thread Stefani Seibold
bit address space. This will be done with io_remap_pfn_range() and remap_pfn_range, which requieres a vm_area_struct. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- include/linux/mm.h | 3 +++ mm/mmap.c | 20 2 files changed, 19 insertions(+), 4

Re: [PATCH 0/3] Improve 32 bit vDSO time

2014-03-13 Thread Stefani Seibold
Am Donnerstag, den 13.03.2014, 15:08 -0700 schrieb H. Peter Anvin: > On 03/13/2014 01:11 AM, Stefani Seibold wrote: > > Am Mittwoch, den 12.03.2014, 20:48 -0700 schrieb H. Peter Anvin: > >> On 03/12/2014 04:11 PM, stef...@seibold.net wrote: > >>> > >>> I w

Re: [PATCH 0/3] Improve 32 bit vDSO time

2014-03-13 Thread Stefani Seibold
Am Mittwoch, den 12.03.2014, 20:48 -0700 schrieb H. Peter Anvin: > On 03/12/2014 04:11 PM, stef...@seibold.net wrote: > > > > I will do this when your patch is pulled into tip. For now we have the > > choice, but i preferer our solution removing the compat vdso. > > > > Sorry, that didn't parse

[PATCH 1/3] x86, vdso32: undef CONFIG_OPTIMIZE_INLINING and CONFIG_X86_PPRO_FENCE

2014-03-12 Thread Stefani Seibold
In case of a 32 bit vDSO build the CONFIG_OPTIMIZE_INLINING and CONFIG_X86_PPRO_FENCE options will increase the size of the generated vDSO not to fit in a page. A #undef of this config options will solve this. Signed-off-by: Stefani Seibold --- arch/x86/vdso/vdso32/vclock_gettime.c | 6

[PATCH 2/3] x86, vdso32: remove vsyscall_32.c

2014-03-12 Thread Stefani Seibold
vsyscall_32.c has not much code in it and the only function map_vsyscall() was invoked prior to vdso_setup() which results in wrong conditional mapping of VVAR_PAGE. Moving the whole fixmap initialization into map_compat_vdso() will solve this calling dependences. Signed-off-by: Stefani Seibold

[PATCH 0/3] Improve 32 bit vDSO time

2014-03-12 Thread Stefani Seibold
This patch bring some improvments to the vDSO 32 bit: - undef some kernel configs which increase the code size of the VDSO - remove vsyscall and prevent wrong conditional VVAR_PAGE mapping - handle VDSO larger than a page The patch set is agains tip 7ed5ee279499a02bf35c77f0a91d657c24f6474e -- To

[PATCH 3/3] x86, vdso32: handle 32 bit vDSO larger one page

2014-03-12 Thread Stefani Seibold
This patch enables 32 bit vDSO which are larger than a page. Currently two pages are reserved, this should be enough for future improvements. Signed-off-by: Stefani Seibold --- arch/x86/include/asm/fixmap.h | 4 +++- arch/x86/vdso/vdso32-setup.c | 29 +++-- 2 files

Re: [PATCH v2] x86: Remove compat vdso support

2014-03-12 Thread Stefani Seibold
Am Dienstag, den 11.03.2014, 10:09 -0700 schrieb Linus Torvalds: > On Tue, Mar 11, 2014 at 9:50 AM, Andy Lutomirski wrote: > > Looking forward, would it be reasonable to have an extensible set of > > flags that live in the ELF interpreter's headers somewhere > > No. Not reasonable. The whole "32-

Re: [x86, vdso] BUG: unable to handle kernel paging request at d34bd000

2014-03-10 Thread Stefani Seibold
Am Montag, den 10.03.2014, 10:12 -0700 schrieb Andy Lutomirski: > On Mon, Mar 10, 2014 at 8:11 AM, Linus Torvalds > wrote: > > > > On Mar 10, 2014 8:01 AM, "H. Peter Anvin" wrote: > >> > >> I have mentioned in the past wanting to move the fixmap to the low part > >> of the kernel space, because t

Re: [x86, vdso] BUG: unable to handle kernel paging request at d34bd000

2014-03-09 Thread Stefani Seibold
Am Freitag, den 07.03.2014, 15:07 -0800 schrieb Andy Lutomirski: > On Fri, Mar 7, 2014 at 1:53 PM, Stefani Seibold wrote: > > > > Am Freitag, den 07.03.2014, 10:56 -0800 schrieb Andy Lutomirski: > >> On Thu, Mar 6, 2014 at 11:21 PM, Stefani Seibold > &g

Re: [x86, vdso] BUG: unable to handle kernel paging request at d34bd000

2014-03-09 Thread Stefani Seibold
Am Samstag, den 08.03.2014, 07:44 +0800 schrieb Fengguang Wu: > Hi Stefani, > > > So i tried my best, but without support it is impossible to find all > > issues. But mostly what i get was bureaucracy afflictions > > > > I complied, but now it is time to help finding the issues. And not only > >

Re: [x86, vdso] BUG: unable to handle kernel paging request at d34bd000

2014-03-07 Thread Stefani Seibold
Am Freitag, den 07.03.2014, 10:56 -0800 schrieb Andy Lutomirski: > On Thu, Mar 6, 2014 at 11:21 PM, Stefani Seibold wrote: > > Hi Fengguang, > > > > i have build a kernel with the config, but my kvm is unable to start it. > > I will try to find a way to test your kerne

Re: [x86, vdso] BUG: unable to handle kernel paging request at d34bd000

2014-03-07 Thread Stefani Seibold
Am Freitag, den 07.03.2014, 18:21 +0800 schrieb Fengguang Wu: > Hi Stefani, > > On Fri, Mar 07, 2014 at 10:57:28AM +0100, Stefani Seibold wrote: > > Hi Fengguang, > > > > did you test the config i had sent to you? > > > > My test was all done with curren

Re: [x86, vdso] BUG: unable to handle kernel paging request at d34bd000

2014-03-07 Thread Stefani Seibold
ite i cannot pay the invoice). Also i get no support by people who ask me to do this work. I am really pissed of. - Stefani Am Freitag, den 07.03.2014, 17:15 +0800 schrieb Fengguang Wu: > Hi Stefani, > > On Fri, Mar 07, 2014 at 09:47:14AM +0100, Stefani Seibold wrote: > > Hi Fengguang

Re: [x86, vdso] BUG: unable to handle kernel paging request at d34bd000

2014-03-06 Thread Stefani Seibold
:38 +0800 schrieb Fengguang Wu: > Hi Stefani, > > I got the below dmesg and the first bad commit is > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/vdso > commit 4dea8e4824b363c53f320d328040d7c6c5921419 > Author: Stefani Seibold > AuthorDate: Mon M

[tip:x86/vdso] x86, vdso: Add 32 bit VDSO time support for 64 bit kernel

2014-03-05 Thread tip-bot for Stefani Seibold
Commit-ID: 821130f9335f5808968fedab50268ba9159cc330 Gitweb: http://git.kernel.org/tip/821130f9335f5808968fedab50268ba9159cc330 Author: Stefani Seibold AuthorDate: Mon, 3 Mar 2014 22:12:21 +0100 Committer: H. Peter Anvin CommitDate: Wed, 5 Mar 2014 14:02:38 -0800 x86, vdso: Add 32 bit

[tip:x86/vdso] x86, vdso: Revamp vclock_gettime.c

2014-03-05 Thread tip-bot for Stefani Seibold
Commit-ID: 20dd4e23a10764f886c2a615bdc1f0c7db991cdb Gitweb: http://git.kernel.org/tip/20dd4e23a10764f886c2a615bdc1f0c7db991cdb Author: Stefani Seibold AuthorDate: Mon, 3 Mar 2014 22:12:14 +0100 Committer: H. Peter Anvin CommitDate: Wed, 5 Mar 2014 14:02:37 -0800 x86, vdso: Revamp

[tip:x86/vdso] x86, vdso: Replace VVAR(vsyscall_gtod_data) by gtod macro

2014-03-05 Thread tip-bot for Stefani Seibold
Commit-ID: 2e0035eefd9cc8a386c706cab7547b5280772726 Gitweb: http://git.kernel.org/tip/2e0035eefd9cc8a386c706cab7547b5280772726 Author: Stefani Seibold AuthorDate: Mon, 3 Mar 2014 22:12:16 +0100 Committer: H. Peter Anvin CommitDate: Wed, 5 Mar 2014 14:02:38 -0800 x86, vdso: Replace

[tip:x86/vdso] x86, vdso: Add 32 bit VDSO time support for 32 bit kernel

2014-03-05 Thread tip-bot for Stefani Seibold
Commit-ID: 4dea8e4824b363c53f320d328040d7c6c5921419 Gitweb: http://git.kernel.org/tip/4dea8e4824b363c53f320d328040d7c6c5921419 Author: Stefani Seibold AuthorDate: Mon, 3 Mar 2014 22:12:20 +0100 Committer: H. Peter Anvin CommitDate: Wed, 5 Mar 2014 14:02:38 -0800 x86, vdso: Add 32 bit

[tip:x86/vdso] mm: Add new func _install_special_mapping() to mmap.c

2014-03-05 Thread tip-bot for Stefani Seibold
Commit-ID: 1c6ff9d5108b5056dea85916990af036bb9dd10c Gitweb: http://git.kernel.org/tip/1c6ff9d5108b5056dea85916990af036bb9dd10c Author: Stefani Seibold AuthorDate: Mon, 3 Mar 2014 22:12:13 +0100 Committer: H. Peter Anvin CommitDate: Wed, 5 Mar 2014 14:02:37 -0800 mm: Add new func

[tip:x86/vdso] x86, vdso: Cleanup __vdso_gettimeofday()

2014-03-05 Thread tip-bot for Stefani Seibold
Commit-ID: 6543ca6fee7d3b314bda69b83fd429ed3e336645 Gitweb: http://git.kernel.org/tip/6543ca6fee7d3b314bda69b83fd429ed3e336645 Author: Stefani Seibold AuthorDate: Mon, 3 Mar 2014 22:12:17 +0100 Committer: H. Peter Anvin CommitDate: Wed, 5 Mar 2014 14:02:38 -0800 x86, vdso: Cleanup

[tip:x86/vdso] x86, vdso: Introduce VVAR marco for vdso32

2014-03-05 Thread tip-bot for Stefani Seibold
Commit-ID: 47ffeb5bae376766da7f4a326f13e980a280338b Gitweb: http://git.kernel.org/tip/47ffeb5bae376766da7f4a326f13e980a280338b Author: Stefani Seibold AuthorDate: Mon, 3 Mar 2014 22:12:18 +0100 Committer: H. Peter Anvin CommitDate: Wed, 5 Mar 2014 14:02:38 -0800 x86, vdso: Introduce

[tip:x86/vdso] x86, vdso: __vdso_clock_gettime() cleanup

2014-03-05 Thread tip-bot for Stefani Seibold
Commit-ID: 44e016d37d0e84f1d7063f699ee8df68d7bd7607 Gitweb: http://git.kernel.org/tip/44e016d37d0e84f1d7063f699ee8df68d7bd7607 Author: Stefani Seibold AuthorDate: Mon, 3 Mar 2014 22:12:15 +0100 Committer: H. Peter Anvin CommitDate: Wed, 5 Mar 2014 14:02:38 -0800 x86, vdso

[tip:x86/vdso] x86, vdso: Make vsyscall_gtod_data handling x86 generic

2014-03-05 Thread tip-bot for Stefani Seibold
Commit-ID: 644641cf162515479f34db62145d2efe084cb60e Gitweb: http://git.kernel.org/tip/644641cf162515479f34db62145d2efe084cb60e Author: Stefani Seibold AuthorDate: Mon, 3 Mar 2014 22:12:12 +0100 Committer: H. Peter Anvin CommitDate: Wed, 5 Mar 2014 14:02:37 -0800 x86, vdso: Make

Ping: Add 32 bit VDSO time function support

2014-03-04 Thread Stefani Seibold
Hi, again i want ask if there is a change to bring the patch back to tip and/or linux next? I also need a review of [Patch v22 10/12] x86: Add 32 bit VDSO time support for 64 bit kernel. Some more tests and acked-by would be also fine :-) Till the 32 bit VDSO time functions are not in the vanil

Re: Add 32 bit VDSO time function support

2014-03-04 Thread Stefani Seibold
Am Montag, den 03.03.2014, 23:20 -0800 schrieb H. Peter Anvin: > Pretty much... contact the glibc maintainers. However, with glibc being a > GNU project you will have to sign a copyright transfer. > > On March 3, 2014 11:02:08 PM PST, Stefani Seibold wrote: > >Hi, > >

Add 32 bit VDSO time function support

2014-03-03 Thread Stefani Seibold
Hi, i want ask if there is a change to bring the patch back to tip? As requested the glibc patch is now available at http://seibold.net/glibc.patch Any idea how to bring this patch into glibc? Is the process similar to the kernel? - Stefani -- To unsubscribe from this list: send the line "un

[Patch v22 12/12] x86: Zero-pad the VVAR page

2014-03-03 Thread Stefani Seibold
of memory that is exposed to userspace. Signed-off-by: Stefani Seibold --- arch/x86/kernel/vmlinux.lds.S | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S index 1d4897b..49edf2d 100644 --- a/arch/x86/kernel/vmlinux.lds.S +++

[Patch v22 10/12] x86: Add 32 bit VDSO time support for 64 bit kernel

2014-03-03 Thread Stefani Seibold
32- and 64-bit access - The inner struct clock was removed to pack the whole struct. The "unsigned seq" would be handled by functions derivated from seqcount_t. Signed-off-by: Stefani Seibold --- arch/x86/include/asm/vgtod.h | 71 +-- arch/x86/include/

[Patch v22 04/12] x86: vclock_gettime.c __vdso_clock_gettime cleanup

2014-03-03 Thread Stefani Seibold
This patch is a small code cleanup for the __vdso_clock_gettime() function. It removes the unneeded return values from do_monotonic_coarse() and do_realtime_coarse() and add a fallback label for doing the kernel gettimeofday() system call. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani

[Patch v22 02/12] x86: Add new func _install_special_mapping() to mmap.c

2014-03-03 Thread Stefani Seibold
bit address space. This will be done with io_remap_pfn_range() and remap_pfn_range, which requieres a vm_area_struct. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- include/linux/mm.h | 3 +++ mm/mmap.c | 20 2 files changed, 19 insertions(+), 4

[Patch v22 06/12] x86: cleanup __vdso_gettimeofday

2014-03-03 Thread Stefani Seibold
This patch do a little cleanup for the __vdso_gettimeofday() function. It kick out an unneeded ret local variable and makes the code faster if only the timezone is needed. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- arch/x86/vdso/vclock_gettime.c | 7 ++- 1 file

[Patch v22 03/12] x86: revamp vclock_gettime.c

2014-03-03 Thread Stefani Seibold
This intermediate patch revamps the vclock_gettime.c by moving some functions around. It is only for spliting purpose, to make whole the 32 bit vdso timer patch easier to review. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- arch/x86/vdso/vclock_gettime.c | 85

[PATCH v22 00/12] Add 32 bit VDSO time function support

2014-03-03 Thread Stefani Seibold
This patch add the functions vdso_gettimeofday(), vdso_clock_gettime() and vdso_time() to the 32 bit VDSO. The reason to do this was to get a fast reliable time stamp. Many developers uses TSC to get a fast time stamp, without knowing the pitfalls. VDSO time functions a fast and a reliable way, be

[Patch v22 05/12] x86: replace VVAR(vsyscall_gtod_data) by gtod macro

2014-03-03 Thread Stefani Seibold
There a currently more than 30 users of the gtod macro, so replace the last VVAR(vsyscall_gtod_data) by gtod macro. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- arch/x86/vdso/vclock_gettime.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86

[Patch v22 08/12] x86: Patch alternatives in the 32-bit vDSO

2014-03-03 Thread Stefani Seibold
From: Andy Lutomirski rdtsc_barrier() needs this. Signed-off-by: Stefani Seibold --- arch/x86/include/asm/vdso.h | 2 ++ arch/x86/vdso/Makefile | 3 ++- arch/x86/vdso/vdso32-setup.c | 25 + arch/x86/vdso/vma.c | 13 ++--- 4 files changed, 27

[Patch v22 09/12] x86: Add 32 bit VDSO time support for 32 bit kernel

2014-03-03 Thread Stefani Seibold
This patch add the time support for 32 bit a VDSO to a 32 bit kernel. For 32 bit programs running on a 32 bit kernel, the same mechanism is used as for 64 bit programs running on a 64 bit kernel. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- arch/x86/include/asm/vdso.h

[Patch v22 07/12] x86: introduce VVAR marco for vdso32

2014-03-03 Thread Stefani Seibold
This patch revamp the vvar.h for introduce the VVAR macro for vdso32. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- arch/x86/include/asm/vvar.h | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/vvar.h b/arch/x86/include

[Patch v22 01/12] x86: Make vsyscall_gtod_data handling x86 generic

2014-03-03 Thread Stefani Seibold
This patch move the vsyscall_gtod_data handling out of vsyscall_64.c into an additonal file vsyscall_gtod.c to make the functionality available for x86 32 bit kernel. It also adds a new vsyscall_32.c which setup the VVAR page. Reviewed-by: Andy Lutomirski Signed-off-by: Stefani Seibold

[PATCH v21 10/12] Add 32 bit VDSO time support for 64 bit kernel

2014-03-02 Thread Stefani Seibold
32- and 64-bit access - The inner struct clock was removed to pack the whole struct. The "unsigned seq" would be handled by functions derivated from seqcount_t. Signed-off-by: Stefani Seibold --- arch/x86/include/asm/vgtod.h | 71 +-- arch/x86/include/

[PATCH v21 12/12] x86: Zero-pad the VVAR page

2014-03-02 Thread Stefani Seibold
exposed to userspace. Signed-off-by: Andy Lutomirski Signed-off-by: Stefani Seibold --- arch/x86/kernel/vmlinux.lds.S | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S index 1d4897b..49edf2d 100644 --- a/arch/x86/kernel/vmlinux.lds.S

[PATCH v21 09/12] Add 32 bit VDSO time support for 32 bit kernel

2014-03-02 Thread Stefani Seibold
This patch add the time support for 32 bit a VDSO to a 32 bit kernel. For 32 bit programs running on a 32 bit kernel, the same mechanism is used as for 64 bit programs running on a 64 bit kernel. Signed-off-by: Stefani Seibold --- arch/x86/include/asm/vdso.h | 3 ++ arch/x86/include

  1   2   3   >