[PATCH v2] w1: mxc_w1: Enable clock before calling clk_get_rate() on it

2018-05-02 Thread Stefan Potyra
According to the API, you may only call clk_get_rate() after actually enabling it. Found by Linux Driver Verification project (linuxtesting.org). Fixes: a5fd9139f74c ("w1: add 1-wire master driver for i.MX27 / i.MX31") Signed-off-by: Stefan Potyra --- drivers/w1/masters/mxc

Re: [PATCH] Enable clock before calling clk_get_rate() on it.

2018-05-02 Thread Stefan Potyra
Hi Evgeniy, On Mon, Apr 30, 2018 at 06:02:57PM +0300, Evgeniy Polyakov wrote: > Hi Stefan > > Nice catch, thank you! > > 19.04.2018, 16:02, "Stefan Potyra" : > > According to the API, you may only call clk_get_rate() after actually > > enabling it. >

[PATCH v5] spi/bcm63xx-hspi: Enable the clock before calling clk_get_rate().

2018-04-26 Thread Stefan Potyra
("spi: bcm63xx-hsspi: add bcm63xx HSSPI driver") Signed-off-by: Stefan Potyra --- drivers/spi/spi-bcm63xx-hsspi.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c index cb

[PATCH v4] spi/bcm63xx-hspi: Enable the clock before calling clk_get_rate().

2018-04-25 Thread Stefan Potyra
("spi: bcm63xx-hsspi: add bcm63xx HSSPI driver") Signed-off-by: Stefan Potyra --- drivers/spi/spi-bcm63xx-hsspi.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c index cb

[PATCH v3] spi/bcm63xx-hspi: Enable the clock before calling

2018-04-25 Thread Stefan Potyra
Enable the clock prior to calling clk_get_rate(), because clk_get_rate() should only be called if the clock is enabled. Found by Linux Driver Verification project (linuxtesting.org). Fixes: 142168eba9dc ("spi: bcm63xx-hsspi: add bcm63xx HSSPI driver") Signed-off-by: Stefan Potyra --

[PATCH v2] sc16is7xx: Check for an error when the clock is enabled.

2018-04-24 Thread Stefan Potyra
When the clock is enabled, check if there is an error. Otherwise clk_get_rate() can be called without enabled clock. Found by Linux Driver Verification project (linuxtesting.org). Fixes: 0814e8d5da2b ("sc16is7xx: enable the clock") Signed-off-by: Stefan Potyra --- drivers/

[PATCH v2] spi/bcm63xx-hspi: Enable the clock before calling clk_get_rate().

2018-04-24 Thread Stefan Potyra
Enable the clock prior to calling clk_get_rate(), because clk_get_rate() should only be called if the clock is enabled. Found by Linux Driver Verification project (linuxtesting.org). Fixes: 142168eba9dc (spi: "bcm63xx-hsspi: add bcm63xx HSSPI driver") Signed-off-by: Stefan Potyra --

[PATCH] Enable clock before calling clk_get_rate() on it.

2018-04-19 Thread Stefan Potyra
According to the API, you may only call clk_get_rate() after actually enabling it. Found by Linux Driver Verification project (linuxtesting.org). Fixes: a5fd9139f74c w1: add 1-wire master driver for i.MX27 / i.MX31 Signed-off-by: Stefan Potyra --- drivers/w1/masters/mxc_w1.c | 8 1

[PATCH] Enable the clock before calling clk_get_rate().

2018-04-19 Thread Stefan Potyra
Found by Linux Driver Verification project (linuxtesting.org). Fixes: 142168eba9dc spi: bcm63xx-hsspi: add bcm63xx HSSPI driver Signed-off-by: Stefan Potyra --- drivers/spi/spi-bcm63xx-hsspi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-bcm63xx

[PATCH] Check for an error when the clock is enabled.

2018-04-19 Thread Stefan Potyra
Found by Linux Driver Verification project (linuxtesting.org). Fixes: 0814e8d5da2b sc16is7xx: enable the clock Signed-off-by: Stefan Potyra --- drivers/tty/serial/sc16is7xx.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty

[PATCH] serial: 8250_dw: Disable clock on error

2017-12-06 Thread Stefan Potyra
If there is no clock rate for uartclk defined, disable the previously enabled clock again. Found by Linux Driver Verification project (linuxtesting.org). Fixes: 23f5b3fdd04e serial: 8250_dw: only get the clock rate in one place Signed-off-by: Stefan Potyra --- drivers/tty/serial/8250/8250_dw.c

[PATCH] SoC: rockchip: disable clock on error

2017-12-06 Thread Stefan Potyra
Disable the clocks in rk_spdif_probe when an error occurs after one of the clocks has been enabled previously. Found by Linux Driver Verification project (linuxtesting.org). Fixes: f874b80e1571 ASoC: rockchip: Add rockchip SPDIF transceiver driver Signed-off-by: Stefan Potyra --- sound/soc

[PATCH] phy: rockchip-inno-usb2: disable clock on error

2017-12-06 Thread Stefan Potyra
-by: Stefan Potyra --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index 5049dac79bd0..06827f4f49b3 100644 --- a/drivers/phy/rockc