[PATCH v2] target: remove initiatorname field in se_acl_lun

2015-08-13 Thread Spencer Baugh
From: Chris Zankel The initiatorname field in se_acl_lun is only a copy of the same field in se_node_acl, so remove it and use the version in se_node_acl where needed (it's actually only used for pr_debug) Signed-off-by: Chris Zankel Signed-off-by: Spencer Baugh --- drivers/t

[PATCH v2] target: remove unused lun_flags field from se_lun

2015-08-13 Thread Spencer Baugh
From: Chris Zankel The lun_flags field is not used, so drop it. Signed-off-by: Chris Zankel Signed-off-by: Spencer Baugh --- include/target/target_core_base.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index

[PATCH v2] target: Fix handling of small allocation lengths in REPORT LUNS

2015-08-13 Thread Spencer Baugh
rather than return an error. Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers/target/target_core_spc.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/target/target_core_spc.c b/drivers/target/target_core_spc.c

[PATCH] RDMA/cma: fix IPv6 address resolution

2015-08-13 Thread Spencer Baugh
bind_addr, and set bound_dev_if to the destination address scope id to correct it. Signed-off-by: Spencer Baugh --- drivers/infiniband/core/cma.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index 6a6b60a..

[PATCH] target: Fix handling of small allocation lengths in REPORT LUNS

2015-08-12 Thread Spencer Baugh
rather than return an error. Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers/target/target_core_spc.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/target/target_core_spc.c b/drivers/target/target_core_spc.c

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Spencer Baugh
From: Brian Bunker AIX servers using VIOS servers that virtualize FC cards will have a problem booting without support for START_STOP_UNIT. v2: Cite sb3r36 exactly, clean up if conditions Signed-off-by: Brian Bunker Signed-off-by: Spencer Baugh --- drivers/target/target_core_sbc.c | 36

[PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-23 Thread Spencer Baugh
b in there as soon as possible. At a later point t_task_cdb is reset to the correct buffer, but until then traces and printks don't cause a crash. Signed-off-by: Alexei Potashnik Signed-off-by: Spencer Baugh --- drivers/target/iscsi/iscsi_target.c| 4 ++-- drivers/target/target_cor

[PATCH] e1000: make eeprom read/write scheduler friendly

2015-07-23 Thread Spencer Baugh
From: Joern Engel Code was responsible for ~150ms scheduler latencies. Signed-off-by: Joern Engel Signed-off-by: Spencer Baugh --- drivers/net/ethernet/intel/e1000/e1000_hw.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000

[PATCH] block: round timeouts to 100ms instead of 1s

2015-07-23 Thread Spencer Baugh
better precision. Signed-off-by: Joern Engel Signed-off-by: Spencer Baugh --- block/blk-timeout.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/block/blk-timeout.c b/block/blk-timeout.c index 246dfb1..0d06162 100644 --- a/block/blk-timeout.c +++ b/block/blk

[PATCH] mm: add resched points to remap_pmd_range/ioremap_pmd_range

2015-07-23 Thread Spencer Baugh
+0xc0/0x150 [] ? finish_task_switch+0xc4/0xe0 [] do_notify_resume+0x65/0x80 [] retint_signal+0x4d/0x9f ---[ end trace 3506c05e4a0af3e5 ]--- Signed-off-by: Joern Engel Signed-off-by: Spencer Baugh --- lib/ioremap.c | 1 + mm/memory.c | 1 + mm/vmalloc.c | 1 + 3 files changed, 3 insertions

[PATCH] aer: add cond_resched to aer_isr

2015-07-23 Thread Spencer Baugh
From: Joern Engel Multiple nested loops. I have observed 590ms scheduler latency caused by this loop and interrupts. Interrupts were responsible for 190ms, the rest could have been avoided with a cond_resched. Signed-off-by: Joern Engel Signed-off-by: Spencer Baugh --- drivers/pci/pcie/aer

[PATCH] hugetlb: cond_resched for set_max_huge_pages and follow_hugetlb_page

2015-07-23 Thread Spencer Baugh
From: Joern Engel ~150ms scheduler latency for both observed in the wild. Signed-off-by: Joern Engel Signed-off-by: Spencer Baugh --- mm/hugetlb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index a8c3087..2eb6919 100644 --- a/mm/hugetlb.c +++ b/mm

Re: [PATCH v3] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-07-23 Thread Spencer Baugh
there don't appear to be any other places that use max_cmd_sn within the mutex more than once, so this lock can't be providing any useful serialization. v2: Get correct values for logging v3: Fix whitespace damage Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers

[PATCH v2] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-07-23 Thread Spencer Baugh
there don't appear to be any other places that use max_cmd_sn within the mutex more than once, so this lock can't be providing any useful serialization. v2: Get correct values for logging Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers/target/iscsi/

[PATCH] target: respond to unknown initiators with sensible REPORT LUNS list length

2015-07-22 Thread Spencer Baugh
From: Roland Dreier Solaris seems to go beserk if we respond to REPORT LUNS with a LUN LIST LENGTH of 0. Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers/target/target_core_spc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/target/target_core_spc.c

[PATCH] target: allow underflow/overflow for PR OUT etc. commands

2015-07-22 Thread Spencer Baugh
ands. The Windows compliance test sends them. Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers/target/target_core_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transpo

[PATCH] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-07-22 Thread Spencer Baugh
there don't appear to be any other places that use max_cmd_sn within the mutex more than once, so this lock can't be providing any useful serialization. Signed-off-by: Roland Dreier Signed-off-by: Spencer Baugh --- drivers/target/iscsi/iscsi_target.c | 18 +---

[PATCH] qla2xxx: remove unused rval

2015-07-22 Thread Spencer Baugh
From: Joern Engel We don't touch the return value of qla2x00_loop_resync in qla2x00_do_dpc, so don't bother collecting it. Fixes a compiler warning. Signed-off-by: Joern Engel Signed-off-by: Spencer Baugh --- drivers/scsi/qla2xxx/qla_os.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH] target: improve unsupported opcode message

2015-07-22 Thread Spencer Baugh
From: Joern Engel Make the warning about unsupported SCSI opcode more useful: - Add in the initiator name so we know who's sending it. - Print the warning even for opcodes that spc_parse_cdb() knows about but that we don't handle. Signed-off-by: Joern Engel Signed-off-by: Spe

Re: [PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-21 Thread Spencer Baugh
Please disregard, depends on another patch. Will send again later. Sorry for the noise. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read th

[PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-21 Thread Spencer Baugh
From: Dilip Kumar Uppugandla Invoking get_cmd_state for qla2xxx always returns 0. Instead change it to return the actual fabric state from qla_tgt_cmd. This will help with debugging. Signed-off-by: Dilip Kumar Uppugandla Signed-off-by: Spencer Baugh --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 6

[PATCH] target/iscsi: Fix double free of a TUR followed by a solicited NOPOUT

2015-07-21 Thread Spencer Baugh
Potashnik Signed-off-by: Spencer Baugh --- drivers/target/iscsi/iscsi_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index a4cf58c..ebb1ece 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b

[PATCH] soft lockup: kill realtime threads before panic

2015-07-21 Thread Spencer Baugh
From: Joern Engel We have observed cases where the soft lockup detector triggered, but no kernel bug existed. Instead we had a buggy realtime thread that monopolized a cpu. So let's kill the responsible party and not panic the entire system. Signed-off-by: Joern Engel Signed-off-by: Sp

[PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-21 Thread Spencer Baugh
b in there as soon as possible. At a later point t_task_cdb is reset to the correct buffer, but until then traces and printks don't cause a crash. Signed-off-by: Alexei Potashnik Signed-off-by: Spencer Baugh --- drivers/target/target_core_device.c| 7 +++ drivers/target/target_co

[PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-21 Thread Spencer Baugh
From: Brian Bunker AIX servers using VIOS servers that virtualize FC cards will have a problem booting without support for START_STOP_UNIT. Signed-off-by: Brian Bunker Signed-off-by: Spencer Baugh --- drivers/target/target_core_sbc.c | 33 + 1 file changed, 33

Re: [PATCH 1/2] target: remove unused lun_flags field from se_lun

2015-07-21 Thread Spencer Baugh
Christoph Hellwig writes: > Looks good, > > but what's up with your From lines: > > On Mon, Jul 20, 2015 at 04:29:49PM -0700, Spencer Baugh wrote: >> From: Spencer Baugh >> >> From: Chris Zankel > > plus another address for you in the actual ema

[PATCH] target/iscsi: fix digest computation for chained SGs

2015-07-20 Thread Spencer Baugh
From: Alexei Potashnik Current implementation assumes that all the buffers of an IO are linked with a single SG list. Which makes it fail if SG chaining is used. Signed-off-by: Alexei Potashnik --- drivers/target/iscsi/iscsi_target.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(

[PATCH 1/2] target: remove unused lun_flags field from se_lun

2015-07-20 Thread Spencer Baugh
From: Spencer Baugh From: Chris Zankel The lun_flags field is not used, so drop it. Signed-off-by: Chris Zankel --- include/target/target_core_base.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index 17ae2d6

[PATCH 2/2] target: remove initiatorname field in se_acl_lun

2015-07-20 Thread Spencer Baugh
From: Spencer Baugh From: Chris Zankel The initiatorname field in se_acl_lun is only a copy of the same field in se_node_acl, so remove it and use the version in se_node_acl where needed (it's actually only used for pr_debug) Signed-off-by: Chris Zankel --- drivers/t

[PATCH] lustre: ptlrpc: add "ptlrpc_internal.h" to sec_gc.c

2014-12-20 Thread Spencer Baugh
c? drivers/staging/lustre/lustre/ptlrpc/sec_gc.c:241:6: warning: symbol 'sptlrpc_gc_fini' was not declared. Should it be static? Signed-off-by: Spencer Baugh --- drivers/staging/lustre/lustre/ptlrpc/sec_gc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/

[PATCH 2/2] staging: lustre: fix pointer whitespace style

2014-09-14 Thread Spencer Baugh
Fix errors reported by checkpatch of this kind: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Spencer Baugh --- drivers/staging/lustre/lustre/include/lustre_import.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/l

[PATCH 1/2] staging: lustre: fix function definition style

2014-09-14 Thread Spencer Baugh
Fix errors reported by checkpatch of this kind: ERROR: open brace '{' following function declarations go on the next line Signed-off-by: Spencer Baugh --- drivers/staging/lustre/lustre/include/lustre_import.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 2/3] staging: lustre: fix pointer whitespace style

2014-09-06 Thread Spencer Baugh
Fix errors reported by checkpatch of this kind: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Spencer Baugh --- drivers/staging/lustre/lustre/include/lustre_import.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/l

[PATCH 3/3] staging: lustre: remove trailing whitespace

2014-09-06 Thread Spencer Baugh
Fix errors reported by checkpatch of this kind: ERROR: trailing whitespace Signed-off-by: Spencer Baugh --- drivers/staging/lustre/lustre/include/lustre_import.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lustre_import.h b

[PATCH 1/3] staging: lustre: fix function definition style

2014-09-06 Thread Spencer Baugh
Fix errors reported by checkpatch of this kind: ERROR: open brace '{' following function declarations go on the next line Signed-off-by: Spencer Baugh --- drivers/staging/lustre/lustre/include/lustre_import.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH] staging: fix style in lustre_import.h

2014-08-22 Thread Spencer Baugh
This patch fixes style errors and warnings reported by scripts/checkpatch.pl Signed-off-by: Spencer Baugh --- .../staging/lustre/lustre/include/lustre_import.h | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/staging/lustre/lustre/include