[PATCH] MAINTAINERS: Remove myself as reviewer

2017-09-27 Thread Soren Brinkmann
This address is gonna bounce in the not too far away future. Signed-off-by: Soren Brinkmann --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index dc3ff3aaa588..4502f016be12 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2161,7 +2161,6 @@ F

[PATCH v2 1/2] media:imx274 device tree binding file

2017-08-28 Thread Soren Brinkmann
From: Leon Luo The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann --- .../devicetree/bindings/media/i2c/imx274.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/media

[PATCH v2 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-08-28 Thread Soren Brinkmann
From: Leon Luo The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface is 4-lane MIPI running at 1.44Gbps each. This driver has been tested on Xilinx ZCU102 platform with a Leopard LI-IMX274MIPI-FMC camera board. Supp

[PATCH 1/2] media:imx274 device tree binding file

2017-08-28 Thread Soren Brinkmann
From: Leon Luo The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann --- .../devicetree/bindings/media/i2c/imx274.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/media

[PATCH 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-08-28 Thread Soren Brinkmann
From: Leon Luo The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface is 4-lane MIPI running at 1.44Gbps each. This driver has been tested on Xilinx ZCU102 platform with a Leopard LI-IMX274MIPI-FMC camera board. Supp

[PATCH] gpio: zynq: Clarify quirk and provide helper function

2017-06-08 Thread Soren Brinkmann
or zynqmp. Signed-off-by: Soren Brinkmann --- drivers/gpio/gpio-zynq.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index ed87c9a6e0e6..df0851464006 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers

[PATCH] vivid: Enable 4k resolution for webcam capture device

2016-12-15 Thread Soren Brinkmann
Add 3840x2160 as valid resolution for the webcam capture input and adjust the webcam intervals accordingly. Signed-off-by: Soren Brinkmann --- Hi, we'd like to use the vivid webcam capture device with a 4k resolution. This basically seems to do the trick, though, I'm not sure if

[PATCH LINUX v5 1/8] tty: xuartps: Beautify read-modify writes

2015-12-26 Thread Soren Brinkmann
Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley Reviewed-by: Moritz Fischer --- drivers/tty/serial/xilinx_uartps.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial

[PATCH LINUX v5 6/8] tty: xuartps: Keep lock for whole ISR

2015-12-26 Thread Soren Brinkmann
The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c

[PATCH LINUX v5 4/8] tty: xuartps: Clear interrupt status register in shutdown

2015-12-26 Thread Soren Brinkmann
When shutting down the UART, clear the interrupt status register. Bits in the ISR are cleared by writing them as '1'. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley Reviewed-by: Moritz Fischer --- v4: - clarify workings of the ISR in the commit message --- drivers/

[PATCH LINUX v5 2/8] tty: xuartps: Use spinlock to serialize HW access

2015-12-26 Thread Soren Brinkmann
Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley

[PATCH LINUX v5 3/8] tty: xuartps: Don't consider circular buffer when enabling transmitter

2015-12-26 Thread Soren Brinkmann
Restarting the transmitter even if the circ buffer is empty may be necessary to push out remaining data when the port is restarted after being stopped. Cc: Peter Hurley Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- v3: - changed this patch to not always enable the transmitter

[PATCH LINUX v5 7/8] tty: xuartps: Acquire port lock for shutdown

2015-12-26 Thread Soren Brinkmann
Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- drivers/tty/serial

[PATCH LINUX v5 0/8] tty: xuartps: Fix lock ups

2015-12-26 Thread Soren Brinkmann
Hi, as requested by Peter, this is the first part of my series which has the patches reviewed by Peter. I'll submit the second part separately. There are no new changes within the patches. Thanks, Sören Sören Brinkmann (8): tty: xuartps: Beautify read-modify writes tty: xuart

[PATCH LINUX v5 5/8] tty: xuartps: Improve startup function

2015-12-26 Thread Soren Brinkmann
The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- drivers/tty/serial/xilinx_uartps.c | 20 1 file change

[PATCH LINUX v5 8/8] tty: xuartps: Move RX path into helper function

2015-12-26 Thread Soren Brinkmann
Move RX-related IRQ handling into a helper function. Fixes a problem where every char received after a parity or frame error in the current isr will also be tagged as a parity or frame error. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- v4: - added Peter's addit

[PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property

2015-12-14 Thread Soren Brinkmann
Signed-off-by: Soren Brinkmann --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi index 857eda5c7217..b5d1facadf16 100644 --- a/arch/arm64/boot/dts

[PATH TRIVIAL] Documentation: cpu-hotplug: Fix sysfs mount instructions

2015-12-07 Thread Soren Brinkmann
The instructions for mounting sysfs are inconsistent in instructing to create the directory '/sysfs' but then mounting sysfs to /sys. Also, indentation is slightly off. Signed-off-by: Soren Brinkmann --- Documentation/cpu-hotplug.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH LINUX v4 13/13] tty: xuartps: Remove '_OFFSET' suffix from #defines

2015-12-05 Thread Soren Brinkmann
Remove the _OFFSET suffix from all register defines which makes code a little easier to read and avoids a few line breaks. Suggested-by: Peter Hurley Signed-off-by: Soren Brinkmann --- v4: - added this patch --- drivers/tty/serial/xilinx_uartps.c | 221 ++--- 1

[PATCH LINUX v4 03/13] tty: xuartps: Don't consider circular buffer when enabling transmitter

2015-12-05 Thread Soren Brinkmann
Restarting the transmitter even if the circ buffer is empty may be necessary to push out remaining data when the port is restarted after being stopped. Cc: Peter Hurley Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- v3: - changed this patch to not always enable the transmitter

[PATCH LINUX v4 05/13] tty: xuartps: Improve startup function

2015-12-05 Thread Soren Brinkmann
The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- drivers/tty/serial/xilinx_uartps.c | 20 1 file change

[PATCH LINUX v4 11/13] tty: xuartps: Cleanup: Reformat if-else

2015-12-05 Thread Soren Brinkmann
Convert an if-else into the more common early return on error, reducing the indent level of the happy path. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 124 ++--- 1 file changed, 62 insertions(+), 62 deletions(-) diff --git a/drivers

[PATCH LINUX v4 04/13] tty: xuartps: Clear interrupt status register in shutdown

2015-12-05 Thread Soren Brinkmann
When shutting down the UART, clear the interrupt status register. Bits in the ISR are cleared by writing them as '1'. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley Reviewed-by: Moritz Fischer --- v4: - clarify workings of the ISR in the commit message --- drivers/

[PATCH LINUX v4 01/13] tty: xuartps: Beautify read-modify writes

2015-12-05 Thread Soren Brinkmann
Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley Reviewed-by: Moritz Fischer --- drivers/tty/serial/xilinx_uartps.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial

[PATCH LINUX v4 00/13] tty: xuartps: Fix lock ups

2015-12-05 Thread Soren Brinkmann
Hi, I picked up all the review tags from Peter and Moritz and addressed Peter's comments. Most patches are unchanged but I added the info Peter suggested/provided to some commit messages. The patches "tty: xuartps: Move request_irq to after setting up the HW", "tty: xuartps: Improve sysrq handling

[PATCH LINUX v4 02/13] tty: xuartps: Use spinlock to serialize HW access

2015-12-05 Thread Soren Brinkmann
Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley

[PATCH LINUX v4 09/13] tty: xuartps: Move RX path into helper function

2015-12-05 Thread Soren Brinkmann
Move RX-related IRQ handling into a helper function. Fixes a problem where every char received after a parity or frame error in the current isr will also be tagged as a parity or frame error. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- v4: - added Peter's addit

[PATCH LINUX v4 08/13] tty: xuartps: Acquire port lock for shutdown

2015-12-05 Thread Soren Brinkmann
Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- drivers/tty/serial

[PATCH LINUX v4 12/13] tty: xuartps: Improve sysrq handling

2015-12-05 Thread Soren Brinkmann
to simply call uart_handle_sysrq. Suggested-by: Peter Hurley Signed-off-by: Soren Brinkmann --- v4: - added this patch --- drivers/tty/serial/xilinx_uartps.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/

[PATCH LINUX v4 06/13] tty: xuartps: Move request_irq to after setting up the HW

2015-12-05 Thread Soren Brinkmann
Request_irq() should be _after_ h/w programming, otherwise an interrupt could be triggered and in-progress before the h/w has been setup. Reported-by: Peter Hurley Signed-off-by: Soren Brinkmann --- v4: - this patch has been added. Thanks to Peter for pointing it out and providing commit

[PATCH LINUX v4 07/13] tty: xuartps: Keep lock for whole ISR

2015-12-05 Thread Soren Brinkmann
The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c

[PATCH LINUX v4 10/13] tty: xuartps: Refactor IRQ handling

2015-12-05 Thread Soren Brinkmann
The system could deadlock handling RX IRQs when RX-related IRQ conditions became true while the receiver was disabled. To avoid this, enable/disable the RX/TX IRQs together with the receiver/transmitter. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 18

[PATCH LINUX v3 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled

2015-11-21 Thread Soren Brinkmann
Ignore RX-related interrupts if RX is not enabled. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index

[PATCH LINUX v3 04/10] tty: xuartps: Clear interrupt status register in shutdown

2015-11-21 Thread Soren Brinkmann
When shutting down the UART, clear the interrupt status register. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 6a7cd4e057ae..ef114d7a0623

[PATCH LINUX v3 01/10] tty: xuartps: Beautify read-modify writes

2015-11-21 Thread Soren Brinkmann
Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index

[PATCH LINUX v3 05/10] tty: xuartps: Improve startup function

2015-11-21 Thread Soren Brinkmann
The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 20 1 file changed, 12 insertions(+), 8 dele

[PATCH LINUX v3 03/10] tty: xuartps: Don't consider circular buffer when enabling transmitter

2015-11-21 Thread Soren Brinkmann
Restarting the transmitter even if the circ buffer is empty may be necessary to push out remaining data when the port is restarted after being stopped. Cc: Peter Hurley Signed-off-by: Soren Brinkmann --- v3: - changed this patch to not always enable the transmitter, but keep the check for

[PATCH LINUX v3 02/10] tty: xuartps: Use spinlock to serialize HW access

2015-11-21 Thread Soren Brinkmann
Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann --- drivers/tty/serial

[PATCH LINUX v3 10/10] tty: xuartps: Cleanup: Reformat if-else

2015-11-21 Thread Soren Brinkmann
Convert an if-else into the more common early return on error, reducing the indent level of the happy path. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 124 ++--- 1 file changed, 62 insertions(+), 62 deletions(-) diff --git a/drivers

[PATCH LINUX v3 00/10] tty: xuartps: Fix lock ups

2015-11-21 Thread Soren Brinkmann
Hi, here is v3 of this series. It's largely the same as before, but I adjusted 'tty: xuartps: Don't consider circular buffer when enabling transmitter' according to Peter's suggestions. I also spent some time trying to get Peter's test for flow control and xchar running. The xchar thing fails and

[PATCH LINUX v3 08/10] tty: xuartps: Move RX path into helper function

2015-11-21 Thread Soren Brinkmann
Move RX-related IRQ handling into a helper function. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 50 +- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial

[PATCH LINUX v3 07/10] tty: xuartps: Acquire port lock for shutdown

2015-11-21 Thread Soren Brinkmann
Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 6 ++ 1 file

[PATCH LINUX v3 06/10] tty: xuartps: Keep lock for whole ISR

2015-11-21 Thread Soren Brinkmann
The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 6ffd3bbe3e18

[PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in start_tx

2015-11-19 Thread Soren Brinkmann
start_tx must start transmitting characters. Regardless of the state of the circular buffer, always enable the transmitter hardware. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial

[PATH RESEND v2 07/10] tty: xuartps: Acquire port lock for shutdown

2015-11-19 Thread Soren Brinkmann
Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 6 ++ 1 file

[PATH RESEND v2 10/10] tty: xuartps: Cleanup: Reformat if-else

2015-11-19 Thread Soren Brinkmann
Convert an if-else into the more common early return on error, reducing the indent level of the happy path. Signed-off-by: Soren Brinkmann --- v2: - added this patch --- drivers/tty/serial/xilinx_uartps.c | 124 ++--- 1 file changed, 62 insertions(+), 62

[PATH RESEND v2 05/10] tty: xuartps: Improve startup function

2015-11-19 Thread Soren Brinkmann
The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 20 1 file changed, 12 insertions(+), 8 dele

[PATH RESEND v2 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled

2015-11-19 Thread Soren Brinkmann
Ignore RX-related interrupts if RX is not enabled. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index

[PATH RESEND v2 00/10] tty: xuartps: Fix lock ups

2015-11-19 Thread Soren Brinkmann
Hi, I guess this series got probably lost during the merge window. Hence, I resend the patches. This is v2, hopefully without any build issues. The changes are the same as before, just the warning reported by kbuild test robot about unused variables have been fixed. And, I added one more patch wi

[PATH RESEND v2 08/10] tty: xuartps: Move RX path into helper function

2015-11-19 Thread Soren Brinkmann
Move RX-related IRQ handling into a helper function. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 50 +- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial

[PATH RESEND v2 06/10] tty: xuartps: Keep lock for whole ISR

2015-11-19 Thread Soren Brinkmann
The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 167e0f4bcf7a

[PATH RESEND v2 02/10] tty: xuartps: Use spinlock to serialize HW access

2015-11-19 Thread Soren Brinkmann
Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann --- v2: - remove unused variable

[PATH RESEND v2 01/10] tty: xuartps: Beautify read-modify writes

2015-11-19 Thread Soren Brinkmann
Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index

[PATH RESEND v2 04/10] tty: xuartps: Clear interrupt status register in shutdown

2015-11-19 Thread Soren Brinkmann
When shutting down the UART, clear the interrupt status register. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index df6778d17949..b7fc30639292

[PATCH v2 02/10] tty: xuartps: Use spinlock to serialize HW access

2015-11-04 Thread Soren Brinkmann
Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann --- v2: - remove unused variable

[PATCH v2 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled

2015-11-04 Thread Soren Brinkmann
Ignore RX-related interrupts if RX is not enabled. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index

[PATCH v2 01/10] tty: xuartps: Beautify read-modify writes

2015-11-04 Thread Soren Brinkmann
Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index

[PATCH v2 03/10] tty: xuartps: Always enable transmitter in start_tx

2015-11-04 Thread Soren Brinkmann
start_tx must start transmitting characters. Regardless of the state of the circular buffer, always enable the transmitter hardware. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial

[PATCH v2 07/10] tty: xuartps: Acquire port lock for shutdown

2015-11-04 Thread Soren Brinkmann
Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 6 ++ 1 file

[PATCH v2 04/10] tty: xuartps: Clear interrupt status register in shutdown

2015-11-04 Thread Soren Brinkmann
When shutting down the UART, clear the interrupt status register. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index df6778d17949..b7fc30639292

[PATCH v2 00/10] tty: xuartps: Fix lock ups

2015-11-04 Thread Soren Brinkmann
Hi, this is v2, hopefully without any build issues. The changes are the same as before, just the warning reported by kbuild test robot about unused variables have been fixed. And, I added one more patch with some cleanup/refactoring. I recently found my system locking up under some conditions. I

[PATCH v2 06/10] tty: xuartps: Keep lock for whole ISR

2015-11-04 Thread Soren Brinkmann
The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 167e0f4bcf7a

[PATCH v2 10/10] tty: xuartps: Cleanup: Reformat if-else

2015-11-04 Thread Soren Brinkmann
Convert an if-else into the more common early return on error, reducing the indent level of the happy path. Signed-off-by: Soren Brinkmann --- v2: - added this patch --- drivers/tty/serial/xilinx_uartps.c | 124 ++--- 1 file changed, 62 insertions(+), 62

[PATCH v2 05/10] tty: xuartps: Improve startup function

2015-11-04 Thread Soren Brinkmann
The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 20 1 file changed, 12 insertions(+), 8 dele

[PATCH v2 08/10] tty: xuartps: Move RX path into helper function

2015-11-04 Thread Soren Brinkmann
Move RX-related IRQ handling into a helper function. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 50 +- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial

[PATCH v2 2/2] gpio: zynq: Implement irq_pm_(get|put)

2015-11-04 Thread Soren Brinkmann
The driver uses runtime PM to leverage low power techniques. For use-cases using GPIO as interrupt the device needs to be in an appropriate state. Reported-by: John Linn Signed-off-by: Soren Brinkmann --- v2: - declare callbacks static --- drivers/gpio/gpio-zynq.c | 20 1

[PATCH v2 1/2] genirq: Add irq_pm_(get|put) callbacks to the irqchip

2015-11-04 Thread Soren Brinkmann
Clausen Signed-off-by: Soren Brinkmann --- v2: - report errors up the callchain - add error handling (needed some refactoring of the existing error handling in request_threaded_irq) --- include/linux/irq.h| 4 kernel/irq/internals.h | 14 ++ kernel/irq/manage.c| 20

[PATCH v2 0/2] Power management callbacks for irqchips

2015-11-04 Thread Soren Brinkmann
Hi, we recently discussed how to handle power management with GPIO devices that can generate interrupts here: https://lkml.org/lkml/2015/10/23/305. At the end of that discussion stood Lars' suggestion to add a new pair of callbacks to the irqchip for this purpose. This is a first, naive implementa

[PATCH] rtc: Group Kconfig entries by vendor

2015-11-03 Thread Soren Brinkmann
The RTC entries are mostly grouped by vendor. Move the few outliers in place. Also, change the one occurrence of 'nxp' to 'NXP' to make all NXP entries consistent. Signed-off-by: Soren Brinkmann --- drivers/rtc/Kconfig | 90 ++---

[PATCH 7/9] tty: xuartps: Acquire port lock for shutdown

2015-11-03 Thread Soren Brinkmann
Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 6 ++ 1 file

[PATCH 6/9] tty: xuartps: Keep lock for whole ISR

2015-11-03 Thread Soren Brinkmann
The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index b189e600d4ab

[PATCH 2/9] tty: xuartps: Use spinlock to serialize HW access

2015-11-03 Thread Soren Brinkmann
Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann --- drivers/tty/serial

[PATCH 1/9] tty: xuartps: Beautify read-modify writes

2015-11-03 Thread Soren Brinkmann
Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index

[PATCH 5/9] tty: xuartps: Improve startup function

2015-11-03 Thread Soren Brinkmann
The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 20 1 file changed, 12 insertions(+), 8 dele

[PATCH 0/9] tty: xuartps: Fix lock ups

2015-11-03 Thread Soren Brinkmann
Hi, I recently found my system locking up under some conditions. I dug through the code a bit and the result is this collections of various changes. Some of it may not be required and has just been created out of half-baked theories and re-reading the documentation. The actual failing scenarios se

[PATCH 3/9] tty: xuartps: Always enable transmitter in start_tx

2015-11-03 Thread Soren Brinkmann
start_tx must start transmitting characters. Regardless of the state of the circular buffer, always enable the transmitter hardware. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial

[PATCH 9/9] tty: xuartps: Only handle RX IRQs when RX is enabled

2015-11-03 Thread Soren Brinkmann
Ignore RX-related interrupts if RX is not enabled. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index

[PATCH 4/9] tty: xuartps: Clear interrupt status register in shutdown

2015-11-03 Thread Soren Brinkmann
When shutting down the UART, clear the interrupt status register. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 5edd1efca015..738df6bb2646

[PATCH 8/9] tty: xuartps: Move RX path into helper function

2015-11-03 Thread Soren Brinkmann
Move RX-related IRQ handling into a helper function. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 50 +- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial

[PATCH 2/3] ARM: zynq: DT: Add interrupt-controller property to GPIO

2015-10-23 Thread Soren Brinkmann
GPIO can be used as interrupt-controller. Add the missing properties to the GPIO node. Signed-off-by: Soren Brinkmann --- arch/arm/boot/dts/zynq-7000.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi index 1a5220e05109

[PATCH 3/3] ARM64: zynqmp: DT: Add interrupt-controller property to GPIO

2015-10-23 Thread Soren Brinkmann
GPIO can be used as interrupt-controller. Add the missing properties to the GPIO node. Signed-off-by: Soren Brinkmann --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi

[PATCH 1/3] DT binding: gpio-zynq: Document interrupt-controller

2015-10-23 Thread Soren Brinkmann
HW and driver support the GPIO as interrupt-controller. Document that in the DT binding. Signed-off-by: Soren Brinkmann --- Documentation/devicetree/bindings/gpio/gpio-zynq.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.txt b

[PATCH] gpio: zynq: Implement irq_(request|release)_resources

2015-10-23 Thread Soren Brinkmann
The driver uses runtime PM to leverage low power techniques. For use-cases using GPIO as interrupt the device needs to be in an appropriate state. Reported-by: John Linn Signed-off-by: Soren Brinkmann Tested-by: John Linn --- drivers/gpio/gpio-zynq.c | 20 1 file changed

[PATCH v2] gpio: xilinx: Drop architecture dependencies

2015-10-22 Thread Soren Brinkmann
The driver does not have any real architecture dependencies. To avoid listing each architecture that might use this driver on some FPGA-enabled platform, drop these dependencies. Signed-off-by: Soren Brinkmann Acked-by: Moritz Fischer --- v2: - rebased --- drivers/gpio/Kconfig | 2 +- 1 file

[PATCH] gpio: xilinx: Drop architecture dependencies

2015-10-19 Thread Soren Brinkmann
The driver does not have any real architecture dependencies. To avoid listing each architecture that might use this driver on some FPGA-enabled platform, drop these dependencies. Signed-off-by: Soren Brinkmann --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH RFC] MAINTAINERS: Update Zynq git tree location

2015-06-26 Thread Soren Brinkmann
The git tree for Zynq moved to Github. Update the MAINTAINERS record to reflect the change. Signed-off-by: Soren Brinkmann --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a01df3088b01..f6b16941ae08 100644 --- a/MAINTAINERS

[PATCH] leds: leds-gpio: Pass on error codes unmodified

2015-01-31 Thread Soren Brinkmann
Instead of overriding error codes, pass them on unmodified. This way a EPROBE_DEFER is correctly passed to the driver core. This results in the LED driver correctly requesting probe deferral in cases the GPIO controller is not yet available. Signed-off-by: Soren Brinkmann --- Adding pinctrl on

[PATCH v2] clk: zynq: Force CPU_2X clock to be ungated

2015-01-27 Thread Soren Brinkmann
'clk: zynq: Add clock controller driver' Signed-off-by: Soren Brinkmann --- v2: - Fixed some typo's in the commit message - added Fixes and Cc tags to commit message As reference, the v1 submission: https://patchwork.kernel.org/patch/5698251/ --- drivers/clk/zynq/clkc.c | 1

[PATCH] usb: phy-generic: Don't fail on missing gpio reset

2015-01-26 Thread Soren Brinkmann
A reset through a GPIO is optional. Don't fail probing when it is missing. Reported-by: Andreas Färber Signed-off-by: Soren Brinkmann --- Hi Andreas, does this do the trick? Thanks, Sören drivers/usb/phy/phy-generic.c | 6 ++ 1 file changed, 2 insertions(+), 4 dele

[PATCH 1/2] ARM: zynq: Remove bogus value from 'bias-disable' property

2015-01-26 Thread Soren Brinkmann
In one pinctrl node, a 'bias-disable' property is erroneously assigned a value. Fixes: ARM: zynq: DT: Add pinctrl information Signed-off-by: Soren Brinkmann --- Feel free to squash this into the mentioned patch. I don't see it in any stable branch yet. Sören --- arch/ar

[PATCH 2/2] ARM: zynq: DT: Add pinctrl information to USB nodes

2015-01-26 Thread Soren Brinkmann
Signed-off-by: Soren Brinkmann --- Hi Michal, This could be squashed into 1643b31658c4 'ARM: zynq: DT: Add USB to device tree' if you decide to rebuild the zynq/dt branch. Sören --- arch/arm/boot/dts/zynq-zc702.dts | 26 ++ arch/arm/boot/dts/zynq-zc70

[PATCH] clk: zynq: Force CPU_2X clock to be ungated

2015-01-23 Thread Soren Brinkmann
The CPU_2X clock does not have a classical in kernel user, but is, amongst other things, required for OCM and debug access. Make sure this clock does not mistakenly disabled during boot up by enabling it in the platforms clock driver. Signed-off-by: Soren Brinkmann --- I just noticed this on

[PATCH v4] gpio: lib-sysfs: Add 'wakeup' attribute

2015-01-15 Thread Soren Brinkmann
that file will enable wake for that GPIO, while writing 'disabled' will disable wake. Reading that file will return either 'disabled' or 'enabled' depening on the currently set flag for the GPIO's IRQ. Signed-off-by: Soren Brinkmann Reviewed-by: Alexandre Courbo

[PATCH v4 2/7] pinctrl: pinconf-generic: Allow driver to specify DT params

2015-01-09 Thread Soren Brinkmann
ic parameters as well as the driver-specific ones. Signed-off-by: Soren Brinkmann Tested-by: Andreas Färber --- v2: - fix typo - add missing documentation for @conf_items member in struct - rebase to pinctrl/devel: conflict in abx500 - rename _pinconf_generic_dump() to pinconf_generic_dump_on

[PATCH v4 1/7] pinctrl: pinconf-generic: Infer map type from DT property

2015-01-09 Thread Soren Brinkmann
VALID is passed to the parsing function as type. Also, a new helper 'pinconf_generic_dt_node_to_map_all()' is introduced, which can be used by drivers as generic callback for dt_node_to_map() to leverage the new feature. Signed-off-by: Soren Brinkmann Tested-by: Andreas Färber --- Chan

[PATCH v4 5/7] ARM: zynq: Enable pinctrl

2015-01-09 Thread Soren Brinkmann
Select pinctrl and the Zynq pinctrl driver. Signed-off-by: Soren Brinkmann Tested-by: Andreas Färber --- Changes since RFC v2: - separate mach-zynq changes in their own patch --- arch/arm/mach-zynq/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-zynq/Kconfig b/arch

[PATCH v4 3/7] pinctrl: zynq: Document DT binding

2015-01-09 Thread Soren Brinkmann
Add documentation for the devicetree binding for the Zynq pincontroller. Signed-off-by: Soren Brinkmann Tested-by: Andreas Färber --- Changes since v1: - fix typo - add USB related documentation - remove 'pinctrl-' prefix for pinctrl sub-nodes - update documentation to enfo

[PATCH v4 6/7] ARM: zynq: DT: Add pinctrl information

2015-01-09 Thread Soren Brinkmann
Add pinctrl descriptions to the zc702 and zc706 device trees. Signed-off-by: Soren Brinkmann Tested-by: Andreas Färber --- Changes since v1: - remove 'pinctrl-' prefix for pinctrl sub-nodes - separate config and mux nodes Changes since RFC v2: - add pinconf properties to zc702

[PATCH v4 4/7] pinctrl: Add driver for Zynq

2015-01-09 Thread Soren Brinkmann
This adds a pin-control driver for Zynq. Signed-off-by: Soren Brinkmann Tested-by: Andreas Färber --- Changes since v2: - driver-specific DT properties are passed to the core in two arrays, one for the actual DT parsing one for the debugfs representation. Issue a compiler warning when the

[PATCH v4 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic

2015-01-09 Thread Soren Brinkmann
Instead of the driver caring about implementation details like device tree, just provide information about driver specific pinconf parameters to pinconf-generic which takes care of parsing the DT. Signed-off-by: Soren Brinkmann --- Changes since v2: - remove hyphens in 'pull-up-str

  1   2   3   4   5   >