On 2018/12/13 下午9:23, Johan Hovold wrote:
Hi Song,
Sorry about the late reply.
On Thu, Dec 06, 2018 at 02:02:21PM +0800, Song Qiang wrote:
On 12/5/18 11:17 PM, Anatolij Gustschin wrote:
Hi,
On Wed, 5 Dec 2018 22:10:40 +0800
Song Qiang songqiang1304...@gmail.com wrote:
...
I've
corresponding driver and check how did the manufacture do with it.
yours,
Song Qiang
.
- DRDY pin for data ready trigger.
- Both i2c and spi interface are supported.
- Both interrupt and polling measurement is supported, depends on if
the 'interrupts' in DT is declared.
Signed-off-by: Song Qiang
---
MAINTAINERS| 7 +
drivers/iio/ma
Signed-off-by: Song Qiang
Reviewed-by: Rob Herring
---
.../bindings/iio/magnetometer/pni,rm3100.txt | 20 +++
1 file changed, 20 insertions(+)
create mode 100644
Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt
diff --git a/Documentation/devicetree/bindings
Signed-off-by: Song Qiang
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 4b1a2a8fcc16..adcdf60124dd 100644
--- a
Hi,
The next 3 patches do the following:
- The first patch adds PNI Sensor Corporation to the vendor prefix list.
- The second patch adds devicetree binding for RM3100 magnetometer.
- The third patch adds the driver for RM3100 magnetometer.
-- Song Qiang
Changes in v6:
- Add data shift for
On 2018/11/4 上午1:19, Jonathan Cameron wrote:
On Fri, 2 Nov 2018 15:42:09 +0800
Song Qiang wrote:
...
+int rm3100_common_probe(struct device *dev, struct regmap *regmap, int irq)
+{
+ struct iio_dev *indio_dev;
+ struct rm3100_data *data;
+ unsigned int tmp;
+ int
On 2018/11/2 下午5:24, Jonathan Cameron wrote:
On Fri, 2 Nov 2018 15:55:27 +0800
Song Qiang wrote:
On 2018/10/21 下午10:14, Jonathan Cameron wrote:
On Thu, 18 Oct 2018 16:24:15 +0800
Song Qiang wrote:
...
+static irqreturn_t rm3100_trigger_handler(int irq, void *p)
+{
+ struct
On 2018/10/21 下午10:14, Jonathan Cameron wrote:
On Thu, 18 Oct 2018 16:24:15 +0800
Song Qiang wrote:
...
+static irqreturn_t rm3100_trigger_handler(int irq, void *p)
+{
+ struct iio_poll_func *pf = p;
+ struct iio_dev *indio_dev = pf->indio_dev;
+ unsigned long scan_m
.
- DRDY pin for data ready trigger.
- Both i2c and spi interface are supported.
- Both interrupt and polling measurement is supported, depends on if
the 'interrupts' in DT is declared.
Signed-off-by: Song Qiang
---
MAINTAINERS| 7 +
drivers/iio/ma
Hi,
The next 3 patches do the following:
- The first patch adds PNI Sensor Corporation to the vendor prefix list.
- The second patch adds devicetree binding for RM3100 magnetometer.
- The third patch adds the driver for RM3100 magnetometer.
-- Song Qiang
Changes in v5:
- Fix a bug about
Signed-off-by: Song Qiang
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 4b1a2a8fcc16..adcdf60124dd 100644
--- a
Signed-off-by: Song Qiang
Reviewed-by: Rob Herring
---
.../bindings/iio/magnetometer/pni,rm3100.txt | 20 +++
1 file changed, 20 insertions(+)
create mode 100644
Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt
diff --git a/Documentation/devicetree/bindings
On 2018/10/13 下午6:19, Jonathan Cameron wrote:
On Fri, 12 Oct 2018 15:35:36 +0800
Song Qiang wrote:
PNI RM3100 is a high resolution, large signal immunity magnetometer,
composed of 3 single sensors and a processing chip with a MagI2C
interface.
Following functions are available:
- Single
On 2018/10/12 下午8:53, Himanshu Jha wrote:
Hi Qiang,
On Fri, Oct 12, 2018 at 04:36:01PM +0800, Song Qiang wrote:
On 2018年10月12日 15:35, Song Qiang wrote:
PNI RM3100 is a high resolution, large signal immunity magnetometer,
composed of 3 single sensors and a processing chip with a MagI2C
On 2018年10月12日 15:35, Song Qiang wrote:
PNI RM3100 is a high resolution, large signal immunity magnetometer,
composed of 3 single sensors and a processing chip with a MagI2C
interface.
...
+static irqreturn_t rm3100_trigger_handler(int irq, void *p)
+{
+ struct iio_poll_func *pf = p
Signed-off-by: Song Qiang
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 41f0b97eb933..5b935f01e15b 100644
--- a
Hi,
The next 3 patches do the following:
- The first patch adds PNI Sensor Corporation to the vendor prefix list.
- The second patch adds devicetree binding for RM3100 magnetometer.
- The third patch adds the driver for RM3100 magnetometer.
-- Song Qiang
Changes in v4:
- Fix a bug about
Signed-off-by: Song Qiang
---
.../bindings/iio/magnetometer/pni,rm3100.txt | 20 +++
1 file changed, 20 insertions(+)
create mode 100644
Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt
diff --git a/Documentation/devicetree/bindings/iio/magnetometer/pni
.
- DRDY pin for data ready trigger.
- Both i2c and spi interface are supported.
- Both interrupt and polling measurement is supported, depends on if
the 'interrupts' in DT is declared.
Signed-off-by: Song Qiang
---
MAINTAINERS| 7 +
drivers/iio/ma
On 2018年10月07日 23:44, Jonathan Cameron wrote:
On Tue, 2 Oct 2018 22:38:12 +0800
Song Qiang wrote:
PNI RM3100 is a high resolution, large signal immunity magnetometer,
composed of 3 single sensors and a processing chip with a MagI2C
interface.
Following functions are available:
- Single
Signed-off-by: Song Qiang
---
.../bindings/iio/magnetometer/pni,rm3100.txt | 20 +++
1 file changed, 20 insertions(+)
create mode 100644
Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt
diff --git a/Documentation/devicetree/bindings/iio/magnetometer/pni
.
- Both i2c and spi interface are supported.
- Both interrupt and polling measurement is supported, depends on if
the 'interrupts' in DT is declared.
Signed-off-by: Song Qiang
---
MAINTAINERS| 7 +
drivers/iio/magnetometer/Kconfig | 29 ++
d
Signed-off-by: Song Qiang
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 41f0b97eb933..5b935f01e15b 100644
--- a
Hi,
The next 3 patches do the following:
- The first patch adds PNI Sensor Corporation to the vendor prefix list.
- The second patch adds devicetree binding for RM3100 magnetometer.
- The third patch adds the driver for RM3100 magnetometer.
-- Song Qiang
Changes in v3:
- Change PNI to PNI
On Fri, Sep 28, 2018 at 06:52:13PM -0500, Rob Herring wrote:
> On Fri, Sep 28, 2018 at 4:36 AM Song Qiang wrote:
> >
> > On Wed, Sep 26, 2018 at 05:46:18PM -0500, Rob Herring wrote:
> > > On Sat, Sep 22, 2018 at 04:05:23PM +0100, Jonathan Cameron wrote:
> > > >
On Wed, Sep 26, 2018 at 05:46:18PM -0500, Rob Herring wrote:
> On Sat, Sep 22, 2018 at 04:05:23PM +0100, Jonathan Cameron wrote:
> > On Tue, 18 Sep 2018 16:24:22 +0800
> > Song Qiang wrote:
> >
> > > The first version of this driver issues a measuring request
On Wed, Sep 26, 2018 at 10:30:34AM +0800, Phil Reid wrote:
> On 26/09/2018 9:49 AM, Song Qiang wrote:
> > On Tue, Sep 25, 2018 at 10:36:54PM +0800, Phil Reid wrote:
> > > On 25/09/2018 9:30 PM, Jonathan Cameron wrote:
> > > > > +static irqreturn_t rm3100
On Tue, Sep 25, 2018 at 11:20:18PM +0530, Himanshu Jha wrote:
> On Tue, Sep 25, 2018 at 11:17:24AM +0800, Song Qiang wrote:
> > PNI RM3100 is a high resolution, large signal immunity magnetometer,
> > composed of 3 single sensors and a processing chip with MagI2C Interface.
>
shuffle Z then Y.
> Do the unused bytes need to be zeroed? or does libiio mask them anyway?
>
>
>
> --
> Regards
> Phil Reid
Hi Phil,
This is interesting, last patch I submitted uses three transactions and
shuffles X, Y and Z respectively. You said it should be better to use one
transactions, I thought it makes point, and one transaction may reduce
IO pressure of the i2c bus. :)
And that's not necessary for unused bytes to be zero. I'm not familiar
with libiio, actually just been studying it, can't say anything about
it.
yours,
Song Qiang
On Tue, Sep 25, 2018 at 02:30:54PM +0100, Jonathan Cameron wrote:
> On Tue, 25 Sep 2018 11:17:24 +0800
> Song Qiang wrote:
>
> > PNI RM3100 is a high resolution, large signal immunity magnetometer,
> > composed of 3 single sensors and a processing chip with MagI2C Interfac
On Mon, Sep 24, 2018 at 03:23:52PM -0700, Rob Herring wrote:
> On Thu, Sep 20, 2018 at 09:13:40PM +0800, Song Qiang wrote:
> > PNI RM3100 magnetometer is a high resolution, large signal immunity
> > magnetometer, composed of 3 single sensors and a processing chip.
> > PNI is
PNI RM3100 is a high resolution, large signal immunity magnetometer,
composed of 3 single sensors and a processing chip with MagI2C Interface.
PNI is not in the vendors' list, so this patch is also adding it.
Signed-off-by: Song Qiang
---
Changes in v2:
- Remove bus specific pa
.
- Both i2c and spi interface are supported.
- Both interrupt and polling measurement is supported, depands on if
the 'interrupts' in DT is declared.
Signed-off-by: Song Qiang
---
Changes in v2:
- Add scale channel.
- Add EXPORT_SYMBOL_GPL() to export regmap con
On Sat, Sep 22, 2018 at 11:14:09AM +0100, Jonathan Cameron wrote:
> On Thu, 20 Sep 2018 21:13:40 +0800
> Song Qiang wrote:
>
> > PNI RM3100 magnetometer is a high resolution, large signal immunity
> > magnetometer, composed of 3 single sensors and a processing chip.
> &
On Sat, Sep 22, 2018 at 11:14:09AM +0100, Jonathan Cameron wrote:
> On Thu, 20 Sep 2018 21:13:40 +0800
> Song Qiang wrote:
>
...
> > +const struct regmap_access_table rm3100_volatile_table = {
> > + .yes_ranges = rm3100_volatile_ranges,
> > +
On Sat, Sep 22, 2018 at 03:46:58PM +0100, Jonathan Cameron wrote:
> On Tue, 18 Sep 2018 16:24:21 +0800
> Song Qiang wrote:
>
> > This driver was originally written by ST in 2016 as a misc input device
> > driver, and hasn't been maintained for a long time. I grabbed s
x27;, mostly because of this issue.
I googled this issue and someone on stack overflow said it's because
this kind of action will break the check mechanism of 'const'.
yours,
Song Qiang
> >
> > I love your patch! Perhaps something to improve:
> >
> > [auto
o/togreg]
> > [also build test ERROR on v4.19-rc4 next-20180920]
> > [if your patch is applied to the wrong git tree, please drop us a note to
> > help improve the system]
> >
> > url:
> > https://github.com/0day-ci/linux/commits/Song-Qiang/iio-mag
or common cases. If you are reading a 3 axis accelerometer for
> example with timestamp then you can probably safely prebake optimized handling
> for,
>
> 1B (x), 1B (y), 1B(z), 5B(pad), 8B(ts)
>
> 2B (x), 2B (y), 2B(z), 2B(pad), 8B(ts)
>
&
On Fri, Sep 21, 2018 at 01:07:17PM +0800, Phil Reid wrote:
> G'day Song,
>
> One more comment below.
> On 20/09/2018 9:46 PM, Peter Meerwald-Stadler wrote:
> > On Thu, 20 Sep 2018, Song Qiang wrote:
> >
> > > PNI RM3100 magnetometer is a high resolution, la
On Fri, Sep 21, 2018 at 10:05:38AM +0800, Phil Reid wrote:
> On 20/09/2018 9:13 PM, Song Qiang wrote:
> > PNI RM3100 magnetometer is a high resolution, large signal immunity
> > magnetometer, composed of 3 single sensors and a processing chip.
> > PNI is currently not in the
On Thu, Sep 20, 2018 at 03:46:03PM +0200, Peter Meerwald-Stadler wrote:
> On Thu, 20 Sep 2018, Song Qiang wrote:
>
> > PNI RM3100 magnetometer is a high resolution, large signal immunity
> > magnetometer, composed of 3 single sensors and a processing chip.
> > PNI is curr
Regmap tables are both defined in hmc5843_spi.c and hmc5843_i2c.c, while
the only difference between these two set of tables is SPI need a read
mask, which is set only in 'regmap_config' structrue. This patch moves
the other structrues into hmc5843_core.c to reduce redundance.
Signed-of
Replace 'hcm5843' with 'hmc5843'.
Signed-off-by: Song Qiang
---
drivers/iio/magnetometer/hmc5843.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/magnetometer/hmc5843.h
b/drivers/iio/magnetometer/hmc5843.h
index 76a5d7484d8d..a75224cf99df
This error apparently is caused by timed out event, so a -ETIMEDOUT
should be used instead of a -EIO, and it also tells user what happened
, so this dev_err may not be needed anymore.
Signed-off-by: Song Qiang
---
I used ./scripts/get_maintainer.pl to get maintainers about this file,
I thought
/iio:deviceX/in_magn_{axis}_raw
- Triggerd buffer measurement.
- Both i2c and spi interface are supported.
- Both interrupt and polling measurement is supported, depands on if
the 'interrupts' in DT is declared.
Signed-off-by: Song Qiang
---
.../bindings/iio/magnetometer/pni,rm3100.
measuring completes, so no irq line is needed.
It can be tested with reading from
/sys/bus/iio/devices/iio:deviceX/in_distance_input
Signed-off-by: Song Qiang
---
Changes in v6:
- Remove '.' in mail address. Google doesn't care, these two
email address
cpu cost.
Signed-off-by: Song Qiang
---
.../bindings/iio/proximity/vl53l0x.txt| 14 +-
drivers/iio/proximity/vl53l0x-i2c.c | 135 +++---
2 files changed, 129 insertions(+), 20 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/proximity/vl53l0x.txt
b
On Mon, Sep 17, 2018 at 09:25:21AM +0100, Jonathan Cameron wrote:
> On Sun, 16 Sep 2018 21:36:51 +0800
> Song Qiang wrote:
>
> > On Sun, Sep 16, 2018 at 12:01:49PM +0100, Jonathan Cameron wrote:
> > > On Sat, 15 Sep 2018 17:57:52 +0800
> > > Song Qiang wrote:
On Mon, Sep 17, 2018 at 02:19:33AM -0400, Rob Herring wrote:
> On Sat, Sep 15, 2018 at 05:57:52PM +0800, Song Qiang wrote:
> > This driver was originally written by ST in 2016 as a misc input device
> > driver, and hasn't been maintained for a long time. I grabbed some code
&
On Sun, Sep 16, 2018 at 12:01:49PM +0100, Jonathan Cameron wrote:
> On Sat, 15 Sep 2018 17:57:52 +0800
> Song Qiang wrote:
>
> > This driver was originally written by ST in 2016 as a misc input device
> > driver, and hasn't been maintained for a long time. I grabbed s
measuring completes, so no irq line is needed.
This version of driver supports only one-shot mode, and it can be
tested with reading from
/sys/bus/iio/devices/iio:deviceX/in_distance_raw
Signed-off-by: Song Qiang
---
Changes in v5:
- Correct some spell problems.
- Change tries-- to
On Sat, Sep 15, 2018 at 12:13:22AM +0530, Himanshu Jha wrote:
> Hi Song,
>
> On Thu, Sep 13, 2018 at 10:22:29AM +0800, Song Qiang wrote:
> > This driver was originally written by ST in 2016 as a misc input device
> > driver, and hasn't been maintained for a long time. I
On Thu, Sep 13, 2018 at 02:43:35PM -0700, Matt Ranostay wrote:
> On Wed, Sep 12, 2018 at 8:51 PM Song Qiang wrote:
> >
> > This driver tries to access a block of data on a i2c bus and it tries
> > to manually make a device command frame and a consecutively read frame,
>
ata()? The original code
is commented with something I'm not sure, but I think if it's a standard
SMBus, it should be able to use in here.
Hoping for someone to explain.
Signed-off-by: Song Qiang
---
.../iio/proximity/pulsedlight-lidar-lite-v2.c | 18 +-
1 file changed
measuring completes, so no irq line is needed.
This version of driver supports only one-shot mode, and it can be
tested with reading from
/sys/bus/iio/devices/iio:deviceX/in_distance_raw
Signed-off-by: Song Qiang
---
Changes in v2:
- Clean up the register table.
- Sort header files de
On Thu, Sep 13, 2018 at 12:05:51AM +0530, Himanshu Jha wrote:
> On Wed, Sep 12, 2018 at 10:20:34AM +0800, Song Qiang wrote:
> > This driver was originally written by ST in 2016 as a misc input device
> > driver, and hasn't been maintained for a long time. I grabbed some code
&
measuring completes, so no irq line is needed.
This version of driver supports only one-shot mode, and it can be
tested with reading from
/sys/bus/iio/devices/iio:deviceX/in_distance_raw
Signed-off-by: Song Qiang
---
Changes in v2:
- Clean up the register table.
- Sort header files de
On Tue, Sep 11, 2018 at 09:33:00PM +0530, Himanshu Jha wrote:
> Hi Song,
>
> On Tue, Sep 11, 2018 at 03:53:57PM +0800, Song Qiang wrote:
> > This driver was originally written by ST in 2016 as a misc input device
> > driver, and hasn't been maintained for a long time. I
regmap, err: %d\n", ret);
> + return ret;
> + }
> +
> + indio_dev->dev.parent = &client->dev;
> + indio_dev->channels = fxas21002c_channels;
> + indio_dev->num_channels = ARRAY_SIZE(fxas21002c_channels);
> + indio_dev->name =
measuring completes, so no irq line is needed.
This version of driver supports only one-shot mode, and it can be
tested with reading from
/sys/bus/iio/devices/iio:deviceX/in_distance_raw
Signed-off-by: Song Qiang
---
.../bindings/iio/proximity/vl53l0x.txt| 12 ++
drivers/iio/proximi
On Tue, Sep 11, 2018 at 12:58:20PM +0530, Himanshu Jha wrote:
> On Tue, Sep 11, 2018 at 02:46:38PM +0800, Song Qiang wrote:
> > On Mon, Sep 10, 2018 at 11:27:47PM +0530, Himanshu Jha wrote:
> > > On Mon, Sep 10, 2018 at 10:42:59PM +0800, Song Qiang wrote:
> > > > This
On Mon, Sep 10, 2018 at 11:27:47PM +0530, Himanshu Jha wrote:
> On Mon, Sep 10, 2018 at 10:42:59PM +0800, Song Qiang wrote:
> > This driver was originally written by ST in 2016 as a misc input device,
> > and hasn't been maintained for a long time. I grabbed some code f
On Mon, Sep 10, 2018 at 11:27:47PM +0530, Himanshu Jha wrote:
> On Mon, Sep 10, 2018 at 10:42:59PM +0800, Song Qiang wrote:
> > This driver was originally written by ST in 2016 as a misc input device,
> > and hasn't been maintained for a long time. I grabbed some code f
On Mon, Sep 10, 2018 at 11:27:47PM +0530, Himanshu Jha wrote:
> On Mon, Sep 10, 2018 at 10:42:59PM +0800, Song Qiang wrote:
> > This driver was originally written by ST in 2016 as a misc input device,
> > and hasn't been maintained for a long time. I grabbed some code f
On Mon, Sep 10, 2018 at 06:12:43PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 10, 2018 at 10:42:59PM +0800, Song Qiang wrote:
> > This driver was originally written by ST in 2016 as a misc input device,
> > and hasn't been maintained for a long time. I grabbed some code f
pletes, so no irq line is needed.
This version of driver supports only one-shot mode, and it can be
tested with reading from
/sys/bus/iio/devices/iio:deviceX/in_distance_raw
Signed-off-by: Song Qiang
---
.../bindings/iio/proximity/vl53l0x.txt| 12 +
drivers/iio/proximi
active high leds and "low" for active low leds.
The default value is "high" for compatible for the original driver.
Signed-off-by: Song Qiang
---
.../devicetree/bindings/leds/leds-gpio.txt| 15 +++
drivers/leds/leds-gpio.c | 25 +
69 matches
Mail list logo