Re: [PATCH] dt-bindings: Drop kernel copy of common reserved-memory bindings

2023-10-13 Thread Simon Glass
etree/bindings/reserved-memory/framebuffer.yaml > delete mode 100644 > Documentation/devicetree/bindings/reserved-memory/memory-region.yaml > delete mode 100644 > Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml > delete mode 100644 > Documentation/devicetree/bindings/reserved-memory/shared-dma-pool.yaml > Reviewed-by: Simon Glass

Re: [SPECIFICATION RFC] The firmware and bootloader log specification

2020-12-15 Thread Simon Glass
Hi Daniel, On Fri, 13 Nov 2020 at 19:07, Daniel Kiper wrote: > > Hey, > > This is next attempt to create firmware and bootloader log specification. > Due to high interest among industry it is an extension to the initial > bootloader log only specification. It takes into the account most of the >

Re: [PATCH 1/3] platform/chrome: cros_ec_spi: Don't overwrite spi::mode

2020-12-09 Thread Simon Glass
core > take care of it. > > Fixes: a17d94f0b6e1 ("mfd: Add ChromeOS EC SPI driver") > Cc: Simon Glass > Cc: Gwendal Grignou > Reviewed-by: Douglas Anderson > Tested-by: Douglas Anderson > Acked-by: Enric Balletbo i Serra > Cc: Alexandru M Stan > Signed-off-b

Re: [PATCH 2/3] platform/chrome: cros_ec_spi: Drop bits_per_word assignment

2020-12-09 Thread Simon Glass
On Fri, 4 Dec 2020 at 12:35, Stephen Boyd wrote: > > This is already handed by default in spi_setup() if the bits_per_word is > 0, so just drop it to shave off a line. > > Cc: Simon Glass > Cc: Gwendal Grignou > Reviewed-by: Douglas Anderson > Tested-by: Douglas And

Re: [PATCH v4 4/5] dm: pci: Assign controller device node to root bridge

2020-06-25 Thread Simon Glass
Hi Nicolas, On Wed, 17 Jun 2020 at 13:15, Nicolas Saenz Julienne wrote: > > On Tue, 2020-06-16 at 17:31 -0600, Simon Glass wrote: > > Hi Nicolas, > > > > On Tue, 16 Jun 2020 at 08:09, Nicolas Saenz Julienne > > wrote: > > > On Tue, 2020-06-16 at 07:

Re: [PATCH v4 4/5] dm: pci: Assign controller device node to root bridge

2020-06-16 Thread Simon Glass
Hi Nicolas, On Tue, 16 Jun 2020 at 08:09, Nicolas Saenz Julienne wrote: > > On Tue, 2020-06-16 at 07:43 -0600, Simon Glass wrote: > > Hi Nicolas, > > > > On Fri, 12 Jun 2020 at 10:47, Nicolas Saenz Julienne > > wrote: > > > There is no distinction in DT be

Re: [PATCH v4 4/5] dm: pci: Assign controller device node to root bridge

2020-06-16 Thread Simon Glass
Hi Nicolas, On Fri, 12 Jun 2020 at 10:47, Nicolas Saenz Julienne wrote: > > There is no distinction in DT between the PCI controller device and the > root bridge, whereas such distinction exists from dm's perspective. Make > sure the root bridge ofnode is assigned to the controller's platform > d

Re: [PATCH v3] patman: Use the Change-Id, version, and prefix in the Message-Id

2019-09-29 Thread Simon Glass
On Fri, 27 Sep 2019 at 10:25, Douglas Anderson wrote: > > As per the centithread on ksummit-discuss [1], there are folks who > feel that if a Change-Id is present in a developer's local commit that > said Change-Id could be interesting to include in upstream posts. > Specifically if two commits ar

Re: [PATCH] RFC: Example schema files written in Python

2019-05-20 Thread Simon Glass
Hi Rob, On Wed, 8 May 2019 at 13:21, Rob Herring wrote: > > On Mon, Apr 29, 2019 at 5:41 PM Simon Glass wrote: > > > > Most of these are hand-written, but xilinx-xadc.py is auto-generated by > > binding_to_py.py as an example of the use of that tool. > > > >

[PATCH] RFC: Example schema files written in Python

2019-04-29 Thread Simon Glass
: Simon Glass --- Documentation/__init__.py | 0 Documentation/devicetree/__init__.py | 0 Documentation/devicetree/bindings/__init__.py | 0 .../devicetree/bindings/arm/__init__.py | 0 Documentation/devicetree/bindings/arm/cpus.py | 125

Re: [PATCH] firmware: dmi: Add access to the SKU ID string

2018-04-27 Thread Simon Glass
Hi Jean, On 27 April 2018 at 01:58, Jean Delvare wrote: > Hi Simon, > > On Tue, 24 Apr 2018 15:11:11 -0600, Simon Glass wrote: >> This is used in some systems from user space for determining the identity >> of the device. >> >> Expose this as a file so that th

Re: [PATCH] firmware: dmi: Add access to the SKU ID string

2018-04-25 Thread Simon Glass
Hi Vinod, On 24 April 2018 at 20:51, Vinod Koul wrote: > On Tue, Apr 24, 2018 at 03:11:11PM -0600, Simon Glass wrote: >> This is used in some systems from user space for determining the identity >> of the device. >> >> Expose this as a file so that that user-spa

[PATCH] firmware: dmi: Add access to the SKU ID string

2018-04-24 Thread Simon Glass
This is used in some systems from user space for determining the identity of the device. Expose this as a file so that that user-space tools don't need to read from /sys/firmware/dmi/tables/DMI Signed-off-by: Simon Glass --- drivers/firmware/dmi-id.c | 2 ++ drivers/firmware/dmi_s

Re: [PATCH v3 02/10] video: add support of MIPI DSI interface

2018-03-13 Thread Simon Glass
Hi, On 13 March 2018 at 07:50, yannick fertre wrote: > > Mipi_display.c contains a set of dsi helpers. > This file is a copy of file drm_mipi_dsi.c (linux kernel). > > Signed-off-by: yannick fertre > --- > drivers/video/Kconfig| 7 + > drivers/video/Makefile | 1 + > drivers/v

Re: [PATCH v2 00/10] splash screen on the stm32f769 disco board

2018-03-06 Thread Simon Glass
On 2 March 2018 at 08:44, yannick fertre wrote: > > Version 2: > - Replace debug log by pr_error, pr_warn or pr_info. > - Rework bridge between ltdc & dsi panel > - Rework backligh management (with or witout gpio) > - Rework panel otm8009a > - Add new panel raydium rm68200 > > Version 1: > - Initi

Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

2016-10-03 Thread Simon Glass
HI Matt, On 16 August 2016 at 20:25, Matt Mullins wrote: > On Tue, Aug 16, 2016 at 12:19:42PM -0700, Yinghai Lu wrote: >> On Mon, Aug 15, 2016 at 9:01 PM, Matt Mullins wrote: >> > >> > This appears to have a negative effect on booting the Intel Edison >> > platform, as >> > it uses u-boot as it

Re: [ANNOUNCE] git-series: track changes to a patch series over time

2016-08-15 Thread Simon Glass
Hi Josh, On 1 August 2016 at 12:37, Josh Triplett wrote: > On Mon, Aug 01, 2016 at 09:14:54AM -0600, Stephen Warren wrote: >> On 07/29/2016 12:40 AM, Josh Triplett wrote: >> > I'd like to announce a project I've been working on for a while: >> > >> > git-series provides a tool for managing patch

Re: [PATCH] arm: rpi: Device tree modifications for U-Boot

2015-09-09 Thread Simon Glass
Hi, On Friday, 28 August 2015, Simon Glass wrote: > > Hi Rob, > > On 25 August 2015 at 10:22, Rob Herring wrote: > > On Sat, Aug 15, 2015 at 8:46 AM, Simon Glass wrote: > >> Hi Rob, > >> > >> On 14 August 2015 at 14:29, Rob Herring wrote: >

Re: set rockchip-specific uboot bootmode flags on reboot (was: [PATCH] ARM: rockchip: add reboot notifier)

2015-09-09 Thread Simon Glass
Hi, On 8 September 2015 at 16:46, Heiko Stübner wrote: > > Hi Andy, > > Am Dienstag, 8. September 2015, 20:43:07 schrieb Andy Yan: > > rockchip platform have a protocol to pass the the kernel > > reboot mode to bootloader by some special registers when > > system reboot.By this way the bootloader

Re: [PATCH] arm: rpi: Device tree modifications for U-Boot

2015-08-28 Thread Simon Glass
Hi Rob, On 25 August 2015 at 10:22, Rob Herring wrote: > On Sat, Aug 15, 2015 at 8:46 AM, Simon Glass wrote: >> Hi Rob, >> >> On 14 August 2015 at 14:29, Rob Herring wrote: >>> On Fri, Aug 14, 2015 at 1:34 PM, Simon Glass wrote: >>>> -linux-tegra &g

Re: [PATCH] arm: rpi: Device tree modifications for U-Boot

2015-08-15 Thread Simon Glass
Hi Stephen, On 14 August 2015 at 21:46, Stephen Warren wrote: > On 08/12/2015 07:21 AM, Simon Glass wrote: >> Hi Lucas, >> >> On 11 August 2015 at 11:05, Lucas Stach wrote: >>> Hi Simon, >>> >>> why did you send this to the Tegra ML? >>

Re: [PATCH] arm: rpi: Device tree modifications for U-Boot

2015-08-15 Thread Simon Glass
Hi Rob, On 14 August 2015 at 14:29, Rob Herring wrote: > On Fri, Aug 14, 2015 at 1:34 PM, Simon Glass wrote: >> -linux-tegra >> >> Hi, >> >> On 12 August 2015 at 07:21, Simon Glass wrote: >>> Hi Lucas, >>> >>> On 11 August 2015 at 11:

Re: [PATCH] arm: rpi: Device tree modifications for U-Boot

2015-08-14 Thread Simon Glass
-linux-tegra Hi, On 12 August 2015 at 07:21, Simon Glass wrote: > Hi Lucas, > > On 11 August 2015 at 11:05, Lucas Stach wrote: >> Hi Simon, >> >> why did you send this to the Tegra ML? >> >> Am Dienstag, den 11.08.2015, 08:25 -0600 schrieb Simon Glass: &g

Re: [PATCH] arm: rpi: Device tree modifications for U-Boot

2015-08-12 Thread Simon Glass
Hi Lucas, On 11 August 2015 at 11:05, Lucas Stach wrote: > Hi Simon, > > why did you send this to the Tegra ML? > > Am Dienstag, den 11.08.2015, 08:25 -0600 schrieb Simon Glass: >> This updates the device tree from the kernel version to something suitable >> for U-Bo

[PATCH] arm: rpi: Device tree modifications for U-Boot

2015-08-11 Thread Simon Glass
This updates the device tree from the kernel version to something suitable for U-Boot: - Add stdout-path alias for console - Mark the /soc node to be available pre-relocation so that the early serial console works (we need the 'ranges' property to be available) Signed-off-by: S

[PATCH] ARM: tegra: Enable TPM on tegra124 nyan boards

2015-05-13 Thread Simon Glass
Regenerate the pinmux from the latest tegra-pinmux-scripts. Signed-off-by: Simon Glass --- arch/arm/boot/dts/tegra124-nyan-big.dts | 22 +++--- arch/arm/boot/dts/tegra124-nyan-blaze.dts | 30 +++--- 2 files changed, 26 insertions(+), 26 deletions

[pinmux scripts PATCH] Support TPM on nyan boards

2015-05-13 Thread Simon Glass
There is a TPM on I2C3, so set up the pinmux for that. Signed-off-by: Simon Glass --- configs/nyan-big.board | 4 ++-- configs/nyan-blaze.board | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configs/nyan-big.board b/configs/nyan-big.board index 6ebe466..18c2e52

Re: [PATCH 1/3] Add patman patch automation script

2015-05-03 Thread Simon Glass
Hi Richard, On 3 May 2015 at 14:43, Richard Weinberger wrote: > Am 03.05.2015 um 22:40 schrieb Simon Glass: >>> But I don't think it makes much sense to carry it with the Linux kernel >>> tree. >>> Other projects can also use it and it does not seem to be very

Re: [PATCH 1/3] Add patman patch automation script

2015-05-03 Thread Simon Glass
Hi Richard, On 3 May 2015 at 14:13, Richard Weinberger wrote: > Simon, > > Am 03.05.2015 um 21:54 schrieb Simon Glass: >> Hi Richard, >> >> On 3 May 2015 at 13:16, Richard Weinberger >> wrote: >>> On Sun, May 3, 2015 at 8:29 PM, Simon Glass wrot

Re: [PATCH 1/3] Add patman patch automation script

2015-05-03 Thread Simon Glass
Hi Richard, On 3 May 2015 at 13:16, Richard Weinberger wrote: > On Sun, May 3, 2015 at 8:29 PM, Simon Glass wrote: >> This tool is a Python script which: >> - Creates patch directly from your branch >> - Cleans them up by removing unwanted tags >> - Inserts a cov

[PATCH 0/3] Add a tool to simplify patch checking and posting (patman)

2015-05-03 Thread Simon Glass
get_maintainer.pl on each of your patches automatically (unless you use -m to disable this). I am submitting this to LKML to raise awareness, since those who are not involved in U-Boot probably don't know about it. I could not find a specific linux-tools list but may have missed something. Simon Gla

[PATCH 3/3] Add documentation for patman

2015-05-03 Thread Simon Glass
Add an entry to the MAINTAINERS file, plus a README which explains how to use patman. Signed-off-by: Simon Glass --- MAINTAINERS | 5 + tools/patman/README | 475 2 files changed, 480 insertions(+) create mode 100644 tools/patman

[PATCH 1/3] Add patman patch automation script

2015-05-03 Thread Simon Glass
code, excluding tests and documentation. Signed-off-by: Simon Glass --- tools/patman/.gitignore | 1 + tools/patman/checkpatch.py | 173 tools/patman/command.py | 123 + tools/patman/commit.py | 88 ++ tools/patman/cros_subprocess.py

[PATCH 2/3] Add tests for patman

2015-05-03 Thread Simon Glass
Add some simple tests which can be run with the '--test' option. Signed-off-by: Simon Glass --- tools/patman/test.py | 243 +++ 1 file changed, 243 insertions(+) create mode 100644 tools/patman/test.py diff --git a/tools/patman/test.

Re: [PATCH v5 09/11] drm/tegra: Reset the SOR on probe

2015-03-02 Thread Simon Glass
Hi, On 2 March 2015 at 01:41, Alexandre Courbot wrote: > > On Thu, Feb 12, 2015 at 5:51 PM, Tomeu Vizoso > wrote: > > As there isn't a way for the firmware on the Nyan chromebooks to hand > > over the display to the kernel. > > Could this have a side-effect on models for which the firmware *does

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-26 Thread Simon Glass
Hi Olof, On 25 February 2015 at 17:59, Olof Johansson wrote: > On Tue, Feb 17, 2015 at 07:26:50PM -0700, Simon Glass wrote: >> Hi, >> >> On 16 February 2015 at 01:19, Javier Martinez Canillas >> wrote: >> > Hello Olof, >> > >> >

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-17 Thread Simon Glass
Hi, On 16 February 2015 at 01:19, Javier Martinez Canillas wrote: > Hello Olof, > > On 02/02/2015 12:26 PM, Javier Martinez Canillas wrote: >> Hello, >> >> The mainline ChromeOS Embedded Controller (EC) driver is still missing some >> features that are present in the downstream ChromiumOS tree. T

Re: [PATCH 2/3] mfd: cros_ec: Use the proper size when looking at the cros_ec_i2c result

2014-06-30 Thread Simon Glass
sure we take the lesser of the two of those. We'll > also complain if the EC tried to send us too many bytes. The EC > sending us too few bytes is legit for when we send the EC an invalid > command. > > This is based on similar code in cros_ec_spi. > > Signed-off-by: Doug

Re: [PATCH] i2c: cros_ec: Remove EC_I2C_FLAG_10BIT

2014-06-24 Thread Simon Glass
d-off-by: Doug Anderson Funny. We certainly don't use it. Reviewed-by: Simon Glass Regards, Simon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 10/10] mfd: cros_ec: move EC interrupt to cros_ec_keyb

2014-06-19 Thread Simon Glass
ver. > > Signed-off-by: Andrew Bresticker > Signed-off-by: Doug Anderson Reviewed-by: Simon Glass We never needed an EC-level interrupt, and have shipped at least three products now that use this code, so I think it is safe enough to declare that we won't need it. Regards, Simon --

Re: [PATCH v2 08/10] mfd: cros_ec: Check result code from EC messages

2014-06-19 Thread Simon Glass
t; This change lets the EC report its errors separately. > > [dianders: Added common function to cros_ec.c] > > Signed-off-by: Bill Richardson > Signed-off-by: Doug Anderson This is better. Reviewed-by: Simon Glass -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH v2 05/10] mfd: cros_ec: Use struct cros_ec_command to communicate with the EC

2014-06-19 Thread Simon Glass
dson > Signed-off-by: Doug Anderson > Acked-by: Lee Jones Reviewed-by: Simon Glass -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

Re: [PATCH 10/10] mfd: cros_ec: ec_dev->cmd_xfer() returns number of bytes received from EC

2014-06-17 Thread Simon Glass
Hi Doug, On 17 June 2014 21:54, Doug Anderson wrote: > Simon, > > On Tue, Jun 17, 2014 at 8:46 PM, Simon Glass wrote: >> Hi, >> >> On 16 June 2014 14:40, Doug Anderson wrote: >>> From: Bill Richardson >>> >>> When communicating with the EC

Re: [PATCH 08/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-17 Thread Simon Glass
Hi Doug, On 17 June 2014 21:27, Doug Anderson wrote: > Simon, > > On Tue, Jun 17, 2014 at 8:42 PM, Simon Glass wrote: >>> diff --git a/drivers/input/keyboard/cros_ec_keyb.c >>> b/drivers/input/keyboard/cros_ec_keyb.c >>> index 4083796..dc37b6b 100

Re: [PATCH 07/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-06-17 Thread Simon Glass
Hi Doug, On 17 June 2014 21:22, Doug Anderson wrote: > > Simon, > > On Tue, Jun 17, 2014 at 8:39 PM, Simon Glass wrote: > > Hi Doug, > > > > On 16 June 2014 14:39, Doug Anderson wrote: > >> From: Bill Richardson > >> > >> struct cros

Re: [PATCH 10/10] mfd: cros_ec: ec_dev->cmd_xfer() returns number of bytes received from EC

2014-06-17 Thread Simon Glass
Hi, On 16 June 2014 14:40, Doug Anderson wrote: > From: Bill Richardson > > When communicating with the EC, the cmd_xfer() function should return the > number of bytes it received from the EC, or negative on error. This is just for the I2C tunnel feature, right? If so, I think this should be me

Re: [PATCH 09/10] mfd: cros_ec: Check result code from EC messages

2014-06-17 Thread Simon Glass
Hi Doug, On 16 June 2014 14:39, Doug Anderson wrote: > From: Bill Richardson > > Just because the host was able to talk to the EC doesn't mean that the EC > was happy with what it was told. Errors in communincation are not the same > as error messages from the EC itself. > > This change lets the

Re: [PATCH 08/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-17 Thread Simon Glass
Hi Doug, On 16 June 2014 14:39, Doug Anderson wrote: > From: Bill Richardson > > Remove the three wrapper functions that talk to the EC without passing all > the desired arguments and just use the underlying communication function > that passes everything in a struct intead. > > This is internal

Re: [PATCH 07/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-06-17 Thread Simon Glass
eld. Except that it no longer prints I2C/SPI - i.e. the transport that is used. Is that not considered important? Anyway: Reviewed-by: Simon Glass Regards, Simon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger

Re: [PATCH 04/10] mfd: cros_ec: Tweak struct cros_ec_device for clarity

2014-06-17 Thread Simon Glass
Hi Doug, On 16 June 2014 14:39, Doug Anderson wrote: > From: Bill Richardson > > The members of struct cros_ec_device were improperly commented, and > intermixed the private and public sections. This is just cleanup to make it > more obvious what goes with what. > > [dianders: left lock in the s

Re: [PATCH 03/10] mfd: cros_ec: Allow static din/dout buffers with cros_ec_register()

2014-06-17 Thread Simon Glass
, but > it's good to document it. > > [dianders: Resolved conflicts; documented that no code changes needed > on mainline] > > Signed-off-by: Bill Richardson > Signed-off-by: Doug Anderson Reviewed-by: Simon Glass -- To unsubscribe from this list: send the line "un

Re: [PATCH 02/10] mfd: cros_ec: IRQs for cros_ec should be optional

2014-06-17 Thread Simon Glass
On 16 June 2014 14:39, Doug Anderson wrote: > From: Bill Richardson > > Preparing the way for the LPC device, which is just a plaform_device without > interrupts. > > Signed-off-by: Bill Richardson > Signed-off-by: Doug Anderson Reviewed-by: Simon Glass -- To unsubscribe

Re: [PATCH 2/7] mfd: cros_ec: spi: Add mutex to cros_ec_spi

2014-04-18 Thread Simon Glass
Hi Doug, On 18 April 2014 15:15, Doug Anderson wrote: > > Simon, > > On Fri, Apr 18, 2014 at 10:28 AM, Simon Glass wrote: > > Hi Doug, > > > > On 17 April 2014 11:59, Doug Anderson wrote: > >> The main transfer function for cros_ec_spi can be called

Re: [PATCH 4/7] mfd: cros_ec: spi: Increase cros_ec_spi deadline from 5ms to 100ms

2014-04-18 Thread Simon Glass
C protocol should be changed on future platforms to poll for completion of I2C, but in the meantime this patch prevents failure. Reviewed-by: Simon Glass -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

Re: [PATCH 1/7] mfd: cros_ec: spi: calculate delay between transfers correctly

2014-04-18 Thread Simon Glass
he delay period to be > far too short. Most noticably this impacts commands with a long > turnaround time such as EC firmware reads and writes. > > Signed-off-by: David Hendricks > Signed-off-by: Doug Anderson Reviewed-by: Simon Glass -- To unsubscribe from this list: send the li

Re: [PATCH 5/7] mfd: cros_ec: Sync to the latest cros_ec_commands.h from EC sources

2014-04-18 Thread Simon Glass
; > > [dianders: took today's ToT version from the Chromium OS EC; deleted > references to cros_ec_dev and cros_ec_lpc since those aren't upstream > yet] > > Signed-off-by: Bill Richardson > Signed-off-by: Doug Anderson Reviewed-by: Simon Glass -- To unsubscribe fro

Re: [PATCH 2/7] mfd: cros_ec: spi: Add mutex to cros_ec_spi

2014-04-18 Thread Simon Glass
Hi Doug, On 17 April 2014 11:59, Doug Anderson wrote: > The main transfer function for cros_ec_spi can be called by more than > one client at a time. Make sure that those clients don't stomp on > each other by locking the bus for the duration of the transfer > function. Is there no lock at the

Re: [PATCH 3/7] mfd: cros_ec: spi: Make the cros_ec_spi timeout more reliable

2014-04-18 Thread Simon Glass
et a timeout after a single loop. Let's be paranoid and >make sure we do one last transfer after the timeout expires. > > Signed-off-by: Doug Anderson Reviewed-by: Simon Glass -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH v2 5/5] regulator: tps65090: Make FETs more reliable by adding retries

2014-04-16 Thread Simon Glass
Hi Doug, On 16 April 2014 15:25, Doug Anderson wrote: > Simon, > > On Wed, Apr 16, 2014 at 1:50 PM, Simon Glass wrote: >>> +#define MAX_CTRL_READ_TRIES5 >>> +#define MAX_FET_ENABLE_TRIES 1000 >> >> Gosh that is a lot of tries - should we maybe give

Re: [PATCH v2 5/5] regulator: tps65090: Make FETs more reliable by adding retries

2014-04-16 Thread Simon Glass
> > Signed-off-by: Doug Anderson > Signed-off-by: Simon Glass > Signed-off-by: Michael Spang > Signed-off-by: Sean Paul > --- > Changes in v2: > - Separated the overcurrent and retries changes into two patches. > - No longer open code fet_is_enabled(). > - Fixed tp

Re: [RESEND] spi/tegra114: Correct support for cs_change

2013-09-23 Thread Simon Glass
[trying again] Hi, On Mon, Sep 23, 2013 at 3:14 PM, Stephen Warren wrote: > On 09/23/2013 03:01 PM, Rhyland Klein wrote: >> On 9/23/2013 3:58 PM, Stephen Warren wrote: >>> On 09/23/2013 01:48 PM, Rhyland Klein wrote: On 9/23/2013 2:51 PM, Stephen Warren wrote: > On 09/18/2013 12:17 PM,

Re: [PATCH] input: cros_ec_keyb_clear_keyboard() depends on CONFIG_PM_SLEEP

2013-05-08 Thread Simon Glass
ion > protected by #ifdef CONFIG_PM_SLEEP to fix this. > > Signed-off-by: Geert Uytterhoeven Acked-by: Simon Glass -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [PATCH] mfd: ChromeOS EC - Spelling s/ned/need/

2013-05-06 Thread Simon Glass
On Mon, May 6, 2013 at 1:46 AM, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven Acked-by: Simon Glass > --- > drivers/mfd/Kconfig |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v8 0/3] Runtime Interpreted Power Sequences

2013-04-26 Thread Simon Glass
Hi, On Thu, Nov 15, 2012 at 10:38 PM, Alexandre Courbot wrote: > Hopefully the final series before the feature gets merged. Anton Vorontsov > kindly accepted to take it into his tree, so this series is mostly a call for > acks, tests and reviews notices before the merge window for 3.8 opens. If y

Re: [PATCH] input: Export matrix_keypad_parse_of_params()

2013-04-17 Thread Simon Glass
ut/keyboard/cros_ec_keyb.ko] undefined! > > Reported-by: Randy Dunlap > Acked-by: Dmitry Torokhov > Signed-off-by: Michal Marek Acked-by: Simon Glass -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vg

Re: [patch] drivers, mfd: fix link error

2013-03-21 Thread Simon Glass
;mfd_add_devices" [drivers/mfd/cros_ec.ko] undefined! > > Fix it by selecting CONFIG_MFD_CORE anytime CONFIG_MFD_CROS_EC is enabled. > > Signed-off-by: David Rientjes Take 2 Acked-by: Simon Glass > --- > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support

2013-03-20 Thread Simon Glass
Hi Samuel, On Wed, Mar 20, 2013 at 1:52 AM, Samuel Ortiz wrote: > Hi Simon, > > On Wed, Mar 20, 2013 at 09:14:56AM +0100, Samuel Ortiz wrote: >> On Tue, Mar 19, 2013 at 07:01:42PM -0700, Simon Glass wrote: >> > Hi Samuel, >> > >> > On Tue, Mar 19,

Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support

2013-03-19 Thread Simon Glass
Hi Samuel, On Tue, Mar 19, 2013 at 6:12 PM, Samuel Ortiz wrote: > On Wed, Mar 20, 2013 at 01:56:52AM +0100, Samuel Ortiz wrote: >> Hi Simon, >> >> On Mon, Feb 25, 2013 at 02:08:35PM -0800, Simon Glass wrote: >> > The ChromeOS Embedded Controller (EC) is an Open Sour

Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support

2013-03-18 Thread Simon Glass
Hi Samuel, On Wed, Feb 27, 2013 at 12:40 AM, Samuel Ortiz wrote: > Hi Simon, > > On Tue, Feb 26, 2013 at 09:13:06PM -0800, Simon Glass wrote: >> Hi Samuel, >> >> On Mon, Feb 25, 2013 at 2:08 PM, Simon Glass wrote: >> > The ChromeOS Embedded Controller (EC)

Re: [PATCH] i2c: exynos5: add High Speed I2C controller driver

2013-03-12 Thread Simon Glass
[please excuse my mailer html confusion] Hi Naveen, On Mon, Mar 11, 2013 at 9:32 PM, Naveen Krishna Chatradhi wrote: > > Adds support for High Speed I2C driver found in Exynos5 and later > SoCs from Samsung. This driver currently supports Auto mode. > > Driver only supports Device Tree method. >

Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support

2013-02-27 Thread Simon Glass
Hi Samuel, On Wed, Feb 27, 2013 at 12:40 AM, Samuel Ortiz wrote: > Hi Simon, > > On Tue, Feb 26, 2013 at 09:13:06PM -0800, Simon Glass wrote: >> Hi Samuel, >> >> On Mon, Feb 25, 2013 at 2:08 PM, Simon Glass wrote: >> > The ChromeOS Embedded Controller (EC)

Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support

2013-02-26 Thread Simon Glass
Hi Samuel, On Mon, Feb 25, 2013 at 2:08 PM, Simon Glass wrote: > The ChromeOS Embedded Controller (EC) is an Open Source EC implementation > used on ARM and Intel Chromebooks. Current implementations use a Cortex-M3 > connected on a bus (such as I2C, SPI, LPC) to the AP. A separate

[PATCH v6 5/6] Input: matrix-keymap: Add function to read the new DT binding

2013-02-25 Thread Simon Glass
-GPIO drivers to use to decode the binding. Note: We could in fact create an entirely separate structure to hold these two fields, but it does not seem worth it, yet. If we have more parameters then we can add this, and then refactor each driver to hold such a structure. Signed-off-by: Simon Glass

[PATCH v6 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-25 Thread Simon Glass
-off-by: Simon Glass Signed-off-by: Luigi Semenzato Signed-off-by: Vincent Palatin --- Changes in v6: - Fix incorrect indentation in cros_ec_keyb_process() - Remove unnecessary assignment to NULL in probe function Changes in v5: - Fix {} style nit in cros_ec_keyb_has_ghosting - Correct key lookup

[PATCH v6 4/6] mfd: Add ChromeOS EC SPI driver

2013-02-25 Thread Simon Glass
This uses a SPI bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass --- Changes in v6: None Changes in v5: - Switch cros_ec_spi

[PATCH v6 2/6] mfd: Add ChromeOS EC implementation

2013-02-25 Thread Simon Glass
structure is used to pass messages to the protocol driver. Signed-off-by: Simon Glass Signed-off-by: Che-Liang Chiou Signed-off-by: Jonathan Kliegman Signed-off-by: Luigi Semenzato Signed-off-by: Olof Johansson Signed-off-by: Vincent Palatin --- Changes in v6: - Allow cros_ec to be a module

[PATCH v6 3/6] mfd: Add ChromeOS EC I2C driver

2013-02-25 Thread Simon Glass
This uses an I2C bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass Signed-off-by: Che-Liang Chiou --- Changes in v6: - Use %ph

[PATCH v6 1/6] mfd: Add ChromeOS EC messages header

2013-02-25 Thread Simon Glass
This file is included verbatim from the ChromeOS EC respository. Ideally we would prefer to avoid changing it, to make it easier to track this rapidly-changing file. Signed-off-by: Simon Glass Signed-off-by: Che-Liang Chiou Signed-off-by: Vincent Palatin --- Changes in v6: None Changes in v5

[PATCH v6 0/6] Add ChromeOS Embedded Controller support

2013-02-25 Thread Simon Glass
on to read matrix-keypad parameters from DT - Remove key autorepeat parameters from DT binding and driver - Use unsigned int for rows/cols Simon Glass (6): mfd: Add ChromeOS EC messages header mfd: Add ChromeOS EC implementation mfd: Add ChromeOS EC I2C driver mfd: Add ChromeOS EC SPI driver Inp

Re: [PATCH v5 5/6] Input: matrix-keymap: Add function to read the new DT binding

2013-02-25 Thread Simon Glass
Hi Dmitry, On Wed, Feb 20, 2013 at 10:18 AM, Dmitry Torokhov wrote: > On Wed, Feb 20, 2013 at 09:24:38AM -0800, Simon Glass wrote: >> We now have a binding which adds two parameters to the matrix keypad DT >> node. This is separate from the GPIO-driven matrix keypad binding, and &

[PATCH v5 0/6] Add ChromeOS Embedded Controller support

2013-02-20 Thread Simon Glass
use of __devinit/__devexit - Use function to read matrix-keypad parameters from DT - Remove key autorepeat parameters from DT binding and driver - Use unsigned int for rows/cols Simon Glass (6): mfd: Add ChromeOS EC messages header mfd: Add ChromeOS EC implementation mfd: Add ChromeOS EC I2C

[PATCH v5 1/6] mfd: Add ChromeOS EC messages header

2013-02-20 Thread Simon Glass
This file is included verbatim from the ChromeOS EC respository. Ideally we would prefer to avoid changing it, to make it easier to track this rapidly-changing file. Signed-off-by: Simon Glass Signed-off-by: Che-Liang Chiou Signed-off-by: Vincent Palatin --- Changes in v5: None Changes in v4

[PATCH v5 5/6] Input: matrix-keymap: Add function to read the new DT binding

2013-02-20 Thread Simon Glass
-GPIO drivers to use to decode the binding. Note: We could in fact create an entirely separate structure to hold these two fields, but it does not seem worth it, yet. If we have more parameters then we can add this, and then refactor each driver to hold such a structure. Signed-off-by: Simon Glass

[PATCH v5 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-20 Thread Simon Glass
-off-by: Simon Glass Signed-off-by: Luigi Semenzato Signed-off-by: Vincent Palatin --- Changes in v5: - Fix {} style nit in cros_ec_keyb_has_ghosting - Correct key lookup logic which was broken in previous version - Switch cros_ec_keyb driver to use devm Changes in v4: - Add 'depen

[PATCH v5 3/6] mfd: Add ChromeOS EC I2C driver

2013-02-20 Thread Simon Glass
This uses an I2C bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass Signed-off-by: Che-Liang Chiou --- Changes in v5: - Fix

[PATCH v5 4/6] mfd: Add ChromeOS EC SPI driver

2013-02-20 Thread Simon Glass
This uses a SPI bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass --- Changes in v5: - Switch cros_ec_spi driver to use devm

[PATCH v5 2/6] mfd: Add ChromeOS EC implementation

2013-02-20 Thread Simon Glass
structure is used to pass messages to the protocol driver. Signed-off-by: Simon Glass Signed-off-by: Che-Liang Chiou Signed-off-by: Jonathan Kliegman Signed-off-by: Luigi Semenzato Signed-off-by: Olof Johansson Signed-off-by: Vincent Palatin --- Changes in v5: - Remove cros_ec allocation

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-19 Thread Simon Glass
Hi, On Tue, Feb 19, 2013 at 12:36 AM, li guang wrote: > 在 2013-02-15五的 20:16 -0800,Simon Glass写道: >> Use the key-matrix layer to interpret key scan information from the EC >> and inject input based on the FDT-supplied key map. This driver registers >> itself with the

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-18 Thread Simon Glass
Hi Dmitry, On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov wrote: > Hi Simon, > > On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: >> + for (row = 0; row < ckdev->rows; row++) { >> + if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row)) >

Re: [v3 0/6] ARM: tegra: convert device tree files to use CLK defines

2013-02-17 Thread Simon Glass
Hi Hiroshi, On Fri, Feb 15, 2013 at 12:43 AM, Hiroshi Doyu wrote: > Hi, > > With new dtc+cpp feature, we could get rid of magic numbers in dts* > files. This patch replaces CLK IDs. > > We also plan to share those DT header files with kernel source > later[1]. > > This series depends on: > [PAT

Re: [PATCH v4 3/6] mfd: Add ChromeOS EC I2C driver

2013-02-16 Thread Simon Glass
Hi, On Sat, Feb 16, 2013 at 1:06 AM, Felipe Balbi wrote: > On Fri, Feb 15, 2013 at 08:16:09PM -0800, Simon Glass wrote: >> This uses an I2C bus to talk to the ChromeOS EC. The protocol >> is defined by the EC and is fairly simple, with a length byte, >> checksum, command

[PATCH v4 1/6] mfd: Add ChromeOS EC messages header

2013-02-15 Thread Simon Glass
This file is included verbatim from the ChromeOS EC respository. Ideally we would prefer to avoid changing it, to make it easier to track this rapidly-changing file. Signed-off-by: Simon Glass Signed-off-by: Che-Liang Chiou Signed-off-by: Vincent Palatin --- Changes in v4: None Changes in v3

[PATCH v4 3/6] mfd: Add ChromeOS EC I2C driver

2013-02-15 Thread Simon Glass
This uses an I2C bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass Signed-off-by: Che-Liang Chiou --- Changes in v4: None

[PATCH v4 5/6] Input: matrix-keymap: Add function to read the new DT binding

2013-02-15 Thread Simon Glass
-GPIO drivers to use to decode the binding. Note: We could in fact create an entirely separate structure to hold these two fields, but it does not seem worth it, yet. If we have more parameters then we can add this, and then refactor each driver to hold such a structure. Signed-off-by: Simon Glass

[PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-15 Thread Simon Glass
-off-by: Simon Glass Signed-off-by: Luigi Semenzato Signed-off-by: Vincent Palatin --- Changes in v4: - Add 'depends on MFD_CROS_EC' to Kconfig - Remove use of wake_notifier - Remove manual code to locate device tree node - Add resume handler to clear keyboard scan buffer if required Cha

[PATCH v4 2/6] mfd: Add ChromeOS EC implementation

2013-02-15 Thread Simon Glass
structure is used to pass messages to the protocol driver. Signed-off-by: Simon Glass Signed-off-by: Che-Liang Chiou Signed-off-by: Jonathan Kliegman Signed-off-by: Luigi Semenzato Signed-off-by: Olof Johansson Signed-off-by: Vincent Palatin --- Changes in v4: - Fix up trvial logging comments

[PATCH v4 4/6] mfd: Add ChromeOS EC SPI driver

2013-02-15 Thread Simon Glass
This uses a SPI bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass --- Changes in v4: None Changes in v3: None Changes in v2

[PATCH v4 0/6] Add ChromeOS Embedded Controller support

2013-02-15 Thread Simon Glass
- Add new patch to decode matrix-keypad DT binding - Remove use of __devinit/__devexit - Use function to read matrix-keypad parameters from DT - Remove key autorepeat parameters from DT binding and driver - Use unsigned int for rows/cols Simon Glass (6): mfd: Add ChromeOS EC messages header mf

Re: [PATCH v2 2/6] mfd: Add ChromeOS EC implementation

2013-02-15 Thread Simon Glass
Hi Joe, On Tue, Feb 12, 2013 at 7:35 PM, Joe Perches wrote: > On Tue, 2013-02-12 at 18:42 -0800, Simon Glass wrote: >> This is the base EC implementation, which provides a high level >> interface to the EC for use by the rest of the kernel. The actual >> communcations is dea

Re: [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-15 Thread Simon Glass
Hi Dmitry, On Thu, Feb 14, 2013 at 9:31 AM, Dmitry Torokhov wrote: > On Wed, Feb 13, 2013 at 10:45:07PM -0800, Simon Glass wrote: >> >> >> >> +config KEYBOARD_CROS_EC >> >> + tristate "ChromeOS EC keyboard" >> >> + select INPU

  1   2   >