Re: [v6-1,15/17] arm64: dts: rockchip: add isp0 node for rk3399

Ah, sorry, I used a wrong Message-Id in In-reply-to, please ignore this one. Sorry about that. On 2018年03月12日 11:37, Shunqian Zheng wrote: rk3399 have two ISP, but we havn't test isp1, so just add isp0 at present. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen --- arch/

[PATCH v6-1,15/17] arm64: dts: rockchip: add isp0 node for rk3399

rk3399 have two ISP, but we havn't test isp1, so just add isp0 at present. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dt

[v6-1,15/17] arm64: dts: rockchip: add isp0 node for rk3399

rk3399 have two ISP, but we havn't test isp1, so just add isp0 at present. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dt

[PATCH] arm64: dts: rockchip: assign clock rate for ACLK_VIO

d that at least one board may override cru node and set the CPLL to 1.6 GHz. On that board it will be very important to be explicit about aclk-vio being 400 MHz. Signed-off-by: Shunqian Zheng --- arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 6 -- arch/arm64/boot/dts/rockchip/rk3399.dtsi

[PATCH v5 01/16] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format

Add the Rockchip ISP1 specific processing parameter format V4L2_META_FMT_RK_ISP1_PARAMS and metadata format V4L2_META_FMT_RK_ISP1_STAT_3A for 3A. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ include/uapi/linux/videodev2.h | 4

[PATCH v5 05/16] media: rkisp1: add Rockchip ISP1 subdev driver

From: Jacob Chen Add the subdev driver for rockchip isp1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen Signed-off-by: Eddie Cai Signed-off-by: Jeffy Chen Signed-off-by: Allon Huang Signed-off-by: Tomasz Figa --- drivers

[PATCH v5 09/16] media: rkisp1: add rockchip isp1 core driver

From: Jacob Chen Add the core driver for rockchip isp1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen Signed-off-by: Eddie Cai Signed-off-by: Jeffy Chen Signed-off-by: Allon Huang Signed-off-by: Tomasz Figa --- drivers

[PATCH v5 10/16] dt-bindings: Document the Rockchip ISP1 bindings

From: Jacob Chen Add DT bindings documentation for Rockchip ISP1 Signed-off-by: Jacob Chen Reviewed-by: Rob Herring --- .../devicetree/bindings/media/rockchip-isp1.txt| 69 ++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/

[PATCH v5 11/16] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings

From: Jacob Chen Add DT bindings documentation for Rockchip MIPI D-PHY RX Signed-off-by: Jacob Chen Reviewed-by: Rob Herring --- .../bindings/media/rockchip-mipi-dphy.txt | 88 ++ 1 file changed, 88 insertions(+) create mode 100644 Documentation/devicetree/bindi

[PATCH v5 14/16] arm64: dts: rockchip: add isp0 node for rk3399

rk3399 have two ISP, but we havn't test isp1, so just add isp0 at present. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b

[PATCH v5 16/16] MAINTAINERS: add entry for Rockchip ISP1 driver

/MAINTAINERS b/MAINTAINERS index 85773bf..b97bc25 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11668,6 +11668,16 @@ F: drivers/hid/hid-roccat* F: include/linux/hid-roccat* F: Documentation/ABI/*/sysfs-driver-hid-roccat* +ROCKCHIP ISP V1 DRIVER +M: Jacob chen +M: Shunqian

[PATCH v5 13/16] ARM: dts: rockchip: add rx0 mipi-phy for rk3288

From: Jacob Chen It's a Designware MIPI D-PHY, used by ISP in rk3288. Signed-off-by: Jacob Chen --- arch/arm/boot/dts/rk3288.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 5dbfafb..a4c9a6e 100644 --- a/arch/ar

[PATCH v5 15/16] arm64: dts: rockchip: add rx0 mipi-phy for rk3399

It's a Designware MIPI D-PHY, used for ISP0 in rk3399. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/roc

[PATCH v5 07/16] media: rkisp1: add ISP1 params driver

From: Jacob Chen Add the output video driver that accept params from userspace. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen Signed-off-by: Eddie Cai Signed-off-by: Jeffy Chen Signed-off-by: Allon Huang Signed-off-by

[PATCH v5 04/16] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

From: Jacob Chen This commit adds a subdev driver for Rockchip MIPI Synopsys DPHY driver Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- .../media/platform/rockchip/isp1/mipi_dphy_sy.c| 787 + 1 file changed, 787 insertions

[PATCH v5 00/16] Rockchip ISP1 Driver

t the Rockchip ISP1 bindings dt-bindings: Document the Rockchip MIPI RX D-PHY bindings ARM: dts: rockchip: add isp node for rk3288 ARM: dts: rockchip: add rx0 mipi-phy for rk3288 MAINTAINERS: add entry for Rockchip ISP1 driver Jeffy Chen (1): media: rkisp1: Add user space ABI definitions Shu

[PATCH v5 06/16] media: rkisp1: add ISP1 statistics driver

From: Jacob Chen Add the capture video driver for rockchip isp1 statistics block. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen Signed-off-by: Eddie Cai Signed-off-by: Jeffy Chen Signed-off-by: Allon Huang Signed-off-by

[PATCH v5 08/16] media: rkisp1: add capture device driver

From: Jacob Chen This is the capture device interface driver that provides the v4l2 user interface. Frames can be received from ISP1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen Signed-off-by: Eddie Cai Signed-off-by: Jeffy

[PATCH v5 02/16] media: doc: add document for rkisp1 meta buffer format

From: Jacob Chen This commit add docuemnt for rkisp1 meta buffer format Signed-off-by: Jacob Chen --- Documentation/media/uapi/v4l/meta-formats.rst | 2 ++ .../media/uapi/v4l/pixfmt-meta-rkisp1-params.rst | 17 + .../media/uapi/v4l/pixfmt-meta-rkisp1-stat.rst

[PATCH v5 12/16] ARM: dts: rockchip: add isp node for rk3288

From: Jacob Chen rk3288 have a Embedded 13M ISP Signed-off-by: Jacob Chen --- arch/arm/boot/dts/rk3288.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index cd24894..5dbfafb 100644 --- a/arch/arm/boot/dts

[PATCH v5 03/16] media: rkisp1: Add user space ABI definitions

From: Jeffy Chen Add the header for userspace Signed-off-by: Jeffy Chen Signed-off-by: Jacob Chen --- include/uapi/linux/rkisp1-config.h | 757 + 1 file changed, 757 insertions(+) create mode 100644 include/uapi/linux/rkisp1-config.h diff --git a/include/

[PATCH] clk: rockchip: add 2016M to big cpu clk rate table

We would prefer the 2016M as 2.0G than 1992M which seems odd, adding it to big cpu clk rate table then we can set 2016M in dts. Signed-off-by: Shunqian Zheng --- drivers/clk/rockchip/clk-rk3399.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers

[PATCH v5 3/8] iommu/rockchip: Fix allocation of bases array in driver probe

lti slaves") Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa Reviewed-by: Douglas Anderson --- drivers/iommu/rockchip-iommu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index 53fa0d9.

[PATCH v5 8/8] iommu/rockchip: Enable Rockchip IOMMU on ARM64

From: Simon Xue This patch makes it possible to compile the rockchip-iommu driver on ARM64, so that it can be used with 64-bit SoCs equipped with this type of IOMMU. Signed-off-by: Simon Xue Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/iommu/Kconfig | 2 +- 1 file

[PATCH v5 6/8] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

. This patch should not introduce any functional changes until the driver is made to attach subdevices into an IOMMU domain with the generic IOMMU API, which will happen in following patch. Based heavily on GEM implementation of Tegra DRM driver. Signed-off-by: Tomasz Figa Signed-off-by: Shunqian

[PATCH v5 4/8] iommu/rockchip: Use DMA API to manage coherency

device is registered for each allocated IOMMU domain. With this patch, this driver can be used on both ARM and ARM64 platforms, such as RK3288 and RK3399 respectively. Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 162

[PATCH v5 7/8] drm/rockchip: Use common IOMMU API to attach devices

wires things to use the new method. Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 100 +++- 1 file changed, 53 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers

[PATCH v5 2/8] iommu/rockchip: Add map_sg callback for rk_iommu_ops

From: Simon Xue The iommu_dma_alloc() in iommu/dma-iommu.c calls iommu_map_sg() that requires the callback iommu_ops .map_sg(). Adding the default_iommu_map_sg() to Rockchip IOMMU accordingly. Signed-off-by: Simon Xue Signed-off-by: Shunqian Zheng Reviewed-by: Douglas Anderson Signed-off-by

[PATCH v5 5/8] iommu/rockchip: Prepare to support generic DMA mapping

Set geometry for allocated domains and fix .domain_alloc() callback to work with IOMMU_DOMAIN_DMA domain type, which is used for implicit domains on ARM64. Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 16 +++- 1 file changed, 11

iommu/rockchip: Fix bugs and enable on ARM64

: - Instead of registering virtual IOMMU from DTS, create it when attaching. - Fix some bugs found in internal review. Shunqian Zheng (4): iommu/rockchip: Fix allocation of bases array in driver probe iommu/rockchip: Use DMA API to manage coherency iommu/rockchip: Prepare to support generic DMA

[PATCH v5 1/8] iommu/rockchip: Fix devm_{request,free}_irq parameter

ff-by: Simon Xue Signed-off-by: Shunqian Zheng Reviewed-by: Douglas Anderson Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index 25b4627..5a9659a 1

[PATCH v3 3/6] iommu/rockchip: support virtual iommu slave device

iommu when virtual master(group is NULL) attaching, so it can use this iommu even the real iommus disabled. Changes of V3: - Instead of registering virtual iommu in DTS, this patch creates a iommu when attaching. Signed-off-by: Shunqian Zheng Suggested-by: Tomasz Figa --- drivers/iommu

[PATCH v3 5/6] iommu/rockchip: use DMA API to map, to flush cache

ith this patch, this driver is available for ARM64 like RK3399. Signed-off-by: Shunqian Zheng --- drivers/iommu/rockchip-iommu.c | 113 +++-- 1 file changed, 76 insertions(+), 37 deletions(-) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockc

[PATCH v3 1/6] iommu/rockchip: fix devm_{request,free}_irq parameter

From: Simon Xue Even though the iommu shares irq with its master, using the *dev of iommu instead of master's *dev for devm_{request,free}_irq makes things clear. Signed-off-by: Simon Xue Signed-off-by: Shunqian Zheng Reviewed-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 4 ++

[PATCH v3 2/6] iommu/rockchip: add map_sg callback for rk_iommu_ops

From: Simon Xue The iommu_dma_alloc() in iommu/dma-iommu.c calls iommu_map_sg() that requires the callback iommu_ops .map_sg(). Adding the default_iommu_map_sg() to rockchip iommu accordingly. Signed-off-by: Simon Xue Signed-off-by: Shunqian Zheng Reviewed-by: Tomasz Figa --- drivers/iommu

[PATCH v3 6/6] iommu/rockchip: enable rockchip iommu on ARM64 platform

From: Simon Xue This patch makes it possible to compile the rockchip-iommu driver on ARM64 platform to be used with 64-bit SoCs equipped with this type of IOMMU. Signed-off-by: Simon Xue Signed-off-by: Shunqian Zheng Reviewed-by: Tomasz Figa --- drivers/iommu/Kconfig | 2 +- 1 file changed

[PATCH v3 4/6] drm: rockchip: use common iommu api to attach iommu

-by: Shunqian Zheng --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 112 +--- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + 2 files changed, 71 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip

[PATCH v3 0/6] fix bugs; enable iommu for ARM64

of registering virtual iommu in DTS, V3 creates a iommu when attaching. - Fix some bugs according to Tomasz's comments, most of them are offline, locally. Shunqian Zheng (3): iommu/rockchip: support virtual iommu slave device drm: rockchip: use common iommu api to attach

[PATCH v2 5/7] drm: rockchip: use common iommu api to attach iommu

-by: Shunqian Zheng --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 130 +++- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + 2 files changed, 89 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip

[PATCH v2 4/7] ARM: dts: rockchip: add virtual iommu for display

An virtual iommu without reg or interrupts for display. Adding this according to iommu driver changes. Signed-off-by: Shunqian Zheng --- arch/arm/boot/dts/rk3288.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index

[PATCH v2 7/7] iommu/rockchip: enable rockchip iommu on ARM64 platform

From: Simon Xue Signed-off-by: Simon Xue Signed-off-by: Shunqian Zheng --- drivers/iommu/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index ad08603..5572621 100644 --- a/drivers/iommu/Kconfig +++ b/drivers/iommu

[PATCH v2 2/7] iommu/rockchip: add map_sg callback for rk_iommu_ops

From: Simon Xue The iommu_dma_alloc() in iommu/dma-iommu.c calls iommu_map_sg() that requires the callback iommu_ops .map_sg(). Adding the default_iommu_map_sg() to rockchip iommu accordingly. Signed-off-by: Simon Xue Signed-off-by: Shunqian Zheng --- drivers/iommu/rockchip-iommu.c | 1 + 1

[PATCH v2 3/7] iommu/rockchip: support virtual iommu slave device

, we can probe a virtual iommu device and allow the DRM attaching to it. The virtual iommu is needed also because we want convert to use DMA API for map/unmap, cache flush, so that DRM buffer alloc still work even VOP is disabled. Signed-off-by: Shunqian Zheng --- drivers/iommu/rockchip-iommu.c

[PATCH v2 6/7] iommu/rockchip: use DMA API to map, to flush cache

ith this patch, this driver is available for ARM64 like RK3399. Signed-off-by: Shunqian Zheng --- drivers/iommu/rockchip-iommu.c | 113 ++--- 1 file changed, 71 insertions(+), 42 deletions(-) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockc

[PATCH v2 1/7] iommu/rockchip: fix devm_{request,free}_irq parameter

From: Simon Xue Even though the iommu shares irq with its master, using the *dev of iommu instead of master's *dev for devm_{request,free}_irq makes things clear. Signed-off-by: Simon Xue Signed-off-by: Shunqian Zheng --- drivers/iommu/rockchip-iommu.c | 4 ++-- 1 file changed, 2 inser

[PATCH v2 0/7] fix bugs; enable iommu for ARM64

vs v1, so please forget the v1. Shunqian Zheng (4): iommu/rockchip: support virtual iommu slave device ARM: dts: rockchip: add virtual iommu for display drm: rockchip: use common iommu api to attach iommu iommu/rockchip: use DMA API to map, to flush cache Simon Xue (3): iommu/rockchip

Re: [PATCH 4/5] iommu/rockchip: add ARM64 cache flush operation for iommu

Catalin, Robin, On 2016年05月23日 21:35, Catalin Marinas wrote: On Mon, May 23, 2016 at 11:44:14AM +0100, Robin Murphy wrote: On 23/05/16 02:37, Shunqian Zheng wrote: From: Simon Signed-off-by: Simon --- drivers/iommu/rockchip-iommu.c | 4 1 file changed, 4 insertions(+) diff --git a

[PATCH 1/5] iommu/rockchip: fix devm_request_irq and devm_free_irq parameter

From: Simon When rk_iommu_attach_device or rk_iommu_detach_device be called, the second parameter "dev" represent the device who own the iommu, so it is not resonable using "dev" for devm_request_irq's first parameter. To avoid potential error, we must use iommu device itself "iommu->dev" instead

[PATCH 3/5] iommu/rockchip: add sanity check for virtual device

From: Simon We mark DRM as "virtual" device by checking it's group, which may no longer true with the new rockchip drm drv in https://patchwork.kernel.org/patch/8876331/. Checking the group->iommu_data for virtual device. Signed-off-by: Simon --- drivers/iommu/rockchip-iommu.c | 7 ++- 1

[PATCH 5/5] iommu/rockchip: enable rockchip iommu on ARM64 platform

From: Simon Signed-off-by: Simon --- drivers/iommu/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index ad08603..5572621 100644 --- a/drivers/iommu/Kconfig +++ b/drivers/iommu/Kconfig @@ -218,7 +218,7 @@ config OMAP_IOMM

[PATCH 2/5] iommu/rockchip: add map_sg callback for rk_iommu_ops

From: Simon The iommu_dma_alloc() in iommu/dma-iommu.c calls iommu_map_sg() that requires the callback iommu_ops .map_sg(). Adding the default_iommu_map_sg() to rockchip iommu accordingly. Signed-off-by: Simon --- drivers/iommu/rockchip-iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 4/5] iommu/rockchip: add ARM64 cache flush operation for iommu

From: Simon Signed-off-by: Simon --- drivers/iommu/rockchip-iommu.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index 043d18c..1741b65 100644 --- a/drivers/iommu/rockchip-iommu.c +++ b/drivers/iommu/rockchip-iommu.c @@

[PATCH 0/5] iommu/rockchip: fix bugs; enable iommu for ARM64

Fix a few bugs for rockchip iommu and enable for ARM64. Simon (5): iommu/rockchip: fix devm_request_irq and devm_free_irq parameter iommu/rockchip: add map_sg callback for rk_iommu_ops iommu/rockchip: add sanity check for virtual device iommu/rockchip: add ARM64 cache flush operation for i

[RFC PATCH v1] Trying to fix the stmmac memory leak during suspend/resume

From: ZhengShunQian When I run Suspend-to-Ram stress test on my Rockchip RK3288(SoC) board that integrated stmmac ethernet, it always OOM after a few iterations, usually 50 times is enough to reproduce. Compiled kernel with KMEMLEAK feature, I got the logs as below: unreferenced object 0xed89ac0

[PATCH v1] net: stmmac: Free rx_skbufs before realloc

From: ZhengShunQian The init_dma_desc_rings() may realloc the rx_skbuff[] when suspend and resume. This patch free the rx_skbuff[] before reallocing memory. Signed-off-by: ZhengShunQian --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 18 ++ 1 file changed, 10 insertions

[PATCH v4 2/2] ASoC: RK3036: Add binding doc of inno-rk3036 codec driver

From: ZhengShunQian This patch add the binding document of inno-rk3036 audio codec driver. Signed-off-by: ZhengShunQian --- .../devicetree/bindings/sound/inno-rk3036.txt| 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/sou

[PATCH v4 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

From: ZhengShunQian RK3036 SoC integrated with an Inno audio codec. This driver implements the functions of it. There is not need a special machine driver, since the simple-card machine driver works perfect in this case. Signed-off-by: ZhengShunQian --- sound/soc/codecs/Kconfig | 4 +

[PATCH v4 0/2] Audio Codec Driver of RK3036 SoC

From: ZhengShunQian This patches add the RK3036 SoC codec driver. Rockchip RK3036 SoC integrated with an Inno audio codec. It supports the following features: o. 24bit DAC o. Support 16Ω to 32Ω headphone output and speaker output o. Support Mono, Stereo channel o. Sampling rate of 8/12/16/24/32/

Re: [PATCH v3 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

Hi Mark, On 2015年11月06日 18:45, Mark Brown wrote: On Fri, Nov 06, 2015 at 04:39:21PM +0800, Shunqian Zheng wrote: + SOC_ENUM("Anti-pop", rk3036_codec_antipop_enum), As discussed this shouldn't be an enum. Sure, I'll write the .get/.put/.info() for this. Here is t

[PATCH v3 2/2] ASoC: RK3036: Add binding doc of inno-rk3036 codec driver

From: ZhengShunQian This patch add the binding document of inno-rk3036 audio codec driver. Signed-off-by: ZhengShunQian --- .../devicetree/bindings/sound/inno-rk3036.txt| 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/sou

[PATCH v3 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

From: ZhengShunQian RK3036 SoC integrated with an Inno audio codec. This driver implements the functions of it. There is not need a special machine driver, since the simple-card machine driver works perfect in this case. Signed-off-by: ZhengShunQian --- sound/soc/codecs/Kconfig | 4 +

[PATCH v3 0/2] Audio Codec Driver of RK3036 SoC

From: ZhengShunQian This patches add the RK3036 SoC codec driver. Rockchip RK3036 SoC integrated with an Inno audio codec. It supports the following features: o. 24bit DAC o. Support 16Ω to 32Ω headphone output and speaker output o. Support Mono, Stereo channel o. Sampling rate of 8/12/16/24/32/

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

Mark, On 2015年11月06日 00:13, Mark Brown wrote: On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: This is basically all good, a few very minor comments below but nothing that should take any time to fix. +static const char *rk3036_codec_antipop_text[] = {"none", "

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

LABBE, On 2015年11月05日 20:47, LABBE Corentin wrote: On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: From: ZhengShunQian RK3036 SoC integrated with an Inno audio codec. This driver implements the functions of it. There is not need a special machine driver, since the simple

[PATCH v2 2/2] ASoC: RK3036: Add binding doc of inno-rk3036 codec driver

From: ZhengShunQian This patch add the binding document of inno-rk3036 audio codec driver. Signed-off-by: ZhengShunQian --- .../devicetree/bindings/sound/inno-rk3036.txt| 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/sou

[PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

From: ZhengShunQian RK3036 SoC integrated with an Inno audio codec. This driver implements the functions of it. There is not need a special machine driver, since the simple-card machine driver works perfect in this case. Signed-off-by: ZhengShunQian --- sound/soc/codecs/Kconfig | 4 +

[PATCH v2 0/2] Audio Codec Driver of RK3036 SoC

From: ZhengShunQian This patches add the RK3036 SoC codec driver. Rockchip RK3036 SoC integrated with an Inno audio codec. It supports the following features: o. 24bit DAC o. Support 16Ω to 32Ω headphone output and speaker output o. Support Mono, Stereo channel o. Sampling rate of 8/12/16/24/32/

Re: [PATCH v1 1/4] ASoC: codec: Inno codec driver for RK3036 SoC

Mark, I sended the v2 patches and fixed the follows, On 2015年10月20日 03:09, Mark Brown wrote: On Tue, Oct 13, 2015 at 09:01:06AM +0800, Shunqian Zheng wrote: +config SND_SOC_INNO_RK3036 + tristate "Inno codec driver for RK3036 SoC" + depends on ARCH_ROCKCHIP + There does

Re: [PATCH v1 3/4] ASoC: Add codec machine driver for RK3036

Mark & Sjoerd, On 2015年10月20日 03:13, Mark Brown wrote: On Tue, Oct 13, 2015 at 09:01:08AM +0800, Shunqian Zheng wrote: From: ZhengShunQian This patch add the machine driver for rk3036. Like Sjoerd said this looks like it migh be better just using simple-card, if not... Yes, simple-

[PATCH v1 3/4] ASoC: Add codec machine driver for RK3036

From: ZhengShunQian This patch add the machine driver for rk3036. RK3036 SoC is integrated with Inno codec, this patch should work for all RK3036 board. Signed-off-by: ZhengShunQian --- sound/soc/rockchip/Kconfig | 10 +++ sound/soc/rockchip/Makefile | 2 + sound/soc/roc

[PATCH v1 4/4] ASoC: RK3036: Add binding doc for audio machine driver

From: ZhengShunQian This patch add binding document for RK3036 SoC audio machine driver. Signed-off-by: ZhengShunQian --- .../devicetree/bindings/sound/rockchip-rk3036.txt | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound

[PATCH v1 2/4] ASoC: RK3036: Add binding doc of inno-rk3036 codec driver

From: ZhengShunQian This patch add the binding document of inno-rk3036 audio codec driver. Signed-off-by: ZhengShunQian --- .../devicetree/bindings/sound/inno-rk3036.txt| 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/sou

[PATCH v1 1/4] ASoC: codec: Inno codec driver for RK3036 SoC

From: ZhengShunQian RK3036 SoC integrated with an Inno audio codec. This driver config the base function of codec. And the dapm is still WIP. Signed-off-by: ZhengShunQian --- sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/inno_rk3036.c | 439 ++

[PATCH v1 0/4] Audio Codec Driver of RK3036 SoC

From: ZhengShunQian Base on the other seris of RK3036 clk patches, which is not landed yet, this patches add the RK3036 SoC codec driver. Rockchip RK3036 SoC integrated with an Inno audio codec. It supports the following features: o. 24bit DAC o. Support 16Ω to 32Ω headphone output and speaker o

[PATCH v2 2/5] nvmem: fix the out-of-range leak in read/write()

From: ZhengShunQian The position to read/write must be less than max register size. Signed-off-by: ZhengShunQian Acked-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index d3c

[PATCH v2 5/5] ARM: dts: rockchip: add eFuse config of rk3288 SoC

From: ZhengShunQian This patch add the eFuse dt config of rk3288 SoC. Cc: Srinivas Kandagatla Cc: Heiko Stuebner Signed-off-by: ZhengShunQian --- arch/arm/boot/dts/rk3288.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts

[PATCH v2 4/5] Documentation: rockchip-efuse: describe the usage of eFuse

From: ZhengShunQian This patch add the bindings document of rockchip eFuse driver. Cc: Srinivas Kandagatla Cc: Heiko Stuebner Signed-off-by: ZhengShunQian --- .../devicetree/bindings/nvmem/rockchip-efuse.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644

[PATCH v2 0/5] Add eFuse driver of Rockchip SoC

From: ZhengShunQian Base on nvmem framework, this series patches implement the eFuse driver of Rockchip SoC. The data from eFuse contains CPU leakage, chip code and version etc. The flow of reading data from eFuse is quite simple, configure the CTRL register, write data address to CTRL register,

[PATCH v2 3/5] nvmem: rockchip-efuse: implement efuse driver

From: ZhengShunQian There are some SoC specified values store in eFuse, such as the cpu_leakage and cpu_version, this driver can expose these values to /sys base on nvmem. Signed-off-by: Caesar Wang Signed-off-by: ZhengShunQian Acked-by: Srinivas Kandagatla --- drivers/nvmem/Kconfig

[PATCH v2 1/5] clk: rockchip: rk3288: Add the clock id of eFuse

From: ZhengShunQian The clock id is necessary item, changing it from 0 then can be referred in driver and device tree. Signed-off-by: ZhengShunQian Reviewed-by: Heiko Stuebner --- drivers/clk/rockchip/clk-rk3288.c | 2 +- include/dt-bindings/clock/rk3288-cru.h | 1 + 2 files changed, 2 i

Re: [PATCH v1 1/5] clk: rockchip: rk3288: Add the clock id of eFuse

Heiko, On 2015年08月11日 15:22, Heiko Stübner wrote: Am Dienstag, 11. August 2015, 09:16:32 schrieb Heiko Stübner: Am Dienstag, 11. August 2015, 14:15:02 schrieb Shunqian Zheng: From: ZhengShunQian The clock id is necessary item, changing it from 0 then can be referred in driver and device

Re: [PATCH v1 1/5] clk: rockchip: rk3288: Add the clock id of eFuse

On 2015年08月11日 15:16, Heiko Stübner wrote: Am Dienstag, 11. August 2015, 14:15:02 schrieb Shunqian Zheng: From: ZhengShunQian The clock id is necessary item, changing it from 0 then can be referred in driver and device tree. Signed-off-by: ZhengShunQian Reviewed-by: Heiko Stuebner

[PATCH v1 1/5] clk: rockchip: rk3288: Add the clock id of eFuse

From: ZhengShunQian The clock id is necessary item, changing it from 0 then can be referred in driver and device tree. Signed-off-by: ZhengShunQian --- drivers/clk/rockchip/clk-rk3288.c | 2 +- include/dt-bindings/clock/rk3288-cru.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)

[PATCH v1 2/5] nvmem: fix the out-of-range leak in read/write()

From: ZhengShunQian The position to read/write must be less than max register size. Signed-off-by: ZhengShunQian Acked-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index d3c

[PATCH v1 5/5] ARM: dts: rockchip: add eFuse config of rk3288 SoC

From: ZhengShunQian This patch add the eFuse dt config of rk3288 SoC. Signed-off-by: ZhengShunQian --- arch/arm/boot/dts/rk3288.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 2db91c9..4632e0d 100644 --

[PATCH v1 4/5] Documentation: rockchip-efuse: describe the usage of eFuse

From: ZhengShunQian This patch add the bindings document of rockchip eFuse driver. Signed-off-by: ZhengShunQian --- .../devicetree/bindings/nvmem/rockchip-efuse.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/nvmem/rockc

[PATCH v1 0/5] Add eFuse driver of Rockchip SoC

From: ZhengShunQian Base on nvmem framework, this series patches implement the eFuse driver of Rockchip SoC. The data from eFuse contains CPU leakage, chip code and version etc. The flow of reading data from eFuse is quite simple, configure the CTRL register, write data address to CTRL register,

[PATCH v1 3/5] nvmem: rockchip-efuse: implement efuse driver

From: ZhengShunQian There are some SoC specified values store in eFuse, such as the cpu_leakage and cpu_version, this driver can expose these values to /sys base on nvmem. Signed-off-by: Caesar Wang Signed-off-by: ZhengShunQian --- drivers/nvmem/Kconfig | 10 +++ drivers/nvmem/Makef

Re: [PATCH 3/3] clk: rockchip: do not gate the efuse256 clock

Hi Heiko, On 2015年08月10日 16:08, Heiko Stübner wrote: Hi, Am Montag, 10. August 2015, 11:22:43 schrieb Shunqian Zheng: From: ZhengShunQian Always enable the clock of efuse256. Base on the nvmem framework, it seems like there is not a good way to enable the clock when actual needed. Signed

[PATCH 1/3] nvmem: fix the out-of-range leak in read/write()

From: ZhengShunQian The position to read/write must be less than max register size. Signed-off-by: ZhengShunQian --- drivers/nvmem/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index d3c6676..f4af8e5 100644 --- a/driv

[PATCH 0/3] Add eFuse driver of Rockchip SoC

From: ZhengShunQian Base on nvmem framework, this three patches implement the eFuse driver of Rockchip SoC. The data from eFuse contains CPU leakage, chip code and version etc. The flow of reading data from eFuse is quite simple, config the CTRL register, write data address to CTRL register, the

[PATCH 3/3] clk: rockchip: do not gate the efuse256 clock

From: ZhengShunQian Always enable the clock of efuse256. Base on the nvmem framework, it seems like there is not a good way to enable the clock when actual needed. Signed-off-by: ZhengShunQian --- drivers/clk/rockchip/clk-rk3288.c | 2 +- include/dt-bindings/clock/rk3288-cru.h | 1 + 2 fi

[PATCH 2/3] nvmem: rockchip-efuse: implement eFuse driver

From: ZhengShunQian There are some SoC specified values store in eFuse, such as the cpu_leakage and cpu_version, this driver can expose these values to /sys base on nvmem. Also add the docs of efuse bindings and the rk3288's efuse config. Signed-off-by: Caesar Wang Signed-off-by: ZhengShunQian

Re: [PATCH v2 0/3] Add the efuse driver on rockchip platform

On 2015年08月05日 00:11, Srinivas Kandagatla wrote: Hi Shunqian, Sorry for delay in reply, I was on Holidays.. Thanks for testing. On 31/07/15 10:27, Shunqian Zheng wrote: 1. Without the following diff, `hexdump /sys/bus/nvmem/devices/rockchip-efuse0/nvmem` is wrong with "INVALID ARG

Re: [PATCH v2 0/3] Add the efuse driver on rockchip platform

#size-cells = <1>; clocks = <&cru PCLK_EFUSE256>; clock-names = "pclk_efuse_256"; cpu_leakage: cpu_leakage { reg = <0x17 0x1>; }; }; Then nvmem exposes the "c