Re: [PATCH] selftests/filesystems/binderfs: Skip tests if user namespaces are unavailable

2025-08-07 Thread Shuah Khan
On 8/7/25 07:45, Wake Liu wrote: The binderfs selftests, specifically `binderfs_stress` and `binderfs_test_unprivileged`, depend on user namespaces to run. On kernels built without user namespace support (CONFIG_USER_NS=n), these tests will fail. Why not add CONFIG_USER_NS to config file inste

[GIT PULL] kselftest next update for Linux 6.17-rc1

2025-07-28 Thread Shuah Khan
tests: breakpoints: use suspend_stats to reliably check suspend success selftests/kexec: fix test_kexec_jump build Nick Huang (1): selftests: ipc: Replace fail print statements with ksft_test_result_fail Paul E. McKenney (1): selftests/pidfd: Fix duplicate-symbol warnings for SCHED_ CPP

[GIT PULL] kunit next update for Linux 6.17-rc1

2025-07-28 Thread Shuah Khan
Hi Linus, Please pull the following kunit next update for Linux 6.17-rc1. Corrects MODULE_IMPORT_NS() syntax documentation, makes kunit_test timeout configurable via a module parameter and a Kconfig option, fixes longest symbol length test, adds a test for static stub, and adjusts kunit_test tim

Re: [PATCH v2] selftests/pidfd: Fix duplicate-symbol warnings for SCHED_ CPP symbols

2025-07-24 Thread Shuah Khan
On 7/24/25 12:26, Shuah Khan wrote: On 7/23/25 17:13, Paul E. McKenney wrote: The pidfd selftests run in userspace and include both userspace and kernel header files.  On some distros (for example, CentOS), this results in duplicate-symbol warnings in allmodconfig builds, while on other distros

Re: [PATCH v2] selftests: firmware: Add details in error logging

2025-07-24 Thread Shuah Khan
On 7/20/25 12:21, Harshal Wadhwa wrote: On Mon, Jul 14, 2025 at 03:39:47PM -0600, Shuah Khan wrote: On 7/14/25 15:26, Harshal wrote: Specify details in logs of failed cases How about changing the above to: Improve error messages adding details on failuires Will change this in next patch

Re: [PATCH v2] selftests/pidfd: Fix duplicate-symbol warnings for SCHED_ CPP symbols

2025-07-24 Thread Shuah Khan
feasible) or to adjust compiler command-line options to suppress the warnings (which might or might not be desirable). [ paulmck: Apply Shuah Khan feedback. ] Looks good to me. thanks, -- Shuah

Re: [RESEND PATCH] selftests/pidfd: align stack to fix SP alignment exception

2025-07-18 Thread Shuah Khan
On 7/16/25 01:00, Shuai Xue wrote: 在 2025/6/19 10:26, Shuai Xue 写道: 在 2025/6/19 05:36, Shuah Khan 写道: On 6/15/25 23:06, Shuai Xue wrote: The pidfd_test fails on the ARM64 platform with the following error: Bail out! pidfd_poll check for premature notification on child thread exec

Re: [PATCH RFC] selftests/pidfd: Fix duplicate-symbol warnings for SCHED_ CPP symbols

2025-07-18 Thread Shuah Khan
kernel definitions into another (which might or might not be feasible) or to adjust compiler command-line options to suppress the warnings (which might or might not be desirable). Signed-off-by: Paul E. McKenney Cc: Christian Brauner Cc: Shuah Khan Cc: --- pidfd.h |4 1 file

Re: [PATCH v2] selftests: firmware: Add details in error logging

2025-07-14 Thread Shuah Khan
On 7/14/25 15:26, Harshal wrote: Specify details in logs of failed cases How about changing the above to: Improve error messages adding details on failuires Signed-off-by: Harshal --- v2: - revert back to exit() instead of die() to avoid modifying system behaviour v1: https://lore.kernel

Re: [PATCH] selftests: breakpoints: use suspend_stats to reliably check suspend success

2025-07-10 Thread Shuah Khan
On 6/26/25 13:16, Moon Hee Lee wrote: The step_after_suspend_test verifies that the system successfully suspended and resumed by setting a timerfd and checking whether the timer fully expired. However, this method is unreliable due to timing races. In practice, the system may take time to enter

[PATCH] selftests: print installation complete message

2025-07-03 Thread Shuah Khan
Add installation complete message to Makefile install logic. Signed-off-by: Shuah Khan --- tools/testing/selftests/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 9dae84a74e7f..b95de208265a 100644 --- a/tools

Re: [PATCH] selftests: ptrace: add set_syscall_info to .gitignore

2025-07-01 Thread Shuah Khan
On 6/23/25 12:34, Moon Hee Lee wrote: Add the set_syscall_info test binary to .gitignore to avoid tracking build artifacts in the ptrace selftests directory. Signed-off-by: Moon Hee Lee --- tools/testing/selftests/ptrace/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/te

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread Shuah Khan
On 6/19/25 15:40, Shuah Khan wrote: On 6/19/25 13:00, John Hubbard wrote: On 6/19/25 10:00 AM, Shuah Khan wrote: On 6/19/25 01:46, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan wrote: On 6/9/25 20:07, Chen Linxuan wrote: ... diff --git a/tools/testing/selftests

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread Shuah Khan
On 6/19/25 13:00, John Hubbard wrote: On 6/19/25 10:00 AM, Shuah Khan wrote: On 6/19/25 01:46, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan wrote: On 6/9/25 20:07, Chen Linxuan wrote: ... diff --git a/tools/testing/selftests/filesystems/mount-notify/mount- notify_test.c

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread Shuah Khan
On 6/19/25 01:46, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan wrote: On 6/9/25 20:07, Chen Linxuan wrote: When running `make kselftest`, the following compilation warning was encountered: mount-notify_test.c: In function ‘fanotify_rmdir’: mount-notify_test.c:490:17

Re: [PATCH RESEND] selftests/memfd: clean Makefile

2025-06-19 Thread Shuah Khan
On 6/19/25 01:43, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:21 AM Shuah Khan wrote: On 6/9/25 20:05, Chen Linxuan wrote: When writing a test for fusectl, I referred to this Makefile as a reference for creating a FUSE daemon in the selftests. While doing so, I noticed that there is a

Re: [RESEND PATCH] selftests/pidfd: align stack to fix SP alignment exception

2025-06-18 Thread Shuah Khan
16 bytes. Signed-off-by: Shuai Xue --- Assuming this is going through Christian's tree. Acked-by: Shuah Khan Let me know if you would like me to pick it up. thanks, -- Shuah

Re: [PATCH RESEND] selftests/memfd: clean Makefile

2025-06-18 Thread Shuah Khan
On 6/9/25 20:05, Chen Linxuan wrote: When writing a test for fusectl, I referred to this Makefile as a reference for creating a FUSE daemon in the selftests. While doing so, I noticed that there is a minor issue in the Makefile. What happens if this change isn't made? The fuse_mnt.c file is

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-18 Thread Shuah Khan
On 6/9/25 20:07, Chen Linxuan wrote: When running `make kselftest`, the following compilation warning was encountered: mount-notify_test.c: In function ‘fanotify_rmdir’: mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused

Re: [PATCH RESEND] selftests: add missing include

2025-06-18 Thread Shuah Khan
On 6/9/25 20:08, Chen Linxuan wrote: I failed to build this test on Ubuntu 24.04. Compiler complained about undefined functions mount, umount and some mount related flags. Signed-off-by: Chen Linxuan --- tools/testing/selftests/pid_namespace/pid_max.c | 1 + 1 file changed, 1 insertion(+) d

Re: [RESEND PATCH v13 3/3] selftests/rseq: Add test for mm_cid compaction

2025-06-18 Thread Shuah Khan
co Mathieu, Let me know if you would like me to take this through my tree. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v4] selftests: filesystems: Add functional test for the abort file in fusectl

2025-06-18 Thread Shuah Khan
el.org/all/CAOQ4uxjKFXOKQxPpxtS6G_nR0tpw95w0GiO68UcWg_OBhmSY=q...@mail.gmail.com/ Signed-off-by: Chen Linxuan Acked-by: Shuah Khan Reviewed-by: Amir Goldstein Co-developed-by: Miklos Szeredi Reviewed-by: Miklos Szeredi --- Changes in v4: - Apply patch suggested by Miklos Szeredi - Setting up a userns envir

Re: [PATCH] selftests: Add version file to kselftest installation dir

2025-06-03 Thread Shuah Khan
On 6/2/25 19:13, Tianyi Cui wrote: On 6/2/25 3:48 PM, Shuah Khan wrote: On 5/28/25 18:33, Tianyi Cui wrote: As titled, adding version file to kselftest installation dir, so the user of the tarball can know which kernel version the tarball belongs to. Signed-off-by: Tianyi Cui <1

Re: [PATCH] selftests: firmware: Add details in error logging

2025-06-02 Thread Shuah Khan
On 5/25/25 12:26, Harshal Wadhwa wrote: On Fri, 23 May 2025 at 03:49, Shuah Khan wrote: On 5/16/25 09:39, Harshal wrote: Specify details in logs of failed cases Use die() instead of exit() when write to sys_path fails Please explain why this change is needed? Signed-off-by: Harshal

Re: [PATCH v2] selftests: Add functional test for the abort file in fusectl

2025-06-02 Thread Shuah Khan
On 5/25/25 19:41, Chen Linxuan wrote: On Fri, May 23, 2025 at 6:50 AM Shuah Khan wrote: Also if this test requires root previlege, add check for it. Currently, this test does not require root privileges. Thanks, Chen Linxuan Thanks. Looks good to me. Acked-by: Shuah Khan thanks

Re: [PATCH] selftests: Add version file to kselftest installation dir

2025-06-02 Thread Shuah Khan
On 5/28/25 18:33, Tianyi Cui wrote: As titled, adding version file to kselftest installation dir, so the user of the tarball can know which kernel version the tarball belongs to. Signed-off-by: Tianyi Cui <1997...@gmail.com> --- tools/testing/selftests/Makefile | 6 ++ 1 file changed, 6 i

Re: [PATCH v2] selftests/filesystems: Fix build of anon_inode_test

2025-06-02 Thread Shuah Khan
anches got merged there. - Link to v1: https://lore.kernel.org/r/20250518-selftests-anon-inode-build-v1-1-71eff8183...@kernel.org Looks this will have to go directly to Linu's tree or vfs tree. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] selftests: ipc: Replace fail print statements with ksft_test_result_fail

2025-06-02 Thread Shuah Khan
On 5/31/25 01:01, Nick Huang wrote: Use the standard kselftest failure report function to ensure consistent test output formatting. This improves readability and integration with automated test frameworks. Signed-off-by: Nick Huang --- tools/testing/selftests/ipc/msgque.c | 47 ++-

Re: [PATCH v2] selftests/ptrace/get_syscall_info: fix for MIPS n32

2025-06-02 Thread Shuah Khan
ll_info) has been merged, so there are two similar tests in the tree now, but only one of them is permitted to use this approach, creating inconsistency. Taking all of the above into consideration, please approve this fix. Acked-by: Shuah Khan thanks, -- Shuah

Re: [RFC] selftests/mm: Skip tests dependent on a binary not built

2025-05-23 Thread Shuah Khan
On 5/23/25 12:43, Khaled Elnaggar wrote: Hello. The above doesn't belong in change log. Refer to a few change logs in the repo to learn how to write them. You can also check the kernel documentation - this change log is way too long. It doesn't clearly state what is being fixed. In this cas

[GIT PULL] Kselftest next update for Linux 6.16-rc1

2025-05-23 Thread Shuah Khan
Hi Linus, Please pull the following kselftest next update for Linux 6.16-rc1. -- Fixes - cpufreq test to not double suspend in rtcwake case. - compile error in pid_namespace test. - run_kselftest.sh to use readlink if realpath is not available. - cpufreq basic read and update testcas

[GIT PULL] kunit next update for Linux 6.16-rc1

2025-05-23 Thread Shuah Khan
Hi Linus, Please pull the following kunit next update for Linux 6.16-rc1. - Enables qemu_config for riscv32, sparc 64-bit, PowerPC 32-bit BE and 64-bit LE. - Enables CONFIG_SPARC32 to clearly differentiate between sparc 32-bit and 64-bit configurations. - Enables CONFIG_CPU_BIG_ENDIAN to cle

Re: [PATCH v2] kselftest: x86: Improve MOV SS test result message

2025-05-23 Thread Shuah Khan
On 5/23/25 01:32, Brigham Campbell wrote: Apparently, this test completes successfully when it completes execution without either causing a kernel panic or being killed by the kernel. This new test result message is more descriptive and grammatically correct. The change log description usually

Re: [PATCH v2] selftests: timers: valid-adjtimex: fix coding style issues

2025-05-23 Thread Shuah Khan
reported by checkpatch.pl and do not affect functionality. changes in v2 : - Resubmitted the patch with a properly formatted commit message, following patch submission guidelines, as suggested by Shuah Khan. Signed-off-by: Rujra Bhatt Sorry - I didn't realize these are all coding style re

Re: [PATCH] selftests: net: fix spelling and grammar mistakes

2025-05-22 Thread Shuah Khan
On 5/16/25 19:59, Praveen Balakrishnan wrote: Fix several spelling and grammatical mistakes in output messages from the net selftests to improve readability. Only the message strings for the test output have been modified. No changes to the functional logic of the tests have been made. Signed-o

Re: [PATCH v2] selftests: Add functional test for the abort file in fusectl

2025-05-22 Thread Shuah Khan
rt summary should include the test name: selftests: filesystems: Add functional test for the abort file in fusectl Also if this test requires root previlege, add check for it. The rest looks good to me. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 1/1] Fix typo in cpu-on-off-test selftest script:

2025-05-22 Thread Shuah Khan
On 5/16/25 19:19, Jihed Chaibi wrote: Fix typo in hotplaggable_offline_cpus function name: "hotplaggable" is replaced by "hotpluggable" Signed-off-by: Jihed Chaibi --- Change looks good to me. Change log should specify the subsusystem. Check submitting patches document and refer to a few cha

Re: [PATCH] [PATCH] Change pidns to pid namespace

2025-05-22 Thread Shuah Khan
On 5/16/25 10:49, rodgeprit...@gmail.com wrote: From: Pritesh Rodge Changed a comment in memfd_test.c , Unabbreviated pidns to pid namespace for better understanding . Signed-off-by: Pritesh Rodge --- tools/testing/selftests/memfd/memfd_test.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH v2] selftests: Improve test output grammar, code style

2025-05-22 Thread Shuah Khan
On 5/16/25 02:42, Hanne-Lotta Mäenpää wrote: Add small grammar fixes in perf events and Real Time Clock tests' output messages. Include braces around a single if statement, when there are multiple statements in the else branch, to align with the kernel coding style. This patch combines several

Re: [PATCH] selftests: firmware: Add details in error logging

2025-05-22 Thread Shuah Khan
On 5/16/25 09:39, Harshal wrote: Specify details in logs of failed cases Use die() instead of exit() when write to sys_path fails Please explain why this change is needed? Signed-off-by: Harshal --- tools/testing/selftests/firmware/fw_namespace.c | 17 + 1 file changed,

Re: Fwd: [PATCH] selftests : timers : valid-adjtimex.c : Fixed style checks

2025-05-22 Thread Shuah Khan
On 5/15/25 19:44, rujra wrote: fixed style checks according to Linux Kernel Coding Style standards. Fixes 1 : fixed alignment of parenthesis. LOG : CHECK: Alignment should match open parenthesis + printf("ERROR: out of range value %ld actually set!\n", +

Re: [PATCH] selftests: timers: Fix grammar and clarify comments in nanosleep.c

2025-05-22 Thread Shuah Khan
On 5/14/25 16:21, Rahul Kumar wrote: Improved the clarity and grammar in the header comment of nanosleep.c for better readability and consistency with kernel documentation style. This patch isn't really fixing anything. I won't be taking this one. Sorry. thanks, -- Shuah

Re: [PATCH] selftests/eventfd: correct test name and improve messages

2025-05-22 Thread Shuah Khan
On 5/13/25 01:44, Ryan Chung wrote: - Rename test from to ?? missing description of the change. Looks like the patch renames the test to fix spelling error in the test name? - Make the RDWR‐flag comment declarative: “The kernel automatically adds the O_RDWR flag.” - Update semaphore‐flag

Re: [PATCH] selftests: fix "memebers" typo in filesystems/mount-notify

2025-05-22 Thread Shuah Khan
On 5/13/25 08:48, Hendrik Hamerlinck wrote: Corrects a spelling mistake "memebers" instead of "members" in tools/testing/selftests/filesystems/mount-notify/mount-notify_test.c Change the shortlog to indicate test clearly. Check a few logs for this file for examples. Here is how the correct form

Re: [PATCH] selftests: ir_decoder: Convert header comment to proper multi-line block

2025-05-22 Thread Shuah Khan
On 5/13/25 16:32, Abdelrahman Fekry wrote: The test file for the IR decoder used single-line comments at the top to document its purpose and licensing, which is inconsistent with the style used throughout the Linux kernel. in this patch i converted the file header to a proper multi-line comment

Re: [PATCH] selftests: size: fix grammar and align output formatting

2025-05-22 Thread Shuah Khan
On 5/13/25 15:44, Abdelrahman Fekry wrote: Improve the grammar in the test name by changing "get runtime memory use" to "get runtime memory usage". Also adjust spacing in output lines ("Total:", "Free:", etc.) to ensure consistent alignment and readability. Signed-off-by: Abdelrahman Fekry Di

Re: [PATCH] selftests: acct: fix grammar and clarify output messages

2025-05-22 Thread Shuah Khan
On 5/13/25 16:14, Abdelrahman Fekry wrote: This patch improves the clarity and grammar of output messages in the acct() selftest. Minor changes were made to user-facing strings and comments to make them easier to understand and more consistent with the kselftest style. Changes include: - Fixing

Re: [PATCH] selftests/cpufreq: Fix cpufreq basic read and update testcases

2025-05-22 Thread Shuah Khan
On 5/19/25 01:58, Viresh Kumar wrote: On 30-04-25, 17:14, Swapnil Sapkal wrote: In cpufreq basic selftests, one of the testcases is to read all cpufreq sysfs files and print the values. This testcase assumes all the cpufreq sysfs files have read permissions. However certain cpufreq sysfs files (

Re: [PATCH v4 00/14] kselftest harness and nolibc compatibility

2025-05-12 Thread Shuah Khan
sts have been written for them. Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 1/3] selftests/timens: Print TAP headers

2025-05-09 Thread Shuah Khan
On 5/9/25 09:41, Thomas Weißschuh wrote: +Cc Kees On Wed, May 07, 2025 at 03:06:16PM -0600, Shuah Khan wrote: On 5/2/25 06:03, Thomas Weißschuh wrote: The TAP specification requires that the output begins with a header line. These headers lines are missing in the timens tests. Print such a

Re: The "make headers" requirement, revisited: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2025-05-08 Thread Shuah Khan
On 5/8/25 08:04, Sean Christopherson wrote: On Wed, May 07, 2025, Shuah Khan wrote: The issues Peter is seeing regarding KHDR_INCLUDES in the following tests can be easily fixed by simply changing the test Makefile. These aren't framework related. kvm/Makefile.kvm:-I ../rs

Re: [PATCH] kbuild: use ARCH from compile.h in unclean source tree msg

2025-05-07 Thread Shuah Khan
On 5/7/25 16:21, Shuah Khan wrote: On 5/7/25 01:23, Masahiro Yamada wrote: On Wed, May 7, 2025 at 7:07 AM Shuah Khan wrote: On 5/6/25 05:12, Nicolas Schier wrote: On Fri, 02 May 2025, Shuah Khan wrote: When make finds the source tree unclean, it prints a message to run "make ARCH=x

Re: [PATCH] kbuild: use ARCH from compile.h in unclean source tree msg

2025-05-07 Thread Shuah Khan
On 5/7/25 01:23, Masahiro Yamada wrote: On Wed, May 7, 2025 at 7:07 AM Shuah Khan wrote: On 5/6/25 05:12, Nicolas Schier wrote: On Fri, 02 May 2025, Shuah Khan wrote: When make finds the source tree unclean, it prints a message to run "make ARCH=x86_64 mrproper" message using the

Re: [PATCH 1/3] selftests/timens: Print TAP headers

2025-05-07 Thread Shuah Khan
On 5/2/25 06:03, Thomas Weißschuh wrote: The TAP specification requires that the output begins with a header line. These headers lines are missing in the timens tests. Print such a line. There is no cover letter for this - so I will respond to the first patch. The TAP information is added by t

Re: The "make headers" requirement, revisited: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2025-05-07 Thread Shuah Khan
On 10/17/24 10:47, John Hubbard wrote: On 10/17/24 9:33 AM, Shuah Khan wrote: On 10/16/24 20:01, John Hubbard wrote: On 10/16/24 1:00 PM, Shuah Khan wrote: On 10/16/24 04:20, Lorenzo Stoakes wrote: ... The requirement to do "make headers" is not a keeper. Really. The reason we

Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2025-05-07 Thread Shuah Khan
On 5/6/25 15:34, John Hubbard wrote: On 5/6/25 2:18 PM, Shuah Khan wrote: On 5/1/25 05:42, Peter Zijlstra wrote: On Wed, Oct 16, 2024 at 07:14:34PM -0700, John Hubbard wrote: On 10/16/24 3:06 PM, Lorenzo Stoakes wrote: On Wed, Oct 16, 2024 at 02:00:27PM -0600, Shuah Khan wrote: On 10/16/24

Re: [PATCH] kbuild: use ARCH from compile.h in unclean source tree msg

2025-05-06 Thread Shuah Khan
On 5/6/25 16:07, Shuah Khan wrote: On 5/6/25 05:12, Nicolas Schier wrote: On Fri, 02 May 2025, Shuah Khan wrote: When make finds the source tree unclean, it prints a message to run "make ARCH=x86_64 mrproper" message using the ARCH from the command line. The ARCH specified in the co

Re: [PATCH] kbuild: use ARCH from compile.h in unclean source tree msg

2025-05-06 Thread Shuah Khan
On 5/6/25 05:12, Nicolas Schier wrote: On Fri, 02 May 2025, Shuah Khan wrote: When make finds the source tree unclean, it prints a message to run "make ARCH=x86_64 mrproper" message using the ARCH from the command line. The ARCH specified in the command line could be different from t

Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2025-05-06 Thread Shuah Khan
On 5/1/25 05:42, Peter Zijlstra wrote: On Wed, Oct 16, 2024 at 07:14:34PM -0700, John Hubbard wrote: On 10/16/24 3:06 PM, Lorenzo Stoakes wrote: On Wed, Oct 16, 2024 at 02:00:27PM -0600, Shuah Khan wrote: On 10/16/24 04:20, Lorenzo Stoakes wrote: ... diff --git a/tools/testing/selftests

[PATCH] kbuild: use ARCH from compile.h in unclean source tree msg

2025-05-02 Thread Shuah Khan
mrproper' *** in /linux/linux_6.15 *** Signed-off-by: Shuah Khan --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5aa9ee52a765..7ee29136b4da 100644 --- a/Makefile +++ b/Makefile @@ -674,7 +674,7 @@ ifeq ($(KBUIL

Re: [PATCH v3 00/32] kselftest harness and nolibc compatibility

2025-04-29 Thread Shuah Khan
On 4/24/25 14:06, Shuah Khan wrote: On 4/22/25 02:51, Willy Tarreau wrote: Hi Thomas, On Tue, Apr 22, 2025 at 10:48:28AM +0200, Thomas Weißschuh wrote: Hi, On Fri, Apr 11, 2025 at 11:00:24AM +0200, Thomas Weißschuh wrote: Nolibc is useful for selftests as the test programs can be very small

Re: [PATCH v3 00/32] kselftest harness and nolibc compatibility

2025-04-24 Thread Shuah Khan
On 4/22/25 02:51, Willy Tarreau wrote: Hi Thomas, On Tue, Apr 22, 2025 at 10:48:28AM +0200, Thomas Weißschuh wrote: Hi, On Fri, Apr 11, 2025 at 11:00:24AM +0200, Thomas Weißschuh wrote: Nolibc is useful for selftests as the test programs can be very small, and compiled with just a kernel cros

[GIT PULL] kunit fixes update for Linux 6.15-rc3

2025-04-18 Thread Shuah Khan
Hi Linus, Please pull the following kunit fixes update for Linux 6.15-rc3. Fixes arch sh kunit qemu_configs script sh.py to honor kunit cmdline. diff is attached. thanks, -- Shuah The following changes since commit 8ffd015db85fe

[GIT PULL] Kselftest fixes update for Linux 6.15-rc3

2025-04-18 Thread Shuah Khan
Hi Linus, Please pull the following kselftest fixes update for Linux 6.15-rc3. Fixes dynevent_limitations.tc test failure on dash by detecting and handling bash and dash differences in evaluating \\. diff is attached. thanks, -- Shuah --

Re: [PATCH v2 00/32] kselftest harness and nolibc compatibility

2025-04-10 Thread Shuah Khan
On 4/10/25 09:19, Shuah Khan wrote: On 4/7/25 00:52, Thomas Weißschuh wrote: Nolibc is useful for selftests as the test programs can be very small, and compiled with just a kernel crosscompiler, without userspace support. Currently nolibc is only usable with kselftest.h, not the more convenient

Re: [PATCH v2 03/32] selftests: harness: Ignore unused variant argument warning

2025-04-10 Thread Shuah Khan
On 4/7/25 00:52, Thomas Weißschuh wrote: For tests without fixtures the variant argument is unused. This is intentional, prevent to compiler from complaining. Include the warning in the change log for reference. Signed-off-by: Thomas Weißschuh --- tools/testing/selftests/kselftest_harness

Re: [PATCH v2 02/32] selftests: harness: Use C89 comment style

2025-04-10 Thread Shuah Khan
On 4/7/25 00:52, Thomas Weißschuh wrote: All comments in this file use C89 comment style. Except for this one. Change it to get one step closer to C89 compatibility. Signed-off-by: Thomas Weißschuh --- tools/testing/selftests/kselftest_harness.h | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH v2 00/32] kselftest harness and nolibc compatibility

2025-04-10 Thread Shuah Khan
On 4/7/25 00:52, Thomas Weißschuh wrote: Nolibc is useful for selftests as the test programs can be very small, and compiled with just a kernel crosscompiler, without userspace support. Currently nolibc is only usable with kselftest.h, not the more convenient to use kselftest_harness.h This serie

Re: [PATCH v2 01/32] selftests: harness: Add harness selftest

2025-04-10 Thread Shuah Khan
On 4/7/25 00:52, Thomas Weißschuh wrote: Add a selftest for the harness itself so any changes can be validated. kselftest harness? Signed-off-by: Thomas Weißschuh --- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/kselftest/.gitignore | 1 +

[GIT PULL] Kselftest fixes update for Linux 6.15-rc2

2025-04-09 Thread Shuah Khan
Hi Linus, Please pull the following kselftest fixes update for Linux 6.15-rc2 Fixes tpm2, futex, and mincore tests. Creates a dedicated .gitignore for tpm2 Details: selftests: tpm2: test_smoke: use POSIX-conformant expression operator selftests/futex: futex_waitv wouldblock test should fail se

[GIT PULL] kunit fixes update for Linux 6.15-rc2

2025-04-08 Thread Shuah Khan
Hi Linus, Please pull the following kunit fixes update for Linux 6.15-rc2 Fixes tool to report test count in case of a late test plan when tests are specified before the test plan. Fixes spelling error in the commit that went into 6.15-rc1. diff is attached. thanks, -- Shuah -

Re: [PATCH v2] selftests/ptrace/get_syscall_info: fix for MIPS n32

2025-04-08 Thread Shuah Khan
On 3/29/25 08:02, Maciej W. Rozycki wrote: On Sat, 29 Mar 2025, Dmitry V. Levin wrote: +#if defined(_MIPS_SIM) && _MIPS_SIM == _MIPS_SIM_NABI32 +/* + * MIPS N32 is the only architecture where __kernel_ulong_t + * does not match the bitness of syscall arguments. + */ +typedef unsigned long long

Re: [PATCH 1/1] selftests/mincore: Allow read-ahead pages to reach the end of the file

2025-04-08 Thread Shuah Khan
On 4/7/25 20:42, Zhuo, Qiuxu wrote: Hi Shuah Khan, Just a gentle ping regarding this patch. If you have any questions, please feel free to let me know. Thanks! -Qiuxu From: Zhuo, Qiuxu [...] Subject: [PATCH 1/1] selftests/mincore: Allow read-ahead pages to reach the end of the file When

Re: [PATCH] selftests/futex: futex_waitv wouldblock test should fail

2025-04-08 Thread Shuah Khan
On 4/8/25 08:21, André Almeida wrote: Thank you Edward, Em 04/04/2025 19:12, Edward Liaw escreveu: Testcase should fail if -EWOULDBLOCK is not returned when expected value differs from actual value from the waiter. Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_f

Re: [PATCH] tests/pid_namespace: Add missing sys/mount.h

2025-04-08 Thread Shuah Khan
On 4/7/25 16:59, T.J. Mercier wrote: pid_max.c: In function ‘pid_max_cb’: pid_max.c:42:15: error: implicit declaration of function ‘mount’ [-Wimplicit-function-declaration] 42 | ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0); |

Re: [PATCH v2 12/16] selftests: vDSO: parse_vdso: Use UAPI headers instead of libc headers

2025-03-30 Thread Shuah Khan
nal report: https://lore.kernel.org/r/20250321-uapi-consistency-v1-1-439070118...@linutronix.de but it has apparently slipped through the cracks. If this is going through tip Acked-by: Shuah Khan Otherwise, I can send this up thanks, -- Shuah

Re: [PATCH v2] selftests/ptrace/get_syscall_info: fix for MIPS n32

2025-03-28 Thread Shuah Khan
On 1/15/25 16:37, Dmitry V. Levin wrote: MIPS n32 is one of two ILP32 architectures supported by the kernel that have 64-bit syscall arguments (another one is x32). When this test passed 32-bit arguments to syscall(), they were sign-extended in libc, PTRACE_GET_SYSCALL_INFO reported these sign-e

Re: bug report for linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c

2025-03-28 Thread Shuah Khan
On 3/26/25 13:25, David Binderman wrote: Hello there, Static analyser cppcheck says: linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:1061:11: style: int result is assigned to long long variable. If the variable is long long to avoid loss of information, then you have loss of informatio

Re: [PATCH] selftests/nolibc: drop unnecessary sys/io.h include

2025-03-28 Thread Shuah Khan
--- base-commit: bceb73904c855c78402dca94c82915f078f259dd change-id: 20250324-nolibc-ioperm-155646560b95 Best regards, Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] selftests/run_kselftest.sh: Use readlink if realpath is not available

2025-03-28 Thread Shuah Khan
On 3/18/25 10:05, Yosry Ahmed wrote: 'realpath' is not always available, fallback to 'readlink -f' if is not available. They seem to work equally well in this context. Can you add more specifics on "realpath" is not always available," No issues with the patch itself. I would like to know the

[GIT PULL] kunit next update for Linux 6.15-rc1

2025-03-26 Thread Shuah Khan
Hi Linus, Please pull the following kunit next update for Linux 6.15-rc1. kunit tool: - Changes to kunit tool to use qboot on QEMU x86_64, and build GDB scripts. - Fixes kunit tool bug in parsing test plan. - Adds test to kunit tool to check parsing late test plan. kunit: - Clarifies kunit_skip

[GIT PULL] Kselftest next update for Linux 6.15-rc1

2025-03-26 Thread Shuah Khan
Hi Linus, Please pull the following kselftest next update for Linux 6.15-rc1. Fixes bugs and cleans up code in tracing, ftrace, and user_events tests. Adds missing executables to ftrace gitignore. diff is attached. thanks, -- Shuah -

Re: Error during --arch x86_64 kunit test run

2025-03-15 Thread Shuah Khan
On 3/12/25 16:52, David Gow wrote: Hi Shuah, On Thu, 13 Mar 2025 at 05:14, Shuah Khan wrote: David, Brendan, Rae, I am seeing the following error when I run ./tools/testing/kunit/kunit.py run --arch x86_64 ERROR:root:ld:arch/x86/realmode/rm/realmode.lds:236: undefined symbol

Re: Error during --arch x86_64 kunit test run

2025-03-13 Thread Shuah Khan
On 3/12/25 20:21, David Gow wrote: On Thu, 13 Mar 2025 at 07:51, Shuah Khan wrote: On 3/12/25 16:52, David Gow wrote: Hi Shuah, On Thu, 13 Mar 2025 at 05:14, Shuah Khan wrote: David, Brendan, Rae, I am seeing the following error when I run ./tools/testing/kunit/kunit.py run --arch

Error during --arch x86_64 kunit test run

2025-03-12 Thread Shuah Khan
David, Brendan, Rae, I am seeing the following error when I run ./tools/testing/kunit/kunit.py run --arch x86_64 ERROR:root:ld:arch/x86/realmode/rm/realmode.lds:236: undefined symbol `sev_es_trampoline_start' referenced in expression I isolated it to dependency on CONFIG_AMD_MEM_ENCRYPT I ad

Re: [PATCH v3 0/2 RESEND] update kselftest framework to check for required configs

2025-02-27 Thread Shuah Khan
On 2/26/25 22:29, Siddharth Menon wrote: Currently, kselftests does not have a generalised mechanism to skip compilation and run tests when required kernel configuration options are disabled. Skipping compile by default is not what we want to do. Tests are supposed to compile and run even when

Re: [PATCH] selftests/dma: Fix bad array reference.

2025-02-26 Thread Shuah Khan
On 2/25/25 18:31, liuye wrote: Friendly ping. 在 2025/2/6 10:12, Liu Ye 写道: dir[directions] should be directions[dir] to correctly index the directions array. Signed-off-by: Liu Ye --- tools/testing/selftests/dma/dma_map_benchmark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH v2 2/2] Revert "selftests: kselftest: Fix build failure with NOLIBC"

2025-02-26 Thread Shuah Khan
d int min_major, ksft_exit_fail_msg("Can't parse kernel version\n"); return major > min_major || (major == min_major && minor >= min_minor); -#endif } #endif /* __KSELFTEST_H */ Looks good to me. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v2] selftests/vDSO: fix GNU hash table entry size for s390x

2025-02-26 Thread Shuah Khan
via s390 tree. Shuah, if you don't mind, may I get your Acked-by? Hello Shuah, friendly ping. Could you please respond with "Acked-by" if you don’t mind me taking this patch via the s390 tree? Or let me know if you plan to take it via your tree. Thank you! Yes. Please take

Re: [PATCH v2 00/16] selftests: vDSO: parse_vdso: Make compatible with nolibc

2025-02-26 Thread Shuah Khan
7ff48 Best regards, Here is my Ack for this series to go through vDSO or x86 tree Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

2025-02-24 Thread Shuah Khan
On 2/24/25 12:26, Steven Rostedt wrote: On Mon, 24 Feb 2025 19:21:26 + Beau Belgrave wrote: Beau? I applied it locally and ensured it passed (seems timing related). Acked-by: Beau Belgrave Thanks Beau, Shuah, Please apply this patch: Acked-by: Steven Rostedt (Google) -- Stev

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

2025-02-21 Thread Shuah Khan
On 2/20/25 20:35, realx...@163.com wrote: From: Yiqian Xun In parse_abi function,the dyn_test fails because the enable_file isn’t closed after successfully registering an event. By adding wait_for_delete(), the dyn_test now passes as expected. Signed-off-by: Yiqian Xun --- tools/testing/sel

Re: [PATCH] selftests: pid_namespace and pidfd missing include

2025-02-18 Thread Shuah Khan
On 2/12/25 17:24, Alessandro Zanni wrote: Running "make kselftest" results in several errors like these: pidfd_fdinfo_test.c:231:36: error: ‘MS_REC’ undeclared (first use in this function) 231 | r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0); pidfd_fdinfo_test.c:231:45: error: ‘M

Re: [PATCH v5 3/3] rseq/selftests: Add test for mm_cid compaction

2025-02-18 Thread Shuah Khan
On 2/10/25 08:25, Gabriele Monaco wrote: On Mon, 2025-02-10 at 15:53 +0100, Mathieu Desnoyers wrote: On 2025-02-10 08:57, Gabriele Monaco wrote: A task in the kernel (task_mm_cid_work) runs somewhat periodically to compact the mm_cid for each process. Add a test to validate that it runs corre

Re: [PATCH v5 0/3] selftests/lam: get_user additions and LAM enabled check

2025-01-23 Thread Shuah Khan
On 1/15/25 02:06, Maciej Wieczor-Retman wrote: Hello Shuah, I'd like to bump this series for visibility and ask if you still consider these patches okay to merge? Just checked and there were no conflicts after applying it on the newest kselftest-next. This is x86 test and usually goes through

[GIT PULL] kunit next update for Linux 6.14-rc1

2025-01-21 Thread Shuah Khan
Hi Linus, Please pull the following kunit next update for Linux 6.14-rc1. - fixes struct completion warning - introduces autorun option - adds fallback for os.sched_getaffinity - enables hardware acceleration when available Note: Stephen reported duplicate patch in kunit and driver-core: The

[GIT PULL] kselftest next update for Linux 6.14-rc1

2025-01-21 Thread Shuah Khan
Hi Linus, Please pull the following kseltest update for Linux 6.14-rc1. - fixes, reporting improvements, and cleanup changes to several tests - adds support for DT_GNU_HASH to selftests/vDSO Note: Stephen reported conflict between the following two commits and the fix is in the linux-next:

Re: [PATCH] selftests/.gitignore include missing log file

2025-01-20 Thread Shuah Khan
On 1/16/25 01:59, Khaled Elnaggar wrote: Add tpm2/AsyncTest.log to .gitignore Signed-off-by: Khaled Elnaggar --- Hello After running kselftests, AsyncTest.log file showed when running git status. I just added it. --- tools/testing/selftests/.gitignore | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH] selftests/rseq: Fix handling of glibc without rseq support

2025-01-15 Thread Shuah Khan
On 1/14/25 17:45, Mathieu Desnoyers wrote: On 2025-01-14 19:14, Shuah Khan wrote: On 1/14/25 07:51, Mathieu Desnoyers wrote: When porting librseq commit: commit c7b45750fa85 ("Adapt to glibc __rseq_size feature detection") from librseq to the kernel selftests, the following line

Re: [PATCH] selftests/rseq: Fix handling of glibc without rseq support

2025-01-14 Thread Shuah Khan
On 1/14/25 07:51, Mathieu Desnoyers wrote: When porting librseq commit: commit c7b45750fa85 ("Adapt to glibc __rseq_size feature detection") from librseq to the kernel selftests, the following line was missed at the end of rseq_init(): rseq_size = get_rseq_kernel_feature_size(); which effe

  1   2   3   4   5   6   7   8   9   10   >