Re: [PATCH v4 1/3] mm/slub: Introduce two counters for partial objects

2021-03-28 Thread Shu Ming
I am not sure how people are using partial object accounting. I believe it is used as a memory usage hint of slabs. On Mon, Mar 22, 2021 at 6:22 PM Vlastimil Babka wrote: > > On 3/22/21 2:46 AM, Shu Ming wrote: > > More precisely, ss will count partial objects like denty objects wi

Re: [PATCH v4 1/3] mm/slub: Introduce two counters for partial objects

2021-03-21 Thread Shu Ming
More precisely, ss will count partial objects like denty objects with "/sys/kernel/slab/dentry/partial" whose number can become huge. On Thu, Mar 18, 2021 at 8:56 PM Xunlei Pang wrote: > > > > On 3/18/21 8:18 PM, Vlastimil Babka wrote: > > On 3/17/21 8:54 AM, Xunlei Pang wrote: > >> The node li

Re: [PATCH v2 3/3] mm/slub: Use percpu partial free counter

2021-03-02 Thread Shu Ming
On Mon, Aug 10, 2020 at 8:22 PM Xunlei Pang wrote: > static inline void > @@ -2429,12 +2439,12 @@ static unsigned long partial_counter(struct > kmem_cache_node *n, > unsigned long ret = 0; > > if (item == PARTIAL_FREE) { > - ret = atomic_long_read(&n->partial_free_

Re: [PATCH v2 0/3] mm/slub: Fix count_partial() problem

2021-03-01 Thread Shu Ming
Any progress on this? The problem addressed by this patch has also made jitters to our online apps which are quite annoying. On Mon, Aug 24, 2020 at 6:05 PM xunlei wrote: > > On 2020/8/20 下午10:02, Pekka Enberg wrote: > > On Mon, Aug 10, 2020 at 3:18 PM Xunlei Pang > > wrote: > >> > >> v1->v2:

Incorrect RSS page accounting of processes with multiple mapping pages

2021-02-07 Thread Shu Ming
Hi, I believe there is an unexpected RES page accounting when doing multiple page mapping. The sample code was pasted below. In the sample code, The same 1g pages are mapped for three times. And it is expected that the process gets 1g RES instead of 3g RES pages(top command showed result).