[PATCH v5 4/4] vdpa/octeon_ep: read vendor-specific PCI capability

2025-01-03 Thread Shijith Thotton
Added support to read the vendor-specific PCI capability to identify the type of device being emulated. Reviewed-by: Dan Carpenter Acked-by: Jason Wang Signed-off-by: Shijith Thotton --- drivers/vdpa/octeon_ep/octep_vdpa.h | 20 + drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 36

[PATCH v5 3/4] virtio-pci: define type and header for PCI vendor data

2025-01-03 Thread Shijith Thotton
Added macro definition for VIRTIO_PCI_CAP_VENDOR_CFG to identify the PCI vendor data type in the virtio_pci_cap structure. Defined a new struct virtio_pci_vndr_data for the vendor data capability header as per the specification. Acked-by: Jason Wang Signed-off-by: Shijith Thotton --- include

[PATCH v5 2/4] vdpa/octeon_ep: handle device config change events

2025-01-03 Thread Shijith Thotton
: Jason Wang Signed-off-by: Shijith Thotton --- drivers/vdpa/octeon_ep/octep_vdpa_main.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_main.c b/drivers/vdpa/octeon_ep/octep_vdpa_main.c index e9c3e57b321f..4d56be64ae56 100644 --- a/drivers/vdpa

[PATCH v5 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

2025-01-03 Thread Shijith Thotton
Carpenter Acked-by: Jason Wang Signed-off-by: Shijith Thotton --- v1: - https://lore.kernel.org/virtualization/20241120070508.789508-1-sthot...@marvell.com Changes in v2: - Handle reset getting called twice. - Use devm_kcalloc to allocate irq array. - IRQ is never zero. Adjusted code accordingly

[PATCH v4 4/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-12-13 Thread Shijith Thotton
Added support to read the vendor-specific PCI capability to identify the type of device being emulated. Reviewed-by: Dan Carpenter Signed-off-by: Shijith Thotton --- drivers/vdpa/octeon_ep/octep_vdpa.h | 20 + drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 36

[PATCH v4 3/4] virtio-pci: define type and header for PCI vendor data

2024-12-13 Thread Shijith Thotton
Added macro definition for VIRTIO_PCI_CAP_VENDOR_CFG to identify the PCI vendor data type in the virtio_pci_cap structure. Defined a new struct virtio_pci_vndr_data for the vendor data capability header as per the specification. Signed-off-by: Shijith Thotton --- include/uapi/linux/virtio_pci.h

[PATCH v4 2/4] vdpa/octeon_ep: handle device config change events

2024-12-13 Thread Shijith Thotton
: Jason Wang Signed-off-by: Shijith Thotton --- drivers/vdpa/octeon_ep/octep_vdpa_main.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_main.c b/drivers/vdpa/octeon_ep/octep_vdpa_main.c index e9c3e57b321f..4d56be64ae56 100644 --- a/drivers/vdpa

[PATCH v4 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

2024-12-13 Thread Shijith Thotton
Carpenter Acked-by: Jason Wang Signed-off-by: Shijith Thotton --- v1: - https://lore.kernel.org/virtualization/20241120070508.789508-1-sthot...@marvell.com Changes in v2: - Handle reset getting called twice. - Use devm_kcalloc to allocate irq array. - IRQ is never zero. Adjusted code accordingly

Re: [PATCH v3 4/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-12-13 Thread Shijith Thotton
>> >>> Added support to read the vendor-specific PCI capability to identify the >> >>> type of device being emulated. >> >>> >> >>> Reviewed-by: Dan Carpenter >> >>> Signed-off-by: Shijith Thotton >> >>>

RE: [PATCH v3 4/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-12-13 Thread Shijith Thotton
>>> >>> Added support to read the vendor-specific PCI capability to identify the >>> type of device being emulated. >>> >>> Reviewed-by: Dan Carpenter >>> Signed-off-by: Shijith Thotton >>> --- >>> drivers/vdpa/oct

Re: [PATCH v3 3/4] virtio-pci: define type and header for PCI vendor data

2024-12-13 Thread Shijith Thotton
>> Added macro definition for VIRTIO_PCI_CAP_VENDOR_CFG to identify the >PCI >> vendor data type in the virtio_pci_cap structure. Defined a new struct >> virtio_pci_vndr_data for the vendor data capability header as per the >> specification. >> >> Signed-off-

Re: [PATCH v3 4/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-12-13 Thread Shijith Thotton
>> >> Added support to read the vendor-specific PCI capability to identify the >> type of device being emulated. >> >> Reviewed-by: Dan Carpenter >> Signed-off-by: Shijith Thotton >> --- >> drivers/vdpa/octeon_ep/octep_vdpa.h | 20 +

[PATCH v3 4/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-12-09 Thread Shijith Thotton
Added support to read the vendor-specific PCI capability to identify the type of device being emulated. Reviewed-by: Dan Carpenter Signed-off-by: Shijith Thotton --- drivers/vdpa/octeon_ep/octep_vdpa.h | 20 ++ drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 33

[PATCH v3 2/4] vdpa/octeon_ep: handle device config change events

2024-12-09 Thread Shijith Thotton
: Jason Wang Signed-off-by: Shijith Thotton --- drivers/vdpa/octeon_ep/octep_vdpa_main.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_main.c b/drivers/vdpa/octeon_ep/octep_vdpa_main.c index e9c3e57b321f..4d56be64ae56 100644 --- a/drivers/vdpa

[PATCH v3 3/4] virtio-pci: define type and header for PCI vendor data

2024-12-09 Thread Shijith Thotton
Added macro definition for VIRTIO_PCI_CAP_VENDOR_CFG to identify the PCI vendor data type in the virtio_pci_cap structure. Defined a new struct virtio_pci_vndr_data for the vendor data capability header as per the specification. Signed-off-by: Shijith Thotton --- include/uapi/linux/virtio_pci.h

[PATCH v3 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

2024-12-09 Thread Shijith Thotton
Carpenter Signed-off-by: Shijith Thotton --- v1: - https://lore.kernel.org/virtualization/20241120070508.789508-1-sthot...@marvell.com Changes in v2: - Handle reset getting called twice. - Use devm_kcalloc to allocate irq array. - IRQ is never zero. Adjusted code accordingly. Changes in v3

Re: [PATCH v2 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

2024-12-09 Thread Shijith Thotton
oss multiple cores, improving parallelism and >> > performance. >> > >> > Signed-off-by: Shijith Thotton >> > --- >> > v1: >> > - https://urldefense.proofpoint.com/v2/url?u=https- >3A__lore.kernel.org_virtualization_20241120070508.789508-2D1- >2Ds

RE: [PATCH v2 4/4] vdpa/octeon_ep: add interrupt handler for virtio crypto device

2024-12-09 Thread Shijith Thotton
r processing data. >> >>I'm not sure I will get here but the recent kernel depends heavily on >>the tx interrupt for skb post processing as well. >> > >Currently, the device does not support TX interrupts. >This behavior may change in the future. >

Re: [PATCH v2 4/4] vdpa/octeon_ep: add interrupt handler for virtio crypto device

2024-12-06 Thread Shijith Thotton
. > >I'm not sure I will get here but the recent kernel depends heavily on >the tx interrupt for skb post processing as well. > Currently, the device does not support TX interrupts. This behavior may change in the future. >> >> Signed-off-by: Shijith Thotton >

RE: [EXTERNAL] Re: [PATCH v2 3/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-12-05 Thread Shijith Thotton
>> Added support to read the vendor-specific PCI capability to identify the >> type of device being emulated. >> >> Signed-off-by: Shijith Thotton >> --- >> drivers/vdpa/octeon_ep/octep_vdpa.h | 24 + >> dri

[PATCH v2 3/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-11-21 Thread Shijith Thotton
Added support to read the vendor-specific PCI capability to identify the type of device being emulated. Signed-off-by: Shijith Thotton --- drivers/vdpa/octeon_ep/octep_vdpa.h | 24 + drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 34 +++- drivers/vdpa

[PATCH v2 2/4] vdpa/octeon_ep: handle device config change events

2024-11-21 Thread Shijith Thotton
From: Satha Rao The first interrupt of the device is used to notify the host about device configuration changes, such as link status updates. The ISR configuration area is updated to indicate a config change event when triggered. Signed-off-by: Satha Rao Signed-off-by: Shijith Thotton

[PATCH v2 4/4] vdpa/octeon_ep: add interrupt handler for virtio crypto device

2024-11-21 Thread Shijith Thotton
Introduced an interrupt handler for the virtio crypto device, as its queue usage differs from that of network devices. While virtio network device receives packets only on even-indexed queues, virtio crypto device utilize all available queues for processing data. Signed-off-by: Shijith Thotton

[PATCH v2 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

2024-11-21 Thread Shijith Thotton
: Shijith Thotton --- v1: - https://lore.kernel.org/virtualization/20241120070508.789508-1-sthot...@marvell.com Changes in v2: - Handle reset getting called twice. - Use devm_kcalloc to allocate irq array. - IRQ is never zero. Adjusted code accordingly. drivers/vdpa/octeon_ep/octep_vdpa.h | 10

Re: [PATCH 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

2024-11-20 Thread Shijith Thotton
>> @@ -63,44 +80,53 @@ static irqreturn_t octep_vdpa_intr_handler(int irq, >void *data) >> static void octep_free_irqs(struct octep_hw *oct_hw) >> { >> struct pci_dev *pdev = oct_hw->pdev; >> +int irq; >> + >> +for (irq = 0; irq < oct_hw->nb_irqs && oct_hw->irqs; irq++) { >> +

Re: [PATCH 2/4] vdpa/octeon_ep: handle device config change events

2024-11-20 Thread Shijith Thotton
>> >> The first interrupt of the device is used to notify the host about >> device configuration changes, such as link status updates. The ISR >> configuration area is updated to indicate a config change event when >> triggered. >> >> Signed-off-by: Sa

[PATCH 4/4] vdpa/octeon_ep: add interrupt handler for virtio crypto device

2024-11-19 Thread Shijith Thotton
Introduced an interrupt handler for the virtio crypto device, as its queue usage differs from that of network devices. While virtio network device receives packets only on even-indexed queues, virtio crypto device utilize all available queues for processing data. Signed-off-by: Shijith Thotton

[PATCH 3/4] vdpa/octeon_ep: read vendor-specific PCI capability

2024-11-19 Thread Shijith Thotton
Added support to read the vendor-specific PCI capability to identify the type of device being emulated. Signed-off-by: Shijith Thotton --- drivers/vdpa/octeon_ep/octep_vdpa.h | 24 + drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 34 +++- drivers/vdpa

[PATCH 2/4] vdpa/octeon_ep: handle device config change events

2024-11-19 Thread Shijith Thotton
From: Satha Rao The first interrupt of the device is used to notify the host about device configuration changes, such as link status updates. The ISR configuration area is updated to indicate a config change event when triggered. Signed-off-by: Satha Rao Signed-off-by: Shijith Thotton

[PATCH 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

2024-11-19 Thread Shijith Thotton
: Shijith Thotton --- drivers/vdpa/octeon_ep/octep_vdpa.h | 10 +-- drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 2 - drivers/vdpa/octeon_ep/octep_vdpa_main.c | 88 3 files changed, 63 insertions(+), 37 deletions(-) diff --git a/drivers/vdpa/octeon_ep/octep_vdpa.h b

[tip:irq/core] genirq: Update irq stats from NMI handlers

2019-07-06 Thread tip-bot for Shijith Thotton
Commit-ID: c09cb1293523dd786ae54a12fd88001542cba2f6 Gitweb: https://git.kernel.org/tip/c09cb1293523dd786ae54a12fd88001542cba2f6 Author: Shijith Thotton AuthorDate: Fri, 5 Jul 2019 07:56:20 + Committer: Thomas Gleixner CommitDate: Sat, 6 Jul 2019 10:40:19 +0200 genirq: Update irq

[PATCH v2] genirq: update irq stats from NMI handlers

2019-07-05 Thread Shijith Thotton
this. With this change, we can see stats of the perf NMI interrupts on arm64. As NMI handlers can't update tot_count in irq descriptor, kstat_irqs() has been updated not to return tot_count for NMI. Fixes: 2dcf1fbcad35 ("genirq: Provide NMI handlers") Signed-off-by: Shijith Thot

Re: [PATCH] genirq: update irq stats from NMI handlers

2019-07-04 Thread Shijith Thotton
On 7/4/19 9:19 AM, Thomas Gleixner wrote: > On Thu, 4 Jul 2019, Shijith Thotton wrote: >> On 7/4/19 12:13 AM, Julien Thierry wrote: >>> Looking at handle_percpu_irq(), I think this might be acceptable. But >>> does it make sense to only have kstats for percpu NMIs? &

Re: [PATCH] genirq: update irq stats from NMI handlers

2019-07-04 Thread Shijith Thotton
Hi Julien, On 7/4/19 12:13 AM, Julien Thierry wrote: > On 04/07/2019 05:22, Shijith Thotton wrote: >> The NMI handlers handle_percpu_devid_fasteoi_nmi() and >> handle_fasteoi_nmi() added by commit 2dcf1fbcad35 ("genirq: Provide NMI >> handlers") do not update th

[PATCH] genirq: update irq stats from NMI handlers

2019-07-03 Thread Shijith Thotton
this. With this change, we can see stats of the perf NMI interrupts on arm64. Fixes: 2dcf1fbcad35 ("genirq: Provide NMI handlers") Signed-off-by: Shijith Thotton --- kernel/irq/chip.c | 4 1 file changed, 4 insertions(+) diff --git a/kernel/irq/chip.c b/kernel/irq/chip.

Re: [PATCH v6 00/19] Unify vDSOs across more architectures

2019-06-19 Thread Shijith Thotton
: 262 nsec/call clock-getres-tai:vdso: 258 nsec/call clock-gettime-boottime: syscall: 353 nsec/call clock-gettime-boottime:libc: 365 nsec/call clock-gettime-boottime:vdso: 362 nsec/call clock-getres-boottime: syscall: 260 nsec/call clock-getres-boottime:libc: 267 nsec/call clock-getres-boottime:vdso: 259 nsec/call clock-gettime-realtime: syscall: 344 nsec/call clock-gettime-realtime:libc: 73 nsec/call clock-gettime-realtime:vdso: 72 nsec/call clock-getres-realtime: syscall: 255 nsec/call clock-getres-realtime:libc: 7 nsec/call clock-getres-realtime:vdso: 4 nsec/call clock-gettime-realtime-coarse: syscall: 296 nsec/call clock-gettime-realtime-coarse:libc: 35 nsec/call clock-gettime-realtime-coarse:vdso: 33 nsec/call clock-getres-realtime-coarse: syscall: 258 nsec/call clock-getres-realtime-coarse:libc: 6 nsec/call clock-getres-realtime-coarse:vdso: 4 nsec/call getcpu: syscall: 237 nsec/call getcpu:libc: 242 nsec/call getcpu:vdso: not tested Note: vDSO version of getcpu not found gettimeofday: syscall: 378 nsec/call gettimeofday:libc: 73 nsec/call gettimeofday:vdso: 70 nsec/call Observed good improvement for some APIs with the patch. Tested-by: Shijith Thotton Thanks, Shijith

Re: [Qestion] Softlockup when send IPI to other CPUs

2019-01-25 Thread Shijith Thotton
On 01/24/2019 10:07 PM, Catalin Marinas wrote: > Hi Shijith, > > On Thu, Jan 24, 2019 at 07:00:42AM +, Shijith Thotton wrote: >> On 01/23/2019 11:45 PM, Catalin Marinas wrote: >>> diff --git a/arch/arm64/mm/flush.c b/arch/arm64/mm/flush.c >>> index 30695a8681

Re: [Qestion] Softlockup when send IPI to other CPUs

2019-01-23 Thread Shijith Thotton
Hi Catalin, On 01/23/2019 11:45 PM, Catalin Marinas wrote: > On Tue, Jan 22, 2019 at 05:44:02AM +, Will Deacon wrote: >> On Mon, Jan 21, 2019 at 02:21:28PM +, Catalin Marinas wrote: >>> arm64: Do not issue IPIs for user executable ptes >>> >>> From: Catalin Marinas >>> >>> Commit 3b8c9f1c

Re: [PATCH v4 00/10] steal tasks to improve CPU utilization

2019-01-04 Thread Shijith Thotton
On 07-Dec-18 3:09 AM, Steve Sistare wrote: > > When a CPU has no more CFS tasks to run, and idle_balance() fails to > find a task, then attempt to steal a task from an overloaded CPU in the > same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently > identify candidates. To minimize

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2019-01-04 Thread Shijith Thotton
On 22-Oct-18 8:40 PM, Steve Sistare wrote: > > When a CPU has no more CFS tasks to run, and idle_balance() fails to > find a task, then attempt to steal a task from an overloaded CPU in the > same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently > identify candidates. To minimize