(yeah, I made the same non-ASCII mistake...)
On 7/24/25 10:49 AM, Shannon Nelson wrote:
On 7/24/25 1:20 AM, Xiumei Mu wrote:
resent the reply again with "plain text mode"
On Thu, Jul 24, 2025 at 2:25 PM Hangbin Liu wrote:
Hi Xiumei,
On Thu, Jul 24, 2025 at 12:55:02PM +0800, Xiume
ks.
Acked-by: Shannon Nelson
On 12/8/20 5:53 AM, Zheng Yongjun wrote:
Simplify the return expression.
Signed-off-by: Zheng Yongjun
Acked-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/pensando
On 12/7/20 8:06 PM, Xiaohui Zhang wrote:
From: Zhang Xiaohui
If the hardware receives an oversized packet with too many rx fragments,
skb_shinfo(skb)->frags can overflow and corrupt memory of adjacent pages.
This becomes especially visible if it corrupts the freelist pointer of
a slab page.
I f
On 12/6/20 5:51 PM, Jesse Brandeburg wrote:
Xiaohui Zhang wrote:
From: Zhang Xiaohui
If the hardware receives an oversized packet with too many rx fragments,
skb_shinfo(skb)->frags can overflow and corrupt memory of adjacent pages.
This becomes especially visible if it corrupts the freelist p
some constants like
#define can_sleep true
so the code can be a little more readable.
Yes, I know we have this problem already in the call to
ionic_lif_addr(), which I'm annoyed with but haven't addressed yet.
So, if you want to deal with this now, fine, otherwise I'll take car
On 9/28/20 10:24 AM, Shannon Nelson wrote:
On 9/27/20 12:48 PM, Thomas Gleixner wrote:
From: Sebastian Andrzej Siewior
The in_interrupt() usage in this driver tries to figure out which
context
may sleep and which context may not sleep. in_interrupt() is not really
suitable as it misses both
of checks (always enabled or
debug option dependent) which cover all invalid conditions already, there
is no point in having inconsistent warnings in those drivers.
Just remove them.
Signed-off-by: Sebastian Andrzej Siewior
Signed-off-by: Thomas Gleixner
Cc: Shannon Nelson
Cc: Pensando Drivers
ain fully preemptible task context
Add 'can_sleep' arguments to the affected functions and let the callers
provide the context instead of letting the functions deduce it.
Signed-off-by: Sebastian Andrzej Siewior
Signed-off-by: Thomas Gleixner
Cc: Shannon Nelson
Cc: Pensando Drivers
On 8/9/20 7:38 PM, Xu Wang wrote:
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "devm_kcalloc".
Signed-off-by: Xu Wang
Acked-by: Shannon Nelson
---
drivers/ne
On 8/9/20 8:20 PM, Joe Perches wrote:
On Mon, 2020-08-10 at 02:38 +, Xu Wang wrote:
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "devm_kcalloc".
[]
diff --git a/drivers/net
lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: drivers/net/ethernet/pensando/ionic/ionic_lif.c:2004:3-9: preceding
lock on line 1998
CC: kbuild-...@lists.01.org
CC: linux-kernel@vger.kernel.org
TO: Shannon Nelson
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linu
);
return ERR_PTR(err);
Thanks!
Acked-by: Shannon Nelson
On 5/9/20 6:58 PM, Andrew Lunn wrote:
On Sat, May 09, 2020 at 06:01:51PM -0700, Shannon Nelson wrote:
On 5/8/20 9:35 PM, Luis Chamberlain wrote:
Device driver firmware can crash, and sometimes, this can leave your
system in a state which makes the device or subsystem completely
useless
On 5/8/20 9:35 PM, Luis Chamberlain wrote:
Device driver firmware can crash, and sometimes, this can leave your
system in a state which makes the device or subsystem completely
useless. Detecting this by inspecting /proc/sys/kernel/tainted instead
of scraping some magical words from the kernel lo
-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
index bc03cecf80cc9eb4..5beba915f69d12dd
On 10/12/19 10:45 AM, kbuild test robot wrote:
Hi Shannon,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a
commit: 77ceb68e29ccd25d923b6af59e74ecaf736cc4b7 ionic: Add notify
the Pensando family of Ethernet
adapters. More specific information on this driver can be
Thanks!
Acked-by: Shannon Nelson
fix_str, prefix_type, \
+ rowsize, groupsize, buf, len, ascii); \
+ } while (0)
#endif
#endif
Thanks, I hadn't had a chance to look into that one yet.
Acked-by: Shannon Nelson
dentity_fops) ? 0 : -EOPNOTSUPP;
+ ionic, &identity_fops);
}
void ionic_debugfs_add_sizes(struct ionic *ionic)
This has just recently been addressed by Nathan Chancellor
Either way,
Acked-by: Shannon Nelson
sln
uot;ionic: Add hardware init and device commands")
Link: https://github.com/ClangBuiltLinux/linux/issues/658
Signed-off-by: Nathan Chancellor
Acked-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
On 8/29/19 8:50 AM, Thomas Bogendoerfer wrote:
Break up the big ioc3 register struct into functional pieces to
make use in sub-function drivers more straightforward. And while
doing that get rid of all volatile access by using readX/writeX.
Signed-off-by: Thomas Bogendoerfer
---
diff --git a
On 7/16/19 12:20 AM, Felipe Balbi wrote:
Add a driver supporting Intel Timed GPIO controller available as part
of some Intel PMCs.
Signed-off-by: Felipe Balbi
Hi Felipe, just a couple of quick comments:
There are several places where a line is continued on the next line, but
should be inden
Acked-by: Shannon Nelson
Thanks!
sln
On Wed, May 22, 2019 at 4:25 PM dann frazier wrote:
>
> An ipsec structure will not be allocated if the hardware does not support
> offload. Fixes the following Oops:
>
> [ 191.045452] Unable to handle kernel NULL pointer dereference at vir
t; Fix up the SPDX identifier and remove the boiler plate text as it is
> redundant.
>
> Fixes: c861ef83d771 ("sun: Add SPDX license tags to Sun network drivers")
> Signed-off-by: Thomas Gleixner
> Cc: Shannon Nelson
> Cc: Zhu Yanjun
> Cc: David S. Miller
> Cc: net...@v
; + for (i = 0; i < prop_len; i++) {
> + err = niu_pci_eeprom_read(np, off + i);
> + if (err >= 0)
> + *prop_buf = err;
> + ++prop_buf;
ec.
Detected by CoverityScan, CID#146424 ("Resource Leak")
Fixes: 63a67fe229ea ("ixgbe: add ipsec offload add and remove SA")
Signed-off-by: Colin Ian King
Yep, thanks, good catch.
Acked-by: Shannon Nelson
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 2 +-
On 4/29/2018 6:31 PM, Wenwen Wang wrote:
In ethtool_get_rxnfc(), the object "info" is firstly copied from
user-space. If the FLOW_RSS flag is set in the member field flow_type of
"info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from
user-space because FLOW_RSS is newer and has new
Oh, yes, there it is, and the pointer to vio_dev_release() was already
set up a little earlier in this function.
Sorry for the noise.
sln
On Wed, Apr 25, 2018 at 8:59 AM, arvindY wrote:
>
>
> On Wednesday 25 April 2018 09:14 PM, Shannon Nelson wrote:
>>
>> On 4/25/2018
On 4/25/2018 7:56 AM, Arvind Yadav wrote:
Never directly free @dev after calling device_register(), even
if it returned an error. Always use put_device() to give up the
reference initialized.
Signed-off-by: Arvind Yadav
---
arch/sparc/kernel/vio.c | 2 +-
1 file changed, 1 insertion(+), 1 de
Shannon Nelson's request, xfrm_dev_state_add() fails if ESN is
requested and xdo_dev_state_advance_esn() is not implemented
This works for me - thanks!
Signed-off-by: Shannon Nelson
---
Documentation/networking/xfrm_device.txt | 3 +++
include/linux/netdevice.h| 1 +
in
On 1/11/2018 5:51 AM, Aviad Yehezkel wrote:
On 1/11/2018 10:28 AM, Yossi Kuperman wrote:
From: Shannon Nelson [mailto:shannon.nel...@oracle.com]
Sent: Thursday, January 11, 2018 5:21 AM
On 1/10/2018 3:09 PM, Yossi Kuperman wrote:
On 10 Jan 2018, at 19:36, Shannon Nelson
wrote:
On 1/10
On 1/10/2018 3:09 PM, Yossi Kuperman wrote:
On 10 Jan 2018, at 19:36, Shannon Nelson wrote:
On 1/10/2018 2:34 AM, yoss...@mellanox.com wrote:
From: Yossef Efraim
This patch adds ESN support to IPsec device offload.
Adding new xfrm device operation to synchronize device ESN.
Signed-off-by
On 1/10/2018 2:34 AM, yoss...@mellanox.com wrote:
From: Yossef Efraim
This patch adds ESN support to IPsec device offload.
Adding new xfrm device operation to synchronize device ESN.
Signed-off-by: Yossef Efraim
---
Changes from v1:
- Added documentation
---
Documentation/networking/xfrm_
On 11/28/2017 1:49 AM, yoss...@mellanox.com wrote:
From: Yossef Efraim
This patch adds ESN support to IPsec device offload.
Adding new xfrm device operation to synchronize device ESN.
Signed-off-by: Yossef Efraim
---
include/linux/netdevice.h | 1 +
include/net/xfrm.h| 12
On 11/30/2017 10:23 PM, Steffen Klassert wrote:
On Tue, Nov 28, 2017 at 11:49:30AM +0200, yoss...@mellanox.com wrote:
From: Yossef Efraim
This patch adds ESN support to IPsec device offload.
Adding new xfrm device operation to synchronize device ESN.
Signed-off-by: Yossef Efraim
---
includ
David Windsor
Reviewed-by: Hans Liljestrand
Signed-off-by: Elena Reshetova
Acked-by: Shannon Nelson
Thank you Shannon! Would you be able to take this patch into the respective tree
to propagate normally from there?
Best Regards,
Elena.
Hi Elena,
Dave Miller takes good care of the sparclinux
ff-by: Elena Reshetova
Acked-by: Shannon Nelson
---
arch/sparc/kernel/mdesc.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/arch/sparc/kernel/mdesc.c b/arch/sparc/kernel/mdesc.c
index fa466ce..821a724 100644
--- a/arch/sparc/kernel/mdesc.c
+++ b/arch/
Wilson
Cc: Shannon Nelson
Cc: Rob Herring
Cc: chris hyser
Cc: Tushar Dave
Cc: Tobias Klauser
Cc: net...@vger.kernel.org
Signed-off-by: Kees Cook
Acked-by: Shannon Nelson
---
drivers/net/ethernet/sun/cassini.c| 7 ---
drivers/net/ethernet/sun/ldmvsw.c | 3 +--
d
alloc".
* Replace the specification of a data structure by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.
Signed-off-by: Markus Elfring
Thanks Markus.
Acked-by: Shannon Nelson
---
drivers/char/hw_random/n2
us Elfring
Thanks Markus.
Acked-by: Shannon Nelson
---
drivers/char/hw_random/n2-drv.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
index 92dd4e925315..f3e67c768101 100644
--- a/drivers/char/hw
On 3/15/2017 1:50 AM, David Laight wrote:
From: Shannon Nelson
Sent: 14 March 2017 17:25
...
+ if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest)))
+ dev->stats.multicast++;
I'd guess that:
dev->stats.multicast += is_multicast_ether_ad
DC_EVENT_UP from
the underlying LDC protocol. Similarly, we take the link down when we
see the LDC_EVENT_RESET. Now when we see the ndo_open(), we reset the
link to get things talking again.
Orabug: 25525312
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldm
These patches remove some problems in handling of carrier state
with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and
add stats for debug and tracking of point-to-point connections
between the ldom VMs.
v2:
- added ldmvsw ndo_open to reset the LDC channel
- updated copyrights
Shannon
Track our used and unused queue indexies correctly. Otherwise, as ports
dropped out and returned, they all eventually ended up with the same
queue index.
Orabug: 25190537
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c | 24
drivers/net
ndividual queue/port stats. This patch breaks out the traffic counts
for the individual ports and gives us a little view into the state of
those connections.
Orabug: 25190537
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet.c| 116 -
drivers/n
ls
into the driver's tx_timeout handler. Simply removing these takes care
of the problem.
Orabug: 25190537
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvne
Make sure multicast packets get counted in the device.
Orabug: 25190537
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c
b/drivers/net/ethernet/sun
On 3/6/2017 3:15 PM, Shannon Nelson wrote:
These patches remove some problems in handling of carrier state
with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and
add stats for debug and tracking of point-to-point connections
between the ldom VMs.
Further testing shows a problem in one
On 3/6/2017 3:53 PM, Florian Fainelli wrote:
On 03/06/2017 03:15 PM, Shannon Nelson wrote:
When an ldom VM is bound, the network vswitch infrastructure is set up for
it, but was being forced 'UP' by the userland switch configuration script.
When 'UP' but not actually conne
ndividual queue/port stats. This patch breaks out the traffic counts
for the individual ports and gives us a little view into the state of
those connections.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet.c| 114 +
drivers/net/ethernet/sun/s
These patches remove some problems in handling of carrier state
with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and
add stats for debug and tracking of point-to-point connections
between the ldom VMs.
Shannon Nelson (5):
ldmvsw: better use of link up and down on ldom vswitch
DC_EVENT_UP from
the underlying LDC protocol. Similarly, we take the link down when we
see the LDC_EVENT_RESET.
Orabug: 25525312
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldmvsw.c | 10 +++---
drivers/net/ethernet/sun/sunvnet_common.c | 14 ++
2 files ch
ls
into the driver's tx_timeout handler. Simply removing these takes care
of the problem.
Orabug: 25190537
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvne
Make sure multicast packets get counted in the device.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c
b/drivers/net/ethernet/sun/sunvnet_common.c
Track our used and unused queue indices correctly. Otherwise, as ports
dropped out and returned, they all eventually ended up with the same
queue index.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c | 24
drivers/net/ethernet/sun
On 2/13/2017 11:06 AM, Joe Perches wrote:
On Mon, 2017-02-13 at 10:57 -0800, Shannon Nelson wrote:
The use of gotos for handling the incoming events made this code
harder to read and support than it should be. This patch straightens
out and clears up the logic.
Signed-off-by: Shannon Nelson
ommon module doesn't need module_init or _exit
v4:
- dropped the statistics patch
- fixed up "default" tag for SUNVNET_COMMON
Shannon Nelson (7):
sunvnet: make sunvnet common code dynamically loadable
sunvnet: update version and version printing
sunvnet: add memory barrier
kernels that aren't running the LDoms.
This patch makes the sunvnet_common into a dynamically loadable
module and makes sunvnet and ldmvsw dependent on sunvnet_common.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/Kconfig |8 ++--
drivers/net/ethernet/sun/sunvnet_com
and trigger the consumer to drain the dring.
Signed-off-by: Sowmini Varadhan
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c
b/drivers/net/ethernet
There have been several changes since the first version of this code, so
we bump the version number. While we're at it, we can simplify the
version printing a bit and drop a couple lines of code.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet.c | 14
delayed packets, enough to begin triggering retransmits
and affecting overall throughput. By turning off advertised support for
TSO and GSO we restore stable traffic flow through the bridge.
Orabug: 23293104
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldmvsw.c |5
: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c
b/drivers/net/ethernet/sun/sunvnet_common.c
index d124bde..65f7038 100644
--- a/drivers/net/ethernet/sun
New version and simplify the print code.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldmvsw.c | 14 --
1 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/sun/ldmvsw.c
b/drivers/net/ethernet/sun/ldmvsw.c
index 335b876..f0fe6cf
The use of gotos for handling the incoming events made this code
harder to read and support than it should be. This patch straightens
out and clears up the logic.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c | 94 ++---
1 files changed
In order to allow the underlying LDC and outstanding memory operations
to potentially catch up with the driver's Tx requests, add a memory
barrier before checking again for available tx descriptors.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |1 +
1
On 2/12/2017 3:16 AM, Sergei Shtylyov wrote:
Hello!
On 2/10/2017 8:38 PM, Shannon Nelson wrote:
When the sunvnet_common code was split out for use by both sunvnet
and the newer ldmvsw, it was made into a static kernel library, which
limits the usefulness of sunvnet and ldmvsw as loadables
On 2/11/2017 6:01 PM, David Miller wrote:
From: Stephen Hemminger
Date: Fri, 10 Feb 2017 16:22:08 -0800
On Fri, 10 Feb 2017 09:38:20 -0800
Shannon Nelson wrote:
+static void vsw_get_ethtool_stats(struct net_device *dev,
+ struct ethtool_stats *estats, u64
kernels that aren't running the LDoms.
This patch makes the sunvnet_common into a dynamically loadable
module and makes sunvnet and ldmvsw dependent on sunvnet_common.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/Kconfig |8 ++--
drivers/net/ethernet/sun/sunvnet_com
: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c
b/drivers/net/ethernet/sun/sunvnet_common.c
index e54bc95..64671f0 100644
--- a/drivers/net/ethernet/sun
Since we're collecting some stats in the driver code, let's support use
of the ethtool driver stats facility in both sunvnet and ldmvsw.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldmvsw.c | 63 +
drivers/net/ethernet/sun
There have been several changes since the first version of this code, so
we bump the version number. While we're at it, we can simplify the
version printing a bit and drop a couple lines of code.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet.c | 14
delayed packets, enough to begin triggering retransmits
and affecting overall throughput. By turning off advertised support for
TSO and GSO we restore stable traffic flow through the bridge.
Orabug: 23293104
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldmvsw.c |5
In order to allow the underlying LDC and outstanding memory operations
to potentially catch up with the driver's Tx requests, add a memory
barrier before checking again for available tx descriptors.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |1 +
1
and trigger the consumer to drain the dring.
Signed-off-by: Sowmini Varadhan
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c
b/drivers/net/ethernet
New version and simplify the print code.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldmvsw.c | 14 --
1 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/sun/ldmvsw.c
b/drivers/net/ethernet/sun/ldmvsw.c
index 3999fb7..3ef5c08
The use of gotos for handling the incoming events made this code
harder to read and support than it should be. This patch straightens
out and clears up the logic.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c | 94 ++---
1 files changed
ommon module doesn't need module_init or _exit
Shannon Nelson (8):
sunvnet: make sunvnet common code dynamically loadable
sunvnet: update version and version printing
sunvnet: add driver stats for ethtool support
sunvnet: add memory barrier before check for tx enable
sunvnet: str
On 2/8/2017 11:29 AM, David Miller wrote:
From: Shannon Nelson
Date: Tue, 7 Feb 2017 14:12:54 -0800
+static int __init sunvnet_common_init(void)
+{
+ pr_info("%s\n", version);
+ return 0;
+}
+module_init(sunvnet_common_init);
+
+static void __exit sunvnet_common
On 2/8/2017 7:59 AM, Sowmini Varadhan wrote:
On (02/07/17 14:12), Shannon Nelson wrote:
+
+ /* we don't expect any other bits */
+ BUG_ON(port->rx_event & ~(LDC_EVENT_DATA_READY |
+ LDC_EVENT_RESET |
+
: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c
b/drivers/net/ethernet/sun/sunvnet_common.c
index d2aed2c..9384db0 100644
--- a/drivers/net/ethernet/sun
and trigger the consumer to drain the dring.
Signed-off-by: Sowmini Varadhan
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c
b/drivers/net/ethernet
delayed packets, enough to begin triggering retransmits
and affecting overall throughput. By turning off advertised support for
TSO and GSO we restore stable traffic flow through the bridge.
Orabug: 23293104
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldmvsw.c |5
kernels that aren't running the LDoms.
This patch makes the sunvnet_common into a dynamically loadable
module and makes sunvnet and ldmvsw dependent on sunvnet_common.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/Kconfig |8 ++--
drivers/net/ethernet/sun/sunvnet_com
The use of gotos for handling the incoming events made this code
harder to read and support than it should be. This patch straightens
out and clears up the logic.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c | 94 ++---
1 files changed
In order to allow the underlying LDC and outstanding memory operations
to potentially catch up with the driver's Tx requests, add a memory
barrier before checking again for available tx descriptors.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |1 +
1
Since we're collecting some stats in the driver code, let's support use
of the ethtool driver stats facility in both sunvnet and ldmvsw.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldmvsw.c | 63 +
drivers/net/ethernet/sun
The sunvnet ldom virtual network driver was due for some updates and
a bugfix or two. These patches address a few items left over from
last year's make-over.
v2:
- changed memory barrier fix to use smp_wmb
- put NETIF_F_SG back into the advertised ldmvsw hw_features
Shannon Nels
New version and simplify the print code.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldmvsw.c | 14 --
1 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/sun/ldmvsw.c
b/drivers/net/ethernet/sun/ldmvsw.c
index 3999fb7..3ef5c08
There have been several changes since the first version of this code, so
we bump the version number. While we're at it, we can simplify the
version printing a bit and drop a couple lines of code.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet.c | 14
On 2/3/2017 2:11 PM, Eric Dumazet wrote:
Transmit completion might happen on another cpu, regardless of ldom.
Therefore you need smp_rmb() here ( like mellanox/mlx4/en_tx.c) , or
even smp_mb() as bnx2x does.
dma_rmb() is never used in this context.
In that case, it looks like there are a co
On 2/3/2017 9:59 AM, Eric Dumazet wrote:
On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote:
The ldmvsw driver is specifically for supporting the ldom virtual
networking by running in the primary ldom and using the LDC to connect
the remaining ldoms to the outside world via a bridge. With
On 2/3/2017 9:56 AM, Eric Dumazet wrote:
On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote:
In order to allow the underlying LDC and outstanding memory operations
to potentially catch up with the driver's Tx requests, add a memory
barrier before checking again for available tx descri
delayed packets, enough to begin triggering retransmits and
affecting overall throughput. By turning off advertised support for TSO
and GSO we restore stable traffic flow through the bridge.
Orabug: 23293104
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldmvsw.c |5
: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c
b/drivers/net/ethernet/sun/sunvnet_common.c
index 160b35a..a479a58 100644
--- a/drivers/net/ethernet/sun
kernels that aren't running the LDoms.
This patch makes the sunvnet_common into a dynamically loadable
module and makes sunvnet and ldmvsw dependent on sunvnet_common.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/Kconfig |9 ++---
drivers/net/etherne
The sunvnet ldom virtual network driver was due for some updates and
a bugfix or two. These patches address a few items left over from
last year's make-over.
Shannon Nelson (8):
sunvnet: make sunvnet common code dynamically loadable
sunvnet: update version and version printing
sunvnet
Since we're collecting some stats in the driver code, let's support use
of the ethtool driver stats facility in both sunvnet and ldmvsw.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldmvsw.c | 63 +
drivers/net/ethernet/sun
and trigger the consumer to drain the dring.
Signed-off-by: Sowmini Varadhan
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c
b/drivers/net/ethernet
New version and simplify the print code.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/ldmvsw.c | 14 --
1 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/sun/ldmvsw.c
b/drivers/net/ethernet/sun/ldmvsw.c
index 7c5dab4..552c0a9
1 - 100 of 169 matches
Mail list logo
