Hi Chris & Ulf,
I hope you find this patch for next.
Thanks,
Seungwon Jeon
On Wed, May 21, 2014, Seungwon Jeon wrote:
> On Wed, May 21, 2014, Doug Anderson wrote:
> > If we happened to get a data error at just the wrong time the dw_mmc
> > driver could get into a state w
after "mmc: dw_mmc: change to use recommended reset
procedure"
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
> ---
> Changes in v2:
> - Removed TODO
> - Set cmd to NULL before calling dw_mci_request_end()
>
> drivers/mmc/host/dw_mmc.c | 46 +++
...and they think something is wrong with their hardware.
>
> Remove the printouts. We'll leave it up to a higher level to report
> about errors.
Yes, your saying makes sense.
But in normal I/O, actual error information such as status below is useful,
isn't it?
Thanks,
Seungwon Je
On Tue, April 22, 2014, Ulf Hansson wrote:
> On 22 April 2014 12:53, Seungwon Jeon wrote:
> > On Tue, April 22, 2014, Ulf Hansson wrote:
> >> On 22 April 2014 08:57, Seungwon Jeon wrote:
> >> > As commit 3957848(mmc: drop the speed mode of card's state) ap
On Tue, April 22, 2014, Ulf Hansson wrote:
> On 22 April 2014 08:57, Seungwon Jeon wrote:
> > As commit 3957848(mmc: drop the speed mode of card's state) applies,
> > this change should be followed.
> >
> > drivers/net/wireless/rsi/rsi_91x_sdio.c:288:20:
declaration of
function 'mmc_card_set_highspeed' [-Werror=implicit-function-declaration]
drivers/net/wireless/rsi/rsi_91x_sdio.c:306:2: error: implicit declaration of
function 'mmc_card_highspeed' [-Werror=implicit-function-declaration]
Signed-off-by: Seungwon Jeon
---
driv
> I have used the version of the mmc tree from next-20140417 for today.
I didn't detect usage out of mmc-sub for that.
Let me fix and send a patch.
Thanks,
Seungwon Jeon
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this li
; > Reported by: Harold (SoonYeal) Yang
> > Signed-off-by: Ray Jui
> > Reviewed-by: Seungwon Jeon
> > ---
> > drivers/mmc/card/block.c |7 ---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/mmc/card/block.c b
On Tue, October 29, 2013, Doug Anderson wrote
> Seungwon,
>
> On Fri, Oct 25, 2013 at 2:29 AM, Seungwon Jeon wrote:
> >> By SDIO devices, are you referring to actual SDIO cards or some
> >> implementations of dw_mmc?
> >>
> >> As far as I unders
_flags like below.
unsigned int cmd_flags = req ? req->cmd_flags : 0;
Then, we could replace several 'if statement' without dereference.
if (req && req->cmd_flags & REQ_DISCARD) -> if (cmd_flags & REQ_DISCARD)
Just my suggestion.
Thanks,
Seungwon Jeon
>
On Thu, October 24, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Wed, Oct 23, 2013 at 12:25 PM, Seungwon Jeon wrote:
> >> >> + if (card->type == MMC_TYPE_SDIO ||
> >> >> + card->type == MMC_TYPE_SD_COMBO) {
> > &a
C_CMD_PRV_DAT_WAIT, 0);
> >> + clk_en_a_old = mci_readl(host, CLKENA);
> >> +
> >> + if (card->type == MMC_TYPE_SDIO ||
> >> + card->type == MMC_TYPE_SD_COMBO) {
&& card->qu
deprecated APIs.
>
> Cc: Seungwon Jeon
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.ht
Hi Ray,
Thank you for information. Your analysis is right.
I also noticed same problem.
If you'd like to submit patch, not to report, please send it with regular form.
Or I could send similar patch I have.
Thanks,
Seungwon Jeon
On Wed, Oct 23, 2013, Ray Jui wrote:
Hi Seungwon/Chris
dev_info(&slot->mmc->class_dev,
> - "Bus speed (slot %d) = %dHz (slot req %dHz, actual
> %dHZ"
> - " div = %d)\n", slot->id, host->bus_hz, slot->clock,
> -
On Fri, August 30, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Thu, Aug 29, 2013 at 12:04 AM, Seungwon Jeon wrote:
> >> I'd really still rather honor the MMC subsystem's request. It
> >> shouldn't _hurt_ to turn the clock off when the subsystem r
On Thu, August 29, 2013, Mischa Jonker wrote:
> Adapt Kconfig to include ARC in supported architectures
>
> Signed-off-by: Mischa Jonker
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
> ---
> drivers/mmc/host/Kconfig |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On Tuesday, August 27, 2013, Doug Anderson wrote:
> Jaehoon / Seungwon,
>
> On Mon, Aug 26, 2013 at 2:06 AM, Jaehoon Chung wrote:
> > On 08/26/2013 01:34 PM, Seungwon Jeon wrote:
> >> On Fri, August 23, 2013, Doug Anderson wrote:
> >>> Previously the dw_mmc
PD_CLK | SDMMC_CMD_PRV_DAT_WAIT, 0);
Basically dw_mmc driver uses host's low power mode(auto clock gating)
So, how about keeping origin code rather than programming clock setting to '0'?
> + } else if (slot->clock != host->current_speed || force_clkinit) {
And
Hi Doug,
Do you have any update for this series?
Please let me know.
Thanks,
Seungwon Jeon
On Sat, August 10, 2013, Doug Anderson wrote:
> This series of patches addresses some suspend/resume problems with
> dw_mmc on exynos platforms, espeically exynos5420. Since
> suspend/resume is
m is silent. Origin code has stood up somewhat
long.
Did you see?
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
>
> Signed-off-by: Derek Basehore
> Reviewed-by: Doug Anderson
> ---
> drivers/mmc/host/dw_mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
t; +/*
> + * TODO: we should probably disable the clock to the card in the suspend
> path.
In suspend, clock is gated, isn't it?
Rather, no comment looks better, if intention is not clear.
Thanks,
Seungwon Jeon
> + */
> +static int dw_mci_exynos_suspend(struct de
On Sat, August 10, 2013,Doug Anderson wrote:
> Seungwon,
>
> On Fri, Aug 9, 2013 at 6:35 AM, Seungwon Jeon wrote:
> > On Wed, August 07, 2013, Doug Anderson wrote:
> >> After suspend/resume all of the dw_mmc registers are reset to
> >> defaults. We restore mos
On Sat, August 10, 2013, Doug Anderson wrote:
> Seungwon and Jaehoon,
>
> On Fri, Aug 9, 2013 at 6:32 AM, Seungwon Jeon wrote:
> > On Wed, August 07, 2013, Doug Anderson wrote:
> >> The dw_mmc driver keeps a cache of the current slot->clock in order to
> >> a
os() is from
mmc_power_off().
On seeing fields of 'mmc->ios' stored last, these values aren't proper in
resume phase.
Please check mmc_power_off() function.
In case MMC_PM_KEEP_POWER it could be kept.
Thanks,
Seungwon Jeon
>
> There doesn't seem to be any reason that I
q);
> + dw_mci_exynos_pmops.resume_noirq = dw_mci_exynos_resume_noirq;
> + dw_mci_exynos_pmops.thaw_noirq = dw_mci_exynos_resume_noirq;
> + dw_mci_exynos_pmops.restore_noirq = dw_mci_exynos_resume_noirq;
If CONFIG_PM_SLEEP is not defined, we don't need to add it.
And also, inst
oks like another version of 'dw_mci_setup_bus(slot, true)'.
Eventually, this change does same?
Thanks,
Seungwon Jeon
>
> Invalidating the current_speed also means that we don't need to call:
> dw_mci_setup_bus(slot, true);
> ...to force an update of the clock in th
ike there is no actual use case for that though origin Synopsys IP
supports.
Multi-slot might be not useful in terms of performance because shared bus
should be allowed.
(At least this is the way I see it, though)
As Exynos's host does so, other hosts which are introduced in Linux seems u
On Tue, July 30, 2013, Mark Brown wrote:
> From: Mark Brown
>
> Use regulator_get_optional() to tell the core that requests for regulators
> can fail in a real system.
>
> Signed-off-by: Mark Brown
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
--
To unsubscribe from this l
c
xxx_noirq now.
I feel like it is for handling quirk.
If we meet use case for that in some day, it could be added commonly.
How do you think?
Thanks,
Seungwon Jeon
>
> Signed-off-by: Doug Anderson
> Reviewed-by: James Hogan
> ---
> Changes in v3:
> - Add freeze/thaw and poweroff/r
On Thu, July 11, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Wed, Jul 10, 2013 at 7:54 AM, Seungwon Jeon wrote:
> > On Wed, July 10, 2013, Doug Anderson wrote:
> >> If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up
> >> looping around
27;t know of any
> boards that need DW_MCI_QUIRK_IDMAC_DTO.
>
> Signed-off-by: Doug Anderson
Acked-by: Seungwon Jeon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:
erted. This bit is 1 to indicate that it fired and we can
> + * clear it by writing a 1 back. Clear it to prevent interrupts from going
> off
> + * constantly.
> + */
As I know this bit is auto-cleared.
Did you find the cause of this problem?
How about your GPIO setting in sleep?
Cur
here is data to send), but it makes the
> register dump before and after suspend clean.
>
> Signed-off-by: Doug Anderson
Acked-by: Seungwon Jeon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.
On Sat, June 29, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Mon, Jun 24, 2013 at 1:04 AM, Seungwon Jeon wrote:
> > This patch looks good to me. I agree above.
> > Card detection procedure of mmc subsystem will be started by mmc_start_host
> > during probe time.
Hi Jaehoon,
Do you have the same result?
Could you share the result?
Thanks,
Seungwon Jeon
On Tuesday, June 25 2013, Bing Zhao wrote:
> > I think the proposal on the table is to take Seungwon's patches
> > instead of mine. Assuming they solve your problems, I'm OK with tha
If a actual detection of card is triggered during probe, similar problem may be
occurred in spite of this patch.
Thanks,
Seungwon Jeon
>
> Specifically, I found that with just the right set of printouts in my
> system that one of the three SD/MMC devices in my system was having
> trouble p
On Thursday, June 13, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Wed, Apr 10, 2013 at 12:02 AM, Seungwon Jeon wrote:
> >> > There are two solutions we have applied.
> >>
> >> I'm a little confused. Have you already applied one or both of t
Looks good to me.
But this patch has a dependency on '[PATCH 2/2] mmc: dw_mmc: Add support DW
SD/MMC driver on SOCFPGA'
After that, it can be applied.(SDMMC_CMD_USE_HOLD_REG should be moved in
dw_mmc.h)
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
On 06/11/13 2013 8:31 PM Hei
On 06/11/13 2013 8:30 PM Heiko Stübner wrote:
> In a subsquent patch probe will need to do some handling of data from
> the dt match table. So to prevent the need for forward declarations,
> move probe and remove below the match table.
>
> Signed-off-by: Heiko Stuebner
Acked-by
mci_rockchip_prepare_command(struct dw_mci *host, u32 *cmdr)
> +{
> + *cmdr |= SDMMC_CMD_USE_HOLD_REG;
Currently, SDMMC_CMD_USE_HOLD_REG is defined in dw_mmc-exynos.c
It should be moved to dw_mmc.h
Thanks,
Seungwon Jeon
> +}
> +
> +static const struct dw_mci_drv_data rockchip_dr
On 06/03/13 2013 7:58 AM, Heiko Stübner wrote:
> dw_mci_pltfm_remove gets exported and used by dw_mmc-exynos, so should
> not be static.
>
> Signed-off-by: Heiko Stuebner
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line "unsubsc
On Sunday, May 12, 2013, Dolev Raviv wrote:
Author should be identified here. (From: author...)
Except last patch of series(8/8), all of patches are not from you.
> Simplify operations with hiding mmio_base.
>
> Signed-off-by: Seungwon Jeon
> Signed-off-by: Dolev Raviv
I'm n
On Tuesday, April 16, 2013, Doug Anderson
> Seungwon,
>
> On Mon, Apr 15, 2013 at 5:14 AM, Seungwon Jeon wrote:
> >> + MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23 | MMC_CAP_SDIO_IRQ,
> >> + MMC_CAP_CMD23 | MMC_CAP_SDIO_IRQ,
> > This line for [1]
> >&
23 | MMC_CAP_SDIO_IRQ,
This line for [1]
> + MMC_CAP_CMD23 | MMC_CAP_SDIO_IRQ,
> + MMC_CAP_CMD23 | MMC_CAP_SDIO_IRQ,
[1] is for mshc1. mshc1 is only used for SDIO.
As I know, The others are improper for SDIO.
Thanks,
Seungwon Jeon
> };
>
> static const struct dw_mci_dr
On Tuesday, April 09, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Mon, Apr 8, 2013 at 5:17 AM, Seungwon Jeon wrote:
> > I guess Doug are debugging it with wifi, right?
>
> Yes, we're debugging it on the Samsung ARM Chromebook on a part that
> has an SDIO WiFi
p(host);
- } else {
- /* Data transfer was stopped by the interrupt handler */
- set_bit(EVENT_XFER_COMPLETE, &host->pending_events);
}
+
+ set_bit(EVENT_XFER_COMPLETE, &host->pending_events);
}
If you have any opinion, please let me k
On Wednesday, March 27, 2013, Grant Grundler wrote:
> Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation.
For easily identifying, it would be good to point the commit id and subject.
> But when debugging a related issue (http://crbug.com/221828) I found
It is not easy to ca
On Wednesday, March 13, 2013, James Hogan wrote:
> On 13/03/13 14:20, Seungwon Jeon wrote:
> > Hi James,
> >
> > On Tuesday, March 12, 2013, James Hogan wrote:
> >> Call the setpower platform callback in response to set_ios with
> >> ios->power_mode ==
> of the while loop.
>
> Signed-off-by: Markos Chandras
> Cc: Seungwon Jeon
Acked-by: Seungwon Jeon
You can add my ack to other patches.
However, could you change the subject prefix to 'mmc: dw_mmc' and resend?
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send t
x27;t occur prior to host->data_offset being initialised.
>
> Signed-off-by: James Hogan
> Cc: Seungwon Jeon
Acked-by: Seungwon Jeon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
0: Bus speed (slot 0) = 9984Hz (slot req 30Hz, actual
> 298922HZ div = 167)
>
> Signed-off-by: James Hogan
> Cc: Seungwon Jeon
This patch is reasonable.
I just want to know though.
I guess this problem is happened when card is inserted as soon as card is
removed.
If not, could
On Saturday, February 23, 2013, Dongjin Kim wrote:
> This patch adds the compatible string for MSHC controller of Exynos4412.
> And exynos5250_dwmmc_caps is renamed to exynos_dwmmc_caps, since it has the
> capablities of common feature supported by Exynos4 and Exynos5.
>
> Cc
I think it's close to platform rather than Synopsys
itself.
I'm starting to compare the new generic parsing with dw_mmc.
> Similar situation would be happened to Exynos4210 which is not
> supported by dw_mmc-exynos.c yet.
Maybe not, it should be done.
Thanks,
Seungwon Jeon
>
> R
rmation of Exynos5250.
> > And suggestion do you have?
At least, these capabilities can be shared because of common feature, not fully
same.
Dongjin, could you modify the commit message and comments of code?
Let me introduce the functional feature of Exynos5250 and capability extension.
I gue
m concerning about this.
Thanks,
Seungwon Jeon
>
> Cc: Jaehoon Chung
> Cc: Sachin Kamat
> Signed-off-by: Dongjin Kim
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exy
Add maintainer entry for the Synopsys DW host driver which
is used in various SOC including EXYNOS series.
As Will Newton will no longer be able to take care of dw_mmc*,
I and Jaehoon Chung are willing to maintain it.
Signed-off-by: Seungwon Jeon
Signed-off-by: Jaehoon Chung
---
MAINTAINERS
c_suspend(struct mmc_host *host)
> >> else if (!mmc_host_is_spi(host))
> >> err = mmc_deselect_cards(host);
> >> host->card->state &= ~(MMC_STATE_HIGHSPEED |
> > MMC_STATE_HIGHSPEED_200);
> >> - mmc_release_host(host);
>
Doug, Thanks to work.
Looks good to me with other patches.
Acked-by: Seungwon Jeon
On Friday, November 30, 2012, Doug Anderson wrote:
> The "disable-wp" property is used to specify that a given SD card slot
> doesn't have a concept of write protect. This eliminates the ne
Hi Doug,
On Thursday, November 29, 2012, Doug Anderson wrote:
> Seungwon,
>
> Thanks for the review. See below for comments. If you'd like me to
> respin then please let me know. Otherwise I look forward to your ack.
>
> On Wed, Nov 28, 2012 at 1:29 AM, Seungwon Jeon
io property is empty?
I think wp-pin is valid for SD card, not eMMC/SDIO.
Of course, I know origin code did it.
How about removing whole checking routine?
Instead, new definition for this quirk can be added into
'dw_mci_of_quirks'(dw_mmc.c) and dts file.
Thanks,
Seungwon Jeon
> --
> 1.7.7.
On Thursday, November 22, 2012, Doug Anderson wrote:
> On Wed, Nov 21, 2012 at 5:42 PM, Seungwon Jeon wrote:
> > Hi,
> >
> > wp-gpios has been implemented in dw_mmc-exynos.c
> > It can be reused for EXYNOS platform? We need to modify some though.
>
> Yup,
Hi,
wp-gpios has been implemented in dw_mmc-exynos.c
It can be reused for EXYNOS platform? We need to modify some though.
Thanks,
Seungwon Jeon
On Thursday, November 22, 2012, Doug Anderson wrote:
> On some SoCs (like exynos5250) you need to use an external GPIO for
> write protect
; aliased to
> undefined symbol 'dw_mci_pltfm_match'
>
> CC: Chris Ball
> CC: Thomas Abraham
> CC: Will Newton
> CC: linux-...@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Sergei Trofimovich
> ---
Acked-by: Seungwon Jeon
I suggest changing
fm_probe() is used, as it sets host->drv_data to
> NULL, and that's only checked against NULL in 1 out of the 7 cases where
> it is dereferenced.
>
> Signed-off-by: James Hogan
Acked-by: Seungwon Jeon
Looks good to me.
Thanks.
Seungwon Jeon
--
To unsubscribe from this list
>
> > Further, we get a warning about the driver_data being
> > marked constant, which requires annotating a few pointers
> > as const.
> >
> > Signed-off-by: Arnd Bergmann
> > Cc: Chris Ball
> > Cc: Thomas Abraham
> > Cc: Will Newton
> &g
> }
> //
>
> Signed-off-by: Peter Senna Tschudin
Looks good.
Acked-by: Seungwon Jeon
> --
> 1.7.11.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
WQ_MEM_RECLAIM | WQ_NON_REENTRANT, 1);
> - if (!host->card_workqueue)
> + if (!host->card_workqueue) {
> + err = -ENOMEM;
ret is expected instead of err.
err isn't defined.
Thanks,
Seungwon Jeon
> goto err_dmaunmap;
> +
led and it will get
> + * re-enabled again in dw_mci_setup_bus().
> + */
> + dw_mci_disable_low_power(slot);
> +
> mci_writel(host, INTMASK,
> (int_mask | SDMMC_INT_SDIO(slot->id)));
> }
low power mode for SDIO cards
> + * if we need interrupts to work.
Above comment is correct, but this is not specific for Exynos5250.
Exynos5250 is just one of host controllers base on Synopsys's.
It'd be better to remove the part related to Exynos you mentioned .
> + *
> + * T
July 23, 2012, Thomas Abraham wrote:
> On 20 July 2012 16:08, Seungwon Jeon wrote:
> > July 20, 2012, Thomas Abraham wrote:
> >> On 19 July 2012 09:21, Seungwon Jeon wrote:
>
> [...]
>
> >> >> +static unsigned long exynos5250_dwmmc_c
July 20, 2012, Thomas Abraham wrote:
> On 19 July 2012 09:21, Seungwon Jeon wrote:
> > Hi,
> >
> > This version does not seems to consider previous reviews fully.
> > Could you check the comments below?
>
> I did try to address all the comments. I will che
host->bus_hz = host->pdata->bus_hz;
> + else
> + host->bus_hz = clk_get_rate(host->ciu_clk);
I have posted similar patch some time back.
bus_hz represents input rate for cclk_in of mshc.
Host of samsung soc doesn't use input clock from system directly.
As
MC_CMD_USE_HOLD_REG BIT(29)
> #define SDMMC_CMD_CCS_EXPBIT(23)
> #define SDMMC_CMD_CEATA_RD BIT(22)
> #define SDMMC_CMD_UPD_CLKBIT(21)
> @@ -142,6 +144,17 @@
> /* Version ID register define */
> #define SDMMC_GET_VERID(x)
74 matches
Mail list logo
