Re: [PATCH v2 2/3] selftests/nolibc: use file driver for QEMU serial

On 6/24/25 12:15 AM, Thomas Weißschuh wrote: > For the test implementation of the SuperH architecture a second serial > serial port needs to be used. Unfortunately the currently used 'stdio' "Serial" typed twice? :-) > driver does not support multiple serial ports at the same time. > > Switc

Re: [PATCH 10/19] USB: gadget/legacy: remove sb_mutex

On 9/13/23 2:10 PM, Christoph Hellwig wrote: > Creating new a new super_block vs freeing the old one for single instance ^ I can't parse that. :-) > file systems is serialized by the wait for SB_DEAD. > > Remove the superfluous sb_mutex. > > Signed-off-by: Christoph Hellwi

Re: [PATCH 5.4 03/74] module: merge repetitive strings in module_sig_check()

with the same text. >>> Let's put the starting text into the pr_notice() call -- it saves 21 >>> bytes of the object code (x86 gcc 10.2.1). >>> >>> Suggested-by: Joe Perches >>> Reviewed-by: Miroslav Benes >>> Signed-off-by: Sergey

Re: [PATCH 5.4 03/74] module: merge repetitive strings in module_sig_check()

On 4/5/21 11:53 AM, Greg Kroah-Hartman wrote: > From: Sergey Shtylyov > > [ Upstream commit 705e9195187d85249fbb0eaa844b1604a98fbc9a ] > > The 'reason' variable in module_sig_check() points to 3 strings across > the *switch* statement, all needlessly starting wit

[PATCH] sata_mv: add IRQ checks

mode). Fixes: f351b2d638c3 ("sata_mv: Support SoC controllers") Signed-off-by: Sergey Shtylyov --- drivers/ata/sata_mv.c |4 1 file changed, 4 insertions(+) Index: linux-block/drivers/ata/sata_mv.c === --- linux-blo

[PATCH v2] module: fix comment style

ome reason?) the starts of the multi-line comments not being /* on their own line... Signed-off-by: Sergey Shtylyov --- This patch is against the 'modules-next' branch of Jessica Yu's 'linux.git' repo plus my 2 patches posted this week. I'm not sure such patches ar

[PATCH] module: fix comment style

ome reason?) the starts of the multi-line comments not being /* on their own line... Signed-off-by: Sergey Shtylyov --- This patch is against the 'modules-next' branch of Jessica Yu's 'linux.git' repo plus my 2 patches posted this week. I'm not sure such patches ar

[PATCH 2/2] module: add more 'kernel-doc' comments

Some functions have the proper 'kernel-doc' comments but these don't start with proper /** -- fix that, along with adding () to the function name on the following lines to fully comply with the 'kernel-doc' format. Signed-off-by: Sergey Shtylyov --- kernel/module.c |

[PATCH 1/2] module: fix up 'kernel-doc' comments

Some 'kernel-doc' function comments do not fully comply with the specified format due to: - missing () after the function name; - "RETURNS:"/"Returns:" instead of "Return:" when documenting the function's result. - empty line before describing the

[PATCH 0/2] module: add/fix 'kernel-doc' comments

Here are 2 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo. I'm cleaning up the 'kernel-doc' function comments... [1/2] module: fix up 'kernel-doc' comments [2/2] module: add more 'kernel-doc' comments

[PATCH v2 3/3] module: only handle errors with the *switch* statement in module_sig_check()

/dash, spell out "nomem" as "lack of memory" in these comments, while at it... Suggested-by: Joe Perches Signed-off-by: Sergey Shtylyov --- Changes in version 2: - new patch. kernel/module.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletion

[PATCH v2 2/3] module: avoid *goto*s in module_sig_check()

Let's move the common handling of the non-fatal errors after the *switch* statement -- this avoids *goto*s inside that *switch*... Suggested-by: Joe Perches Signed-off-by: Sergey Shtylyov --- Changes in version 2: - new patch. kernel/module.c | 20 ++-- 1 file change

[PATCH v2 1/3] module: merge repetitive strings in module_sig_check()

Signed-off-by: Sergey Shtylyov --- Changes in version 2: - put less starting text into the pr_notice() call; - updated the patch description accordingly, added the "Suggested-by:" tag. kernel/module.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) Ind

[PATCH v2 0/3] module: refactor module_sig_check()

Here are 3 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo. I'm doing some refactoring in module_sig_check()... [1/3] module: merge repetitive strings in module_sig_check() [2/3] module: avoid *goto*s in module_sig_check() [3/3] module: only handle errors with the *swit

Re: [PATCH 0/2] module: some refactoring in module_sig_check()

Hello! On 10/22/20 6:09 PM, Jessica Yu wrote: >> Here are 2 patches against the 'modules-next' branch of Jessica Yu's >> 'linux.git' repo. >> I'm doing some little refactoring in module_sig_check()... >> >> [1/2] module: merge repetitive strings in module_sig_check() >> [2/2] module: unindent co

Re: [PATCH 0/2] module: some refactoring in module_sig_check()

On 10/14/20 11:35 AM, Joe Perches wrote: [...] Here are 2 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo. I'm doing some little refactoring in module_sig_check()... [1/2] module: merge repetitive strings in module_sig_check() [2/2] module:

Re: [PATCH 0/2] module: some refactoring in module_sig_check()

Hello! On 14.10.2020 1:44, Joe Perches wrote: Here are 2 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo. I'm doing some little refactoring in module_sig_check()... [1/2] module: merge repetitive strings in module_sig_check() [2/2] module: unindent comments in modul

[PATCH 1/2] module: merge repetitive strings in module_sig_check()

bytes of object code (x86 gcc 10.2.1). Signed-off-by: Sergey Shtylyov --- kernel/module.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) Index: linux/kernel/module.c === --- linux.orig/kernel/module.c +++ linux/

[PATCH 2/2] module: unindent comments in module_sig_check()

: Sergey Shtylyov --- kernel/module.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) Index: linux/kernel/module.c === --- linux.orig/kernel/module.c +++ linux/kernel/module.c @@ -2901,10 +2901,11 @@ static int

[PATCH 0/2] module: some refactoring in module_sig_check()

Here are 2 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo. I'm doing some little refactoring in module_sig_check()... [1/2] module: merge repetitive strings in module_sig_check() [2/2] module: unindent comments in module_sig_check()

Re: [PATCH 0/2] module: n module_sig_check()

Oops, hadn't finished the subject... :-/\

[PATCH 0/2] module: n module_sig_check()

Here are 2 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo. I'm doing some little refactoring in module_sig_check()... [1/2] module: merge repetitive strings in module_sig_check() [2/2] module: unindent comments in module_sig_check()