Hi Antonio,
the question was addressed to Sabrina, but since I've already touched
this topic in the another patch, let me put my 2c here.
On 16.11.2024 02:33, Antonio Quartulli wrote:
On 31/10/2024 16:25, Sabrina Dubroca wrote:
2024-10-29, 11:47:25 +0100, Antonio Quartulli wrote:
+static vo
On 15.11.2024 17:02, Antonio Quartulli wrote:
On 11/11/2024 02:54, Sergey Ryazanov wrote:
[...]
+/* Called after decrypt to write the IP packet to the device.
+ * This method is expected to manage/free the skb.
+ */
+static void ovpn_netdev_write(struct ovpn_peer *peer, struct sk_buff
*skb
On 25.11.2024 15:07, Antonio Quartulli wrote:
On 25/11/2024 03:26, Sergey Ryazanov wrote:
OpenVPN (userspace) will tear down the P2P interface upon
disconnection, assuming the --persist-tun option was not specified by
the user.
So the interface is gone in any case.
By keeping the netcarrier
On 24.11.2024 00:52, Antonio Quartulli wrote:
On 23/11/2024 23:25, Sergey Ryazanov wrote:
On 21.11.2024 23:17, Antonio Quartulli wrote:
On 20/11/2024 23:56, Sergey Ryazanov wrote:
On 15.11.2024 16:13, Antonio Quartulli wrote:
On 09/11/2024 02:11, Sergey Ryazanov wrote:
On 29.10.2024 12:47
On 21.11.2024 23:17, Antonio Quartulli wrote:
On 20/11/2024 23:56, Sergey Ryazanov wrote:
On 15.11.2024 16:13, Antonio Quartulli wrote:
On 09/11/2024 02:11, Sergey Ryazanov wrote:
On 29.10.2024 12:47, Antonio Quartulli wrote:
An ovpn interface will keep carrier always on and let the user
On 21.11.2024 23:23, Antonio Quartulli wrote:
On 21/11/2024 00:22, Sergey Ryazanov wrote:
On 13.11.2024 12:03, Sabrina Dubroca wrote:
2024-11-13, 03:37:13 +0200, Sergey Ryazanov wrote:
On 12.11.2024 19:31, Sabrina Dubroca wrote:
2024-11-10, 15:38:27 +0200, Sergey Ryazanov wrote:
On
On November 21, 2024 11:36:19 PM, Antonio Quartulli wrote:
>On 21/11/2024 00:58, Sergey Ryazanov wrote:
>> On 15.11.2024 16:28, Antonio Quartulli wrote:
>>> On 10/11/2024 19:26, Sergey Ryazanov wrote:
>>>> On 29.10.2024 12:47, Antonio Quartulli wrote:
>&
On 15.11.2024 16:39, Antonio Quartulli wrote:
On 11/11/2024 00:54, Sergey Ryazanov wrote:
Another one forgotten question, sorry about this. Please find the
question inlined.
On 29.10.2024 12:47, Antonio Quartulli wrote:
/* Send user data to the network
*/
netdev_tx_t ovpn_net_xmit
On 15.11.2024 16:28, Antonio Quartulli wrote:
On 10/11/2024 19:26, Sergey Ryazanov wrote:
On 29.10.2024 12:47, Antonio Quartulli wrote:
[...]
+static bool ovpn_socket_hold(struct ovpn_socket *sock)
+{
+ return kref_get_unless_zero(&sock->refcount);
Why do we need to wrap th
On 19.11.2024 15:44, Antonio Quartulli wrote:
On 15/11/2024 15:28, Antonio Quartulli wrote:
[...]
+}
+
+static struct ovpn_socket *ovpn_socket_get(struct socket *sock)
+{
+ struct ovpn_socket *ovpn_sock;
+
+ rcu_read_lock();
+ ovpn_sock = rcu_dereference_sk_user_data(sock->sk);
+ if
On 13.11.2024 12:03, Sabrina Dubroca wrote:
2024-11-13, 03:37:13 +0200, Sergey Ryazanov wrote:
On 12.11.2024 19:31, Sabrina Dubroca wrote:
2024-11-10, 15:38:27 +0200, Sergey Ryazanov wrote:
On 29.10.2024 12:47, Antonio Quartulli wrote:
An ovpn_peer object holds the whole status of a remote
On 15.11.2024 16:13, Antonio Quartulli wrote:
On 09/11/2024 02:11, Sergey Ryazanov wrote:
On 29.10.2024 12:47, Antonio Quartulli wrote:
An ovpn interface will keep carrier always on and let the user
decide when an interface should be considered disconnected.
This way, even if an ovpn
On 15.11.2024 16:03, Antonio Quartulli wrote:
On 10/11/2024 21:42, Sergey Ryazanov wrote:
Missed the most essential note regarding this patch :)
On 29.10.2024 12:47, Antonio Quartulli wrote:
+static int ovpn_net_open(struct net_device *dev)
+{
+ netif_tx_start_all_queues(dev);
+ return
On 15.11.2024 12:19, Antonio Quartulli wrote:
On 09/11/2024 00:31, Sergey Ryazanov wrote:
On 29.10.2024 12:47, Antonio Quartulli wrote:
+/**
+ * struct ovpn_struct - per ovpn interface state
+ * @dev: the actual netdev representing the tunnel
+ * @dev_tracker: reference tracker for associated
On 15.11.2024 12:05, Antonio Quartulli wrote:
On 09/11/2024 00:15, Sergey Ryazanov wrote:
On 29.10.2024 12:47, Antonio Quartulli wrote:
@@ -37,7 +41,7 @@ static int ovpn_newlink(struct net *src_net, struct
net_device *dev,
}
static struct rtnl_link_ops ovpn_link_ops = {
- .kind = "
On 14.11.2024 10:07, Antonio Quartulli wrote:
On 12/11/2024 17:47, Sabrina Dubroca wrote:
2024-11-09, 03:01:21 +0200, Sergey Ryazanov wrote:
On 29.10.2024 12:47, Antonio Quartulli wrote:
+/* When the OpenVPN protocol is ran in AEAD mode, use
+ * the OpenVPN packet ID as the AEAD nonce
On 14.11.2024 17:33, Antonio Quartulli wrote:
On 06/11/2024 02:18, Sergey Ryazanov wrote:
Regarding "big" topics I have only two concerns: link creation using
RTNL and a switch statement usage. In the corresponding thread, I
asked Jiri to clarify that "should" regarding .ne
On 12.11.2024 19:31, Sabrina Dubroca wrote:
2024-11-10, 15:38:27 +0200, Sergey Ryazanov wrote:
On 29.10.2024 12:47, Antonio Quartulli wrote:
An ovpn_peer object holds the whole status of a remote peer
(regardless whether it is a server or a client).
This includes status for crypto, tx/rx
On 12.11.2024 18:47, Sabrina Dubroca wrote:
2024-11-09, 03:01:21 +0200, Sergey Ryazanov wrote:
On 29.10.2024 12:47, Antonio Quartulli wrote:
+/* When the OpenVPN protocol is ran in AEAD mode, use
+ * the OpenVPN packet ID as the AEAD nonce:
+ *
+ *0005 521c3b01 4308c041
+ *[seq
On 04.11.2024 13:26, Sabrina Dubroca wrote:
2024-10-29, 11:47:27 +0100, Antonio Quartulli wrote:
struct ovpn_peer *ovpn_peer_get_by_transp_addr(struct ovpn_struct *ovpn,
struct sk_buff *skb)
{
- struct ovpn_peer *peer = NULL;
+ struc
On 29.10.2024 12:47, Antonio Quartulli wrote:
+static void ovpn_netdev_write(struct ovpn_peer *peer, struct sk_buff *skb)
+{
+ unsigned int pkt_len;
+
+ /* we can't guarantee the packet wasn't corrupted before entering the
+* VPN, therefore we give other layers a chance to che
On 29.10.2024 12:47, Antonio Quartulli wrote:
Packets received over the socket are forwarded to the user device.
Implementation is UDP only. TCP will be added by a later patch.
Note: no decryption/decapsulation exists yet, packets are forwarded as
they arrive without much processing.
Signed-of
Another one forgotten question, sorry about this. Please find the
question inlined.
On 29.10.2024 12:47, Antonio Quartulli wrote:
/* Send user data to the network
*/
netdev_tx_t ovpn_net_xmit(struct sk_buff *skb, struct net_device *dev)
{
+ struct ovpn_struct *ovpn = netdev_priv(
On 29.10.2024 12:47, Antonio Quartulli wrote:
Packets sent over the ovpn interface are processed and transmitted to the
connected peer, if any.
Implementation is UDP only. TCP will be added by a later patch.
Note: no crypto/encapsulation exists yet. packets are just captured and
sent.
Signed-o
Missed the most essential note regarding this patch :)
On 29.10.2024 12:47, Antonio Quartulli wrote:
+static int ovpn_net_open(struct net_device *dev)
+{
+ netif_tx_start_all_queues(dev);
+ return 0;
+}
+
+static int ovpn_net_stop(struct net_device *dev)
+{
+ netif_tx_stop_all_
On 29.10.2024 12:47, Antonio Quartulli wrote:
[...]
+static void ovpn_peer_release(struct ovpn_peer *peer)
+{
+ ovpn_bind_reset(peer, NULL);
+
nit: this empty line after ovpn_bind_reset() is removed in the
'implement basic TX path (UDP)' patch. What tricks git and it produces a
sensle
On 29.10.2024 12:47, Antonio Quartulli wrote:
This specific structure is used in the ovpn kernel module
to wrap and carry around a standard kernel socket.
ovpn takes ownership of passed sockets and therefore an ovpn
specific objects is attached to them for status tracking
purposes.
Initially on
On 29.10.2024 12:47, Antonio Quartulli wrote:
An ovpn_peer object holds the whole status of a remote peer
(regardless whether it is a server or a client).
This includes status for crypto, tx/rx buffers, napi, etc.
Only support for one peer is introduced (P2P mode).
Multi peer support is introdu
On 29.10.2024 12:47, Antonio Quartulli wrote:
An ovpn interface will keep carrier always on and let the user
decide when an interface should be considered disconnected.
This way, even if an ovpn interface is not connected to any peer,
it can still retain all IPs and routes and thus prevent any d
On 29.10.2024 12:47, Antonio Quartulli wrote:
Add basic infrastructure for handling ovpn interfaces.
Signed-off-by: Antonio Quartulli
---
drivers/net/ovpn/main.c | 115 --
drivers/net/ovpn/main.h | 7 +++
drivers/net/ovpn/ovpnstruct.h |
On 29.10.2024 12:47, Antonio Quartulli wrote:
This commit introduces basic netlink support with family
registration/unregistration functionalities and stub pre/post-doit.
More importantly it introduces the YAML uAPI description along
with its auto-generated files:
- include/uapi/linux/ovpn.h
- d
On 29.10.2024 12:47, Antonio Quartulli wrote:
This commit introduces basic netlink support with family
registration/unregistration functionalities and stub pre/post-doit.
More importantly it introduces the YAML uAPI description along
with its auto-generated files:
- include/uapi/linux/ovpn.h
- d
Hi Antonio,
On 29.10.2024 12:47, Antonio Quartulli wrote:
Notable changes from v10:
* extended commit message of 23/23 with brief description of the output
* Link to v10:
https://lore.kernel.org/r/20241025-b4-ovpn-v10-0-b87530777...@openvpn.net
Please note that some patches were already review
Hello Jiri,
Sorry for the late reply. Could you elaborate a bit reasons for the RTNL
interface implementation? Please find the questions inlined.
On 08.10.2024 15:52, Jiri Pirko wrote:
Tue, Oct 08, 2024 at 11:16:01AM CEST, anto...@openvpn.net wrote:
On 08/10/2024 10:58, Jiri Pirko wrote:
Tu
Caller (generic PCI code) already does proper locking, so no need to add
> another one here. Local PCI read/write functions are never called
> simultaneously, also they do not require synchronization with the PCI
> controller ops, since they are used before the controller registration.
>
>
On Tue, Apr 13, 2021 at 4:28 PM Sergey Ryazanov wrote:
> On Tue, Apr 13, 2021 at 9:22 AM Ilya Lipnitskiy
> wrote:
> > Mirror pci-rt3883 fix from commit e5067c718b3a ("MIPS: pci-rt3883:
> > Remove odd locking in PCI config space access code"). pci-rt2880 shares
&g
and
rt2880_pci_config_read()/rt2880_pci_config_write() functions.
The code that uses rt2880_pci_write_u32()/rt2880_pci_read_u32() in the
pcibios_map_irq() duplicates a BAR initialization procedure, which is
already performed by the rt288x_pci_probe().
Maybe we should remove duplicated code in the pcibios_map_irq() to
reduce duplication and to avoid possible race in configuration space
access?
If you fix this possible race, feel free to add in the next patch version my
Reviewed-by: Sergey Ryazanov
--
Sergey
; Signed-off-by: Ilya Lipnitskiy
> Cc: Sergey Ryazanov
> Cc: triv...@kernel.org
Yep, I overlooked these local variables. Thank you.
Acked-by: Sergey Ryazanov
--
Sergey
2015-07-03 12:11 GMT+03:00 Alban Bedel :
> To prepare moving the GPIO driver to drivers/gpio remove the
> platform specific pinmux API. As it is not used by any board,
> and such functionality should better be implemented using the
> pinmux subsystem just removing it seems to be the best option.
>
_handler_and_data().
Reviewed-by: Sergey Ryazanov
--
Sergey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
_handler_and_data().
Reviewed-by: Sergey Ryazanov
Though it's nearly impossible to trigger a race here, since SoC boot
up with disabled PCI interrupts.
--
Sergey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.k
_handler_and_data().
Reviewed-by: Sergey Ryazanov
I'm agree with this change, but could you use a bit shorter
function names for API? Somebody could just fall asleep while typing
such name :)
--
Sergey
--
To unsubscribe from this list: send the line "unsubscribe linux-kerne
x.c |2 +-
> arch/mips/pci/pci-rt3883.c |2 +-
> arch/mips/ralink/irq.c |2 +-
> 14 files changed, 23 insertions(+), 23 deletions(-)
>
Acked-by: Sergey Ryazanov
--
Sergey
--
To unsubscribe from this list: send the line "unsu
|2 +-
> arch/mips/pci/pci-rt3883.c |2 +-
> arch/mips/ralink/irq.c |2 +-
> 8 files changed, 10 insertions(+), 8 deletions(-)
>
For ath25 (AR231x/AR5312) changes
Acked-by: Sergey Ryazanov
--
Sergey
--
To unsubscribe from this list: send the line "unsu
2015-05-31 2:52 GMT+03:00 Alban Bedel :
> +
> +Example:
> +
> + interrupt-controller@18060010 {
> + compatible = "qca,ar9132-misc-intc", qca,ar7100-misc-intc";
Sorry for meticulousness, but seems you missed a quote :)
--
Sergey
--
To unsubscribe from this list: send the line
2015-05-29 20:59 GMT+03:00 Andrew Lunn :
> On Fri, May 29, 2015 at 10:36:49AM -0700, Mathieu Olivari wrote:
>> Alternatively, we could have something similar to what happens for the phy
>> in the wireless subsystems. Wireless PHYs are not registered as net_device
>> but they can still be listed, qu
oon, get this removed now.
>
> Cc: Sergey Ryazanov
> Cc: linux-m...@linux-mips.org
> Signed-off-by: Paul Gortmaker
Looks like I missed that this macro is scheduled for removing.
Acked-by: Sergey Ryazanov
--
Sergey
--
To unsubscribe from this list: send the line "unsubscribe
2014-09-10 15:36 GMT+04:00, Jiri Slaby :
> On 09/10/2014, 12:33 PM, Sergey Ryazanov wrote:
>> 2014-09-09 22:27 GMT+04:00, John W. Linville :
>>> On Fri, Sep 05, 2014 at 04:02:10PM +0400, Sergey Ryazanov wrote:
>>>> 2014-09-05 15:33 GMT+04:00 Paul Bolle :
>>>
2014-09-09 22:27 GMT+04:00, John W. Linville :
> On Fri, Sep 05, 2014 at 04:02:10PM +0400, Sergey Ryazanov wrote:
>> 2014-09-05 15:33 GMT+04:00 Paul Bolle :
>> > Hi Sergey,
>> >
>> > On Fri, 2014-09-05 at 15:12 +0400, Sergey Ryazanov wrote:
>> >> 201
2014-09-05 15:33 GMT+04:00 Paul Bolle :
> Hi Sergey,
>
> On Fri, 2014-09-05 at 15:12 +0400, Sergey Ryazanov wrote:
>> 2014-09-05 14:10 GMT+04:00, Paul Bolle :
>> > On Wed, 2014-06-18 at 13:46 +0200, Paul Bolle wrote:
>> >> Having this conversation every rc
Hello Paul,
2014-09-05 14:10 GMT+04:00, Paul Bolle :
> Jiri, Nick, Luis, John,
>
> On Wed, 2014-06-18 at 13:46 +0200, Paul Bolle wrote:
>> Having this conversation every rc1 is getting a bit silly. Could Jiri
>> e.a. perhaps set some specific deadline for ATHEROS_AR231X to be
>> submitted?
>
> I w
Several architectures (e.g. x86, MIPS, Blackfin) have asm/reboot.h and
asm/time.h header files, which are not included in linux/reboot.h and
linux/time.h headers. This lead to generation of false positive errors.
Signed-off-by: Sergey Ryazanov
---
scripts/checkpatch.pl | 4 +++-
1 file changed
Hi Paul,
2014-06-18 14:25 GMT+04:00 Paul Bolle :
> Jiri, Nick, Luis, John,
>
> On Wed, 2014-04-16 at 13:20 +0400, Sergey Ryazanov wrote:
>> 2014-04-15 21:08 GMT+04:00 Paul Bolle :
>> > On Thu, 2014-02-13 at 15:14 -0500, John W. Linville wrote:
>> >> On W
2014-04-15 21:08 GMT+04:00 Paul Bolle :
> On Thu, 2014-02-13 at 15:14 -0500, John W. Linville wrote:
>> On Wed, Feb 12, 2014 at 02:50:30PM +0400, Sergey Ryazanov wrote:
>> > John, can you delay the merging of this patch for a few months, I will
>> > try to prepare t
2014-02-11 3:43 GMT+04:00 Sergey Ryazanov :
> 2014-02-11 2:37 GMT+04:00 Florian Fainelli :
>> 2014-02-10 4:38 GMT-08:00 Sergey Ryazanov :
>>> 2014-02-10 16:17 GMT+04:00 Oleksij Rempel :
>>>> Am 10.02.2014 13:05, schrieb Sergey Ryazanov:
>>>>>
2014-02-11 2:37 GMT+04:00 Florian Fainelli :
> 2014-02-10 4:38 GMT-08:00 Sergey Ryazanov :
>> 2014-02-10 16:17 GMT+04:00 Oleksij Rempel :
>>> Am 10.02.2014 13:05, schrieb Sergey Ryazanov:
>>>> 2014-02-10 0:03 GMT+04:00 Richard Weinberger :
>>>>>
2014-02-10 16:17 GMT+04:00 Oleksij Rempel :
> Am 10.02.2014 13:05, schrieb Sergey Ryazanov:
>> 2014-02-10 0:03 GMT+04:00 Richard Weinberger :
>>> Am 09.02.2014 20:18, schrieb Hauke Mehrtens:
>>>> On 02/09/2014 07:47 PM, Richard Weinberger wrote:
>>>&g
2014-02-10 0:03 GMT+04:00 Richard Weinberger :
> Am 09.02.2014 20:18, schrieb Hauke Mehrtens:
>> On 02/09/2014 07:47 PM, Richard Weinberger wrote:
>>> The symbol is an orphan, get rid of it.
>>>
>>> Signed-off-by: Richard Weinberger
>>> ---
>>> drivers/net/wireless/ath/ath5k/Kconfig | 10 +---
58 matches
Mail list logo
