On Wed, 11 Sep 2019, Cornelia Huck wrote:
> The common I/O layer is maintaining an "intparm" inspired by
> the hardware intparm for driver usage. This "intparm" is not
> only applicaple for ssch, but also for hsch/csch. The kerneldoc
> states that it is only updated for hsch/csch if no prior reques
sm/pci_clp.h | 6 +++---
> arch/s390/pci/pci.c | 16
> arch/s390/pci/pci_clp.c | 6 +++---
> 4 files changed, 15 insertions(+), 18 deletions(-)
>
Acked-by: Sebastian Ott
On Tue, 6 Aug 2019, Denis Efremov wrote:
> This patch alters the for loop iteration scheme in zpci_map_resources
> to make it more usual. Thus, the patch generalizes the style for
> PCI_IOV_RESOURCES iteration and improves readability.
>
> Signed-off-by: Denis Efremov
Applied for inclusion via s
r pci).
>
> Note that unlike pci we still require a driver override to
> match the subchannel type; matching more than one subchannel
> type is probably not useful anyway.
>
> Signed-off-by: Cornelia Huck
Reviewed-by: Sebastian Ott
Should I take that via our git tree or do you have other patches depending
on this one?
On Mon, 3 Jun 2019, Suzuki K Poulose wrote:
> The cio driver use driver_find_device() to find all devices
> to release them before the driver is unregistered. Instead,
> it could easily use a lighter driver_for_each_device() helper
> to iterate over all the devices.
>
> Cc: S
Hi,
this warning turned up on s390:
[7.041512] [ cut here ]
[7.041518] DMA-API: nvme :00:00.0: mapping sg segment longer than
device claims to support [len=106496] [max=65536]
[7.041531] WARNING: CPU: 1 PID: 229 at kernel/dma/debug.c:1233
debug_dma_map_sg
On Mon, 8 Apr 2019, Arnd Bergmann wrote:
> clang points out that the declaration of cio_irb does not match the
> definition exactly, it is missing the alignment attribute:
>
> ../drivers/s390/cio/cio.c:50:1: warning: section does not match previous
> declaration [-Wsection]
> DEFINE_PER_CPU_ALIGN
On Mon, 11 Mar 2019, Tony Krowiak wrote:
> On 2/18/19 12:01 PM, Tony Krowiak wrote:
> > The current AP bus implementation periodically polls the AP configuration
> > to detect changes. When the AP configuration is dynamically changed via the
> > SE or an SCLP instruction, the changes will not be re
On Wed, 6 Feb 2019, Tony Krowiak wrote:
> diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
> +void ap_bus_cfg_chg(void)
> +{
> + AP_DBF(DBF_INFO, "%s config change, forcing bus rescan\n", __func__);
> +
> + ap_bus_force_rescan();
> +}
> +EXPORT_SYMBOL(ap_bus_cfg_chg)
On Thu, 31 Jan 2019, Tony Krowiak wrote:
> On 1/30/19 1:32 PM, Sebastian Ott wrote:
> > On Wed, 30 Jan 2019, Tony Krowiak wrote:
> >> +++ b/drivers/s390/cio/chsc.h
> >> @@ -9,6 +9,7 @@
> >> #include
> >> #include
> >> #include
> >
that function
from module code.
As an unrelated question, just to be sure: ap_bus.c is compiled as
built-in even with ZCRYPT=m, right?
Reviewed-by: Sebastian Ott
Regards,
Sebastian
iko Carstens
> Cc: Sebastian Ott
> Cc: Gerald Schaefer
> Cc: linux-s...@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman
Applied for inclusion via s390/linux.git
Thanks!
On Sat, 1 Dec 2018, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li
> ---
> drivers/s390/block/dasd.c | 15 +--
> drivers/s390/cio/qdio_debug.c | 16 ++--
> 2 files changed, 3 insertions(+), 28 deletions(-)
Appl
Fix the following sparse warning:
drivers/s390/cio/vfio_ccw_drv.c:25:19: warning: symbol 'vfio_ccw_io_region'
was not declared. Should it be static?
Signed-off-by: Sebastian Ott
---
drivers/s390/cio/vfio_ccw_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dr
Hello,
On Wed, 30 May 2018, Sebastian Ott wrote:
> On Wed, 30 May 2018, Christoph Hellwig wrote:
> > > - req->completion_data = cqr;
> > > + *((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr;
> > > +
> >
> > Please don't play such tricks.
On Wed, 30 May 2018, Christoph Hellwig wrote:
> > - req->completion_data = cqr;
> > + *((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr;
> > +
>
> Please don't play such tricks. In general your driver structure
> should have struct request embedded. If for some reason
> struct dasd_cc
On Mon, 14 May 2018, Bart Van Assche wrote:
> Recently the blk-mq timeout handling code was reworked. See also Tejun
> Heo, "[PATCHSET v4] blk-mq: reimplement timeout handling", 08 Jan 2018
> (https://www.mail-archive.com/linux-block@vger.kernel.org/msg16985.html).
> This patch reworks the blk-mq t
On Thu, 26 Apr 2018, Sebastian Ott wrote:
> on my s390 test system make TAGS is broken since commit 99443f811c452c6
> ("scripts/tags.sh: change find_other_sources() for include directories")
>
> # make TAGS
> GEN TAGS
> xargs: etags: terminated by signal 11
>
Hi,
on my s390 test system make TAGS is broken since commit 99443f811c452c6
("scripts/tags.sh: change find_other_sources() for include directories")
# make TAGS
GEN TAGS
xargs: etags: terminated by signal 11
This is a rather old etags from fedora 24. On x86 using a more recent
etags (fedor
On Mon, 23 Apr 2018, Sebastian Ott wrote:
> This happend once during boot and I could not reproduce this since, but I
> think the following patch should fix the issue:
I can now recreate the issue reliably. The following patch works for me:
-->8
>From 6bbfab86beae8fe8b6efeffd08c9
On Mon, 23 Apr 2018, Sebastian Ott wrote:
> From 9d29e0c92efaf94277bc178782523283958ae8c8 Mon Sep 17 00:00:00 2001
> From: Sebastian Ott
> Date: Mon, 23 Apr 2018 14:59:20 +0200
> Subject: [PATCH] random: don't sleep during allocations in irq context
>
> Since numa_crng_in
e+0x32/0x50
[<008e659e>] default_idle_call+0x3e/0x68
[<001889aa>] do_idle+0xea/0x1c0
[<00188d26>] cpu_startup_entry+0x3e/0x48
[<0011758e>] smp_start_secondary+0x13e/0x158
[<008e87a2>] restart_int_handler+0x5a/0x70
[&l
On Mon, 9 Apr 2018, Linus Torvalds wrote:
> On Mon, Apr 9, 2018 at 10:03 AM, Linus Torvalds
> wrote:
> >
> > Our old "min()" had the internal variables called "min1" and "min2",
> > which is crazy too.
>
> Actually, no, it used the really cumbersome "__UNIQUE_ID" and then
> passed that odd as the
On Mon, 9 Apr 2018, Linus Torvalds wrote:
> On Mon, Apr 9, 2018 at 9:18 AM, Sebastian Ott wrote:
> >
> > Both of the following return 0 on my machine:
> > + pr_warn("%u\n", min_not_zero(100, 1000));
> > + pr_warn("%u\n", min_not_zero(
On Mon, 9 Apr 2018, Sebastian Ott wrote:
> On Fri, 6 Apr 2018, Kees Cook wrote:
> > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott
> > wrote:
> > > Today's kernel oopsed on s390. Bisect points to:
> > > 3c8ba0d61d04 ("kernel.h: Retain cons
On Fri, 6 Apr 2018, Kees Cook wrote:
> On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott
> wrote:
> > Today's kernel oopsed on s390. Bisect points to:
> > 3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()")
> >
> > [1.898
On Fri, 6 Apr 2018, Kees Cook wrote:
> On Fri, Apr 6, 2018 at 9:47 AM, Kees Cook wrote:
> > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott
> > wrote:
> >> Today's kernel oopsed on s390. Bisect points to:
> >> 3c8ba0d61d04 ("kernel.h: Retain con
Hi,
Today's kernel oopsed on s390. Bisect points to:
3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()")
[1.898277] dasd-eckd 0.0.3304: DASD with 4 KB/block, 21636720 KB total
size, 48 KB/track, compatible disk layout
[1.898308] [ cut here ]--
On Tue, 27 Mar 2018, Christoph Hellwig wrote:
> On Tue, Mar 27, 2018 at 05:24:10PM +0200, Sebastian Ott wrote:
> > What do you mean by current implementations? Arch specific code? At least
> > on s390 we don't do that. dma-mapping.h doesn't do it either.
>
> The ar
On Tue, 27 Mar 2018, Christoph Hellwig wrote:
> On Tue, Mar 27, 2018 at 10:12:54AM +0200, Sebastian Ott wrote:
> > Hi,
> >
> > commit 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 broke usage of dma
> > allocations specifying __GFP_ZERO by silently removing that flag.
>
Hello Geert,
On Tue, 27 Mar 2018, Geert Uytterhoeven wrote:
> On Tue, Mar 27, 2018 at 10:12 AM, Sebastian Ott
> wrote:
> > commit 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 broke usage of dma
> > allocations specifying __GFP_ZERO by silently removing that flag.
>
> How d
Hi,
commit 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 broke usage of dma
allocations specifying __GFP_ZERO by silently removing that flag.
Why should "the memory returned [] always be zeroed."?
Regards,
Sebastian
Move the kvm_arch_irq_routing_update() prototype outside of
ifdef CONFIG_HAVE_KVM_EVENTFD guards to fix the following sparse warning:
arch/s390/kvm/../../../virt/kvm/irqchip.c:171:28: warning: symbol
'kvm_arch_irq_routing_update' was not declared. Should it be static?
Signed-off-by:
7; was not declared. Should it be static?
Signed-off-by: Sebastian Ott
---
arch/x86/include/asm/kvm_host.h | 3 ---
include/linux/kvm_host.h| 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index dd
subsequently replaced the MODULE_LICENSE() with a "License: GPL" comment.
>
> Add SPDX GPL-2.0+ and remove the "License: GPL" comment, relying on the
> assertion in b24413180f56 ("License cleanup: add SPDX GPL-2.0 license
> identifier to files with no license") that the SPDX identifier may be used
> instead of the full boilerplate text.
>
> Signed-off-by: Bjorn Helgaas
Acked-by: Sebastian Ott
On Tue, 23 Jan 2018, Cornelia Huck wrote:
> Cornelia Huck (3):
> s390/docs: mention subchannel types
> s390/docs: reword airq section
> s390/cmf: fix kerneldoc
All applied. Thanks!
On Tue, 23 Jan 2018, Cornelia Huck wrote:
> Make sure we use proper Return sections, and make the output
> for cmf_enable() less odd.
>
> Signed-off-by: Cornelia Huck
> ---
> +++ b/drivers/s390/cio/cmf.c
> @@ -1118,9 +1118,10 @@ int ccw_set_cmf(struct ccw_device *cdev, int enable)
> * enable_cm
On Mon, 27 Nov 2017, Will Deacon wrote:
> Sebastian: could you try the diff below, please? If that fixes s390, then
> we can debate the merits of GENERIC_LOCKBREAK independently of fixing this
> issue.
>
> Thanks,
>
> Will
>
> --->8
>
> diff --git a/kernel/locking/spinlock.c b/kernel/locking/sp
Hello Will,
On Wed, 22 Nov 2017, Will Deacon wrote:
> Now, I can't see what the break_lock is doing here other than causing
> problems. Is there a good reason for it, or can you just try removing it
> altogether? Patch below.
With your patch applied the system is able to boot again.
I did some qu
Hi,
One of my test systems (s390) hangs after boot. One of the cpus is idle
the other is in arch_spin_relax. Bisect pointed to this one:
a8a217c22116eff6c120d753c9934089fb229af0 is the first bad commit
commit a8a217c22116eff6c120d753c9934089fb229af0
Author: Will Deacon
Date: Tue Oct 3 19:25:27
On Thu, 5 Oct 2017, Kees Cook wrote:
> On Thu, Oct 5, 2017 at 2:13 AM, Sebastian Ott
> wrote:
> > On Wed, 4 Oct 2017, Kees Cook wrote:
> >> In preparation for unconditionally passing the struct timer_list pointer to
> >> all timer callbacks, switch to using the ne
On Wed, 4 Oct 2017, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
> -void qdio_outbound_timer(unsigned long data)
> +void qdio_outb
On Tue, 15 Aug 2017, Joerg Roedel wrote:
> On Tue, Aug 15, 2017 at 06:02:20PM +0200, Sebastian Ott wrote:
> > On Mon, 14 Aug 2017, Joerg Roedel wrote:
> > > I attach the patch I wrote to fix this, can you please test it together
> > > with the initial patch in this thr
On Mon, 14 Aug 2017, Joerg Roedel wrote:
> I attach the patch I wrote to fix this, can you please test it together
> with the initial patch in this thread?
I did and can confirm that everything worked as expected!
Thanks,
Sebastian
On Fri, 11 Aug 2017, Sebastian Ott wrote:
> * That patch embedded a struct iommu_device within struct zpci_dev but
> the iommu_device has a release function (via its class) - so when
> the release function gets called it frees memory that was never allocated.
> The fix is to not e
On Fri, 11 Aug 2017, Sebastian Ott wrote:
> * iommu_release_device must not release the struct device but the
> structure it is embedded in: struct iommu_device (I'll send a patch
> for that)
--->8
>From 2839c92e038af47b8cb569f84d571878c54d1815 Mon Sep 17 00:00:00 2001
From:
Hello Joerg,
On Fri, 11 Aug 2017, Joerg Roedel wrote:
> Hey Sebastian,
>
> On Thu, Aug 10, 2017 at 09:07:06PM +0200, Sebastian Ott wrote:
> > With this patch pci hot-unplug fails with a use after free or refcounting
> > issue - I'm currently trying to understand what
On Wed, 9 Aug 2017, Joerg Roedel wrote:
> From: Joerg Roedel
>
> Add support for the iommu_device_register interface to make
> the s390 hardware iommus visible to the iommu core and in
> sysfs.
>
With this patch pci hot-unplug fails with a use after free or refcounting
issue - I'm currently try
Hello Sergey,
On Tue, 21 Mar 2017, Sergey Senozhatsky wrote:
> // I kept only lockdep splats from the original report and cut off .configs
> // full version:
> // lkml.kernel.org/r/alpine.LFD.2.20.1703201736070.1753@schleppi
>
> On (03/20/17 17:43), Sebastian Ott wrote:
&
Commit-ID: e5682b4eecb2b73282853d0ef314d3164b986997
Gitweb: http://git.kernel.org/tip/e5682b4eecb2b73282853d0ef314d3164b986997
Author: Sebastian Ott
AuthorDate: Tue, 4 Jul 2017 11:25:15 +0200
Committer: Thomas Gleixner
CommitDate: Tue, 4 Jul 2017 12:36:43 +0200
genirq/debugfs: Fix
ned-off-by: Sebastian Ott
---
kernel/irq/internals.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h
index 9da14d1..dbfba99 100644
--- a/kernel/irq/internals.h
+++ b/kernel/irq/internals.h
@@ -437,7 +437,9 @@ static i
On Thu, 15 Jun 2017, Sebastian Ott wrote:
> On Tue, 13 Jun 2017, Stephen Rothwell wrote:
> > After merging the block tree, today's linux-next build (s390x
> > s390-defconfig) failed like this:
> >
> > drivers/s390/block/scm_blk.c:293:10: error: 'BLK_MQ_RQ_QUEU
On Tue, 13 Jun 2017, Stephen Rothwell wrote:
> After merging the block tree, today's linux-next build (s390x
> s390-defconfig) failed like this:
>
> drivers/s390/block/scm_blk.c:293:10: error: 'BLK_MQ_RQ_QUEUE_BUSY' undeclared
> (first use in this function)
> drivers/s390/block/scm_blk.c:327:9: e
Hi,
On Tue, 13 Jun 2017, Christoph Hellwig wrote:
> Btw, scm_blk.c blk-mq conversion seems odd if not broken. It should
> always call blk_mq_complete_request from scm_request_finish and
> then pass the error to blk_mq_end_request frin
> there.
OK. I had added that because rq->errors went away. W
On Thu, 1 Jun 2017, Xin Long wrote:
> On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott
> wrote:
> > [...]
> I couldn't see any bridge-related thing here, and it couldn't be reproduced
> with virbr0 (stp=1) on my box (on both s390x and x86_64), I guess there
> i
Hi,
A system running v4.12-rc3-11-gf511c0b on s390 hangs after boot with no
messages on the console. The message buffer obtained via a system dump
looked like this:
[...]
[ 17.870712] virbr0: port 1(virbr0-nic) entered disabled state
[ 19.618523] Unable to handle kernel pointer dereference in
where they'd likely
> never be called without CONFIG_PCI set, but this is needed to compile
> such changes.
>
> Signed-off-by: Logan Gunthorpe
> Cc: Martin Schwidefsky
> Cc: Heiko Carstens
> cc: Sebastian Ott
> Cc: Al Viro
> ---
>
> v2 of this patch is cha
Hi,
On Fri, 26 May 2017, Logan Gunthorpe wrote:
> On 26/05/17 06:38 AM, Heiko Carstens wrote:
> > On Thu, May 25, 2017 at 09:43:48AM -0600, Logan Gunthorpe wrote:
> > I'd rather move the #ifdef CONFIG_PCI than implementing this yet another
> > time (see patch below). But I'll leave that up to Seba
On Fri, 28 Apr 2017, Joerg Roedel wrote:
> On Fri, Apr 28, 2017 at 02:46:34PM +0200, Gerald Schaefer wrote:
> > On Thu, 27 Apr 2017 23:03:25 +0200
> > Joerg Roedel wrote:
> >
> > > > Well, there is a separate zpci_dev for each pci_dev on s390,
> > > > and each of those has its own separate dma-ta
On Sat, 25 Mar 2017, Sergey Senozhatsky wrote:
> On (03/21/17 13:44), Sergey Senozhatsky wrote:
> [..]
> > so we probably can
> >
> >
> > 1) move pr_info() out of zone->lock in __offline_isolated_pages().
> >meh...
> >
> >
> > 2) switch to printk_deferred() in __offline_isolated_pages().
>
On Fri, 24 Mar 2017, Steven Rostedt wrote:
> Is there a stack trace of where the lockdep dump happened? That is
> useful too. Otherwise we don't see where the inverse happened.
Sure. Here you go.
[ 132.379220] ==
[ 132.379220] [ INFO: possible
Since commit f975237b7682 ("printk: use printk_safe buffers in printk")
I observe lockdep warnings on s390 when doing memory hotplug:
[ 132.379220] ==
[ 132.379220] [ INFO: possible circular locking dependency detected ]
[ 132.379221] 4.11.0-r
On Tue, 28 Feb 2017, Sebastian Ott wrote:
> On Mon, 27 Feb 2017, Bart Van Assche wrote:
> > On Mon, 2017-02-27 at 21:17 +0100, Sebastian Ott wrote:
> > > commit 99db94940 "IB/core: Remove ib_device.dma_device"
> > > breaks infiniband on s390 (and I thi
On Mon, 27 Feb 2017, Bart Van Assche wrote:
> On Mon, 2017-02-27 at 21:17 +0100, Sebastian Ott wrote:
> > commit 99db94940 "IB/core: Remove ib_device.dma_device"
> > breaks infiniband on s390 (and I think also other archs that do something
> > like to_pci_d
Hi,
commit 99db94940 "IB/core: Remove ib_device.dma_device"
breaks infiniband on s390 (and I think also other archs that do something
like to_pci_dev(dev) in one of their dma_ops callbacks).
With this commit you use the dma_ops of the device that called
ib_register_device but you call e.g. dma_ma
d to a warning
when add_memory() is called. Fix this by acquiring device_hotplug_lock in
add_memory_resource().
Signed-off-by: Sebastian Ott
---
mm/memory_hotplug.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 1d3ed58..c633bbc 10064
_common.isra.15+0x572/0x1010
[mlx4_ib]
[ 20.781949] [<03ff8013929e>] mlx4_ib_create_qp+0x1de/0x438 [mlx4_ib]
[ 20.781953] [<03ff8004f52c>] create_qp.isra.11+0x44c/0x7f0 [ib_uverbs]
The following patch fixes this:
>8
>From ec91646d8c14e2a8dd2b62187084dab32ef8
Hi,
I ran into the following lockdep complaint:
[7.059561] INFO: trying to register non-static key.
[7.059566] the code is fine but needs lockdep annotation.
[7.059570] turning off the locking correctness validator.
[7.059579] CPU: 6 PID: 6 Comm: kworker/u32:0 Not tainted
4.9.0-0
_common.isra.15+0x572/0x1010
[mlx4_ib]
[ 20.781949] [<03ff8013929e>] mlx4_ib_create_qp+0x1de/0x438 [mlx4_ib]
[ 20.781953] [<03ff8004f52c>] create_qp.isra.11+0x44c/0x7f0 [ib_uverbs]
The following patch fixes this:
>8
>From ec91646d8c14e2a8dd2b62187084dab32ef8
Hi,
Ifup on an interface provided by CX4 (MLX5 driver) on s390 fails with:
[ 22.318553] [ cut here ]
[ 22.318564] WARNING: CPU: 1 PID: 399 at mm/page_alloc.c:3421
__alloc_pages_nodemask+0x2ee/0x1298
[ 22.318568] Modules linked in: mlx4_ib ib_core mlx5_core mlx4_en m
Hi,
After a userspace update (fedora 23->24) I reproducibly run into the
following oops during shutdown (on s390):
[ 71.054832] Unable to handle kernel pointer dereference in virtual kernel
address space
[ 71.054835] Failing address: 6b6b6b6b6b6b6000 TEID: 6b6b6b6b6b6b6803
[ 71.054838] Fau
unsigned long pa = 0;
> > int ret;
> >
> > size = PAGE_ALIGN(size);
>
> The compiler is right. pa is set in the for-loop. If "dma_addr <
> dma_addr_base + size"
> is never true and __dma_purge_tlb() returns with an error, pa *is*
> uninitialized.
> The fix seems sensible to me.
Although that could only happen if map_sg is called with zero length sg
list entries I'm in favor getting rid of that warning.
Acked-by: Sebastian Ott
Regards,
Sebastian
On Thu, 22 Sep 2016, Frank Haverkamp wrote:
> > On 12.09.2016, at 20:09, Sebastian Ott wrote:
> > Genwqe uses dma_alloc_coherent and depends on zero initialized memory. On
> > one occasion it ueses an explicit memset on others it uses un-initialized
> > memory.
>
On Wed, 14 Sep 2016, Tariq Toukan wrote:
> On 14/09/2016 4:53 PM, Sebastian Ott wrote:
> > On Wed, 14 Sep 2016, Tariq Toukan wrote:
> > > On 14/09/2016 2:09 PM, Sebastian Ott wrote:
> > > > If an error occurs in mlx4_init_eq_table the index used in the
> > &g
Hello Tariq,
On Wed, 14 Sep 2016, Tariq Toukan wrote:
> On 14/09/2016 2:09 PM, Sebastian Ott wrote:
> > If an error occurs in mlx4_init_eq_table the index used in the
> > err_out_unmap label is one too big which results in a panic in
> > mlx4_free_eq. This patch fixes the in
If an error occurs in mlx4_init_eq_table the index used in the
err_out_unmap label is one too big which results in a panic in
mlx4_free_eq. This patch fixes the index in the error path.
Signed-off-by: Sebastian Ott
---
drivers/net/ethernet/mellanox/mlx4/eq.c | 4 ++--
1 file changed, 2
guaranteed.
Simply switch to dma_zalloc_coherent.
Signed-off-by: Sebastian Ott
---
drivers/misc/genwqe/card_ddcb.c | 2 --
drivers/misc/genwqe/card_utils.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
index
On Fri, 29 Jul 2016, Julia Lawall wrote:
> On Fri, 29 Jul 2016, Sebastian Ott wrote:
> > On Fri, 29 Jul 2016, Amitoj Kaur Chawla wrote:
> > > Remove unnecessary error handling because the only failure value that
> > > can be returned is NULL and so the test can nev
On Fri, 29 Jul 2016, Amitoj Kaur Chawla wrote:
> Remove unnecessary error handling because the only failure value that
> can be returned is NULL and so the test can never be true.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression e;
> @@
>
> e = debugfs
On Sat, 16 Jul 2016, Bhaktipriya Shridhar wrote:
> The workqueue "chp_wq" is involved in performing pending
> configure tasks for channel paths.
>
> It has a single work item(&cfg_work) and hence doesn't require
> ordering. Also, it is not being used on a memory reclaim path.
> Hence, the singleth
start of the next segment (which is
the next bit position such that we'll not cross the same segment
boundary again).
Signed-off-by: Sebastian Ott
Reviewed-by: Gerald Schaefer
---
lib/iommu-helper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/iommu-helper.c
On Wed, 27 Apr 2016, Ben Hutchings wrote:
> 3.16.35-rc1 review patch. If anyone has any objections, please let me know.
>
> --
>
> From: Sebastian Ott
>
> commit 80c544ded25ac14d7cc3e555abb8ed2c2da99b84 upstream.
>
> The function measurement
On Wed, 24 Feb 2016, Martin Schwidefsky wrote:
> On Tue, 23 Feb 2016 22:33:45 +0300
> "Kirill A. Shutemov" wrote:
>
> > On Tue, Feb 23, 2016 at 07:19:07PM +0100, Gerald Schaefer wrote:
> > > I'll check with Martin, maybe it is actually trivial, then we can
> > > do a quick test it to rule that on
On Thu, 18 Feb 2016, Kirill A. Shutemov wrote:
> I worth minimizing kernel config on which you can see the bug. Things like
> CONFIG_DEBUG_PAGEALLOC used to interfere with THP before.
I disabled all debugging options (using
arch/s390/configs/performance_defconfig) - we still chrashed.
Sebastian
Hi,
On Wed, 17 Feb 2016, Kirill A. Shutemov wrote:
> On Tue, Feb 16, 2016 at 05:24:44PM +0100, Gerald Schaefer wrote:
> > On Mon, 15 Feb 2016 23:35:26 +0200
> > "Kirill A. Shutemov" wrote:
> >
> > > Is there any chance that I'll be able to trigger the bug using QEMU?
> > > Does anybody have an Q
On Mon, 15 Feb 2016, Kirill A. Shutemov wrote:
> Just to make sure: commit 122afea9626a is fine, commit 61f5d698cc97
> crashes. Correct?
Correct.
On Mon, 15 Feb 2016, Kirill A. Shutemov wrote:
> > [ 59.851421] list_del corruption. next->prev should be 6e1eb000,
> > but was 0400
>
> This kinda interesting: 0x400 is TAIL_MAPPING.. Hm..
>
> Could you check if you see the problem on commit 1c290f642101 and its
> immediat
On Sat, 13 Feb 2016, Kirill A. Shutemov wrote:
> Could you check if revert of fecffad25458 helps?
I reverted fecffad25458 on top of 721675fcf277cf - it oopsed with:
¢ 1851.721062! Unable to handle kernel pointer dereference in virtual kernel
address space
¢ 1851.721075! failing address: 000
On Thu, 11 Feb 2016, Kirill A. Shutemov wrote:
> On Thu, Feb 11, 2016 at 09:09:42PM +0200, Kirill A. Shutemov wrote:
> > On Thu, Feb 11, 2016 at 07:22:23PM +0100, Gerald Schaefer wrote:
> > > Hi,
> > >
> > > Sebastian Ott reported random kernel crashes begin
On Fri, 12 Feb 2016, Will Deacon wrote:
> On Thu, Feb 11, 2016 at 08:57:02PM +0100, Gerald Schaefer wrote:
> > On Thu, 11 Feb 2016 21:09:42 +0200
> > "Kirill A. Shutemov" wrote:
> > > On Thu, Feb 11, 2016 at 07:22:23PM +0100, Gerald Schaefer wrote:
> >
atic?
Signed-off-by: Sebastian Ott
---
drivers/iommu/s390-iommu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c
index cbe198c..030e94c 100644
--- a/drivers/iommu/s390-iommu.c
+++ b/drivers/iommu/s390-iommu.c
@@ -49,7
tomic.
Regards,
Sebastian
>8
misc/genwqe: get rid of atomic allocations
All of genwqe's atomic allocations happen in a context where it's allowed
to sleep. Change these to use GFP_KERNEL.
Signed-off-by: Sebastian Ott
---
drivers/misc/genwqe/card_ddcb.c |2 +-
drivers/misc/g
On Mon, 31 Aug 2015, Felipe Balbi wrote:
> while booting AM437x device, the following splat
> triggered:
>
> [ 12.005238] ===
> [ 12.009749] [ INFO: suspicious RCU usage. ]
> [ 12.014116] 4.2.0-next-20150831 #1154 Not tainted
> [ 12.019050] -
On Wed, 12 Aug 2015, Christoph Hellwig wrote:
> Use sg_phys() instead of page_to_phys(sg_page(sg)) so that we don't
> require a page structure for all DMA memory.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Sebastian Ott
> ---
> arch/s390/pci/pci_dma.c | 20 ++
On Thu, 9 Jul 2015, Jiang Liu wrote:
> Use accessor for_pci_msi_entry() to access MSI device list, so we could
> easily move msi_list from struct pci_dev into struct device later.
>
> Signed-off-by: Jiang Liu
Acked-by: Sebastian Ott
Regards,
Sebastian
> ---
> arch/s39
On Tue, 30 Jun 2015, Or Gerlitz wrote:
> On Tue, Jun 30, 2015 at 1:45 PM, Sebastian Ott
> wrote:
> > after the latest mellanox update the mlx4 driver fails to probe a VF:
> > [ 88.909562] mlx4_core :00:00.0: mlx4_allocate_default_counters:
> > failed to allocate de
Hello,
after the latest mellanox update the mlx4 driver fails to probe a VF:
[ 88.909562] mlx4_core :00:00.0: mlx4_allocate_default_counters: failed
to allocate default counter port 1 err -22
[ 88.909564] mlx4_core :00:00.0: Failed to allocate default counters,
aborting
[ 88.961735
nce to
'devm_ioremap_resource'
Signed-off-by: Sebastian Ott
---
drivers/phy/Kconfig |2 ++
1 file changed, 2 insertions(+)
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -56,6 +56,7 @@ config PHY_EXYNOS_MIPI_VIDEO
config PHY_PXA_28NM_HSIC
tristate "Marvell
Fix this compile error:
drivers/built-in.o: In function `arc_ps2_probe':
/mnt/linux/drivers/input/serio/arc_ps2.c:206: undefined reference to
`devm_ioremap_resource'
Signed-off-by: Sebastian Ott
---
drivers/input/serio/Kconfig |1 +
1 file changed, 1 insertion(+)
--- a/dri
nder Viro
> CC: Markus Pargmann
> CC: Stefan Weinhuber
> CC: Stefan Haberland
> CC: Sebastian Ott
> CC: Fabian Frederick
> CC: Ming Lei
> CC: David Herrmann
> CC: Andrew Morton
> CC: Peter Zijlstra
> CC: nbd-gene...@lists.sourceforge.net
> CC: linux-s...@vge
1 - 100 of 139 matches
Mail list logo
