Want to log my new email with this thread in case any questions arise
later and people have trouble finding me.
sebc...@gmail.com
Thanks!
Sebastian Capella
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kerne
Thanks Pavel!
I believe it's missed 3.15, so will need to verify again for 3.16.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please rea
Hi Stephen, Russell,
Verified, thanks! Please let me know if anything is needed from me for this.
Thanks!
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/maj
Hi Russell,
Ran this overnight and no failures on >1000 hibernations.
Looks good.
Thanks!
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Russell,
Sorry for the delay.
I've merged the omap changes onto 3.15-rc2 and tested and it looks
like everything is working (so far 50 loops into/out of hibernation).
Thanks!
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo
Hi Stephen,
I'm not sure if this is helpful, but the virt_to_pfn macro added in
arch/arm/include/asm/memory.h:300 (I assume the 297 warning in yours),
in the hibernation patch:
#define virt_to_pfn(kaddr) (__pa(kaddr) >> PAGE_SHIFT)
Should be removed as there is an improved version of virt_t
uring hibernation on Kirkwood
Openblocks A6 board.
Signed-off-by: Sebastian Capella
Reported-by: Ezequiel Garcia
Cc: Len Brown
Cc: Pavel Machek
Cc: "Rafael J. Wysocki"
Cc: Russell King
Cc: One Thousand Gnomes
---
kernel/power/hibernate.c |6 --
1 file changed, 4 insertions(
Thanks Russell, Alan!
So we're OK with the current patch + replacing while(1) after
kernel_halt at the end of power_down in hibernate.c with a while (1)
cpu_relax()?
Any other changes needed?
If not, I'll send a follow up patch with just these.
Thanks!
Sebastian
--
To unsubscribe from this lis
Hi Russell,
It seems to work fine with your virt_to_phys on the 3.13 + OMAP
patches kernel, and I checked on the 3.15-rc1 kernel + hibernation and
it compiled and ran fine. I tried a couple of hibernations on this
version as well and they worked (aside from the crash in kernel_halt
we're discussi
On 16 April 2014 03:12, Russell King - ARM Linux wrote:
> On Wed, Mar 05, 2014 at 02:50:05AM -0800, Sebastian Capella wrote:
>> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
>> index 8756e4b..d32adbb 100644
>> --- a/arch/arm/include/asm/memor
On 15 April 2014 14:18, Pavel Machek wrote:
> On Tue 2014-04-15 21:54:53, Russell King - ARM Linux wrote:
>> What I'm basically saying is that I see no reason for ARM to do something
>> different to what x86 does.
>>
>> What is pretty clear to me is that ARM is compatible with x86, which is
>> com
Ping..
There appears to be disagreement on the correct path to take on this.
Pavel and Alan recommend that arm's machine_power_off shall never return
Russell suggests hibernation be modified to handle machine_power_off
returning; that x86 architecture (and others as well) can have
machine_power_
Hi Will,
On 14 April 2014 03:53, Will Deacon wrote:
> On Tue, Mar 18, 2014 at 09:40:57PM +0000, Sebastian Capella wrote:
>> Use of tracers in local_irq_disable is causes abort loops when called
>> with irqs disabled using a temporary stack. Replace local_irq_
> On 20 March 2014 14:35, One Thousand Gnomes
> wrote:
>>> if (pm_power_off)
>>> pm_power_off();
>>> ## It really should do while (1) here.
>> while(1)
>> cpu_relax();
>> or similar at minimum.
Hi Alan, Pavel,
I prepared the changes suggested for AR
Hi Alexander,
Thanks for your comments.
I've posted a different solution for arm only here, that just causes a
while loop in machine_power_off in the event it's called but does not
halt.
https://lkml.org/lkml/2014/3/24/299
On 25 March 2014 11:38, Alexander Holler wrote:
> Both states, power of
Add loop to prevent return from machine_power_off if
pm_power_off is null or does not halt the system.
This caused a panic during hibernation testing on Kirkwood
Openblocks A6 board.
Signed-off-by: Sebastian Capella
Reported-by: Ezequiel Garcia
Cc: Len Brown
Cc: Pavel Machek
Cc: "Raf
Hi,
I have no further changes here.. I will submit a separate patch to
cover Ezequiel's concern. Any final comments? Otherwise, I'll submit
to Russell's system.
Thanks for the review!
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
Thanks Pavel and Alan for your comments!
I'll rework and try again.
Sebastian
On 20 March 2014 14:35, One Thousand Gnomes wrote:
>> if (pm_power_off)
>> pm_power_off();
>> }
>>
>> ## It really should do while (1) here.
>
> while(1)
> cpu_relax();
>
uring hibernation on Kirkwood
Openblocks A6 board.
Signed-off-by: Sebastian Capella
Reported-by: Ezequiel Garcia
Cc: Len Brown
Cc: Pavel Machek
Cc: "Rafael J. Wysocki"
---
kernel/power/hibernate.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/powe
Patch to avoid calling kernel_power_off when pm_power_off is null.
When pm_power_off is null, the platform will not power off in
kernel_power_off. Currently, hibernate will call kernel_power_off and
then move on to kernel_halt. However, this calls the notifier chain
twice with a different paramet
Hi Tony,
I have not used the tux-on-ice solution. The patchset I've sent is to
add initial support for swsusp based hibernation for ARM.
Can you please begin a new, separate thread for this? Ie. separate
from the review for the swsusp hibernation patches I've submitted?
I'm not sure where the r
On 6 March 2014 15:45, Sebastian Capella wrote:
> Quoting Sebastian Capella (2014-03-05 02:50:04)
>> Use of tracers in local_irq_disable is causes recursive aborts when
>> called with irqs disabled and using a temporary stack (hibernation).
>> Replace local_irq_disable with
On 19 March 2014 13:47, Sebastian Capella wrote:
> diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
> index a5f702a..d96b910 100644
> --- a/kernel/power/hibernate.c
> +++ b/kernel/power/hibernate.c
> @@ -594,7 +594,8 @@ static void power_down(void)
On 19 March 2014 08:44, Ezequiel Garcia
wrote:
> Tested-by: Ezequiel Garcia
Thanks!
> On the other side, this board has no pm_power_off() support, which means
> kernel_halt() is called after kernel_power_off().
>
> I'm not sure if a NULL pm_power_off() is supported, but this makes my kernel
> cra
l
Cc: "Rafael J. Wysocki"
Signed-off-by: Sebastian Capella
Acked-by: Pavel Machek
Reviewed-by: Lorenzo Pieralisi
Cc: Russell King
Cc: Len Brown
Cc: Nicolas Pitre
Cc: Santosh Shilimkar
Cc: Will Deacon
Cc: Jonathan Austin
Cc: Catalin Marinas
Cc: "Uwe Kleine-König"
Cc: Stephe
Use of tracers in local_irq_disable is causes abort loops when called
with irqs disabled using a temporary stack. Replace local_irq_disable
with raw_local_irq_disable instead to avoid tracers.
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Andrew Morton
Cc: Will Deacon
Cc: Robin Holt
On 17 March 2014 13:44, Ezequiel Garcia
wrote:
> On Mar 17, Sebastian Capella wrote:
>> On 16 March 2014 00:09, Ezequiel Garcia
>> wrote:
>> > On Mar 05, Sebastian Capella wrote:
>> > [..]
>> >> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm
Thanks Russell!
On 16 March 2014 02:46, Russell King - ARM Linux wrote:
> On Mon, Mar 10, 2014 at 11:32:17AM -0700, Sebastian Capella wrote:
...
> Let's look at the implementations...
>
> #define __pa(x) __virt_to_phys((unsigned long)(x))
> stati
On 16 March 2014 00:09, Ezequiel Garcia
wrote:
> On Mar 05, Sebastian Capella wrote:
> [..]
>> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
>> index 1f8fed9..83707702 100644
>> --- a/arch/arm/mm/Kconfig
>> +++ b/arch/arm/mm/Kconfig
>> @@ -611
Use of tracers in local_irq_disable is causes recursive aborts when
called with irqs disabled and using a temporary stack (hibernation).
Replace local_irq_disable with raw_local_irq_disable instead to
avoid tracers.
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Andrew Morton
Cc: Thomas
yril Chemparathy from Cc: list as
emails are bouncing.
Thanks,
Sebastian Capella
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read th
l
Cc: "Rafael J. Wysocki"
Signed-off-by: Sebastian Capella
Acked-by: Pavel Machek
Reviewed-by: Lorenzo Pieralisi
Cc: Russell King
Cc: Len Brown
Cc: Nicolas Pitre
Cc: Santosh Shilimkar
Cc: Will Deacon
Cc: Jonathan Austin
Cc: Catalin Marinas
Cc: "Uwe Kleine-König"
Cc: Step
On 6 March 2014 20:42, Stephen Boyd wrote:
> On 03/05, Sebastian Capella wrote:
>> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
>> index 8756e4b..d32adbb 100644
>> --- a/arch/arm/include/asm/memory.h
>> +++ b/arch/arm/include/asm/m
Sorry to those receiving repeated emails, I'm having an issue with some
of the special characters names.
Quoting Sebastian Capella (2014-03-05 02:50:05)
> From: Russ Dill
> Enable hibernation for ARM architectures and provide ARM
> architecture specific calls used during hibernatio
Quoting Sebastian Capella (2014-03-05 02:50:04)
> Use of tracers in local_irq_disable is causes recursive aborts when
> called with irqs disabled and using a temporary stack (hibernation).
> Replace local_irq_disable with raw_local_irq_disable instead to
> avoid tracers.
>
l
Cc: "Rafael J. Wysocki"
Signed-off-by: Sebastian Capella
Acked-by: Pavel Machek
Reviewed-by: Lorenzo Pieralisi
Cc: Russell King
Cc: Len Brown
Cc: Nicolas Pitre
Cc: Santosh Shilimkar
Cc: Will Deacon
Cc: Jonathan Austin
Cc: Catalin Marinas
Cc: "Uwe Kleine-König"
Cc: Step
Use of tracers in local_irq_disable is causes recursive aborts when
called with irqs disabled and using a temporary stack (hibernation).
Replace local_irq_disable with raw_local_irq_disable instead to
avoid tracers.
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Andrew Morton
Cc: Thomas
t as
emails are bouncing.
Thanks,
Sebastian Capella
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoting Sebastian Capella (2014-02-28 10:17:31)
> Quoting Russell King - ARM Linux (2014-02-28 02:20:18)
> > On Thu, Feb 27, 2014 at 06:19:49PM -0800, Stephen Boyd wrote:
> > > On 02/27/14 17:47, Russ Dill wrote:
> > > > On 02/27/2014 04:09 PM, Stephen Boyd wro
Quoting Sebastian Capella (2014-02-28 15:38:54)
> Quoting Lorenzo Pieralisi (2014-02-28 14:49:33)
> > On Fri, Feb 28, 2014 at 08:15:57PM +, Sebastian Capella wrote:
> > > >
> > > > This does not guarantee your stack is 8-byte aligned, that's not AAP
n v2:
--
* Removed unneeded flush_thread, use of __naked and cpu_init.
* dropped Cyril Chemparathy from Cc: list as
emails are bouncing.
Thanks,
Sebastian Capella
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
l
Cc: "Rafael J. Wysocki"
Signed-off-by: Sebastian Capella
Acked-by: Pavel Machek
Cc: Russell King
Cc: Len Brown
Cc: Nicolas Pitre
Cc: Santosh Shilimkar
Cc: Will Deacon
Cc: Jonathan Austin
Cc: Catalin Marinas
Cc: "Uwe Kleine-König"
Cc: Stephen Boyd
Cc: Lorenzo Pierali
Use of tracers in local_irq_disable is causes recursive aborts when
called with irqs disabled and using a temporary stack (hibernation).
Replace local_irq_disable with raw_local_irq_disable instead to
avoid tracers.
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Andrew Morton
Cc: Thomas
l
Cc: "Rafael J. Wysocki"
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Len Brown
Cc: Pavel Machek
Cc: Nicolas Pitre
Cc: Santosh Shilimkar
Cc: Will Deacon
Cc: Jonathan Austin
Cc: Catalin Marinas
Cc: "Uwe Kleine-König"
Cc: Stephen Boyd
Cc: Lorenzo Pieralisi
---
pped Cyril Chemparathy from Cc: list as
emails are bouncing.
Thanks,
Sebastian Capella
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Pleas
Use of tracers in local_irq_disable is causes recursive aborts when
called with irqs disabled and using a temporary stack (hibernation).
Replace local_irq_disable with raw_local_irq_disable instead to
avoid tracers.
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Andrew Morton
Cc: Thomas
Use of tracers in local_irq_disable is causes recursive aborts when
called with irqs disabled and using a temporary stack (hibernation).
Replace local_irq_disable with raw_local_irq_disable instead to
avoid tracers.
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Andrew Morton
Cc: Thomas
uot;Rafael J. Wysocki"
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Len Brown
Cc: Pavel Machek
Cc: Nicolas Pitre
Cc: Santosh Shilimkar
Cc: Will Deacon
Cc: Jonathan Austin
Cc: Catalin Marinas
Cc: "Uwe Kleine-König"
Cc: Stephen Boyd
Cc: Lorenzo Pieralisi
---
arc
e of soft_restart
* drop irq disable soft_restart patch
* add patch to avoid tracers in soft_restart by using raw_local_irq_*
Changes in v2:
--
* Removed unneeded flush_thread, use of __naked and cpu_init.
* dropped Cyril Chemparathy from Cc: list as
emails are bouncing.
Thanks,
Sebas
e of soft_restart
* drop irq disable soft_restart patch
* add patch to avoid tracers in soft_restart by using raw_local_irq_*
Changes in v2:
--
* Removed unneeded flush_thread, use of __naked and cpu_init.
* dropped Cyril Chemparathy from Cc: list as
emails are bouncing.
Thanks,
Sebas
lock on this semaphore and hangs waiting.
Signed-off-by: Sebastian Capella
Acked-by: Ming Lei
Cc: Russ Dill
Cc: Greg Kroah-Hartman
---
drivers/base/firmware_class.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index eb8fb94
cing.
Thanks,
Sebastian Capella
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Use of tracers in local_irq_disable is causes abort loops when called
with irqs disabled using a temporary stack. Replace local_irq_disable
with raw_local_irq_disable instead to avoid tracers.
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Andrew Morton
Cc: Thomas Gleixner
Cc: Will
uot;Rafael J. Wysocki"
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Len Brown
Cc: Pavel Machek
Cc: Nicolas Pitre
Cc: Santosh Shilimkar
Cc: Will Deacon
Cc: Jonathan Austin
Cc: Catalin Marinas
Cc: "Uwe Kleine-König"
Cc: Stephen Boyd
---
arch/arm/include/asm/memory.h |
Quoting Russ Dill (2014-02-25 09:15:33)
> On 02/25/2014 02:27 AM, Thomas Gleixner wrote:
> > If you want escape the tracer and in that case you really want it
> > being on a different stack, use raw_local_irq_* which are not
> > traced.
>
> So it might make sense to change soft_restart to use the
From: Russ Dill
This adds the ability to run soft_restart with local_irq/fiq_disable
already called. This is helpful for the hibernation code paths.
Signed-off-by: Russ Dill
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Andrew Morton
Cc: Thomas Gleixner
Cc: Will Deacon
Cc: Robin
lock on this semaphore and hangs waiting.
Signed-off-by: Sebastian Capella
Acked-by: Ming Lei
Cc: Russ Dill
Cc: Greg Kroah-Hartman
---
drivers/base/firmware_class.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index eb8fb94
Patches adding support for hibernation on ARM
- ARM hibernation / suspend-to-disk
- Fix hang in freeze_processes during hibernation
- add an irq disabled version of soft_restart
Patches based on v3.13 tag, verified hibernation on beaglebone black on a branch
based on 3.13 merged with initial
uot;Rafael J. Wysocki"
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Len Brown
Cc: Pavel Machek
Cc: Nicolas Pitre
Cc: Santosh Shilimkar
Cc: Will Deacon
Cc: Jonathan Austin
Cc: Catalin Marinas
Cc: "Uwe Kleine-König"
Cc: Stephen Boyd
---
arch/arm/include/asm/memory.h |
Quoting Lorenzo Pieralisi (2014-02-22 04:09:10)
> On Sat, Feb 22, 2014 at 10:38:40AM +, Russell King - ARM Linux wrote:
> > On Wed, Feb 19, 2014 at 04:12:54PM +, Lorenzo Pieralisi wrote:
> > > On Wed, Feb 19, 2014 at 01:52:09AM +, Sebas
Quoting Lorenzo Pieralisi (2014-02-22 04:09:10)
> On Sat, Feb 22, 2014 at 10:38:40AM +, Russell King - ARM Linux wrote:
> > On Wed, Feb 19, 2014 at 04:12:54PM +, Lorenzo Pieralisi wrote:
> > > > + cpu_switch_mm(idmap_pgd, &init_mm);
> >
> > You need the idmap_pgd in place to call cpu_resume
lock on this semaphore and hangs waiting.
Signed-off-by: Sebastian Capella
Cc: Russ Dill
Cc: Ming Lei
Cc: Greg Kroah-Hartman
---
drivers/base/firmware_class.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index eb8fb94
uot;Rafael J. Wysocki"
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Len Brown
Cc: Pavel Machek
Cc: Nicolas Pitre
Cc: Santosh Shilimkar
Cc: Will Deacon
Cc: Cyril Chemparathy
Cc: Jonathan Austin
Cc: Catalin Marinas
Cc: "Uwe Kleine-König"
Cc: Stephen Boyd
---
arc
From: Russ Dill
This adds the ability to run soft_restart with local_irq/fiq_disable
already called. This is helpful for the hibernation code paths.
Signed-off-by: Russ Dill
Signed-off-by: Sebastian Capella
Cc: Russell King
Cc: Andrew Morton
Cc: Thomas Gleixner
Cc: Will Deacon
Cc: Robin
Patches adding support for hibernation on ARM
- ARM hibernation / suspend-to-disk
- Fix hang in freeze_processes during hibernation
- add an irq disabled version of soft_restart
Patches based on v3.13 tag, verified hibernation on beaglebone black on a branch
based on 3.13 merged with initial
Shuah Khan wrote:
> Convert drivers/video/backlight/class to use dev_pm_ops for power
> management and remove Legacy PM ops hooks. With this change, rtc class
> registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of
> Legacy class->suspend/resume. When __device_suspend() runs ca
same syntax as the resume=device
parameter, we can parse the resume=device in the init script and
use the resume device directly from the kernel command line.
Signed-off-by: Sebastian Capella
Cc: Len Brown
Cc: Pavel Machek
Cc: "Rafael J. Wysocki"
---
kernel/power/hib
Patchset related to hibernation resume:
- enhancement to make the use of an existing resume file more general
Patch is based on the 3.13 tag. This was tested on a Beaglebone black
with partial hibernation support, also compiled for x86_64.
[PATCH v9 1/1] PM / Hibernate: use name_to_dev_t t
same syntax as the resume=device
parameter, we can parse the resume=device in the init script and
use the resume device directly from the kernel command line.
Signed-off-by: Sebastian Capella
Cc: Len Brown
Cc: Pavel Machek
Cc: "Rafael J. Wysocki"
---
kernel/power/hib
Patchset related to hibernation resume:
- enhancement to make the use of an existing resume file more general
Patch is based on the 3.13 tag. This was tested on a Beaglebone black
with partial hibernation support, also compiled for x86_64.
[PATCH v9 1/1] PM / Hibernate: use name_to_dev_t t
Patchset related to hibernation resume:
- enhancement to make the use of an existing resume file more general
- add kstrdup_trimnl function which duplicates and trims a single
trailing newline off of a string
- cleanup checkpatch warnings in hibernate.c file
All patches are based on th
same syntax as the resume=device
parameter, we can parse the resume=device in the init script and
use the resume device directly from the kernel command line.
Signed-off-by: Sebastian Capella
Cc: Pavel Machek
Cc: Len Brown
Cc: "Rafael J. Wysocki"
---
kernel/power/hib
Checkpatch reports several warnings in hibernate.c
printk use removed, long lines wrapped, whitespace cleanup,
extend short msleeps, while loops on two lines.
Signed-off-by: Sebastian Capella
Cc: Pavel Machek
Cc: Len Brown
Cc: "Rafael J. Wysocki"
---
kernel/power/hibernat
kstrdup_trimnl creates a duplicate of the passed in
null-terminated string. If a trailing newline is found, it
is removed before duplicating. This is useful for strings
coming from sysfs that often include trailing whitespace due to
user input.
Signed-off-by: Sebastian Capella
Cc: Andrew
Quoting David Rientjes (2014-02-03 17:05:04)
> The last we heard, I think Sebastian is looking to redo this series and
> this patch is no longer needed. Sebastian?
Hi David, Alexey,
I am in the process of reworking the patches. I'm not sure if Andrew
was just interested in having the kstrimdup
Quoting Pavel Machek (2014-01-31 04:24:21)
> Well, your /sys/power/resume patch would be nice cleanup, but it
> changs behaviour, too... which is unnice. Stripping trailing "\n" is
> probably neccessary, because we did it before. (It probably was a
> mistake). But kernel is not right place to secon
kstrimdup creates a whitespace-trimmed duplicate of the passed
in null-terminated string. This is useful for strings coming
from sysfs that often include trailing whitespace due to user
input.
Thanks to Joe Perches for this implementation.
Signed-off-by: Sebastian Capella
Cc: Andrew Morton
Cc
Patchset related to hibernation resume:
- enhancement to make the use of an existing resume file more general
- add kstrimdup function which trims and duplicates a string
Both patches are based on the 3.13 tag. This was tested on a
Beaglebone black with partial hibernation support, and co
same syntax as the resume=device
parameter, we can parse the resume=device in the init script and
use the resume device directly from the kernel command line.
Signed-off-by: Sebastian Capella
Acked-by: Pavel Machek
Cc: Len Brown
Cc: "Rafael J. Wysocki"
---
kernel/power/hib
Patchset related to hibernation resume:
- enhancement to make the use of an existing resume file more general
- add kstrimdup function which trims and duplicates a string
Both patches are based on the 3.13 tag. This was tested on a
Beaglebone black with partial hibernation support, and co
kstrimdup will duplicate and trim spaces from the passed in
null terminated string. This is useful for strings coming from
sysfs that often include trailing whitespace due to user input.
Signed-off-by: Sebastian Capella
Cc: Andrew Morton
Cc: Joe Perches
Cc: Mikulas Patocka
Cc: Rik van Riel
same syntax as the resume=device
parameter, we can parse the resume=device in the init script and
use the resume device directly from the kernel command line.
Signed-off-by: Sebastian Capella
Acked-by: Pavel Machek
Cc: Len Brown
Cc: "Rafael J. Wysocki"
---
kernel/power/hib
Quoting Joe Perches (2014-01-29 17:24:28)
> Why not minimize the malloc length too?
>
> maybe something like:
>
> char *kstrimdup(const char *s, gfp_t gfp)
> {
> char *buf;
> const char *begin = skip_spaces(s);
> size_t len = strlen(begin);
>
> while (len && isspa
same syntax as the resume=device
parameter, we can parse the resume=device in the init script and
use the resume device directly from the kernel command line.
Signed-off-by: Sebastian Capella
Cc: Pavel Machek
Cc: Len Brown
Cc: "Rafael J. Wysocki"
---
kernel/power/hib
kstrimdup will duplicate and trim spaces from the passed in
null terminated string. This is useful for strings coming from
sysfs that often include trailing whitespace due to user input.
Signed-off-by: Sebastian Capella
Cc: Andrew Morton
Cc: Rik van Riel (commit_signer:5/10=50%)
Cc: Michel
Patchset related to hibernation resume:
- enhancement to make the use of an existing resume file more general
- add kstrimdup function which trims and duplicates a string
Both patches are based on the 3.13 tag. This was tested on a
Beaglebone black with partial hibernation support, and co
a little sense in adding hibernation support to ARM-only drivers..
FYI, we at Linaro and a few others have been working on adding
hibernation support for ARM. I have not coordinated with Jonghwan
however.
Apoligies for the earlier toppost.
Thanks,
Sebastian Capella
--
To unsubscribe from this list: se
r
handling.
By handling trailing newlines in name_to_dev_t, userspace
buffers may be directly passed to name_to_dev_t without
modification.
Signed-off-by: Sebastian Capella
Reviewed-by: Pavel Machek
Cc: "Eric W. Biederman"
Cc: Serge Hallyn
Cc: Andrew Morton
Cc: Stephen Warren
Cc:
same syntax as the resume=device
parameter, we can parse the resume=device in the init script and
use the resume device directly from the kernel command line.
Signed-off-by: Sebastian Capella
Acked-by: Pavel Machek
Cc: Len Brown
Cc: "Rafael J. Wysocki"
---
kernel/power/hib
Patchsets related to hibernation resume:
- enhancement to make the use of an existing resume file more general
- enhance name_to_dev_t to ignore trailing newlines coming from userspace.
Both patches are based on the 3.12-rc3 tag. This was tested on a
Pandaboard with partial hibernation suppor
same syntax as the resume=device
parameter, we can parse the resume=device in the init script and
use the resume device directly from the kernel command line.
Signed-off-by: Sebastian Capella
Cc: Len Brown
Cc: Pavel Machek
Cc: "Rafael J. Wysocki"
---
kernel/power/hibernate.c | 15 +++
r
handling.
By handling trailing newlines in name_to_dev_t, userspace
buffers may be directly passed to name_to_dev_t without
modification.
Signed-off-by: Sebastian Capella
Cc: Pavel Machek
Cc: "Eric W. Biederman"
Cc: Serge Hallyn
Cc: Andrew Morton
Cc: Stephen Warren
Cc: Jens Axboe
Cc
Patchset related to hibernation resume: one enhancement to make the use
of an existing resume file more general and one enhances name_to_dev_t
to ignore the trailing newlines coming from userspace.
Both patches are based on the 3.11 tag. This was tested on a
Pandaboard with partial hibernation su
Quoting Sebastian Capella (2013-09-12 13:54:54)
> The name_to_dev_t function has a comment block which lists the
> supported syntaxes for the device name. Add a bullet for
> the : syntax, which is already supported in the code
>
> Signed-off-by: Sebastian Capella
> Cc: A
The name_to_dev_t function has a comment block which lists the
supported syntaxes for the device name. Add a bullet for
the : syntax, which is already supported in the code
Signed-off-by: Sebastian Capella
Cc: Andrew Morton
Cc: Stephen Warren
Cc: Jens Axboe
Cc: Greg Kroah-Hartman
Cc: Al
same syntax as the resume=device
parameter, we can parse the resume=device in the init script and
use the resume device directly from the kernel command line.
Signed-off-by: Sebastian Capella
Cc: Len Brown
Cc: Pavel Machek
Cc: "Rafael J. Wysocki"
---
kernel/power/hib
Expand the existing documentation to explicitly list the options for
resuming a hibernation image, including the manual resume option which
can be used from the initrd or initramfs and the kernel init resume.
Signed-off-by: Sebastian Capella
Cc: Rob Landley
Cc: Len Brown
Cc: Pavel Machek
Cc
Patchset related to hibernation resume: one enhancement to make the use
of an existing file more general and one documentation update.
Both patches are based on the 3.11-rc6 tag. This was tested on a
Pandaboard with partial hibernation support, and compiled on x86.
Further testing is needed on o
From: Sebastian Capella
Subject: [PATCH RFC 2/2] PM / Hibernate: add section for resume options
Expand the existing documentation to explicitly list the options for
resuming a hibernation image, including the manual resume option which
can be used from the initrd or initramfs and the kernel init
same syntax as the resume=device
parameter, we can parse the resume=device in the init script and
use the resume device directly from the kernel command line.
Signed-off-by: Sebastian Capella
---
kernel/power/hibernate.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --
1 - 100 of 102 matches
Mail list logo
