On Mon, Apr 12, 2021 at 10:57 PM Zhiyong Tao wrote:
> @@ -176,6 +180,12 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
> else
> err = -ENOTSUPP;
> break;
> + case MTK_PIN_CONFIG_RSEL:
> + if (hw->soc->rsel_ge
On Mon, Apr 12, 2021 at 10:57 PM Zhiyong Tao wrote:
>
> This patch provides the advanced drive raw data setting version
> for I2C used pins on MT8195.
>
> Signed-off-by: Zhiyong Tao
Acked-by: Sean Wang
> ---
> drivers/pinctrl/mediatek/pinc
On Mon, Apr 12, 2021 at 10:57 PM Zhiyong Tao wrote:
>
> This commit includes pinctrl driver for mt8195.
>
> Signed-off-by: Zhiyong Tao
Acked-by: Sean Wang
> ---
> drivers/pinctrl/mediatek/Kconfig |6 +
> drivers/pinctrl/mediatek/Makefile
Hi Zhiyong,
On Fri, Mar 12, 2021 at 2:35 PM Zhiyong Tao wrote:
>
> When multiple threads operate on the same register resource
> which include multiple pin, It will make the register resource
> wrong to control. So we add lock to avoid the case.
>
> Signed-off-by: Zhiyong Tao
> ---
> drivers/pi
compatible to previous
> Mediatek's bias-pull usage")
> Signed-off-by: Hsin-Yi Wang
Acked-by: Sean Wang
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
ers.
>
After confirming with the internal team, MT7622 actually does not have
the 7th channel. Thanks for Frank's catchup and patch.
Acked-by: Sean Wang
> The rest should probably go through ARM SoC.
>
> Yours,
> Linus Walleij
Memory Limit: none
> [ 2.228860] ---[ end Kernel panic - not syncing: Attempted to kill init!
> exitcode=0x000b ]---
>
> Fixes: 89132dd8ffd2 ("pinctrl: mediatek: extend eint build to
> pinctrl-mtk-common-v2.c")
> Signed-off-by: Enric Balletbo i S
On Wed, Sep 30, 2020 at 1:47 AM Linus Walleij wrote:
>
> On Sun, Sep 27, 2020 at 7:57 PM Sean Wang wrote:
>
> > v2 seems the same with v1 or I was missing something.
> >
> > I just thought we call devm_ioremap_release to explicitly to free
> > resource wh
On Mon, Sep 21, 2020 at 6:10 AM Qinglang Miao wrote:
>
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao
Acked-by: Sean Wang
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 10 ++
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
On Fri, Sep 25, 2020 at 5:51 AM Hanks Chen wrote:
>
> Hi Sean & Linux & Matthias,
>
> Please kindly let me know your comments about this fixes patch.
> Thanks
>
Acked-by: Sean Wang
> Regards,
> Hanks
>
>
> On Thu, 2020-08-20 at 19:22 +0800, Hanks Che
2.199611] Kernel panic - not syncing: Attempted to kill init!
> > exitcode=0x000b
> > [2.207260] SMP: stopping secondary CPUs
> > [2.211294] Kernel Offset: 0x2ebff480 from 0x80001000
> > [2.217377] PHYS_OFFSET: 0xb5050
Hi Light,
On Thu, Aug 20, 2020 at 9:47 PM Light Hsieh wrote:
>
> On Wed, 2020-08-19 at 16:11 -0700, Sean Wang wrote:
> > Hi Light,
> >
> > On Tue, Aug 18, 2020 at 1:36 AM wrote:
> > >
> > > From: Light Hsieh
> > >
> > > Some
On Wed, Aug 19, 2020 at 9:19 AM Enric Balletbo i Serra
wrote:
>
> The pinctrl driver can work without the EINT resource, but, if it is
> expected to have this resource but the mtk_build_eint() function fails
> after allocating their data (because can't get the resource or can't map
> the irq), the
Hi Hanks,
On Thu, Aug 13, 2020 at 4:14 AM Hanks Chen wrote:
>
> check mtk_is_virt_gpio input parameter,
> virtual gpio need to support eint mode.
>
> add error handler for the ko case
> to fix this boot fail:
> pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> lr : mtk_gpio_get_direction+
Hi Light,
On Tue, Aug 18, 2020 at 1:36 AM wrote:
>
> From: Light Hsieh
>
> Some MediaTek SOC provide more control registers other than value register.
s/MT6765/Some MediaTek SoC/
> Generanll, a value register need read-modify-write is at offset 0x0.
s/Generally/Generanll/
> A corresp
drivers/pinctrl/mediatek/pinctrl-mtk-mt6765.h:12,
> from drivers/pinctrl/mediatek/pinctrl-mt6765.c:10:
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning:
> ‘mtk_default_register_base_names’ defined but not used
> [-Wunused-const-variable=]
> 83 | static cons
On Fri, Jul 10, 2020 at 12:28 AM Zhiyong Tao wrote:
>
> This commit includes pinctrl driver for mt8192.
>
> Signed-off-by: Zhiyong Tao
It is good to see the clean driver with mtk-common-v2.
Acked-by: Sean Wang
> ---
> drivers/pinctrl/mediatek/Kconfig |7 +
On Tue, Jul 14, 2020 at 2:20 AM Hanks Chen wrote:
>
> for virtual gpios, they should not do reg setting and
> should behave as expected for eint function.
>
> Signed-off-by: Mars Cheng
> Signed-off-by: Hanks Chen
Acked-by: Sean Wang
> ---
> .../pinctrl/mediatek/pinct
> > Sean if you're OK with this patch I can just apply it separately.
>
> Ah nevermind since the next patch has your ACK I just applied this
> too since it's a dependency. Yell if this is wrong.
The patch looks good to me too.
By the way, I didn't see those applied patches in for-next branch yet
I
Hi,
On Thu, Sep 26, 2019 at 10:02 PM Light Hsieh wrote:
>
> Add support for pin configuration dump via catting
> /sys/kernel/debug/pinctrl/$platform_dependent_path/pinconf-pins.
> pinctrl framework had already support such dump. This patch implement the
> operation function pointer to fullfill th
Hi,
On Thu, Sep 26, 2019 at 10:02 PM Light Hsieh wrote:
>
> Refine mtk_pinconf_set()/mtk_pinconf_get() for backward compatibility to
> previous Mediatek's bias-pull usage.
MediaTek
> In PINCTRL_MTK that use pinctrl-mtk-common.c, bias-pull setting for pins
> with 2 pull resistors can be specifie
Hi,
On Thu, Sep 26, 2019 at 10:02 PM Light Hsieh wrote:
>
> 1.Refine mtk_pinconf_get():
> 1.1 Use only one occurrence of return at end of this function.
> 1.2 Correct cases for PIN_CONFIG_SLEW_RATE, PIN_CONFIG_INPUT_SCHMITT_ENABLE,
If you want to fix it a bug, you should submit a separate patch
Hi,
On Thu, Sep 26, 2019 at 10:02 PM Light Hsieh wrote:
>
> Mediatek's smarphone project actual usage does need to know current value
MediaTek
> (in mA) in procedure of finding the best driving setting.
> The steps in the procedure is like as follow:
>
> 1. set driving setting field in setting
On Thu, Sep 26, 2019 at 10:14 PM Light Hsieh wrote:
>
> Dear reviewers:
>
> Patch v6 improves v5 by:
>
> 1.in mtk_pinconf_get() and mtk_pinconf_set() @pinctrl-paris.c:
> * check if pin is in range before using pin as array index of
> hw->soc->pins[]
> 2.in mtk_pin_field_lookup() @pinctrl-mt
ed-by: Sebastian Reichel
Thanks for your help keep the unfinished driver to upstream
Acked-by: Sean Wang
> ---
> changes since v6: none
> changes since v5: split out mfd/mt6397/core.h
> changes since v4: none
> changes since v3: none
> changes since v2: none (=v2 pa
Hi Linus,
That looks OK to me too
Acked-by: Sean Wang
On Wed, Sep 11, 2019 at 2:29 AM Linus Walleij wrote:
>
> On Thu, Sep 5, 2019 at 7:00 AM Light Hsieh wrote:
>
> > v2 is the same as v1 except that commit message is corrected according
> > to Linus' comment for v1
On Mon, Aug 19, 2019 at 2:22 AM Mars Cheng wrote:
>
> add driver setting to support mt6779 eint
>
> Signed-off-by: Mars Cheng
Acked-by: Sean Wang
> ---
> drivers/pinctrl/mediatek/pinctrl-mt6779.c |8
> 1 file changed, 8 insertions(+)
>
> diff --git
On Mon, Aug 19, 2019 at 2:22 AM Mars Cheng wrote:
>
> This adds MT6779 pinctrl driver based on MediaTek pinctrl-paris core.
>
> Signed-off-by: Mars Cheng
> Signed-off-by: Andy Teng
Acked-by: Sean Wang
> ---
> drivers/pinctrl/mediatek/Kconfig |7 +
>
Hi, Light
a few nitpicks, but the overall changes look good to me
On Tue, Aug 13, 2019 at 1:53 AM Light Hsieh wrote:
>
> From: Light Hsieh
>
> Mediatek's smarphone project actual usage does need to know current value
> (in mA) in procedure of finding the best driving setting.
> The steps in the
Hi, Light
On Tue, Aug 13, 2019 at 1:53 AM Light Hsieh wrote:
>
> From: Light Hsieh
>
> Refine mtk_pinconf_set()/mtk_pinconf_get() for backward compatibility to
> previous Mediatek's bias-pull usage.
> In PINCTRL_MTK that use pinctrl-mtk-common.c, bias-pull setting for pins
> with 2 pull resist
On Tue, Aug 13, 2019 at 1:53 AM Light Hsieh wrote:
>
> From: Light Hsieh
>
> 1. Check if gpio pin number is in valid range to prevent from get invalid
>pointer 'desc' in the following code:
> desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio];
>
> 2. Use binary search in mtk_hw_
ld do anyway at a later stage in the resume sequence, when
> restoring cur_mask).
>
> Fixes: bf22ff45bed ("genirq: Avoid unnecessary low level irq function calls")
> Signed-off-by: Nicolas Boichat
Acked-by: Sean Wang
> ---
> drivers/pinctrl/mediatek/mtk-eint.c | 1
you added above as an instance
and adding Fixes tag as a fixup to mean you're fixing the existing
problem in the driver.
And then Acked-by: Sean Wang
> Signed-off-by: Nicolas Boichat
> ---
> drivers/pinctrl/mediatek/mtk-eint.c | 18 --
> 1 file changed,
name from mtk_eth_soc to mtk_eth.
> I didn't see a way to leave it as mtk_eth_soc.
>
> Reported-by: kbuild test robot
> Signed-off-by: Randy Dunlap
> Cc: Sean Wang
> Cc: John Crispin
> Cc: Felix Fietkau
> Cc: Nelson Chang
> ---
> drivers/net/ethernet/m
features.
> >
> > Nicolas Boichat (2):
> > pinctrl: mediatek: Add pm_ops to pinctrl-paris
> > pinctrl: mediatek: mt8183: Add mtk_pinctrl_paris_pm_ops
>
> All seems to look fair to me, but I need some official ACK from
> Sean on these.
>
sure, it looks g
Hi, Nicolas
On Thu, May 2, 2019 at 5:53 PM Nicolas Boichat wrote:
>
> On Thu, May 2, 2019 at 9:48 PM Yingjoe Chen wrote:
> >
> > On Mon, 2019-04-29 at 11:25 +0800, Nicolas Boichat wrote:
> > > pinctrl variants that include pinctrl-mtk-common-v2.h (and not
> > > pinctrl-mtk-common.h) also need to
Hi, Long
I guess you should mean "flow control", not "follow control".
And the commit subject should be swapped between 1/2 and 2/2,
otherwise, the subject is inconsistent with its own content.
Sean
On Thu, Apr 25, 2019 at 1:41 AM Long Cheng wrote:
>
> Add SW and HW follow control functi
>
> On Sun, 2019-04-14 at 16:01 -0700, Sean Wang wrote:
> > Hi, Light
> >
> > On Thu, Apr 11, 2019 at 8:15 PM Light Hsieh
> > wrote:
> > >
> > > The orginal PINCTRL_MTK_PARIS/PINCTRL_MTK_MOORE need more effort for
> > > specify
Hi, Fabien
After reusing the eint_regs common, the result looks good to me
On Tue, Apr 16, 2019 at 1:33 AM Fabien Parent wrote:
>
> This commit adds the pinctrl driver for the MediaTek's MT8516 SoC.
>
> Signed-off-by: Fabien Parent
Acked-by: Sean Wang
> ---
>
> v2
Hi, Light
On Thu, Apr 11, 2019 at 8:15 PM Light Hsieh wrote:
>
> The orginal PINCTRL_MTK_PARIS/PINCTRL_MTK_MOORE need more effort for
> specifying register bases when porting platform driver:
> 1. Write mt_pinctrl_register_base_name[] array in pinctrl-mt.c
>to specify names of registe
Hi, Light
On Thu, Apr 11, 2019 at 2:32 AM Light Hsieh wrote:
>
> Since no single Mediatek chip use code for PINCTRL_MTK and code for
> PINCTRL_MTK_MOORE/PINCTRL_MTK_PARIS simultaneously, it is better to use
> different config to determine if related code will be built or not on
> building non-gen
Hi, Fabien
On Sat, Mar 23, 2019 at 2:17 PM Fabien Parent wrote:
>
> Signed-off-by: Fabien Parent
> ---
> drivers/pinctrl/mediatek/Kconfig |7 +
> drivers/pinctrl/mediatek/Makefile |1 +
> drivers/pinctrl/mediatek/pinctrl-mt8516.c | 384 ++
> drivers/pin
This is just a gentle ping of the series
On Fri, 2019-01-25 at 07:26 +0800, sean.w...@mediatek.com wrote:
> From: Sean Wang
>
> v6:
> * fix drivers/bluetooth/btusb.c:2683:2-3: Unneeded semicolon based reported
> by [1]
> * update power-on sequence with adding neccesary t
this is just a gentle ping
On Tue, 2019-03-05 at 08:14 +0800, sean.w...@mediatek.com wrote:
> From: Sean Wang
>
> Fixed warning: incorrect type in assignment reported by kbuild test robot.
> The detailed warning is shown as below.
>
> make ARCH=x86_64 allmodconfig
> make
> > drivers/bluetooth/btmtksdio.c:375:17: note: ‘old_data’ was declared here
> > unsigned char *old_data;
> > ^~~~
> >
> > Fixes: d74eef2834b5 ("Bluetooth: mediatek: add support for MediaTek MT7663S
> > and
ndle irq status %08x\n",
> - status);
> + dev_dbg(hsdma->ddev.dev, "unhandle irq status %08x\n",
> status);
> /* clean intr bits */
> mtk_hsdma_write(hsdma, HSDMA_REG_INT_STATUS, status);
>
Acked-by: Sean Wang
On Mon, Mar 11, 2019 at 3:06 PM Rob Herring wrote:
>
> On Mon, Mar 11, 2019 at 12:19:32PM -0700, Sean Wang wrote:
> > Hi,
> >
> > Always put the patches about dt-binding changes at the head of the
> > series to let the related maintainer more easily find them.
> &
On Mon, 2019-03-11 at 17:38 +0100, Marcel Holtmann wrote:
> Hi Sean,
>
> > The SDIO identifier for MediaTek Bluetooth devices were defined in the
> > MediaTek Bluetooth driver. Moving the definitions in MMC header file
> > seems common sense.
> >
> > Signed-of
em into the common files and allow
> > varous transport drivers to reuse them in the future.
> >
> > [1]
> > http://lists.infradead.org/pipermail/linux-mediatek/2019-January/017074.html
> >
> > Signed-off-by: Sean Wang
> > -
Hi,
On Sun, Mar 10, 2019 at 8:49 PM Hsin-Hsiung Wang
wrote:
>
> From: Ran Bi
>
> Alarm registers high byte was reserved for other functions.
> This add mask in alarm registers operation functions.
> This also fix error condition in interrupt handler.
>
> Fixes: fc2979118f3f ("rtc: mediatek: Add
Hi,
On Sun, Mar 10, 2019 at 8:49 PM Hsin-Hsiung Wang
wrote:
>
> add PMIC MT6358 related nodes which is for mt8183 platform
>
s/MT8183/mt8183/
> Signed-off-by: Hsin-Hsiung Wang
> ---
> arch/arm64/boot/dts/mediatek/mt6358.dtsi | 318
> +++
> 1 file changed, 318 inse
Hi,
On Sun, Mar 10, 2019 at 8:50 PM Hsin-Hsiung Wang
wrote:
>
> This adds support for the MediaTek MT6358 PMIC. This is a
> multifunction device with the following sub modules:
>
> - Regulator
> - RTC
> - Codec
> - Interrupt
>
> It is interfaced to the host controller using SPI interface
> by a p
Hi,
add a dt-bindings prefix and move the patch to the first order in the series.
On Sun, Mar 10, 2019 at 9:03 PM Hsin-Hsiung Wang
wrote:
>
> add dt-binding document for MediaTek MT6358 PMIC
>
> Signed-off-by: Hsin-Hsiung Wang
> ---
> .../bindings/regulator/mt6358-regulator.txt| 318
Hi,
Always put the patches about dt-binding changes at the head of the
series to let the related maintainer more easily find them.
On Sun, Mar 10, 2019 at 8:48 PM Hsin-Hsiung Wang
wrote:
>
> This adds compatible for the MediaTek MT6358 PMIC.
>
> Signed-off-by: Hsin-Hsiung Wang
> ---
> Document
Hi,
I would expect the patch just a migration patch that just moves the
code and should not add something changed or something new in the
patch.
but a new mt6397_irq_pm_notifier is being added into mt6397-irq.c so I
guessed the patch is needed to be refined and split into several
patches on advanc
Hi,
On Sun, Mar 10, 2019 at 8:48 PM Hsin-Hsiung Wang
wrote:
>
> clean up code
>
> Signed-off-by: Hsin-Hsiung Wang
> ---
> drivers/mfd/mt6397-core.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> i
Hi, Long
List some comments as the below and this week I will find a board to
test and then improve the driver.
Sean
On Wed, Mar 6, 2019 at 5:45 PM Long Cheng wrote:
>
> In DMA engine framework, add 8250 uart dma to support MediaTek uart.
> If MediaTek uart enabled(SERIAL_8250_MT6577),
On Sat, Mar 2, 2019 at 5:53 PM Zhiyong Tao wrote:
>
> This patch provides the advanced drive for I2C used pins on MT8183.
> The detail strength specification description of the I2C pin is as follows.
> When E1=0/E0=0, the strength is 0.125mA.
> When E1=0/E0=1, the strength is 0.25mA.
> When E1=1/E
n
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:229:2-3: Unneeded semicolon
> drivers/net/usb/sr9700.c:437:2-3: Unneeded semicolon
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
Acked-by: Sean Wang for mt7530 and mtk_eth_soc
gt; > in Patch 4/6, 5/6 to add the general flow which MT7622 and even MT7663U and
> > MT7668U USB devices also utilize.
> >
> > Finally, in patch 6/6 to add the specific setups for MediaTek UART-based
> > Bluetooth and enable MT7663U and MT7668U device.
> >
>
On Mon, Jan 28, 2019 at 2:35 PM Dmitry Voytik wrote:
>
> How to reproduce the problem:
> $ make tinyconfig
> $ make menuconfig
> then enable:
> CONFIG_COMPILE_TEST=y
> CONFIG_PINCTRL=y
> and any of these:
> CONFIG_PINCTRL_MT7622=y
> CONFIG_PINCTRL_MT7629=y
> CONFIG_PINCTRL_MT7623=y
>
> This c
On Thu, Jan 24, 2019 at 2:46 AM wrote:
>
> From: Shun-Chih Yu
>
> This patch introduces active_vdec to indicate the virtual descriptor
> under processing by the CQDMA dmaengine, and simplify the control logic
> by removing redundant queue structure, tasklets, and completion
> management.
>
> Also
found on MT6765 SoC or other similar Mediatek SoCs.
>
> Signed-off-by: Shun-Chih Yu
> Reviewed-by: Rob Herring
otherwise, Acked-by: Sean Wang
> ---
> .../devicetree/bindings/dma/mtk-cqdma.txt | 31
>
> 1 file changed, 31 insertio
Hi Shun-Chih,
the driver seems already be applied since v5.0-rc1
I suggest these improvements you made in the recent version can be
split into several patches and then be applied on the top of the base
driver.
On Wed, Jan 23, 2019 at 11:15 PM wrote:
>
> This patchset introduces support for Medi
On Tue, 2019-01-22 at 09:47 +0100, Loys Ollivier wrote:
> On Mon 21 Jan 2019 at 18:44, Sean Wang wrote:
>
> > On Mon, Jan 21, 2019 at 9:29 AM Loys Ollivier
> > wrote:
> >>
> >>
> >> On Mon 21 Jan 2019 at 17:10, Rob Herring wrote:
> >>
&g
On Mon, Jan 21, 2019 at 9:29 AM Loys Ollivier wrote:
>
>
> On Mon 21 Jan 2019 at 17:10, Rob Herring wrote:
>
> > On Thu, 17 Jan 2019 17:54:32 +0100, Loys Ollivier wrote:
> >> Add binding for Mediatek-based GNSS receivers.
> >>
> >> Signed-off-by: Loys Ollivier
> >> ---
> >>
> >> v2:
> >> Renamed
;t
> > needed. It's done by phy_link_change() in phylib.
> >
> > Signed-off-by: Frank Wunderlich
> > ---
> > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 16
> > 1 file changed, 16 deletions(-)
> >
> Reviewed-by: Heiner Kallweit
Thanks for your help to have the driver more fit in phylib.
Acked-by: Sean Wang
;BUILD_BUG_ON_ZERO'
> #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
> ^
> ../include/linux/kernel.h:72:59: note: in expansion of macro '__must_be_array'
> #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)
On Tue, Jan 8, 2019 at 11:07 AM Frank Wunderlich
wrote:
>
>
> > In mtk_phy_connect() I would say this complete block can be removed.
> > All this is handled internally by phylib.
> >
> > dev->phydev->autoneg = AUTONEG_ENABLE;
> > dev->phydev->speed = 0;
> > dev->phydev->duplex =
Signed-off-by: chuanjia.liu
Acked-by: Sean Wang
BTW, if you were worried about a patch is lost, you could use RESEND
in the tag is fine.
> ---
> change note:
> v5: This patch is the same as v4,re-upload due to
> mail permissions issues
> ---
> drivers/pinctrl/mediatek/
On Fri, Jan 4, 2019 at 12:48 AM Zhiyong Tao wrote:
>
> On Wed, 2018-12-12 at 04:51 +0800, Sean Wang wrote:
> > The subject should be refined to be close to the content
> >
> > On Tue, Dec 11, 2018 at 12:02 AM Zhiyong Tao
> > wrote:
> > >
> > > Thi
On Fri, Jan 4, 2019 at 1:40 AM Zhiyong Tao wrote:
>
> On Fri, 2019-01-04 at 01:14 -0800, Sean Wang wrote:
> > On Thu, Jan 3, 2019 at 11:09 PM Zhiyong Tao
> > wrote:
> > >
> > > On Sat, 2018-12-29 at 06:04 +0800, Rob Herring wrote:
> > > > On Fri,
On Thu, Jan 3, 2019 at 11:09 PM Zhiyong Tao wrote:
>
> On Sat, 2018-12-29 at 06:04 +0800, Rob Herring wrote:
> > On Fri, Dec 28, 2018 at 04:09:40PM +0800, Erin Lo wrote:
> > > From: Zhiyong Tao
> > >
> > > The commit adds mt8183 compatible node in binding document.
> > >
> > > Signed-off-by: Zhiy
go on other parts not finished review at the last time
On Sat, Dec 29, 2018 at 3:03 AM Sean Wang wrote:
>
> The version looks like better than the earlier version, but there are
> still a few nitpicks I post at the inline.
>
> On Thu, Dec 27, 2018 at 5:11 AM wrote:
> >
&
On Mon, Dec 24, 2018 at 8:25 PM wrote:
>
> From: Chuanjia Liu
>
there are still some nitpicks
an empty char should follow the ':' char
> Virtual gpio only used inside SOC and not being exported to outside SOC.
> Some modules use virtual gpio as eint and doesn't nedd SMT.
s/nedd/need/
> So th
On Mon, Dec 17, 2018 at 6:32 PM wrote:
>
I thought the subject still is much general, it should be further
improved with something like "add EINT support to virtual GPIOs" and
should say more about what virtual GPIOs means by MTKers in the patch
description because "virtual" is a usual term used
On Mon, Dec 17, 2018 at 6:43 PM Biao Huang wrote:
>
> 1. remove fine-tune property and related setting to simplify
> the timing adjustment flow.
> 2. set timing value according to the value from device tree,
> and will not care whether PHY insert internal delay.
>
> Signed-off-by: Biao Huang
> --
On Mon, Dec 17, 2018 at 12:40 AM Long Cheng wrote:
>
> On Fri, 2018-12-14 at 12:09 -0800, Sean Wang wrote:
< ... >
> > > > > +
> > > > > + mtk_dma_chan_write(c, VFF_ADDR, cfg->src_addr);
> > > >
On Sun, Dec 16, 2018 at 7:15 PM Chuanjia Liu wrote:
>
> On Thu, 2018-12-13 at 11:33 -0800, Sean Wang wrote:
> > On Thu, Dec 13, 2018 at 1:36 AM wrote:
> > >
> > > From: Chuanjia Liu
> > >
> > > This patch add gpio vritual number select,avoid
On Thu, Dec 13, 2018 at 3:36 AM Long Cheng wrote:
Hope those comments did not get a response that means they're fine with you.
< ... >
> > > +struct mtk_dmadev {
> > > + struct dma_device ddev;
> > > + void __iomem *mem_base[MTK_APDMA_CHANNELS];
> > > + spinlock_t lock; /* dma
And the subject should be also corrected with prefix starting with
"pinctrl: mediatek:", typo fixup, and having a better subject close to
the content.
On Thu, Dec 13, 2018 at 1:36 AM wrote:
>
> From: Chuanjia Liu
>
> This patch add gpio vritual number select,avoid virtual gpio set SMT.
>
> Signe
On Thu, Dec 13, 2018 at 1:36 AM wrote:
>
> From: Chuanjia Liu
>
> This patch add gpio vritual number select,avoid virtual gpio set SMT.
s/gpio/GPIO/
s/vritual/virtual/
Virtual GPIOs you said here that means these pins only used inside SoC
and not being exported to outside SoC, right? It seems t
It looks good to me. Thanks for bringing the improved version soon.
Acked-by: Sean Wang
On Wed, Dec 12, 2018 at 6:28 PM Ryder Lee wrote:
>
> Remove prompts to make all pinctrl cores to non-visible symbols and
> make sure the target SoCs would be coupled with the correspondin
On Wed, Dec 12, 2018 at 1:59 AM Ryder Lee wrote:
>
> Improve dependencies for the pinctrl drivers which select
> PINCTRL_MTK_MOORE as its core layer.
> ---
> drivers/pinctrl/mediatek/Kconfig | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pinctrl/med
Sorry for that I didn't have a full review at one time in the earlier version
On Mon, Dec 10, 2018 at 9:37 PM Long Cheng
wrote:
>
> In DMA engine framework, add 8250 mtk dma to support it.
It looks like there are still many rooms to improve the description,
especially it's a totally new d
The subject should be refined to be close to the content
On Tue, Dec 11, 2018 at 12:02 AM Zhiyong Tao wrote:
>
> This patch provides the advanced drive for I2C used pins on MT8183.
>
Additionally, you should state more how much strength in mA given on
each step E1, E0 move forward. This way woul
Hi Olof,
I'm a guy from MediaTek.
Thanks for your input and we will get these bad things to be better.
On Fri, Dec 7, 2018 at 10:42 AM Olof Johansson wrote:
>
> On Wed, Dec 5, 2018 at 4:01 AM Linus Walleij wrote:
> >
> > On Mon, Dec 3, 2018 at 2:08 AM Matthias Brugger
> > wrote:
> > > On 15/1
On Thu, Dec 6, 2018 at 1:55 AM Long Cheng wrote:
>
> On Wed, 2018-12-05 at 13:07 -0800, Sean Wang wrote:
> > .
> > On Wed, Dec 5, 2018 at 1:31 AM Long Cheng wrote:
> > >
> > > In DMA engine framework, add 8250 mtk dma to support it.
> > >
> > &g
.
On Wed, Dec 5, 2018 at 1:31 AM Long Cheng wrote:
>
> In DMA engine framework, add 8250 mtk dma to support it.
>
> Signed-off-by: Long Cheng
> ---
> drivers/dma/mediatek/8250_mtk_dma.c | 894
> +++
> drivers/dma/mediatek/Kconfig| 11 +
> drivers/dma/m
On Mon, Dec 3, 2018 at 5:34 AM wrote:
>
> From: qii wang
>
> Add MT8183 i2c binding to binding file. Compare to 2712 i2c
> controller, MT8183 has different registers, offsets, clock,
> and multi-user function.
>
> Signed-off-by: qii wang
> ---
> Documentation/devicetree/bindings/i2c/i2c-mtk.txt
於 2018年12月3日 週一 上午5:35寫道：
>
> From: qii wang
>
> New i2c registers would have different offsets, so we use different
> offsets array to distinguish different i2c registers version.
>
> Signed-off-by: qii wang
They are almost 1 to 1 function translation being taken here,
於 2018年12月3日 週一 上午5:40寫道：
>
> From: qii wang
>
> Completion_done is useless when we don't use its return value,
> so we remove it. Different speeds have been defined by macros,
> so we use macros definitions.
>
> Signed-off-by: qii wang
Reviewed-by: Sean Wang
&g
於 2018年12月3日 週一 上午5:34寫道：
>
> From: qii wang
>
> Add MT7629 i2c binding to i2c-mt2712.txt and there is no need to
where's i2c-mt2712.txt mentioned here?
> modify i2c driver.
suggest not to mention driver in any dt-binding, dt-binding self
should be os-agnostic
>
> Signed-off-by: qii wang
> -
於 2018年12月3日 週一 上午5:34寫道：
>
> From: qii wang
>
> Add i2c compatible for MT8183. Compare to 2712 i2c controller, MT8183 has
> different registers, offsets, clock, and multi-user function.
>
> Signed-off-by: qii wang
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 136
> ++
>
> On Wed, Nov 28, 2018 at 4:37 AM Sean Wang wrote:
> >
> > Weiyi Lu 於 2018年11月26日 週一 下午7:45寫道：
> > >
> > > From: Owen Chen
> > >
> > > PLLs with tuner_en bit, such as APLL1, need to disable
> > > tuner_en before apply new frequen
>
> Signed-off-by: Nicholas Mc Guire
Acked-by: Sean Wang
> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
> ---
>
> V2: A logic error spoted by Sean Wang the
> success case is 0 and thus returning early should be on on
> ret!=0 and not
Weiyi Lu 於 2018年11月26日 週一 下午7:45寫道：
>
> From: Owen Chen
>
> PLLs with tuner_en bit, such as APLL1, need to disable
> tuner_en before apply new frequency settings, or the new frequency
> settings (pcw) will not be applied.
> The tuner_en bit will be disabled during changing PLL rate
> and be resto
rm-dependent.
The patch title seems much general. It should be more specific to
reflect the content,
such as add configurable parameters pcwibits and fmin to mtk_pll.
Apart from that: Acked-by: Sean Wang
>
> Signed-off-by: Owen Chen
> Signed-off-by: Weiyi Lu
> ---
> drivers/cl
>
> From: Owen Chen
>
> On both MT8183 & MT6765, there add "set/clr" register for
> each clkmux setting, and one update register to trigger value change.
> It is designed to prevent read-modify-write racing issue.
> The sw design need to add a new API to handle this hw change with
> a new mtk_clk
>
> On Mon, Nov 26, 2018 at 11:49:26PM -0800, Sean Wang wrote:
> > Nicholas Mc Guire ??? 2018???11???21??? ??
> > ??10:13?
> > >
> > > The error cases of mediatek_gpio_bank_probe() would go unnoticed (except
> > > for the dev_err() m
1 - 100 of 362 matches
Mail list logo
