> On Jan 15, 2017, at 10:30 PM, Derek Robson wrote:
>
> Changed bare use of 'unsigned' to the prefered us of 'unsigned int'
> found using checkpatch
Just wondering if you compiled? This patch looks exactly like a patch I tried,
but it didn't compile.
> Signed-off-by: Derek Robson
> ---
> d
Fixed Alignment should match open parenthesis checkpatch CHECK.
Signed-off-by: Scott Matheina
---
drivers/staging/wlan-ng/cfg80211.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c
b/drivers/staging/wlan-ng/cfg80211.c
index aa0e5a3
Fixes checkpatch CHECK: Alignment should match open parenthesis
Signed-off-by: Scott Matheina
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers/staging/wilc1000/linux_wlan.c
index
Fixes checkpatch CHECK: Alignment should match open parenthesis
Signed-off-by: Scott Matheina
---
drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wilc_debugfs.c
index
Fixes checkpatch CHECK: Please don't use multiple blank lines
Signed-off-by: Scott Matheina
---
drivers/staging/wilc1000/wilc_debugfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wilc_debugfs.c
index 52aac75..7d
Fixes checkpatch CHECK: Alignment should match open parenthesis
Signed-off-by: Scott Matheina
---
drivers/staging/wilc1000/wilc_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_sdio.c
b/drivers/staging/wilc1000/wilc_sdio.c
index 3ad7cec
Fixes checkpatch CHECK:
Blank lines aren't necessary before a close brace '}'
Please don't use multiple blank lines
Signed-off-by: Scott Matheina
---
drivers/staging/wilc1000/wilc_sdio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wi
Fixes checkpatch warning: braces {} should be used on all arms of
this statement
Signed-off-by: Scott Matheina
---
drivers/staging/wilc1000/host_interface.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging
Fixes checkpatch warning: Alignment should match open parenthesis
Signed-off-by: Scott Matheina
---
drivers/staging/vt6656/mac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
index 86d98bc..417fdad 100644
Fixes checkpatch warning: Alignment should match open parenthesis
Signed-off-by: Scott Matheina
---
drivers/staging/vt6656/mac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
index 86d98bc..417fdad 100644
Fixed Alignment should match open parenthesis checkpatch CHECK
Signed-off-by: Scott Matheina
---
drivers/staging/vt6656/mac.c | 42 ++
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656
Fixed Alignment should match open parenthesis checkpatch CHECK
Signed-off-by: Scott Matheina
---
drivers/staging/vt6656/key.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vt6656/key.c b/drivers/staging/vt6656/key.c
index 0246a8f..cc18cb1
Fixed Alignment should match open parenthesis from checkpatch
Signed-off-by: Scott Matheina
---
drivers/staging/vt6656/main_usb.c | 59 ---
1 file changed, 31 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging
Fixed the following checkpatch warnings by deleting blank lines
Blank lines aren't necessary before a close brace '}'
Blank lines aren't necessary after an open brace '{'
Please don't use multiple blank lines
Signed-off-by: Scott Matheina
---
drivers/staging
Fixes checkpatch warning - Please don't use multiple blank lines
Signed-off-by: Scott Matheina
---
drivers/staging/sm750fb/ddk750_chip.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
b/drivers/staging/sm750fb/ddk750_chip.c
index ec33f1f..9a
Fixes absence of braces on last arm of statement, identified by
checkpatch
Signed-off-by: Scott Matheina
---
drivers/staging/sm750fb/ddk750_chip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
b/drivers/staging/sm750fb/ddk750_chip.c
Fixes checkpatch.pl warning - Blank lines aren't necessary before a
close brace '}' & Please don't use multiple blank lines
Signed-off-by: Scott Matheina
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 25 -
1 file changed, 25 deletions(-)
diff
Fixes Alignment should match open parenthesis in checkpatch
Signed-off-by: Scott Matheina
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
Fixed Checkpatch check "Alignment should match open parenthesis"
Signed-off-by: Scott Matheina
---
drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c
b/drive
Fixed checkpatch check blank line before closing brace '}'
Signed-off-by: Scott Matheina
---
drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c
b/drivers/staging/med
Aligned code with open parenthesis to fix a checkpatch warning
Signed-off-by: Scott Matheina
---
drivers/staging/rtl8712/mlme_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8712/mlme_linux.c
b/drivers/staging/rtl8712/mlme_linux.c
index
Removed unnecessary parentheses identified by checkpatch
Signed-off-by: Scott Matheina
---
drivers/staging/rtl8712/ieee80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.c
b/drivers/staging/rtl8712/ieee80211.c
index 5dc3b5b
Fixed style issue: Alignment should match open brace
Signed-off-by: Scott Matheina
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 38 -
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging
Removed unnecessary braces
Signed-off-by: Scott Matheina
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 106
1 file changed, 53 insertions(+), 53 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging/rtl8188eu/core/rtw_ap.c
index
Fixed coding style issue, un-necessary parenthesis present
Signed-off-by: Scott Matheina
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 106
1 file changed, 53 insertions(+), 53 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging
Fixed style issue: Alignment should match open parenthesis throughout file
Signed-off-by: Scott Matheina
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 38 -
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b
The patch series addresses some coding style issues contained within the file.
Scott Matheina (2):
drivers/staging/rtl8188eu/core/rtw_ap.c un-necessary parenthesis
drivers/staging/rtl8188eu/core/rtw_ap.c Alignment should match open
parenthesis
drivers/staging/rtl8188eu/core/rtw_ap.c
Fixes style issue where Alignment doesn't match open parenthesis
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/addac/adt7316-i2c.c
b/drivers/staging/iio/addac/adt7316-i2c.c
The permmission code was changed to reflect octat (0644/0444) for required
permissions.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 264 ++--
1 file changed, 101 insertions(+), 163 deletions(-)
diff --git a/drivers/staging/iio/addac
Lines were not aligned with (, this patch simply changes the indention, no
substantive
changes function of driver.
Signed-Off-By: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 415 ++--
1 file changed, 210 insertions(+), 205 deletions(-)
diff --git a
There was an additional line which was un-needed, removed that line.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
index e78d302..4678a64 100644
The code wasn't aligned with preceding ( on following lines, fixes
this coding style issue.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/iio/
Cases of camel case were fixed by making variables lower case throughout
the file.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 82 ++---
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316
Adds braces to second arm of if else statement.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
index 2b584a0..e78d302 100644
Across the file, variables were sometimes upper case, some times
lower case, this fix addresses a few of the instances with this
inconsistency.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 48 ++---
1 file changed, 24 insertions(+), 24
The description was split into 2 lines due to the line greatly
exceeding the 80 character soft limit.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers
*** BLURB HERE ***
Scott Matheina (8):
fixed long description text exceeding 80 characters
Fixed variables not being consistently lower case
Fix camel case issues
Fix braces not present on all arms of if else statement
Remove line after closing braces
Fixed code wrap alignment with
Adds braces to second arm of if else statement.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
index 2b584a0..e78d302 100644
Across the file, variables were sometimes upper case, some times
lower case, this fix addresses a few of the instances with this
inconsistency.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 48 ++---
1 file changed, 24 insertions(+), 24
The permmission code was changed to reflect octat (0644/0444) for required
permissions.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 264 ++--
1 file changed, 101 insertions(+), 163 deletions(-)
diff --git a/drivers/staging/iio/addac
There was an additional line which was un-needed, removed that line.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
index e78d302..4678a64 100644
The description was split into 2 lines due to the line greatly
exceeding the 80 character soft limit.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers
*** BLURB HERE ***
Scott Matheina (8):
fixed long description text exceeding 80 characters
Fixed variables not being consistently lower case
Fix camel case issues
Fix braces not present on all arms of if else statement
Remove line after closing braces
Fixed code wrap alignment with
Cases of camel case were fixed by making variables lower case throughout
the file.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 82 ++---
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316
fixed a missing letter in the TODO file 'unneeded'
Signed-off-by: Scott Matheina
---
drivers/staging/dgnc/TODO | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
index 0e0825b..6c91bbd 100644
--- a/drivers/staging
On 12/20/2016 09:23 PM, Joe Perches wrote:
On Tue, 2016-12-20 at 20:58 -0600, Scott Matheina wrote:
Fixed indention and space issues to align the code with the linux style guide.
[]
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
[]
@@ -176,16
> On Dec 20, 2016, at 9:23 PM, Joe Perches wrote:
>
>> On Tue, 2016-12-20 at 20:58 -0600, Scott Matheina wrote:
>> Fixed indention and space issues to align the code with the linux style
>> guide.
> []
>> diff --git a/drivers/staging/iio/addac/adt7316.c
>&
Fixed indention and space issues to align the code with the linux style guide.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 603
1 file changed, 266 insertions(+), 337 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
These changes where identified by checkpatch.pl as needed changes to
align the code with the linux development coding style. The several
lines of text where aligned with the precending parenthesis.
Signed-off-by: Scott Matheina
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 18
On 12/19/2016 12:35 AM, Greg KH wrote:
On Sun, Dec 18, 2016 at 11:47:30AM -0600, Scott Matheina wrote:
These changes where identified by checkpatch.pl as needed changes to
align the code with the linux development coding style. The several
lines of text where aligned with the precending
AM, Scott Matheina wrote:
On 12/18/2016 01:46 AM, Greg KH wrote:
On Sat, Dec 17, 2016 at 08:42:53PM -0600, Scott Matheina wrote:
Signed-off-by: Scott Matheina
I can't take patches without any changelog text :(
Yah. Forgot to add the description. Added for v2.
---
drivers/staging/fb
On 12/15/2016 07:50 PM, Linus Torvalds wrote:
On Thu, Dec 15, 2016 at 5:37 PM, Sergey Senozhatsky
wrote:
basically I'm talking about a bunch of 80-cols fixups.
Please don't.
Nobody uses a vt100 terminal any more. The 80-column wrapping is
excessive, and makes things like "grep" not work as
These changes where identified by checkpatch.pl as needed changes to
align the code with the linux development coding style. The several
lines of text where aligned with the precending parenthesis.
Signed-off-by: Scott Matheina
Changes to be committed:
modified: drivers/staging/fbtft
On 12/18/2016 01:46 AM, Greg KH wrote:
On Sat, Dec 17, 2016 at 08:42:53PM -0600, Scott Matheina wrote:
Signed-off-by: Scott Matheina
I can't take patches without any changelog text :(
Yah. Forgot to add the description. Added for v2.
---
drivers/staging/fbtft/fb_agm1264k-fl.c
Signed-off-by: Scott Matheina
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c
b/drivers/staging/fbtft/fb_agm1264k-fl.c
index a6e3af7..4e371ed 100644
--- a/drivers/staging
On 10/21/2015 09:15 PM, Richard Guy Briggs wrote:
On 15/10/21, Scott Matheina wrote:
On 10/21/2015 10:33 AM, Richard Guy Briggs wrote:
On 15/10/21, Joe Perches wrote:
On Mon, 2015-10-19 at 12:10 -0400, Richard Guy Briggs wrote:
On 15/10/18, Scott Matheina wrote:
On 10/14/2015 04:54 PM
On 10/21/2015 09:15 PM, Richard Guy Briggs wrote:
> On 15/10/21, Scott Matheina wrote:
>> On 10/21/2015 10:33 AM, Richard Guy Briggs wrote:
>>> On 15/10/21, Joe Perches wrote:
>>>> On Mon, 2015-10-19 at 12:10 -0400, Richard Guy Briggs wrote:
>>>>> On
On 10/21/2015 01:23 PM, Paul Moore wrote:
> On Sunday, October 18, 2015 12:50:45 PM Scott Matheina wrote:
>> On 10/14/2015 04:54 PM, Paul Moore wrote:
>>> On Saturday, October 10, 2015 08:57:55 PM Scott Matheina wrote:
>>>> Signed-off-by: Scott Matheina
>>&g
On 10/21/2015 10:33 AM, Richard Guy Briggs wrote:
> On 15/10/21, Joe Perches wrote:
>> On Mon, 2015-10-19 at 12:10 -0400, Richard Guy Briggs wrote:
>>> On 15/10/18, Scott Matheina wrote:
>>>> On 10/14/2015 04:54 PM, Paul Moore wrote:
>>>>> On Saturday
On 10/14/2015 04:54 PM, Paul Moore wrote:
> On Saturday, October 10, 2015 08:57:55 PM Scott Matheina wrote:
>> Signed-off-by: Scott Matheina
>> ---
>> kernel/auditfilter.c | 17 ++---
>> 1 file changed, 10 insertions(+), 7 deletions(-)
> Sorry f
Signed-off-by: Scott Matheina
---
kernel/auditfilter.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index 7714d93..774f9ad 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -39,13 +39,13
>From 06fabebf521e29014fd59518c923d671e6df0fce Mon Sep 17 00:00:00 2001
From: Scott Matheina
Date: Sat, 10 Oct 2015 16:05:51 -0500
Subject: [PATCH] Style Error line 1: Deleted trailing space This is a simple
patch to line 1 of kernel/audit.h, deleting a trailing space to remove a
style er
62 matches
Mail list logo