Re: [PATCH net-next v2 4/6] net: dsa: mv88e6xxx: implement port_fdb_dump

2015-10-14 Thread Scott Feldman
On Tue, Oct 13, 2015 at 9:46 AM, Vivien Didelot wrote: > Implement the port_fdb_dump DSA operation. > > Signed-off-by: Vivien Didelot Reviewed-by: Scott Feldman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@v

Re: [PATCH net-next 6/6] net: dsa: use switchdev obj in port_fdb_del

2015-10-07 Thread Scott Feldman
On Wed, Oct 7, 2015 at 4:48 PM, Vivien Didelot wrote: > For consistency with the FDB add operation, propagate the > switchdev_obj_port_fdb structure in the DSA drivers. > > Signed-off-by: Vivien Didelot Reviewed-by: Scott Feldman -- To unsubscribe from this list: send the line

Re: [PATCH net-next 5/6] net: dsa: push prepare phase in port_fdb_add

2015-10-07 Thread Scott Feldman
On Wed, Oct 7, 2015 at 4:48 PM, Vivien Didelot wrote: > Now that the prepare phase is pushed down to the DSA drivers, propagate > it to the port_fdb_add function. > > Signed-off-by: Vivien Didelot Reviewed-by: Scott Feldman -- To unsubscribe from this list: send the line "

Re: [PATCH net-next 4/6] net: dsa: add port_fdb_prepare

2015-10-07 Thread Scott Feldman
On Wed, Oct 7, 2015 at 4:48 PM, Vivien Didelot wrote: > Push the prepare phase for FDB operations down to the DSA drivers, with > a new port_fdb_prepare function. Currently only mv88e6xxx is affected. > > Signed-off-by: Vivien Didelot Reviewed-by: Scott Feldman -- To unsubscribe fr

Re: [PATCH v2 net-next 6/6] net: switchdev: extract struct switchdev_obj_*

2015-09-30 Thread Scott Feldman
On Wed, Sep 30, 2015 at 3:36 AM, Jiri Pirko wrote: > Tue, Sep 29, 2015 at 06:07:18PM CEST, vivien.dide...@savoirfairelinux.com > wrote: >>Now that switchdev and its drivers directly use specific switchdev_obj_* >>structures, move them out of the switchdev_obj union and get rif of this >>outer str

Re: Exporting obscene amounts of data in rtnl_link_ops->fill_info()

2015-08-19 Thread Scott Feldman
On Wed, Aug 19, 2015 at 5:47 PM, Jason A. Donenfeld wrote: > Hi guys, > > I have a new link driver that registers a rtnl_link_ops. For many > things, the rtnl interfaces are perfectly suited: I can use netlink in > userspace to check out packet counts, adjust interface parameters, and > all sorts

Re: [PATCH net-next v3 7/8] net: switchdev: support static FDB addresses

2015-08-10 Thread Scott Feldman
On Mon, Aug 10, 2015 at 6:09 AM, Vivien Didelot wrote: > This patch adds an ndm_state member to the switchdev_obj_fdb structure, > in order to support static FDB addresses. > > Set Rocker ndm_state to NUD_REACHABLE. > > Signed-off-by: Vivien Didelot Acked-by: Scott Feldman

Re: [PATCH net-next v2 2/7] net: switchdev: support static FDB addresses

2015-08-06 Thread Scott Feldman
On Thu, Aug 6, 2015 at 7:19 AM, Vivien Didelot wrote: > On 15-08-05 23:28:15, Scott Feldman wrote: >> On Wed, Aug 5, 2015 at 10:44 PM, Vivien Didelot >> wrote: >> > This patch adds a is_static boolean to the switchdev_obj_fdb structure, >> > in order to set the

Re: [PATCH net-next v2 2/7] net: switchdev: support static FDB addresses

2015-08-05 Thread Scott Feldman
On Wed, Aug 5, 2015 at 10:44 PM, Vivien Didelot wrote: > This patch adds a is_static boolean to the switchdev_obj_fdb structure, > in order to set the ndm_state to either NUD_NOARP or NUD_REACHABLE. > > Signed-off-by: Vivien Didelot > --- > include/net/switchdev.h | 1 + > net/switchdev/switch

Re: [PATCH net-next 3/4] net: dsa: add support for switchdev FDB objects

2015-08-04 Thread Scott Feldman
On Mon, Aug 3, 2015 at 11:30 PM, Vivien Didelot wrote: > Remove the fdb_{add,del,getnext} function pointer in favor of new > port_fdb_{add,del,getnext}. > > Implement the switchdev_port_obj_{add,del,dump} functions in DSA to > support the SWITCHDEV_OBJ_PORT_FDB objects. > > These functions are cal

Re: [PATCH] net: switchdev: restrict vid range abstraction

2015-07-29 Thread Scott Feldman
On Wed, Jul 29, 2015 at 12:14 PM, Vivien Didelot wrote: > Hi Scott, David, > > On Jul 29, 2015, at 2:28 PM, David da...@davemloft.net wrote: > >> From: Scott Feldman >> Date: Wed, 29 Jul 2015 00:31:44 -0700 >> >>> Since the netlink request (for example vl

Re: [PATCH] net: switchdev: restrict vid range abstraction

2015-07-29 Thread Scott Feldman
On Sun, Jul 26, 2015 at 4:45 PM, Vivien Didelot wrote: > This patch replaces the vid_begin and vid_end members of the > switchdev_obj_vlan structure for a single vid member. This way, the VID > range abstraction is restricted to switchdev, not exposed to drivers. > > The main benefice to do so is

Re: [PATCH] net: switchdev: don't abort unsupported operations

2015-07-11 Thread Scott Feldman
en Didelot Acked-by: Scott Feldman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-07 Thread Scott Feldman
On Tue, Jul 7, 2015 at 9:17 AM, Vivien Didelot wrote: > Hi Andrew, Scott, > Does this fixup http://ix.io/jxq look good to you? Yes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [PATCH v3 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-06 Thread Scott Feldman
On Mon, Jul 6, 2015 at 7:00 PM, Andrew Lunn wrote: > On Tue, Jul 07, 2015 at 01:38:04AM +0200, Andrew Lunn wrote: >> On Sun, Jul 05, 2015 at 10:14:50PM -0400, Vivien Didelot wrote: >> > Hi all, >> > >> > This patchset brings full support for hardware VLANs in DSA, and the >> > Marvell >> > 88E6xx

Re: [PATCH v2 2/4] net: dsa: add support for switchdev VLAN objects

2015-06-24 Thread Scott Feldman
A compatible switch chips. > > Signed-off-by: Vivien Didelot Acked-by: Scott Feldman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html P

Re: [PATCH] net: dsa: add support for switchdev VLAN objects

2015-06-23 Thread Scott Feldman
A compatible switch chips. > > Signed-off-by: Vivien Didelot I'd like to see an example driver implementation for DSA port_vlan_xxx callbacks to go along with this patch. But this patch looks good, Acked-by: Scott Feldman -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] net: switchdev: ignore unsupported bridge flags

2015-06-23 Thread Scott Feldman
ent than -EOPNOTSUPP. > > (This is a follow-up patch for 7d4f8d8.) > > Signed-off-by: Vivien Didelot Thanks for testing Vivien. Acked-by: Scott Feldman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vg

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Scott Feldman
On Tue, Jun 2, 2015 at 3:31 PM, nolan wrote: > On 06/02/2015 12:44 AM, Scott Feldman wrote: >> >> That brings up an interesting point about having multiple bridges with >> the same vlan configured. I struggled with that problem with rocker >> also and I don't hav

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Scott Feldman
On Mon, Jun 1, 2015 at 11:50 PM, Guenter Roeck wrote: [cut] > I brought this up before. No idea if my e-mail got lost or what happened. > > We use a fid per port, and a fid per bridge group. With VLANs, this is > completely > ignored, ahd there is only a single fid per vlan for the entire switch

Re: [PATCH] Net: ethernet: rocker: fixed a space coding style issue

2015-03-21 Thread Scott Feldman
On Sat, Mar 21, 2015 at 11:02 AM, Andrei Maresu wrote: > Fixed a space coding style issue found by checkpatch.pl in rocker.c > > Signed-off-by: Andrei Maresu Signed-off-by: Scott Feldman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: [patch 2/2] rocker: silence shift wrapping warning

2015-02-25 Thread Scott Feldman
> + val |= 1ULL << rocker_port->lport; > else > - val &= ~(1 << rocker_port->lport); > + val &= ~(1ULL << rocker_port->lport); > rocker_write64(rocker_port->rocker, PORT_PHYS_ENABLE,

Re: [PATCH net-next 1/7] r8152: adjust rx_bottom

2015-01-26 Thread Scott Feldman
On Mon, Jan 19, 2015 at 6:48 PM, Hayes Wang wrote: > David Miller [mailto:da...@davemloft.net] >> Sent: Tuesday, January 20, 2015 5:14 AM > [...] >> >> - r8152_submit_rx(tp, agg, GFP_ATOMIC); >> >> + if (!ret) { >> >> + ret = r8152_submit_rx(tp, a

Re: [PATCH net-next 1/7] r8152: adjust rx_bottom

2015-01-19 Thread Scott Feldman
On Sun, Jan 18, 2015 at 11:13 PM, Hayes Wang wrote: > If a error occurs when submitting rx, skip the remaining submissions > and try to submit them again next time. > > Signed-off-by: Hayes Wang > --- > drivers/net/usb/r8152.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions

Re: Sending IP datagrams

2005-03-07 Thread Scott Feldman
On Mar 7, 2005, at 4:53 PM, Josef E. Galea wrote: AFAIK that module uses socket buffers (struct sk_buff) to send the packets. I was asking whether there was another way to send the IP datagrams. Well the network device driver wants a sk_buff (hard_start_xmit) so you'd need to modify the network

Re: Sending IP datagrams

2005-03-07 Thread Scott Feldman
On Mar 7, 2005, at 3:48 PM, Josef E. Galea wrote: Hi, Is there any way, other than socket buffers, to send IP datagrams from a kernel module? If yes, can you please point me to some good tutorial or sample code See net/core/pktgen.c for an example. -scott - To unsubscribe from this list: send the

Re: slab corruption in skb allocs

2005-03-06 Thread Scott Feldman
On Mar 6, 2005, at 10:40 AM, Richard Fuchs wrote: Scott Feldman wrote: A bug in the driver. I have a hunch: please try this patch with 2.6.9 or higher: http://marc.theaimsgroup.com/?l=linux-netdev&m=110726809431611&w=2 bingo, that fixes it. too bad neither this patch nor the removal of

Re: slab corruption in skb allocs

2005-03-06 Thread Scott Feldman
On Mar 5, 2005, at 11:10 AM, Richard Fuchs wrote: Scott Feldman wrote: Was NAPI turned on for e100 in 2.6.7? If not, turn NAPI on in the 2.6.7 driver and see if you get the same result. If you do, it's very likely the bug is in the e100 driver's NAPI implementation. looks like you

Re: slab corruption in skb allocs

2005-03-05 Thread Scott Feldman
On Mar 4, 2005, at 4:23 AM, Richard Fuchs wrote: kernel 2.6.7 doesn't show this behavior, while all kernels from 2.6.9 and up do. (i didn't test 2.6.8.x). Was NAPI turned on for e100 in 2.6.7? If not, turn NAPI on in the 2.6.7 driver and see if you get the same result. If you do, it's very lik

Re: [ANN] removal of certain net drivers coming soon: eepro100,?xircom_tulip_cb, iph5526

2005-02-01 Thread Scott Feldman
On Tue, 2005-02-01 at 11:09, linux-os wrote: > You just need to load mii first. Both of these drivers are working > fine on 2.6.10. Huh? You have 82556 cards working with eepro100 or e100 on 2.6.10? Neither driver will work on any card without mii loaded. -scott - To unsubscribe from this list

Re: [ANN] removal of certain net drivers coming soon: eepro100,?xircom_tulip_cb, iph5526

2005-02-01 Thread Scott Feldman
On Tue, 2005-02-01 at 04:48, Meelis Roos wrote: > > See if eepro100 works on your 82556 cards. I would be surprised if it > > does. If it does, maybe it's not that much trouble to add support to > > e100. Let us know. > > I did add the PCI ID to e100 to to try it with both drivers. > > In shor

Re: 2.4.29, e100 and a WOL packet causes keventd going mad

2005-01-30 Thread Scott Feldman
On Sun, 2005-01-30 at 19:58, Nigel Cunningham wrote: > Do you also disable the WOL event when resuming? Good catch. How's this look? --- linux-2.6.11-rc2/drivers/net/e100.c.orig2005-01-30 19:13:56.850497376 -0800 +++ linux-2.6.11-rc2/drivers/net/e100.c 2005-01-30 20:53:22.630560952 -0800 @@

Re: 2.4.29, e100 and a WOL packet causes keventd going mad

2005-01-30 Thread Scott Feldman
On Sun, 2005-01-30 at 09:18, David HÃrdeman wrote: > I experience the same problems as reported by Michael Gernoth when > sending a WOL-packet to computer with a e100 NIC which is already > powered on. I didn't look at the 2.4 case, but for 2.6, it seems e100 was enabling PME wakeup during probe

Re: [ANN] removal of certain net drivers coming soon: eepro100,?xircom_tulip_cb, iph5526

2005-01-28 Thread Scott Feldman
On Fri, 2005-01-28 at 01:33, Meelis Roos wrote: > eepro100 also drives 82556-based cards. I have a couple of EtherExpress > PRO/100 Smart cards, Intel identifier is PILA8485, PCI ID is 8086:1228. > e100 doesn't support them, I'm told eepro100 works (I have not verified > it myself). I can probably

Re: [ANN] removal of certain net drivers coming soon: eepro100, xircom_tulip_cb, iph5526

2005-01-27 Thread Scott Feldman
On Thu, 2005-01-27 at 16:48, David S. Miller wrote: > On Fri, 28 Jan 2005 00:14:30 + > Russell King <[EMAIL PROTECTED]> wrote: > > > The fact of the matter is that eepro100.c works on ARM, e100.c doesn't. > > There's a message from me back on 30th June 2004 at about 10:30 BST on > > this very