Re: Re: [PATCH 0/9] added helper macros to remove duplicate code from probe functions of the platform drivers

On Wed, Sep 18, 2019 at 3:57 PM, Vinod Koul wrote: > On 15-09-19, 12:30, Satendra Singh Thakur wrote: > > 1. For most of the platform drivers's probe include following steps > > > > -memory allocation for driver's private structure > > -getting io

[PATCH 8/9] probe/dma/axi: removed redundant code from axi dma controller's probe function

in previous patch [01/09]. Signed-off-by: Satendra Singh Thakur Signed-off-by: Satendra Singh Thakur --- drivers/dma/dma-axi-dmac.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index

[PATCH 9/9] probe/dma/owl: removed redundant code from owl dma controller's probe function

[01/09]. Signed-off-by: Satendra Singh Thakur Signed-off-by: Satendra Singh Thakur --- drivers/dma/owl-dma.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c index 90bbcef99ef8..03e692fc25a1 100644

[PATCH 7/9] probe/dma/sun4i: removed redundant code from sun4i dma controller's probe function

[01/09]. Signed-off-by: Satendra Singh Thakur Signed-off-by: Satendra Singh Thakur --- drivers/dma/sun4i-dma.c | 30 +- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c index 1f80568b2613..5db139ff43ac

[PATCH 6/9] probe/dma/sun6i: removed redundant code from sun6i dma controller's probe function

[01/09]. Signed-off-by: Satendra Singh Thakur Signed-off-by: Satendra Singh Thakur --- drivers/dma/sun6i-dma.c | 30 +- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c index ed5b68dcfe50..41ee054bbeeb

[PATCH 5/9] probe/dma/mtk-hs: removed redundant code from mediatek hs dma controller's probe function

. 3. This patch depends on the file include/linux/probe-helper.h which is pushed in previous patch [01/09]. Signed-off-by: Satendra Singh Thakur Signed-off-by: Satendra Singh Thakur --- drivers/dma/mediatek/mtk-hsdma.c | 38 ++-- 1 file changed, 12 insertions(+), 26

[PATCH 4/9] probe/dma/qcom-bam: removed redundant code from qcom bam dma controller's probe function

. 3. This patch depends on the file include/linux/probe-helper.h which is pushed in previous patch [01/09]. Signed-off-by: Satendra Singh Thakur Signed-off-by: Satendra Singh Thakur --- drivers/dma/qcom/bam_dma.c | 71 -- 1 file changed, 29 insertions(+), 42

[PATCH 3/9] probe/dma/zx: removed redundant code from zx dma controller's probe function

already used in probe function. 3. This patch depends on the file include/linux/probe-helper.h which is pushed in previous patch [01/09]. Signed-off-by: Satendra Singh Thakur Signed-off-by: Satendra Singh Thakur --- drivers/dma/zx_dma.c | 35 ++- 1 file changed, 10

[PATCH 2/9] probe/dma/jz4740: removed redundant code from jz4740 dma controller's probe function

remove method. 3. This patch depends on the file include/linux/probe-helper.h which is pushed in previous patch [01/09]. Signed-off-by: Satendra Singh Thakur Signed-off-by: Satendra Singh Thakur --- drivers/dma/dma-jz4740.c | 33 + 1 file changed, 13 insertions

[PATCH 1/9] probe/dma : added helper macros to remove redundant/duplicate code from probe functions of the dma controller drivers

be functions of different drivers. Signed-off-by: Satendra Singh Thakur Signed-off-by: Satendra Singh Thakur --- include/linux/probe-helper.h | 179 +++ 1 file changed, 179 insertions(+) create mode 100644 include/linux/probe-helper.h diff --git a/include/linux/p

[PATCH 0/9] added helper macros to remove duplicate code from probe functions of the platform drivers

de devres compatible (wherever required) The functions: clk_get, request_irq, kzalloc, platform_get_resource are replaced with their devm_* counterparts. 4. Few bugs are also fixed. Satendra Singh Thakur (9): probe/dma : added helper macros to remove redundant/duplicate code from probe

Re: [PATCH v1] [semaphore] Removed redundant code from semaphore's down family of function

On Mon, 26 Aug 2019 16:25:57 +0200, Peter Zijlstra wrote: >On Mon, Aug 26, 2019 at 04:14:36PM +0200, Peter Zijlstra wrote: > > (XXX, we should probably move the schedule_timeout() thing into its own > > patch) > > A better version here... > > --- > Subject: sched,time: Allow better constprop/DCE fo

Re: [PATCH v1] [semaphore] Removed redundant code from semaphore's down family of function

On Thu, 22 Aug 2019 17:51:12 +0200, Peter Zijlstra wrote: > On Mon, Aug 12, 2019 at 07:18:59PM +0530, Satendra Singh Thakur wrote: > > -The semaphore code has four funcs > > down, > > down_interruptible, > > down_killable, > > down_timeout > > -These four fun

[PATCH v1] [semaphore] Removed redundant code from semaphore's down family of function

, down_killable calls noinline __down_common directly through a macro -The funcs __down_interruptible, __down_killable etc have been removed as they were just wrapper to __down_common Signed-off-by: Satendra Singh Thakur --- v1: removed disclaimer appended automatically by company mail policy

[PATCH] [semaphore] Removed redundant code from semaphore's down family of function

, down_killable calls noinline __down_common directly through a macro -The funcs __down_interruptible, __down_killable etc have been removed as they were just wrapper to __down_common Signed-off-by: Satendra Singh Thakur --- kernel/locking/semaphore.c | 107 + 1

[PATCH] [ASoC][soc-dapm] : memory leak in the func snd_soc_dapm_new_dai

In the func snd_soc_dapm_new_dai, if the inner func snd_soc_dapm_alloc_kcontrol fails, there will be memory leak. The label param_fail wont free memory which is allocated by the func devm_kcalloc. Hence new label is created for this purpose. Signed-off-by: Satendra Singh Thakur --- sound/soc

[PATCH v1] drm/kms/crtc: Improving the func drm_mode_setcrtc

. If mode_valid is clear, mode and fb will be NULL. Therefore, we just check mode_valid and NOT mode or fb. 4. Moved kfree inside if statement Signed-off-by: Satendra Singh Thakur --- v1: Hi Mr Maarten, Thanks for the comments. I have fixed some of them and done more modifications to th

Re: [PATCH 00/13] drm/kms/mode: using helper func drm_display_mode_to/from_videomode for calculating timing parameters

On Thu, May 08, 2018 at 16:28:30 +0530, Satendra Singh Thakur wrote: > On Thu, May 07, 2018 at 15:46:02 +0200, Daniel Vetter wrote: > > On Thu, May 03, 2018 at 01:53:55PM +0530, Satendra Singh Thakur wrote: > > > 1.There is a function in drm-core to calculate display

Re: [PATCH 00/13] drm/kms/mode: using helper func drm_display_mode_to/from_videomode for calculating timing parameters

On Thu, May 07, 2018 at 15:46:02 +0200, Daniel Vetter wrote: > On Thu, May 03, 2018 at 01:53:55PM +0530, Satendra Singh Thakur wrote: > > 1.There is a function in drm-core to calculate display timing parameters: > > horizontal front porch, back porch, sync length, > > verti

[PATCH v1 04/13] drm/kms/mode/fsl-dcu: using helper func drm_display_mode_to_videomode for calculating timing parameters

-Using drm_display_mode_to_videomode to avoid duplicate logic -Removed index = drm_crtc_index(crtc) as it is unused -Replaced DRM_MODE_FLAG_* flags with DISPLAY_FLAGS_* flags -Replaced mode->h/vdisplay with vm.h/vactive Acked-by: Stefan Agner Signed-off-by: Satendra Singh Thakur Cc: Mad

[PATCH v2 03/13] drm/kms/mode/exynos-dsi: using helper func drm_display_mode_to_videomode for calculating timing parameters

To avoid duplicate logic for the same Signed-off-by: Satendra Singh Thakur Acked-by: Madhur Verma Cc: Hemanshu Srivastava --- v2: Removed Mr Robin from reviewed-by field drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff

[PATCH v2] drm/kms/mode: added a new helper for calculating videomode from crtc's display mode

drivers will be using this new helper -arm hdlcd -atmel hlcdc -exynos 5433 decon -exynos7 decon -exynos fimd 4. -This change reduces several redundant lines of code for many drivers Acked-by: Liviu Dudau Signed-off-by: Satendra Singh Thakur Acked-by: Madhur Verma Cc: Hemanshu Srivastava

Re: [PATCH v1] drm/kms/mode: added a new helper for calculating videomode from crtc's display mode

On Thu, May 03, 2018 at 11:36:39 +0100, Liviu Dudau wrote: > On Thu, May 03, 2018 at 11:28:37AM +0530, Satendra Singh Thakur wrote: > > 1. > > -Added a new helper drm_display_mode_crtc_to_videomode > > -This helper calculates mode parameters like > > horizontal fr

[PATCH v1 09/13] drm/kms/mode/sun4i-tv: using helper func drm_display_mode_from_videomode for calculating timing parameters

To avoid duplicate logic for horizonal/vertical sync_start/end helper func drm_display_mode_from_videomode is used Acked-by: Maxime Ripard Signed-off-by: Satendra Singh Thakur Acked-by: Madhur Verma Cc: Hemanshu Srivastava --- v1: Added acked-by fields drivers/gpu/drm/sun4i/sun4i_tv.c

[PATCH v1 03/13] drm/kms/mode/exynos-dsi: using helper func drm_display_mode_to_videomode for calculating timing parameters

To avoid duplicate logic for the same Reviewed-by: Robin Murphy Signed-off-by: Satendra Singh Thakur Acked-by: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v1] drm/kms/mode: added a new helper for calculating videomode from crtc's display mode

drivers will be using this new helper -arm hdlcd -atmel hlcdc -exynos 5433 decon -exynos7 decon -exynos fimd 4. -This change reduces several redundant lines of code for many drivers Reviewed-by: Jani Nikula Acked-by: Liviu Dudau Signed-off-by: Satendra Singh Thakur Acked-by: Madhur Verma Cc

[PATCH 13/13] drm/kms/mode/bridge-adv7533: using helper func drm_display_mode_to_videomode for calculating timing parameters

. Therefore, there is a duplication of the code. This patch series replaces this redundant code with the function drm_display_mode_to_videomode. This removes nearly 100 redundant lines from the related drivers. Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava

[PATCH 12/13] drm/kms/mode/mtk_dpi_dsi: using helper func drm_display_mode_to_videomode for calculating timing parameters

-Duplicate logic for the timing params is avoided -Arithmatic operator *,/ are replaced by logical >>, << operators -The flags DRM_MODE_FLAG_* are replaced with DISPLAY_FLAGS_* flags Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/

[PATCH 11/13] drm/kms/mode/tegra: using helper func drm_display_mode_to_videomode for calculating timing parameters

To avoid duplicate logic for the same Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/drm/tegra/dc.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index

[PATCH 10/13] drm/kms/mode/ti-lcdc: using helper func drm_display_mode_to_videomode for calculating timing parameters

To avoid duplicate logic for the same Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 60 1 file changed, 27 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/tilcdc

[PATCH 09/13] drm/kms/mode/sun4i-tv: using helper func drm_display_mode_from_videomode for calculating timing parameters

To avoid duplicate logic for horizonal/vertical sync_start/end helper func drm_display_mode_from_videomode is used Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/drm/sun4i/sun4i_tv.c | 67 +++- 1 file changed

[PATCH 08/13] drm/kms/mode/pl111-display: using helper function drm_display_mode_to_videomode for calculating timing parameters

To avoid duplicate logic for the same Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/drm/pl111/pl111_display.c | 40 +-- 1 file changed, 15 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/pl111

[PATCH 07/13] drm/kms/mode/meson-encoder: using helper function drm_display_mode_to_videomode for calculating timing parameters

-Duplicate logic for the timing params is avoided -Arithmatic operator *,/ are replaced by logical >>, << operators -The flags DRM_MODE_FLAG_* are replaced with DISPLAY_FLAGS_* flags -Combined similar if statements Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemansh

[PATCH 06/13] drm/kms/mode/hisilicon-kirin-dsi-ade: using helper function drm_display_mode_to_videomode for calculating timing parameters

-Avoidded duplicate logic for the timing calculations -Removed func ade_set_pix_clk and combined it with func ade_ldi_set_mode Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c| 42 ++-- drivers

[PATCH 05/13] drm/kms/mode/gma500-mdfld_dsi_dpi: using helper function drm_display_mode_to_videomode for calculating timing parameters

To avoid duplicate logic for the same Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/drm/gma500/mdfld_dsi_dpi.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/gma500

[PATCH 04/13] drm/kms/mode/fsl-dcu: using helper func drm_display_mode_to_videomode for calculating timing parameters

To avoid duplicate logic for the same Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 29 - 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/fsl-dcu

[PATCH 03/13] drm/kms/mode/exynos-dsi: using helper func drm_display_mode_to_videomode for calculating timing parameters

To avoid duplicate logic for the same Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu

[PATCH 02/13] drm/kms/mode/bridge-tc358767: using helper func drm_display_mode_to_videomode for calculating timing parameters

To avoid duplicate logic for timing parameters Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/drm/bridge/tc358767.c | 42 ++- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 01/13] drm/kms/mode/atmel-hlcdc: using helper func drm_display_mode_to_videomode for calculating timing parameters

. Therefore, there is a duplication of the code. This patch series replaces this redundant code with the function drm_display_mode_to_videomode. This removes nearly 100 redundant lines from the related drivers. Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava

[PATCH 00/13] drm/kms/mode: using helper func drm_display_mode_to/from_videomode for calculating timing parameters

ncoder pl111-display sun4i-tv ti lcdc tegra dc mediatek dpi dsi bridge-adv7533 Satendra Singh Thakur (13): drm/kms/mode/atmel-hlcdc: using helper func drm_display_mode_to_videomode for calculating timing parameters drm/kms/mode/bridge-tc358767: using helper func drm_display_mode_to_v

[PATCH] drm/kms/mode: added a new helper for calculating videomode from crtc's display mode

drivers will be using this new helper -arm hdlcd -atmel hlcdc -exynos 5433 decon -exynos7 decon -exynos fimd 4. -This patch removes related duplicate code from above mentioned drivers Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/drm/arm

[PATCH] drm/atomic: Handling the case when setting old crtc for plane

. Ideally, we should do nothing in this case, this patch handles the same, and causes the program to return without doing anything in such scenario. Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma Cc: Hemanshu Srivastava --- drivers/gpu/drm/drm_atomic.c | 4 +++- 1 file changed, 3

[PATCH] [VB2-CORE] Fixed bug about unnecessary calls to queue cancel and free

h case, *count is non-zero, q->num_buffers is zero and q->memory is 0 which is not equal to memory field *count=N, q->num_buffers=0, q->memory != memory Signed-off-by: Satendra Singh Thakur --- drivers/media/v4l2-core/videobuf2-core.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH v1] media: videobuf2: Add new uAPI for DVB streaming I/O

l patch=> --https://patchwork.linuxtv.org/patch/31613/ Signed-off-by: Junghak Sung Signed-off-by: Geunyoung Kim Acked-by: Seung-Woo Kim Acked-by: Inki Dae Signed-off-by: Satendra Singh Thakur --- drivers/media/dvb-core/Makefile | 2 +- drivers/media/dvb-core/dmxdev.c | 194 +

[PATCH v5 2/2] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

rrent versions FE_SET_PROPERTY Signed-off-by: Satendra Singh Thakur --- Documentation/media/uapi/dvb/fe-get-property.rst | 24 +++-- drivers/media/dvb-core/dvb_frontend.c| 33 +++- include/uapi/linux/dvb/frontend.h| 24 + 3

[PATCH v5] [DVB][FRONTEND] Modified the code related to FE_SET_PROPERTY ioctl

properties. Signed-off-by: Satendra Singh Thakur --- drivers/media/dvb-core/dvb_frontend.c | 135 ++ 1 file changed, 73 insertions(+), 62 deletions(-) diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c index 2fcba16..013476e

[PATCH v4] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

0 err and warnings Please review it. Thanks for the patience. Signed-off-by: Satendra Singh Thakur --- Documentation/media/uapi/dvb/fe-get-property.rst | 24 ++- drivers/media/dvb-core/dvb_frontend.c| 191 ++- include/uapi/linux/dvb/frontend.h

[PATCH v3] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

Hello Mr Chehab, Thanks for the review. I have modified the code and documentation as per your comments. Please let me know if this patch is ready for merging. Signed-off-by: Satendra Singh Thakur --- Documentation/media/uapi/dvb/fe-get-property.rst | 24 ++- drivers/media/dvb-core

[PATCH v2] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

Hello Mr Chehab, Thanks for the comments. I have modified dtv_property_process_set and also added documentation. Please let me know if any further modifications required. Signed-off-by: Satendra Singh Thakur --- .../media/uapi/dvb/fe-set-property-short.rst | 60 + Documentation

[PATCH v1] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

Hello Mr Chehab, Thanks for reviewing the patch. I have modified the patch as per your comments. Please check if it looks fine now. Signed-off-by: Satendra Singh Thakur --- drivers/media/dvb-core/dvb_frontend.c | 212 +- include/uapi/linux/dvb/frontend.h

[RFC] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

a/usb/dvb-usb/friio-fe.c -Moreover, stv0288 driver implemments blank function for set_property. -If needed in future, we can define a new ops.set_property_short method to support struct dtv_property_short. Signed-off-by: Satendra Singh Thakur --- drivers/media/dvb-core/dvb_frontend.c

[RFC v2] [ALSA][CONTROL] 1. Added 2 ioctls for reading/writing values of multiple controls in one go (at once) 2. Restructured the code for read/write of a single control

From: satendra singh thakur 1.Added 2 ioctls in alsa driver's control interface -Added an ioctl to read values of multiple elements at once -Added an ioctl to write values of multiple elements at once -In the absence of above ioctls user needs to call N ioctls to read/write value of N ele

[RFC] [ALSA][CONTROL] Restructured the code for read/write of a single control

From: satendra singh thakur -Restructured/Combined two functions snd_ctl_elem_read_user and snd_ctl_elem_write_user into a single function snd_ctl_elem_rw_user -These functions were having most of the code which was similar to each other -Thus, there was redundant/duplicate code which was

[RFC] [ALSA][CONTROL] Added 2 ioctls for reading/writing values of multiple controls in one go (at once)

From: satendra singh thakur -Added 2 ioctls in alsa driver's control interface -Added an ioctl to read values of multiple elements at once -Added an ioctl to write values of multiple elements at once -In the absence of above ioctls user needs to call N ioctls to read/write value of N ele

[RFC] [GPU][DRM][PROPERTY] -Added a new ioctl in Linux DRM KMS driver.

From: satendra singh thakur -Added a new ioctl in Linux DRM KMS driver. This ioctl allows user to set the values of an object’s multiple properties in one go. -In the absence of such ioctl, User would be calling one ioctl to set each property value; Thus, user needs to call N ioctls to set