Re: [PATCH] Documentation: fix a typo in watchdog-api.txt

On 07/30/2014 01:47 AM, Randy Dunlap wrote: On 07/29/14 01:04, Sangjung Woo wrote: Signed-off-by: Sangjung Woo --- Documentation/watchdog/watchdog-api.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/watchdog/watchdog-api.txt b/Documentation

[PATCH v2] Documentation: fix two typos in watchdog-api.txt

This patch changes 'go of' to 'go off' and 'pretimout' to 'pretimeout'. Signed-off-by: Sangjung Woo Reviewed-by: Guenter Roeck --- Documentation/watchdog/watchdog-api.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Do

[PATCH] Documentation: fix a typo in watchdog-api.txt

Signed-off-by: Sangjung Woo --- Documentation/watchdog/watchdog-api.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/watchdog/watchdog-api.txt b/Documentation/watchdog/watchdog-api.txt index eb7132e..53c49a4 100644 --- a/Documentation/watchdog/watchdog

[PATCHv4 2/8] extcon: adc-jack: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-adc-jack.c | 30 +- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c index e23f1c2..549d820 100644 --- a/drivers/extcon/extcon-adc-jack.c +++ b/drivers

[PATCHv4 3/8] extcon: gpio: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-gpio.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c index 13d5222..43af34c 100644 --- a/drivers/extcon/extcon-gpio.c +++ b/drivers/extcon/extcon-gpio.c

[PATCHv4 1/8] extcon: Add resource-managed extcon register function

Add resource-managed extcon device register function for convenience. For example, if a extcon device is attached with new devm_extcon_dev_register(), that extcon device is automatically unregistered on driver detach. Signed-off-by: Sangjung Woo --- drivers/extcon/extcon-class.c | 64

[PATCHv4 6/8] extcon: max8997: Use devm_extcon_dev_register()

: Sangjung Woo Reviewed-by: Krzysztof Kozlowski --- drivers/extcon/extcon-max8997.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c index 223e6b0..804a446 100644 --- a/drivers/extcon/extcon-max8997.c +++ b

[PATCHv4 7/8] extcon: palmas: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-palmas.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 51db5bc..1a770e0 100644 --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-palmas.c

[PATCHv4 4/8] extcon: max14577: Use devm_extcon_dev_register()

: Sangjung Woo Reviewed-by: Krzysztof Kozlowski --- drivers/extcon/extcon-max14577.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c index 1fef08d..c6166e7 100644 --- a/drivers/extcon/extcon-max14577.c

[PATCHv4 8/8] extcon: arizona: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-arizona.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 98a14f6..f63fa6f 100644 --- a/drivers/extcon/extcon-arizona.c +++ b/drivers/extcon/extcon

[PATCHv4 0/8] Resource-managed extcon device register function

ed by Chanwoo * fix the bug reported by Seung-Woo * add the credit for reviewers v1: * initial version Sangjung Woo (8): extcon: Add resource-managed extcon register function extcon: adc-jack: Use devm_extcon_dev_register() extcon: gpio: Use devm_extcon_dev_register() extcon: max14577

[PATCHv4 5/8] extcon: max77693: Use devm_extcon_dev_register()

: Sangjung Woo Reviewed-by: Krzysztof Kozlowski --- drivers/extcon/extcon-max77693.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c index 39cd095..f0f18e2 100644 --- a/drivers/extcon/extcon-max77693.c

Re: [PATCHv3 1/8] extcon: Add resource-managed extcon register function

Hi Chanwoo. Thanks for your comments. I also add my opinion too. On 04/19/2014 04:13 PM, Chanwoo Choi wrote: Hi Sangjung, On Fri, Apr 18, 2014 at 9:32 AM, Sangjung Woo wrote: Add resource-managed extcon device register function for convenience. For example, if a extcon device is attached

[PATCHv3 3/8] extcon: gpio: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-gpio.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c index 13d5222..43af34c 100644 --- a/drivers/extcon/extcon-gpio.c +++ b/drivers/extcon/extcon-gpio.c

[PATCHv3 4/8] extcon: max14577: Use devm_extcon_dev_register()

: Sangjung Woo Reviewed-by: Krzysztof Kozlowski --- drivers/extcon/extcon-max14577.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c index 1fef08d..c6166e7 100644 --- a/drivers/extcon/extcon-max14577.c

[PATCHv3 6/8] extcon: max8997: Use devm_extcon_dev_register()

: Sangjung Woo Reviewed-by: Krzysztof Kozlowski --- drivers/extcon/extcon-max8997.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c index 223e6b0..804a446 100644 --- a/drivers/extcon/extcon-max8997.c +++ b

[PATCHv3 5/8] extcon: max77693: Use devm_extcon_dev_register()

: Sangjung Woo Reviewed-by: Krzysztof Kozlowski --- drivers/extcon/extcon-max77693.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c index 39cd095..f0f18e2 100644 --- a/drivers/extcon/extcon-max77693.c

[PATCHv3 0/8] Resource-managed extcon device register function

moved. Changelog: v3: * send the right version instead of previous v1 * add the credit for reviewers according to the review rules v2: * modify and clean up all unnecessary code reported by Chanwoo * fix the bug reported by Seung-Woo * add the credit for reviewers v1: * initial version Sangjung W

[PATCHv3 1/8] extcon: Add resource-managed extcon register function

Add resource-managed extcon device register function for convenience. For example, if a extcon device is attached with new devm_extcon_dev_register(), that extcon device is automatically unregistered on driver detach. Signed-off-by: Sangjung Woo --- drivers/extcon/extcon-class.c | 72

[PATCHv3 7/8] extcon: palmas: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-palmas.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 51db5bc..1a770e0 100644 --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-palmas.c

[PATCHv3 8/8] extcon: arizona: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-arizona.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 98a14f6..f63fa6f 100644 --- a/drivers/extcon/extcon-arizona.c +++ b/drivers/extcon/extcon

[PATCHv3 2/8] extcon: adc-jack: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-adc-jack.c | 30 +- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c index e23f1c2..549d820 100644 --- a/drivers/extcon/extcon-adc-jack.c +++ b/drivers

Re: [PATCHv2 1/8] extcon: Add resource-managed extcon register function

Hi Chanwoo On 04/18/2014 12:26 AM, Chanwoo Choi wrote: Hi Sangjung, This patch(v2) is same as previous patch(v1). I think you sent previous patch(v1) instead of v2. You're right. I made a big mistake. I will send the fixed one as v3. Thank you. Sangjung Thanks Chanwoo Choi On Thu

Re: [PATCHv2 8/8] extcon: arizona: Use devm_extcon_dev_register()

Hi Chanwoo. On 04/18/2014 12:29 AM, Chanwoo Choi wrote: Hi Sangjung, Seung-Woo reviewed this patch previously but, He didn't send reviewed-by message as reply. After received reviewed-by message, I think that we should add it on patch description. Frankly speaking, I didn't know

[PATCHv2 1/8] extcon: Add resource-managed extcon register function

Add resource-managed extcon device register function for convenience. For example, if a extcon device is attached with new devm_extcon_dev_register(), that extcon device is automatically unregistered on driver detach. Signed-off-by: Sangjung Woo --- drivers/extcon/extcon-class.c | 83

[PATCHv2 2/8] extcon: adc-jack: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-adc-jack.c | 30 +- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c index e23f1c2..549d820 100644 --- a/drivers/extcon/extcon-adc-jack.c +++ b/drivers

[PATCHv2 5/8] extcon: max77693: Use devm_extcon_dev_register()

: Sangjung Woo Reviewed-by: Krzysztof Kozlowski --- drivers/extcon/extcon-max77693.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c index 39cd095..f0f18e2 100644 --- a/drivers/extcon/extcon-max77693.c

[PATCHv2 8/8] extcon: arizona: Use devm_extcon_dev_register()

: Sangjung Woo Reviewed-by: Seung-Woo Kim --- drivers/extcon/extcon-arizona.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 98a14f6..40e6c0b 100644 --- a/drivers/extcon/extcon-arizona.c +++ b

[PATCHv2 4/8] extcon: max14577: Use devm_extcon_dev_register()

: Sangjung Woo Reviewed-by: Krzysztof Kozlowski --- drivers/extcon/extcon-max14577.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c index 1fef08d..c6166e7 100644 --- a/drivers/extcon/extcon-max14577.c

[PATCHv3 3/8] extcon: gpio: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-gpio.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c index 13d5222..43af34c 100644 --- a/drivers/extcon/extcon-gpio.c +++ b/drivers/extcon/extcon-gpio.c

[PATCHv2 0/8] Resource-managed extcon device register function

moved. Changelog: v2: * modify and clean up all unnecessary code reported by Chanwoo * fix the bug reported by Seung-Woo * add the credit for reviewers v1: * initial version Sangjung Woo (8): extcon: Add resource-managed extcon register function extcon: adc-jack: Use devm_extcon_dev_register() e

[PATCHv2 7/8] extcon: palmas: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-palmas.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 51db5bc..1a770e0 100644 --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-palmas.c

[PATCHv2 6/8] extcon: max8997: Use devm_extcon_dev_register()

: Sangjung Woo Reviewed-by: Krzysztof Kozlowski --- drivers/extcon/extcon-max8997.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c index 223e6b0..804a446 100644 --- a/drivers/extcon/extcon-max8997.c +++ b

Re: [PATCH 8/8] extcon: arizona: Use devm_extcon_dev_register()

To Seung-Woo. On 04/16/2014 07:44 PM, Seung-Woo Kim wrote: > Hi, > > On 2014년 04월 16일 19:27, Sangjung Woo wrote: >> Use the resource-managed extcon device register function (i.e. >> devm_extcon_dev_register()) instead of extcon_dev_register(). If extcon >> devi

[PATCH 2/8] extcon: adc-jack: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-adc-jack.c | 30 +- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c index e23f1c2..549d820 100644 --- a/drivers/extcon/extcon-adc-jack.c +++ b/drivers

[PATCH 0/8] Resource-managed extcon device register function

moved. Sangjung Woo (8): extcon: Add resource-managed extcon register function extcon: adc-jack: Use devm_extcon_dev_register() extcon: gpio: Use devm_extcon_dev_register() extcon: max14577: Use devm_extcon_dev_register() extcon: max77693: Use devm_extcon_dev_register() extcon: max8997

[PATCH 5/8] extcon: max77693: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-max77693.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c index 39cd095..f0f18e2 100644 --- a/drivers/extcon/extcon-max77693.c +++ b/drivers/extcon/extcon-max77693

[PATCH 3/8] extcon: gpio: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-gpio.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c index 13d5222..43af34c 100644 --- a/drivers/extcon/extcon-gpio.c +++ b/drivers/extcon/extcon-gpio.c

[PATCH 6/8] extcon: max8997: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-max8997.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c index 223e6b0..804a446 100644 --- a/drivers/extcon/extcon-max8997.c +++ b/drivers/extcon/extcon-max8997.c

[PATCH 8/8] extcon: arizona: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-arizona.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 98a14f6..40e6c0b 100644 --- a/drivers/extcon/extcon-arizona.c +++ b/drivers/extcon/extcon

[PATCH 7/8] extcon: palmas: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-palmas.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 51db5bc..1a770e0 100644 --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-palmas.c

[PATCH 4/8] extcon: max14577: Use devm_extcon_dev_register()

: Sangjung Woo --- drivers/extcon/extcon-max14577.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c index 1fef08d..c6166e7 100644 --- a/drivers/extcon/extcon-max14577.c +++ b/drivers/extcon/extcon

[PATCH 1/8] extcon: Add resource-managed extcon register function

Add resource-managed extcon device register function for convenience. For example, if a extcon device is attached with new devm_extcon_dev_register(), that extcon device is automatically unregistered on driver detach. Signed-off-by: Sangjung Woo --- drivers/extcon/extcon-class.c | 83

[PATCH] Documentation / CPU hotplug: Fix the typo in example code

As the notifier_block name (i.e. foobar_cpu_notifer) is different from the parameter (i.e.foobar_cpu_notifier) of register function, that is definitely error and it also makes readers confused. Signed-off-by: Sangjung Woo --- Documentation/cpu-hotplug.txt |2 +- 1 file changed, 1 insertion

[PATCH] pwm: samsung: memory leak bugfix in pwm_samsung_free

There is certainly a kind of memory leak since allocated data (i.e. chip_data) is set NULL before freeing it by calling devm_kfree(). This patch fixes the memory leak bug by modifying its call order. Signed-off-by: Sangjung Woo Reviewed-by: Jonghwa Lee --- drivers/pwm/pwm-samsung.c |2

[PATCH v2] rtc: rtc-puv3: use dev_dbg() instead of pr_debug()

Because dev_*() are used along with pr_debug() function in this code, the debug message is not tidy. This patch converts from pr_debug() to dev_dbg() since dev_*() are encouraged to use in device driver code. Signed-off-by: Sangjung Woo --- drivers/rtc/rtc-puv3.c | 22

[PATCH] rtc: rtc-puv3: use dev_dbg() instead of pr_debug()

Because dev_*() are used along with pr_debug() function in this code, the debug message is not tidy. This patch converts from pr_debug() to dev_dbg() since dev_*() are encouraged to use in device driver code. Signed-off-by: Sangjung Woo --- drivers/rtc/rtc-puv3.c | 20 ++-- 1

[PATCH v2] rtc: pl030: Use devm_kzalloc() instead of kmalloc()

In order to be free automatically and make the cleanup paths more simple, use devm_kzalloc() instead of kmalloc(). Signed-off-by: Sangjung Woo --- drivers/rtc/rtc-pl030.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc

[PATCH] rtc: pl030: Use devm_kzalloc() instead of kmalloc()

In order to be free automatically and make the cleanup paths more simple, use devm_kzalloc() instead of kzalloc(). Signed-off-by: Sangjung Woo --- drivers/rtc/rtc-pl030.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc

[PATCH] sgi-xp: fix wrong usage of dev_set_name()

The second parameter of dev_set_name() is format string. In order to avoid any potential accidents such as segmentation fault, basic format parameter "%s" should be used in this case. Signed-off-by: Sangjung Woo --- drivers/misc/sgi-xp/xpc_main.c |4 ++-- 1 file changed, 2 insert

[PATCH] staging:iio: fix wrong usage of dev_set_name()

The second parameter of dev_set_name() is format string. In order to avoid any potential accidents such as segmentation fault, basic format parameter "%s" should be used in this case. Signed-off-by: Sangjung Woo --- drivers/staging/iio/iio_dummy_evgen.c |2 +- 1 file changed, 1

[PATCH] fbdev: sh_mobile_hdmi: Use devm_kzalloc()

Use devm_kzalloc() instead of kzalloc() in order to be free automatically. This makes cleanup paths more simple. Signed-off-by: Sangjung Woo --- drivers/video/sh_mobile_hdmi.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/video/sh_mobile_hdmi.c b/drivers

[PATCH] drivers/rtc/rtc-max77686.c: Fix wrong register

Fix to read the wrong register when checking whether the RTC timer has reached or not. Signed-off-by: Sangjung Woo Signed-off-by: Myugnjoo Ham Reviewed-by: Jonghwa Lee --- drivers/rtc/rtc-max77686.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc

[PATCH] drivers/rtc/rtc-max77686.c: Fix wrong register

Fix to read the wrong register when cheching whether the RTC timer has reached or not. Signed-off-by: Sangjung Woo Signed-off-by: Myugnjoo Ham Reviewed-by: Jonghwa Lee --- drivers/rtc/rtc-max77686.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc