Re: [PATCH v3 3/4] drm_dp_mst_topology: export two functions

2021-02-04 Thread Sam McNally
On Tue, 2 Feb 2021 at 09:03, Lyude Paul wrote: > > On Wed, 2020-09-23 at 12:13 +1000, Sam McNally wrote: > > From: Hans Verkuil > > > > These are required for the CEC MST support. > > > > Signed-off-by: Hans Verkuil > > Signed-off-by: Sam McN

Re: [PATCH v3 4/4] drm_dp_cec: add MST support

2021-02-04 Thread Sam McNally
On Thu, 4 Feb 2021 at 21:42, Hans Verkuil wrote: > > On 23/09/2020 04:13, Sam McNally wrote: > > With DP v2.0 errata E5, CEC tunneling can be supported through an MST > > topology. > > > > There are some minor differences for CEC tunneling through an MST > > t

Re: [PATCH v3 2/4] drm_dp_mst_topology: use correct AUX channel

2021-02-04 Thread Sam McNally
On Thu, 4 Feb 2021 at 21:19, Hans Verkuil wrote: > > On 01/02/2021 23:13, Ville Syrjälä wrote: > > On Wed, Sep 23, 2020 at 12:13:53PM +1000, Sam McNally wrote: > >> From: Hans Verkuil > >> > >> For adapters behind an MST hub use the correct AUX channel

[PATCH v3 4/4] drm_dp_cec: add MST support

2020-09-22 Thread Sam McNally
held preclude HPD handling, are deferred to avoid remote DPCD access which would block until HPD handling is performed or a timeout Register and unregister for all MST connectors, ensuring their drm_dp_aux_cec struct won't be accessed uninitialized. Reviewed-by: Hans Verkuil Signed-off-by

[PATCH v3 2/4] drm_dp_mst_topology: use correct AUX channel

2020-09-22 Thread Sam McNally
From: Hans Verkuil For adapters behind an MST hub use the correct AUX channel. Signed-off-by: Hans Verkuil [sa...@chromium.org: rebased, removing redundant changes] Signed-off-by: Sam McNally --- (no changes since v1) drivers/gpu/drm/drm_dp_mst_topology.c | 36

[PATCH v3 3/4] drm_dp_mst_topology: export two functions

2020-09-22 Thread Sam McNally
From: Hans Verkuil These are required for the CEC MST support. Signed-off-by: Hans Verkuil Signed-off-by: Sam McNally --- (no changes since v1) drivers/gpu/drm/drm_dp_mst_topology.c | 6 ++ include/drm/drm_dp_mst_helper.h | 4 2 files changed, 6 insertions(+), 4 deletions

[PATCH v3 1/4] dp/dp_mst: Add support for sink event notify messages

2020-09-22 Thread Sam McNally
Sink event notify messages are used for MST CEC IRQs. Add parsing support for sink event notify messages in preparation for handling MST CEC IRQs. Signed-off-by: Sam McNally --- (no changes since v1) drivers/gpu/drm/drm_dp_mst_topology.c | 37 ++- include/drm

[PATCH v2] drm/dp_mst: Add ddc i2c device links for DP MST connectors

2020-09-09 Thread Sam McNally
sysfs created by drm_connector"), creating sysfs ddc links to the associated i2c device for MST DP connectors. If the connector is created and registered before the i2c device, create the link when registering the i2c device; otherwise, create the link after registering the connector. Signed-o

[PATCH v2 3/4] drm_dp_mst_topology: export two functions

2020-09-09 Thread Sam McNally
From: Hans Verkuil These are required for the CEC MST support. Signed-off-by: Hans Verkuil Signed-off-by: Sam McNally --- (no changes since v1) drivers/gpu/drm/drm_dp_mst_topology.c | 6 ++ include/drm/drm_dp_mst_helper.h | 4 2 files changed, 6 insertions(+), 4 deletions

[PATCH v2 4/4] drm_dp_cec: add MST support

2020-09-09 Thread Sam McNally
held preclude HPD handling, are deferred to avoid remote DPCD access which would block until HPD handling is performed or a timeout Register and unregister for all MST connectors, ensuring their drm_dp_aux_cec struct won't be accessed uninitialized. Signed-off-by: Sam McNally --- Changes

[PATCH v2 2/4] drm_dp_mst_topology: use correct AUX channel

2020-09-09 Thread Sam McNally
From: Hans Verkuil For adapters behind an MST hub use the correct AUX channel. Signed-off-by: Hans Verkuil [sa...@chromium.org: rebased, removing redundant changes] Signed-off-by: Sam McNally --- (no changes since v1) drivers/gpu/drm/drm_dp_mst_topology.c | 36

[PATCH v2 1/4] dp/dp_mst: Add support for sink event notify messages

2020-09-09 Thread Sam McNally
Sink event notify messages are used for MST CEC IRQs. Add parsing support for sink event notify messages in preparation for handling MST CEC IRQs. Signed-off-by: Sam McNally --- (no changes since v1) drivers/gpu/drm/drm_dp_mst_topology.c | 37 ++- include/drm

Re: [PATCH 5/5] drm_dp_cec: add the implementation of MST support

2020-09-09 Thread Sam McNally
On Tue, 8 Sep 2020 at 18:08, Hans Verkuil wrote: > > Hi Sam, > > On 01/09/2020 08:22, Sam McNally wrote: > > With DP v2.0 errata E5, CEC tunneling can be supported through an MST > > topology. > > Oh wow, this is finally supported in the spec. Very nice to see this

Re: [PATCH 4/5] drm_dp_cec: add plumbing in preparation for MST support

2020-09-09 Thread Sam McNally
On Tue, 8 Sep 2020 at 18:41, Hans Verkuil wrote: > > On 01/09/2020 08:22, Sam McNally wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > [sa...@chromium.org: > > - rebased > > - removed polling-related changes > > - moved

Re: [PATCH 4/5] drm_dp_cec: add plumbing in preparation for MST support

2020-09-09 Thread Sam McNally
On Wed, 2 Sep 2020 at 04:12, Lyude Paul wrote: > > Super minor nitpicks: > > On Tue, 2020-09-01 at 16:22 +1000, Sam McNally wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > [sa...@chromium.org: > > - rebased > > - removed p

[PATCH 5/5] drm_dp_cec: add the implementation of MST support

2020-08-31 Thread Sam McNally
held preclude HPD handling, are deferred to avoid remote DPCD access which would block until HPD handling is performed or a timeout Register and unregister for all MST connectors, ensuring their drm_dp_aux_cec struct won't be accessed uninitialized. Signed-off-by: Sam McNally --- driver

[PATCH 4/5] drm_dp_cec: add plumbing in preparation for MST support

2020-08-31 Thread Sam McNally
From: Hans Verkuil Signed-off-by: Hans Verkuil [sa...@chromium.org: - rebased - removed polling-related changes - moved the calls to drm_dp_cec_(un)set_edid() into the next patch ] Signed-off-by: Sam McNally --- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- drivers/gpu/drm

[PATCH 2/5] drm_dp_mst_topology: use correct AUX channel

2020-08-31 Thread Sam McNally
From: Hans Verkuil For adapters behind an MST hub use the correct AUX channel. Signed-off-by: Hans Verkuil [sa...@chromium.org: rebased, removing redundant changes] Signed-off-by: Sam McNally --- drivers/gpu/drm/drm_dp_mst_topology.c | 36 +++ 1 file changed, 36

[PATCH 3/5] drm_dp_mst_topology: export two functions

2020-08-31 Thread Sam McNally
From: Hans Verkuil These are required for the CEC MST support. Signed-off-by: Hans Verkuil Signed-off-by: Sam McNally --- drivers/gpu/drm/drm_dp_mst_topology.c | 6 ++ include/drm/drm_dp_mst_helper.h | 4 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 1/5] dp/dp_mst: Add support for sink event notify messages

2020-08-31 Thread Sam McNally
Sink event notify messages are used for MST CEC IRQs. Add parsing support for sink event notify messages in preparation for handling MST CEC IRQs. Signed-off-by: Sam McNally --- drivers/gpu/drm/drm_dp_mst_topology.c | 37 ++- include/drm/drm_dp_mst_helper.h | 14

Re: [PATCH] drm/dp_mst: Add ddc i2c device links for DP MST connectors

2020-08-19 Thread Sam McNally
Thanks for the feedback. On Sat, 15 Aug 2020 at 01:00, Imre Deak wrote: > > On Wed, Jul 29, 2020 at 04:15:28PM +1000, Sam McNally wrote: > > As of commit d8bd15b37d32 ("drm/dp_mst: Fix the DDC I2C device > > registration of an MST port"), DP MST DDC I2C devices are

[PATCH] drm/dp_mst: Add ddc i2c device links for DP MST connectors

2020-07-28 Thread Sam McNally
eated and registered before the i2c device, create the link when registering the i2c device; otherwise, create the link during late connector registration. Signed-off-by: Sam McNally --- drivers/gpu/drm/drm_dp_mst_topology.c | 29 +-- 1 file changed, 27 insertions(+),

[PATCH] drm/dp_mst: Support remote i2c writes

2020-07-26 Thread Sam McNally
r, so this is sufficient. For i2c transfers meeting the above criteria, generate and send a remote i2c write message for each transaction. Add the trivial remote i2c write reply parsing support so remote i2c write acks bubble up correctly. Signed-off-by: Sam McNally --- drivers/gp