On 1/16/2018 12:02 PM, srinivas.kandaga...@linaro.org wrote:
From: Srinivas Kandagatla
When BAM is remotely controlled it does not sound correct to control
its clk on Linux side. Make it optional, so that its not madatory
for remote controlled BAM instances.
Signed-off-by: Srinivas Kandagatla
-modes too frequently since
entering clock-pause is an expensive sequence
Signed-off-by: Sagar Dharia
---
drivers/slimbus/slim-qcom-ctrl.c | 128 +--
drivers/slimbus/slim-qcom.h | 1 +
2 files changed, 125 insertions(+), 4 deletions(-)
diff --git a/drive
tilize DMA operations for the
transactions without remapping every transaction buffer.
Statically allocated rings help to improve performance by avoiding
overhead of dynamically allocating transactions on need basis.
Signed-off-by: Sagar Dharia
Tested-by: Naveen Kaje
---
drivers/slimbus/Makefile
OF helper routine scans the SLIMbus DeviceTree, allocates resources,
and creates slim_devices according to the hierarchy.
Signed-off-by: Sagar Dharia
---
Documentation/devicetree/bindings/slimbus/bus.txt | 55 ++
drivers/slimbus/slim-core.c | 57
ecedure is controller-specific, framework calls it via
controller's function pointer to invoke it.
Signed-off-by: Sagar Dharia
---
drivers/slimbus/Makefile | 2 +-
drivers/slimbus/slim-core.c | 15 +
drivers/slimbus/slim-messaging.c | 50 ++--
drivers/slimbus/slim-sc
). So probe is called
if the device is added to board-info list for a controller.
Additionally device is probed when it reports present if that device
doesn't need any such steps mentioned above.
Signed-off-by: Sagar Dharia
---
Documentation/slimbus/summary | 109 +++
drivers/Kc
time it's woken up, until clock-pause
is executed by the manager device.
Signed-off-by: Sagar Dharia
---
.../devicetree/bindings/slimbus/slim-qcom-ctrl.txt | 45 ++
drivers/slimbus/Kconfig| 9 +
drivers/slimbus/Makefile | 1 +
drive
other
discoverable buses, and clarified documentation about when node
definition and compatible fields should be used.
* Clock-pause initiated by the framework when controller is being
removed to make sure there are no ongoing transfers.
Sagar Dharia (6):
SLIMbus: Device management on SLIMbus
of/sl
On 4/18/2016 3:19 AM, Mark Brown wrote:
On Fri, Apr 15, 2016 at 10:17:36AM -0600, Sagar Dharia wrote:
Please leave blank lines between paragraphs, it makes things much easier
to read than a wall of uninterrupted text.
+ ret = devm_request_irq(&pdev->dev, dev->irq, msm_slim
Hello Mark
Apologies for a late reply. I will incorporate most of your comments.
Please see inline response for 2 comments:
+ ret = devm_request_irq(&pdev->dev, dev->irq, msm_slim_interrupt,
+ IRQF_TRIGGER_HIGH, "msm_slim_irq", dev);
+ if (ret) {
+
). So probe is called
if the device is added to board-info list for a controller.
Additionally device is probed when it reports present if that device
doesn't need any such steps mentioned above.
Signed-off-by: Sagar Dharia
---
Documentation/slimbus/summary | 109 ++
drivers/Kc
ecedure is controller-specific, framework calls it via
controller's function pointer to invoke it.
Signed-off-by: Sagar Dharia
---
drivers/slimbus/Makefile | 2 +-
drivers/slimbus/slim-core.c | 13 +
drivers/slimbus/slim-messaging.c | 50 ++--
drivers/slimbus/slim-sc
tilize DMA operations for the
transactions without remapping every transaction buffer.
Statically allocated rings help to improve performance by avoiding
overhead of dynamically allocating transactions on need basis.
Signed-off-by: Sagar Dharia
Tested-by: Naveen Kaje
---
drivers/slimbus/Makefile
-modes too frequently since
entering clock-pause is an expensive sequence
Signed-off-by: Sagar Dharia
---
drivers/slimbus/slim-qcom-ctrl.c | 124 ++-
drivers/slimbus/slim-qcom.h | 1 +
2 files changed, 124 insertions(+), 1 deletion(-)
diff --git a/drive
OF helper routine scans the SLIMbus DeviceTree, allocates resources,
and creates slim_devices according to the hierarchy.
Signed-off-by: Sagar Dharia
---
Documentation/devicetree/bindings/slimbus/bus.txt | 54
drivers/slimbus/slim-core.c | 75
time it's woken up, until clock-pause
is executed by the manager device.
Signed-off-by: Sagar Dharia
---
.../devicetree/bindings/slimbus/slim-qcom-ctrl.txt | 43 ++
drivers/slimbus/Kconfig| 10 +
drivers/slimbus/Makefile | 1 +
drive
t and comments to document performance arguments in using
coherently mapped buffers for transaction buffer management.
* Tried to address clock-pause management suggestion by making sure
bus-framework votes/unvotes for runtime-PM while handling transfers.
Sagar Dharia (6):
SLIMbus: Device manageme
On 8/14/2015 12:31 PM, Mark Brown wrote:
On Mon, Aug 03, 2015 at 12:59:48AM -0600, Sagar Dharia wrote:
+/**
+ * Qualcomm slimbus controller may experience interference on the lines
+ * causing some early messages (e.g. logical-address assignment) to be
+ * NACKed. Retry after sometime
Hi Mark,
On 8/14/2015 12:39 PM, Mark Brown wrote:
On Mon, Aug 03, 2015 at 12:59:49AM -0600, Sagar Dharia wrote:
@@ -459,6 +459,8 @@ int slim_register_controller(struct slim_controller *ctrl)
mutex_init(&ctrl->m_ctrl);
spin_lock_init(&ctrl->tx.lock);
Hello Rob,
On 8/3/2015 10:13 AM, Rob Herring wrote:
On Mon, Aug 3, 2015 at 1:59 AM, Sagar Dharia wrote:
OF helper routine scans the SLIMbus DeviceTree, allocates resources,
and creates slim_devices according to the hierarchy.
Signed-off-by: Sagar Dharia
---
Documentation/devicetree
OF helper routine scans the SLIMbus DeviceTree, allocates resources,
and creates slim_devices according to the hierarchy.
Signed-off-by: Sagar Dharia
---
Documentation/devicetree/bindings/slimbus/bus.txt | 46 ++
drivers/slimbus/slim-core.c | 75
ynchronous operations, the callback will be called from atomic
context.
Signed-off-by: Sagar Dharia
Tested-by: Naveen Kaje
---
drivers/slimbus/Makefile | 2 +-
drivers/slimbus/slim-core.c | 44 +
drivers/slimbus/slim-messaging.c | 378 +++
inc
time it's woken up, until clock-pause
is executed by the manager device.
Signed-off-by: Sagar Dharia
---
.../devicetree/bindings/slimbus/slim-qcom-ctrl.txt | 42 ++
drivers/slimbus/Kconfig| 10 +
drivers/slimbus/Makefile | 1 +
drive
ecedure is controller-specific, framework calls it via
controller's function pointer to invoke it.
Signed-off-by: Sagar Dharia
---
drivers/slimbus/Makefile | 2 +-
drivers/slimbus/slim-core.c | 2 +
drivers/slimbus/slim-sched.c | 121 +++
include/
-modes too frequently since
entering clock-pause is an expensive sequence
Signed-off-by: Sagar Dharia
---
drivers/slimbus/slim-qcom-ctrl.c | 149 ++-
drivers/slimbus/slim-qcom.h | 1 +
2 files changed, 149 insertions(+), 1 deletion(-)
diff --git a/drive
). So probe is called
if the device is added to board-info list for a controller.
Additionally device is probed when it reports present if that device
doesn't need any such steps mentioned above.
Signed-off-by: Sagar Dharia
---
Documentation/slimbus/summary | 109 ++
drivers/Kc
ark's suggestion
* Changed framework to make sure synchronous transactions are waited-
for in framework itself per Mark's suggestion
* Addressed other inline comments.
Sagar Dharia (6):
SLIMbus: Device management on SLIMbus
of/slimbus: OF helper for SLIMbus
slimbus: Add messaging
On 6/17/2015 7:53 AM, Mark Brown wrote:
On Tue, Jun 16, 2015 at 07:46:02PM -0600, Sagar Dharia wrote:
+ - dmaengine, and pipes used to communicate between controller and memory if
+ sps-BAM HW is used
This needs more detail.
+*/
+ mb();
+ if
Hi Srini
Thank you for the review.
On 6/18/2015 3:23 PM, Srinivas Kandagatla wrote:
Hi Sagar,
On 14/06/15 06:49, Sagar Dharia wrote:
SLIMbus (Serial Low Power Interchip Media Bus) is a specification
developed by MIPI (Mobile Industry Processor Interface) alliance.
SLIMbus is a 2-wire
On 6/17/2015 7:16 AM, Mark Brown wrote:
On Tue, Jun 16, 2015 at 07:45:59PM -0600, Sagar Dharia wrote:
+ if (status) {
+ slim_dev->driver = NULL;
+ } else if (driver->device_up) {
+ ctrl = slim_dev->ctrl;
+ queue_work(ctrl->wq, &
On 6/17/2015 5:45 AM, Mark Brown wrote:
On Tue, Jun 16, 2015 at 09:22:31AM -0600, Sagar Dharia wrote:
On 6/15/2015 4:54 AM, Mark Brown wrote:
On Sat, Jun 13, 2015 at 11:49:16PM -0600, Sagar Dharia wrote:
+void slim_ctrl_add_boarddevs(struct slim_controller *ctrl)
+{
Why are these operations
On 6/17/2015 7:09 AM, Mark Brown wrote:
On Tue, Jun 16, 2015 at 07:46:00PM -0600, Sagar Dharia wrote:
OF helper routine scans the SLIMbus DeviceTree, allocates resources,
and creates slim_devices according to the hierarchy.
You've not CCed any of the DT maintainers on this, for a compl
OF helper routine scans the SLIMbus DeviceTree, allocates resources,
and creates slim_devices according to the hierarchy.
Signed-off-by: Sagar Dharia
---
Documentation/devicetree/bindings/slimbus/bus.txt | 34 ++
drivers/slimbus/slimbus.c | 76
ecedure is controller-specific, framework calls it via
controller's function pointer to invoke it.
Signed-off-by: Sagar Dharia
---
drivers/slimbus/slimbus.c | 109 ++
include/linux/slimbus.h | 65 +++
2 files changed, 174 inse
time it's woken up, until clock-pause
is executed by the manager device.
Signed-off-by: Sagar Dharia
---
.../devicetree/bindings/slimbus/slim-qcom-ctrl.txt | 45 ++
drivers/slimbus/Kconfig| 10 +
drivers/slimbus/Makefile | 2 +
drive
-modes too frequently since
entering clock-pause is an expensive sequence
Signed-off-by: Sagar Dharia
---
drivers/slimbus/slim-qcom-ctrl.c | 133 ++-
drivers/slimbus/slim-qcom.h | 1 +
2 files changed, 132 insertions(+), 2 deletions(-)
diff --git a/drive
ynchronous operations, the callback can be called from atomic
context.
Signed-off-by: Sagar Dharia
Tested-by: Naveen Kaje
---
drivers/slimbus/slimbus.c | 275 ++
include/linux/slimbus.h | 128 +
2 files changed, 403 insertions(+)
di
). So probe is called
if the device is added to board-info list for a controller.
Additionally device is probed when it reports present if that device
doesn't need any such steps mentioned above.
Signed-off-by: Sagar Dharia
---
drivers/Kconfig | 2 +
drivers/Mak
driver
Sagar Dharia (6):
SLIMbus: Device management on SLIMbus
of/slimbus: OF helper for SLIMbus
slimbus: Add messaging APIs to slimbus framework
slim: qcom: Add Qualcomm Slimbus controller driver
slimbus: Add support for 'clock-pause' feature
slim: qcom: Add runtime-pm support u
On 6/15/2015 4:54 AM, Mark Brown wrote:
On Sat, Jun 13, 2015 at 11:49:16PM -0600, Sagar Dharia wrote:
Thanks for the comments. I will take care of most of the comments from
you, and Joe and upload V2 shortly.
I will also include a controller driver this time.
+void slim_ctrl_add_boarddevs
ynchronous operations, the callback can be called from atomic
context.
Signed-off-by: Sagar Dharia
Tested-by: Naveen Kaje
---
drivers/slimbus/slimbus.c | 273 ++
include/linux/slimbus.h | 124 +
2 files changed, 397 insertions(+)
di
OF helper routine scans the SLIMbus DeviceTree, allocates resources,
and creates slim_devices according to the hierarchy.
Signed-off-by: Sagar Dharia
---
drivers/slimbus/slimbus.c | 77 +++
include/linux/slimbus.h | 19
2 files changed
mentioned above.
Sagar Dharia (3):
SLIMbus: Device management on SLIMbus
of/slimbus: OF helper for SLIMbus
slimbus: Add messaging APIs to slimbus framework
drivers/Kconfig |2 +
drivers/Makefile|1 +
drivers/slimbus/Kconfig |9 +
drivers
). So probe is called
if the device is added to board-info list for a controller.
Additionally device is probed when it reports present if that device
doesn't need any such steps mentioned above.
Signed-off-by: Sagar Dharia
---
drivers/Kconfig | 2 +
drivers/Mak
44 matches
Mail list logo
