Re: [PATCH 2/2] usb: pci-quirks: Minor cleanup for AMD PLL quirk

On Fri, Jul 5, 2019 at 3:10 PM Alan Stern wrote: > > On Thu, 4 Jul 2019, Ryan Kennedy wrote: > > > usb_amd_find_chipset_info() is used for chipset detection for > > several quirks. It is strange that its return value indicates > > the need for the PLL quirk, whic

Re: [PATCH 1/2] usb: pci-quirks: Correct AMD PLL quirk detection

On Fri, Jul 5, 2019 at 1:22 AM Greg KH wrote: > > On Thu, Jul 04, 2019 at 11:35:28AM -0400, Ryan Kennedy wrote: > > The AMD PLL USB quirk is incorrectly enabled on newer Ryzen > > chipsets. The logic in usb_amd_find_chipset_info currently checks > > for unaffected chips

[PATCH 2/2] usb: pci-quirks: Minor cleanup for AMD PLL quirk

probe_result to something more appropriate. Signed-off-by: Ryan Kennedy --- drivers/usb/host/ehci-pci.c | 4 ++-- drivers/usb/host/ohci-pci.c | 2 +- drivers/usb/host/pci-quirks.c | 30 -- drivers/usb/host/pci-quirks.h | 2 +- drivers/usb/host/xhci-pci.c | 2

[PATCH 1/2] usb: pci-quirks: Correct AMD PLL quirk detection

to be updated as new chipsets are added. Note that the core of the workaround in usb_amd_quirk_pll does correctly check the chipset. Signed-off-by: Ryan Kennedy --- drivers/usb/host/pci-quirks.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/dr

[PATCH 0/2] usb: pci-quirks: AMD PLL quirk fix

This series contains a minor fix for the AMD PLL USB quirk plus some clean up to the related code. Ryan Kennedy (2): usb: pci-quirks: Correct AMD PLL quirk detection usb: pci-quirks: Minor cleanup for AMD PLL quirk drivers/usb/host/ehci-pci.c | 4 ++-- drivers/usb/host/ohci-pci.c | 2