Re: [PATCH v9 1/2] Add a "nosymfollow" mount option.

2020-09-09 Thread Ross Zwisler
On Thu, Aug 27, 2020 at 2:25 PM Ross Zwisler wrote: > On Thu, Aug 27, 2020 at 09:10:15PM +0100, Al Viro wrote: > > On Thu, Aug 27, 2020 at 09:08:01PM +0100, Al Viro wrote: > > Applied (to -rc1) and pushed > > Many thanks! (apologies for the resend, the previous one had HTM

Re: [PATCH v9 1/2] Add a "nosymfollow" mount option.

2020-08-27 Thread Ross Zwisler
On Thu, Aug 27, 2020 at 09:10:15PM +0100, Al Viro wrote: > On Thu, Aug 27, 2020 at 09:08:01PM +0100, Al Viro wrote: > > AFAICS, it applies clean to -rc1; what was the rebase about? Oh, sorry if that was confusing, I just wanted to make sure that it still applied cleanly to the latest -rc so that

[PATCH v9 2/2] selftests: mount: add nosymfollow tests

2020-08-27 Thread Ross Zwisler
are mounted with the 'nosymfollow' option. Signed-off-by: Ross Zwisler --- tools/testing/selftests/mount/.gitignore | 1 + tools/testing/selftests/mount/Makefile| 4 +- .../selftests/mount/nosymfollow-test.c| 218 ++ .../selftests/mount/r

[PATCH v9 1/2] Add a "nosymfollow" mount option.

2020-08-27 Thread Ross Zwisler
s/hardening-against-malicious-stateful-data#TOC-Restricting-symlink-traversal Signed-off-by: Mattias Nissler Signed-off-by: Ross Zwisler Reviewed-by: Aleksa Sarai --- Changes since v8 [1]: * Look for MNT_NOSYMFOLLOW in link->mnt->mnt_flags so we are testing the link itself rather than t

Re: [PATCH v8 1/2] Add a "nosymfollow" mount option.

2020-08-27 Thread Ross Zwisler
On Fri, Aug 28, 2020 at 01:41:39AM +1000, Aleksa Sarai wrote: > On 2020-08-27, Al Viro wrote: > > On Wed, Aug 26, 2020 at 02:48:19PM -0600, Ross Zwisler wrote: > > > > > Al, now that the changes to fs/namei.c have landed and we're past the > > > merg

Re: [PATCH v8 1/2] Add a "nosymfollow" mount option.

2020-08-26 Thread Ross Zwisler
O Wed, Aug 19, 2020 at 10:43:16AM -0600, Ross Zwisler wrote: > From: Mattias Nissler > > For mounts that have the new "nosymfollow" option, don't follow symlinks > when resolving paths. The new option is similar in spirit to the > existing "nodev", "

[PATCH v8 2/2] selftests: mount: add nosymfollow tests

2020-08-19 Thread Ross Zwisler
are mounted with the 'nosymfollow' option. Signed-off-by: Ross Zwisler --- tools/testing/selftests/mount/.gitignore | 1 + tools/testing/selftests/mount/Makefile| 4 +- .../selftests/mount/nosymfollow-test.c| 218 ++ .../selftests/mount/r

[PATCH v8 1/2] Add a "nosymfollow" mount option.

2020-08-19 Thread Ross Zwisler
s/hardening-against-malicious-stateful-data#TOC-Restricting-symlink-traversal Signed-off-by: Mattias Nissler Signed-off-by: Ross Zwisler Reviewed-by: Aleksa Sarai --- Changes since v7 [1]: * Rebased onto v5.9-rc1. * Added selftest in second patch. * Added Aleska's Reviewed-By tag. Th

Re: [PATCH v7] Add a "nosymfollow" mount option.

2020-08-12 Thread Ross Zwisler
On Wed, Aug 12, 2020 at 12:36 PM Matthew Wilcox wrote: > On Tue, Aug 11, 2020 at 04:28:03PM -0600, Ross Zwisler wrote: > > diff --git a/include/uapi/linux/mount.h b/include/uapi/linux/mount.h > > index 96a0240f23fed..dd8306ea336c1 100644 > > --- a/include/uapi/linux/mount.h &

Re: [PATCH v7] Add a "nosymfollow" mount option.

2020-08-12 Thread Ross Zwisler
On Tue, Aug 11, 2020 at 7:43 PM Aleksa Sarai wrote: > On 2020-08-11, Ross Zwisler wrote: > > From: Mattias Nissler > > > > For mounts that have the new "nosymfollow" option, don't follow symlinks > > when resolving paths. The new option is similar in s

[PATCH v7] Add a "nosymfollow" mount option.

2020-08-11 Thread Ross Zwisler
s/hardening-against-malicious-stateful-data#TOC-Restricting-symlink-traversal Signed-off-by: Mattias Nissler Signed-off-by: Ross Zwisler --- Changes since v6 [1]: * Rebased onto v5.8. * Another round of testing including readlink(1), readlink(2), realpath(1), realpath(3), statfs(2) and mount

[tip:x86/urgent] Revert "x86/build: Move _etext to actual end of .text"

2019-07-09 Thread tip-bot for Ross Zwisler
Commit-ID: 013c66edf207ddb78422b8b636f56c87939c9e34 Gitweb: https://git.kernel.org/tip/013c66edf207ddb78422b8b636f56c87939c9e34 Author: Ross Zwisler AuthorDate: Mon, 1 Jul 2019 09:52:08 -0600 Committer: Ingo Molnar CommitDate: Tue, 9 Jul 2019 13:57:31 +0200 Revert "x86/build:

[tip:x86/urgent] Revert "x86/build: Move _etext to actual end of .text"

2019-07-02 Thread tip-bot for Ross Zwisler
Commit-ID: 77a1619947ab31564aed54621d5b1e34af9b395d Gitweb: https://git.kernel.org/tip/77a1619947ab31564aed54621d5b1e34af9b395d Author: Ross Zwisler AuthorDate: Mon, 1 Jul 2019 09:52:08 -0600 Committer: Thomas Gleixner CommitDate: Tue, 2 Jul 2019 21:09:44 +0200 Revert "x86/build:

[PATCH] Revert "x86/build: Move _etext to actual end of .text"

2019-07-01 Thread Ross Zwisler
e the ability to compile the kernel with these tools. Signed-off-by: Ross Zwisler --- arch/x86/kernel/vmlinux.lds.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S index 0850b5149345..4d1517022a14 100644 --- a

Re: [PATCH v2 3/3] ext4: use jbd2_inode dirty range scoping

2019-06-24 Thread Ross Zwisler
ree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Ross-Zwisler/mm-add-filemap_fdatawait_range_keep_errors/20190623-181603 > config: x86_64-rhel-7.6 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 >

Re: [PATCH v2 2/3] jbd2: introduce jbd2_inode dirty range scoping

2019-06-20 Thread Ross Zwisler
On Thu, Jun 20, 2019 at 3:25 PM Theodore Ts'o wrote: > On Thu, Jun 20, 2019 at 09:18:38AM -0600, Ross Zwisler wrote: > > diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h > > index 5c04181b7c6d8..0e0393e7f41a4 100644 > > --- a/include/linux/jbd2.h >

[PATCH v2 2/3] jbd2: introduce jbd2_inode dirty range scoping

2019-06-20 Thread Ross Zwisler
n is still being appended to. Signed-off-by: Ross Zwisler Reviewed-by: Jan Kara Cc: sta...@vger.kernel.org --- fs/jbd2/commit.c | 23 ++-- fs/jbd2/journal.c | 2 ++ fs/jbd2/transaction.c | 49 --- include/linux/jbd2.h

[PATCH v2 0/3] Add dirty range scoping to jbd2

2019-06-20 Thread Ross Zwisler
o have the old behavior. Ross Zwisler (3): mm: add filemap_fdatawait_range_keep_errors() jbd2: introduce jbd2_inode dirty range scoping ext4: use jbd2_inode dirty range scoping fs/ext4/ext4_jbd2.h | 12 +-- fs/ext4/inode.c | 13 +--- fs/ext4/move_extent.c | 3 ++

[PATCH v2 3/3] ext4: use jbd2_inode dirty range scoping

2019-06-20 Thread Ross Zwisler
Use the newly introduced jbd2_inode dirty range scoping to prevent us from waiting forever when trying to complete a journal transaction. Signed-off-by: Ross Zwisler Reviewed-by: Jan Kara Cc: sta...@vger.kernel.org --- fs/ext4/ext4_jbd2.h | 12 ++-- fs/ext4/inode.c | 13

[PATCH v2 1/3] mm: add filemap_fdatawait_range_keep_errors()

2019-06-20 Thread Ross Zwisler
In the spirit of filemap_fdatawait_range() and filemap_fdatawait_keep_errors(), introduce filemap_fdatawait_range_keep_errors() which both takes a range upon which to wait and does not clear errors from the address space. Signed-off-by: Ross Zwisler Reviewed-by: Jan Kara Cc: sta

Re: [PATCH 2/3] jbd2: introduce jbd2_inode dirty range scoping

2019-06-20 Thread Ross Zwisler
On Thu, Jun 20, 2019 at 01:04:54PM +0200, Jan Kara wrote: > On Wed 19-06-19 11:21:55, Ross Zwisler wrote: > > Currently both journal_submit_inode_data_buffers() and > > journal_finish_inode_data_buffers() operate on the entire address space > > of each of the inodes associated

Re: [PATCH] x86/build: Move _etext to actual end of .text

2019-06-19 Thread Ross Zwisler
On Sun, Jun 9, 2019 at 1:00 PM Johannes Hirte wrote: > On 2019 Jun 09, Klaus Kusche wrote: > > Hello, > > > > Same problem for linux 5.1.7: > > Kernel building fails with the same relocation error. > > > > 5.1.5 does not have the problem, builds fine for me. > > > > Is there anything I can do to i

[PATCH 0/3] Add dirty range scoping to jbd2

2019-06-19 Thread Ross Zwisler
which don't (yet?) take advantage of this scoping (ocfs2) will continue to have the old behavior. Ross Zwisler (3): mm: add filemap_fdatawait_range_keep_errors() jbd2: introduce jbd2_inode dirty range scoping ext4: use jbd2_inode dirty range scoping fs/ext4/ext4_jbd2.h | 12 +-

[PATCH 3/3] ext4: use jbd2_inode dirty range scoping

2019-06-19 Thread Ross Zwisler
Use the newly introduced jbd2_inode dirty range scoping to prevent us from waiting forever when trying to complete a journal transaction. Signed-off-by: Ross Zwisler --- fs/ext4/ext4_jbd2.h | 12 ++-- fs/ext4/inode.c | 13 ++--- fs/ext4/move_extent.c | 3 ++- 3 files

[PATCH 1/3] mm: add filemap_fdatawait_range_keep_errors()

2019-06-19 Thread Ross Zwisler
In the spirit of filemap_fdatawait_range() and filemap_fdatawait_keep_errors(), introduce filemap_fdatawait_range_keep_errors() which both takes a range upon which to wait and does not clear errors from the address space. Signed-off-by: Ross Zwisler --- include/linux/fs.h | 2 ++ mm/filemap.c

[PATCH 2/3] jbd2: introduce jbd2_inode dirty range scoping

2019-06-19 Thread Ross Zwisler
n is still being appended to. Signed-off-by: Ross Zwisler --- fs/jbd2/commit.c | 26 +-- fs/jbd2/journal.c | 2 ++ fs/jbd2/transaction.c | 49 --- include/linux/jbd2.h | 22 +++ 4 files changed, 72 insertions(+)

Re: [linux-4.4.y PATCH] ASoC: Intel: avoid Oops if DMA setup fails

2019-05-09 Thread Ross Zwisler
On Thu, May 09, 2019 at 07:41:47PM +0200, Greg KH wrote: > On Sun, May 05, 2019 at 03:15:53PM +0200, Greg KH wrote: > > On Fri, May 03, 2019 at 01:45:03PM -0600, Ross Zwisler wrote: > > > From: Ross Zwisler > > > > > > commit 0efa3334d65b7f421ba12382dfa5

[linux-4.4.y PATCH] ASoC: Intel: avoid Oops if DMA setup fails

2019-05-03 Thread Ross Zwisler
From: Ross Zwisler commit 0efa3334d65b7f421ba12382dfa58f6ff5bf83c4 upstream. Currently in sst_dsp_new() if we get an error return from sst_dma_new() we just print an error message and then still complete the function successfully. This means that we are trying to run without sst->dma prope

Re: [PATCH] MAINTAINERS: update git tree for sound entries

2019-05-03 Thread Ross Zwisler
On Fri, May 3, 2019 at 2:17 AM Takashi Iwai wrote: > > On Thu, 02 May 2019 19:27:00 +0200, > Ross Zwisler wrote: > > > > Several sound related entries in MAINTAINERS refer to the old git tree > > at "git://git.alsa-project.org/alsa-kernel.git". This is no

[PATCH] MAINTAINERS: update git tree for sound entries

2019-05-02 Thread Ross Zwisler
Several sound related entries in MAINTAINERS refer to the old git tree at "git://git.alsa-project.org/alsa-kernel.git". This is no longer used for development, and Takashi Iwai's kernel.org tree is used instead. Signed-off-by: Ross Zwisler --- MAINTAINERS | 13 ++--- 1

Re: [PATCH] ASoC: Intel: avoid Oops if DMA setup fails

2019-04-29 Thread Ross Zwisler
On Fri, Apr 26, 2019 at 06:52:45PM +, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a -stable tag. > The stable tag indicates that it's relevant for the following trees: all > > The bot has tested the following trees: v5.0.9,

[PATCH v2] ASoC: Intel: avoid Oops if DMA setup fails

2019-04-29 Thread Ross Zwisler
18 IP: sst_dsp_dma_get_channel+0x4f/0x125 [snd_soc_sst_firmware] Fix this by adding proper error handling for the case where we fail to set up DMA. This change only affects Haswell and Broadwell systems. Baytrail systems explicilty opt-out of DMA via sst->pdata->resindex_dma_base being set to -1. S

Re: [PATCH] ASoC: Intel: avoid Oops if DMA setup fails

2019-04-29 Thread Ross Zwisler
On Fri, Apr 26, 2019 at 04:03:47PM -0500, Pierre-Louis Bossart wrote: > On 4/26/19 11:47 AM, Ross Zwisler wrote: > > Currently in sst_dsp_new() if we get an error return from sst_dma_new() > > we just print an error message and then still complete the function > > successfully

[PATCH] ASoC: Intel: avoid Oops if DMA setup fails

2019-04-26 Thread Ross Zwisler
18 IP: sst_dsp_dma_get_channel+0x4f/0x125 [snd_soc_sst_firmware] Fix this by adding proper error handling for the case where we fail to set up DMA. Signed-off-by: Ross Zwisler Cc: sta...@vger.kernel.org --- sound/soc/intel/common/sst-firmware.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [PATCH v1] mmc: core: Verify SD bus width

2019-04-15 Thread Ross Zwisler
On Mon, Apr 15, 2019 at 03:00:31PM -0600, Raul E Rangel wrote: > The SD Physical Layer Spec says the following: Since the SD Memory Card > shall support at least the two bus modes 1-bit or 4-bit width, then any SD > Card shall set at least bits 0 and 2 (SD_BUS_WIDTH="0101"). > > This change verifi

Re: [PATCH] cros_ec: Add trace event to trace EC commands

2019-04-10 Thread Ross Zwisler
os_ec_cmd: version: 0, command: GET_VERSION */ > /* cros_ec_cmd: version: 0, command: GET_PROTOCOL_INFO */ > /* cros_ec_cmd: version: 1, command: GET_CMD_VERSIONS */ > /* cros_ec_cmd: version: 1, command: USB_PD_CONTROL */ > > Signed-off-by: Raul E Rangel Reviewed-by: Ross Zwisler

Re: [PATCH] MAINTAINERS: Update filesystem-dax and NVDIMM entries

2019-01-24 Thread Ross Zwisler
quests. > > > > Ira and Keith are now involved with the NVDIMM and Device-DAX > > sub-systems. > > > > The linux-nvdimm mailing hosts a patchwork instance for both DAX and > > NVDIMM patches. > > > > Cc: Jan Kara > > Cc: Ira Weiny > > C

Re: [PATCH] ASoC: rt5677: use more of the volume range from DACs

2019-01-04 Thread Ross Zwisler
On Thu, Dec 20, 2018 at 04:25:55PM -0700, Ross Zwisler wrote: > From: Dylan Reid > > The DACs volume can go over 0, both according to the data sheet and > real world testing. The control can go up to +30dB. > > This was tested by playing audio at full volume on a samus chrom

Re: [PATCH] drm/i915/psr: simplify enable_psr handling

2018-12-21 Thread Ross Zwisler
On Fri, Dec 21, 2018 at 11:23:07AM -0800, Dhinakaran Pandiyan wrote: > On Fri, 2018-12-21 at 10:23 -0700, Ross Zwisler wrote: > > The following commit: > > > > commit 2bdd045e3a30 ("drm/i915/psr: Check if VBT says PSR can be > > enabled.") > > >

[PATCH] drm/i915/psr: simplify enable_psr handling

2018-12-21 Thread Ross Zwisler
t defaults to 0. Remove this dead code, simplify the way that enable_psr is handled and update the module parameter string to match the actual functionality. Cc: Dhinakaran Pandiyan Cc: Rodrigo Vivi Signed-off-by: Ross Zwisler --- drivers/gpu/drm/i915/i915_drv.h| 1 - drivers/gpu/drm/i915/i9

[PATCH] ASoC: rt5677: use more of the volume range from DACs

2018-12-20 Thread Ross Zwisler
From: Dylan Reid The DACs volume can go over 0, both according to the data sheet and real world testing. The control can go up to +30dB. This was tested by playing audio at full volume on a samus chromebook. Signed-off-by: Dylan Reid Reviewed-by: Hsinyu Chao Signed-off-by: Ross Zwisler

Re: [PATCH] thermal: add ratelimited thermal and power logging

2018-10-29 Thread Ross Zwisler
On Wed, Oct 24, 2018 at 1:22 AM Viresh Kumar wrote: > On 22-10-18, 14:29, Ross Zwisler wrote: > > From: Ricky Liang > > > > Add thermal logs in devfreq_cooling and cpu_cooling. > > Why should we add them ? > > > Also add logging to > > power

[PATCH 2/2] gsmi: Log event for critical thermal thresholds

2018-10-22 Thread Ross Zwisler
: Duncan Laurie Reviewed-by: Vincent Palatin Reviewed-by: Olof Johansson [ rez: updated changelog for upstream ] Signed-off-by: Ross Zwisler --- drivers/firmware/google/gsmi.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google

[PATCH 1/2] thermal: Add notifier call chain for hot/critical events

2018-10-22 Thread Ross Zwisler
to the cpu_cooling notifier chain so it is not useful for logging. Signed-off-by: Duncan Laurie Reviewed-by: Olof Johansson Reviewed-by: Vincent Palatin [ rez: updated changelog for upstream ] Signed-off-by: Ross Zwisler --- drivers/thermal/thermal_core.c | 38 ++ include

[PATCH] thermal: add ratelimited thermal and power logging

2018-10-22 Thread Ross Zwisler
from each of those subsystems. Signed-off-by: Ricky Liang Co-authored-by: Stephen Barber Signed-off-by: Stephen Barber Reviewed-by: Daniel Kurtz [ rez: squashed initial implementation & fixes, updated changelog for upstream. ] Signed-off-by: Ross Zwisler --- drivers/thermal/cpu_cooli

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Ross Zwisler
On Thu, Oct 18, 2018 at 2:31 PM Kees Cook wrote: > > On Thu, Oct 18, 2018 at 8:33 AM, Dan Williams > wrote: > > [ add Ross ] > > Hi Ross! :) > > > On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: > >> As for nvdimm specifically, yes, I'd love to get pstore hooked up > >> correctly to nvdimm. H

[PATCH 3/4] gsmi: Remove autoselected dependency on EFI and EFI_VARS

2018-10-12 Thread Ross Zwisler
changelog for upstream] Signed-off-by: Ross Zwisler --- drivers/firmware/google/Kconfig | 6 +++--- drivers/firmware/google/gsmi.c | 16 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig index

[PATCH 1/4] gsmi: Fix bug in append_to_eventlog sysfs handler

2018-10-12 Thread Ross Zwisler
iewed-by: Aaron Durbin Reviewed-by: Justin TerAvest [zwisler: updated changelog for 2nd bug fix and upstream] Signed-off-by: Ross Zwisler --- drivers/firmware/google/gsmi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmwa

[PATCH 0/4] gsmi: Google specific firmware patches

2018-10-12 Thread Ross Zwisler
This series contains some Google specific firmware patches that we've been carrying out of tree. I've updated the changelog for each so that it is suitable for upstream, and I've retested them to make sure I know what the patches are doing. Duncan Laurie (3): gsmi: Fix bug in append_to_eventlog

[PATCH 2/4] gsmi: Add coreboot to list of matching BIOS vendors

2018-10-12 Thread Ross Zwisler
Signed-off-by: Ross Zwisler --- drivers/firmware/google/gsmi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c index 62337be07afc..252884787266 100644 --- a/drivers/firmware/google/gsmi.c +++ b/drivers/firmware/google/gsm

[PATCH 4/4] gsmi: Add GSMI commands to log S0ix info

2018-10-12 Thread Ross Zwisler
-by: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Aaron Durbin [zwisler: update changelog for upstream] Signed-off-by: Ross Zwisler --- drivers/firmware/google/gsmi.c | 93 +- 1 file changed, 92 insertions(+), 1 deletion(-) diff --git a/drivers/firmware

Re: [PATCH v14 00/74] Convert page cache to XArray

2018-07-25 Thread Ross Zwisler
On Wed, Jul 25, 2018 at 02:03:23PM -0700, Matthew Wilcox wrote: > On Wed, Jun 27, 2018 at 01:44:38PM -0600, Ross Zwisler wrote: > > On Wed, Jun 27, 2018 at 04:05:29AM -0700, Matthew Wilcox wrote: > > > On Tue, Jun 19, 2018 at 10:16:38AM -0700, Matthew Wilcox wrote: > > >

Re: [PATCH v2 0/6] kaddr and pfn can be NULL to ->direct_access()

2018-07-25 Thread Ross Zwisler
ual to NULL, that > is to say callers may have no need for kaddr or pfn, so this series of > patch are prepared for allowing them to pass in NULL instead of having > to pass in a local pointer or variable that they then just throw away. Looks good. For the series: Reviewed-by: Ross Zwisler

Re: [PATCH] mm/sparse: Make sparse_init_one_section void and remove check

2018-07-06 Thread Ross Zwisler
On Mon, Jul 2, 2018 at 12:48 PM Pavel Tatashin wrote: > > On Mon, Jul 2, 2018 at 11:43 AM wrote: > > > > From: Oscar Salvador > > > > sparse_init_one_section() is being called from two sites: > > sparse_init() and sparse_add_one_section(). > > The former calls it from a for_each_present_section_

Re: [PATCH] x86/asm/memcpy_mcsafe: Fix copy_to_user_mcsafe() exception handling

2018-07-03 Thread Ross Zwisler
orton > Cc: Andy Lutomirski > Cc: Borislav Petkov > Cc: Linus Torvalds > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Tony Luck > Reported-by: Ross Zwisler > Signed-off-by: Dan Williams Tested-by: Ross Zwisler

Re: [PATCH] lib/iov_iter: Fix pipe handling in _copy_to_iter_mcsafe

2018-07-03 Thread Ross Zwisler
Morton > Cc: Andy Lutomirski > Cc: Borislav Petkov > Cc: Linus Torvalds > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Tony Luck > Reported-by: Ross Zwisler > Signed-off-by: Dan Williams Tested-by: Ross Zwisler

Re: [PATCH] lib/iov_iter: Fix pipe handling in _copy_to_iter_mcsafe

2018-07-02 Thread Ross Zwisler
Morton > Cc: Andy Lutomirski > Cc: Borislav Petkov > Cc: Linus Torvalds > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Tony Luck > Reported-by: Ross Zwisler > Signed-off-by: Dan Williams > --- > Hi Ingo, > > I'm submitting this fix back through t

Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

2018-06-28 Thread Ross Zwisler
On Thu, Jun 28, 2018 at 05:42:34PM +, Kani, Toshi wrote: > On Tue, 2018-06-26 at 16:04 -0600, Ross Zwisler wrote: > > On Tue, Jun 26, 2018 at 02:51:52PM -0700, Dan Williams wrote: > > > On Tue, Jun 26, 2018 at 2:31 PM, Kani, Toshi wrote: > > > > On Tue, 2018-06-2

[PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-29 Thread Ross Zwisler
no DAX support returns false. Signed-off-by: Dave Jiang Signed-off-by: Ross Zwisler --- drivers/dax/super.c | 16 fs/ext2/super.c | 3 +-- fs/ext4/super.c | 3 +-- fs/xfs/xfs_ioctl.c | 4 ++-- fs/xfs/xfs_super.c | 12 ++-- include/linux/dax.h | 8 6

[PATCH resend 1/7] fs: allow per-device dax status checking for filesystems

2018-05-25 Thread Ross Zwisler
of XFS where we need to be able to distinguish between datadev and rtdev. This patch fixes the problem where we screw up the dax support checking in xfs if the datadev and rtdev have different dax capabilities. Signed-off-by: Darrick J. Wong Signed-off-by: Ross Zwisler --- drivers/d

[PATCH resend 6/7] dm-snap: remove unnecessary direct_access() stub

2018-05-25 Thread Ross Zwisler
This stub was added so that we could use dm-snap with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler --- drivers/md/dm-snap.c | 8 1 file changed, 8 deletions

[PATCH resend 0/7] Fix DM DAX handling

2018-05-25 Thread Ross Zwisler
in DM. I feel that this series simplifies the handling of DAX devices in DM, and the last 5 DM-related patches have a net code reduction of 50 lines. Darrick J. Wong (1): fs: allow per-device dax status checking for filesystems Dave Jiang (1): dax: change bdev_dax_supported() to support bo

[PATCH resend 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-25 Thread Ross Zwisler
no DAX support returns false. Signed-off-by: Dave Jiang Signed-off-by: Ross Zwisler Reviewed-by: Darrick J. Wong --- drivers/dax/super.c | 16 fs/ext2/super.c | 3 +-- fs/ext4/super.c | 3 +-- fs/xfs/xfs_ioctl.c | 4 ++-- fs/xfs/xfs_super.c | 12

[PATCH resend 7/7] dm-error: remove unnecessary direct_access() stub

2018-05-25 Thread Ross Zwisler
This stub was added so that we could use dm-error with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler --- drivers/md/dm-target.c | 7 --- 1 file changed, 7 deletions

[PATCH resend 3/7] dm: fix test for DAX device support

2018-05-25 Thread Ross Zwisler
make sure the dax_direct_access() path works. Signed-off-by: Ross Zwisler Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support") --- drivers/md/dm-table.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.

[PATCH resend 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode

2018-05-25 Thread Ross Zwisler
stem will then know at mount time whether DAX is a supported mount option or not. Signed-off-by: Ross Zwisler --- drivers/md/dm-ioctl.c | 16 ++-- drivers/md/dm-table.c | 25 ++--- drivers/md/dm.c | 2 -- include/linux/device-mapper

[PATCH resend 4/7] dm: prevent DAX mounts if not supported

2018-05-25 Thread Ross Zwisler
dm_dax_direct_access() if QUEUE_FLAG_DAX isn't set we let the filesystem know we don't support DAX at mount time. The filesystem will then silently fall back and remove the dax mount option, causing it to work properly. Signed-off-by: Ross Zwisler Fixes: commit 545ed20e6df6 (&quo

Re: [PATCH 4/7] dm: prevent DAX mounts if not supported

2018-05-25 Thread Ross Zwisler
On Fri, May 25, 2018 at 03:54:10PM -0400, Mike Snitzer wrote: > On Thu, May 24 2018 at 10:55pm -0400, > Ross Zwisler wrote: > > > Currently the code in dm_dax_direct_access() only checks whether the target > > type has a direct_access() operation defined, not whether the

Re: [PATCH 1/7] fs: allow per-device dax status checking for filesystems

2018-05-25 Thread Ross Zwisler
On Thu, May 24, 2018 at 10:02:18PM -0700, Darrick J. Wong wrote: > On Thu, May 24, 2018 at 08:55:12PM -0600, Ross Zwisler wrote: > > From: "Darrick J. Wong" > > > > Remove __bdev_dax_supported and change to bdev_dax_supported that takes a > > bdev

[PATCH 6/7] dm-snap: remove unnecessary direct_access() stub

2018-05-24 Thread Ross Zwisler
This stub was added so that we could use dm-snap with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler --- drivers/md/dm-snap.c | 8 1 file changed, 8 deletions

[PATCH 1/7] fs: allow per-device dax status checking for filesystems

2018-05-24 Thread Ross Zwisler
of XFS where we need to be able to distinguish between datadev and rtdev. This patch fixes the problem where we screw up the dax support checking in xfs if the datadev and rtdev have different dax capabilities. Signed-off-by: Darrick J. Wong Signed-off-by: Ross Zwisler --- drivers/d

[PATCH 4/7] dm: prevent DAX mounts if not supported

2018-05-24 Thread Ross Zwisler
dm_dax_direct_access() if QUEUE_FLAG_DAX isn't set we let the filesystem know we don't support DAX at mount time. The filesystem will then silently fall back and remove the dax mount option, causing it to work properly. Signed-off-by: Ross Zwisler Fixes: commit 545ed20e6df6 (&quo

[PATCH 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-24 Thread Ross Zwisler
no DAX support returns false. Signed-off-by: Dave Jiang Signed-off-by: Ross Zwisler --- drivers/dax/super.c | 16 fs/ext2/super.c | 3 +-- fs/ext4/super.c | 3 +-- fs/xfs/xfs_ioctl.c | 4 ++-- fs/xfs/xfs_super.c | 12 ++-- include/linux/dax.h | 6 +++--- 6

[PATCH 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode

2018-05-24 Thread Ross Zwisler
stem will then know at mount time whether DAX is a supported mount option or not. Signed-off-by: Ross Zwisler --- drivers/md/dm-ioctl.c | 16 ++-- drivers/md/dm-table.c | 25 ++--- drivers/md/dm.c | 2 -- include/linux/device-mapper

[PATCH 3/7] dm: fix test for DAX device support

2018-05-24 Thread Ross Zwisler
make sure the dax_direct_access() path works. Signed-off-by: Ross Zwisler Fixes: commit 545ed20e6df6 ("dm: add infrastructure for DAX support") --- drivers/md/dm-table.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.

[PATCH 7/7] dm-error: remove unnecessary direct_access() stub

2018-05-24 Thread Ross Zwisler
This stub was added so that we could use dm-error with DM_TYPE_DAX_BIO_BASED mode devices. That mode and the transition issues associated with it no longer exist, so we can remove this dead code. Signed-off-by: Ross Zwisler --- drivers/md/dm-target.c | 7 --- 1 file changed, 7 deletions

[PATCH 0/7] Fix DM DAX handling

2018-05-24 Thread Ross Zwisler
ches have a net code reduction of 50 lines. Darrick J. Wong (1): fs: allow per-device dax status checking for filesystems Dave Jiang (1): dax: change bdev_dax_supported() to support boolean returns Ross Zwisler (5): dm: fix test for DAX device support dm: prevent DAX mounts if not support

Re: [PATCH v3 7/9] dax: report bytes remaining in dax_iomap_actor()

2018-05-23 Thread Ross Zwisler
On Wed, May 23, 2018 at 09:53:38AM -0700, Dan Williams wrote: > On Wed, May 23, 2018 at 9:47 AM, Ross Zwisler > wrote: > > On Wed, May 23, 2018 at 09:39:04AM -0700, Dan Williams wrote: > >> On Wed, May 23, 2018 at 9:34 AM, Ross Zwisler > >> wrote: > >> >

Re: [PATCH v3 7/9] dax: report bytes remaining in dax_iomap_actor()

2018-05-23 Thread Ross Zwisler
On Wed, May 23, 2018 at 09:39:04AM -0700, Dan Williams wrote: > On Wed, May 23, 2018 at 9:34 AM, Ross Zwisler > wrote: > > On Thu, May 03, 2018 at 05:06:42PM -0700, Dan Williams wrote: > >> In preparation for protecting the dax read(2) path from media errors > >> w

Re: [PATCH v3 8/9] pmem: switch to copy_to_iter_mcsafe()

2018-05-23 Thread Ross Zwisler
On Thu, May 03, 2018 at 05:06:47PM -0700, Dan Williams wrote: > Use the machine check safe version of copy_to_iter() for the > ->copy_to_iter() operation published by the pmem driver. > > Signed-off-by: Dan Williams Sure. Reviewed-by: Ross Zwisler

Re: [PATCH v3 7/9] dax: report bytes remaining in dax_iomap_actor()

2018-05-23 Thread Ross Zwisler
On Thu, May 03, 2018 at 05:06:42PM -0700, Dan Williams wrote: > In preparation for protecting the dax read(2) path from media errors > with copy_to_iter_mcsafe() (via dax_copy_to_iter()), convert the > implementation to report the bytes successfully transferred. > > Cc: > Cc: Ingo Molnar > Cc: B

Re: [PATCH v3 6/9] dax: introduce a ->copy_to_iter dax operation

2018-05-23 Thread Ross Zwisler
hine check safe version of copy_to_iter(). For now, add the plumbing > to device-mapper and the dax core. > > Cc: Ross Zwisler > Cc: Mike Snitzer > Cc: Christoph Hellwig > Signed-off-by: Dan Williams Looks good to me. Reviewed-by: Ross Zwisler

Re: [PATCH 0/5] fix radix tree multi-order iteration race

2018-05-10 Thread Ross Zwisler
On Thu, May 10, 2018 at 03:48:44PM -0700, Andrew Morton wrote: > so I think I'll just ignore all that and send this series off to Linus next > week. Great. Thank you, Andrew.

Re: [PATCH 5/5] radix tree: fix multi-order iteration race

2018-05-09 Thread Ross Zwisler
On Wed, May 09, 2018 at 02:46:11PM +0200, Jan Kara wrote: > On Thu 03-05-18 13:24:30, Ross Zwisler wrote: > > Fix a race in the multi-order iteration code which causes the kernel to hit > > a GP fault. This was first seen with a production v4.15 based kernel > > (4.15.6-300.f

Re: [PATCH 0/5] fix radix tree multi-order iteration race

2018-05-08 Thread Ross Zwisler
On Thu, May 03, 2018 at 01:24:25PM -0600, Ross Zwisler wrote: > The following series gets the radix tree test suite compiling again in > the current linux/master, adds a unit test which exposes a race in the > radix tree multi-order iteration code, and then fixes that race. > >

[PATCH 2/5] radix tree test suite: fix compilation issue

2018-05-03 Thread Ross Zwisler
~~ by providing a spin_lock_init() wrapper for the v4.17-rc* version of the radix tree test suite. Signed-off-by: Ross Zwisler --- tools/include/linux/spinlock.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/include/linux/spinlock.h b/tools/include/linux

[PATCH 3/5] radix tree test suite: add item_delete_rcu()

2018-05-03 Thread Ross Zwisler
s we do with "struct radix_tree_node" items. Signed-off-by: Ross Zwisler --- tools/testing/radix-tree/test.c | 19 +++ tools/testing/radix-tree/test.h | 2 ++ 2 files changed, 21 insertions(+) diff --git a/tools/testing/radix-tree/test.c b/tools/testing/radix-

[PATCH 5/5] radix tree: fix multi-order iteration race

2018-05-03 Thread Ross Zwisler
st the preceding slot we instead look for siblings via is_sibling_entry() which compares against the position of the struct radix_tree_node.slots[] array. This ensures that sibling entries are properly identified, even if they are no longer contiguous with the 'entry' they point to. S

[PATCH 1/5] radix tree test suite: fix mapshift build target

2018-05-03 Thread Ross Zwisler
.h', needed by 'main.o'. Stop. make: *** Waiting for unfinished jobs Fix this by making the file generated/map-shift.h our real makefile target, and add this a dependency of the top level build target. Signed-off-by: Ross Zwisler --- tools/testing/radix-tree/Makefile | 6 ++--

[PATCH 4/5] radix tree test suite: multi-order iteration race

2018-05-03 Thread Ross Zwisler
ad.so.0+0x750a) #4 0x7fa8a03bd16e in clone (/lib64/libc.so.6+0xf516e) Signed-off-by: Ross Zwisler --- tools/testing/radix-tree/multiorder.c | 63 +++ tools/testing/radix-tree/test.h | 1 + 2 files changed, 64 insertions(+) diff --git a/tools/tes

[PATCH 0/5] fix radix tree multi-order iteration race

2018-05-03 Thread Ross Zwisler
h the v4.15 based kernel. Ross Zwisler (5): radix tree test suite: fix mapshift build target radix tree test suite: fix compilation issue radix tree test suite: add item_delete_rcu() radix tree test suite: multi-order iteration race radix tree: fix multi-order iteration race lib/radix-t

Re: [PATCH v6] fs: dax: Adding new return type vm_fault_t

2018-04-26 Thread Ross Zwisler
Reviewed-by: Jan Kara > Reviewed-by: Matthew Wilcox Sure, this looks correct. You can add: Reviewed-by: Ross Zwisler I noticed that we have the following status translation now in 4 places in 2 files: if (err == -ENOMEM) return VM_FAULT_OOM; if (err &

Re: [PATCH] MAINTAINERS: Adding backup maintainers for libnvdimm and DAX

2018-04-13 Thread Ross Zwisler
On Fri, Apr 13, 2018 at 01:47:40PM -0700, Dave Jiang wrote: > Adding additional maintainers to libnvdimm related code and DAX. > > Signed-off-by: Dave Jiang This is fine with me: Acked-by: Ross Zwisler

Re: [PATCH v9 07/61] xarray: Add the xa_lock to the radix_tree_root

2018-04-12 Thread Ross Zwisler
On Thu, Apr 12, 2018 at 3:22 PM, Matthew Wilcox wrote: > On Thu, Apr 12, 2018 at 03:16:23PM -0600, Ross Zwisler wrote: >> On Thu, Apr 12, 2018 at 3:10 PM, Matthew Wilcox wrote: >> > On Thu, Apr 12, 2018 at 02:59:32PM -0600, Ross Zwisler wrote: >> >> This is causi

Re: [PATCH v9 07/61] xarray: Add the xa_lock to the radix_tree_root

2018-04-12 Thread Ross Zwisler
On Thu, Apr 12, 2018 at 3:10 PM, Matthew Wilcox wrote: > On Thu, Apr 12, 2018 at 02:59:32PM -0600, Ross Zwisler wrote: >> This is causing build breakage in the radix tree test suite in the >> current linux/master: >> >> ./linux/../../../../include/linux/idr.h:

[PATCH] radix tree test suite: fix mapshift build target

2018-04-12 Thread Ross Zwisler
.h', needed by 'main.o'. Stop. make: *** Waiting for unfinished jobs Fix this by making the file generated/map-shift.h our real makefile target, and add this a dependency of the top level build target. Signed-off-by: Ross Zwisler --- This allows the radix tree test suite th

Re: [PATCH v9 07/61] xarray: Add the xa_lock to the radix_tree_root

2018-04-12 Thread Ross Zwisler
On Tue, Mar 13, 2018 at 7:25 AM, Matthew Wilcox wrote: > From: Matthew Wilcox > > This results in no change in structure size on 64-bit machines as it > fits in the padding between the gfp_t and the void *. 32-bit machines > will grow the structure from 8 to 12 bytes. Almost all radix trees > a

Re: [PATCH] libnvdimm, region: hide persistence_domain when unknown

2018-03-21 Thread Ross Zwisler
Signed-off-by: Dan Williams Looks good to me. Reviewed-by: Ross Zwisler

[PATCH] MAINTAINERS: add coverage for drivers/block

2018-03-09 Thread Ross Zwisler
To help folks like me that use scripts/get_maintainer.pl. Signed-off-by: Ross Zwisler --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4623caf8d72d..7ff83f4c9aeb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2685,6 +2685,7 @@ L:linux

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-03-09 Thread Ross Zwisler
On Fri, Mar 09, 2018 at 08:38:57AM -0700, Jens Axboe wrote: > On 3/9/18 8:38 AM, Jens Axboe wrote: > > On 3/8/18 5:20 PM, Ross Zwisler wrote: > >> This has gotten Reviewed-by tags from Christoph and Ming Lei. > >> > >> Al, are you the right person to merge

  1   2   3   4   5   6   7   8   9   10   >