Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending

On 2021-03-09 08:57, Ross Lagerwall wrote: > On 2021-03-09 05:14, Jürgen Groß wrote: >> On 08.03.21 21:33, Boris Ostrovsky wrote: >>> >>> On 3/6/21 11:18 AM, Juergen Gross wrote: >>>> An event channel should be kept masked when an eoi is pending for it. >

Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending

On 2021-03-09 05:14, Jürgen Groß wrote: > On 08.03.21 21:33, Boris Ostrovsky wrote: >> >> On 3/6/21 11:18 AM, Juergen Gross wrote: >>> An event channel should be kept masked when an eoi is pending for it. >>> When being migrated to another cpu it might be unmasked, though. >>> >>> In order to avoid

Re: [PATCH v3 2/8] xen/events: don't unmask an event channel when an eoi is pending

On 2021-02-19 15:40, Juergen Gross wrote: > An event channel should be kept masked when an eoi is pending for it. > When being migrated to another cpu it might be unmasked, though. > > In order to avoid this keep three different flags for each event channel > to be able to distinguish "normal" mas

Re: [PATCH v2 8/8] xen/evtchn: use READ/WRITE_ONCE() for accessing ring indices

On 2021-02-11 10:16, Juergen Gross wrote: > For avoiding read- and write-tearing by the compiler use READ_ONCE() > and WRITE_ONCE() for accessing the ring indices in evtchn.c. > > Signed-off-by: Juergen Gross > --- > V2: > - modify all accesses (Julien Grall) > --- > drivers/xen/evtchn.c | 25 ++

Re: [PATCH 2/7] xen/events: don't unmask an event channel when an eoi is pending

On 2021-02-06 10:49, Juergen Gross wrote: > An event channel should be kept masked when an eoi is pending for it. > When being migrated to another cpu it might be unmasked, though. > > In order to avoid this keep two different flags for each event channel > to be able to distinguish "normal" maski

[PATCH] iscsi_ibft: Use a field width for target lun sysfs entry

string can be parsed correctly. Signed-off-by: Ross Lagerwall --- drivers/firmware/iscsi_ibft.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index ab3aa3983833..5900edcb6334 100644 --- a/drivers/firmware

[PATCH v2 2/2] efi/cper: Fix possible out-of-bounds access

0 is a superset of the earlier version. Also rework the other checks to avoid potential underflow. Signed-off-by: Ross Lagerwall --- drivers/firmware/efi/cper.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/

Re: [PATCH 2/2] efi/cper: Avoid possible OOB when checking generic data block

On 1/23/19 11:54 AM, Borislav Petkov wrote: On Tue, Jan 22, 2019 at 04:09:12PM +, Ross Lagerwall wrote: When checking a generic status block, we iterate over all the generic data blocks. The loop condition only checks that the start of the generic data block is valid (within estatus

[PATCH v2 1/2] acpi/apei: Fix possible out-of-bounds access to BERT region

). Also move the block_status check so that it only happens after the block has been verified to be within the mapped region. Signed-off-by: Ross Lagerwall --- drivers/acpi/apei/bert.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/acpi/apei

[PATCH v2 0/2] Fix crash in cper_estatus_check()

125.685371] CR2: c9004046d02c CR3: 0260c000 CR4: 00042660 [ 125.685566] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0009 Thanks, Ross Lagerwall (2): acpi/apei: Fix possible out-of-bounds access to BERT region efi/cper: Fix possible out-of-bounds access drivers

[PATCH 2/2] efi/cper: Avoid possible OOB when checking generic data block

perset of the earlier version. Also rework the other checks to avoid potential underflow. Signed-off-by: Ross Lagerwall --- drivers/firmware/efi/cper.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c

[PATCH 0/2] Fix crash in cper_estatus_check()

00042660 [ 125.685566] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0009 Thanks, Ross Lagerwall (2): acpi/apei: Avoid possible OOB when accessing BERT region efi/cper: Avoid possible OOB when checking generic data block drivers/acpi/apei/be

[PATCH 1/2] acpi/apei: Avoid possible OOB when accessing BERT region

the block_status check so that it only happens after the block has been verified to be within the mapped region. Signed-off-by: Ross Lagerwall --- drivers/acpi/apei/bert.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/acpi/apei/bert.c b

Re: [PATCH 4.4 059/268] xen-netfront: Fix race between device setup and open

On 06/11/2018 03:29 PM, Ben Hutchings wrote: On Mon, 2018-05-28 at 12:00 +0200, Greg Kroah-Hartman wrote: 4.4-stable review patch.  If anyone has any objections, please let me know. -- From: Ross Lagerwall [ Upstream commit f599c64fdf7d9c108e8717fb04bc41c680120da4

Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist

ts by default, nor does it implement the block limits VPD page. Apply the sector limit workaround for these targets. Signed-off-by: Ross Lagerwall --- drivers/scsi/scsi_devinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devi

[PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist

The Windows Server 2016 iSCSI target doesn't work with the Linux kernel initiator since the kernel started sending larger requests by default, nor does it implement the block limits VPD page. Apply the sector limit workaround for these targets. Signed-off-by: Ross Lagerwall --- drivers

Re: [PATCH 2/2] xen-netfront: Fix race between device setup and open

On 01/11/2018 04:08 PM, David Miller wrote: From: Ross Lagerwall Date: Thu, 11 Jan 2018 15:49:07 + I've now added CC'd netdev on the other two. That doesn't work. If you don't post the originals explicitly to netdev then it won't get properly queued in patch

Re: [PATCH 2/2] xen-netfront: Fix race between device setup and open

On 01/11/2018 03:26 PM, David Miller wrote: From: Ross Lagerwall Date: Thu, 11 Jan 2018 09:36:38 + When a netfront device is set up it registers a netdev fairly early on, before it has set up the queues and is actually usable. A userspace tool like NetworkManager will immediately try to

Re: [PATCH 1/2] xen/grant-table: Use put_page instead of free_page

+CC netdev On 01/11/2018 09:36 AM, Ross Lagerwall wrote: The page given to gnttab_end_foreign_access() to free could be a compound page so use put_page() instead of free_page() since it can handle both compound and single pages correctly. This bug was discovered when migrating a Xen VM with

Re: [PATCH 0/2] Fix a couple of crashes in netfront

+CC netdev On 01/11/2018 09:36 AM, Ross Lagerwall wrote: Here are a couple of patches to fix two crashes in netfront. Ross Lagerwall (2): xen/grant-table: Use put_page instead of free_page xen-netfront: Fix race between device setup and open drivers/net/xen-netfront.c | 46

[PATCH 2/2] xen-netfront: Fix race between device setup and open

have been destroyed but before they have been recreated. Extend the region covered by the rtnl semaphore to protect against this race. There is a possibility that we fail to recreate the queues so check for this in the open function. Signed-off-by: Ross Lagerwall --- drivers/net/xen-netfront.c

[PATCH 0/2] Fix a couple of crashes in netfront

Here are a couple of patches to fix two crashes in netfront. Ross Lagerwall (2): xen/grant-table: Use put_page instead of free_page xen-netfront: Fix race between device setup and open drivers/net/xen-netfront.c | 46 -- drivers/xen/grant-table.c

[PATCH 1/2] xen/grant-table: Use put_page instead of free_page

error which is detected when DEBUG_VM is enabled. Signed-off-by: Ross Lagerwall --- drivers/xen/grant-table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index f45114f..27be107 100644 --- a/drivers/xen/grant

Re: [PATCH 2/2] xen/gntdev: Fix partial gntdev_mmap() cleanup

On 01/10/2018 01:22 AM, Boris Ostrovsky wrote: On 01/09/2018 07:10 AM, Ross Lagerwall wrote: When cleaning up after a partially successful gntdev_mmap(), unmap the successfully mapped grant pages otherwise Xen will kill the domain if in debug mode (Attempt to implicitly unmap a granted PTE

[PATCH 2/2] xen/gntdev: Fix partial gntdev_mmap() cleanup

lease mode. This is only needed when use_ptemod is true because gntdev_put_map() will unmap grant pages itself when use_ptemod is false. Signed-off-by: Ross Lagerwall --- drivers/xen/gntdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xe

[PATCH 1/2] xen/gntdev: Fix off-by-one error when unmapping with holes

If the requested range has a hole, the calculation of the number of pages to unmap is off by one. Fix it. Signed-off-by: Ross Lagerwall --- drivers/xen/gntdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 57efbd3

[PATCH RESEND 4.4-only] netlink: Allow direct reclaim for fallback allocation

by adding back the direct reclaim flag to the fallback allocation. Fixes: 6d123f1d396b ("netlink: do not enter direct reclaim from netlink_dump()") Signed-off-by: Ross Lagerwall --- Note that this is only for the 4.4 branch as the regression is only in this branch. Consequently, there

[PATCH 4.4-only] netlink: Allow direct reclaim for fallback allocation

dding back the direct reclaim flag to the fallback allocation. Fixes: 6d123f1d396b ("netlink: do not enter direct reclaim from netlink_dump()") Signed-off-by: Ross Lagerwall --- net/netlink/af_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netlin

[PATCH v3] xen-netfront: Improve error handling during initialization

the napi context. * If any fatal error occurs, unregister and destroy the netdev to avoid leaving around a half setup network device. Signed-off-by: Ross Lagerwall --- Changed in V3: * If xennet_create_queues returns < 0, it will not have created any queues so there's no need to go

Re: [PATCH v2] xen-netfront: Improve error handling during initialization

On 02/07/2017 11:33 PM, Boris Ostrovsky wrote: On 02/07/2017 09:55 AM, Ross Lagerwall wrote: This fixes a crash when running out of grant refs when creating many queues across many netdevs. * If creating queues fails (i.e. there are no grant refs available), call xenbus_dev_fatal() to ensure

[PATCH v2] xen-netfront: Improve error handling during initialization

the napi context. * If any fatal error occurs, unregister and destroy the netdev to avoid leaving around a half setup network device. Signed-off-by: Ross Lagerwall --- Changed in V2: * Retested on top of v4.10-rc7 + "xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()&q

Re: [PATCH] xen-netfront: Improve error handling during initialization

On 02/01/2017 06:54 PM, Boris Ostrovsky wrote: On 02/01/2017 10:50 AM, Ross Lagerwall wrote: Improve error handling during initialization. This fixes a crash when running out of grant refs when creating many queues across many netdevs. * Delay timer creation so that if initializing a queue

[PATCH] xen-netfront: Improve error handling during initialization

d-off-by: Ross Lagerwall --- drivers/net/xen-netfront.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 8315fe7..8ca85af 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers

Re: [Xen-devel] [PATCH 1/2] xen-blkfront: don't call talk_to_blkback when already connected to blkback

ux 4.5 and both of the patches in this series are backported to Linux 4.6. This is affecting Debian Testing (using Linux 4.6). It fails to recover its disk when resuming or migrating. Thanks, -- Ross Lagerwall

Re: [PATCH] xen: remove incorrect forward declaration

ation/SubmittingPatches is not clear about it. Regardless, the build fix should be backported to 4.4. -- Ross Lagerwall

[PATCH] xen/events: Don't move disabled irqs

rom_fork+0x3f/0x70 [] ? kthread_create_on_node+0x1e0/0x1e0 Signed-off-by: Ross Lagerwall --- drivers/xen/events/events_base.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index cb7138c..71d49a9 100644 --- a/

[PATCH v2] xen/balloon: Fix declared-but-not-defined warning

Fix a declared-but-not-defined warning when building with XEN_BALLOON_MEMORY_HOTPLUG=n. This fixes a regression introduced by commit dfd74a1edfab ("xen/balloon: Fix crash when ballooning on x86 32 bit PAE"). Signed-off-by: Ross Lagerwall --- v2: Moved function instead of adding a

Re: Build regressions/improvements in v4.6-rc7

LUG" preprocessor block. Thanks for figuring that out - I've sent a patch... Regards, -- Ross Lagerwall

[PATCH] xen/balloon: Fix declared-but-not-defined warning

Fix a declared-but-not-defined warning when building with XEN_BALLOON_MEMORY_HOTPLUG=n. This fixes a regression introduced by commit dfd74a1edfab ("xen/balloon: Fix crash when ballooning on x86 32 bit PAE"). Signed-off-by: Ross Lagerwall --- drivers/xen/balloon.c | 4 ++-- 1 file

[PATCH RESEND] partitions/msdos: Support relative offset BSD partitions

ncludes a cleanup to allow altering behavior based on the type of disklabel. The idea comes from the FreeBSD patch for GRUB: http://lists.freebsd.org/pipermail/freebsd-ports-bugs/2010-November/201081.html Signed-off-by: Ross Lagerwall --- block/partitions/msdos.c | 33 ++

[PATCH] partitions/msdos: Support relative offset BSD partitions

ncludes a cleanup to allow altering behavior based on the type of disklabel. The idea comes from the FreeBSD patch for GRUB: http://lists.freebsd.org/pipermail/freebsd-ports-bugs/2010-November/201081.html Signed-off-by: Ross Lagerwall --- block/partitions/msdos.c | 33 ++

[PATCH RESEND] efivarfs: Ensure VariableName is NUL-terminated

buggy firmware is: BIOS Information Vendor: Intel Corp. Version: S1200RP.86B.02.02.0005.102320140911 Release Date: 10/23/2014 BIOS Revision: 4.6 System Information Manufacturer: Intel Corporation Product Name: S1200RP_SE Signed-off-by: Ross Lagerwall

[PATCH] xen/manage: Fix USB interaction issues when resuming

0xc9/0xe0 [ 7441.276305] [] ? flush_kthread_worker+0x80/0x80 [ 7441.279131] [] ret_from_fork+0x7c/0xb0 [ 7441.281659] [] ? flush_kthread_worker+0x80/0x80 Signed-off-by: Ross Lagerwall --- drivers/xen/manage.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/xen/manage.c b/dri

Re: Mount propagation issue

On Mon, Sep 29, 2014 at 04:30:31PM -0700, Eric W. Biederman wrote: > Ross Lagerwall writes: > > I hope someone has an idea of what's going on or how to debug this > > because I've run out of ideas... > > My guess is that some process (systemd?) is configured

Hang in blkdev_get

xe0 [40455.060358] [] do_notify_resume+0x95/0xa0 [40455.060360] [] int_signal+0x12/0x17 [40455.060361] ---[ end trace e6961ef54dbee30c ]--- Can anyone shed light on the cause of these messages? They don't really cause a problem, other than udevd being blocked for the duration of the writin

Mount propagation issue

t of ideas... Thanks! -- Ross Lagerwall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Trailing slash with symlinks and rmdir/rename

though it names the directory pointed to by the symbolic link. So while Linux gives ENOTDIR for "rmdir X/", the others remove Y. Is this a bug? If it is, I can have a go at writing a patch. Regards -- Ross Lagerwall -- To unsubscribe from this list: send the line "unsubsc

[PATCH] tty/vt: Return EBUSY if deallocating VT1 and it is busy

Commit 421b40a6286e ("tty/vt: Fix vc_deallocate() lock order") changed the behavior when deallocating VT 1. Previously if trying to deallocate VT1 and it is busy, we would return EBUSY. The commit changed this to return 0 (success). This commit restores the old behavior. Signed-of

Possible tty VT1 disallocate regression

Hi, Ever since commit 421b40a6286e ("tty/vt: Fix vc_deallocate() lock order"), the first VT does not clear when I log out. AFAIK, this means that disallocation is not working? The problem only affects the first VT, the others clear when logging out. Regards -- Ross Lagerwall -- To u