[PATCH v2] power: supply: register HWMON devices with valid names

2019-08-30 Thread Romain Izard
tering with the HWMON framework. Other forbidden characters (star, slash, space, tab, newline) are not replaced, as they are not in common use. Fixes: e67d4dfc9ff1 ("power: supply: Add HWMON compatibility layer") Signed-off-by: Romain Izard Reviewed-by: Guenter Roeck --- v2: Remove a s

Re: [PATCH] power: supply: register HWMON devices with valid names

2019-08-23 Thread Romain Izard
On Thu, Aug 22, 2019 at 09:12:07AM -0700, Guenter Roeck wrote: > On Thu, Aug 22, 2019 at 05:09:19PM +0200, Romain Izard wrote: > > With the introduction of the HWMON compatibility layer to the power > > supply framework in Linux 5.3, all power supply devices' names can be

[PATCH] power: supply: register HWMON devices with valid names

2019-08-22 Thread Romain Izard
with the HWMON framework. Other forbidden characters (star, slash, space, tab, newline) are not replaced, as they are not in common use. Fixes: e67d4dfc9ff1 ("power: supply: Add HWMON compatibility layer") Signed-off-by: Romain Izard --- drivers/power/supply/power_supply_hwmon.c | 15 ++

Re: A potential broken at platform driver?

2019-06-04 Thread Romain Izard
the attributes will be different, as the child device will show up in the sysfs path. But for a newly introduced device this will not be a problem. Is this a good compromise ? Best regards, -- Romain Izard

Re: [PATCH v2 9/9] misc: atmel_tclib: do not probe already used TCBs

2019-04-17 Thread Romain Izard
lead to a panic during shutdown, as tc_shutdown is called on the device that has not been initialized and it has not been designed for this. -- Romain Izard

Re: [PATCH] ARM: dts: at91: sama5d2: use the divided clock for SMC

2018-11-20 Thread Romain Izard
Le mar. 20 nov. 2018 à 18:16, Alexandre Belloni a écrit : > > Hello Romain, > > On 20/11/2018 17:57:37+0100, Romain Izard wrote: > > The SAMA5D2 is different from SAMA5D3 and SAMA5D4, as there are two > > different clocks for the peripherals in the SoC. The Static

[PATCH] ARM: dts: at91: sama5d2: use the divided clock for SMC

2018-11-20 Thread Romain Izard
then used by the code for the NAND controller to calculate the timings for the controller, and we end up with slow NAND Flash access. Fix the device tree, and the performance of Flash access is improved. Signed-off-by: Romain Izard --- arch/arm/boot/dts/sama5d2.dtsi | 2 +- 1 file changed, 1

Re: [PATCH 2/2] watchdog: sama5d4: write the mode register in two steps

2018-09-17 Thread Romain Izard
2018-09-14 12:27 GMT+02:00 Alexandre Belloni : > On 14/09/2018 12:13:39+0200, Romain Izard wrote: >> The specification for SAMA5D2 and SAMA5D4 chips, that use this IP for >> their watchdog timer, has the following advice regarding the Mode Register: >> >> "When set

[PATCH 2/2] watchdog: sama5d4: write the mode register in two steps

2018-09-14 Thread Romain Izard
s into two parts if WDV or WDD need to be changed. Signed-off-by: Romain Izard --- drivers/watchdog/sama5d4_wdt.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c index 1e93c1b0e3cf..1e

[PATCH 0/2] Fixes for the SAMA5D2/SAMA5D4 watchdog

2018-09-14 Thread Romain Izard
to a watchdog reset immediately when opening the watchdog device. Fix this by respecting hardware constraints added in recent versions of the SAMA5D2 and SAMA5D4 datasheet. Romain Izard (2): watchdog: sama5d4: fix timeout-sec usage watchdog: sama5d4: write the mode register in two steps drivers/watchdo

[PATCH 1/2] watchdog: sama5d4: fix timeout-sec usage

2018-09-14 Thread Romain Izard
ecs provided in devicetree") Signed-off-by: Romain Izard --- drivers/watchdog/sama5d4_wdt.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c index 255169916dbb..1e93c1b0e3cf 100644 --- a/drivers/watchdog/sama5d4

[PATCH v2 2/3] usb: gadget: udc: atmel: Remove obsolete include

2018-05-11 Thread Romain Izard
The include defines the private platform_data structure used with AVR platforms. It has no user since 7c55984e191f. Remove it. Acked-by: Ludovic Desroches Acked-by: Nicolas Ferre Signed-off-by: Romain Izard --- drivers/usb/gadget/udc/atmel_usba_udc.c | 1 - include/linux/usb/atmel_usba_udc.h

[PATCH v2 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod

2018-05-11 Thread Romain Izard
re Signed-off-by: Romain Izard --- drivers/usb/gadget/udc/atmel_usba_udc.c | 3 +-- drivers/usb/gadget/udc/atmel_usba_udc.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 27c16399c7e8..0f

[PATCH v2 3/3] usb: gadget: udc: atmel: Fix indenting

2018-05-11 Thread Romain Izard
Fix the fallout of the conversion to GPIO descriptors in 3df034081021. Acked-by: Ludovic Desroches Acked-by: Nicolas Ferre Signed-off-by: Romain Izard --- drivers/usb/gadget/udc/atmel_usba_udc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/usb

[PATCH v2 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1

2018-05-11 Thread Romain Izard
the support of platform_data to declare USBA controllers. These changes have not been tested on any hardware, as I do not have a board that needs to use inverted GPIOs. -- Changes in v2: - Use the correct format for the "Fixes:" tag - Collect "Acked-by:" tags Romain Izar

[PATCH 2/3] usb: gadget: udc: atmel: Remove obsolete include

2018-04-16 Thread Romain Izard
The include defines the private platform_data structure used with AVR platforms. It has no user since 7c55984e191f. Remove it. Signed-off-by: Romain Izard --- drivers/usb/gadget/udc/atmel_usba_udc.c | 1 - include/linux/usb/atmel_usba_udc.h | 24 2 files changed

[PATCH 3/3] usb: gadget: udc: atmel: Fix indenting

2018-04-16 Thread Romain Izard
Fix the fallout of the conversion to GPIO descriptors in 3df034081021. Signed-off-by: Romain Izard --- drivers/usb/gadget/udc/atmel_usba_udc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc

[PATCH 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod

2018-04-16 Thread Romain Izard
When converting to GPIO descriptors, gpiod_get_value automatically handles the line inversion flags from the device tree. Do not invert the line twice. Fixes: 3df034081021fa4b6967ce3364bc7d867ec1c870 Signed-off-by: Romain Izard --- drivers/usb/gadget/udc/atmel_usba_udc.c | 3 +-- drivers/usb

[PATCH 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1

2018-04-16 Thread Romain Izard
the support of platform_data to declare USBA controllers. These changes have not been tested on any hardware, as I do not have a board that needs to use inverted GPIOs. Romain Izard (3): usb: gadget: udc: atmel: GPIO inversion is handled by gpiod usb: gadget: udc: atmel: Remove obsolete

[RFC PATCH] cdc-acm: do not drop data from fast devices

2018-03-05 Thread Romain Izard
drop it immediately. To prevent this problem, the URBs whose data did not reach the flip buffer are placed in a waiting list, which is only processed when the serial port is unthrottled. Signed-off-by: Romain Izard -- This is working when using the normal line discipline on ttyACM. But there is a

[PATCH RESEND] mtd: ubi: block: Fix error for write access

2018-03-02 Thread Romain Izard
veritysetup userspace tool is expecting EROFS, and refuses to use the ubiblock device. Use -EROFS for ubiblock as well. As a result, veritysetup accepts the ubiblock device as valid. Fixes: 9d54c8a33eec (UBI: R/O block driver on top of UBI volumes) Signed-off-by: Romain Izard --- drivers/mtd/ubi/block.c

[PATCH v1] mtd: ubi: block: Fix error for write access

2018-01-29 Thread Romain Izard
veritysetup userspace tool is expecting EROFS, and refuses to use the ubiblock device. Use -EROFS for ubiblock as well. As a result, veritysetup accepts the ubiblock device as valid. Fixes: 9d54c8a33eec (UBI: R/O block driver on top of UBI volumes) Signed-off-by: Romain Izard --- drivers/mtd/ubi/block.c

"perf record" leads to a watchdog reset on a SAMA5D2 SoC

2018-01-11 Thread Romain Izard
I'm not sure of how to interpret the issue. Is it because the CPU is too busy servicing the trace code during ticks to do anything else? Best regards, -- Romain Izard

[tip:timers/core] clocksource/drivers/tcb_clksrc: Fix clock speed message

2018-01-08 Thread tip-bot for Romain Izard
Commit-ID: 542f824607a6968ea443208ccfef3b7daf503559 Gitweb: https://git.kernel.org/tip/542f824607a6968ea443208ccfef3b7daf503559 Author: Romain Izard AuthorDate: Mon, 8 Jan 2018 14:28:43 +0100 Committer: Ingo Molnar CommitDate: Mon, 8 Jan 2018 17:57:23 +0100 clocksource/drivers

[PATCH v6] atmel_flexcom: Support resuming after a chip reset

2017-12-12 Thread Romain Izard
on resume. Signed-off-by: Romain Izard --- Changes in v5: * extract from the patch series, and send as a standalone patch Changes in v6: * Reword the patch title and description * Rename the internal structure to ddata drivers/mfd/atmel-flexcom.c | 63 ++-

[PATCH v6 1/3] clk: at91: pmc: Wait for clocks when resuming

2017-12-11 Thread Romain Izard
Wait for the syncronization of all clocks when resuming, not only the UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG() when interrupts are masked, which is the case in here. Signed-off-by: Romain Izard Acked-by: Ludovic Desroches Acked-by: Nicolas Ferre --- drivers/clk

[PATCH v6 3/3] clk: at91: pmc: Support backup for programmable clocks

2017-12-11 Thread Romain Izard
When an AT91 programmable clock is declared in the device tree, register it into the Power Management Controller driver. On entering suspend mode, the driver saves and restores the Programmable Clock registers to support the backup mode for these clocks. Signed-off-by: Romain Izard Acked-by

[PATCH v6 0/3] Clock patches for SAMA5D2 backup mode

2017-12-11 Thread Romain Izard
* improve comments on PMC clock handling Changes in v4: * fix a bug in the PMECC resume code Changes in v5: * drop all patches already taken * split the patch series by subsystem Changes in v6: * rebase on v4.15-rc3 Romain Izard (3): clk: at91: pmc: Wait for clocks when resuming clk: at91

[PATCH v6 2/3] clk: at91: pmc: Save SCSR during suspend

2017-12-11 Thread Romain Izard
clocks will be impacted. Fix the obvious typo in the suspend/resume code, as the IMR register does not need to be saved twice. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre --- drivers/clk/at91/pmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/at91

[PATCH v2] clocksource: tcb_clksrc: Fix clock speed message

2017-12-01 Thread Romain Izard
The clock speed displayed at boot in an information message was 500 kHz too high compared to its real value. As the value is not used anywhere, there is no functional impact. Fix the rounding formula to display the correct value. Signed-off-by: Romain Izard --- v2: rebase over v4.15-rc1 There

Re: [PATCH 2/2] crypto: atmel-aes - Reset the controller before each use

2017-11-06 Thread Romain Izard
2017-11-06 16:45 GMT+01:00 Tudor Ambarus : > Hi, Romain, > > On 10/31/2017 05:25 PM, Romain Izard wrote: >> >> When using the rfc4543(gcm(aes))) mode, the registers of the hardware >> engine are not empty after use. If the engine is not reset before its >> next u

[PATCH 1/2] crypto: atmel-aes - properly set IV after {en,de}crypt

2017-10-31 Thread Romain Izard
is now correctly passed. In the case of in-place decryption, copy the ciphertext in an intermediate buffer before decryption. Signed-off-by: Romain Izard --- drivers/crypto/atmel-aes.c | 40 +--- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/d

[PATCH 2/2] crypto: atmel-aes - Reset the controller before each use

2017-10-31 Thread Romain Izard
When using the rfc4543(gcm(aes))) mode, the registers of the hardware engine are not empty after use. If the engine is not reset before its next use, the following results will be invalid. Always reset the hardware engine. Signed-off-by: Romain Izard --- drivers/crypto/atmel-aes.c | 10

[PATCH 0/2] Fixes for the Atmel AES crypto module

2017-10-31 Thread Romain Izard
th the v4.14 updates, new asynchronous tests are enabled and report new issues. Romain Izard (2): crypto: atmel-aes - properly set IV after {en,de}crypt crypto: atmel-aes - Reset the controller before each use drivers/crypto/atmel-aes.c | 50 -- 1 file chan

[PATCH] crypto: ccm - preserve the IV buffer

2017-10-31 Thread Romain Izard
the hashing algorithm will interpret the updated IV instead of the original value, which can lead to out-of-bounds writes. Reuse the idata buffer, only used in the hashing step, to preserve the IV's value during the ciphering step in the decryption case. Signed-off-by: Romain Izard --- c

Re: [PATCH v5] atmel_flexcom: Support backup mode

2017-10-23 Thread Romain Izard
2017-10-23 18:07 GMT+02:00 Lee Jones : > On Mon, 23 Oct 2017, Lee Jones wrote: >> On Thu, 19 Oct 2017, Romain Izard wrote: >> >> > The controller used by a flexcom module is configured at boot, and left >> > alone after this. As the configuration will be lost af

Re: [PATCH] ARM: add a private asm/unaligned.h

2017-10-23 Thread Romain Izard
gned-off-by: Arnd Bergmann Tested-by: Romain.Izard Without this patch, the LZ4 decompression code is invalid in v4.14-rc6, when compiled with arm-linux-gnueabihf-gcc, version 7.2. The zImage does not start. With this patch, the decompression code is valid, and the kernel boots without a problem. No fixups are reported in /proc/cpu/alignment. -- Romain Izard

[PATCH v5] atmel_flexcom: Support backup mode

2017-10-19 Thread Romain Izard
The controller used by a flexcom module is configured at boot, and left alone after this. As the configuration will be lost after backup mode, restore the state of the flexcom driver on resume. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre Tested-by: Nicolas Ferre --- Changes in v5

[PATCH v5] pwm: atmel-tcb: Support backup mode

2017-10-19 Thread Romain Izard
Save and restore registers for the PWM on suspend and resume, which makes hibernation and backup modes possible. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre --- Changes in v5: * extract from the patch series, and send as a standalone patch drivers/pwm/pwm-atmel-tcb.c | 63

[PATCH v5 3/3] clk: at91: pmc: Support backup for programmable clocks

2017-10-19 Thread Romain Izard
From: Romain Izard When an AT91 programmable clock is declared in the device tree, register it into the Power Management Controller driver. On entering suspend mode, the driver saves and restores the Programmable Clock registers to support the backup mode for these clocks. Signed-off-by: Romain

[PATCH v5 2/3] clk: at91: pmc: Save SCSR during suspend

2017-10-19 Thread Romain Izard
clocks will be impacted. Fix the obvious typo in the suspend/resume code, as the IMR register does not need to be saved twice. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre --- drivers/clk/at91/pmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/at91

[PATCH v5 1/3] clk: at91: pmc: Wait for clocks when resuming

2017-10-19 Thread Romain Izard
Wait for the syncronization of all clocks when resuming, not only the UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG() when interrupts are masked, which is the case in here. Signed-off-by: Romain Izard Acked-by: Ludovic Desroches Acked-by: Nicolas Ferre --- drivers/clk

[PATCH v5 0/3] Clock patches for SAMA5D2 backup mode

2017-10-19 Thread Romain Izard
* improve comments on PMC clock handling Changes in v4: * fix a bug in the PMECC resume code Changes in v5: * drop all patches already taken * split the patch series by subsystem Romain Izard (8): clk: at91: pmc: Wait for clocks when resuming clk: at91: pmc: Save SCSR during suspend clk

Re: [PATCH] crypto: atmel-aes - properly set IV after {en,de}crypt

2017-10-10 Thread Romain Izard
abs.org/patch/821959/ I'll try it. -- Romain Izard

Re: [PATCH] crypto: atmel-aes - properly set IV after {en,de}crypt

2017-10-10 Thread Romain Izard
2017-10-06 17:51 GMT+02:00 Romain Izard : > > Certain cipher modes like CTS expect the IV (req->info) of > ablkcipher_request (or equivalently req->iv of skcipher_request) to > contain the last ciphertext block when the {en,de}crypt operation is done. > > Fix this issue fo

[PATCH] crypto: atmel-aes - properly set IV after {en,de}crypt

2017-10-06 Thread Romain Izard
is now correctly passed. To handle the case of in-place decryption, copy the ciphertext in an intermediate buffer before decryption. Signed-off-by: Romain Izard --- drivers/crypto/atmel-aes.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/crypto/atmel-a

[PATCH v4 2/8] clk: at91: pmc: Save SCSR during suspend

2017-09-28 Thread Romain Izard
clocks will be impacted. Fix the obvious typo in the suspend/resume code, as the IMR register does not need to be saved twice. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre --- drivers/clk/at91/pmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/at91

[PATCH v4 3/8] clk: at91: pmc: Support backup for programmable clocks

2017-09-28 Thread Romain Izard
From: Romain Izard When an AT91 programmable clock is declared in the device tree, register it into the Power Management Controller driver. On entering suspend mode, the driver saves and restores the Programmable Clock registers to support the backup mode for these clocks. Signed-off-by: Romain

[PATCH v4 4/8] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

2017-09-28 Thread Romain Izard
ff-by: Romain Izard --- Changes in v3: * keep the PMECC disabled when not in use, and use atmel_pmecc_resume to reset the controller after the bootloader has left it enabled. Changes in v4: * export atmel_pmecc_reset instead of atmel_pmecc_resume * use the correct pointer in atmel_nand_controller_r

[PATCH v4 0/8] Various patches for SAMA5D2 backup mode

2017-09-28 Thread Romain Izard
variable in the tty/serial patch Changes in v3: * drop dev_printk changes for PMECC * rework the resume code for PMECC * improve comments on PMC clock handling Changes in v4: * fix a bug in the PMECC resume code Romain Izard (8): clk: at91: pmc: Wait for clocks when resuming clk: at91: pmc

[PATCH v4 7/8] atmel_flexcom: Support backup mode

2017-09-28 Thread Romain Izard
The controller used by a flexcom module is configured at boot, and left alone after this. As the configuration will be lost after backup mode, restore the state of the flexcom driver on resume. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre Tested-by: Nicolas Ferre --- drivers/mfd/atmel

[PATCH v4 5/8] ehci-atmel: Power down during suspend is normal

2017-09-28 Thread Romain Izard
When an Atmel SoC is suspended with the backup mode, the USB bus will be powered down. As this is expected, do not return an error to the driver core when ehci_resume detects it. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre --- drivers/usb/host/ehci-atmel.c | 3 ++- 1 file changed, 2

[PATCH v4 1/8] clk: at91: pmc: Wait for clocks when resuming

2017-09-28 Thread Romain Izard
Wait for the syncronization of all clocks when resuming, not only the UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG() when interrupts are masked, which is the case in here. Signed-off-by: Romain Izard Acked-by: Ludovic Desroches Acked-by: Nicolas Ferre --- drivers/clk

[PATCH v4 8/8] tty/serial: atmel: Prevent a warning on suspend

2017-09-28 Thread Romain Izard
rt_suspend_port disappears, and suspending is 20ms shorter for each enabled Atmel serial port. Signed-off-by: Romain Izard Tested-by: Nicolas Ferre Acked-by: Nicolas Ferre Acked-by: Richard Genoud --- drivers/tty/serial/atmel_serial.c | 13 + 1 file changed, 13 insertions(+) diff --gi

[PATCH v4 6/8] pwm: atmel-tcb: Support backup mode

2017-09-28 Thread Romain Izard
Save and restore registers for the PWM on suspend and resume, which makes hibernation and backup modes possible. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre --- drivers/pwm/pwm-atmel-tcb.c | 63 +++-- 1 file changed, 61 insertions(+), 2 deletions

Re: [PATCH v3 4/8] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

2017-09-27 Thread Romain Izard
2017-09-27 17:08 GMT+02:00 Boris Brezillon : > On Wed, 27 Sep 2017 10:35:51 +0200 > Romain Izard wrote: > >> During backup mode, the contents of all registers will be cleared as the >> SoC will be completely powered down. For a product that boots on NAND >> Flash

[PATCH v3 3/8] clk: at91: pmc: Support backup for programmable clocks

2017-09-27 Thread Romain Izard
From: Romain Izard When an AT91 programmable clock is declared in the device tree, register it into the Power Management Controller driver. On entering suspend mode, the driver saves and restores the Programmable Clock registers to support the backup mode for these clocks. Signed-off-by: Romain

[PATCH v3 2/8] clk: at91: pmc: Save SCSR during suspend

2017-09-27 Thread Romain Izard
clocks will be impacted. Fix the obvious typo in the suspend/resume code, as the IMR register does not need to be saved twice. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre --- drivers/clk/at91/pmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/at91

[PATCH v3 0/8] Various patches for SAMA5D2 backup mode

2017-09-27 Thread Romain Izard
variable in the tty/serial patch Changes in v3: * drop dev_printk changes for PMECC * rework the resume code for PMECC * improve comments on PMC clock handling Romain Izard (8): clk: at91: pmc: Wait for clocks when resuming clk: at91: pmc: Save SCSR during suspend clk: at91: pmc: Support

[PATCH v3 5/8] ehci-atmel: Power down during suspend is normal

2017-09-27 Thread Romain Izard
When an Atmel SoC is suspended with the backup mode, the USB bus will be powered down. As this is expected, do not return an error to the driver core when ehci_resume detects it. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre --- drivers/usb/host/ehci-atmel.c | 3 ++- 1 file changed, 2

[PATCH v3 4/8] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

2017-09-27 Thread Romain Izard
ff-by: Romain Izard --- Change in v3: * keep the PMECC disabled when not in use, and use atmel_pmecc_resume to reset the controller after the bootloader has left it enabled. drivers/mtd/nand/atmel/nand-controller.c | 3 +++ drivers/mtd/nand/atmel/pmecc.c | 22 ++ dr

[PATCH v3 6/8] pwm: atmel-tcb: Support backup mode

2017-09-27 Thread Romain Izard
Save and restore registers for the PWM on suspend and resume, which makes hibernation and backup modes possible. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre --- drivers/pwm/pwm-atmel-tcb.c | 63 +++-- 1 file changed, 61 insertions(+), 2 deletions

[PATCH v3 8/8] tty/serial: atmel: Prevent a warning on suspend

2017-09-27 Thread Romain Izard
rt_suspend_port disappears, and suspending is 20ms shorter for each enabled Atmel serial port. Signed-off-by: Romain Izard Tested-by: Nicolas Ferre Acked-by: Nicolas Ferre Acked-by: Richard Genoud --- drivers/tty/serial/atmel_serial.c | 13 + 1 file changed, 13 insertions(+) diff --gi

[PATCH v3 7/8] atmel_flexcom: Support backup mode

2017-09-27 Thread Romain Izard
The controller used by a flexcom module is configured at boot, and left alone after this. As the configuration will be lost after backup mode, restore the state of the flexcom driver on resume. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre Tested-by: Nicolas Ferre --- drivers/mfd/atmel

[PATCH v3 1/8] clk: at91: pmc: Wait for clocks when resuming

2017-09-27 Thread Romain Izard
Wait for the syncronization of all clocks when resuming, not only the UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG() when interrupts are masked, which is the case in here. Signed-off-by: Romain Izard Acked-by: Ludovic Desroches Acked-by: Nicolas Ferre --- drivers/clk

Re: [PATCH v2 3/9] clk: at91: pmc: Support backup for programmable clocks

2017-09-25 Thread Romain Izard
2017-09-22 12:31 GMT+02:00 Nicolas Ferre : > On 15/09/2017 at 16:04, Romain Izard wrote: >> From: Romain Izard >> >> When an AT91 programmable clock is declared in the device tree, register >> it into the Power Management Controller driver. On entering suspend mo

Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors

2017-09-21 Thread Romain Izard
2017-09-18 12:00 GMT+02:00 Boris Brezillon : > Hi Romain, > > On Fri, 15 Sep 2017 16:04:07 +0200 > Romain Izard wrote: > >> It is not normal for the PMECC to fail when trying to fix ECC errors. >> Report these cases as errors. > > I'm not sure we want to have

[PATCH] ARM: unaligned.h: Use an arch-specific version

2017-09-20 Thread Romain Izard
header to ARM, to retain other optimizations that rely on HAVE_EFFICIENT_UNALIGNED_ACCESS, while making sure that access that explicitly rely on the unaligned accessors are correctly handled by the compiler. Signed-off-by: Romain Izard --- This is a follow-up to this discussion

Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode

2017-09-20 Thread Romain Izard
2017-09-19 17:25 GMT+02:00 Lee Jones : > On Tue, 19 Sep 2017, Nicolas Ferre wrote: > >> On 15/09/2017 at 16:04, Romain Izard wrote: >> > The controller used by a flexcom module is configured at boot, and left >> > alone after this. As the configuration will be lost a

[PATCH v2 1/9] clk: at91: pmc: Wait for clocks when resuming

2017-09-15 Thread Romain Izard
Wait for the syncronization of all clocks when resuming, not only the UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG() when interrupts are masked, which is the case in here. Signed-off-by: Romain Izard --- drivers/clk/at91/pmc.c | 24 1 file

[PATCH v2 2/9] clk: at91: pmc: Save SCSR during suspend

2017-09-15 Thread Romain Izard
clocks will be impacted. Fix the obvious typo in the suspend/resume code, as the IMR register does not need to be saved twice. Signed-off-by: Romain Izard Acked-by: Nicolas Ferre --- drivers/clk/at91/pmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/at91

[PATCH v2 3/9] clk: at91: pmc: Support backup for programmable clocks

2017-09-15 Thread Romain Izard
From: Romain Izard When an AT91 programmable clock is declared in the device tree, register it into the Power Management Controller driver. On entering suspend mode, the driver saves and restores the Programmable Clock registers to support the backup mode for these clocks. Signed-off-by: Romain

[PATCH v2 7/9] pwm: atmel-tcb: Support backup mode

2017-09-15 Thread Romain Izard
Save and restore registers for the PWM on suspend and resume, which makes hibernation and backup modes possible. Signed-off-by: Romain Izard --- drivers/pwm/pwm-atmel-tcb.c | 63 +++-- 1 file changed, 61 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 9/9] tty/serial: atmel: Prevent a warning on suspend

2017-09-15 Thread Romain Izard
rt_suspend_port disappears, and suspending is 20ms shorter for each enabled Atmel serial port. Signed-off-by: Romain Izard --- drivers/tty/serial/atmel_serial.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c ind

[PATCH v2 8/9] atmel_flexcom: Support backup mode

2017-09-15 Thread Romain Izard
The controller used by a flexcom module is configured at boot, and left alone after this. As the configuration will be lost after backup mode, restore the state of the flexcom driver on resume. Signed-off-by: Romain Izard --- drivers/mfd/atmel-flexcom.c | 65

[PATCH v2 6/9] ehci-atmel: Power down during suspend is normal

2017-09-15 Thread Romain Izard
When an Atmel SoC is suspended with the backup mode, the USB bus will be powered down. As this is expected, do not return an error to the driver core when ehci_resume detects it. Signed-off-by: Romain Izard --- drivers/usb/host/ehci-atmel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors

2017-09-15 Thread Romain Izard
It is not normal for the PMECC to fail when trying to fix ECC errors. Report these cases as errors. Signed-off-by: Romain Izard --- drivers/mtd/nand/atmel/pmecc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel

[PATCH v2 4/9] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

2017-09-15 Thread Romain Izard
ematically reset the PMECC controller before using it. Signed-off-by: Romain Izard --- drivers/mtd/nand/atmel/pmecc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c index 8c210a5776bc..8d1208f38025 10

[PATCH v2 0/9] Various patches for SAMA5D2 backup mode

2017-09-15 Thread Romain Izard
a week without hanging. Changes in v2: * drop the IIO patch duplicating existing code * determine the number of programmable clocks to save dynamically * declare a required local variable in the tty/serial patch Romain Izard (9): clk: at91: pmc: Wait for clocks when resuming clk: at91: pmc

Re: [PATCH v1 01/10] clk: at91: pmc: Wait for clocks when resuming

2017-09-14 Thread Romain Izard
2017-09-13 14:15 GMT+02:00 Nicolas Ferre : > On 08/09/2017 at 17:35, Romain Izard wrote: >> Wait for the syncronization of all clocks when resuming, not only the >> UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG() >> when interrupts are masked, whic

Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks

2017-09-14 Thread romain izard
2017-09-13 19:03 GMT+02:00 Alexandre Belloni : > On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote: >> On 08/09/2017 at 17:35, Romain Izard wrote: >> > From: Romain Izard >> > >> > Save and restore the System Clock and Programmable Clock register for >

Re: [PATCH v1 10/10] tty/serial: atmel: Prevent a warning on suspend

2017-09-11 Thread Romain Izard
2017-09-08 17:36 GMT+02:00 Romain Izard : > The atmel serial port driver reported the following warning on suspend: > atmel_usart f802.serial: ttyS1: Unable to drain transmitter > > As the ATMEL_US_TXEMPTY status bit in ATMEL_US_CSR is always cleared > when the transmitter is di

Re: [PATCH v1 07/10] iio:adc:at91-sama5d2: Support backup mode

2017-09-08 Thread Romain Izard
2017-09-08 18:03 GMT+02:00 Nicolas Ferre : > On 08/09/2017 at 17:36, Romain Izard wrote: >> Support the backup mode for platform suspend, by restoring the hardware >> registers on resume. >> >> Signed-off-by: Romain Izard > > Romain, > > Thanks for your se

[PATCH v1 02/10] clk: at91: pmc: Save SCSR during suspend

2017-09-08 Thread Romain Izard
clocks will be impacted. Fix the obvious typo in the suspend/resume code, as the IMR register does not need to be saved twice. Signed-off-by: Romain Izard --- drivers/clk/at91/pmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91

[PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks

2017-09-08 Thread Romain Izard
From: Romain Izard Save and restore the System Clock and Programmable Clock register for the backup use case. Signed-off-by: Romain Izard --- drivers/clk/at91/pmc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c index 07dc2861ad3f

[PATCH v1 01/10] clk: at91: pmc: Wait for clocks when resuming

2017-09-08 Thread Romain Izard
Wait for the syncronization of all clocks when resuming, not only the UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG() when interrupts are masked, which is the case in here. Signed-off-by: Romain Izard --- drivers/clk/at91/pmc.c | 24 1 file

[PATCH v1 05/10] mtd: nand: atmel: Report PMECC failures as errors

2017-09-08 Thread Romain Izard
It is not normal for the PMECC to fail when trying to fix ECC errors. Report these cases as errors. Signed-off-by: Romain Izard --- drivers/mtd/nand/atmel/pmecc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel

[PATCH v1 06/10] ehci-atmel: Power down during suspend is normal

2017-09-08 Thread Romain Izard
When an Atmel SoC is suspended with the backup mode, the USB bus will be powered down. As this is expected, do not return an error to the driver core when ehci_resume detects it. Signed-off-by: Romain Izard --- drivers/usb/host/ehci-atmel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH v1 10/10] tty/serial: atmel: Prevent a warning on suspend

2017-09-08 Thread Romain Izard
rt_suspend_port disappears, and suspending is 20ms shorter for each enabled Atmel serial port. Signed-off-by: Romain Izard --- drivers/tty/serial/atmel_serial.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c ind

[PATCH v1 08/10] pwm: atmel-tcb: Support backup mode

2017-09-08 Thread Romain Izard
Save and restore registers for the PWM on suspend and resume, which makes hibernation and backup modes possible. Signed-off-by: Romain Izard --- drivers/pwm/pwm-atmel-tcb.c | 63 +++-- 1 file changed, 61 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v1 04/10] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

2017-09-08 Thread Romain Izard
ematically reset the PMECC controller before using it. Signed-off-by: Romain Izard --- drivers/mtd/nand/atmel/pmecc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c index 8c210a5776bc..8d1208f38025 10

[PATCH v1 09/10] atmel_flexcom: Support backup mode

2017-09-08 Thread Romain Izard
The controller used by a flexcom module is configured at boot, and left alone after this. As the configuration will be lost after backup mode, restore the state of the flexcom driver on resume. Signed-off-by: Romain Izard --- drivers/mfd/atmel-flexcom.c | 65

[PATCH v1 07/10] iio:adc:at91-sama5d2: Support backup mode

2017-09-08 Thread Romain Izard
Support the backup mode for platform suspend, by restoring the hardware registers on resume. Signed-off-by: Romain Izard --- drivers/iio/adc/at91-sama5d2_adc.c | 71 -- 1 file changed, 61 insertions(+), 10 deletions(-) diff --git a/drivers/iio/adc/at91

[PATCH v1 00/10] Various patches for SAMA5D2 backup mode

2017-09-08 Thread Romain Izard
a week without hanging. Romain Izard (10): clk: at91: pmc: Wait for clocks when resuming clk: at91: pmc: Save SCSR during suspend clk: at91: pmc: Support backup for programmable clocks mtd: nand: atmel: Avoid ECC errors when leaving backup mode mtd: nand: atmel: Report PMECC failures as

HAVE_EFFICIENT_UNALIGNED_ACCESS on ARM32 (was: Alignment issues in zImage with Linux 4.12, LZ4 and GCC5.3)

2017-09-04 Thread Romain Izard
2017-07-24 13:07 GMT+02:00 Ard Biesheuvel : > On 24 July 2017 at 11:57, Romain Izard wrote: >> >> While upgrading the kernel from 4.9 to 4.12 for a custom board with a >> Cortex-A5 based CPU, I have encountered a compilation issue that leads to >> a data abort duri

Re: [PATCH 1/3] ARM: at91: pm: Add sama5d2 backup mode

2017-04-27 Thread Romain Izard
; > /* > * void at91_sramc_self_refresh(unsigned int is_active) > @@ -314,6 +358,10 @@ ENDPROC(at91_sramc_self_refresh) > .word 0 > .sramc1_base: > .word 0 > +.shdwc: > + .word 0 > +.sfr: > + .word 0 > .memtype: > .word 0 > .pm_mode: > diff --git a/arch/arm/mach-at91/sama5.c b/arch/arm/mach-at91/sama5.c > index 6d157d0ead8e..3d0bf95a56ae 100644 > --- a/arch/arm/mach-at91/sama5.c > +++ b/arch/arm/mach-at91/sama5.c > @@ -34,7 +34,6 @@ DT_MACHINE_START(sama5_dt, "Atmel SAMA5") > MACHINE_END > > static const char *const sama5_alt_dt_board_compat[] __initconst = { > - "atmel,sama5d2", > "atmel,sama5d4", > NULL > }; > @@ -45,3 +44,21 @@ DT_MACHINE_START(sama5_alt_dt, "Atmel SAMA5") > .dt_compat = sama5_alt_dt_board_compat, > .l2c_aux_mask = ~0UL, > MACHINE_END > + > +static void __init sama5d2_init(void) > +{ > + of_platform_default_populate(NULL, NULL, NULL); > + sama5d2_pm_init(); > +} > + > +static const char *const sama5d2_compat[] __initconst = { > + "atmel,sama5d2", > + NULL > +}; > + > +DT_MACHINE_START(sama5d2, "Atmel SAMA5") > + /* Maintainer: Atmel */ > + .init_machine = sama5d2_init, > + .dt_compat = sama5d2_compat, > + .l2c_aux_mask = ~0UL, > +MACHINE_END Best regards, -- Romain Izard

Re: [PATCH v1] usb: gadget: udc: atmel: Remove an unused local variable

2017-03-10 Thread Romain Izard
2017-03-09 18:02 GMT+01:00 Romain Izard : > The local variable ept_cfg is not used anymore in usba_ep_enable. > Use ep->ept_cfg in the debug function to remove a warning when building > with dynamic debug enabled. > > Signed-off-by: Romain Izard > Fixes: 741d2558bf0a (&qu

[PATCH v3 2/2] usb: gadget: reword configuration choices

2017-03-10 Thread Romain Izard
not the only way to provice service as an USB gadget. Signed-off-by: Romain Izard --- Changes in v3: - split from the functional patch drivers/usb/gadget/Kconfig | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfi

[PATCH v3 0/2] Various cleanups for USB Gadget Kconfig

2017-03-10 Thread Romain Izard
Fix some issues left when the configuration was updated to support a built-in USB gadget configfs together with modular legacy gadget drivers. Changes in v2: - Reword description Changes in v3: - Split functional and comment changes Romain Izard (2): usb: gadget: legacy gadgets are optional

[PATCH v3 1/2] usb: gadget: legacy gadgets are optional

2017-03-10 Thread Romain Izard
gacy gadgets") Cc: # 4.9+ Signed-off-by: Romain Izard --- Changes in v2: - Reword description Changes in v3: - Remove comment changes drivers/usb/gadget/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 8ad203296

  1   2   >