Re: [PATCH] clocksource: Add heuristics to avoid switching away from TSC due to timer delay

2018-12-04 Thread Roland Dreier
> /* > * Proper multiline comments look like this not like > * the above. > */ Got it, will fix next time around. > That aside. Why are you trying to do heuristics on the delta? > > We have way better information than that. Th

[tip:x86/timers] x86/hpet: Remove unused FSEC_PER_NSEC define

2018-12-04 Thread tip-bot for Roland Dreier
Commit-ID: d999c0ec2498e54b9328db6b2c1037710025add1 Gitweb: https://git.kernel.org/tip/d999c0ec2498e54b9328db6b2c1037710025add1 Author: Roland Dreier AuthorDate: Fri, 30 Nov 2018 13:14:50 -0800 Committer: Borislav Petkov CommitDate: Tue, 4 Dec 2018 12:17:21 +0100 x86/hpet: Remove

[PATCH] x86/hpet: Remove unused FSEC_PER_NSEC define

2018-12-04 Thread Roland Dreier
The FSEC_PER_NSEC macro has had zero users since commit ab0e08f15d23 ("x86: hpet: Cleanup the clockevents init and register code"). Signed-off-by: Roland Dreier --- arch/x86/kernel/hpet.c | 4 1 file changed, 4 deletions(-) diff --git a/arch/x86/kernel/hpet.c b/arch/x86/ker

[PATCH] clocksource: Add heuristics to avoid switching away from TSC due to timer delay

2018-11-30 Thread Roland Dreier
le leaving detection of true instability very likely within a few clocksource watchdog iterations. Signed-off-by: Roland Dreier --- kernel/time/clocksource.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/kernel/time/clocksource.c b/kernel/time/clocksour

[PATCH] x86/hpet: Remove unused FSEC_PER_NSEC define

2018-11-30 Thread Roland Dreier
The FSEC_PER_NSEC macro has had zero users since commit ab0e08f15d23 ("x86: hpet: Cleanup the clockevents init and register code"). Signed-off-by: Roland Dreier --- arch/x86/kernel/hpet.c | 4 1 file changed, 4 deletions(-) diff --git a/arch/x86/kernel/hpet.c b/arch/x86/ker

Re: [PATCH 0/3] Provide more fine grained control over multipathing

2018-06-05 Thread Roland Dreier
> The sensible thing to do in nvme is to use different paths for > different queues. That is e.g. in the RDMA case use the HCA closer > to a given CPU by default. We might allow to override this for > cases where the is a good reason, but what I really don't want is > configurability for configur

Re: [PATCH 0/3] Provide more fine grained control over multipathing

2018-06-04 Thread Roland Dreier
> Moreover, I also wanted to point out that fabrics array vendors are > building products that rely on standard nvme multipathing (and probably > multipathing over dispersed namespaces as well), and keeping a knob that > will keep nvme users with dm-multipath will probably not help them > educate t

Re: KASAN: use-after-free Read in __list_add_valid (5)

2018-05-15 Thread Roland Dreier
> Still reproducible on Linus' tree (commit 66e1c94db3cd4e) and on linux-next > (next-20180511). Here's a simplified reproducer: Thanks! That's a fantastic test case. The issue is a race where rdma_listen() sees invalid state in the middle of an rdma_bind_addr() call that will ultimately fail.

Re: [Patch v2 00/19] CIFS: Implement SMBDirect

2017-08-29 Thread Roland Dreier
> Starting with SMB2 dialect 3.0, Microsoft introduced SMBDirect transport > protocol for transferring upper layer (SMB2) payload over RDMA via > Infiniband, RoCE or iWARP. The prococol is published in [MS-SMBD] > (https://msdn.microsoft.com/en-us/library/hh536346.aspx). This is great to see.

Re: Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation

2016-07-08 Thread Roland Dreier
On Fri, Jul 8, 2016 at 9:51 AM, Jason Gunthorpe wrote: > So, it appears, the dst and neigh can be used for all performances cases. > > For the non performance dst == null case, can we just burn cycles and > stuff the daddr in front of the packet at hardheader time, even if we > have to copy? OK,

Re: Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation

2016-07-08 Thread Roland Dreier
On Thu, Jul 7, 2016 at 4:14 PM, Jason Gunthorpe wrote: > We have neighbour_priv, and ndo_neigh_construct/destruct now .. > > A first blush that would seem to be enough to let ipoib store the AH > and other path information in the neigh and avoid the cb? At least the > example in clip sure looks li

Re: Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation

2016-07-07 Thread Roland Dreier
>> struct skb_gso_cb { >> int mac_offset; >> int encap_level; >> __u16 csum_start; >> }; > This is based on an out-dated version of this struct. The 4.7 RC > kernel has a few more fields that were added to support local checksum > offload for encapsulated frames.

Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation

2016-07-06 Thread Roland Dreier
On Thu, Jan 7, 2016 at 3:00 AM, Konstantin Khlebnikov wrote: > Or just shift GSO CB and add couple checks like > BUILD_BUG_ON(sizeof(SKB_GSO_CB(skb)->room) < sizeof(*IPCB(skb))); Resurrecting this old thread, because the patch that ultimately went upstream (commit 9207f9d45b0a / net: preserve IP

[PATCH] iommu/vt-d: Don't reject NTB devices due to scope mismatch

2016-06-02 Thread Roland Dreier
From: Roland Dreier On a system with an Intel PCIe port configured as an NTB device, iommu initialization fails with DMAR: Device scope type does not match for :80:03.0 This is because the DMAR table reports this device as having scope 2 (ACPI_DMAR_SCOPE_TYPE_BRIDGE): [0A0h 0160

Re: Regression in IO resource allocation

2016-06-01 Thread Roland Dreier
On Tue, May 31, 2016 at 3:31 PM, Rafael J. Wysocki wrote: > It may not be called at all if _PTC is used on that system, for example. Yes, that's exactly the case on my system. So from my POV: Tested-by: Roland Dreier Thanks!

Re: Regression in IO resource allocation

2016-05-31 Thread Roland Dreier
On Tue, May 31, 2016 at 2:11 PM, Rafael J. Wysocki wrote: > Can you please try the appended patch (untested)? Thanks for the quick reply. Patch looks OK on my system... it boots (which is very good :) and I see system 00:01: [io 0x0400-0x047f] has been reserved however I don't see the "AC

Regression in IO resource allocation

2016-05-31 Thread Roland Dreier
Hi, I recently updated one of my systems from 3.10.y to 4.4.11, and discovered a regression that stops it from booting. It's actually very similar to https://bugzilla.kernel.org/show_bug.cgi?id=99831 (which I reported about the same system last year). The problem is that commit ac212b6980d8 ("AC

Re: Running out of IO space because of innocuous-looking DSDT change

2015-10-19 Thread Roland Dreier
On Mon, Oct 19, 2015 at 10:00 AM, Yinghai Lu wrote: > I would suggest to expand standard_io_resources[] to include all > possible conflict that we should avoid, like the io port for serial and > cf8/cf9. > > Then we could just set PCIBIOS_MIN_IO to 0 for x86. That would work on my system, which

Running out of IO space because of innocuous-looking DSDT change

2015-10-19 Thread Roland Dreier
I recently ran into an interesting issue with IO space allocation, and I'm looking for opinions on whether this is a BIOS issue, a kernel issue, both, or neither ;) What happened is that a BIOS update for my system changed the DSDT from having three ranges in PCI0: WordIO (ResourceProduce

Re: [PATCH] target/iscsi: fix digest computation for chained SGs

2015-07-21 Thread Roland Dreier
On Tue, Jul 21, 2015 at 1:57 AM, Sagi Grimberg wrote: > How were you able to get a chained SG list in the target code? Local hack. So this bug can't be hit in current mainline code, but patch improves the code and removes a hidden booby-trap, so I think it makes sense to apply. -- To unsubscribe

Re: Regression in 3.10.80 vs. 3.10.79

2015-06-15 Thread Roland Dreier
On Sat, Jun 13, 2015 at 9:56 AM, Roland Dreier wrote: > Below is a more sophisticated, so to speak, version of it with a changelog and > all. It works for me, but more testing would be much appreciated. Yes, the patch works as expected: Tested-by: Roland Dreier It does change /proc/i

Re: Regression in 3.10.80 vs. 3.10.79

2015-06-13 Thread Roland Dreier
On Fri, Jun 12, 2015 at 7:52 PM, Rafael J. Wysocki wrote: > Below is a more sophisticated, so to speak, version of it with a changelog and > all. It works for me, but more testing would be much appreciated. Great, I'm convinced by your reasoning that this makes sense. I'm building 3.10.80 patch

Re: Regression in 3.10.80 vs. 3.10.79

2015-06-12 Thread Roland Dreier
On Thu, Jun 11, 2015 at 1:50 PM, Rafael J. Wysocki wrote: > Changing the ordering between those two routines would work around that > problem, > but in my view that wouldn't be a proper fix. In fact, the role of > reserve_range() > is to reserve the resources so as to prevent them from being us

Re: Regression in 3.10.80 vs. 3.10.79

2015-06-11 Thread Roland Dreier
On Wed, Jun 10, 2015 at 4:23 PM, Rafael J. Wysocki wrote: > Can you please file a bug at bugzilla.kernel.org to track this and attach > the output of acpidump from the affected system in there? Done: https://bugzilla.kernel.org/show_bug.cgi?id=99831 Thanks! -- To unsubscribe from this list: send

Re: Regression in 3.10.80 vs. 3.10.79

2015-06-09 Thread Roland Dreier
On Tue, Jun 9, 2015 at 4:43 PM, Roland Dreier wrote: > I understand that the change here fixed another regression, but I'm > wondering if there's a way to make everyone happy here? I can provide > debugging info from my system as required... Maybe sent my mail too quic

Regression in 3.10.80 vs. 3.10.79

2015-06-09 Thread Roland Dreier
Hi, I recently updated from 3.10.79 to 3.10.80, and my system wouldn't boot any more. I tracked this down to commit 92c934b10ec3 ("ACPI / init: Fix the ordering of acpi_reserve_resources()"). With that commit reverted, my system is OK again. What happens is that ahci fails to initialize because

[GIT PULL] please pull infiniband.git

2015-04-22 Thread Roland Dreier
Hi Linus, Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus InfiniBand/RDMA updates for 4.1: - IPoIB fixes from Doug Ledford and Erez Shitrit - iSER updates from Sagi Gr

Re: [PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib

2015-04-16 Thread Roland Dreier
On Thu, Apr 16, 2015 at 9:44 AM, Jason Gunthorpe wrote: >> We can give client->add() callback a return value and make >> ib_register_device() return -ENOMEM when it failed, just wondering >> why we don't do this at first, any special reason? > No idea, but having ib_register_device fail and unwin

[GIT PULL] please pull infiniband.git

2015-04-02 Thread Roland Dreier
Hi Linus, Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus One 4.0 RDMA change: - Fix for exploitable integer overflow in uverbs interface.

[GIT PULL] please pull infiniband.git

2015-02-20 Thread Roland Dreier
c generate better code for ocrdma_srq_toggle_bit RDMA/ocrdma: Use unsigned for bit index Rickard Strandqvist (1): IB/ipath: Remove unused function in ipath_wc_ppc64 Roi Dayan (1): IB/iser: Use correct dma direction when unmapping SGs Roland Dreier (1): Merge branches 

Re: linux-next: build failure after merge of the infiniband tree

2015-02-17 Thread Roland Dreier
On Tue, Feb 17, 2015 at 6:32 PM, Stephen Rothwell wrote: > After merging the livepatching tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > In file included from drivers/infiniband/hw/qib/qib_cq.c:41:0: > drivers/infiniband/hw/qib/qib.h: In function 'qib_flush_wc': > dr

Re: [PATCH 1/1] IB/mthca: remove deprecated use of pci api

2015-02-17 Thread Roland Dreier
On Wed, Feb 4, 2015 at 6:09 AM, Quentin Lambert wrote: > - dev->eq_table.icm_dma = pci_map_page(dev->pdev, > dev->eq_table.icm_page, 0, > - PAGE_SIZE, > PCI_DMA_BIDIRECTIONAL); > - if (pci_dma_mapping_error(dev->pdev, dev->eq_table.icm_dma

[GIT PULL] please pull infiniband.git

2015-02-06 Thread Roland Dreier
Hi Linus, Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus One more last-second RDMA change for 3.19: - Yann realized that the previous revert of new userspace ABI did n

[GIT PULL] please pull infiniband.git

2015-02-03 Thread Roland Dreier
her than freeze something in a rush and make a mistake, we'll take a bit more time and get it right in 3.20. Haggai Eran (1): IB/core: Temporarily disable ex_query_device uverb Roland Dreier (9): Revert "IPoIB:

[GIT PULL] please pull infiniband.git

2014-12-18 Thread Roland Dreier
Or Kehati (1): IB/addr: Improve address resolution callback scheduling Pramod Kumar (2): RDMA/cxgb4: Increase epd buff size for debug interface RDMA/cxgb4: Configure 0B MRs to match HW implementation Roland Dreier (2): mlx5_core: Re-add MLX5_DEV_CAP_FLAG_ON_DMND_PG flag

Re: linux-next: build failure after merge of the infiniband tree

2014-12-15 Thread Roland Dreier
On Mon, Dec 15, 2014 at 5:56 PM, Roland Dreier wrote: > I'll add a partial revert of that patch to my tree to get back the > now-used enum values. I rebased my tree on top of the merge-window merge of davem's tree, and added the missing flag on top of the "remove this flag&

Re: linux-next: build failure after merge of the infiniband tree

2014-12-15 Thread Roland Dreier
On Mon, Dec 15, 2014 at 5:47 PM, Stephen Rothwell wrote: > Hi all, > > After merging the infiniband tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/infiniband/hw/mlx5/main.c: In function 'mlx5_ib_query_device': > drivers/infiniband/hw/mlx5/main.c:248:34: error:

[GIT PULL] please pull infiniband.git

2014-10-16 Thread Roland Dreier
IB/iser: Remove unused variables and dead code Roland Dreier (1): Merge branches 'core', 'cxgb4', 'iser', 'mlx5' and 'ocrdma' into for-next Sagi Grimberg (23): IB/iser: Rename ib_conn -> iser_conn IB/iser: Re-introduce ib_c

[GIT PULL] please pull infiniband.git

2014-09-23 Thread Roland Dreier
rt comes up IB/mlx4: Avoid executing gid task when device is being removed Or Gerlitz (1): IB/iser: Bump version to 1.4.1 Roi Dayan (1): IB/iser: Fix RX/TX CQ resource leak on error flow Roland Dreier (1): Merge branches 'core', 'ipoib', 'iser

Re: [PATCH v1 for-next 00/16] On demand paging

2014-09-03 Thread Roland Dreier
> I would like to note that we at Los Alamos National Laboratory are very > interested in this functionality and it would be great if it gets accepted. Have you done any review or testing of these changes? If so can you share the results? - R. -- To unsubscribe from this list: send the line "un

[GIT PULL] please pull infiniband.git

2014-08-14 Thread Roland Dreier
handling IB/iser: Clarify a duplicate counters check Roland Dreier (1): Merge branches 'core', 'cxgb4', 'ipoib', 'iser', 'iwcm', 'mad', 'misc', 'mlx4', 'mlx5', 'ocrdma' and '

[GIT PULL] please pull infiniband.git

2014-07-18 Thread Roland Dreier
fixes Hariprasad S (2): RDMA/cxgb4: Fix skb_leak in reject_cr() RDMA/cxgb4: Clean up connection on ARP error Or Gerlitz (1): IB/mlx5: Enable "block multicast loopback" for kernel consumers Roland

[GIT PULL] please pull infiniband.git

2014-06-10 Thread Roland Dreier
ation flag to use GFP_NOIO allocations Roi Dayan (1): IB/iser: Add missing newlines to logging messages Roland Dreier (6): IB/mlx5: Fix warning about cast of wr_id back to pointer on 32 bits mlx4_core: Move handling of MLX4_QP_ST_MLX to proper switch statement IB/mad:

Re: [PATCH v1 for-next 0/3] IB: Use GFP_NOIO calls in IPoIB connected mode TX path

2014-05-19 Thread Roland Dreier
On Sat, May 17, 2014 at 1:52 PM, Or Gerlitz wrote: > Roland, we're soon on -rc6 and there's no reason for this to miss > 3.16, could you please comment whether you want it to go through your > tree or net-next? I will pick it up. -- To unsubscribe from this list: send the line "unsubscribe linux-

[tip:x86/mm] x86, ioremap: Speed up check for RAM pages

2014-05-02 Thread tip-bot for Roland Dreier
Commit-ID: c81c8a1eeede61e92a15103748c23d100880cc8a Gitweb: http://git.kernel.org/tip/c81c8a1eeede61e92a15103748c23d100880cc8a Author: Roland Dreier AuthorDate: Fri, 2 May 2014 11:18:41 -0700 Committer: H. Peter Anvin CommitDate: Fri, 2 May 2014 11:52:26 -0700 x86, ioremap: Speed up

[PATCH] x86, ioremap: Speed up check for RAM pages

2014-05-02 Thread Roland Dreier
From: Roland Dreier In __ioremap_caller() (the guts of ioremap), we loop over the range of pfns being remapped and checks each one individually with page_is_ram(). For large ioremaps, this can be very slow. For example, we have a device with a 256 GiB PCI BAR, and ioremapping this BAR can take

[GIT PULL] please pull infiniband.git

2014-05-01 Thread Roland Dreier
Hi Linus, Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus InfiniBand/RDMA updates for 3.15-rc4: - cxgb4 hardware driver fixes

[GIT PULL] please pull infiniband.git

2014-04-18 Thread Roland Dreier
() instead of pci_enable_msix() Eli Cohen (1): IB/mlx5: Add block multicast loopback support Hariprasad Shenai (1): RDMA/cxgb4: Use pr_warn_ratelimited Roland Dreier (1): Merge branches 'cxgb4', 'misc', 'mlx5' and 'qib' into for-next Steve Wis

[GIT PULL] please pull infiniband.git

2014-04-03 Thread Roland Dreier
rint QP information once connection is established IB/iser: Update Mellanox copyright note IB/iser: Bump driver version to 1.3 Prarit Bhargava (1): RDMA/ocrdma: Fix compiler warning Randy Dunlap (1): IB/iser: Fix sector_t format warning Roi Dayan (1): IB/iser: Drain

Re: linux rdma 3.14 merge plans

2014-03-07 Thread Roland Dreier
will cut patches on top of previous > series of patches. > > -Regards > Devesh > > -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Nicholas A. Bellinger > Sent: Thursday, March 06, 2014 12:34 AM &

Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP

2014-03-05 Thread Roland Dreier
On Thu, Feb 27, 2014 at 2:42 AM, Jiri Kosina wrote: > Whatever suits you best. To sum it up: > > - mlx4 is confirmed to have this problem, and we know how that problem > happens -- see the paragraph in the changelog explaining the dependency > between memory reclaim and allocation of TX ring >

Re: linux rdma 3.14 merge plans

2014-03-05 Thread Roland Dreier
On Wed, Mar 5, 2014 at 1:54 AM, Nicholas A. Bellinger wrote: > That all said, do you have an objection wrt taking this bits through > target-pending..? Given the dependencies involved, that would seem the > most logical path to take. Perhaps not surprisingly, I would prefer to get a chance to re

Re: [PATCH] Revert "driver core: synchronize device shutdown"

2014-03-04 Thread Roland Dreier
> Hm, no one seems to have said anything for the past 5 years about this. It definitely is hard to hit -- you have to do "shutdown" or "reboot" right as something schedules async work. In our case we have some systems with a large and slightly flaky SAS fabric, so there's a constant level of re-p

[PATCH] Revert "driver core: synchronize device shutdown"

2014-03-04 Thread Roland Dreier
From: Roland Dreier This reverts commit 401097ea4b89846d66ac78f7f108d49c2e922d9c. The original changelog said: A patch series to make .shutdown execute asynchronously. Some drivers's shutdown can take a lot of time. The patches can help save some shutdown time. The patche

[PATCH] NTB: Fix typo in setting one translation register

2014-02-21 Thread Roland Dreier
From: Roland Dreier In the code for Xeon devices in back-to-back mode with xeon_errata_workaround disabled, the downstream device puts the wrong value in SNB_B2B_XLAT_OFFSETL (SNB_MBAR01_DSD_ADDR vs. SNB_MBAR01_USD_ADDR). This was spotted while reading code, since the typo has no practical

[GIT PULL] please pull infiniband.git

2014-02-14 Thread Roland Dreier
e port IBoE GID table properly under bonding IB: Report using RoCE IP based gids in port caps Roi Dayan (1): IB/iser: Avoid dereferencing iscsi_iser conn object when not bound to iser connection Roland Dreier (2): mlx5: Add include of because of kzalloc()/kfree() use Merge

Re: linux rdma 3.14 merge plans

2014-02-06 Thread Roland Dreier
On Thu, Feb 6, 2014 at 4:02 PM, Nicholas A. Bellinger wrote: > Can you give us an estimate of when you'll have some time to give > feedback on the outstanding patches..? I hope to get to it in the next few weeks. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

[GIT PULL] please pull infiniband.git

2014-01-24 Thread Roland Dreier
based gids Or Gerlitz (2): IB/core: Resolve Ethernet L2 addresses when modifying QP IB/core: Fix unused variable warning Paul Bolle (1): RDMA/cxgb4: Fix gcc warning on 32-bit arch Roland Dreier (6): IB/usnic: Fix typo "Ignorning" -> "Ignoring"

Re: linux rdma 3.14 merge plans

2014-01-21 Thread Roland Dreier
On Tue, Jan 21, 2014 at 2:00 PM, Or Gerlitz wrote: > Roland, ping! the signature patches were posted > three months ago. We > deserve a response from the maintainer that goes beyond "I need to > think on that". > > Responsiveness was stated by Linus to be the #1 requirement from > kernel maintaine

[GIT PULL] please pull infiniband.git

2013-12-23 Thread Roland Dreier
ger. - Make a function static. Rashika (1): RDMA/cxgb4: Make _c4iw_write_mem_dma() static Roland Dreier (2): IB/uverbs: New macro to set pointers to NULL if length is 0 in INIT_UDATA() Merge branches 'cxgb4', 'flowsteer' and 'misc&

[GIT PULL] please pull infiniband.git

2013-11-18 Thread Roland Dreier
DMA/ocrdma: Remove redundant check in ocrdma_build_fr() Roland Dreier (1): Merge branches 'cma', 'cxgb4', 'flowsteer', 'ipoib', 'misc', 'mlx4', 'mlx5', 'nes', 'ocrdma', 'qib' and 'srp

Re: linux-next: build warning after merge of the infiniband tree

2013-11-08 Thread Roland Dreier
he Tetsuo's original message didn't cc the linux-rdma > list? > > Mike > >> -Original Message- >> From: Stephen Rothwell [mailto:s...@canb.auug.org.au] >> Sent: Sunday, November 03, 2013 11:55 PM >> To: Roland Dreier; linux-r...@vger.kernel.org &g

[GIT PULL] please pull infiniband.git

2013-10-22 Thread Roland Dreier
Hi Linus, This is the "disable ABI we don't want to freeze" pull I warned you about. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus Disable not-quite-ready userspace A

Re: [GIT PULL] please pull infiniband.git

2013-10-15 Thread Roland Dreier
On Mon, Oct 14, 2013 at 5:52 PM, Linus Torvalds wrote: > So get your act together, and push back on the people you are supposed > to manage. Because this is *not* acceptable for post-rc5, and I'm > giving this single warning. Next time, I'll just ignore the sh*t you > send me. > > Comprende? Fair

[GIT PULL] please pull infiniband.git

2013-10-14 Thread Roland Dreier
: Fix memory leak in mlx5_ib_create_srq Roland Dreier (1): Merge branch 'misc' into for-next Sagi Grimberg (1): IB/mlx5: Fix eq names to display nicely in /proc/interrupts drivers/infiniband/hw/amso1100/c2_ae.c | 2 +- drivers/infiniband/hw/mlx5/main.c

[GIT PULL] please pull infiniband.git

2013-09-04 Thread Roland Dreier
IB/iser: Fix possible memory leak in iser_create_frwr_pool() Roland Dreier (2): RDMA/ocrdma: Fix compiler warning about int/pointer size mismatch Merge branches 'cxgb4', 'flowsteer', 'ipoib', 'iser', 'mlx4', 'ocrdma

Re: [PATCH 9/9] tcm_qla2xxx: Add special case for COMPARE_AND_WRITE data_direction

2013-08-21 Thread Roland Dreier
On Wed, Aug 21, 2013 at 7:38 AM, Roland Dreier wrote: > I don't understand this. In fact the whole patch series looks quite > confused. COMPARE AND WRITE is a normal Data-Out command, with no > requirement for special bidirectional handling or anything like that. > The only

Re: [PATCH 9/9] tcm_qla2xxx: Add special case for COMPARE_AND_WRITE data_direction

2013-08-21 Thread Roland Dreier
On Tue, Aug 20, 2013 at 1:08 PM, Nicholas A. Bellinger wrote: > Add a special case for COMPARE_AND_WRITE for the reverse data direction > mapping used for pci_map_sg() + friends. I don't understand this. In fact the whole patch series looks quite confused. COMPARE AND WRITE is a normal Data-Out

Re: [PATCH v2] [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal

2013-08-15 Thread Roland Dreier
Jens / James, do you guys plan to send this to Linus for 3.11? Triggering this bug is a bit esoteric but the impact is pretty nasty (corrupting an unrelated process). Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@v

Re: [PATCH v2] [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal

2013-08-08 Thread Roland Dreier
On Wed, Aug 7, 2013 at 9:31 AM, Douglas Gilbert wrote: > So what kind of signal was leading to your "stomping on the memory"? > Was it user generated or something like SIGIO, SIGPIPE or a RT signal? It was sometimes SIGHUP (for reopening log files) and sometimes SIGALARM (for various periodic thi

Re: [PATCH v2] [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal

2013-08-07 Thread Roland Dreier
On Wed, Aug 7, 2013 at 7:38 AM, David Milburn wrote: > I was able to succesfully test this patch overnight, I had been experimenting > with the > sg driver setting the BIO_NULL_MAPPED flag in sg_rq_end_io_usercontext for a > orphan process > which prevented the corruption, but your solution seem

[PATCH v2] [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal

2013-08-05 Thread Roland Dreier
From: Roland Dreier There is a nasty bug in the SCSI SG_IO ioctl that in some circumstances leads to one process writing data into the address space of some other random unrelated process if the ioctl is interrupted by a signal. What happens is the following: - A process issues an SG_IO ioctl

Re: [PATCH] [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal

2013-08-05 Thread Roland Dreier
+ } > bio_free_map_data(bmd); > bio_put(bio); > return ret; Yes, looks reasonable -- I can't think of any reason why anyone would ever want the bio code to copy to a random userspace address space. Acked-by: Roland Dreier -- To unsubscribe from this list

[PATCH] [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal

2013-08-05 Thread Roland Dreier
From: Roland Dreier There is a nasty bug in the SCSI SG_IO ioctl that in some circumstances leads to one process writing data into the address space of some other random unrelated process if the ioctl is interrupted by a signal. What happens is the following: - A process issues an SG_IO ioctl

[GIT PULL] please pull infiniband.git

2013-08-02 Thread Roland Dreier
contains the default pkey Mike Marciniszyn (1): IB/qib: Add err_decode() call for ring dump Or Gerlitz (1): IPoIB: Make sure child devices use valid/proper pkeys Paul Bolle (1): RDMA/cma: Fix gcc warning Roland Dreier (3): RDMA/ocrdma: Remove unused include Revert

[GIT PULL] please pull infiniband.git

2013-07-11 Thread Roland Dreier
IB/qib: Add dual-rail NUMA awareness for PSM processes Roland Dreier (6): mlx5: Fix parameter type of health_handler_t IB/mlx5: Make profile[] static in main.c mlx5_core: Fixes for sparse warnings IB/uverbs: Use get_unused_fd_flags(O_CLOEXEC) instead of get_unused_fd

Re: [GIT PULL] please pull infiniband.git

2013-07-10 Thread Roland Dreier
On Wed, Jul 10, 2013 at 7:35 AM, Sebastian Riemer wrote: > > I've checked the commits on that tag and the following commit is not > what we've agreed on: Sorry about that. The discussion was long and complex and I probably made a mistake in aplying the patches. Please me send a patch to fix the

[GIT PULL] please pull infiniband.git

2013-07-09 Thread Roland Dreier
RDMA/ocrdma: Set bad_wr in error case RDMA/ocrdma: Change macros to inline funtions RDMA/ocrdma: Reorg structures to avoid padding Ramkrishna Vepa (2): IB/qib: Add optional NUMA affinity IB/qib: Add dual-rail NUMA awareness for PSM processes Roland Dreier (5): mlx5

Re: [PATCH 03/13] infiniband: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-07-08 Thread Roland Dreier
Thanks, I just applied a patch to convert to get_unused_fd_flags(O_CLOEXEC) in uverbs, since there isn't anything useful that can be done with uverbs fds across an exec. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kern

Re: [PATCH] mm: Revert pinned_vm braindamage

2013-06-20 Thread Roland Dreier
On Thu, Jun 20, 2013 at 7:48 AM, Christoph Lameter wrote: > There is no way that user space can initiate a page pin right now. Perf is > pinning the page from the kernel. Similarly the IB subsystem pins memory > meeded for device I/O. Christoph, your argument would be a lot more convincing if you

Re: linux-next: just chaeking correctness of the infiniband tree

2013-06-20 Thread Roland Dreier
On Thu, Jun 20, 2013 at 5:09 PM, Stephen Rothwell wrote: > I noticed that the infiniband tree is now based on the net-next tree. I > assume that is deliberate? I do have to question how much testing that > tree has had since it is now based on a tree that Dave only released in > the last 24 hour

[GIT PULL] please pull infiniband.git

2013-06-07 Thread Roland Dreier
removal flow Roland Dreier (1): Merge branches 'iser' and 'qib' into for-next MAINTAINERS | 10 ++ drivers/infiniband/hw/qib/qib_keys.c | 2 +- drivers/infiniband/ulp/iser/iscsi_iser.c | 1 + drivers/infiniband/u

[GIT PULL] please pull infiniband.git

2013-05-08 Thread Roland Dreier
informational messages from error to info level Roland Dreier (1): Merge branches 'cxgb4', 'ipoib', 'iser', 'misc', 'mlx4', 'qib' and 'srp' into for-next Shlomo Pongratz (3): IB/core: Verify that QP handler is valid befor

Re: linux-next: Tree for Apr 17 (infiniband/rdma)

2013-04-17 Thread Roland Dreier
On Wed, Apr 17, 2013 at 11:06 AM, Randy Dunlap wrote: > on x86_64: > > drivers/built-in.o: In function `isert_free_np': > ib_isert.c:(.text+0x6e8a77): undefined reference to `rdma_destroy_id' > drivers/built-in.o: In function `isert_conn_setup_qp': > ib_isert.c:(.text+0x6e9038): undefined referenc

Re: [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-05 Thread Roland Dreier
On Fri, Apr 5, 2013 at 1:51 PM, Michael R. Hines wrote: > Sorry, I was wrong. ignore the comments about cgroups. That's still broken. > (i.e. trying to register RDMA memory while using a cgroup swap limit cause > the process get killed). > > But the GIFT flag patch works (my understanding is that

Re: [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-05 Thread Roland Dreier
On Fri, Apr 5, 2013 at 1:17 PM, Michael R. Hines wrote: > I also removed the IBV_*_WRITE flags on the sender-side and activated > cgroups with the "memory.memsw.limit_in_bytes" activated and the migration > with RDMA also succeeded without any problems (both with *and* without GIFT > also worked).

Re: [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-02 Thread Roland Dreier
On Tue, Apr 2, 2013 at 8:51 AM, Michael S. Tsirkin wrote: >> At the moment registering an MR breaks COW. This breaks memory >> overcommit for users such as KVM: we have a lot of COW pages, e.g. >> instances of the zero page or pages shared using KSM. >> >> If the application does not care that ad

[GIT PULL] please pull infiniband.git

2013-03-25 Thread Roland Dreier
ion Roland Dreier (1): Merge branches 'cxgb4', 'ipoib' and 'qib' into for-next Vinit Agnihotri (1): IB/qib: change QLogic to Intel Wei Yongjun (1): RDMA/cxgb4: Fix error return code in create_qp() drivers/infiniband/hw/cxgb4/qp.c | 4

Re: [PATCH] rdma: don't make pages writeable if not requiested

2013-03-21 Thread Roland Dreier
On Thu, Mar 21, 2013 at 1:51 AM, Michael S. Tsirkin wrote: >> In that case, no, I don't see any reason for LOCAL_WRITE, since the >> only RDMA operations that will access this memory are remote reads. > > What is the meaning of LOCAL_WRITE then? There are no local > RDMA writes as far as I can see

Re: [PATCH] rdma: don't make pages writeable if not requiested

2013-03-21 Thread Roland Dreier
>> I think this change will break the case where userspace tries to >> register an MR with read-only permission, but intends locally through >> the CPU to write to the memory. > Shouldn't it set LOCAL_WRITE then? We're talking about the permissions for the register MR operation, right? (That's w

Re: [PATCH] rdma: don't make pages writeable if not requiested

2013-03-20 Thread Roland Dreier
On Wed, Mar 20, 2013 at 11:18 PM, Michael S. Tsirkin wrote: > core/umem.c seems to get the arguments to get_user_pages > in the reverse order: it sets writeable flag and > breaks COW for MAP_SHARED if and only if hardware needs to > write the page. > > This breaks memory overcommit for users such

[GIT PULL] please pull infiniband.git

2013-02-26 Thread Roland Dreier
Paul Bolle (2): RDMA/cxgb4: "cookie" can stay in host endianness IB/mlx4: Fix compiler warning about uninitialized 'vlan' variable Roland Dreier (3): IB/mlx4: Convert is_xxx variables in build_mlx_header() to bool IPoIB: Free ipoib neigh on path record fa

Re: [PATCH v2] IB/mlx4: silence GCC warning

2013-02-25 Thread Roland Dreier
On Mon, Feb 25, 2013 at 8:54 AM, Roland Dreier wrote: > I'm finally noticing that this is in the build_mlx_header() function, > which is pretty much a slow path. Certainly another compare isn't > going to change performance given all the other stuff we do there. > > L

Re: [PATCH v2] IB/mlx4: silence GCC warning

2013-02-25 Thread Roland Dreier
On Sun, Feb 24, 2013 at 4:34 AM, Jack Morgenstein wrote: > However, this approach does add the line below to processing for an IB port > (ETH/RoCE port stays same, more or less). > Processing time is therefore increased (at least on the IB side) relative to > just living with the warning. > > Ro

[GIT PULL] please pull infiniband.git

2013-02-06 Thread Roland Dreier
context behaviour Roland Dreier (1): Merge branches 'ipoib', 'mlx4' and 'qib' into for-next Shlomo Pongratz (1): IPoIB: Fix crash due to skb double destruct drivers/infiniband/hw/qib/qib_qp.c| 11 +++ drivers/infiniband/ulp/ipoib/ipo

Re: [PATCH] printk: Fix incorrect length from print_time() when seconds > 99999

2012-12-29 Thread Roland Dreier
On Sat, Dec 29, 2012 at 12:08 PM, Joe Perches wrote: > Sylvan Munaut did something similar > https://lkml.org/lkml/2012/12/5/168 Missed that and duplicated the debugging :( Sorry Sylvain. I guess my patch may be preferable, since I happened to use the snprintf() method that you suggest -- all th

Re: [PATCH] printk: Fix incorrect length from print_time() when seconds > 99999

2012-12-29 Thread Roland Dreier
On Sat, Dec 29, 2012 at 9:56 AM, Greg Kroah-Hartman wrote: > Nice work. When did you start seeing this problem, 3.6 or so? I ask as > it's probably something that should go to stable as well if so. We happened to see it when we rebased to the 3.6 kernel, but as far as I can see, the bug has bee

[PATCH] printk: Fix incorrect length from print_time() when seconds > 99999

2012-12-28 Thread Roland Dreier
From: Roland Dreier print_prefix() passes a NULL buf to print_time() to get the length of the time prefix; when printk times are enabled, the current code just returns the constant 15, which matches the format "[%5lu.%06lu] " used to print the time value. However, this is obviously

[GIT PULL] please pull infiniband.git

2012-12-21 Thread Roland Dreier
steering wrapper Jack Morgenstein (2): mlx4_core: Adjustments to Flow Steering activation logic for SR-IOV mlx4_core: Allow choosing flow steering mode Roland Dreier (2): IPoIB: Call skb_dst_drop() once skb is enqueued for sending Merge branches 'cxgb4', 'i

Re: linux-next: build failure after merge of the infiniband tree

2012-12-19 Thread Roland Dreier
On Wed, Dec 19, 2012 at 2:44 PM, Stephen Rothwell wrote: > Hi all, > > After merging the infiniband tree, today's linux-next build (x86_64_ > allmodconfig) failed like this: > > In file included from drivers/scsi/csiostor/csio_wr.h:42:0, > from drivers/scsi/csiostor/csio_scsi.h:49

  1   2   3   4   5   6   7   8   9   >