RE: [PATCH v2 2/2] ASoC: Intel: Skylake: Zero snd_ctl_elem_value

2021-01-21 Thread Rojewski, Cezary
On 2021-01-21 6:16 PM, Ricardo Ribalda wrote: > Clear struct snd_ctl_elem_value before calling ->put() to avoid any data > leak. > > Signed-off-by: Ricardo Ribalda Reviewed-by: Cezary Rojewski Thanks, Czarek

RE: [PATCH v2 1/2] ASoC: Intel: Skylake: skl-topology: Fix OOPs ib skl_tplg_complete

2021-01-21 Thread Rojewski, Cezary
On 2021-01-21 6:16 PM, Ricardo Ribalda wrote: > If dobj->control is not initialized we end up in an OOPs during > skl_tplg_complete: > > [ 26.553358] BUG: kernel NULL pointer dereference, address: > 0078 > [ 26.561151] #PF: supervisor read access in kernel mode > [ 26.566897] #PF

RE: [PATCH v2] ASoC: Intel: Skylake: Check the kcontrol against NULL

2021-01-20 Thread Rojewski, Cezary
On 2021-01-20 5:41 PM, Rojewski, Cezary wrote: > > Just checked the history behind this. And must say, I liked Ricardo's > version better. Except for the "= {};" bit which Mark already pointed > out - it should be a separate fix - it's simply more optional Meant to say: optimal.

RE: [PATCH v2] ASoC: Intel: Skylake: Check the kcontrol against NULL

2021-01-20 Thread Rojewski, Cezary
On 2021-01-20 5:33 PM, Pierre-Louis Bossart wrote: > On 1/20/21 9:49 AM, Ɓukasz Majczak wrote: >> Hi Pierre, >> >> Is there anything more to do to get the ACK for this patch? > > Adding Cezary and Amadeusz for feedback, I can't pretend having any sort > of knowledge on the Skylake driver internal

RE: sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource_size() here

2020-11-23 Thread Rojewski, Cezary
On 2020-11-23 11:53 AM, Andy Shevchenko wrote: > On Sun, Nov 22, 2020 at 03:52:27AM +0800, kernel test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> head: 27bba9c532a8d21050b94224ffd310ad0058c353 >> commit: 6cbfa11d2694b8a1e46d6834fb9705d

RE: [PATCH] ASoC: Intel: Skylake: Add alternative topology binary name

2020-11-09 Thread Rojewski, Cezary
On 2020-11-08 6:00 PM, Greg KH wrote: > On Sun, Nov 08, 2020 at 04:17:16PM +0000, Rojewski, Cezary wrote: >> On 2020-11-04 12:58 PM, Greg KH wrote: >>> On Wed, Nov 04, 2020 at 12:46:36PM +0100, Gorski, Mateusz wrote: >>>> >>>>>> [ Upstream

RE: [PATCH] ASoC: Intel: Skylake: Add alternative topology binary name

2020-11-08 Thread Rojewski, Cezary
On 2020-11-04 12:58 PM, Greg KH wrote: > On Wed, Nov 04, 2020 at 12:46:36PM +0100, Gorski, Mateusz wrote: >> [ Upstream commit 1b290ef023b3eeb4f4688b582fecb773915ef937 ] Add alternative topology binary file name based on used machine driver and fallback to use this name after fa

RE: [PATCH] ASoC: Intel: remove unneeded semicolon

2020-11-02 Thread Rojewski, Cezary
On 2020-11-01 6:19 PM, t...@redhat.com wrote: > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix > --- Thanks for this update, Tom. Acked-by: Cezary Rojewski Regards, Czarek

RE: [PATCH v2 31/39] docs: ABI: cleanup several ABI documents

2020-10-30 Thread Rojewski, Cezary
On 2020-10-30 8:40 AM, Mauro Carvalho Chehab wrote: > There are some ABI documents that, while they don't generate > any warnings, they have issues when parsed by get_abi.pl script > on its output result. > > Address them, in order to provide a clean output. > > Acked-by: Jonathan Cameron #for I

RE: [PATCH] seq_buf: avoid type mismatch for seq_buf_init

2020-10-26 Thread Rojewski, Cezary
On 2020-10-26 5:10 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > Building with W=2 prints a number of warnings for one function that > has a pointer type mismatch: > > linux/seq_buf.h: In function 'seq_buf_init': > linux/seq_buf.h:35:12: warning: pointer targets in assignment from 'unsigned

RE: sound/soc/intel/catpt/dsp.c:359:9: sparse: sparse: restricted pci_power_t degrades to integer

2020-10-22 Thread Rojewski, Cezary
On 2020-10-22 4:09 PM, Bjorn Helgaas wrote: > On Thu, Oct 22, 2020 at 04:52:29PM +0300, Andy Shevchenko wrote: >> +Cc: Bjorn >> >> On Thu, Oct 22, 2020 at 03:25:49PM +0800, kernel test robot wrote: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >>> master >>> head:

RE: [PATCH 3/8] ASoC: Intel: bytcr_rt5651: use semicolons rather than commas to separate statements

2020-10-12 Thread Rojewski, Cezary
On 2020-10-11 11:19 AM, Julia Lawall wrote: > Replace commas with semicolons. What is done is essentially described by > the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): > > // > @@ expression e1,e2; @@ > e1 > -, > +; > e2 > ... when any > // > > Signed-off-by: Julia Lawal

Re: [PATCH v2] list: Add a macro to test if entry is pointing to the head

2020-09-29 Thread Rojewski, Cezary
On 2020-09-29 3:43 PM, Andy Shevchenko wrote: > Add a macro to test if entry is pointing to the head of the list > which is useful in cases like: > >list_for_each_entry(pos, &head, member) { > if (cond) >break; >} >if (list_entry_is_head(pos, &head, member)) > return

[RFC] kfifo: Add support for copying to and from IO space.

2019-04-15 Thread Rojewski, Cezary
Behind the scenes kfifo_in and kfifo_out use memcpy explicitly. This is not suitable when dealing with IO space. Declare simple IO equivalents in form of kfifo_fromio and kfifo_toio which make use of memcpy_fromio and memcpy_toio respectively. While doing so, don't forget about their spinlocked fri