On 9/22/2020 5:13 PM, Mark Brown wrote:
On Tue, Sep 22, 2020 at 12:22:38PM +0100, Srinivas Kandagatla wrote:
On 22/09/2020 12:08, Mark Brown wrote:
I agree with you on this and I see the point, but Rob had a very different
opinion about the reg-names bindings to start with.
This topic been dis
nce null return value")
Fixes: 1220f6a76e77 ("ASoC: qcom: Add common array to initialize soc based core
clocks")
Signed-off-by: Colin Ian King
---
Thanks for the fix.
Reviewed-by: Rohit kumar
sound/soc/qcom/lpass-apq8016.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
Update lpass-cpu binding with yaml formats.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,lpass-cpu.txt | 130 --
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 189 +
2 files changed, 189 insertions(+), 130 deletions(-)
delete mode
From: Ajit Pandey
Add platform driver for configuring sc7180 lpass core I2S and
DMA configuration to support playback & capture to external codecs
connected over primary & secondary MI2S interfaces.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Ka
river")
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-cpu.c | 16
1 file changed, 16 deletions(-)
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c
index 6b86f16..5d84f63 100644
--- a/sound/soc/qcom/lpass-cpu.c
+++ b
From: Ajit Pandey
We are allocating dma memory for component->dev but trying to mmap
such memory for substream->pcm->card->dev. Replace device argument
in mmap with component->dev to fix this.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandaga
platform_get_irq_byname() is used when there is list
of interrupts in the device node. As lpass-platform
has only one interrupt entry, use platform_get_irq()
instead.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/lpass-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
platform_get_resource_byname() is used when there
is list of reg entries. As lpass-cpu node has only
one reg entry, use platform_get_resource() instead.
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
I2SCTL and DMACTL registers has different bits alignment for newer
LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the
reg_fields in platform specific file and removed shifts and mask
macros for such registers from header file.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/lpass
lpass_pcm_data is never freed. Free it in close
ops to avoid memory leak.
Fixes: 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage")
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-platform.c | 3 ++-
1 file changed, 2 insertions(+),
From: Ajit Pandey
Add header defining dai-id and mclk id for SC7180 lpass soc.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Acked-by: Rob Herring
---
include/dt-bindings/sound/sc7180-lpass.h | 10 ++
1 file changed, 10 insertions(+)
create mode 100644 include/dt-bindings
Add dt-bindings to support "qcom,lpass-cpu-sc7180" node.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,lpass-cpu.txt | 55 +-
1 file changed, 53 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-
Ahbix clock is optional clock and not needed for all platforms.
Move it to lpass-apq8016/ipq806x as it is not needed for sc7180.
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-apq8016.c | 27 ++
sound/soc/qcom/lpass-cpu.c | 40
ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio
Rohit kumar (8):
ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function
ASoC: qcom: lpass-platform: fix memory leak
ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers
ASoC: qcom: lpass-cpu: fix concu
-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-apq8016.c | 39 +++
sound/soc/qcom/lpass.h | 10 +++---
2 files changed, 26 insertions(+), 23 deletions(-)
diff --git a/sound/soc/qcom/lpass
Hello Mark,
Do you see any concern with patches (1-11).
As of now, there is comment only in patch 12 from Rob which I am
planning to update once other patches are merged. Can you
please review and let me know if anything is missing.
Thanks,
Rohit
On 8/4/2020 1:37 PM, Rohit kumar wrote:
From
.
Thanks,
Rohit
On 8/4/2020 1:37 PM, Rohit kumar wrote:
This patch chain add audio support for SC7180 soc by doing the required
modification in existing common lpass-cpu/lpass-platform driver.
This also fixes some concurrency issue.
This patch series is already tested by Srinivas on Dragon Board
Thanks Stephen for reviewing.
On 8/6/2020 6:01 AM, Stephen Boyd wrote:
Quoting Rohit kumar (2020-07-22 03:31:44)
From: Ajit Pandey
LPASS variants have their own soc specific clocks that needs to be
enabled for MI2S audio support. Added a common variable in drvdata to
initialize such clocks
On 8/3/2020 11:52 PM, Rob Herring wrote:
On Mon, Aug 3, 2020 at 2:28 AM Rohit Kumar wrote:
Thanks Rob for reviewing
On 7/23/2020 10:46 PM, Rob Herring wrote:
On Wed, Jul 22, 2020 at 04:01:55PM +0530, Rohit kumar wrote:
Update lpass-cpu binding with yaml formats.
Signed-off-by: Rohit
platform_get_resource_byname() is used when there
is list of reg entries. As lpass-cpu node has only
one reg entry, use platform_get_resource() instead.
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Ajit Pandey
Add platform driver for configuring sc7180 lpass core I2S and
DMA configuration to support playback & capture to external codecs
connected over primary & secondary MI2S interfaces.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Ka
From: Ajit Pandey
Add header defining dai-id and mclk id for SC7180 lpass soc.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Acked-by: Rob Herring
---
include/dt-bindings/sound/sc7180-lpass.h | 10 ++
1 file changed, 10 insertions(+)
create mode 100644 include/dt-bindings
Update lpass-cpu binding with yaml formats.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,lpass-cpu.txt | 130 ---
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 179 +
2 files changed, 179 insertions(+), 130 deletions(-)
delete mode
river")
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-cpu.c | 16
1 file changed, 16 deletions(-)
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c
index 6b86f16..5d84f63 100644
--- a/sound/soc/qcom/lpass-cpu.c
+++ b
platform_get_irq_byname() is used when there is list
of interrupts in the device node. As lpass-platform
has only one interrupt entry, use platform_get_irq()
instead.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/lpass-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
lpass_pcm_data is never freed. Free it in close
ops to avoid memory leak.
Fixes: 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage")
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-platform.c | 3 ++-
1 file changed, 2 insertions(+),
sc7180-lpass bindings header
ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio
Rohit kumar (8):
ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function
ASoC: qcom: lpass-platform: fix memory leak
ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers
Add dt-bindings to support "qcom,lpass-cpu-sc7180" node.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,lpass-cpu.txt | 55 +-
1 file changed, 53 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-
I2SCTL and DMACTL registers has different bits alignment for newer
LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the
reg_fields in platform specific file and removed shifts and mask
macros for such registers from header file.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/lpass
-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-apq8016.c | 39 +++
sound/soc/qcom/lpass.h | 10 +++---
2 files changed, 26 insertions(+), 23 deletions(-)
diff --git a/sound/soc/qcom/lpass
Ahbix clock is optional clock and not needed for all platforms.
Move it to lpass-apq8016/ipq806x as it is not needed for sc7180.
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-apq8016.c | 27 ++
sound/soc/qcom/lpass-cpu.c | 40
From: Ajit Pandey
We are allocating dma memory for component->dev but trying to mmap
such memory for substream->pcm->card->dev. Replace device argument
in mmap with component->dev to fix this.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandaga
Thanks Rob for reviewing
On 7/23/2020 10:46 PM, Rob Herring wrote:
On Wed, Jul 22, 2020 at 04:01:55PM +0530, Rohit kumar wrote:
Update lpass-cpu binding with yaml formats.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,lpass-cpu.txt | 130
On 7/27/2020 3:20 PM, Rohit Kumar wrote:
On 7/24/2020 4:52 PM, Srinivas Kandagatla wrote:
On 22/07/2020 11:31, Rohit kumar wrote:
This patch chain add audio support for SC7180 soc by doing the required
modification in existing common lpass-cpu/lpass-platform driver.
This also fixes some
On 7/24/2020 4:52 PM, Srinivas Kandagatla wrote:
On 22/07/2020 11:31, Rohit kumar wrote:
This patch chain add audio support for SC7180 soc by doing the required
modification in existing common lpass-cpu/lpass-platform driver.
This also fixes some concurrency issue.
Changes since v3
Thanks Rob for the review. Posted v4 with fixes.
On 7/14/2020 4:23 AM, Rob Herring wrote:
On Wed, Jul 08, 2020 at 10:38:16AM +0530, Rohit kumar wrote:
From: Ajit Pandey
Update lpass-cpu binding with yaml formats.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
---
.../devicetree
Update lpass-cpu binding with yaml formats.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,lpass-cpu.txt | 130 ---
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 185 +
2 files changed, 185 insertions(+), 130 deletions(-)
delete mode
platform_get_resource_byname() is used when there
is list of reg entries. As lpass-cpu node has only
one reg entry, use platform_get_resource() instead.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/lpass-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom
platform_get_irq_byname() is used when there is list
of interrupts in the device node. As lpass-platform
has only one interrupt entry, use platform_get_irq()
instead.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/lpass-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
river")
Signed-off-by: Rohit kumar
---
sound/soc/qcom/lpass-cpu.c | 16
1 file changed, 16 deletions(-)
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c
index 6b86f16..5d84f63 100644
--- a/sound/soc/qcom/lpass-cpu.c
+++ b/sound/soc/qcom/lpass-cpu.c
@@ -266
From: Ajit Pandey
We are allocating dma memory for component->dev but trying to mmap
such memory for substream->pcm->card->dev. Replace device argument
in mmap with component->dev to fix this.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandaga
Add dt-bindings to support "qcom,lpass-cpu-sc7180" node.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,lpass-cpu.txt | 55 +-
1 file changed, 53 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-
From: Ajit Pandey
Add header defining dai-id and mclk id for SC7180 lpass soc.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
---
include/dt-bindings/sound/sc7180-lpass.h | 10 ++
1 file changed, 10 insertions(+)
create mode 100644 include/dt-bindings/sound/sc7180-lpass.h
I2SCTL and DMACTL registers has different bits alignment for newer
LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the
reg_fields in platform specific file and removed shifts and mask
macros for such registers from header file.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/lpass
From: Ajit Pandey
Add platform driver for configuring sc7180 lpass core I2S and
DMA configuration to support playback & capture to external codecs
connected over primary & secondary MI2S interfaces.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Ka
lpass_pcm_data is never freed. Free it in close
ops to avoid memory leak.
Fixes: 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage")
Signed-off-by: Rohit kumar
---
sound/soc/qcom/lpass-platform.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/soun
Ahbix clock is optional clock and not needed for all platforms.
Move it to lpass-apq8016/ipq806x as it is not needed for sc7180.
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-apq8016.c | 27 ++
sound/soc/qcom/lpass-cpu.c | 40
de: dt-bindings: sound: Add sc7180-lpass bindings header
ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio
Rohit kumar (8):
ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function
ASoC: qcom: lpass-platform: fix memory leak
ASoC: qcom: lpass: Use regmap_field for i2sc
-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-apq8016.c | 39 +++
sound/soc/qcom/lpass.h | 10 +++---
2 files changed, 26 insertions(+), 23 deletions(-)
diff --git a/sound/soc/qcom/lpass
On 7/9/2020 3:36 PM, Srinivas Kandagatla wrote:
On 09/07/2020 10:57, Rohit Kumar wrote:
Thanks Srini for reviewing.
On 7/9/2020 2:56 PM, Srinivas Kandagatla wrote:
On 08/07/2020 06:08, Rohit kumar wrote:
I2SCTL and DMACTL registers has different bits alignment for newer
LPASS variants
On 7/9/2020 3:38 PM, Srinivas Kandagatla wrote:
On 09/07/2020 11:01, Rohit Kumar wrote:
On 7/9/2020 2:57 PM, Srinivas Kandagatla wrote:
On 08/07/2020 06:08, Rohit kumar wrote:
Add dt-bindings to support "qcom,lpass-cpu-sc7180" node.
Signed-off-by: Rohit kumar
---
Doc
On 7/8/2020 8:15 PM, Mark Brown wrote:
On Wed, Jul 08, 2020 at 10:38:12AM +0530, Rohit kumar wrote:
From: Ajit Pandey
Add header defining dai-id and mclk id for SC7180 lpass soc.
Signed-off-by: Ajit Pandey
---
This one is missing a signoff as well, and I can't seem to see any
refe
On 7/9/2020 2:57 PM, Srinivas Kandagatla wrote:
On 08/07/2020 06:08, Rohit kumar wrote:
Add dt-bindings to support "qcom,lpass-cpu-sc7180" node.
Signed-off-by: Rohit kumar
---
Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt | 3 ++-
1 file changed, 2 insert
Thanks Srini for reviewing.
On 7/9/2020 2:56 PM, Srinivas Kandagatla wrote:
On 08/07/2020 06:08, Rohit kumar wrote:
I2SCTL and DMACTL registers has different bits alignment for newer
LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the
reg_fields in platform specific file and
On 7/8/2020 10:20 PM, Mark Brown wrote:
On Wed, Jul 08, 2020 at 10:38:13AM +0530, Rohit kumar wrote:
From: Ajit Pandey
We are allocating dma memory for component->dev but trying to mmap
such memory for substream->pcm->card->dev. Replace device argument
in mmap with component
On 7/8/2020 4:03 PM, Mark Brown wrote:
On Wed, Jul 08, 2020 at 10:44:46AM +0530, Rohit kumar wrote:
From: Ajit Pandey
Add platform driver for configuring sc7180 lpass core I2S and
DMA configuration to support playback & capture to external codecs
connected over primary & second
From: Ajit Pandey
Add platform driver for configuring sc7180 lpass core I2S and
DMA configuration to support playback & capture to external codecs
connected over primary & secondary MI2S interfaces.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
---
Resending to update Signed-
From: Ajit Pandey
Update lpass-cpu binding with yaml formats.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,lpass-cpu.txt | 80 ---
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 154 +
2 files changed, 154
Add dt-bindings to support "qcom,lpass-cpu-sc7180" node.
Signed-off-by: Rohit kumar
---
Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
b/Doc
Ahbix clock is optional clock and not needed for all platforms.
Move it to lpass-apq8016/ipq806x as it is not needed for sc7180.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/lpass-apq8016.c | 27 ++
sound/soc/qcom/lpass-cpu.c | 40
From: Ajit Pandey
Add header defining dai-id and mclk id for SC7180 lpass soc.
Signed-off-by: Ajit Pandey
---
include/dt-bindings/sound/sc7180-lpass.h | 10 ++
1 file changed, 10 insertions(+)
create mode 100644 include/dt-bindings/sound/sc7180-lpass.h
diff --git a/include/dt-binding
From: Ajit Pandey
We are allocating dma memory for component->dev but trying to mmap
such memory for substream->pcm->card->dev. Replace device argument
in mmap with component->dev to fix this.
Signed-off-by: Ajit Pandey
---
sound/soc/qcom/lpass-platform.c | 5 ++---
1 file changed, 2 insertion
From: Ajit Pandey
Add platform driver for configuring sc7180 lpass core I2S and
DMA configuration to support playback & capture to external codecs
connected over primary & secondary MI2S interfaces.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
---
sound/soc/qcom/Kconfig
I2SCTL and DMACTL registers has different bits alignment for newer
LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the
reg_fields in platform specific file and removed shifts and mask
macros for such registers from header file.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/lpass
-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
---
sound/soc/qcom/lpass-apq8016.c | 39 +++
sound/soc/qcom/lpass.h | 10 +++---
2 files changed, 26 insertions(+), 23 deletions(-)
diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass
: Replace card->dev with component->dev
ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio
dt-bindings: sound: lpass-cpu: Move to yaml format
Rohit kumar (3):
ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function
ASoC: qcom: lpass: Use regmap_field for i2sc
On 5/16/2020 11:07 PM, Ajit Pandey wrote:
On 5/14/2020 10:14 PM, Mark Brown wrote:
On Thu, May 14, 2020 at 10:08:12PM +0530, Ajit Pandey wrote:
Done the required cleanups to update lpass-cpu binding with newer
yaml formats.
Please do YAML conversions as the last thing in any patch series, th
Thanks Srini for reviewing the change.
On 5/18/2020 3:19 PM, Srinivas Kandagatla wrote:
On 14/05/2020 17:38, Ajit Pandey wrote:
I2SCTL and DMACTL registers has different bits alignment for newer
LPASS variants of SC7180 soc. Instead of adding extra overhead for
calculating masks and shifts f
Add support for 384KHz sample rate and S24_3LE
bitwidth for dummy dai.
Signed-off-by: Rohit kumar
---
sound/soc/soc-utils.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/soc-utils.c b/sound/soc/soc-utils.c
index 922eac9..364b248 100644
--- a/sound/soc/soc
Hello Bjorn,
On 1/30/2019 10:38 AM, Rohit Kumar wrote:
Hello Bjorn,
On 1/14/2019 4:14 PM, Rohit Kumar wrote:
On 1/7/2019 12:43 PM, Bjorn Andersson wrote:
On Thu 03 Jan 20:36 PST 2019, Rohit Kumar wrote:
Hello Bjorn,
Can you please review this patch series too.
LPASS_AON clock support
This patch adds Q6V5 ADSP pil remoteproc node
for SDM845 SoC.
Signed-off-by: Rohit kumar
---
Changes since v2:
Updated reg property values from <0x1730 0x410> to <0 0x1730 0 0x410>
This depends on below upstream patches:
Add adsp_mem dt node: https://lkml.org/lkml/2019/1/29
This patch adds Q6V5 ADSP pil remoteproc node
for SDM845 SoC.
Signed-off-by: Rohit kumar
---
Changes since v1:
Addressed comments given by Bjorn.
This depends on below upstream patch which defines adsp_mem node:
https://lkml.org/lkml/2019/1/29/1392
arch/arm64/boot/dts/qcom/sdm845.dtsi | 89
Hello Bjorn,
On 1/14/2019 4:14 PM, Rohit Kumar wrote:
On 1/7/2019 12:43 PM, Bjorn Andersson wrote:
On Thu 03 Jan 20:36 PST 2019, Rohit Kumar wrote:
Hello Bjorn,
Can you please review this patch series too.
LPASS_AON clock support is already removed from lpass clock driver.
Applied the
called if it is not present
in component list during sound card registration.
Check if component is available in component list for
platform and cpu dai before soundcard registration.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Signed-off-by: Mark
On 1/7/2019 12:43 PM, Bjorn Andersson wrote:
On Thu 03 Jan 20:36 PST 2019, Rohit Kumar wrote:
Hello Bjorn,
Can you please review this patch series too.
LPASS_AON clock support is already removed from lpass clock driver.
Applied the two patches.
Hello Bjorn,
Can you please point me to
On 1/12/2019 3:19 AM, Pierre-Louis Bossart wrote:
Thanks for the overnight fix. This update fixes the issue on my
Skylake XPS13 test device (blind testing since I don't understand
what the code does).
Tested-by: Pierre-Louis Bossart
I need to take this back, this set of changes (initial+f
list")
Reported-by: Pierre-Louis Bossart
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
---
sound/soc/soc-core.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 0934b36..df05fb8 100644
--- a/sound/soc/
ist during sound card registration.
Check if component is available in component list for
platform and cpu dai before soundcard registration.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Signed-off-by: Mark Brown
:04 04 98da59b0a73551030a0c9030
)
Reported-by: Kuninori Morimoto
Signed-off-by: Rohit kumar
Signed-off-by: Ajit Pandey
---
sound/soc/soc-core.c | 4
1 file changed, 4 insertions(+)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index eec92f1..0934b36 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
not present
in component list during sound card registration.
Check if component is available in component list for
platform and cpu dai before soundcard registration.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Signed-off-by: Mark Brown
---
I got below WARNING by this patch.
I guess we
From: Ajit Pandey
DAI component probe is not called if it is not present
in component list during sound card registration.
Check if component is available in component list for
platform and cpu dai before soundcard registration.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Thanks Mark for review.
On 1/7/2019 11:57 PM, Mark Brown wrote:
On Mon, Dec 24, 2018 at 02:32:13PM +0530, Rohit kumar wrote:
From: Ajit Pandey
Platform DAI component probe is not called if it is not
present in component list during sound card registration.
Check if component is registered
Thanks Bjorn for review.
On 1/4/2019 5:20 AM, Bjorn Andersson wrote:
On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote:
This patch adds Q6V5 ADSP remoteproc node for SDM845 SoCs.
Thanks Rohit, nice to see these things on the list!
Signed-off-by: Rohit kumar
---
arch/arm64/boot/dts/qcom
Thanks Bjorn for review.
On 1/4/2019 5:12 AM, Bjorn Andersson wrote:
On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote:
Add memory nodes required for remoteproc q6v5_adsp pil.
This range doesn't match the documented memory map. I would prefer to
see a "Specify all PIL regions as
Hello Bjorn,
Can you please review this patch series too.
LPASS_AON clock support is already removed from lpass clock driver.
Thanks,
Rohit
On 11/30/2018 12:59 PM, Rohit kumar wrote:
Lpass_aon clock is on by default. Remove it from lpass
clock list to avoid voting for it.
Signed-off-by
-by: Ajit Pandey
Signed-off-by: Rohit kumar
---
include/sound/soc.h | 1 +
sound/soc/soc-core.c | 28
2 files changed, 29 insertions(+)
diff --git a/include/sound/soc.h b/include/sound/soc.h
index 8ec1de8..dc251fc 100644
--- a/include/sound/soc.h
+++ b/include/sound
From: Ajit Pandey
Platform DAI component probe is not called if it is not
present in component list during sound card registration.
Check if component is registered for platform dai before
soundcard registration.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
---
sound/soc/qcom
Platform DAI component probe is not called if it is not
present in component list during sound card registration.
Add snd_soc_of_lookup_component() to get component info from
device_node. This can be used by machine driver to make sure that
card components are registered before calling snd_soc_regi
This patch adds Q6V5 ADSP remoteproc node for SDM845 SoCs.
Signed-off-by: Rohit kumar
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 96 +++-
1 file changed, 95 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot/dts
Add memory nodes required for remoteproc q6v5_adsp pil.
Signed-off-by: Rohit kumar
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 23a253b..c0a012f 100644
--- a
clk list:
https://lore.kernel.org/patchwork/patch/1019609/
Rohit kumar (2):
arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes
arm64: dts: qcom: sdm845: Add Q6V5 ADSP node
arch/arm64/boot/dts/qcom/sdm845.dtsi | 101 ++-
1 file changed, 100 insertions
This patch add support to Display_port_rx mixers required to
select path between ASM stream and AFE ports.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/qdsp6/q6routing.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6
This patch adds support of AFE DAI for Display_port_rx port.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/qdsp6/q6afe-dai.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c
index bfc3bbf..dc645ba
This patch adds support for Display_Port_Rx
port in AFE.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/qdsp6/q6afe.c | 4
1 file changed, 4 insertions(+)
diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c
index 829b5e987..e0945f7a 100644
--- a/sound/soc/qcom/qdsp6
This patch adds bindings required for DISPLAY_PORT_RX
port on AFE.
Signed-off-by: Rohit kumar
---
include/dt-bindings/sound/qcom,q6afe.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/sound/qcom,q6afe.h
b/include/dt-bindings/sound/qcom,q6afe.h
index e2d3892..1df06f8
Add support for Audio over display port AFE port
Rohit kumar (4):
ASoC: qdsp6: dt-bindings: Add q6afe display_port dt binding
ASoC: qdsp6: qdafe: add support for display_port_rx
ASoC: qdsp6: q6afe-dai: add support to Display port RX dais
ASoC: qdsp6: q6routing: add display_port_rx port
Headset codec is connected over PRIMARY_MI2S interface. Call
set_jack for codec associated with Primary Mi2s interface.
Also, set_jack to NULL when jack is freed.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/sdm845.c | 31 ++-
1 file changed, 22 insertions(+), 9
Hello Mark,
On 12/7/2018 1:51 AM, Mark Brown wrote:
On Wed, Nov 28, 2018 at 05:00:34PM +0800, Cheng-Yi Chiang wrote:
Add a callback for init ops on dai_link to create and setup jack.
Signed-off-by: Rohit kumar
Signed-off-by: Cheng-Yi Chiang
This looks like you're forwarding a patch
LPASS_Audio_Wrapper_AON clock is on by default. Remove
it from lpass clock list to avoid voting for it.
Signed-off-by: Rohit kumar
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree
Lpass_aon clock is on by default. Remove it from lpass
clock list to avoid voting for it.
Signed-off-by: Rohit kumar
---
drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c
b/drivers/remoteproc
1 - 100 of 182 matches
Mail list logo
